)]}'
{"glance/version.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"2e14502fcd018b5cc60d3e19ab62d674c98c71fc","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import pbr"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"version_info \u003d pbr.version.VersionInfo(\u0027glance\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Frwo%3D","line":18,"updated":"2013-04-29 09:20:41.000000000","message":"I think this should be: import pbr.version","commit_id":"530c8cd1d32d38eddfa1d08de453473233e38b44"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"aeadc7674b47ccc295f55c9b0f944213626622f8","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import pbr.version"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"version_info \u003d pbr.version.VersionInfo(\u0027glance\u0027)"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAPn%2F%2FUXQ%3D","line":18,"updated":"2013-07-04 05:28:09.000000000","message":"AFAIK, this is what makes pbr a runtime dep\n\nWe could just do a try_import thing and not report any version_info if pbr isn\u0027t installed\n\nConditional behaviour like that is a bit nasty though\n\nNova has support for an /etc/nova/release file which in Red Hat packaging would contain:\n\n [Nova]\n vendor \u003d Red Hat Inc.\n product \u003d OpenStack Nova\n package \u003d 1.el6\n\nWe could generically support something like this and include the full version number in it ... and if that file is found, not require pbr\n\nBut, then again ... if every project was to support this, it\u0027d be nice if that support was in a library and, well, pbr would be the right library :)","commit_id":"80ab594e4b034af46bba5ef64d80da4b3c05dded"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"7f14a73dc06320a6f368d07c95b6f6863f4430fe","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import pbr.version"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"version_info \u003d pbr.version.VersionInfo(\u0027glance\u0027)"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAPn%2F%2FTBc%3D","line":18,"in_reply_to":"AAAAPn%2F%2FUXQ%3D","updated":"2013-07-10 15:55:39.000000000","message":"Agree. Also, in the general scheme of libraries we have running around, every env is going to be guaranteed to have access at least to pbr, since the distros will need it for packaging anyway. So I\u0027m not sure what about the runtime dep would be nasty.\n\nWe should add the nova release file support to pbr version in a general way. And then we should consider making that be /etc/openstack/nova.release or /etc/opentack/nova/release or something - otherwise we\u0027re going to start getting in to some real etc proliferation.","commit_id":"80ab594e4b034af46bba5ef64d80da4b3c05dded"}],"setup.py":[{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"c10a0f4854c4d95829cc2915eb3862a173d7cb0c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"# Copyright (c) 2013 Hewlett-Packard Development Company, L.P."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAO3%2F%2F%2FsQ%3D","line":2,"updated":"2013-05-15 09:26:31.000000000","message":"A really minor comment/query: the old glance/openstack/common/setup.py had both Openstack and HP copyright lines. Any particular reason to remove the Openstack one here?","commit_id":"617fbdfd3aec2cb9f0f55ea0cb470d9f72dc57af"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"fc0d009134b28b90da1bca8edd102cbc1f9c51cc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"# Copyright (c) 2013 Hewlett-Packard Development Company, L.P."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAPH%2F%2F8xo%3D","line":2,"in_reply_to":"AAAAO3%2F%2F%2FsQ%3D","updated":"2013-05-17 23:16:18.000000000","message":"Because the new file doesn\u0027t share any appreciable code with the old one and isn\u0027t related to glance/openstack/common/setup.py either. (this file will pretty much never change other than possibly the versions of the requires)","commit_id":"617fbdfd3aec2cb9f0f55ea0cb470d9f72dc57af"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"74d103f4951ec548ed7889bbefcb853165eabad2","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import setuptools"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"setuptools.setup("},{"line_number":20,"context_line":"    setup_requires\u003d[\u0027d2to1\u003e\u003d0.2.10,\u003c0.3\u0027, \u0027pbr\u003e\u003d0.5.10,\u003c0.6\u0027],"},{"line_number":21,"context_line":"    d2to1\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAPH%2F%2FfBc%3D","line":20,"updated":"2013-06-01 11:14:30.000000000","message":"Would it be possible to import setup_requires from the matching lines in pip-requires? This avoids those two going out of sync accidentally.","commit_id":"da02e9af1195a938fb8829db20faac4acc6519a9"}],"tools/pip-requires":[{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"b4c0427c6d358c6c516cdef06bbd02e18955e6e3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"d2to1\u003e\u003d0.2.10,\u003c0.3"},{"line_number":2,"context_line":"pbr\u003e\u003d0.5.13,\u003c0.6"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# The greenlet package must be compiled with gcc and needs"},{"line_number":5,"context_line":"# the Python.h headers. Make sure you install the python-dev"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"AAAAPX%2F%2Fsnk%3D","line":2,"updated":"2013-06-12 16:02:04.000000000","message":"This differs from what is in pip-requires and glance won\u0027t install atm","commit_id":"4226a0dc02567d699d3754f59fc53abacd9e02cf"}]}
