)]}'
{"glance/tests/functional/__init__.py":[{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"736e024ea70bb2e148a1d520e1f061ecff99bbf5","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                conf_file.write(\u0027sql_connection \u003d %s\u0027 % self.sql_connection)"},{"line_number":197,"context_line":"                conf_file.flush()"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"            glance_db_env \u003d \u0027GLANCE_DB_TEST_SQLITE_FILE\u0027"},{"line_number":200,"context_line":"            if glance_db_env in os.environ:"},{"line_number":201,"context_line":"                db_location \u003d os.environ[glance_db_env]"},{"line_number":202,"context_line":"                os.system(\u0027cp %s %s/tests.sqlite\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fv44%3D","line":199,"updated":"2013-04-24 22:58:06.000000000","message":"May want to note exactly what you are doing here. Wouldn\u0027t want this to get changed and tests start taking forever (again).\n\nMaybe just say \"create empty db to reuse in tests\" or break it up into some private functions just to make it a little clearer","commit_id":"cb9468b34cc216a581597e65a0ef2bee1f247dfd"},{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"f2956f0cb483738f3ffa34e25f482b01238ae142","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                conf_file.write(\u0027sql_connection \u003d %s\u0027 % self.sql_connection)"},{"line_number":197,"context_line":"                conf_file.flush()"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"            glance_db_env \u003d \u0027GLANCE_DB_TEST_SQLITE_FILE\u0027"},{"line_number":200,"context_line":"            if glance_db_env in os.environ:"},{"line_number":201,"context_line":"                db_location \u003d os.environ[glance_db_env]"},{"line_number":202,"context_line":"                os.system(\u0027cp %s %s/tests.sqlite\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fvzo%3D","line":199,"in_reply_to":"AAAAOn%2F%2Fv44%3D","updated":"2013-04-25 00:00:29.000000000","message":"I think this var is being set to communicate with later Functional tests in a given test run, not to enable/disable some optional behavior. Does that change your thoughts about the variable name?","commit_id":"cb9468b34cc216a581597e65a0ef2bee1f247dfd"},{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"e88a45a70f176334f19335794d7fa21ee736a3aa","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                def _delete_cached_db():"},{"line_number":217,"context_line":"                    try:"},{"line_number":218,"context_line":"                        os.remove(os.environ[glance_db_env])"},{"line_number":219,"context_line":"                    except:"},{"line_number":220,"context_line":"                        pass"},{"line_number":221,"context_line":"                atexit.register(_delete_cached_db)"},{"line_number":222,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fv7I%3D","line":219,"updated":"2013-04-24 22:19:05.000000000","message":"Instinct tells me to worry about this bare except, but this does seem like a very unlikely case to cause a problem.","commit_id":"cb9468b34cc216a581597e65a0ef2bee1f247dfd"},{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"32121455192e70f7625a380f02840618b3b4f18a","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                def _delete_cached_db():"},{"line_number":224,"context_line":"                    try:"},{"line_number":225,"context_line":"                        os.remove(os.environ[glance_db_env])"},{"line_number":226,"context_line":"                    except:"},{"line_number":227,"context_line":"                        glance_tests.logger.exception("},{"line_number":228,"context_line":"                            \"Error cleaning up the file %s\" %"},{"line_number":229,"context_line":"                            os.environ[glance_db_env])"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fvzg%3D","line":226,"updated":"2013-04-25 00:01:37.000000000","message":"Logging addition is great, but I was thinking we need to do \"except Exception:\" rather than just a bare \"except:\" to avoid it catching things like KeyboardInterrupt or SystemExit","commit_id":"811eed01fc824691179ec0081e39866b227b705b"}]}