)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"fae2c0fb81f5ed13a61677de9162e652ff256e6c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"glance-manage db purge failure for limit"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some verions of MySQL doesn\u0027t yet support subquery with"},{"line_number":10,"context_line":"\u0027LIMIT \u0026 IN/ALL/ANY/SOME\u0027 which causes glance-manage db purge"},{"line_number":11,"context_line":"command failure."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5aef4532_e08db37c","line":9,"updated":"2016-03-07 20:01:13.000000000","message":"I don\u0027t think it was ever supported by MySQL. Mind changing the commit msg ?\n\n\"MySQL does not support LIMIT in subqueries for certain subquery operators\" Ref :-\nhttps://dev.mysql.com/doc/mysql-reslimits-excerpt/5.7/en/subquery-restrictions.html","commit_id":"ea39ebf68e0ed5b5d332018597eaf4afbfb5af26"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"c3fae87da992575c52a98b6f369564b5dba4649a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"glance-manage db purge failure for limit"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some verions of MySQL doesn\u0027t yet support subquery with"},{"line_number":10,"context_line":"\u0027LIMIT \u0026 IN/ALL/ANY/SOME\u0027 which causes glance-manage db purge"},{"line_number":11,"context_line":"command failure."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5aef4532_e2f5a583","line":9,"in_reply_to":"5aef4532_99ca6aa0","updated":"2016-03-08 05:58:58.000000000","message":"Done","commit_id":"ea39ebf68e0ed5b5d332018597eaf4afbfb5af26"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"87238b968c8fee0110a86bd5c1c763f83324b7ba","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"glance-manage db purge failure for limit"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some verions of MySQL doesn\u0027t yet support subquery with"},{"line_number":10,"context_line":"\u0027LIMIT \u0026 IN/ALL/ANY/SOME\u0027 which causes glance-manage db purge"},{"line_number":11,"context_line":"command failure."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5aef4532_99ca6aa0","line":9,"in_reply_to":"5aef4532_c0db57ec","updated":"2016-03-08 00:15:09.000000000","message":"To nit pick it just says \"This version of MySQL..\" :D.","commit_id":"ea39ebf68e0ed5b5d332018597eaf4afbfb5af26"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"3ecf00d8ae7e0a0dfebb929cbd5eea2ccf1c10f6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"glance-manage db purge failure for limit"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some verions of MySQL doesn\u0027t yet support subquery with"},{"line_number":10,"context_line":"\u0027LIMIT \u0026 IN/ALL/ANY/SOME\u0027 which causes glance-manage db purge"},{"line_number":11,"context_line":"command failure."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5aef4532_c0db57ec","line":9,"in_reply_to":"5aef4532_e08db37c","updated":"2016-03-07 20:53:05.000000000","message":"I guess that description is coming from the MySQL error message itself :)","commit_id":"ea39ebf68e0ed5b5d332018597eaf4afbfb5af26"}],"glance/db/sqlalchemy/api.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"e74285f16c8918d3b4d8cbe68f389cfe6dd16ad9","unresolved":false,"context_lines":[{"line_number":1242,"context_line":"        self.column \u003d column"},{"line_number":1243,"context_line":""},{"line_number":1244,"context_line":""},{"line_number":1245,"context_line":"# NOTE(abhishekk): some versions of MySQL doesn\u0027t yet support subquery with"},{"line_number":1246,"context_line":"# \u0027LIMIT \u0026 IN/ALL/ANY/SOME\u0027 We need work around this with nesting select."},{"line_number":1247,"context_line":"@compiles(DeleteFromSelect)"},{"line_number":1248,"context_line":"def visit_delete_from_select(element, compiler, **kw):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_359ed856","line":1245,"updated":"2016-02-19 13:42:47.000000000","message":"Could you specify which versions? Are these old versions? Older than the one we run on the gate?","commit_id":"0ee0c4baf973a3166ea8deda79de14ebb16c47ad"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"06d74df868ad681ce295f336c8d02726fc959b8c","unresolved":false,"context_lines":[{"line_number":1242,"context_line":"        self.column \u003d column"},{"line_number":1243,"context_line":""},{"line_number":1244,"context_line":""},{"line_number":1245,"context_line":"# NOTE(abhishekk): some versions of MySQL doesn\u0027t yet support subquery with"},{"line_number":1246,"context_line":"# \u0027LIMIT \u0026 IN/ALL/ANY/SOME\u0027 We need work around this with nesting select."},{"line_number":1247,"context_line":"@compiles(DeleteFromSelect)"},{"line_number":1248,"context_line":"def visit_delete_from_select(element, compiler, **kw):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_9b02753d","line":1245,"in_reply_to":"bae84128_359ed856","updated":"2016-02-19 14:17:41.000000000","message":"Hi Flavio,\n\nI am not sure about the gate but even the latest mysql release has these restictions. Kindly check: http://dev.mysql.com/doc/refman/5.7/en/subquery-restrictions.html","commit_id":"0ee0c4baf973a3166ea8deda79de14ebb16c47ad"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"87238b968c8fee0110a86bd5c1c763f83324b7ba","unresolved":false,"context_lines":[{"line_number":1298,"context_line":"            continue"},{"line_number":1299,"context_line":"        if hasattr(model_class, \u0027deleted\u0027):"},{"line_number":1300,"context_line":"            tables.append(model_class.__tablename__)"},{"line_number":1301,"context_line":"    # get rid of FX constraints"},{"line_number":1302,"context_line":"    for tbl in (\u0027images\u0027, \u0027tasks\u0027):"},{"line_number":1303,"context_line":"        try:"},{"line_number":1304,"context_line":"            tables.remove(tbl)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_b8a11bac","line":1301,"updated":"2016-03-08 00:15:09.000000000","message":"Are we ? \n\nI hit SQL integrity error when trying to purge db records as the ForeignKeyConstraints are still present. Does this whole command work for you with the data ? I know it works fine on an empty dataset :D. \n\nI don\u0027t see where we are getting rid of the constraints. May be this cmd never worked ?","commit_id":"ea39ebf68e0ed5b5d332018597eaf4afbfb5af26"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"853966bd6849fc06cae1fd58a55e068674080df1","unresolved":false,"context_lines":[{"line_number":1298,"context_line":"            continue"},{"line_number":1299,"context_line":"        if hasattr(model_class, \u0027deleted\u0027):"},{"line_number":1300,"context_line":"            tables.append(model_class.__tablename__)"},{"line_number":1301,"context_line":"    # get rid of FX constraints"},{"line_number":1302,"context_line":"    for tbl in (\u0027images\u0027, \u0027tasks\u0027):"},{"line_number":1303,"context_line":"        try:"},{"line_number":1304,"context_line":"            tables.remove(tbl)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_582a607f","line":1301,"in_reply_to":"5aef4532_82d30138","updated":"2016-03-08 21:52:37.000000000","message":"Abhishek has reported LP bug [1] for fixing integrity issue.\n\n[1] : https://bugs.launchpad.net/glance/+bug/1554412","commit_id":"ea39ebf68e0ed5b5d332018597eaf4afbfb5af26"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"c3fae87da992575c52a98b6f369564b5dba4649a","unresolved":false,"context_lines":[{"line_number":1298,"context_line":"            continue"},{"line_number":1299,"context_line":"        if hasattr(model_class, \u0027deleted\u0027):"},{"line_number":1300,"context_line":"            tables.append(model_class.__tablename__)"},{"line_number":1301,"context_line":"    # get rid of FX constraints"},{"line_number":1302,"context_line":"    for tbl in (\u0027images\u0027, \u0027tasks\u0027):"},{"line_number":1303,"context_line":"        try:"},{"line_number":1304,"context_line":"            tables.remove(tbl)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_82d30138","line":1301,"in_reply_to":"5aef4532_b8a11bac","updated":"2016-03-08 05:58:58.000000000","message":"Hi Sabari,\n\nIMO this command never worked, I am also getting integrity error. I have a fix for it and I will report this issue in launchpad and propose a fix for this ASAP.","commit_id":"ea39ebf68e0ed5b5d332018597eaf4afbfb5af26"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"3ecf00d8ae7e0a0dfebb929cbd5eea2ccf1c10f6","unresolved":false,"context_lines":[{"line_number":1319,"context_line":"        deleted_at_column \u003d tab.c.deleted_at"},{"line_number":1320,"context_line":""},{"line_number":1321,"context_line":"        query_delete \u003d sql.select("},{"line_number":1322,"context_line":"            [column], deleted_at_column \u003c deleted_age).limit(max_rows)"},{"line_number":1323,"context_line":""},{"line_number":1324,"context_line":"        delete_statement \u003d DeleteFromSelect(tab, query_delete, column)"},{"line_number":1325,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_be862cb7","line":1322,"range":{"start_line":1322,"start_character":60,"end_line":1322,"end_character":61},"updated":"2016-03-07 20:53:05.000000000","message":"Can we sort here on deleted_at in ascending order so that we are always deleting the oldest records first? And it is also probably more explicit as to what rows one expects to see deleted?\n\nFeel free to say it doesn\u0027t belong in this patch :)","commit_id":"ea39ebf68e0ed5b5d332018597eaf4afbfb5af26"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"c3fae87da992575c52a98b6f369564b5dba4649a","unresolved":false,"context_lines":[{"line_number":1319,"context_line":"        deleted_at_column \u003d tab.c.deleted_at"},{"line_number":1320,"context_line":""},{"line_number":1321,"context_line":"        query_delete \u003d sql.select("},{"line_number":1322,"context_line":"            [column], deleted_at_column \u003c deleted_age).limit(max_rows)"},{"line_number":1323,"context_line":""},{"line_number":1324,"context_line":"        delete_statement \u003d DeleteFromSelect(tab, query_delete, column)"},{"line_number":1325,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_42f299d3","line":1322,"range":{"start_line":1322,"start_character":60,"end_line":1322,"end_character":61},"in_reply_to":"5aef4532_be862cb7","updated":"2016-03-08 05:58:58.000000000","message":"Hi Hemanth,\n\nLet me check on this, if it is ok to make this changes in same patch then I will go for it.","commit_id":"ea39ebf68e0ed5b5d332018597eaf4afbfb5af26"}]}
