)]}'
{"glance/common/wsgi.py":[{"author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"change_message_id":"e7c773055ef86462e1f9d6a2b286248e1c88928d","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    cfg.IntOpt(\u0027workers\u0027, default\u003d-1,"},{"line_number":82,"context_line":"               help\u003d_(\u0027The number of child process workers that will be \u0027"},{"line_number":83,"context_line":"                      \u0027created to service requests. The default will be \u0027"},{"line_number":84,"context_line":"                      \u0027equal to the number of CPUs available.\u0027)),"},{"line_number":85,"context_line":"    cfg.IntOpt(\u0027max_header_line\u0027, default\u003d16384,"},{"line_number":86,"context_line":"               help\u003d_(\u0027Maximum line size of message headers to be accepted. \u0027"},{"line_number":87,"context_line":"                      \u0027max_header_line may need to be increased when using \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_b8f731f4","line":84,"updated":"2016-02-16 14:49:16.000000000","message":"I suggest adding here what -1 means, so people setting the values understand.","commit_id":"66bb59126c7b270063c8400240842e0130053f0d"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"651a62acf2fb27442fd27007182da8a0581d0009","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    cfg.IntOpt(\u0027workers\u0027, default\u003d-1,"},{"line_number":82,"context_line":"               help\u003d_(\u0027The number of child process workers that will be \u0027"},{"line_number":83,"context_line":"                      \u0027created to service requests. The default will be \u0027"},{"line_number":84,"context_line":"                      \u0027equal to the number of CPUs available.\u0027)),"},{"line_number":85,"context_line":"    cfg.IntOpt(\u0027max_header_line\u0027, default\u003d16384,"},{"line_number":86,"context_line":"               help\u003d_(\u0027Maximum line size of message headers to be accepted. \u0027"},{"line_number":87,"context_line":"                      \u0027max_header_line may need to be increased when using \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_de081830","line":84,"in_reply_to":"dae33548_b8f731f4","updated":"2016-02-16 16:48:30.000000000","message":"Would it be slightly more pythonic to just not set the default explicitly? Like we do for bind_port above (line 60). And then check for None below.\n\nIt seems to be what nova do:\n\n    cfg.IntOpt(\u0027osapi_compute_workers\u0027,\n               help\u003d\u0027Number of workers for OpenStack API service. The default \u0027\n                    \u0027will be the number of CPUs available.\u0027),","commit_id":"66bb59126c7b270063c8400240842e0130053f0d"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"5cc1b6e599843878701423b60cadb0948e638a58","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    cfg.IntOpt(\u0027workers\u0027, default\u003d-1,"},{"line_number":82,"context_line":"               help\u003d_(\u0027The number of child process workers that will be \u0027"},{"line_number":83,"context_line":"                      \u0027created to service requests. The default will be \u0027"},{"line_number":84,"context_line":"                      \u0027equal to the number of CPUs available.\u0027)),"},{"line_number":85,"context_line":"    cfg.IntOpt(\u0027max_header_line\u0027, default\u003d16384,"},{"line_number":86,"context_line":"               help\u003d_(\u0027Maximum line size of message headers to be accepted. \u0027"},{"line_number":87,"context_line":"                      \u0027max_header_line may need to be increased when using \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_1431c1ec","line":84,"in_reply_to":"dae33548_de081830","updated":"2016-02-16 16:59:25.000000000","message":"+1 for Stuart\u0027s suggestion. -1 is a confused number for this config. No default is better, IMHO.","commit_id":"66bb59126c7b270063c8400240842e0130053f0d"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"5cc1b6e599843878701423b60cadb0948e638a58","unresolved":false,"context_lines":[{"line_number":121,"context_line":"CONF.register_opts(socket_opts)"},{"line_number":122,"context_line":"CONF.register_opts(eventlet_opts)"},{"line_number":123,"context_line":"CONF.register_opts(profiler_opts, group\u003d\"profiler\")"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"ASYNC_EVENTLET_THREAD_POOL_LIST \u003d []"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_145f010f","line":124,"updated":"2016-02-16 16:59:25.000000000","message":"(nit): Remove this?","commit_id":"66bb59126c7b270063c8400240842e0130053f0d"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"df74ea85a3148315289ef761889d3abedddcb1ae","unresolved":false,"context_lines":[{"line_number":78,"context_line":"]"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"eventlet_opts \u003d ["},{"line_number":81,"context_line":"    cfg.IntOpt(\u0027workers\u0027, default\u003dNone,"},{"line_number":82,"context_line":"               help\u003d_(\u0027The number of child process workers that will be \u0027"},{"line_number":83,"context_line":"                      \u0027created to service requests. The default will be \u0027"},{"line_number":84,"context_line":"                      \u0027equal to the number of CPUs available.\u0027)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_b25e2574","line":81,"range":{"start_line":81,"start_character":26,"end_line":81,"end_character":38},"updated":"2016-02-16 17:43:11.000000000","message":"nit: I\u0027d prefer this to be consistent with ca_file, cert_file, key_file, bind_port (and all our other \u0027None\u0027 options elsewhere). It\u0027s one of the few things we seem to be consistent on :-)","commit_id":"999b2c2b78893a06fc3cc1f627be2fc74894c8ce"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"f4f29032e0f532f8f4742f404d61899c87e9a1a6","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        # processutils.get_worker_count(), but we only set it here in order to"},{"line_number":308,"context_line":"        # avoid generating a non-reproducible glance-api.conf file."},{"line_number":309,"context_line":"        if CONF.workers is None:"},{"line_number":310,"context_line":"            CONF.workers \u003d processutils.get_worker_count()"},{"line_number":311,"context_line":"        if CONF.workers \u003d\u003d 0:"},{"line_number":312,"context_line":"            # Useful for profiling, test, debug etc."},{"line_number":313,"context_line":"            self.pool \u003d self.create_pool()"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_454d2cc3","line":310,"range":{"start_line":310,"start_character":12,"end_line":310,"end_character":24},"updated":"2016-02-17 10:22:20.000000000","message":"We probably should treat CONF as a read only view of the configuration, ie not set it ourselves.","commit_id":"e8af9e2827f956ef168ac58100eac4dc4c25b057"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"dd96151cf9974b28012e404079a217e1c474cb71","unresolved":false,"context_lines":[{"line_number":311,"context_line":"        self.start_wsgi()"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    def start_wsgi(self):"},{"line_number":314,"context_line":"        if get_num_workers() \u003d\u003d 0:"},{"line_number":315,"context_line":"            # Useful for profiling, test, debug etc."},{"line_number":316,"context_line":"            self.pool \u003d self.create_pool()"},{"line_number":317,"context_line":"            self.pool.spawn_n(self._single_run, self.application, self.sock)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_59c355ed","line":314,"updated":"2016-02-17 11:37:46.000000000","message":"Just one minor style nit:\nInstead of calling get_worker_count each time we could introduce a variable:\nnum_workers \u003d get_num_workers()\nand use that variable everywhere.","commit_id":"56184f0f4d05710f51ab1726b63e892c48e10458"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"7fec807d24de9c0566fcb621d2c89cd5344bd84b","unresolved":false,"context_lines":[{"line_number":311,"context_line":"        self.start_wsgi()"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    def start_wsgi(self):"},{"line_number":314,"context_line":"        if get_num_workers() \u003d\u003d 0:"},{"line_number":315,"context_line":"            # Useful for profiling, test, debug etc."},{"line_number":316,"context_line":"            self.pool \u003d self.create_pool()"},{"line_number":317,"context_line":"            self.pool.spawn_n(self._single_run, self.application, self.sock)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_4b689687","line":314,"in_reply_to":"dae33548_549cbc0e","updated":"2016-02-17 12:18:18.000000000","message":"Yep, that I was talking about. Only this function.","commit_id":"56184f0f4d05710f51ab1726b63e892c48e10458"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"54f113bbeb9d82491097719c3baed74bfc63dc07","unresolved":false,"context_lines":[{"line_number":311,"context_line":"        self.start_wsgi()"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    def start_wsgi(self):"},{"line_number":314,"context_line":"        if get_num_workers() \u003d\u003d 0:"},{"line_number":315,"context_line":"            # Useful for profiling, test, debug etc."},{"line_number":316,"context_line":"            self.pool \u003d self.create_pool()"},{"line_number":317,"context_line":"            self.pool.spawn_n(self._single_run, self.application, self.sock)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_549cbc0e","line":314,"in_reply_to":"dae33548_59c355ed","updated":"2016-02-17 11:52:14.000000000","message":"I could do that for this function and still call the function for _verify_and_respawn_children","commit_id":"56184f0f4d05710f51ab1726b63e892c48e10458"}]}