)]}'
{"glance/notifier/notify_log.py":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"ee490eb7d8d8d8bbc5b3123641e69a26871e2aad","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    \"\"\"A notifier that calls logging when called.\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def __init__(self, conf):"},{"line_number":27,"context_line":"        self.logger \u003d logging.getLogger(\u0027glance.notifier.logging_notifier\u0027)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def warn(self, msg):"},{"line_number":30,"context_line":"        self.logger.warn(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAD3%2F%2F%2FjE%3D","line":27,"updated":"2012-01-10 02:45:45.000000000","message":"We typically use the module name when creating loggers.\n\nShould this be \u0027glance.notifier.notify_log\u0027 instead?","commit_id":"f8ae3c4995d8716c46750e3715532e3086a2645a"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"27d1d67664ceddc7390c042b781e40730a48eaa0","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    \"\"\"A notifier that calls logging when called.\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def __init__(self, conf):"},{"line_number":27,"context_line":"        self.logger \u003d logging.getLogger(\u0027glance.notifier.logging_notifier\u0027)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def warn(self, msg):"},{"line_number":30,"context_line":"        self.logger.warn(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAD3%2F%2F%2FeM%3D","line":27,"in_reply_to":"AAAAD3%2F%2F%2FjE%3D","updated":"2012-01-10 15:26:47.000000000","message":"That\u0027s fine with me, but this isn\u0027t new.  It\u0027s just copied from where the code was before, so perhaps it\u0027d be better as a followup patch to specifically call out the change in behavior?","commit_id":"f8ae3c4995d8716c46750e3715532e3086a2645a"}]}