)]}'
{"glance/tests/functional/glare/test_glare.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"98f5c22def9e26231f93d8a45a6494bec6f3c847","unresolved":false,"context_lines":[{"line_number":859,"context_line":"            data\u003d[{\u0027value\u0027: no_prop_art[\u0027id\u0027],"},{"line_number":860,"context_line":"                   \u0027op\u0027: \u0027replace\u0027,"},{"line_number":861,"context_line":"                   \u0027path\u0027: \u0027/depends_on\u0027}])"},{"line_number":862,"context_line":"        self.assertTrue(art_updated[\u0027depends_on\u0027])"},{"line_number":863,"context_line":"        # artifact can\u0027t be published if any dependency is in non-active state"},{"line_number":864,"context_line":"        res \u003d self._check_artifact_post("},{"line_number":865,"context_line":"            \u0027/withprops/v1/%s/publish\u0027 % art[\u0027id\u0027], {}, status\u003d400)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_d8e3f631","line":862,"updated":"2016-02-28 21:13:54.000000000","message":"If we\u0027re changing this one, I\u0027d rather change it to something that verifies that the list is not empty but in a more explicit way. Perhaps checking the number of items in the list.","commit_id":"38d946c7efcfa103c1dd83e97b2071af6067833a"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"24dab585d186a2d1d1ba665b9a877a64e904cb3e","unresolved":false,"context_lines":[{"line_number":859,"context_line":"            data\u003d[{\u0027value\u0027: no_prop_art[\u0027id\u0027],"},{"line_number":860,"context_line":"                   \u0027op\u0027: \u0027replace\u0027,"},{"line_number":861,"context_line":"                   \u0027path\u0027: \u0027/depends_on\u0027}])"},{"line_number":862,"context_line":"        self.assertTrue(art_updated[\u0027depends_on\u0027])"},{"line_number":863,"context_line":"        # artifact can\u0027t be published if any dependency is in non-active state"},{"line_number":864,"context_line":"        res \u003d self._check_artifact_post("},{"line_number":865,"context_line":"            \u0027/withprops/v1/%s/publish\u0027 % art[\u0027id\u0027], {}, status\u003d400)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_18ba7ec0","line":862,"in_reply_to":"9aed3d3a_d8e3f631","updated":"2016-02-28 21:31:28.000000000","message":"I think the change can\u0027t make it clear but the reverse. The change will make the reviewer think rt_updated[\u0027depends_on\u0027] is a boolean.","commit_id":"38d946c7efcfa103c1dd83e97b2071af6067833a"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"c835c38392b17596501b5568918a776339698742","unresolved":false,"context_lines":[{"line_number":859,"context_line":"            data\u003d[{\u0027value\u0027: no_prop_art[\u0027id\u0027],"},{"line_number":860,"context_line":"                   \u0027op\u0027: \u0027replace\u0027,"},{"line_number":861,"context_line":"                   \u0027path\u0027: \u0027/depends_on\u0027}])"},{"line_number":862,"context_line":"        self.assertGreater(len(art_updated[\u0027depends_on\u0027]), 0)"},{"line_number":863,"context_line":"        # artifact can\u0027t be published if any dependency is in non-active state"},{"line_number":864,"context_line":"        res \u003d self._check_artifact_post("},{"line_number":865,"context_line":"            \u0027/withprops/v1/%s/publish\u0027 % art[\u0027id\u0027], {}, status\u003d400)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_cc4ba2af","line":862,"range":{"start_line":862,"start_character":13,"end_line":862,"end_character":26},"updated":"2016-03-01 17:02:14.000000000","message":"why not assertNotEqual?","commit_id":"fa78ba158af2c3d36ef2f4f9899fc5decde2c580"}]}