)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"f1d89ef070537b7809645db49d194fc8217d35e4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Niall Bunting \u003cniall.bunting@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-02 15:53:35 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding member in a list causes 500"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change catches a type error that can be raised if a user mistakenly"},{"line_number":10,"context_line":"uses a list over a dict."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7af24918_60cc3f89","line":7,"updated":"2016-03-04 12:12:05.000000000","message":"Could you update the commit message to reflect Addition and Updates ?","commit_id":"bacf3233561d22966471aaeaa16dfa45262bb63b"}],"glance/api/v2/image_members.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"973e4bf2c385c8cedbd165cf4769d100184890ae","unresolved":false,"context_lines":[{"line_number":256,"context_line":"            msg \u003d _(\"Member can\u0027t be empty\")"},{"line_number":257,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":258,"context_line":"        except TypeError:"},{"line_number":259,"context_line":"            msg \u003d _(\"Please use a dict to supply the member.\")"},{"line_number":260,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":261,"context_line":"        return dict(member_id\u003dmember_id)"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_5381f549","line":259,"updated":"2016-03-01 16:07:30.000000000","message":"What about we make the message something like:\n\n    \"Expected a member in the form of `{....}`\"\n\nOr something along those lines. Providing an example is generally better.","commit_id":"82c247415981f2be7b15c26cb5e65d2e9e0660b3"},{"author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"change_message_id":"c41473a4e944151a538d5070ee77427b3d82a18f","unresolved":false,"context_lines":[{"line_number":256,"context_line":"            msg \u003d _(\"Member can\u0027t be empty\")"},{"line_number":257,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":258,"context_line":"        except TypeError:"},{"line_number":259,"context_line":"            msg \u003d _(\"Please use a dict to supply the member.\")"},{"line_number":260,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":261,"context_line":"        return dict(member_id\u003dmember_id)"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_ecdbfe19","line":259,"in_reply_to":"7af24918_5381f549","updated":"2016-03-01 16:51:57.000000000","message":"Done","commit_id":"82c247415981f2be7b15c26cb5e65d2e9e0660b3"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"99d502b2fda3f8e4aaaf1dda0d53b58210a94343","unresolved":false,"context_lines":[{"line_number":257,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":258,"context_line":"        except TypeError:"},{"line_number":259,"context_line":"            msg \u003d _(\u0027Expected a member in the form of \u0027"},{"line_number":260,"context_line":"                    \u0027`{\"member\": \"image_id\"}`.\u0027)"},{"line_number":261,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":262,"context_line":"        return dict(member_id\u003dmember_id)"},{"line_number":263,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_78731ab2","line":260,"updated":"2016-03-01 21:16:03.000000000","message":"Is it a standard thing to use backticks like this in exception messages?","commit_id":"9c9ae02ce54d353e85e84d8e5ab24eb10125785b"},{"author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"change_message_id":"26c0c8d8a9a6b557c26cb69a41c93a9e3dc06ded","unresolved":false,"context_lines":[{"line_number":257,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":258,"context_line":"        except TypeError:"},{"line_number":259,"context_line":"            msg \u003d _(\u0027Expected a member in the form of \u0027"},{"line_number":260,"context_line":"                    \u0027`{\"member\": \"image_id\"}`.\u0027)"},{"line_number":261,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":262,"context_line":"        return dict(member_id\u003dmember_id)"},{"line_number":263,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_e71be519","line":260,"in_reply_to":"7af24918_78731ab2","updated":"2016-03-02 10:21:54.000000000","message":"Looking through the code there does not seem to be a huge amount of examples of this. But I think it may look nicer without the backticks.","commit_id":"9c9ae02ce54d353e85e84d8e5ab24eb10125785b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"101fb46bded9b32cf34ffd0723dfaa2e2b524420","unresolved":false,"context_lines":[{"line_number":257,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":258,"context_line":"        except TypeError:"},{"line_number":259,"context_line":"            msg \u003d _(\u0027Expected a member in the form of \u0027"},{"line_number":260,"context_line":"                    \u0027{\"member\": \"image_id\"}.\u0027)"},{"line_number":261,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":262,"context_line":"        return dict(member_id\u003dmember_id)"},{"line_number":263,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_a906bdcb","line":260,"updated":"2016-03-02 15:48:55.000000000","message":"You\u0027re going to kill me, but how about:\n\n    \u0027Expected a member in the form: \u0027\n    \u0027{\"member\": \"image_id\"}\u0027\n\n(I like the \u0027:\u0027 better than \u0027of\u0027, it indicates that you\u0027re about to display something.)\n\nBut I didn\u0027t really mean for you to remove the quotes around the example, just maybe use \"regular\" quotes instead of the backticks:\n\n    \u0027Expected a member in the form: \u0027\n    \u0027\\\u0027{\"member\": \"image_id\"}\\\u0027\u0027\n\nBut, also, it was an actual question.  I don\u0027t think I\u0027ve seen backticks in messages much, but maybe that\u0027s OK.","commit_id":"b88e80a2515ce8efa58e5efe7a5454d88c72d383"},{"author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"change_message_id":"bea7aba3cc4c73e3e85d6cbeb7a44918d4bf4d02","unresolved":false,"context_lines":[{"line_number":257,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":258,"context_line":"        except TypeError:"},{"line_number":259,"context_line":"            msg \u003d _(\u0027Expected a member in the form of \u0027"},{"line_number":260,"context_line":"                    \u0027{\"member\": \"image_id\"}.\u0027)"},{"line_number":261,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":262,"context_line":"        return dict(member_id\u003dmember_id)"},{"line_number":263,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_f46ffcc2","line":260,"in_reply_to":"7af24918_6995d5dc","updated":"2016-03-02 15:55:24.000000000","message":"I\u0027m not sure about the quotes but my typical way of dealing with it is that if its at the end of a sentence you don\u0027t really need them especially after a colon.","commit_id":"b88e80a2515ce8efa58e5efe7a5454d88c72d383"},{"author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"change_message_id":"38b1f324179a44f25f90909cfa031f37fa39d84d","unresolved":false,"context_lines":[{"line_number":257,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":258,"context_line":"        except TypeError:"},{"line_number":259,"context_line":"            msg \u003d _(\u0027Expected a member in the form of \u0027"},{"line_number":260,"context_line":"                    \u0027{\"member\": \"image_id\"}.\u0027)"},{"line_number":261,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":262,"context_line":"        return dict(member_id\u003dmember_id)"},{"line_number":263,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_6995d5dc","line":260,"in_reply_to":"7af24918_a906bdcb","updated":"2016-03-02 15:52:47.000000000","message":"Okay i\u0027ll go with that. I don\u0027t think many back ticks are used at all so it may be best to leave them out.","commit_id":"b88e80a2515ce8efa58e5efe7a5454d88c72d383"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7906d6142a40d2c7ce920fad62c867dbf4e97cef","unresolved":false,"context_lines":[{"line_number":257,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":258,"context_line":"        except TypeError:"},{"line_number":259,"context_line":"            msg \u003d _(\u0027Expected a member in the form of \u0027"},{"line_number":260,"context_line":"                    \u0027{\"member\": \"image_id\"}.\u0027)"},{"line_number":261,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":262,"context_line":"        return dict(member_id\u003dmember_id)"},{"line_number":263,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_013ce5c6","line":260,"in_reply_to":"7af24918_f46ffcc2","updated":"2016-03-02 16:12:23.000000000","message":"That works for me ... good compromise.","commit_id":"b88e80a2515ce8efa58e5efe7a5454d88c72d383"}]}