)]}'
{"glance/cmd/manage.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"00fc3690b143eb757b54a17413c8ab388c6ff405","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                print(_(\"Version must be an integer.\"))"},{"line_number":128,"context_line":"                sys.exit(1)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"            if version \u003e db.MAX_INT:"},{"line_number":131,"context_line":"                print(_(\"Version should be less than or equal to \""},{"line_number":132,"context_line":"                        \"%(max_version)d.\") % {\"max_version\": db.MAX_INT})"},{"line_number":133,"context_line":"                sys.exit(1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_58e75212","line":130,"updated":"2016-03-28 19:02:00.000000000","message":"This may be a dumb question, but why don\u0027t you do a similar check on current_version?","commit_id":"100174aeb8b56dd893f6802f001d47938ddd4294"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"0a60bed8861c379aed84764d4ada15814a84efb5","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            except ValueError:"},{"line_number":120,"context_line":"                sys.exit(_(\"Current version must be an integer.\"))"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"            if current_version \u003e db.MAX_INT:"},{"line_number":123,"context_line":"                sys.exit(_(\"Current version should be less than or equal to \""},{"line_number":124,"context_line":"                           \"%(max_version)d.\") % {\"max_version\": db.MAX_INT})"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_920ae977","line":122,"range":{"start_line":122,"start_character":36,"end_line":122,"end_character":43},"updated":"2016-03-30 17:51:04.000000000","message":"Can we use the current version from db instead?","commit_id":"7d4b48f2de93832f9ee2290a043d4846f866786d"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"37e6668aa0dc49d1186fd6abb43e69081955c34c","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            except ValueError:"},{"line_number":120,"context_line":"                sys.exit(_(\"Current version must be an integer.\"))"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"            if current_version \u003e db.MAX_INT:"},{"line_number":123,"context_line":"                sys.exit(_(\"Current version should be less than or equal to \""},{"line_number":124,"context_line":"                           \"%(max_version)d.\") % {\"max_version\": db.MAX_INT})"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_079cf067","line":122,"range":{"start_line":122,"start_character":36,"end_line":122,"end_character":43},"in_reply_to":"ba0121b8_920ae977","updated":"2016-04-06 05:40:25.000000000","message":"Hi Hemanth,\n\nGlance has given provision to sync database from the version(current_version) admin wants to.\nWe should not validate current_version with actual current db version because that condition\nwill not allow user to sync db from the version(current_version) he wants when creating database for \nthe first time where current db version is 0(zero).\n\nFor ex:\nAssume creating database for the first time where current db version is 0.\ncommand: glance-manage db sync 47 5  #47\u003dversion to sync up to, 5\u003dcurrent_version to start from\n\nIf current_version \u003e current_db_version: error\nThis condition will throw error and will not allow user to sync db from 5.\n\nIf no current_version is given by the user by default it takes 0 for current_version.","commit_id":"7d4b48f2de93832f9ee2290a043d4846f866786d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"49176496e486b0dfc056de48fa901f130cbfd03d","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"            if version \u003e db.MAX_INT:"},{"line_number":133,"context_line":"                sys.exit(_(\"Version should be less than or equal to \""},{"line_number":134,"context_line":"                           \"%(max_version)d.\") % {\"max_version\": db.MAX_INT})"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        if current_version not in (None, \u0027None\u0027):"},{"line_number":137,"context_line":"            migration.db_version_control(db_api.get_engine(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_2532b95f","line":134,"range":{"start_line":134,"start_character":30,"end_line":134,"end_character":41},"updated":"2016-03-30 18:01:39.000000000","message":"This is kind of a nit, but this isn\u0027t really the max version number, it\u0027s the maximum possible version number expressible as a signed 32 bit int.  (It\u0027s slightly misleading, I thought at first you had somehow determined max migration version number.)  I\u0027d suggest changing the placeholder to max_int and change \"should be\" to \"must be\" in the message.","commit_id":"7d4b48f2de93832f9ee2290a043d4846f866786d"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"bf88ad6a90cfcc7e7eed159895bbcaeff73d5913","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"            if version \u003e db.MAX_INT:"},{"line_number":133,"context_line":"                sys.exit(_(\"Version should be less than or equal to \""},{"line_number":134,"context_line":"                           \"%(max_version)d.\") % {\"max_version\": db.MAX_INT})"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        if current_version not in (None, \u0027None\u0027):"},{"line_number":137,"context_line":"            migration.db_version_control(db_api.get_engine(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_1e56c9cd","line":134,"range":{"start_line":134,"start_character":30,"end_line":134,"end_character":41},"in_reply_to":"ba0121b8_2532b95f","updated":"2016-03-31 09:03:49.000000000","message":"+1 for \"must be\". Otherwise I\u0027m fine with \"max_version\", that ends up being technically the same here, unless I\u0027m really missing something.","commit_id":"7d4b48f2de93832f9ee2290a043d4846f866786d"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"bad88d602d82938bdb186f5f2374bf23f8038f81","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        Place a database under migration control and upgrade/downgrade it,"},{"line_number":114,"context_line":"        creating first if necessary."},{"line_number":115,"context_line":"        \"\"\""},{"line_number":116,"context_line":"        if current_version is not None:"},{"line_number":117,"context_line":"            try:"},{"line_number":118,"context_line":"                current_version \u003d int(current_version)"},{"line_number":119,"context_line":"            except ValueError:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_06642347","line":116,"updated":"2016-05-08 23:39:11.000000000","message":"Do we really need this checks? Would just doing the change in L141 be enough?","commit_id":"ea428b3cfebb47b5c292c66e3cb5eacf30e9a51b"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"4dbe09733e091fddf8ab2283e84f78b4dd4e745e","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        Place a database under migration control and upgrade/downgrade it,"},{"line_number":114,"context_line":"        creating first if necessary."},{"line_number":115,"context_line":"        \"\"\""},{"line_number":116,"context_line":"        if current_version is not None:"},{"line_number":117,"context_line":"            try:"},{"line_number":118,"context_line":"                current_version \u003d int(current_version)"},{"line_number":119,"context_line":"            except ValueError:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_92064c84","line":116,"in_reply_to":"dab17558_06642347","updated":"2016-05-11 07:41:08.000000000","message":"Hi Flavio,\n\nThis check is necessary because if we provide a large version (e.g. 22222343454545463423235) to sync \nit will raise \u0027OverflowError: range() result has too many items\u0027. To restrict this OverflowError I have added maximum limit validation \nfor version and current_version. \n\nL141 is handling a condition if migration script file is not present in migration repository.","commit_id":"ea428b3cfebb47b5c292c66e3cb5eacf30e9a51b"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"bad88d602d82938bdb186f5f2374bf23f8038f81","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                sys.exit(_(\"Current version must be less than or equal to \""},{"line_number":124,"context_line":"                           \"%(max_int)d.\") % {\"max_int\": db.MAX_INT})"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        if version is not None:"},{"line_number":127,"context_line":"            try:"},{"line_number":128,"context_line":"                version \u003d int(version)"},{"line_number":129,"context_line":"            except ValueError:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_665b6f88","line":126,"updated":"2016-05-08 23:39:11.000000000","message":"This could probably be simplified by putting these checks in a for-loop","commit_id":"ea428b3cfebb47b5c292c66e3cb5eacf30e9a51b"}],"glance/db/__init__.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"72f3f99e63c720d1ff71751c97e898e7615afe7d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"CONF.import_opt(\u0027image_size_cap\u0027, \u0027glance.common.config\u0027)"},{"line_number":36,"context_line":"CONF.import_opt(\u0027metadata_encryption_key\u0027, \u0027glance.common.config\u0027)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# The maximum value a signed INT type may have"},{"line_number":39,"context_line":"MAX_INT \u003d 0x7FFFFFFF"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9abb7d3a_9a6ea42d","line":38,"range":{"start_line":38,"start_character":42,"end_line":38,"end_character":46},"updated":"2016-05-30 09:26:29.000000000","message":"Isn\u0027t this DB-specific?","commit_id":"4ae97dedad127ae85181ae42ab40b367de76377a"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"90e2bab2061b7ee754a11a949208710c5ea6b8fb","unresolved":false,"context_lines":[{"line_number":35,"context_line":"CONF.import_opt(\u0027image_size_cap\u0027, \u0027glance.common.config\u0027)"},{"line_number":36,"context_line":"CONF.import_opt(\u0027metadata_encryption_key\u0027, \u0027glance.common.config\u0027)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# The maximum value a signed INT type may have"},{"line_number":39,"context_line":"MAX_INT \u003d 0x7FFFFFFF"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9abb7d3a_885d867b","line":38,"range":{"start_line":38,"start_character":42,"end_line":38,"end_character":46},"in_reply_to":"9abb7d3a_9a6ea42d","updated":"2016-05-31 11:22:26.000000000","message":"Hi Cyril,\n\nI have confirmed that the value of MAX_INT used is same to maximum limit of integer for PostgreSQL, DB2, MySQL etc.\nThe same limit is used for database related input validations in other projects like nova [1][2], cinder [3] etc.\n \n [1] https://github.com/openstack/nova/blob/master/nova/db/api.py#L48\n [2] https://github.com/openstack/nova/blob/7b35aa97d84acaa503083a85c96bdf90a4aabe05/nova/cmd/manage.py#L760\n [3] https://github.com/openstack/cinder/blob/master/cinder/db/api.py#L75","commit_id":"4ae97dedad127ae85181ae42ab40b367de76377a"}],"glance/tests/unit/test_glance_manage.py":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"0a60bed8861c379aed84764d4ada15814a84efb5","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        message \u003d \"Database schema file with version 45 doesn\u0027t exist.\""},{"line_number":80,"context_line":"        db_sync.side_effect \u003d oslo_exception.DbMigrationError(message)"},{"line_number":81,"context_line":"        exit \u003d self.assertRaises(SystemExit, self.commands.sync,"},{"line_number":82,"context_line":"                                 db_version.return_value + 1)"},{"line_number":83,"context_line":"        self.assertEqual(message, exit.code)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_65f671fa","line":82,"range":{"start_line":82,"start_character":44,"end_line":82,"end_character":56},"updated":"2016-03-30 17:51:04.000000000","message":"Isn\u0027t this test going to break as soon as we have migration #45?\n\nLet me know if I missed anything.","commit_id":"7d4b48f2de93832f9ee2290a043d4846f866786d"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"bf88ad6a90cfcc7e7eed159895bbcaeff73d5913","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        message \u003d \"Database schema file with version 45 doesn\u0027t exist.\""},{"line_number":80,"context_line":"        db_sync.side_effect \u003d oslo_exception.DbMigrationError(message)"},{"line_number":81,"context_line":"        exit \u003d self.assertRaises(SystemExit, self.commands.sync,"},{"line_number":82,"context_line":"                                 db_version.return_value + 1)"},{"line_number":83,"context_line":"        self.assertEqual(message, exit.code)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_73bf3eaa","line":82,"range":{"start_line":82,"start_character":44,"end_line":82,"end_character":56},"in_reply_to":"ba0121b8_65f671fa","updated":"2016-03-31 09:03:49.000000000","message":"I think db_sync will always raise a DbMigrationError here.","commit_id":"7d4b48f2de93832f9ee2290a043d4846f866786d"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"9caceb6e980aa4cdf8b04fe61f6c93611238b1d1","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        message \u003d \"Database schema file with version 45 doesn\u0027t exist.\""},{"line_number":80,"context_line":"        db_sync.side_effect \u003d oslo_exception.DbMigrationError(message)"},{"line_number":81,"context_line":"        exit \u003d self.assertRaises(SystemExit, self.commands.sync,"},{"line_number":82,"context_line":"                                 db_version.return_value + 1)"},{"line_number":83,"context_line":"        self.assertEqual(message, exit.code)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_269ee6b8","line":82,"range":{"start_line":82,"start_character":44,"end_line":82,"end_character":56},"in_reply_to":"ba0121b8_73bf3eaa","updated":"2016-04-01 10:15:41.000000000","message":"Yes Cyril you are right, I have mocked external library function oslo_db.sqlalchemy.migration.db_sync purposefully to raise DbMigrationError in this case, otherwise as pointed out by Hemanth if we give specific version then this test will fail as soon as that version schema is available in migration repo.","commit_id":"7d4b48f2de93832f9ee2290a043d4846f866786d"}],"glance/tests/unit/test_manage.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"bf88ad6a90cfcc7e7eed159895bbcaeff73d5913","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        self._main_test_helper([\u0027glance.cmd.manage\u0027, \u0027db_sync\u0027, \u002720\u0027],"},{"line_number":86,"context_line":"                               migration.db_sync,"},{"line_number":87,"context_line":"                               db_api.get_engine(),"},{"line_number":88,"context_line":"                               db_migration.MIGRATE_REPO_PATH, 20)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @mock.patch.object(migration, \u0027db_sync\u0027)"},{"line_number":91,"context_line":"    def test_legacy_db_upgrade_version(self, db_sync):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_33d026f6","line":88,"range":{"start_line":88,"start_character":65,"end_line":88,"end_character":66},"updated":"2016-03-31 09:03:49.000000000","message":"Why do we change the type here?","commit_id":"7d4b48f2de93832f9ee2290a043d4846f866786d"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"37e6668aa0dc49d1186fd6abb43e69081955c34c","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        self._main_test_helper([\u0027glance.cmd.manage\u0027, \u0027db_sync\u0027, \u002720\u0027],"},{"line_number":86,"context_line":"                               migration.db_sync,"},{"line_number":87,"context_line":"                               db_api.get_engine(),"},{"line_number":88,"context_line":"                               db_migration.MIGRATE_REPO_PATH, 20)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @mock.patch.object(migration, \u0027db_sync\u0027)"},{"line_number":91,"context_line":"    def test_legacy_db_upgrade_version(self, db_sync):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_2778142a","line":88,"range":{"start_line":88,"start_character":65,"end_line":88,"end_character":66},"in_reply_to":"ba0121b8_33d026f6","updated":"2016-04-06 05:40:25.000000000","message":"Hi Cyril,\n\nThe _main_test_helper() method of test_manage at line no:46 is checking whether a given function(in this case migration.db_sync()) is getting called \nwith expected arguments or not. Earlier the given string arguments were directly being passed to migration.db_sync without conversion.\n\nIn the sync() method of glance.cmd.manage I have converted \u0027version\u0027 and \u0027current_version\u0027 to int so now migration.db_sync is expecting integer \u0027version\u0027 \nand \u0027current_version\u0027 instead of string that\u0027s why changed their type from string to int.","commit_id":"7d4b48f2de93832f9ee2290a043d4846f866786d"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"bf88ad6a90cfcc7e7eed159895bbcaeff73d5913","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        self._main_test_helper([\u0027glance.cmd.manage\u0027, \u0027db\u0027, \u0027sync\u0027, \u002720\u0027],"},{"line_number":199,"context_line":"                               migration.db_sync,"},{"line_number":200,"context_line":"                               db_api.get_engine(),"},{"line_number":201,"context_line":"                               db_migration.MIGRATE_REPO_PATH, 20)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    @mock.patch.object(migration, \u0027db_sync\u0027)"},{"line_number":204,"context_line":"    def test_db_upgrade_version(self, db_sync):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_73d61ef2","line":201,"range":{"start_line":201,"start_character":65,"end_line":201,"end_character":66},"updated":"2016-03-31 09:03:49.000000000","message":"Ditto.","commit_id":"7d4b48f2de93832f9ee2290a043d4846f866786d"}]}
