)]}'
{"glance/api/v1/images.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"55e07a430f8f04cbf1be38e7b7701b867889effe","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            images \u003d registry.get_images_list(self.options, req.context,"},{"line_number":112,"context_line":"                                              **params)"},{"line_number":113,"context_line":"        except exception.Invalid, e:"},{"line_number":114,"context_line":"            raise HTTPBadRequest(explanation\u003d_(\"%s\") % e)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        return dict(images\u003dimages)"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACH%2F%2F%2Fb8%3D","line":114,"updated":"2011-08-22 03:39:15.000000000","message":"So this isn\u0027t actually going to get us anything in the way of internationalization support. We use a static code analysis tool to build the i18n translations, so we wouldn\u0027t actually be able to replace \u0027%s\u0027 with anything relevant to the exception at hand. I think you can revert this change throughout the file.","commit_id":"26ccbf73452459c9c7b97a2cbe81ba8b8205623b"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"eba536698cade7ba9bbd04b3a983501a1cf1510b","unresolved":false,"context_lines":[{"line_number":393,"context_line":""},{"line_number":394,"context_line":"            self._safe_kill(req, image_id)"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"            msg \u003d _(\"Error uploading image: (%s): \u0027%s\") % ("},{"line_number":397,"context_line":"                e.__class__.__name__, str(e))"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"            self.notifier.error(\u0027image.upload\u0027, msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAACH%2F%2F%2FZQ%3D","line":396,"updated":"2011-08-22 14:04:29.000000000","message":"This string needs to use keyword arguments, not positional. Not sure if you\u0027ve seen this, but it\u0027s a good overview of i18n in Nova: http://bazaar.launchpad.net/~hudson-openstack/nova/trunk/view/head:/HACKING","commit_id":"83f80fcef6b401fdf914d0c25765ca1a41ea9dc9"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"eba536698cade7ba9bbd04b3a983501a1cf1510b","unresolved":false,"context_lines":[{"line_number":441,"context_line":"        try:"},{"line_number":442,"context_line":"            self._kill(req, image_id)"},{"line_number":443,"context_line":"        except Exception, e:"},{"line_number":444,"context_line":"            logger.error(_(\"Unable to kill image %s: %s\"),"},{"line_number":445,"context_line":"                          image_id, repr(e))"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"    def _upload_and_activate(self, req, image_meta):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAACH%2F%2F%2FZM%3D","line":444,"updated":"2011-08-22 14:04:29.000000000","message":"Need keyword args here.","commit_id":"83f80fcef6b401fdf914d0c25765ca1a41ea9dc9"}],"glance/image_cache/pruner.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"55e07a430f8f04cbf1be38e7b7701b867889effe","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            freed \u003d 0"},{"line_number":81,"context_line":"            while to_free \u003e 0:"},{"line_number":82,"context_line":"                atime, mtime, size, path \u003d stats.pop()"},{"line_number":83,"context_line":"                logger.debug(_(\"deleting \u0027%(path)s\u0027 to free %(size)d B\",)"},{"line_number":84,"context_line":"                             locals())"},{"line_number":85,"context_line":"                os.unlink(path)"},{"line_number":86,"context_line":"                to_free -\u003d size"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACH%2F%2F%2FcA%3D","line":83,"updated":"2011-08-22 03:39:15.000000000","message":"The comma here should be outside of the parens.","commit_id":"26ccbf73452459c9c7b97a2cbe81ba8b8205623b"}],"glance/registry/__init__.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"55e07a430f8f04cbf1be38e7b7701b867889effe","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        logger.debug(_(\" %d custom properties...\"),"},{"line_number":121,"context_line":"                     len(properties))"},{"line_number":122,"context_line":"        for key, value in properties.items():"},{"line_number":123,"context_line":"            logger.debug((\" %(key)20s: %(value)s\") % locals())"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACH%2F%2F%2FcE%3D","line":123,"updated":"2011-08-22 03:39:15.000000000","message":"Missed the underscore on this one.","commit_id":"26ccbf73452459c9c7b97a2cbe81ba8b8205623b"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"eba536698cade7ba9bbd04b3a983501a1cf1510b","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    data \u003d image_meta.copy()"},{"line_number":116,"context_line":"    properties \u003d data.pop(\u0027properties\u0027, None)"},{"line_number":117,"context_line":"    for key, value in sorted(data.items()):"},{"line_number":118,"context_line":"        logger.debug(_(\" %(key)20s: %(value)s\") % locals())"},{"line_number":119,"context_line":"    if properties:"},{"line_number":120,"context_line":"        logger.debug(_(\" %d custom properties...\"),"},{"line_number":121,"context_line":"                     len(properties))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAACH%2F%2F%2FZI%3D","line":118,"updated":"2011-08-22 14:04:29.000000000","message":"Seeing as this is just user-defined data, I think this change can be reverted.","commit_id":"83f80fcef6b401fdf914d0c25765ca1a41ea9dc9"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"eba536698cade7ba9bbd04b3a983501a1cf1510b","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        logger.debug(_(\" %d custom properties...\"),"},{"line_number":121,"context_line":"                     len(properties))"},{"line_number":122,"context_line":"        for key, value in properties.items():"},{"line_number":123,"context_line":"            logger.debug(_(\" %(key)20s: %(value)s\") % locals())"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAACH%2F%2F%2FZE%3D","line":123,"updated":"2011-08-22 14:04:29.000000000","message":"This can also be reverted.","commit_id":"83f80fcef6b401fdf914d0c25765ca1a41ea9dc9"}]}