)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"bfdddbcbf543172d9fa708ff063620f8a44e8d83","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     bpankaj \u003cpankaj.mishra@nectechnologies.in\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-06 18:00:50 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[glance] Fixed message for metadata tag name is case insensitive"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ia61a9220472372655bced4737e741c92a2c5030a"},{"line_number":10,"context_line":"Closes-Bug: #1535231"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a061dce_16e6a914","line":7,"range":{"start_line":7,"start_character":9,"end_line":7,"end_character":64},"updated":"2016-04-06 22:48:28.000000000","message":"Please re-word this.\nAlso, there is nothing wrong with the existing message that it needs to be \u0027fixed\u0027. You are just adding more detail.\n\nI\u0027d say change this to something like \"Modify message of exception MetadefDuplicateTag\". And, maybe write a couple of lines summarizing the fix and the detail on bug report.","commit_id":"a2e71c38e73c98042585419f3267632092210cd6"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"24489941821682dfde9391b67c4ac3d26e5b7dbd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     bpankaj \u003cpankaj.mishra@nectechnologies.in\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-06 18:00:50 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[glance] Fixed message for metadata tag name is case insensitive"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ia61a9220472372655bced4737e741c92a2c5030a"},{"line_number":10,"context_line":"Closes-Bug: #1535231"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a061dce_40b17b46","line":7,"updated":"2016-04-06 21:44:23.000000000","message":"We know what project this. Please remove [glance] from the commit message.","commit_id":"a2e71c38e73c98042585419f3267632092210cd6"}],"glance/common/exception.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"41eec6918ec5455ff475d6c0d001d8c7bd0dda0e","unresolved":false,"context_lines":[{"line_number":398,"context_line":"class MetadefDuplicateTag(Duplicate):"},{"line_number":399,"context_line":"    message \u003d _(\"A metadata tag name is case insensitive\""},{"line_number":400,"context_line":"                \" and metadata tag with name\u003d%(name)s\""},{"line_number":401,"context_line":"                \" already exists in namespace\u003d%(namespace_name)s.\")"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"class MetadefForbidden(Forbidden):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_df12a156","line":401,"updated":"2016-04-06 14:08:44.000000000","message":"Nit: either s/and metadata tag/and a metadata tag/ or s/with// on line 400.","commit_id":"a2e71c38e73c98042585419f3267632092210cd6"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"bfdddbcbf543172d9fa708ff063620f8a44e8d83","unresolved":false,"context_lines":[{"line_number":398,"context_line":"class MetadefDuplicateTag(Duplicate):"},{"line_number":399,"context_line":"    message \u003d _(\"A metadata tag name is case insensitive\""},{"line_number":400,"context_line":"                \" and metadata tag with name\u003d%(name)s\""},{"line_number":401,"context_line":"                \" already exists in namespace\u003d%(namespace_name)s.\")"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"class MetadefForbidden(Forbidden):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_dbd3bad3","line":401,"in_reply_to":"9a061dce_df12a156","updated":"2016-04-06 22:48:28.000000000","message":"I\u0027d say break it into two sentences. Something like \"A metadata tag with name\u003d%(name)s\" already exists in namespace\u003d%(namespace_name)s. (Please note that metadata tag names are case insensitive)\"\n\nThe way it is worded it gives the impression that you know that the issue is with case sensitivity for sure. Is that true? What if it indeed is a duplicate tag? \n\nSo, I\u0027d say state the problem first and then offer a probable explanation.","commit_id":"a2e71c38e73c98042585419f3267632092210cd6"}],"glance/db/sqlalchemy/metadef_api/tag.py":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"bfdddbcbf543172d9fa708ff063620f8a44e8d83","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    try:"},{"line_number":100,"context_line":"        metadef_tag.save(session\u003dsession)"},{"line_number":101,"context_line":"    except db_exc.DBDuplicateEntry:"},{"line_number":102,"context_line":"        LOG.debug(\"A metadata tag name is case insensitive\""},{"line_number":103,"context_line":"                  \" and metadata tag name\u003d%(name)s\""},{"line_number":104,"context_line":"                  \" already exists in namespace\u003d%(namespace_name)s.\","},{"line_number":105,"context_line":"                  {\u0027name\u0027: metadef_tag.name,"},{"line_number":106,"context_line":"                   \u0027namespace_name\u0027: namespace_name})"},{"line_number":107,"context_line":"        raise exc.MetadefDuplicateTag("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_5be04a96","line":104,"range":{"start_line":102,"start_character":38,"end_line":104,"end_character":34},"updated":"2016-04-06 22:48:28.000000000","message":"Ditto.","commit_id":"a2e71c38e73c98042585419f3267632092210cd6"}]}