)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"e6435c986235097e980ef31f28c824cc8dc20760","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Flaper Fesp \u003cflaper87@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-05-26 11:02:53 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move sql_conneciton option into sqlalchemy package."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since we\u0027re in the process of adding new backends that don\u0027t use"},{"line_number":10,"context_line":"sql_connection, it makes sense to move that option into the sqlalchemy"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAPX%2F%2F%2BF0%3D","line":7,"updated":"2013-06-04 21:46:54.000000000","message":"typo","commit_id":"4417557c03f88cec9c3e9f7684d6505740be3d7f"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"e6435c986235097e980ef31f28c824cc8dc20760","unresolved":false,"context_lines":[{"line_number":13,"context_line":"As for glance-manage, it now calls the add_cli_options directly from"},{"line_number":14,"context_line":"sqlalchemy\u0027s api module."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This is parto of the blueprint registry-db-driver"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I890a5f707fe18f397cbeaadbac1d693ead2fdc14"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAPX%2F%2F%2BFs%3D","line":16,"updated":"2013-06-04 21:46:54.000000000","message":"typo","commit_id":"4417557c03f88cec9c3e9f7684d6505740be3d7f"}],"glance/db/sqlalchemy/api.py":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"fd57d8d922c05558d48875996810f55cf76aeeca","unresolved":false,"context_lines":[{"line_number":81,"context_line":"def add_cli_options():"},{"line_number":82,"context_line":"    \"\"\"Allows passing sql_connection as a CLI argument.\"\"\""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    # NOTE(flaper87): Find a better place / way for this."},{"line_number":85,"context_line":"    CONF.unregister_opt(sql_connection_opt)"},{"line_number":86,"context_line":"    CONF.register_cli_opt(sql_connection_opt)"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2FkyE%3D","line":84,"updated":"2013-05-30 06:39:25.000000000","message":"Is it possible we also create a \"session.py\" to handle the session for SQLAlchemy backend?","commit_id":"4417557c03f88cec9c3e9f7684d6505740be3d7f"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"5ccd4c523aeb8e9a926dbf05826f1b3e66906e1c","unresolved":false,"context_lines":[{"line_number":81,"context_line":"def add_cli_options():"},{"line_number":82,"context_line":"    \"\"\"Allows passing sql_connection as a CLI argument.\"\"\""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    # NOTE(flaper87): Find a better place / way for this."},{"line_number":85,"context_line":"    CONF.unregister_opt(sql_connection_opt)"},{"line_number":86,"context_line":"    CONF.register_cli_opt(sql_connection_opt)"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2Fd9Q%3D","line":84,"in_reply_to":"AAAAPH%2F%2Fe3M%3D","updated":"2013-06-03 08:11:08.000000000","message":"I don\u0027t think there\u0027s any need for moving this code to another module. By \"a better place to...\" I meant this code should be changed, I don\u0027t like the fact that glance accpets --sql_connection just for some commands.\n\nThat I will change in a separate patch.","commit_id":"4417557c03f88cec9c3e9f7684d6505740be3d7f"},{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"bcbacb7a9dfaf71759330e71fd883a5c4c93ba42","unresolved":false,"context_lines":[{"line_number":81,"context_line":"def add_cli_options():"},{"line_number":82,"context_line":"    \"\"\"Allows passing sql_connection as a CLI argument.\"\"\""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    # NOTE(flaper87): Find a better place / way for this."},{"line_number":85,"context_line":"    CONF.unregister_opt(sql_connection_opt)"},{"line_number":86,"context_line":"    CONF.register_cli_opt(sql_connection_opt)"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2Fe3M%3D","line":84,"in_reply_to":"AAAAPH%2F%2FkyE%3D","updated":"2013-06-01 17:11:27.000000000","message":"I\u0027d like to see that land separately from this patch (if at all, I don\u0027t  yet understand the proposal / value), since this patch is just a straightforward and clean mv so far.","commit_id":"4417557c03f88cec9c3e9f7684d6505740be3d7f"}]}
