)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"5e447b17fe24e32be0af9b59594bc37f1c40df82","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhufl \u003czhu.fanglei@zte.com.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-11 11:21:27 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Correct some misspell words in glance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are some misspell words in glance,"},{"line_number":10,"context_line":"    specfied (specified)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dab17558_e5dcf947","line":7,"range":{"start_line":7,"start_character":13,"end_line":7,"end_character":21},"updated":"2016-05-11 09:03:27.000000000","message":"misspelt?","commit_id":"b4128af5b8f964686a02064be2f9d78722183deb"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3fa04f9c8f10bb446febe6ce9b01bd9edec520d4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhufl \u003czhu.fanglei@zte.com.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-11 11:21:27 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Correct some misspell words in glance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are some misspell words in glance,"},{"line_number":10,"context_line":"    specfied (specified)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dab17558_863d25df","line":7,"range":{"start_line":7,"start_character":13,"end_line":7,"end_character":21},"in_reply_to":"dab17558_e5dcf947","updated":"2016-05-11 14:02:49.000000000","message":"I agree with Stuart.  Please fix here and below.  Whether you use UK or US English is up to you (\u0027misspelt\u0027 vs. \u0027mispelled\u0027).","commit_id":"b4128af5b8f964686a02064be2f9d78722183deb"}],"glance/api/v2/images.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3fa04f9c8f10bb446febe6ce9b01bd9edec520d4","unresolved":false,"context_lines":[{"line_number":500,"context_line":"            partial_image \u003d {path_root: change[\u0027value\u0027]}"},{"line_number":501,"context_line":"        elif ((path_root in get_base_properties().keys()) and"},{"line_number":502,"context_line":"              (get_base_properties()[path_root].get(\u0027type\u0027, \u0027\u0027) \u003d\u003d \u0027array\u0027)):"},{"line_number":503,"context_line":"            # NOTE(zhiyan): client can use PATCH API to adding element to"},{"line_number":504,"context_line":"            # the image\u0027s existing set property directly."},{"line_number":505,"context_line":"            # Such as: 1. using \u0027/locations/N\u0027 path to adding a location"},{"line_number":506,"context_line":"            #             to the image\u0027s \u0027locations\u0027 list at N position."},{"line_number":507,"context_line":"            #             (implemented)"},{"line_number":508,"context_line":"            #          2. using \u0027/tags/-\u0027 path to appending a tag to the"},{"line_number":509,"context_line":"            #             image\u0027s \u0027tags\u0027 list at last. (Not implemented)"},{"line_number":510,"context_line":"            partial_image \u003d {path_root: [change[\u0027value\u0027]]}"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"        if partial_image:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_a6e789aa","line":509,"range":{"start_line":503,"start_character":0,"end_line":509,"end_character":72},"updated":"2016-05-11 14:02:49.000000000","message":"Might as well fix the grammar, too.\n\nHow about:\n\n    # NOTE(zhiyan): client can use PATCH API to add an element to\n    # the image\u0027s existing set property directly.\n    # Such as: 1. using \u0027/locations/N\u0027 path to add a location\n    #             to the image\u0027s \u0027locations\u0027 list at position N.\n    #             (implemented)\n    #          2. using \u0027/tags/-\u0027 path to append a tag to the\n    #             image\u0027s \u0027tags\u0027 list at the end. (Not implemented)","commit_id":"b4128af5b8f964686a02064be2f9d78722183deb"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a2959c52e2033b44d2fa3bccd67f45a0ffd286a1","unresolved":false,"context_lines":[{"line_number":500,"context_line":"            partial_image \u003d {path_root: change[\u0027value\u0027]}"},{"line_number":501,"context_line":"        elif ((path_root in get_base_properties().keys()) and"},{"line_number":502,"context_line":"              (get_base_properties()[path_root].get(\u0027type\u0027, \u0027\u0027) \u003d\u003d \u0027array\u0027)):"},{"line_number":503,"context_line":"            # NOTE(zhiyan): client can use PATCH API to add an element to"},{"line_number":504,"context_line":"            # the image\u0027s existing set property directly."},{"line_number":505,"context_line":"            # Such as: 1. using \u0027/locations/N\u0027 path to add a location"},{"line_number":506,"context_line":"            #             to the image\u0027s \u0027locations\u0027 list at position N."},{"line_number":507,"context_line":"            #             (implemented)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_05f2ab05","line":504,"range":{"start_line":503,"start_character":12,"end_line":504,"end_character":57},"updated":"2016-05-12 02:50:36.000000000","message":"Apologies for not catching this the first time.  I don\u0027t think this makes sense as written.  How about:\n\n    # NOTE(zhiyan): client can use the PATCH API to add an element\n    # directly to an existing property","commit_id":"d44755a108df8eedc72a21c49f6febfdeb1edcef"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1c11952d7c8a252b9a8c6c8b7756dd8c28f90a68","unresolved":false,"context_lines":[{"line_number":501,"context_line":"        elif ((path_root in get_base_properties().keys()) and"},{"line_number":502,"context_line":"              (get_base_properties()[path_root].get(\u0027type\u0027, \u0027\u0027) \u003d\u003d \u0027array\u0027)):"},{"line_number":503,"context_line":"            # NOTE(zhiyan): client can use the PATCH API to add an element"},{"line_number":504,"context_line":"            # directly to an existing property set"},{"line_number":505,"context_line":"            # Such as: 1. using \u0027/locations/N\u0027 path to add a location"},{"line_number":506,"context_line":"            #             to the image\u0027s \u0027locations\u0027 list at position N."},{"line_number":507,"context_line":"            #             (implemented)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_54c0cc7c","line":504,"range":{"start_line":504,"start_character":47,"end_line":504,"end_character":50},"updated":"2016-05-12 13:28:56.000000000","message":"Why the word \"set\" here? You can tell from the elif that we\u0027re dealing with a property whose value is an array here, so I think \"set\" is misleading.  I\u0027d suggest eliminating the word \"set\" (as I suggested on PS2).  Although I am open to other opinions ...","commit_id":"f11bf642c4515f3fc0b7e7bbe5b771415bb54d1e"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"eab2f92c091136ea30ebba68561fb9f28ad68305","unresolved":false,"context_lines":[{"line_number":500,"context_line":"            partial_image \u003d {path_root: change[\u0027value\u0027]}"},{"line_number":501,"context_line":"        elif ((path_root in get_base_properties().keys()) and"},{"line_number":502,"context_line":"              (get_base_properties()[path_root].get(\u0027type\u0027, \u0027\u0027) \u003d\u003d \u0027array\u0027)):"},{"line_number":503,"context_line":"            # NOTE(zhiyan): client can use the PATCH API to add an element"},{"line_number":504,"context_line":"            # directly to an existing property"},{"line_number":505,"context_line":"            # Such as: 1. using \u0027/locations/N\u0027 path to add a location"},{"line_number":506,"context_line":"            #             to the image\u0027s \u0027locations\u0027 list at position N."},{"line_number":507,"context_line":"            #             (implemented)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_64625daf","line":504,"range":{"start_line":503,"start_character":14,"end_line":504,"end_character":46},"updated":"2016-05-13 03:10:30.000000000","message":"Thanks for fixing the wording here.","commit_id":"97d8ea2efeed906ef3023589aa98b4e2dc288ddc"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"3d148ea892ce6646a561eb7ea8a2daa5ddbddb0e","unresolved":false,"context_lines":[{"line_number":501,"context_line":"        elif ((path_root in get_base_properties().keys()) and"},{"line_number":502,"context_line":"              (get_base_properties()[path_root].get(\u0027type\u0027, \u0027\u0027) \u003d\u003d \u0027array\u0027)):"},{"line_number":503,"context_line":"            # NOTE(zhiyan): client can use the PATCH API to add an element"},{"line_number":504,"context_line":"            # directly to an existing property"},{"line_number":505,"context_line":"            # Such as: 1. using \u0027/locations/N\u0027 path to add a location"},{"line_number":506,"context_line":"            #             to the image\u0027s \u0027locations\u0027 list at position N."},{"line_number":507,"context_line":"            #             (implemented)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_5a443bb6","line":504,"range":{"start_line":504,"start_character":26,"end_line":504,"end_character":46},"updated":"2016-05-13 13:26:31.000000000","message":"existing properties?","commit_id":"a9c2e1166105a5176671d198896fe55c3c19ea34"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5d58feda4019ac1cc975d9a1a117cd6e1b35a77a","unresolved":false,"context_lines":[{"line_number":501,"context_line":"        elif ((path_root in get_base_properties().keys()) and"},{"line_number":502,"context_line":"              (get_base_properties()[path_root].get(\u0027type\u0027, \u0027\u0027) \u003d\u003d \u0027array\u0027)):"},{"line_number":503,"context_line":"            # NOTE(zhiyan): client can use the PATCH API to add an element"},{"line_number":504,"context_line":"            # directly to an existing property"},{"line_number":505,"context_line":"            # Such as: 1. using \u0027/locations/N\u0027 path to add a location"},{"line_number":506,"context_line":"            #             to the image\u0027s \u0027locations\u0027 list at position N."},{"line_number":507,"context_line":"            #             (implemented)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_c60e928b","line":504,"range":{"start_line":504,"start_character":26,"end_line":504,"end_character":46},"in_reply_to":"dab17558_5a443bb6","updated":"2016-05-13 14:35:52.000000000","message":"I disagree, I think the singular is correct here.","commit_id":"a9c2e1166105a5176671d198896fe55c3c19ea34"}],"glance/tests/unit/async/flows/test_ovf_process.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3fa04f9c8f10bb446febe6ce9b01bd9edec520d4","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        super(TestOvfProcessTask, self).tearDown()"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def _copy_ova_to_tmpdir(self, ova_name):"},{"line_number":70,"context_line":"        # Copies an ova package to the tempdir for tempdir from where"},{"line_number":71,"context_line":"        # the system-under-test will read it from"},{"line_number":72,"context_line":"        shutil.copy(os.path.join(self.test_ova_dir, ova_name), self.tempdir)"},{"line_number":73,"context_line":"        return os.path.join(self.tempdir, ova_name)"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_a65789c8","line":71,"range":{"start_line":70,"start_character":0,"end_line":71,"end_character":49},"updated":"2016-05-11 14:02:49.000000000","message":"Might as well fix the grammar, too, while you\u0027re at it.  What about:\n\n    # Copies an ova package to the tempdir from which\n    # it will be read by the system-under-test","commit_id":"b4128af5b8f964686a02064be2f9d78722183deb"}],"glance/tests/unit/v2/test_registry_client.py":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"eab2f92c091136ea30ebba68561fb9f28ad68305","unresolved":false,"context_lines":[{"line_number":677,"context_line":"        self.assertEqual(0, num_members)"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"    def test_image_member_find_include_deleted(self):"},{"line_number":680,"context_line":"        \"\"\"Tests getting member images include the deleted member\"\"\""},{"line_number":681,"context_line":"        values \u003d dict(image_id\u003dUUID2, member\u003d\u0027pattieblack\u0027)"},{"line_number":682,"context_line":"        # create a member"},{"line_number":683,"context_line":"        member \u003d self.client.image_member_create(values\u003dvalues)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_04e71113","line":680,"range":{"start_line":680,"start_character":25,"end_line":680,"end_character":38},"updated":"2016-05-13 03:10:30.000000000","message":"image members?","commit_id":"97d8ea2efeed906ef3023589aa98b4e2dc288ddc"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"eab2f92c091136ea30ebba68561fb9f28ad68305","unresolved":false,"context_lines":[{"line_number":677,"context_line":"        self.assertEqual(0, num_members)"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"    def test_image_member_find_include_deleted(self):"},{"line_number":680,"context_line":"        \"\"\"Tests getting member images include the deleted member\"\"\""},{"line_number":681,"context_line":"        values \u003d dict(image_id\u003dUUID2, member\u003d\u0027pattieblack\u0027)"},{"line_number":682,"context_line":"        # create a member"},{"line_number":683,"context_line":"        member \u003d self.client.image_member_create(values\u003dvalues)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_64d7fd23","line":680,"range":{"start_line":680,"start_character":39,"end_line":680,"end_character":46},"updated":"2016-05-13 03:10:30.000000000","message":"including?","commit_id":"97d8ea2efeed906ef3023589aa98b4e2dc288ddc"}]}
