)]}'
{"glance/cmd/api.py":[{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"6d4a4b2ca21ae6f584529a7828931e47cd69f0a4","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        if cfg.CONF.profiler.enabled:"},{"line_number":78,"context_line":"            osprofiler.initializer.init_from_conf("},{"line_number":79,"context_line":"                conf\u003dCONF,"},{"line_number":80,"context_line":"                context\u003d{},"},{"line_number":81,"context_line":"                project\u003d\"glance\","},{"line_number":82,"context_line":"                service\u003d\"api\","},{"line_number":83,"context_line":"                host\u003dcfg.CONF.bind_host"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a8bc5a2_5207f81b","line":80,"updated":"2016-09-22 19:31:21.000000000","message":"admin context?","commit_id":"b91eb5cf489029b6fb556f78a57fbe5886e8ea52"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"63c3e9ed211168ff7bcd4a29f38f7543ff1ea74d","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        logging.setup(CONF, \u0027glance\u0027)"},{"line_number":76,"context_line":"        notifier.set_defaults()"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        if cfg.CONF.profiler.enabled:"},{"line_number":79,"context_line":"            osprofiler.initializer.init_from_conf("},{"line_number":80,"context_line":"                conf\u003dCONF,"},{"line_number":81,"context_line":"                context\u003dcontext.get_admin_context().to_dict(),"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a461143_153968a4","line":78,"range":{"start_line":78,"start_character":11,"end_line":78,"end_character":19},"updated":"2017-01-30 17:30:40.000000000","message":"s/cfg.CONF/CONF","commit_id":"66651e18bfa94241021559b5cc84f857ce75fbda"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"a9483f4dac477f0c807ca94a1616c4c0752dd004","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        logging.setup(CONF, \u0027glance\u0027)"},{"line_number":76,"context_line":"        notifier.set_defaults()"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        if cfg.CONF.profiler.enabled:"},{"line_number":79,"context_line":"            osprofiler.initializer.init_from_conf("},{"line_number":80,"context_line":"                conf\u003dCONF,"},{"line_number":81,"context_line":"                context\u003dcontext.get_admin_context().to_dict(),"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a430d35_84247760","line":78,"range":{"start_line":78,"start_character":11,"end_line":78,"end_character":19},"in_reply_to":"3a461143_153968a4","updated":"2017-02-07 09:12:58.000000000","message":"Thanks for noticing that! Will fix soon! :D","commit_id":"66651e18bfa94241021559b5cc84f857ce75fbda"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"2dc72257820c6468175dda4d61ed358898966aa9","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        if CONF.profiler.enabled:"},{"line_number":79,"context_line":"            osprofiler.initializer.init_from_conf("},{"line_number":80,"context_line":"                conf\u003dCONF,"},{"line_number":81,"context_line":"                context\u003dcontext.get_admin_context().to_dict(),"},{"line_number":82,"context_line":"                project\u003d\"glance\","},{"line_number":83,"context_line":"                service\u003d\"api\","},{"line_number":84,"context_line":"                host\u003dCONF.bind_host"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba2be162_c208a6dc","line":81,"range":{"start_line":81,"start_character":16,"end_line":81,"end_character":62},"updated":"2017-03-06 17:55:39.000000000","message":"Hi Tovin,\nWhy admin context?\nosprofiler does not require it.","commit_id":"36b073d9d0aecb58a80cd8326cc525378d109707"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"19e3508b2a93018a1e1eda51c2b779d1f0b952e5","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        if CONF.profiler.enabled:"},{"line_number":79,"context_line":"            osprofiler.initializer.init_from_conf("},{"line_number":80,"context_line":"                conf\u003dCONF,"},{"line_number":81,"context_line":"                context\u003dcontext.get_admin_context().to_dict(),"},{"line_number":82,"context_line":"                project\u003d\"glance\","},{"line_number":83,"context_line":"                service\u003d\"api\","},{"line_number":84,"context_line":"                host\u003dCONF.bind_host"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a1ced50_e5e68daf","line":81,"range":{"start_line":81,"start_character":16,"end_line":81,"end_character":62},"in_reply_to":"9a30ddce_43a9dede","updated":"2017-03-23 19:39:47.000000000","message":"Hi Tovin,\nSo, osprofiler\u0027s initializer.init_from_conf passes the context to osprofiler.notifier.create. I do not see the need for glance to use the admin context here for this purpose (we were not earlier either while we were manually calling and creating the notifier). \nI might be missing something, but i think we need not use an admin context. Also, Glance by default has osprofiler disabled for request tracing. \n\nI will wait for other reviewers and remove my -1 based on any advancements on this. \n\nhttps://docs.openstack.org/developer/osprofiler/api.html#using-osprofiler-initializer","commit_id":"36b073d9d0aecb58a80cd8326cc525378d109707"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"347e7459cd528a6a959b2a087df2480b8745070d","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        if CONF.profiler.enabled:"},{"line_number":79,"context_line":"            osprofiler.initializer.init_from_conf("},{"line_number":80,"context_line":"                conf\u003dCONF,"},{"line_number":81,"context_line":"                context\u003dcontext.get_admin_context().to_dict(),"},{"line_number":82,"context_line":"                project\u003d\"glance\","},{"line_number":83,"context_line":"                service\u003d\"api\","},{"line_number":84,"context_line":"                host\u003dCONF.bind_host"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a30ddce_43a9dede","line":81,"range":{"start_line":81,"start_character":16,"end_line":81,"end_character":62},"in_reply_to":"ba2be162_c208a6dc","updated":"2017-03-08 02:02:53.000000000","message":"Currently, only OSprofiler with messaging driver (OSprofiler + Messaging + Ceilometer + Panko) requires this.","commit_id":"36b073d9d0aecb58a80cd8326cc525378d109707"},{"author":{"_account_id":23936,"name":"Ronan-Alexandre Cherrueau","email":"Ronan-Alexandre.Cherrueau@inria.fr","username":"rcherrueau"},"change_message_id":"d5ea657b3557895054924dfb8317bbffa59f87ba","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        notifier.set_defaults()"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        if CONF.profiler.enabled:"},{"line_number":78,"context_line":"            osprofiler.initializer.init_from_conf("},{"line_number":79,"context_line":"                conf\u003dCONF,"},{"line_number":80,"context_line":"                project\u003d\"glance\","},{"line_number":81,"context_line":"                service\u003d\"api\","}],"source_content_type":"text/x-python","patch_set":15,"id":"5ff73747_9fe04a28","line":78,"updated":"2017-04-28 00:29:42.000000000","message":"Python complains about missing context","commit_id":"1e6b15380139d11e07ebf9028c6d3a1ba70f32b8"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"aec58a0f284892e7cb059eeefd9305de7aef01c9","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        notifier.set_defaults()"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        if CONF.profiler.enabled:"},{"line_number":78,"context_line":"            osprofiler.initializer.init_from_conf("},{"line_number":79,"context_line":"                conf\u003dCONF,"},{"line_number":80,"context_line":"                project\u003d\"glance\","},{"line_number":81,"context_line":"                service\u003d\"api\","}],"source_content_type":"text/x-python","patch_set":15,"id":"5ff73747_1fee79ec","line":78,"in_reply_to":"5ff73747_9fe04a28","updated":"2017-04-28 01:28:33.000000000","message":"Oh, that\u0027s a really a big mistake of mine :(\nThank you!","commit_id":"1e6b15380139d11e07ebf9028c6d3a1ba70f32b8"}],"glance/cmd/glare.py":[{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"63c3e9ed211168ff7bcd4a29f38f7543ff1ea74d","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        wsgi.set_eventlet_hub()"},{"line_number":65,"context_line":"        logging.setup(CONF, \u0027glare\u0027)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if cfg.CONF.profiler.enabled:"},{"line_number":68,"context_line":"            osprofiler.initializer.init_from_conf("},{"line_number":69,"context_line":"                conf\u003dCONF,"},{"line_number":70,"context_line":"                context\u003dcontext.get_admin_context().to_dict(),"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a461143_b5c33488","line":67,"range":{"start_line":67,"start_character":11,"end_line":67,"end_character":19},"updated":"2017-01-30 17:30:40.000000000","message":"s/cfg.CONF/CONF","commit_id":"66651e18bfa94241021559b5cc84f857ce75fbda"}],"glance/cmd/registry.py":[{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"63c3e9ed211168ff7bcd4a29f38f7543ff1ea74d","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                                                   cfg.CONF.bind_host)"},{"line_number":70,"context_line":"            osprofiler.notifier.set(_notifier)"},{"line_number":71,"context_line":"            osprofiler.web.enable(cfg.CONF.profiler.hmac_keys)"},{"line_number":72,"context_line":"        else:"},{"line_number":73,"context_line":"            osprofiler.web.disable()"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        server \u003d wsgi.Server()"},{"line_number":76,"context_line":"        server.start(config.load_paste_app(\u0027glance-registry\u0027),"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a461143_3833bbac","side":"PARENT","line":73,"range":{"start_line":72,"start_character":8,"end_line":73,"end_character":36},"updated":"2017-01-30 17:30:40.000000000","message":"Why are we getting rid of this? I do not see the osprofiler.initializer handling this.","commit_id":"0bf9d805886c248083d47ac0c694b8b48b9d1224"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"a9483f4dac477f0c807ca94a1616c4c0752dd004","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                                                   cfg.CONF.bind_host)"},{"line_number":70,"context_line":"            osprofiler.notifier.set(_notifier)"},{"line_number":71,"context_line":"            osprofiler.web.enable(cfg.CONF.profiler.hmac_keys)"},{"line_number":72,"context_line":"        else:"},{"line_number":73,"context_line":"            osprofiler.web.disable()"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        server \u003d wsgi.Server()"},{"line_number":76,"context_line":"        server.start(config.load_paste_app(\u0027glance-registry\u0027),"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a430d35_e4c37b87","side":"PARENT","line":73,"range":{"start_line":72,"start_character":8,"end_line":73,"end_character":36},"in_reply_to":"3a461143_3833bbac","updated":"2017-02-07 09:12:58.000000000","message":"Oh, OSprofiler for web is disable by default. So, we do not need to ensure that.\n\nIn early stage of OSprofiler, options to enable tracing in web is place in paste.ini config. However, OSprofiler had removed it for a long time. That why we should come with new OSprofiler API.","commit_id":"0bf9d805886c248083d47ac0c694b8b48b9d1224"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"63c3e9ed211168ff7bcd4a29f38f7543ff1ea74d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        logging.setup(CONF, \u0027glance\u0027)"},{"line_number":61,"context_line":"        notifier.set_defaults()"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        if cfg.CONF.profiler.enabled:"},{"line_number":64,"context_line":"            osprofiler.initializer.init_from_conf("},{"line_number":65,"context_line":"                conf\u003dCONF,"},{"line_number":66,"context_line":"                context\u003dcontext.get_admin_context().to_dict(),"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a461143_92d3ae03","line":63,"range":{"start_line":63,"start_character":11,"end_line":63,"end_character":36},"updated":"2017-01-30 17:30:40.000000000","message":"CONF.profilier.enabled is sufficient.","commit_id":"66651e18bfa94241021559b5cc84f857ce75fbda"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"63c3e9ed211168ff7bcd4a29f38f7543ff1ea74d","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                context\u003dcontext.get_admin_context().to_dict(),"},{"line_number":67,"context_line":"                project\u003d\"glance\","},{"line_number":68,"context_line":"                service\u003d\"registry\","},{"line_number":69,"context_line":"                host\u003dcfg.CONF.bind_host"},{"line_number":70,"context_line":"            )"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        server \u003d wsgi.Server()"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a461143_7501cc69","line":69,"range":{"start_line":69,"start_character":21,"end_line":69,"end_character":29},"updated":"2017-01-30 17:30:40.000000000","message":"CONF","commit_id":"66651e18bfa94241021559b5cc84f857ce75fbda"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"2dc72257820c6468175dda4d61ed358898966aa9","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        if CONF.profiler.enabled:"},{"line_number":64,"context_line":"            osprofiler.initializer.init_from_conf("},{"line_number":65,"context_line":"                conf\u003dCONF,"},{"line_number":66,"context_line":"                context\u003dcontext.get_admin_context().to_dict(),"},{"line_number":67,"context_line":"                project\u003d\"glance\","},{"line_number":68,"context_line":"                service\u003d\"registry\","},{"line_number":69,"context_line":"                host\u003dCONF.bind_host"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba2be162_22f8a2c4","line":66,"range":{"start_line":66,"start_character":16,"end_line":66,"end_character":62},"updated":"2017-03-06 17:55:39.000000000","message":"same","commit_id":"36b073d9d0aecb58a80cd8326cc525378d109707"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"347e7459cd528a6a959b2a087df2480b8745070d","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        if CONF.profiler.enabled:"},{"line_number":64,"context_line":"            osprofiler.initializer.init_from_conf("},{"line_number":65,"context_line":"                conf\u003dCONF,"},{"line_number":66,"context_line":"                context\u003dcontext.get_admin_context().to_dict(),"},{"line_number":67,"context_line":"                project\u003d\"glance\","},{"line_number":68,"context_line":"                service\u003d\"registry\","},{"line_number":69,"context_line":"                host\u003dCONF.bind_host"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a30ddce_e382d251","line":66,"range":{"start_line":66,"start_character":16,"end_line":66,"end_character":62},"in_reply_to":"9a30ddce_3e7faaab","updated":"2017-03-08 02:02:53.000000000","message":"same as above","commit_id":"36b073d9d0aecb58a80cd8326cc525378d109707"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"08e29278f10dad4ae5ddfecf898e7a2de70291c0","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        if CONF.profiler.enabled:"},{"line_number":64,"context_line":"            osprofiler.initializer.init_from_conf("},{"line_number":65,"context_line":"                conf\u003dCONF,"},{"line_number":66,"context_line":"                context\u003dcontext.get_admin_context().to_dict(),"},{"line_number":67,"context_line":"                project\u003d\"glance\","},{"line_number":68,"context_line":"                service\u003d\"registry\","},{"line_number":69,"context_line":"                host\u003dCONF.bind_host"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a30ddce_3e7faaab","line":66,"range":{"start_line":66,"start_character":16,"end_line":66,"end_character":62},"in_reply_to":"ba2be162_22f8a2c4","updated":"2017-03-07 20:54:28.000000000","message":"Why explicit admin context?\nosprofiler does not require it.","commit_id":"36b073d9d0aecb58a80cd8326cc525378d109707"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"347e7459cd528a6a959b2a087df2480b8745070d","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        if CONF.profiler.enabled:"},{"line_number":64,"context_line":"            osprofiler.initializer.init_from_conf("},{"line_number":65,"context_line":"                conf\u003dCONF,"},{"line_number":66,"context_line":"                context\u003dcontext.get_admin_context().to_dict(),"},{"line_number":67,"context_line":"                project\u003d\"glance\","},{"line_number":68,"context_line":"                service\u003d\"registry\","},{"line_number":69,"context_line":"                host\u003dCONF.bind_host"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a30ddce_8392f69d","line":66,"range":{"start_line":66,"start_character":16,"end_line":66,"end_character":62},"in_reply_to":"ba2be162_22f8a2c4","updated":"2017-03-08 02:02:53.000000000","message":"same as above","commit_id":"36b073d9d0aecb58a80cd8326cc525378d109707"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"7484655c381488bcf3449147665bdf5fd776c93e","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        if CONF.profiler.enabled:"},{"line_number":64,"context_line":"            osprofiler.initializer.init_from_conf("},{"line_number":65,"context_line":"                conf\u003dCONF,"},{"line_number":66,"context_line":"                context\u003dcontext.get_admin_context().to_dict(),"},{"line_number":67,"context_line":"                project\u003d\"glance\","},{"line_number":68,"context_line":"                service\u003d\"registry\","},{"line_number":69,"context_line":"                host\u003dCONF.bind_host"}],"source_content_type":"text/x-python","patch_set":14,"id":"bff0334d_7c408436","line":66,"range":{"start_line":66,"start_character":16,"end_line":66,"end_character":62},"updated":"2017-04-05 22:33:18.000000000","message":"The same applies here too, Tovin.","commit_id":"49f958f0df3d99a41d7c0da8cf28e35dd497a26b"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"6aac8ba9bc0a97ac8daaab94f4f7392fff74dc82","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        if CONF.profiler.enabled:"},{"line_number":64,"context_line":"            osprofiler.initializer.init_from_conf("},{"line_number":65,"context_line":"                conf\u003dCONF,"},{"line_number":66,"context_line":"                context\u003dcontext.get_admin_context().to_dict(),"},{"line_number":67,"context_line":"                project\u003d\"glance\","},{"line_number":68,"context_line":"                service\u003d\"registry\","},{"line_number":69,"context_line":"                host\u003dCONF.bind_host"}],"source_content_type":"text/x-python","patch_set":14,"id":"bff0334d_5320dbb0","line":66,"range":{"start_line":66,"start_character":16,"end_line":66,"end_character":62},"in_reply_to":"bff0334d_7c408436","updated":"2017-04-07 00:57:35.000000000","message":"Done","commit_id":"49f958f0df3d99a41d7c0da8cf28e35dd497a26b"}]}