)]}'
{"glance/registry/__init__.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"444eac89c677a8f99ee31b1b5266046de0e1e815","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    * ``cache prefetcher`` (a periodic task)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Possible values:"},{"line_number":36,"context_line":"    * A valid IP"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Related options:"},{"line_number":39,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_4d1c3cc1","line":36,"range":{"start_line":36,"start_character":14,"end_line":36,"end_character":16},"updated":"2016-05-20 12:15:42.000000000","message":"(Feel free to tell me to look this up myself.)\n1 - does it have to be an IP? no symbolic address?\n2 - can it be IPv6?","commit_id":"3c3bcd9c5bf30dbd2bdd0cf9aa5aefe2fdfca404"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"479c248395b1761053c85e0928ce77ae3bbf44d0","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    * ``cache prefetcher`` (a periodic task)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Possible values:"},{"line_number":36,"context_line":"    * A valid IP"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Related options:"},{"line_number":39,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_91ec72f4","line":36,"range":{"start_line":36,"start_character":14,"end_line":36,"end_character":16},"in_reply_to":"bab6814e_4d1c3cc1","updated":"2016-05-20 15:19:14.000000000","message":"This could be a hostname too, I think. That is the reason why I didn\u0027t change the type of this config opt to IPOpt from StrOpt. Currently, in oslo.config there is either a HostnameOpt or IPOpt but nothing that allows either. I\u0027m going to add a new Opt to oslo.config, say HostAddressOpt, that allows either an IP or hostname. Until then this will remain a StrOpt. And, yes, I will change the possible values section to reflect that.\n\nAnd, your question about IPv6. I don\u0027t know off the top of my head. I\u0027ll have to do some research.","commit_id":"3c3bcd9c5bf30dbd2bdd0cf9aa5aefe2fdfca404"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"444eac89c677a8f99ee31b1b5266046de0e1e815","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    * ``cache prefetcher`` (a periodic task)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Possible values:"},{"line_number":52,"context_line":"    * A valid port"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Related options:"},{"line_number":55,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_2dcd7866","line":52,"range":{"start_line":52,"start_character":8,"end_line":52,"end_character":18},"updated":"2016-05-20 12:15:42.000000000","message":"\"valid port number\"?","commit_id":"3c3bcd9c5bf30dbd2bdd0cf9aa5aefe2fdfca404"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"479c248395b1761053c85e0928ce77ae3bbf44d0","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    * ``cache prefetcher`` (a periodic task)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Possible values:"},{"line_number":52,"context_line":"    * A valid port"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Related options:"},{"line_number":55,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_9fe3e3a3","line":52,"range":{"start_line":52,"start_character":8,"end_line":52,"end_character":18},"in_reply_to":"bab6814e_2dcd7866","updated":"2016-05-20 15:19:14.000000000","message":"Done","commit_id":"3c3bcd9c5bf30dbd2bdd0cf9aa5aefe2fdfca404"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"19bea06932df8a9ebc033a9a947e8d45105ad20b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"Services which consume this:"},{"line_number":47,"context_line":"    * ``glance-api`` (mandatory for v1; optional for v2)"},{"line_number":48,"context_line":"    * ``image scrubber`` (a periodic task)"},{"line_number":49,"context_line":"    * ``cache prefetcher`` (a periodic task)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Possible values:"},{"line_number":52,"context_line":"    * A valid port number"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_7072454b","line":49,"updated":"2016-05-24 00:45:11.000000000","message":"I\u0027m not convinced about this section here. This will be added for example to the glance-cache.conf which gives the impression that glance-api and cache prefetcher will consume it from there.\n\nWhile these are handy for the developers, I think this would cause confusion in the users. Thus I\u0027d rather have this kind of info in comment if it\u0027s desired rather than in the config option helptext.","commit_id":"5bc0bee2f7d6068835d90481e58d76c83050aefb"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"19bea06932df8a9ebc033a9a947e8d45105ad20b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    * ``image scrubber`` (a periodic task)"},{"line_number":49,"context_line":"    * ``cache prefetcher`` (a periodic task)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Possible values:"},{"line_number":52,"context_line":"    * A valid port number"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Related options:"},{"line_number":55,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_90ac098e","line":52,"range":{"start_line":51,"start_character":0,"end_line":52,"end_character":25},"updated":"2016-05-24 00:45:11.000000000","message":"Not needed, the range will be provided by config generator. Current:\n\n# Port the registry server is listening on. (port value)\n# Minimum value: 0\n# Maximum value: 65535\n#registry_port \u003d 9191","commit_id":"5bc0bee2f7d6068835d90481e58d76c83050aefb"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"a3b6f8b3edd7c8b061d828ebca16384dcb945c10","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"registry_addr_opts \u003d ["},{"line_number":26,"context_line":"    cfg.StrOpt(\u0027registry_host\u0027, default\u003d\u00270.0.0.0\u0027,"},{"line_number":27,"context_line":"               help\u003d_(\"\"\""},{"line_number":28,"context_line":"Address the registry server is hosted on."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_d0e4b13c","line":26,"range":{"start_line":26,"start_character":8,"end_line":26,"end_character":14},"updated":"2016-08-19 20:47:47.000000000","message":"Perhaps a TODO comment to change this to HostAddressOpt if/when https://review.openstack.org/358045 gets merged?","commit_id":"b158de35c08aa78578f374f125884607468e67d1"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"0ff946a9574e5319b1141054160f936da33f16b8","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"registry_addr_opts \u003d ["},{"line_number":26,"context_line":"    cfg.StrOpt(\u0027registry_host\u0027, default\u003d\u00270.0.0.0\u0027,"},{"line_number":27,"context_line":"               help\u003d_(\"\"\""},{"line_number":28,"context_line":"Address the registry server is hosted on."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_d0d83120","line":26,"range":{"start_line":26,"start_character":8,"end_line":26,"end_character":14},"in_reply_to":"1ac06dbe_d0e4b13c","updated":"2016-08-19 20:54:54.000000000","message":"That\u0027d certainly be a good idea.\nBut, I\u0027d wait at least until we get some kinda of a buy-in from the oslo folks for HostAddressOpt. Otherwise, the TODO would be obsolete in no time.","commit_id":"b158de35c08aa78578f374f125884607468e67d1"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"90ccfd9d31b8cbbaca6029ca84254f9a79367776","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                help\u003d_(\"\"\""},{"line_number":39,"context_line":"Port the registry server is listening on."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Possible values:"},{"line_number":42,"context_line":"    * A valid port number"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Related options:"},{"line_number":45,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_cbc2b233","line":42,"range":{"start_line":41,"start_character":0,"end_line":42,"end_character":25},"updated":"2016-08-23 14:30:01.000000000","message":"This could be dropped. But, it can be done in a separate patch though. We should drop all such sections that don\u0027t add any specific value.","commit_id":"b158de35c08aa78578f374f125884607468e67d1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"947d8cd7909508b098016447fd942423ff260ee5","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    * A valid port number"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Related options:"},{"line_number":45,"context_line":"    * None"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"\"\"\")),"},{"line_number":48,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_0254e4c7","line":45,"updated":"2016-08-22 19:25:02.000000000","message":"I was looking at Erno\u0027s comment from last PS.  This is what the glance-api.conf.sample file looks like for these two options:\n\n#\n# Address the registry server is hosted on.\n#\n# Possible values:\n#     * A valid IP or hostname\n#\n# Related options:\n#     * None\n#\n#  (string value)\n#registry_host \u003d 0.0.0.0\n\n#\n# Port the registry server is listening on.\n#\n# Possible values:\n#     * A valid port number\n#\n# Related options:\n#     * None\n#\n#  (port value)\n# Minimum value: 0\n# Maximum value: 65535\n#registry_port \u003d 9191\n\nI think this is OK, though we could get rid of the empty comment as the beginning by using \"\"\"\\ to kick off the help texts (but let\u0027s not do that in this patch since it hasn\u0027t been done for any of the others).  The empty comment line before the \u0027(datatype)\u0027 is good, and I actually like the \u0027(datatype)\u0027 right before the option someone\u0027s going to edit.  Usually it\u0027s a datatype while the info given in the help text is an interpretation of the value, though for some specialized options, the datatype and interpretation are very close.  (Compare the two above.)","commit_id":"b158de35c08aa78578f374f125884607468e67d1"}]}