)]}'
{"glance/api/v1/images.py":[{"author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"change_message_id":"cb6ab8b1055c47d94183c9ea6c2f3b4282401d53","unresolved":false,"context_lines":[{"line_number":749,"context_line":""},{"line_number":750,"context_line":"        if location_data:"},{"line_number":751,"context_line":"            try:"},{"line_number":752,"context_line":"                LOG.info(_LI(\"Uploaded data of image %s from request \""},{"line_number":753,"context_line":"                     \"payload successfully.\"), image_id)"},{"line_number":754,"context_line":"                image_meta \u003d self._activate(req,"},{"line_number":755,"context_line":"                                            image_id,"},{"line_number":756,"context_line":"                                            location_data,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_95e6a2e6","line":753,"range":{"start_line":752,"start_character":29,"end_line":753,"end_character":44},"updated":"2016-05-24 11:42:36.000000000","message":"This place should abide by pep8.","commit_id":"1acfef3d8d07c94dc832ba4a49fe311ee3bdfe27"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"7e00a25ea285842b6c2fd9b9fadcd0766be2fef2","unresolved":false,"context_lines":[{"line_number":750,"context_line":"        if location_data:"},{"line_number":751,"context_line":"            try:"},{"line_number":752,"context_line":"                LOG.info(_LI(\"Uploaded data of image %s from request \""},{"line_number":753,"context_line":"                             \"payload successfully.\"), image_id)"},{"line_number":754,"context_line":"                image_meta \u003d self._activate(req,"},{"line_number":755,"context_line":"                                            image_id,"},{"line_number":756,"context_line":"                                            location_data,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_e1e65015","line":753,"range":{"start_line":753,"start_character":30,"end_line":753,"end_character":37},"updated":"2016-05-24 12:42:26.000000000","message":"Why couldn\u0027t this message go right before the \"try\"?","commit_id":"5c5799507754a0314481cd17bb6c1128f6841aff"},{"author":{"_account_id":19153,"name":"jingtao liang","email":"liang.jingtao@zte.com.cn","username":"liangjingtao"},"change_message_id":"ad2c1e49823a15b9cb4464acefcbb964130751cd","unresolved":false,"context_lines":[{"line_number":750,"context_line":"        if location_data:"},{"line_number":751,"context_line":"            try:"},{"line_number":752,"context_line":"                LOG.info(_LI(\"Uploaded data of image %s from request \""},{"line_number":753,"context_line":"                             \"payload successfully.\"), image_id)"},{"line_number":754,"context_line":"                image_meta \u003d self._activate(req,"},{"line_number":755,"context_line":"                                            image_id,"},{"line_number":756,"context_line":"                                            location_data,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_258681db","line":753,"range":{"start_line":753,"start_character":30,"end_line":753,"end_character":37},"in_reply_to":"bab6814e_e1e65015","updated":"2016-05-25 01:36:54.000000000","message":"In function(line 747) :location_data \u003d self._upload(req, image_meta), if self._get_from_store(req.context,copy_from,dest\u003dstore) failed, then function upload will return None, but print log \"payload successfully\". So move down the successful log in the \"if conditional statements\".","commit_id":"5c5799507754a0314481cd17bb6c1128f6841aff"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"1dda18590f370dc13b830a69606b5b71a193066f","unresolved":false,"context_lines":[{"line_number":744,"context_line":""},{"line_number":745,"context_line":"        :returns: Mapping of updated image data"},{"line_number":746,"context_line":"        \"\"\""},{"line_number":747,"context_line":"        location_data \u003d self._upload(req, image_meta)"},{"line_number":748,"context_line":"        image_id \u003d image_meta[\u0027id\u0027]"},{"line_number":749,"context_line":"        LOG.info(_LI(\"Uploaded data of image %s from request \""},{"line_number":750,"context_line":"                     \"payload successfully.\"), image_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_0d3f2dd7","side":"PARENT","line":747,"range":{"start_line":747,"start_character":0,"end_line":747,"end_character":53},"updated":"2016-05-30 01:53:50.000000000","message":"If the remote server where the image is present is unavailable, an error will be raised here(in the _upload function) IMO. Then the LOG.info at L749 will not be logged.","commit_id":"e137c39cd4ad77e52f21b27c72e0b94bc35b8136"}]}