)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"4eddce8435b42e9f051cf24c7c236d419a788fe8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Improving help text for public_endpoint for glance-api and"},{"line_number":10,"context_line":"glare-api. Changing the config option to glare_public_endpoint for"},{"line_number":11,"context_line":"Glare\u0027s versions.py to avoid DuplicateError and adding changes to"},{"line_number":12,"context_line":"files that call this."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: If18dc18582bbb3e388ec914af3cba784316879aa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7aa08908_6bf55281","line":11,"range":{"start_line":11,"start_character":29,"end_line":11,"end_character":43},"updated":"2016-06-14 20:16:06.000000000","message":"Can you add a bit more detail about this error? Do you have a stack trace? If this is a bug, we should fix it in a separate patch. \nAlso, while renaming config options we should be careful to not break any backwards compatibility.","commit_id":"78801152cc28465758024f6e4758abb74afffa07"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"0a219cd5ef19eda0c24408948451f90125a4de13","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Improving help text for public_endpoint for glance-api and"},{"line_number":10,"context_line":"glare-api. Changing the config option to glare_public_endpoint for"},{"line_number":11,"context_line":"Glare\u0027s versions.py to avoid DuplicateError and adding changes to"},{"line_number":12,"context_line":"files that call this."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: If18dc18582bbb3e388ec914af3cba784316879aa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7aa08908_46db2b4f","line":11,"range":{"start_line":11,"start_character":29,"end_line":11,"end_character":43},"in_reply_to":"7aa08908_6bf55281","updated":"2016-06-14 20:38:51.000000000","message":"The method \"_is_opt_registered\" in oslo_config/cfg.py checks whether an opt with the same name is already registered. If yes it checks if the parameter\u0027s content differs and rasies a DuplicateError in that case. \nThe files glance/api/versions.py and glance/api/glare/versions.py have the same config option \"public_endpoint\" for their respective versions response. So if the help text differs for both, oslo_config/cfg.py throws a DuplicateError. But since glare has its own API and we need the help text of glare\u0027s public_endpoint to differ from the glance\u0027s public_endpoint I edited the config option for glare to \"glare_public_endpoint\" after which the tests passed despite having differing help texts as it no longer is a duplicate opt.\n\nThe stack trace can be found here: http://paste.openstack.org/show/516059/","commit_id":"78801152cc28465758024f6e4758abb74afffa07"}],"glance/api/glare/versions.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"3a6c8d581a5e32125dfbd22688ee689136816909","unresolved":false,"context_lines":[{"line_number":29,"context_line":"               help\u003d_(\"\"\""},{"line_number":30,"context_line":"Public url endpoint to use for Glance versions response."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"This is the public url endpoint that will appear in the Glance \\\"versions\\\""},{"line_number":33,"context_line":"response. The default endpoint (None) that is displayed in the version\\\u0027s"},{"line_number":34,"context_line":"response is that of the host running the API service. Change the endpoint"},{"line_number":35,"context_line":"to represent the proxy URL if the Glance API service is running behind a"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_ffb3d24a","line":32,"range":{"start_line":32,"start_character":56,"end_line":32,"end_character":62},"updated":"2016-06-08 17:33:00.000000000","message":"Glare?","commit_id":"253cc9423b953393525884a3a6607429a537de55"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"3a6c8d581a5e32125dfbd22688ee689136816909","unresolved":false,"context_lines":[{"line_number":33,"context_line":"response. The default endpoint (None) that is displayed in the version\\\u0027s"},{"line_number":34,"context_line":"response is that of the host running the API service. Change the endpoint"},{"line_number":35,"context_line":"to represent the proxy URL if the Glance API service is running behind a"},{"line_number":36,"context_line":"proxy. If Glance is running behind a load balancer, add the load balancer\\\u0027s"},{"line_number":37,"context_line":"URL for this value."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Services which consume this:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_3f88ba70","line":36,"range":{"start_line":36,"start_character":10,"end_line":36,"end_character":16},"updated":"2016-06-08 17:33:00.000000000","message":"Glare?","commit_id":"253cc9423b953393525884a3a6607429a537de55"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"3a6c8d581a5e32125dfbd22688ee689136816909","unresolved":false,"context_lines":[{"line_number":37,"context_line":"URL for this value."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Services which consume this:"},{"line_number":40,"context_line":"    * glance-api"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Possible values:"},{"line_number":43,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_9f7bae7a","line":40,"range":{"start_line":40,"start_character":6,"end_line":40,"end_character":12},"updated":"2016-06-08 17:33:00.000000000","message":"Shouldn\u0027t this also be glare?","commit_id":"253cc9423b953393525884a3a6607429a537de55"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"df86a4a257ecb0037e794344a471dcb6d602cbb1","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Public url endpoint to use for Glare versions response."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"This is the public url endpoint that will appear in the Glare \\\"versions\\\""},{"line_number":33,"context_line":"response. The default endpoint (None) that is displayed in the version\\\u0027s"},{"line_number":34,"context_line":"response is that of the host running the API service. Change the endpoint"},{"line_number":35,"context_line":"to represent the proxy URL if the Glare API service is running behind a"},{"line_number":36,"context_line":"proxy. If Glare is running behind a load balancer, add the load balancer\\\u0027s"},{"line_number":37,"context_line":"URL for this value."}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_8e6b771d","line":34,"range":{"start_line":33,"start_character":10,"end_line":34,"end_character":53},"updated":"2016-06-08 20:23:06.000000000","message":"I don\u0027t agree with this wording. (None) is not the default endpoint, (None) is the conf value that causes the default behaviour / the host\u0027s name to be displayed.\n\nSuggest something like :\n\"If no value is specified, the endpoint that is displayed in the version\u0027s response is that of the host running the API service.\"","commit_id":"bb78ac0fe5e9d4ecf7812a67c89c6667b6f5ccea"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"f8aaa2eda9c55f4668cf2a3605c8adf1926e8bad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7aa08908_6ea4804a","updated":"2016-06-13 20:22:56.000000000","message":"This file is specifically for Glare, which is a separate API. Does something import it that shouldn\u0027t to be causing your conflict errors you mentioned? I would think this should only ever be imported when using glance-glare.","commit_id":"9c00a4f547da14bd896016cfbfd412f2b22afedd"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"28c1789e10d7b561070c530bffa94d9ea21bfb22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7aa08908_998775b4","in_reply_to":"7aa08908_6ea4804a","updated":"2016-06-14 20:53:58.000000000","message":"The method \"_is_opt_registered\" in oslo_config/cfg.py checks whether an opt with the same name is already registered. If yes it checks if the parameter\u0027s content differs and rasies a DuplicateError in that case. \n\nSince glare has its own API and we need the help text of glare\u0027s public_endpoint to differ from the glance\u0027s public_endpoint, could we possibly edit the name of the config option for glare\u0027s end point and call it accordingly? This no longer fails tests.","commit_id":"9c00a4f547da14bd896016cfbfd412f2b22afedd"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"f8aaa2eda9c55f4668cf2a3605c8adf1926e8bad","unresolved":false,"context_lines":[{"line_number":29,"context_line":"               help\u003d_(\"\"\""},{"line_number":30,"context_line":"Public url endpoint to use for Glance versions response."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"This is the public url endpoint that will appear in the Glance \\\"versions\\\""},{"line_number":33,"context_line":"response. If no value is specified, the endpoint that is displayed in the"},{"line_number":34,"context_line":"version\u0027s response is that of the host running the API service. Change the"},{"line_number":35,"context_line":"endpoint to represent the proxy URL if the Glance API service is running"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_ce63f418","line":32,"updated":"2016-06-13 20:22:56.000000000","message":"Why are you escaping the quotes here?","commit_id":"9c00a4f547da14bd896016cfbfd412f2b22afedd"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"f8aaa2eda9c55f4668cf2a3605c8adf1926e8bad","unresolved":false,"context_lines":[{"line_number":34,"context_line":"version\u0027s response is that of the host running the API service. Change the"},{"line_number":35,"context_line":"endpoint to represent the proxy URL if the Glance API service is running"},{"line_number":36,"context_line":"behind a proxy. If Glance is running behind a load balancer, add the load"},{"line_number":37,"context_line":"balancer\\\u0027s URL for this value."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Services which consume this:"},{"line_number":40,"context_line":"    * glance-api"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_ae6828f6","line":37,"updated":"2016-06-13 20:22:56.000000000","message":"Why are you escaping the \u0027 here?","commit_id":"9c00a4f547da14bd896016cfbfd412f2b22afedd"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"4eddce8435b42e9f051cf24c7c236d419a788fe8","unresolved":false,"context_lines":[{"line_number":25,"context_line":"_ \u003d i18n._"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"versions_opts \u003d ["},{"line_number":28,"context_line":"    cfg.StrOpt(\u0027glare_public_endpoint\u0027,"},{"line_number":29,"context_line":"               help\u003d_(\"\"\""},{"line_number":30,"context_line":"Public url endpoint to use for Glare versions response."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_eb1662a5","line":28,"range":{"start_line":28,"start_character":16,"end_line":28,"end_character":22},"updated":"2016-06-14 20:16:06.000000000","message":"Why do we need this?\nJust trying to understand the reason for this.","commit_id":"78801152cc28465758024f6e4758abb74afffa07"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"3d4fa2ac4b63560dbf7fce1c97ded29cca890f5e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"_ \u003d i18n._"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"versions_opts \u003d ["},{"line_number":28,"context_line":"    cfg.StrOpt(\u0027glare_public_endpoint\u0027,"},{"line_number":29,"context_line":"               help\u003d_(\"\"\""},{"line_number":30,"context_line":"Public url endpoint to use for Glare versions response."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_f3470d75","line":28,"range":{"start_line":28,"start_character":16,"end_line":28,"end_character":22},"in_reply_to":"3aaa91ec_3d7326e9","updated":"2016-06-23 00:19:04.000000000","message":"Done","commit_id":"78801152cc28465758024f6e4758abb74afffa07"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"3d4fa2ac4b63560dbf7fce1c97ded29cca890f5e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"_ \u003d i18n._"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"versions_opts \u003d ["},{"line_number":28,"context_line":"    cfg.StrOpt(\u0027glare_public_endpoint\u0027,"},{"line_number":29,"context_line":"               help\u003d_(\"\"\""},{"line_number":30,"context_line":"Public url endpoint to use for Glare versions response."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_535f0141","line":28,"range":{"start_line":28,"start_character":16,"end_line":28,"end_character":22},"in_reply_to":"7aa08908_eb1662a5","updated":"2016-06-23 00:19:04.000000000","message":"Done","commit_id":"78801152cc28465758024f6e4758abb74afffa07"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"daee34c9c04115f71535d8bddbc1cf929bf12fdb","unresolved":false,"context_lines":[{"line_number":25,"context_line":"_ \u003d i18n._"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"versions_opts \u003d ["},{"line_number":28,"context_line":"    cfg.StrOpt(\u0027glare_public_endpoint\u0027,"},{"line_number":29,"context_line":"               help\u003d_(\"\"\""},{"line_number":30,"context_line":"Public url endpoint to use for Glare versions response."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_3d7326e9","line":28,"range":{"start_line":28,"start_character":16,"end_line":28,"end_character":22},"in_reply_to":"7aa08908_eb1662a5","updated":"2016-06-22 23:04:48.000000000","message":"I agree. We cannot change the config opt. If glance needs a different config opt for that deployment then that can come in a different glare patch. You should limit the scope to text improvements.","commit_id":"78801152cc28465758024f6e4758abb74afffa07"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"7ddf1846e1f9934d6706ac71c865ce6ece67dd24","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"\"\"\")),"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    # Note: Since both glance-api and glare-api have the same name for the"},{"line_number":52,"context_line":"    # option public_endpoint, oslo.config generator throws a DuplicateError"},{"line_number":53,"context_line":"    # exception during the conf file generation incase of differing help"},{"line_number":54,"context_line":"    # texts. Hence we have to have identical help texts for glance-api and"},{"line_number":55,"context_line":"    # glare-api\u0027s public_endpoint if not for changing the conf opt name."},{"line_number":56,"context_line":"]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":15,"id":"3aaa91ec_9adaa376","line":55,"range":{"start_line":51,"start_character":4,"end_line":55,"end_character":72},"updated":"2016-06-30 18:33:26.000000000","message":"We usually add block comments prior to the code that\u0027s being addressed. Let\u0027s move this to line #27.","commit_id":"e41576502b342c26506d14a26840229abe9d694a"}],"glance/api/versions.py":[{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"df86a4a257ecb0037e794344a471dcb6d602cbb1","unresolved":false,"context_lines":[{"line_number":29,"context_line":"Public url endpoint to use for Glance versions response."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"This is the public url endpoint that will appear in the Glance \\\"versions\\\""},{"line_number":32,"context_line":"response. The default endpoint (None) that is displayed in the version\\\u0027s"},{"line_number":33,"context_line":"response is that of the host running the API service. Change the endpoint"},{"line_number":34,"context_line":"to represent the proxy URL if the Glance API service is running behind a"},{"line_number":35,"context_line":"proxy. If Glance is running behind a load balancer, add the load balancer\\\u0027s"},{"line_number":36,"context_line":"URL for this value."}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_4e5cef7c","line":33,"range":{"start_line":32,"start_character":10,"end_line":33,"end_character":53},"updated":"2016-06-08 20:23:06.000000000","message":"Same as other comment.","commit_id":"bb78ac0fe5e9d4ecf7812a67c89c6667b6f5ccea"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"f8aaa2eda9c55f4668cf2a3605c8adf1926e8bad","unresolved":false,"context_lines":[{"line_number":28,"context_line":"               help\u003d_(\"\"\""},{"line_number":29,"context_line":"Public url endpoint to use for Glance versions response."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"This is the public url endpoint that will appear in the Glance \\\"versions\\\""},{"line_number":32,"context_line":"response. If no value is specified, the endpoint that is displayed in the"},{"line_number":33,"context_line":"version\u0027s response is that of the host running the API service. Change the"},{"line_number":34,"context_line":"endpoint to represent the proxy URL if the Glance API service is running"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_2eaef82d","line":31,"updated":"2016-06-13 20:22:56.000000000","message":"Same question here","commit_id":"9c00a4f547da14bd896016cfbfd412f2b22afedd"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"f8aaa2eda9c55f4668cf2a3605c8adf1926e8bad","unresolved":false,"context_lines":[{"line_number":33,"context_line":"version\u0027s response is that of the host running the API service. Change the"},{"line_number":34,"context_line":"endpoint to represent the proxy URL if the Glance API service is running"},{"line_number":35,"context_line":"behind a proxy. If Glance is running behind a load balancer, add the load"},{"line_number":36,"context_line":"balancer\\\u0027s URL for this value."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Services which consume this:"},{"line_number":39,"context_line":"    * glance-api"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_8ea72c4f","line":36,"updated":"2016-06-13 20:22:56.000000000","message":"And here","commit_id":"9c00a4f547da14bd896016cfbfd412f2b22afedd"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"43540edc516cc47ace5deba7e2812bd5634276f4","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"versions_opts \u003d ["},{"line_number":26,"context_line":"    cfg.StrOpt(\u0027public_endpoint\u0027,"},{"line_number":27,"context_line":"               help\u003d_(\u0027Public url to use for versions endpoint. The default \u0027"},{"line_number":28,"context_line":"                      \u0027is None, which will use the request\\\u0027s host_url \u0027"},{"line_number":29,"context_line":"                      \u0027attribute to populate the URL base. If Glance is \u0027"},{"line_number":30,"context_line":"                      \u0027operating behind a proxy, you will want to change \u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"3aaa91ec_116cb506","side":"PARENT","line":27,"updated":"2016-06-27 09:48:50.000000000","message":"IMO this text is good enough","commit_id":"df5a4552f417eac5a21c3c9fdcda521b1e374faf"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"c08910c76cf87193f45079331a7f91bdd5f99b77","unresolved":false,"context_lines":[{"line_number":32,"context_line":"version\u0027s response is that of the host running the API service. Change the"},{"line_number":33,"context_line":"endpoint to represent the proxy URL if the API service is running behind a"},{"line_number":34,"context_line":"proxy. If the service is running behind a load balancer, add the load"},{"line_number":35,"context_line":"balancer\u0027s URL for this value."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Services which consume this:"},{"line_number":38,"context_line":"    * glance-api/glare-api"}],"source_content_type":"text/x-python","patch_set":11,"id":"3aaa91ec_6e2188fc","line":35,"range":{"start_line":35,"start_character":14,"end_line":35,"end_character":30},"updated":"2016-06-28 13:57:41.000000000","message":"Is it correct to use absolute formatting here?\nI saw the following patch: https://review.openstack.org/#/c/323779/\nSo looks like absolute formatting leads to confusing configurations when using oslo config generator. WDYT?","commit_id":"9b14873053ab276ebef5fd62a7fdfccf00a70d87"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"f24891fde68ebbdfd3727b4f4b83696d9b4892ef","unresolved":false,"context_lines":[{"line_number":32,"context_line":"version\u0027s response is that of the host running the API service. Change the"},{"line_number":33,"context_line":"endpoint to represent the proxy URL if the API service is running behind a"},{"line_number":34,"context_line":"proxy. If the service is running behind a load balancer, add the load"},{"line_number":35,"context_line":"balancer\u0027s URL for this value."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Services which consume this:"},{"line_number":38,"context_line":"    * glance-api/glare-api"}],"source_content_type":"text/x-python","patch_set":11,"id":"3aaa91ec_ccbb5274","line":35,"range":{"start_line":35,"start_character":14,"end_line":35,"end_character":30},"in_reply_to":"3aaa91ec_6e2188fc","updated":"2016-06-28 19:46:10.000000000","message":"Done","commit_id":"9b14873053ab276ebef5fd62a7fdfccf00a70d87"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"37d6b462dd1093df0d0d11222f54ccecb4bfbe2d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"behind a load balancer, add the load balancer\u0027s URL for this value."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Services which consume this:"},{"line_number":38,"context_line":"    * glance-api/glare-api"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Possible values:"},{"line_number":41,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":14,"id":"3aaa91ec_5a65ed42","line":38,"updated":"2016-06-30 13:37:07.000000000","message":"Won\u0027t \"Glare\" confuse users here?\nIIUC it is not consumed by glare so we can use Glance here.","commit_id":"b0e838293f65d4e467ef651aa7455cd3755ae85c"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"e5fe5a23ed61bea765cdb2913c4d82687c509ac3","unresolved":false,"context_lines":[{"line_number":35,"context_line":"behind a load balancer, add the load balancer\u0027s URL for this value."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Services which consume this:"},{"line_number":38,"context_line":"    * glance-api/glare-api"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Possible values:"},{"line_number":41,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":14,"id":"3aaa91ec_feac86ee","line":38,"in_reply_to":"3aaa91ec_5a65ed42","updated":"2016-06-30 15:13:47.000000000","message":"You\u0027re right, it\u0027s confusing.\nIn one of the earlier patchsets, Dharini had different descriptions for this and the glare public_endpoint config. But, since the config is defined twice, oslo.config would throw a DuplicateOpt exception. However, if both definitions are exactly identical (including the help text that is), oslo.config considers them as the same and won\u0027t treat it as an error.\n\nDharini tried to rename the public_endpoint of glare to \u0027glare_public_endpoint\u0027. But, that would mean we\u0027d have to go through the deprecation cycle. And, it\u0027s really something that needs to be addressed in a separate patch. So, that\u0027s the reason we have the same help text for both config definitions. Hence, the confusion.\n\nLet us know if you have a better suggestion for tackling this.","commit_id":"b0e838293f65d4e467ef651aa7455cd3755ae85c"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"7ddf1846e1f9934d6706ac71c865ce6ece67dd24","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"\"\"\")),"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    # Note: Since both glance-api and glare-api have the same name for the"},{"line_number":51,"context_line":"    # option public_endpoint, oslo.config generator throws a DuplicateError"},{"line_number":52,"context_line":"    # exception during the conf file generation incase of differing help"},{"line_number":53,"context_line":"    # texts. Hence we have to have identical help texts for glance-api and"},{"line_number":54,"context_line":"    # glare-api\u0027s public_endpoint if not for changing the conf opt name."},{"line_number":55,"context_line":"]"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":15,"id":"3aaa91ec_5aa67b0f","line":54,"range":{"start_line":50,"start_character":3,"end_line":54,"end_character":72},"updated":"2016-06-30 18:33:26.000000000","message":"same","commit_id":"e41576502b342c26506d14a26840229abe9d694a"}]}