)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"287a91d7484772db0849e5804dc44e2d27ed497d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Deprecate the Glance v1 API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This gives a warning for using the v1 API in Newton and encourages users"},{"line_number":10,"context_line":"to switch to v2 before the P release where it will be removed."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"DocImpact"},{"line_number":13,"context_line":"Implements blueprint deprecate-glance-v1-api"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3aaa91ec_e22827f1","line":10,"range":{"start_line":10,"start_character":46,"end_line":10,"end_character":62},"updated":"2016-07-01 17:19:22.000000000","message":"To prevent freakouts by various parties, I suggest changing the end of this sentence to:\n\nis scheduled to be removed, following the OpenStack standard deprecation policy.","commit_id":"77339cb9ce04296e27de3c090e27c10c72f9953f"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"71eb966695b243bc5161ba1a334da32634a60abc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Deprecate the Glance v1 API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This gives a warning for using the v1 API in Newton and encourages users"},{"line_number":10,"context_line":"to switch to v2 before the P release where it will be removed."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"DocImpact"},{"line_number":13,"context_line":"Implements blueprint deprecate-glance-v1-api"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1aa78d24_65ce97b5","line":10,"range":{"start_line":10,"start_character":46,"end_line":10,"end_character":62},"in_reply_to":"3aaa91ec_e22827f1","updated":"2016-07-05 19:35:56.000000000","message":"Done","commit_id":"77339cb9ce04296e27de3c090e27c10c72f9953f"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"9cf739f02d23b170db29c916c1a7f698ab67f187","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to switch to v2 before the P release where it is scheduled to be removed,"},{"line_number":11,"context_line":"following the OpenStack standard deprecation policy."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"DocImpact"},{"line_number":14,"context_line":"Implements blueprint deprecate-glance-v1-api"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Iab0c4abaea247044fee545342ac450e3415432f7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1aa78d24_53fcc171","line":13,"updated":"2016-07-06 20:15:17.000000000","message":"So, does it need APIImpact also?","commit_id":"7a3679dc0aadab65546a0b79c14dd020dc4d8825"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"6df292c0120565cd2a0344923591d9f1e6a4da98","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to switch to v2 before the P release where it is scheduled to be removed,"},{"line_number":11,"context_line":"following the OpenStack standard deprecation policy."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"DocImpact"},{"line_number":14,"context_line":"Implements blueprint deprecate-glance-v1-api"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Iab0c4abaea247044fee545342ac450e3415432f7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dada55a8_58e98de5","line":13,"in_reply_to":"1aa78d24_53fcc171","updated":"2016-07-20 15:31:44.000000000","message":"I don\u0027t think so. The API itself does not change.","commit_id":"7a3679dc0aadab65546a0b79c14dd020dc4d8825"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"0eaca5e87cab34ae84f50bc963d0b0be224173d9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to switch to v2 before the P release where it is scheduled to be removed,"},{"line_number":11,"context_line":"following the OpenStack standard deprecation policy."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"DocImpact"},{"line_number":14,"context_line":"Implements blueprint deprecate-glance-v1-api"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Iab0c4abaea247044fee545342ac450e3415432f7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1ac06dbe_9816ce53","line":13,"in_reply_to":"dada55a8_58e98de5","updated":"2016-08-25 05:14:16.000000000","message":"UpgradeImpact","commit_id":"7a3679dc0aadab65546a0b79c14dd020dc4d8825"}],"glance/api/versions.py":[{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"1bb3cb6534dd962a8ea1ebc2c13dc6ccbe61661c","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                build_version_object(2.0, \u0027v2\u0027, \u0027SUPPORTED\u0027),"},{"line_number":67,"context_line":"            ])"},{"line_number":68,"context_line":"        if CONF.enable_v1_api:"},{"line_number":69,"context_line":"            LOG.warn(_(\u0027The v1 api is deprecated and will be removed after \u0027"},{"line_number":70,"context_line":"                       \u0027the Ocata release. You should set \u0027"},{"line_number":71,"context_line":"                       \u0027enable_v1_api\u003dfalse and enable_v2_api\u003dtrue in your \u0027"},{"line_number":72,"context_line":"                       \u0027glance-api.conf file.\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_0ab1b78f","line":69,"updated":"2016-06-10 18:56:31.000000000","message":"Nit: use _LW()","commit_id":"adc874c378812745cfd64970463533e4fc3518c3"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"d89ec83c90307ad217a843cb80584e00ff3ee821","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                build_version_object(2.0, \u0027v2\u0027, \u0027SUPPORTED\u0027),"},{"line_number":67,"context_line":"            ])"},{"line_number":68,"context_line":"        if CONF.enable_v1_api:"},{"line_number":69,"context_line":"            LOG.warn(_(\u0027The v1 api is deprecated and will be removed after \u0027"},{"line_number":70,"context_line":"                       \u0027the Ocata release. You should set \u0027"},{"line_number":71,"context_line":"                       \u0027enable_v1_api\u003dfalse and enable_v2_api\u003dtrue in your \u0027"},{"line_number":72,"context_line":"                       \u0027glance-api.conf file.\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_e90e528b","line":69,"in_reply_to":"7aa08908_0ab1b78f","updated":"2016-07-01 16:42:13.000000000","message":"Done","commit_id":"adc874c378812745cfd64970463533e4fc3518c3"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"287a91d7484772db0849e5804dc44e2d27ed497d","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                build_version_object(2.0, \u0027v2\u0027, \u0027SUPPORTED\u0027),"},{"line_number":67,"context_line":"            ])"},{"line_number":68,"context_line":"        if CONF.enable_v1_api:"},{"line_number":69,"context_line":"            LOG.warn(_LW(\u0027The v1 api is deprecated and will be removed after \u0027"},{"line_number":70,"context_line":"                         \u0027the Ocata release. You should set \u0027"},{"line_number":71,"context_line":"                         \u0027enable_v1_api\u003dfalse and enable_v2_api\u003dtrue in your \u0027"},{"line_number":72,"context_line":"                         \u0027glance-api.conf file.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_e25dc77d","line":69,"range":{"start_line":69,"start_character":33,"end_line":69,"end_character":36},"updated":"2016-07-01 17:19:22.000000000","message":"super-nit: s/api/API/","commit_id":"77339cb9ce04296e27de3c090e27c10c72f9953f"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"71eb966695b243bc5161ba1a334da32634a60abc","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                build_version_object(2.0, \u0027v2\u0027, \u0027SUPPORTED\u0027),"},{"line_number":67,"context_line":"            ])"},{"line_number":68,"context_line":"        if CONF.enable_v1_api:"},{"line_number":69,"context_line":"            LOG.warn(_LW(\u0027The v1 api is deprecated and will be removed after \u0027"},{"line_number":70,"context_line":"                         \u0027the Ocata release. You should set \u0027"},{"line_number":71,"context_line":"                         \u0027enable_v1_api\u003dfalse and enable_v2_api\u003dtrue in your \u0027"},{"line_number":72,"context_line":"                         \u0027glance-api.conf file.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_e5e3a731","line":69,"range":{"start_line":69,"start_character":33,"end_line":69,"end_character":36},"in_reply_to":"3aaa91ec_e25dc77d","updated":"2016-07-05 19:35:56.000000000","message":"Done","commit_id":"77339cb9ce04296e27de3c090e27c10c72f9953f"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"8b14d13ff9fff5fb6830de168a0e4b57f0433c24","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            ])"},{"line_number":92,"context_line":"        if CONF.enable_v1_api:"},{"line_number":93,"context_line":"            LOG.warn(_LW(\u0027The v1 API is deprecated and will be removed after \u0027"},{"line_number":94,"context_line":"                         \u0027the Ocata release. You should set \u0027"},{"line_number":95,"context_line":"                         \u0027enable_v1_api\u003dfalse and enable_v2_api\u003dtrue in your \u0027"},{"line_number":96,"context_line":"                         \u0027glance-api.conf file.\u0027))"},{"line_number":97,"context_line":"            version_objs.extend(["}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_7d65d0df","line":94,"range":{"start_line":94,"start_character":30,"end_line":94,"end_character":43},"updated":"2016-08-26 00:45:41.000000000","message":"I am guessing the i18n team ignores such first nouns.","commit_id":"f921e842815cbe355d52e69b7186c98b9b1a7908"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"53598a0b8a7928b3554294cc569e981baff6b9ba","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            ])"},{"line_number":92,"context_line":"        if CONF.enable_v1_api:"},{"line_number":93,"context_line":"            LOG.warn(_LW(\u0027The v1 API is deprecated and will be removed after \u0027"},{"line_number":94,"context_line":"                         \u0027the Ocata release. You should set \u0027"},{"line_number":95,"context_line":"                         \u0027enable_v1_api\u003dfalse and enable_v2_api\u003dtrue in your \u0027"},{"line_number":96,"context_line":"                         \u0027glance-api.conf file.\u0027))"},{"line_number":97,"context_line":"            version_objs.extend(["}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_4078f8f2","line":94,"range":{"start_line":94,"start_character":30,"end_line":94,"end_character":43},"in_reply_to":"fa7ab95a_7d65d0df","updated":"2016-08-26 14:34:56.000000000","message":"Improved this string.","commit_id":"f921e842815cbe355d52e69b7186c98b9b1a7908"}],"glance/common/config.py":[{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"1bb3cb6534dd962a8ea1ebc2c13dc6ccbe61661c","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                      \u0027act in case they were wrong.\u0027)),"},{"line_number":88,"context_line":"]"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"_DEPRECATE_GLANCE_V1_MSG \u003d (\u0027This option is useless since Glance v1 API is \u0027"},{"line_number":91,"context_line":"                            \u0027deprecated and only v2 API should be deployed.\u0027)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"common_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_aa3ea3d7","line":90,"updated":"2016-06-10 18:56:31.000000000","message":"Nit: Can you add translation _()","commit_id":"adc874c378812745cfd64970463533e4fc3518c3"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"d89ec83c90307ad217a843cb80584e00ff3ee821","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                      \u0027act in case they were wrong.\u0027)),"},{"line_number":88,"context_line":"]"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"_DEPRECATE_GLANCE_V1_MSG \u003d (\u0027This option is useless since Glance v1 API is \u0027"},{"line_number":91,"context_line":"                            \u0027deprecated and only v2 API should be deployed.\u0027)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"common_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_c95d567e","line":90,"in_reply_to":"7aa08908_aa3ea3d7","updated":"2016-07-01 16:42:13.000000000","message":"Done","commit_id":"adc874c378812745cfd64970463533e4fc3518c3"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"7021d73b873f24d368a45fa27b6ad999d2f6871f","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                      \"respectively. If no unit is specified then Bytes is \""},{"line_number":148,"context_line":"                      \"assumed. Note that there should not be any space \""},{"line_number":149,"context_line":"                      \"between value and unit and units are case sensitive.\")),"},{"line_number":150,"context_line":"    cfg.BoolOpt(\u0027enable_v1_api\u0027, default\u003dTrue, deprecated_for_removal\u003dTrue,"},{"line_number":151,"context_line":"                deprecated_reason\u003d_DEPRECATE_GLANCE_V1_MSG,"},{"line_number":152,"context_line":"                help\u003d_(\"Deploy the v1 OpenStack Images API.\")),"},{"line_number":153,"context_line":"    cfg.BoolOpt(\u0027enable_v2_api\u0027, default\u003dTrue, deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_988e6577","line":150,"range":{"start_line":150,"start_character":41,"end_line":150,"end_character":45},"updated":"2016-07-20 15:30:38.000000000","message":"I think we should change this to False as well with the deprecation. We should not enable deprecated functionality by default.","commit_id":"7a3679dc0aadab65546a0b79c14dd020dc4d8825"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"0eaca5e87cab34ae84f50bc963d0b0be224173d9","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                      \"respectively. If no unit is specified then Bytes is \""},{"line_number":148,"context_line":"                      \"assumed. Note that there should not be any space \""},{"line_number":149,"context_line":"                      \"between value and unit and units are case sensitive.\")),"},{"line_number":150,"context_line":"    cfg.BoolOpt(\u0027enable_v1_api\u0027, default\u003dTrue, deprecated_for_removal\u003dTrue,"},{"line_number":151,"context_line":"                deprecated_reason\u003d_DEPRECATE_GLANCE_V1_MSG,"},{"line_number":152,"context_line":"                help\u003d_(\"Deploy the v1 OpenStack Images API.\")),"},{"line_number":153,"context_line":"    cfg.BoolOpt(\u0027enable_v2_api\u0027, default\u003dTrue, deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_fb409c37","line":150,"range":{"start_line":150,"start_character":41,"end_line":150,"end_character":45},"in_reply_to":"dada55a8_988e6577","updated":"2016-08-25 05:14:16.000000000","message":"I think this might be related to the devstack and testing in gate for some projects that didn\u0027t get opportunity to port completely to v2 yet.\n\nIt\u0027s not a big deal, we can do this in early ocata and leave enough time for ML discussions when gate starts failing for some projects.","commit_id":"7a3679dc0aadab65546a0b79c14dd020dc4d8825"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"9cf739f02d23b170db29c916c1a7f698ab67f187","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                deprecated_reason\u003d_DEPRECATE_GLANCE_V1_MSG,"},{"line_number":152,"context_line":"                help\u003d_(\"Deploy the v1 OpenStack Images API.\")),"},{"line_number":153,"context_line":"    cfg.BoolOpt(\u0027enable_v2_api\u0027, default\u003dTrue, deprecated_for_removal\u003dTrue,"},{"line_number":154,"context_line":"                deprecated_reason\u003d_DEPRECATE_GLANCE_V1_MSG,"},{"line_number":155,"context_line":"                help\u003d_(\"Deploy the v2 OpenStack Images API.\")),"},{"line_number":156,"context_line":"    cfg.BoolOpt(\u0027enable_v1_registry\u0027, default\u003dTrue,"},{"line_number":157,"context_line":"                deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_5358418a","line":154,"updated":"2016-07-06 20:15:17.000000000","message":"You will also need deprecated_since.","commit_id":"7a3679dc0aadab65546a0b79c14dd020dc4d8825"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"0eaca5e87cab34ae84f50bc963d0b0be224173d9","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                deprecated_reason\u003d_DEPRECATE_GLANCE_V1_MSG,"},{"line_number":152,"context_line":"                help\u003d_(\"Deploy the v1 OpenStack Images API.\")),"},{"line_number":153,"context_line":"    cfg.BoolOpt(\u0027enable_v2_api\u0027, default\u003dTrue, deprecated_for_removal\u003dTrue,"},{"line_number":154,"context_line":"                deprecated_reason\u003d_DEPRECATE_GLANCE_V1_MSG,"},{"line_number":155,"context_line":"                help\u003d_(\"Deploy the v2 OpenStack Images API.\")),"},{"line_number":156,"context_line":"    cfg.BoolOpt(\u0027enable_v1_registry\u0027, default\u003dTrue,"},{"line_number":157,"context_line":"                deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_db3de0bc","line":154,"in_reply_to":"1aa78d24_5358418a","updated":"2016-08-25 05:14:16.000000000","message":"+1","commit_id":"7a3679dc0aadab65546a0b79c14dd020dc4d8825"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"b5a10795b65b6e5c52802d26fb494976bd45a718","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                      \u0027act in case they were wrong.\u0027)),"},{"line_number":88,"context_line":"]"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"_DEPRECATE_GLANCE_V1_MSG \u003d _(\u0027This option is useless since Glance v1 API is \u0027"},{"line_number":91,"context_line":"                             \u0027deprecated and only v2 API should be deployed.\u0027)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"common_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_adcf0daf","line":90,"range":{"start_line":90,"start_character":45,"end_line":90,"end_character":52},"updated":"2016-08-26 11:12:04.000000000","message":"I have problem with use of \"useless\" here. While it\u0027s not advised to use v1 after derecation, these options are not \"useless\" until they don\u0027t affect anything. And afaik they still do.\n\nWe could change the message to something like: \"This option is deprecated with Images API v1 and should not be used in production anymore.\"","commit_id":"f921e842815cbe355d52e69b7186c98b9b1a7908"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"bb3ba2b28f81e406365b75d75cf5c4beb5bc1267","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                      \u0027act in case they were wrong.\u0027)),"},{"line_number":88,"context_line":"]"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"_DEPRECATE_GLANCE_V1_MSG \u003d _(\u0027This option is useless since Glance v1 API is \u0027"},{"line_number":91,"context_line":"                             \u0027deprecated and only v2 API should be deployed.\u0027)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"common_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_77c4c45e","line":90,"range":{"start_line":90,"start_character":45,"end_line":90,"end_character":52},"in_reply_to":"fa7ab95a_01b1928f","updated":"2016-08-27 03:30:35.000000000","message":"Done","commit_id":"f921e842815cbe355d52e69b7186c98b9b1a7908"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"f80cfcb211d4da0386c467a6ab20411eb1bb3b81","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                      \u0027act in case they were wrong.\u0027)),"},{"line_number":88,"context_line":"]"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"_DEPRECATE_GLANCE_V1_MSG \u003d _(\u0027This option is useless since Glance v1 API is \u0027"},{"line_number":91,"context_line":"                             \u0027deprecated and only v2 API should be deployed.\u0027)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"common_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_13d9e9f3","line":90,"range":{"start_line":90,"start_character":45,"end_line":90,"end_character":52},"in_reply_to":"fa7ab95a_01b1928f","updated":"2016-08-26 15:17:09.000000000","message":"I like this message better.\nHowever, this message (and the current one) may not explain the deprecation of enable_v2_api opt in a straightforward manner. One would end up asking the same question that Alex did on this patchset. And, hence, I think we need a slightly different deprecation message for enable_v2_api.","commit_id":"f921e842815cbe355d52e69b7186c98b9b1a7908"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"bb3ba2b28f81e406365b75d75cf5c4beb5bc1267","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                      \u0027act in case they were wrong.\u0027)),"},{"line_number":88,"context_line":"]"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"_DEPRECATE_GLANCE_V1_MSG \u003d _(\u0027This option is useless since Glance v1 API is \u0027"},{"line_number":91,"context_line":"                             \u0027deprecated and only v2 API should be deployed.\u0027)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"common_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_57c98077","line":90,"range":{"start_line":90,"start_character":45,"end_line":90,"end_character":52},"in_reply_to":"fa7ab95a_13d9e9f3","updated":"2016-08-27 03:30:35.000000000","message":"Done","commit_id":"f921e842815cbe355d52e69b7186c98b9b1a7908"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"921daa35d592308fdad52261a4e9dad6eccdb06f","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                      \u0027act in case they were wrong.\u0027)),"},{"line_number":88,"context_line":"]"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"_DEPRECATE_GLANCE_V1_MSG \u003d _(\u0027This option is useless since Glance v1 API is \u0027"},{"line_number":91,"context_line":"                             \u0027deprecated and only v2 API should be deployed.\u0027)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"common_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_01b1928f","line":90,"range":{"start_line":90,"start_character":45,"end_line":90,"end_character":52},"in_reply_to":"fa7ab95a_adcf0daf","updated":"2016-08-26 15:03:19.000000000","message":"I agree with Erno.  Maybe:\n\nThe Images version 1 API has been DEPRECATED in the Newton release and will be removed in a future release, following the standard OpenStack deprecation policy.  Hence, configuration options specific to the v1 API are hereby deprecated and subject to removal.  Operators are advised to deploy the Images v2 API.","commit_id":"f921e842815cbe355d52e69b7186c98b9b1a7908"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"f80cfcb211d4da0386c467a6ab20411eb1bb3b81","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    * None"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"\"\"\")),"},{"line_number":196,"context_line":"    # NOTE(nikhil): Thie configuration option ``enable_v1_api`` is set to True"},{"line_number":197,"context_line":"    # by default on purpose. Having it enabled helps the projects that haven\u0027t"},{"line_number":198,"context_line":"    # been able to fully move to v2 yet by keeping the devstack setup to use"},{"line_number":199,"context_line":"    # glance v1 as well. We need to switch it to False by default soon after"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_738f9523","line":196,"range":{"start_line":196,"start_character":20,"end_line":196,"end_character":24},"updated":"2016-08-26 15:17:09.000000000","message":"This","commit_id":"f921e842815cbe355d52e69b7186c98b9b1a7908"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"bb3ba2b28f81e406365b75d75cf5c4beb5bc1267","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    * None"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"\"\"\")),"},{"line_number":196,"context_line":"    # NOTE(nikhil): Thie configuration option ``enable_v1_api`` is set to True"},{"line_number":197,"context_line":"    # by default on purpose. Having it enabled helps the projects that haven\u0027t"},{"line_number":198,"context_line":"    # been able to fully move to v2 yet by keeping the devstack setup to use"},{"line_number":199,"context_line":"    # glance v1 as well. We need to switch it to False by default soon after"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_f70c543d","line":196,"range":{"start_line":196,"start_character":20,"end_line":196,"end_character":24},"in_reply_to":"fa7ab95a_738f9523","updated":"2016-08-27 03:30:35.000000000","message":"changed the language a bit","commit_id":"f921e842815cbe355d52e69b7186c98b9b1a7908"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"85b2140390e2441c31eb3c4592b4533f41a0b6d3","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    # affect the release."},{"line_number":204,"context_line":"    cfg.BoolOpt(\u0027enable_v1_api\u0027, default\u003dTrue, deprecated_for_removal\u003dTrue,"},{"line_number":205,"context_line":"                deprecated_reason\u003d_DEPRECATE_GLANCE_V1_MSG,"},{"line_number":206,"context_line":"                deprecated_since\u003d_(\u0027Newton\u0027),"},{"line_number":207,"context_line":"                help\u003d_(\"Deploy the v1 OpenStack Images API.\")),"},{"line_number":208,"context_line":"    cfg.BoolOpt(\u0027enable_v2_api\u0027, default\u003dTrue, deprecated_for_removal\u003dTrue,"},{"line_number":209,"context_line":"                deprecated_reason\u003d_DEPRECATE_GLANCE_V1_MSG,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_acb64c3b","line":206,"range":{"start_line":206,"start_character":33,"end_line":206,"end_character":44},"updated":"2016-08-25 22:53:01.000000000","message":"nit: is the release name translatable, or is it \u0027Newton\u0027 in all languages?","commit_id":"f921e842815cbe355d52e69b7186c98b9b1a7908"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"b5a10795b65b6e5c52802d26fb494976bd45a718","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    # affect the release."},{"line_number":204,"context_line":"    cfg.BoolOpt(\u0027enable_v1_api\u0027, default\u003dTrue, deprecated_for_removal\u003dTrue,"},{"line_number":205,"context_line":"                deprecated_reason\u003d_DEPRECATE_GLANCE_V1_MSG,"},{"line_number":206,"context_line":"                deprecated_since\u003d_(\u0027Newton\u0027),"},{"line_number":207,"context_line":"                help\u003d_(\"Deploy the v1 OpenStack Images API.\")),"},{"line_number":208,"context_line":"    cfg.BoolOpt(\u0027enable_v2_api\u0027, default\u003dTrue, deprecated_for_removal\u003dTrue,"},{"line_number":209,"context_line":"                deprecated_reason\u003d_DEPRECATE_GLANCE_V1_MSG,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_ad146df5","line":206,"range":{"start_line":206,"start_character":33,"end_line":206,"end_character":44},"in_reply_to":"fa7ab95a_5d41ec38","updated":"2016-08-26 11:12:04.000000000","message":"if we respin, we should remove the translations from these, if not I\u0027m fine with it.","commit_id":"f921e842815cbe355d52e69b7186c98b9b1a7908"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"bb3ba2b28f81e406365b75d75cf5c4beb5bc1267","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    # affect the release."},{"line_number":204,"context_line":"    cfg.BoolOpt(\u0027enable_v1_api\u0027, default\u003dTrue, deprecated_for_removal\u003dTrue,"},{"line_number":205,"context_line":"                deprecated_reason\u003d_DEPRECATE_GLANCE_V1_MSG,"},{"line_number":206,"context_line":"                deprecated_since\u003d_(\u0027Newton\u0027),"},{"line_number":207,"context_line":"                help\u003d_(\"Deploy the v1 OpenStack Images API.\")),"},{"line_number":208,"context_line":"    cfg.BoolOpt(\u0027enable_v2_api\u0027, default\u003dTrue, deprecated_for_removal\u003dTrue,"},{"line_number":209,"context_line":"                deprecated_reason\u003d_DEPRECATE_GLANCE_V1_MSG,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_d709102e","line":206,"range":{"start_line":206,"start_character":33,"end_line":206,"end_character":44},"in_reply_to":"fa7ab95a_9b41a03c","updated":"2016-08-27 03:30:35.000000000","message":"Done","commit_id":"f921e842815cbe355d52e69b7186c98b9b1a7908"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"39f14384b065be2ae1635748ed0d0ba57347e680","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    # affect the release."},{"line_number":204,"context_line":"    cfg.BoolOpt(\u0027enable_v1_api\u0027, default\u003dTrue, deprecated_for_removal\u003dTrue,"},{"line_number":205,"context_line":"                deprecated_reason\u003d_DEPRECATE_GLANCE_V1_MSG,"},{"line_number":206,"context_line":"                deprecated_since\u003d_(\u0027Newton\u0027),"},{"line_number":207,"context_line":"                help\u003d_(\"Deploy the v1 OpenStack Images API.\")),"},{"line_number":208,"context_line":"    cfg.BoolOpt(\u0027enable_v2_api\u0027, default\u003dTrue, deprecated_for_removal\u003dTrue,"},{"line_number":209,"context_line":"                deprecated_reason\u003d_DEPRECATE_GLANCE_V1_MSG,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_5d41ec38","line":206,"range":{"start_line":206,"start_character":33,"end_line":206,"end_character":44},"in_reply_to":"fa7ab95a_acb64c3b","updated":"2016-08-26 00:44:56.000000000","message":"I wasn\u0027t sure so, went with the safer route. Lack of patience to contact anyone in i18n :)","commit_id":"f921e842815cbe355d52e69b7186c98b9b1a7908"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"8ae326e2e672e2b79acc3b8b10f2a45f59a657f2","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    # affect the release."},{"line_number":204,"context_line":"    cfg.BoolOpt(\u0027enable_v1_api\u0027, default\u003dTrue, deprecated_for_removal\u003dTrue,"},{"line_number":205,"context_line":"                deprecated_reason\u003d_DEPRECATE_GLANCE_V1_MSG,"},{"line_number":206,"context_line":"                deprecated_since\u003d_(\u0027Newton\u0027),"},{"line_number":207,"context_line":"                help\u003d_(\"Deploy the v1 OpenStack Images API.\")),"},{"line_number":208,"context_line":"    cfg.BoolOpt(\u0027enable_v2_api\u0027, default\u003dTrue, deprecated_for_removal\u003dTrue,"},{"line_number":209,"context_line":"                deprecated_reason\u003d_DEPRECATE_GLANCE_V1_MSG,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_9b41a03c","line":206,"range":{"start_line":206,"start_character":33,"end_line":206,"end_character":44},"in_reply_to":"fa7ab95a_ad146df5","updated":"2016-08-26 12:18:03.000000000","message":"Release names are not translated. we should remove this.","commit_id":"f921e842815cbe355d52e69b7186c98b9b1a7908"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"37ef13a5a76503513d35b2c0aadf5e7ce2909ca8","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                deprecated_reason\u003d_DEPRECATE_GLANCE_V1_MSG,"},{"line_number":206,"context_line":"                deprecated_since\u003d_(\u0027Newton\u0027),"},{"line_number":207,"context_line":"                help\u003d_(\"Deploy the v1 OpenStack Images API.\")),"},{"line_number":208,"context_line":"    cfg.BoolOpt(\u0027enable_v2_api\u0027, default\u003dTrue, deprecated_for_removal\u003dTrue,"},{"line_number":209,"context_line":"                deprecated_reason\u003d_DEPRECATE_GLANCE_V1_MSG,"},{"line_number":210,"context_line":"                deprecated_since\u003d_(\u0027Newton\u0027),"},{"line_number":211,"context_line":"                help\u003d_(\"Deploy the v2 OpenStack Images API.\")),"},{"line_number":212,"context_line":"    cfg.BoolOpt(\u0027enable_v1_registry\u0027, default\u003dTrue,"},{"line_number":213,"context_line":"                deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_31affae4","line":210,"range":{"start_line":208,"start_character":47,"end_line":210,"end_character":45},"updated":"2016-08-25 21:29:22.000000000","message":"Is this option (enable_v2_api) being deprecated as well? if so, should there be a LOG.warn message emitted in versions.py similar to enable_v1_api?","commit_id":"f921e842815cbe355d52e69b7186c98b9b1a7908"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"bb3ba2b28f81e406365b75d75cf5c4beb5bc1267","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                deprecated_reason\u003d_DEPRECATE_GLANCE_V1_MSG,"},{"line_number":206,"context_line":"                deprecated_since\u003d_(\u0027Newton\u0027),"},{"line_number":207,"context_line":"                help\u003d_(\"Deploy the v1 OpenStack Images API.\")),"},{"line_number":208,"context_line":"    cfg.BoolOpt(\u0027enable_v2_api\u0027, default\u003dTrue, deprecated_for_removal\u003dTrue,"},{"line_number":209,"context_line":"                deprecated_reason\u003d_DEPRECATE_GLANCE_V1_MSG,"},{"line_number":210,"context_line":"                deprecated_since\u003d_(\u0027Newton\u0027),"},{"line_number":211,"context_line":"                help\u003d_(\"Deploy the v2 OpenStack Images API.\")),"},{"line_number":212,"context_line":"    cfg.BoolOpt(\u0027enable_v1_registry\u0027, default\u003dTrue,"},{"line_number":213,"context_line":"                deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_7772044b","line":210,"range":{"start_line":208,"start_character":47,"end_line":210,"end_character":45},"in_reply_to":"fa7ab95a_17cf46b1","updated":"2016-08-27 03:30:35.000000000","message":"improved the text for explanation","commit_id":"f921e842815cbe355d52e69b7186c98b9b1a7908"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"c4fe626c431240cd01f4ffea20d2005f42cb67ba","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                deprecated_reason\u003d_DEPRECATE_GLANCE_V1_MSG,"},{"line_number":206,"context_line":"                deprecated_since\u003d_(\u0027Newton\u0027),"},{"line_number":207,"context_line":"                help\u003d_(\"Deploy the v1 OpenStack Images API.\")),"},{"line_number":208,"context_line":"    cfg.BoolOpt(\u0027enable_v2_api\u0027, default\u003dTrue, deprecated_for_removal\u003dTrue,"},{"line_number":209,"context_line":"                deprecated_reason\u003d_DEPRECATE_GLANCE_V1_MSG,"},{"line_number":210,"context_line":"                deprecated_since\u003d_(\u0027Newton\u0027),"},{"line_number":211,"context_line":"                help\u003d_(\"Deploy the v2 OpenStack Images API.\")),"},{"line_number":212,"context_line":"    cfg.BoolOpt(\u0027enable_v1_registry\u0027, default\u003dTrue,"},{"line_number":213,"context_line":"                deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_f1e672e7","line":210,"range":{"start_line":208,"start_character":47,"end_line":210,"end_character":45},"in_reply_to":"fa7ab95a_31affae4","updated":"2016-08-25 21:36:34.000000000","message":"Thanks for asking.\n\nThe option is being deprecated now that we will have only one API i.e. v2 that Glance supports.\n\nThe versions.py warn is for deprecation of the v1 API. Since v2 stay, we don\u0027t need one for it there.","commit_id":"f921e842815cbe355d52e69b7186c98b9b1a7908"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"f66143a0ecd9463ae452abda7ee528c6c295da09","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                deprecated_reason\u003d_DEPRECATE_GLANCE_V1_MSG,"},{"line_number":206,"context_line":"                deprecated_since\u003d_(\u0027Newton\u0027),"},{"line_number":207,"context_line":"                help\u003d_(\"Deploy the v1 OpenStack Images API.\")),"},{"line_number":208,"context_line":"    cfg.BoolOpt(\u0027enable_v2_api\u0027, default\u003dTrue, deprecated_for_removal\u003dTrue,"},{"line_number":209,"context_line":"                deprecated_reason\u003d_DEPRECATE_GLANCE_V1_MSG,"},{"line_number":210,"context_line":"                deprecated_since\u003d_(\u0027Newton\u0027),"},{"line_number":211,"context_line":"                help\u003d_(\"Deploy the v2 OpenStack Images API.\")),"},{"line_number":212,"context_line":"    cfg.BoolOpt(\u0027enable_v1_registry\u0027, default\u003dTrue,"},{"line_number":213,"context_line":"                deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_17cf46b1","line":210,"range":{"start_line":208,"start_character":47,"end_line":210,"end_character":45},"in_reply_to":"fa7ab95a_f1e672e7","updated":"2016-08-25 22:05:22.000000000","message":"Got it, thanks for the explanation.","commit_id":"f921e842815cbe355d52e69b7186c98b9b1a7908"}]}
