)]}'
{"api-ref/source/v2/images-data.inc":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"202f5bc48cd0c9f9532916e79cd532ea4045c5b0","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- The image status must be ``queued``."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- Your image storage quota must be sufficient."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- The size of the data that you want to store must not exceed the"},{"line_number":45,"context_line":"  size that the OpenStack Image service allows."}],"source_content_type":"text/x-c++src","patch_set":9,"id":"1aa78d24_f40aae78","line":42,"updated":"2016-07-07 23:01:34.000000000","message":"This is very tricky. Since Glance is using a global quota configuration. That said, it\u0027s very hard for end user to know his usage, which may result in an unexpected failure. For example, as an cloud admin, I set the user_storage_quota\u003d1TB, it\u0027s very hard for user to check if the quota is sufficient or not.","commit_id":"990c53bc648e7a42418fbf3de131e4434b904f56"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"36070f809244ae90841419c86c147ccd6a6ddc4b","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- The image status must be ``queued``."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- Your image storage quota must be sufficient."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- The size of the data that you want to store must not exceed the"},{"line_number":45,"context_line":"  size that the OpenStack Image service allows."}],"source_content_type":"text/x-c++src","patch_set":9,"id":"1aa78d24_2aca0a6f","line":42,"in_reply_to":"1aa78d24_f40aae78","updated":"2016-07-08 02:19:14.000000000","message":"I agree that it\u0027s tricky, but all I\u0027m saying here is that if you don\u0027t have access to sufficient space to store your image, the upload will fail.  Which is completely true.  You\u0027re bringing up a good point, but it\u0027s really an issue for the quotas spec (to make sure that a user can discover a quota, how much is currently consumed/how much is available).  I don\u0027t think we need to discuss it in the API quick-reference guide.","commit_id":"990c53bc648e7a42418fbf3de131e4434b904f56"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"202f5bc48cd0c9f9532916e79cd532ea4045c5b0","unresolved":false,"context_lines":[{"line_number":108,"context_line":"  response code."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"- If no image record exists, the call returns the HTTP ``404`` response code."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Normal response codes: 200, 204"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Error response codes: 400, 403, 404"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"1aa78d24_bf93dfff","line":111,"updated":"2016-07-07 23:01:34.000000000","message":"Another case is the md5 doesn\u0027t match.","commit_id":"990c53bc648e7a42418fbf3de131e4434b904f56"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"36070f809244ae90841419c86c147ccd6a6ddc4b","unresolved":false,"context_lines":[{"line_number":108,"context_line":"  response code."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"- If no image record exists, the call returns the HTTP ``404`` response code."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Normal response codes: 200, 204"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Error response codes: 400, 403, 404"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"1aa78d24_ea12c208","line":111,"in_reply_to":"1aa78d24_bf93dfff","updated":"2016-07-08 02:19:14.000000000","message":"I looked in the code, but it looks like we just set the Content-MD5 header from the image checksum value.  Do we actually check the MD5 somewhere in the download chain?","commit_id":"990c53bc648e7a42418fbf3de131e4434b904f56"}],"api-ref/source/v2/images-images-v2.inc":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"33ad3292a2140216b7f7b68208c8643e2faf0845","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Normal response codes: 201"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Error response codes: "},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Request"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"3aaa91ec_faef67e6","line":101,"updated":"2016-06-30 18:42:13.000000000","message":"(nit): remove the space","commit_id":"3b4d7b89ca1496a6002e615d23fd93e03cf868b4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ceffe378ddc56c7b8717900cb7255806009e08ed","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Normal response codes: 201"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Error response codes: "},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Request"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"1aa78d24_02ace932","line":101,"in_reply_to":"3aaa91ec_faef67e6","updated":"2016-07-06 19:12:45.000000000","message":"Thanks for catching this.  I think I need a list of response codes here!","commit_id":"3b4d7b89ca1496a6002e615d23fd93e03cf868b4"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"33ad3292a2140216b7f7b68208c8643e2faf0845","unresolved":false,"context_lines":[{"line_number":358,"context_line":"   - sort_dir: sort_dir"},{"line_number":359,"context_line":"   - sort_key: sort_key"},{"line_number":360,"context_line":"   - sort: sort"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"Response Parameters"},{"line_number":364,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"3aaa91ec_2f36d302","line":361,"updated":"2016-06-30 18:42:13.000000000","message":"We can also support filtering by tags.","commit_id":"3b4d7b89ca1496a6002e615d23fd93e03cf868b4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ceffe378ddc56c7b8717900cb7255806009e08ed","unresolved":false,"context_lines":[{"line_number":358,"context_line":"   - sort_dir: sort_dir"},{"line_number":359,"context_line":"   - sort_key: sort_key"},{"line_number":360,"context_line":"   - sort: sort"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"Response Parameters"},{"line_number":364,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"1aa78d24_ba497ab9","line":361,"in_reply_to":"3aaa91ec_2f36d302","updated":"2016-07-06 19:12:45.000000000","message":"That is a useful functionality, I will add info about it.","commit_id":"3b4d7b89ca1496a6002e615d23fd93e03cf868b4"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"33ad3292a2140216b7f7b68208c8643e2faf0845","unresolved":false,"context_lines":[{"line_number":404,"context_line":"Notation (JSON) Patch `RFC6902 \u003chttp://tools.ietf.org/html/rfc6902\u003e`_, which"},{"line_number":405,"context_line":"defines the ``application/json-patch+json`` media type."},{"line_number":406,"context_line":""},{"line_number":407,"context_line":".. note:: "},{"line_number":408,"context_line":"   The ``application/openstack-images-v2.0-json-patch`` media type is based on"},{"line_number":409,"context_line":"   draft 4 of the standard. Its use is deprecated."},{"line_number":410,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"3aaa91ec_da138bff","line":407,"updated":"2016-06-30 18:42:13.000000000","message":"(nit): remove the space.","commit_id":"3b4d7b89ca1496a6002e615d23fd93e03cf868b4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ceffe378ddc56c7b8717900cb7255806009e08ed","unresolved":false,"context_lines":[{"line_number":404,"context_line":"Notation (JSON) Patch `RFC6902 \u003chttp://tools.ietf.org/html/rfc6902\u003e`_, which"},{"line_number":405,"context_line":"defines the ``application/json-patch+json`` media type."},{"line_number":406,"context_line":""},{"line_number":407,"context_line":".. note:: "},{"line_number":408,"context_line":"   The ``application/openstack-images-v2.0-json-patch`` media type is based on"},{"line_number":409,"context_line":"   draft 4 of the standard. Its use is deprecated."},{"line_number":410,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"1aa78d24_e530c7ea","line":407,"in_reply_to":"3aaa91ec_da138bff","updated":"2016-07-06 19:12:45.000000000","message":"Will do.","commit_id":"3b4d7b89ca1496a6002e615d23fd93e03cf868b4"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"33ad3292a2140216b7f7b68208c8643e2faf0845","unresolved":false,"context_lines":[{"line_number":427,"context_line":""},{"line_number":428,"context_line":"Normal response codes: 200"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"Error response codes: 403, 404, 415"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"Request"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"3aaa91ec_5a84bbd1","line":430,"updated":"2016-06-30 18:42:13.000000000","message":"Here may also return 413, see https://github.com/openstack/glance/blob/master/glance/api/v2/images.py#L162","commit_id":"3b4d7b89ca1496a6002e615d23fd93e03cf868b4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ceffe378ddc56c7b8717900cb7255806009e08ed","unresolved":false,"context_lines":[{"line_number":427,"context_line":""},{"line_number":428,"context_line":"Normal response codes: 200"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"Error response codes: 403, 404, 415"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"Request"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"1aa78d24_054d136c","line":430,"in_reply_to":"3aaa91ec_5a84bbd1","updated":"2016-07-06 19:12:45.000000000","message":"Thanks for catching this!","commit_id":"3b4d7b89ca1496a6002e615d23fd93e03cf868b4"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"202f5bc48cd0c9f9532916e79cd532ea4045c5b0","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        recoverable."},{"line_number":62,"context_line":"    * - deactivated"},{"line_number":63,"context_line":"      - The image data is not available for use."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"**Image visibility**"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"The possible values for image visibility are presented in the following table."}],"source_content_type":"text/x-c++src","patch_set":9,"id":"1aa78d24_9a92714a","line":64,"updated":"2016-07-07 23:01:34.000000000","message":"Here is the status transition chart if you want to add a link http://docs.openstack.org/developer/glance/statuses.html","commit_id":"990c53bc648e7a42418fbf3de131e4434b904f56"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"36070f809244ae90841419c86c147ccd6a6ddc4b","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        recoverable."},{"line_number":62,"context_line":"    * - deactivated"},{"line_number":63,"context_line":"      - The image data is not available for use."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"**Image visibility**"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"The possible values for image visibility are presented in the following table."}],"source_content_type":"text/x-c++src","patch_set":9,"id":"1aa78d24_4a7b162a","line":64,"in_reply_to":"1aa78d24_9a92714a","updated":"2016-07-08 02:19:14.000000000","message":"Thanks for the link, but I think that it\u0027s too much information for a quick-ref guide like this.","commit_id":"990c53bc648e7a42418fbf3de131e4434b904f56"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"202f5bc48cd0c9f9532916e79cd532ea4045c5b0","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":".. rest_method::  POST /v2/images"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Creates a virtual machine (VM) image."},{"line_number":89,"context_line":"*(Since Image API v2.0)*"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"The ``Location`` response header contains the URI for the image."}],"source_content_type":"text/x-c++src","patch_set":9,"id":"1aa78d24_1a916153","line":88,"updated":"2016-07-07 23:01:34.000000000","message":"Not sure if it\u0027s a correct description. I think Ironic can also consume Glance\u0027s images.","commit_id":"990c53bc648e7a42418fbf3de131e4434b904f56"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"36070f809244ae90841419c86c147ccd6a6ddc4b","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":".. rest_method::  POST /v2/images"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Creates a virtual machine (VM) image."},{"line_number":89,"context_line":"*(Since Image API v2.0)*"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"The ``Location`` response header contains the URI for the image."}],"source_content_type":"text/x-c++src","patch_set":9,"id":"1aa78d24_4af7968c","line":88,"in_reply_to":"1aa78d24_1a916153","updated":"2016-07-08 02:19:14.000000000","message":"Good point, but I\u0027m not sure what to say here.  How about:\n\nCreates a catalog record for an operating system disk image.","commit_id":"990c53bc648e7a42418fbf3de131e4434b904f56"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"202f5bc48cd0c9f9532916e79cd532ea4045c5b0","unresolved":false,"context_lines":[{"line_number":414,"context_line":"Notation (JSON) Patch `RFC6902 \u003chttp://tools.ietf.org/html/rfc6902\u003e`_, which"},{"line_number":415,"context_line":"defines the ``application/json-patch+json`` media type."},{"line_number":416,"context_line":""},{"line_number":417,"context_line":".. note:: "},{"line_number":418,"context_line":"   The ``application/openstack-images-v2.0-json-patch`` media type is based on"},{"line_number":419,"context_line":"   draft 4 of the standard. Its use is deprecated."},{"line_number":420,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":9,"id":"1aa78d24_1af5e1ca","line":417,"updated":"2016-07-07 23:01:34.000000000","message":"(nit): remove space.","commit_id":"990c53bc648e7a42418fbf3de131e4434b904f56"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3519c3421b882ba89c8264336af292b42d1feac1","unresolved":false,"context_lines":[{"line_number":270,"context_line":"You can list VM images that have a status of ``active``, ``queued``, or"},{"line_number":271,"context_line":"``saving``."},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"**The** ``in`` **Operator**"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"As a convenience, you may specify several values for any of the following"},{"line_number":276,"context_line":"fields by using the ``in`` operator:"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"1aa78d24_34ad1b89","line":273,"updated":"2016-07-08 21:24:20.000000000","message":"@Darja: can you read through this section and let me know if it\u0027s accurate?","commit_id":"aafd0834b2ae10e0405c79ca128193e442f1152c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3519c3421b882ba89c8264336af292b42d1feac1","unresolved":false,"context_lines":[{"line_number":315,"context_line":"written in a query string as:"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"``\"really,+really+\\\"good\\\"+image\"``"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"**Size Comparison Filters**"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"You can use the ``size_min`` and ``size_max`` query parameters to filter images"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"1aa78d24_f43ef327","line":318,"updated":"2016-07-08 21:24:20.000000000","message":"@Darja: is the above correct? I couldn\u0027t get it to work in devstack.  I wonder whether I\u0027m escaping the quotation marks correctly.\n\n(Also, just realized I should probably have used %20 instead of the plus sign to be consistent with the other examples.)","commit_id":"aafd0834b2ae10e0405c79ca128193e442f1152c"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"1b4784437d2600ff94790df1c7f2ac5fc2756f2b","unresolved":false,"context_lines":[{"line_number":460,"context_line":"Notation (JSON) Patch `RFC6902 \u003chttp://tools.ietf.org/html/rfc6902\u003e`_, which"},{"line_number":461,"context_line":"defines the ``application/json-patch+json`` media type."},{"line_number":462,"context_line":""},{"line_number":463,"context_line":".. note:: "},{"line_number":464,"context_line":"   The ``application/openstack-images-v2.0-json-patch`` media type is based on"},{"line_number":465,"context_line":"   draft 4 of the standard. Its use is deprecated."},{"line_number":466,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":10,"id":"1aa78d24_01d32c05","line":463,"updated":"2016-07-12 04:53:57.000000000","message":"(super nit): remove the space","commit_id":"aafd0834b2ae10e0405c79ca128193e442f1152c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2b2b74c22c5d09e18350a172e38f1c305d526af1","unresolved":false,"context_lines":[{"line_number":460,"context_line":"Notation (JSON) Patch `RFC6902 \u003chttp://tools.ietf.org/html/rfc6902\u003e`_, which"},{"line_number":461,"context_line":"defines the ``application/json-patch+json`` media type."},{"line_number":462,"context_line":""},{"line_number":463,"context_line":".. note:: "},{"line_number":464,"context_line":"   The ``application/openstack-images-v2.0-json-patch`` media type is based on"},{"line_number":465,"context_line":"   draft 4 of the standard. Its use is deprecated."},{"line_number":466,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":10,"id":"1aa78d24_4bf6b85d","line":463,"in_reply_to":"1aa78d24_01d32c05","updated":"2016-07-12 22:20:55.000000000","message":"Done","commit_id":"aafd0834b2ae10e0405c79ca128193e442f1152c"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"781cd723074c0bc9b00136f37a0f0fcdcc17ee4b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"Images"},{"line_number":4,"context_line":"******"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Creates, lists, updates, deletes, and performs other operations on images."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"General information"},{"line_number":9,"context_line":"~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"1aa78d24_bffc7f0d","line":6,"updated":"2016-07-15 15:12:57.000000000","message":"may be show is a primary operation?","commit_id":"9aa08ddbb090ec88c4cdd37dad827fe69f53fcd5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a894e4e245da25e3db9d32b1a94ca298d060aece","unresolved":false,"context_lines":[{"line_number":3,"context_line":"Images"},{"line_number":4,"context_line":"******"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Creates, lists, updates, deletes, and performs other operations on images."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"General information"},{"line_number":9,"context_line":"~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"fad55976_7e069921","line":6,"in_reply_to":"1aa78d24_bffc7f0d","updated":"2016-07-15 15:35:48.000000000","message":"I was thinking of \"show\" as covered by \"lists\" (it\u0027s like a singular list?).","commit_id":"9aa08ddbb090ec88c4cdd37dad827fe69f53fcd5"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"c2571fa8a3eeccc70d8d23c3180783731bfa5605","unresolved":false,"context_lines":[{"line_number":3,"context_line":"Images"},{"line_number":4,"context_line":"******"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Creates, lists, updates, deletes, and performs other operations on images."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"General information"},{"line_number":9,"context_line":"~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"fad55976_9908c793","line":6,"in_reply_to":"fad55976_7e069921","updated":"2016-07-15 15:39:36.000000000","message":"sure, but v2 list is sparse and that puts show on a boundary line. either way works, it\u0027s just a nit.","commit_id":"9aa08ddbb090ec88c4cdd37dad827fe69f53fcd5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"596193d7e4f9e52d02c684e86f0b36d21d613250","unresolved":false,"context_lines":[{"line_number":3,"context_line":"Images"},{"line_number":4,"context_line":"******"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Creates, lists, updates, deletes, and performs other operations on images."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"General information"},{"line_number":9,"context_line":"~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"fad55976_246a4e1b","line":6,"in_reply_to":"fad55976_9908c793","updated":"2016-07-15 16:01:58.000000000","message":"Done","commit_id":"9aa08ddbb090ec88c4cdd37dad827fe69f53fcd5"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"781cd723074c0bc9b00136f37a0f0fcdcc17ee4b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    * - Status"},{"line_number":46,"context_line":"      - Description"},{"line_number":47,"context_line":"    * - queued"},{"line_number":48,"context_line":"      - The Image service reserved an image ID for the image in the registry"},{"line_number":49,"context_line":"        but did not yet upload any image data."},{"line_number":50,"context_line":"    * - saving"},{"line_number":51,"context_line":"      - The Image service is currently uploading the raw data for the image."}],"source_content_type":"text/x-c++src","patch_set":11,"id":"1aa78d24_5f463b50","line":48,"range":{"start_line":48,"start_character":68,"end_line":48,"end_character":76},"updated":"2016-07-15 15:12:57.000000000","message":"I\u0027d like to use backend DB - the word registry can be confusing based on who reads it.","commit_id":"9aa08ddbb090ec88c4cdd37dad827fe69f53fcd5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a894e4e245da25e3db9d32b1a94ca298d060aece","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    * - Status"},{"line_number":46,"context_line":"      - Description"},{"line_number":47,"context_line":"    * - queued"},{"line_number":48,"context_line":"      - The Image service reserved an image ID for the image in the registry"},{"line_number":49,"context_line":"        but did not yet upload any image data."},{"line_number":50,"context_line":"    * - saving"},{"line_number":51,"context_line":"      - The Image service is currently uploading the raw data for the image."}],"source_content_type":"text/x-c++src","patch_set":11,"id":"fad55976_59312fec","line":48,"range":{"start_line":48,"start_character":68,"end_line":48,"end_character":76},"in_reply_to":"1aa78d24_5f463b50","updated":"2016-07-15 15:35:48.000000000","message":"How about \"in the catalog\"?  (For some reason I don\u0027t want to talk about the DB if we don\u0027t need to.)","commit_id":"9aa08ddbb090ec88c4cdd37dad827fe69f53fcd5"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"c2571fa8a3eeccc70d8d23c3180783731bfa5605","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    * - Status"},{"line_number":46,"context_line":"      - Description"},{"line_number":47,"context_line":"    * - queued"},{"line_number":48,"context_line":"      - The Image service reserved an image ID for the image in the registry"},{"line_number":49,"context_line":"        but did not yet upload any image data."},{"line_number":50,"context_line":"    * - saving"},{"line_number":51,"context_line":"      - The Image service is currently uploading the raw data for the image."}],"source_content_type":"text/x-c++src","patch_set":11,"id":"fad55976_992f27f6","line":48,"range":{"start_line":48,"start_character":68,"end_line":48,"end_character":76},"in_reply_to":"fad55976_59312fec","updated":"2016-07-15 15:39:36.000000000","message":"that works.","commit_id":"9aa08ddbb090ec88c4cdd37dad827fe69f53fcd5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"596193d7e4f9e52d02c684e86f0b36d21d613250","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    * - Status"},{"line_number":46,"context_line":"      - Description"},{"line_number":47,"context_line":"    * - queued"},{"line_number":48,"context_line":"      - The Image service reserved an image ID for the image in the registry"},{"line_number":49,"context_line":"        but did not yet upload any image data."},{"line_number":50,"context_line":"    * - saving"},{"line_number":51,"context_line":"      - The Image service is currently uploading the raw data for the image."}],"source_content_type":"text/x-c++src","patch_set":11,"id":"fad55976_2451ae63","line":48,"range":{"start_line":48,"start_character":68,"end_line":48,"end_character":76},"in_reply_to":"fad55976_992f27f6","updated":"2016-07-15 16:01:58.000000000","message":"Done","commit_id":"9aa08ddbb090ec88c4cdd37dad827fe69f53fcd5"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"781cd723074c0bc9b00136f37a0f0fcdcc17ee4b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"      - The Image service reserved an image ID for the image in the registry"},{"line_number":49,"context_line":"        but did not yet upload any image data."},{"line_number":50,"context_line":"    * - saving"},{"line_number":51,"context_line":"      - The Image service is currently uploading the raw data for the image."},{"line_number":52,"context_line":"    * - active"},{"line_number":53,"context_line":"      - The image is active and fully available in the Image service."},{"line_number":54,"context_line":"    * - killed"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"1aa78d24_7fb7b73a","line":51,"range":{"start_line":51,"start_character":29,"end_line":51,"end_character":48},"updated":"2016-07-15 15:12:57.000000000","message":"based on how accurate we intend to be: we can say the image service is expecting a stream of data that it can upload to backend store.","commit_id":"9aa08ddbb090ec88c4cdd37dad827fe69f53fcd5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a894e4e245da25e3db9d32b1a94ca298d060aece","unresolved":false,"context_lines":[{"line_number":48,"context_line":"      - The Image service reserved an image ID for the image in the registry"},{"line_number":49,"context_line":"        but did not yet upload any image data."},{"line_number":50,"context_line":"    * - saving"},{"line_number":51,"context_line":"      - The Image service is currently uploading the raw data for the image."},{"line_number":52,"context_line":"    * - active"},{"line_number":53,"context_line":"      - The image is active and fully available in the Image service."},{"line_number":54,"context_line":"    * - killed"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"fad55976_79e7d340","line":51,"range":{"start_line":51,"start_character":29,"end_line":51,"end_character":48},"in_reply_to":"1aa78d24_7fb7b73a","updated":"2016-07-15 15:35:48.000000000","message":"I see your point.  How about:\n\nThe image service is in the process of saving the raw data for the image into the backing store.","commit_id":"9aa08ddbb090ec88c4cdd37dad827fe69f53fcd5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"596193d7e4f9e52d02c684e86f0b36d21d613250","unresolved":false,"context_lines":[{"line_number":48,"context_line":"      - The Image service reserved an image ID for the image in the registry"},{"line_number":49,"context_line":"        but did not yet upload any image data."},{"line_number":50,"context_line":"    * - saving"},{"line_number":51,"context_line":"      - The Image service is currently uploading the raw data for the image."},{"line_number":52,"context_line":"    * - active"},{"line_number":53,"context_line":"      - The image is active and fully available in the Image service."},{"line_number":54,"context_line":"    * - killed"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"fad55976_c49412ea","line":51,"range":{"start_line":51,"start_character":29,"end_line":51,"end_character":48},"in_reply_to":"fad55976_193cd72e","updated":"2016-07-15 16:01:58.000000000","message":"Done","commit_id":"9aa08ddbb090ec88c4cdd37dad827fe69f53fcd5"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"c2571fa8a3eeccc70d8d23c3180783731bfa5605","unresolved":false,"context_lines":[{"line_number":48,"context_line":"      - The Image service reserved an image ID for the image in the registry"},{"line_number":49,"context_line":"        but did not yet upload any image data."},{"line_number":50,"context_line":"    * - saving"},{"line_number":51,"context_line":"      - The Image service is currently uploading the raw data for the image."},{"line_number":52,"context_line":"    * - active"},{"line_number":53,"context_line":"      - The image is active and fully available in the Image service."},{"line_number":54,"context_line":"    * - killed"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"fad55976_193cd72e","line":51,"range":{"start_line":51,"start_character":29,"end_line":51,"end_character":48},"in_reply_to":"fad55976_79e7d340","updated":"2016-07-15 15:39:36.000000000","message":"works for me.","commit_id":"9aa08ddbb090ec88c4cdd37dad827fe69f53fcd5"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"781cd723074c0bc9b00136f37a0f0fcdcc17ee4b","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    * - saving"},{"line_number":51,"context_line":"      - The Image service is currently uploading the raw data for the image."},{"line_number":52,"context_line":"    * - active"},{"line_number":53,"context_line":"      - The image is active and fully available in the Image service."},{"line_number":54,"context_line":"    * - killed"},{"line_number":55,"context_line":"      - An image data upload error occurred."},{"line_number":56,"context_line":"    * - deleted"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"1aa78d24_bf7f5f68","line":53,"range":{"start_line":53,"start_character":32,"end_line":53,"end_character":47},"updated":"2016-07-15 15:12:57.000000000","message":"ready for consumption","commit_id":"9aa08ddbb090ec88c4cdd37dad827fe69f53fcd5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a894e4e245da25e3db9d32b1a94ca298d060aece","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    * - saving"},{"line_number":51,"context_line":"      - The Image service is currently uploading the raw data for the image."},{"line_number":52,"context_line":"    * - active"},{"line_number":53,"context_line":"      - The image is active and fully available in the Image service."},{"line_number":54,"context_line":"    * - killed"},{"line_number":55,"context_line":"      - An image data upload error occurred."},{"line_number":56,"context_line":"    * - deleted"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"fad55976_b9730bb4","line":53,"range":{"start_line":53,"start_character":32,"end_line":53,"end_character":47},"in_reply_to":"1aa78d24_bf7f5f68","updated":"2016-07-15 15:35:48.000000000","message":"That\u0027s a good change, I\u0027ll make it.","commit_id":"9aa08ddbb090ec88c4cdd37dad827fe69f53fcd5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"596193d7e4f9e52d02c684e86f0b36d21d613250","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    * - saving"},{"line_number":51,"context_line":"      - The Image service is currently uploading the raw data for the image."},{"line_number":52,"context_line":"    * - active"},{"line_number":53,"context_line":"      - The image is active and fully available in the Image service."},{"line_number":54,"context_line":"    * - killed"},{"line_number":55,"context_line":"      - An image data upload error occurred."},{"line_number":56,"context_line":"    * - deleted"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"fad55976_44b0228c","line":53,"range":{"start_line":53,"start_character":32,"end_line":53,"end_character":47},"in_reply_to":"fad55976_b9730bb4","updated":"2016-07-15 16:01:58.000000000","message":"Done","commit_id":"9aa08ddbb090ec88c4cdd37dad827fe69f53fcd5"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"781cd723074c0bc9b00136f37a0f0fcdcc17ee4b","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":".. rest_parameters:: images-parameters.yaml"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"   - Location: Location"},{"line_number":136,"context_line":"   - checksum: checksum"},{"line_number":137,"context_line":"   - container_format: container_format"},{"line_number":138,"context_line":"   - created_at: created_at"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"1aa78d24_1fe2f301","line":135,"range":{"start_line":135,"start_character":5,"end_line":135,"end_character":23},"updated":"2016-07-15 15:12:57.000000000","message":"small question: this is a header, I\u0027m not sure how this is being rendered?","commit_id":"9aa08ddbb090ec88c4cdd37dad827fe69f53fcd5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a894e4e245da25e3db9d32b1a94ca298d060aece","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":".. rest_parameters:: images-parameters.yaml"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"   - Location: Location"},{"line_number":136,"context_line":"   - checksum: checksum"},{"line_number":137,"context_line":"   - container_format: container_format"},{"line_number":138,"context_line":"   - created_at: created_at"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"fad55976_59ee4fed","line":135,"range":{"start_line":135,"start_character":5,"end_line":135,"end_character":23},"in_reply_to":"1aa78d24_1fe2f301","updated":"2016-07-15 15:35:48.000000000","message":"it\u0027s in a table.  What you see is basically:\n\nName         In     Type    Description\nLocation   header  string   The URL for ...\nchecksum   body    string   Hash that is ...","commit_id":"9aa08ddbb090ec88c4cdd37dad827fe69f53fcd5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"596193d7e4f9e52d02c684e86f0b36d21d613250","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":".. rest_parameters:: images-parameters.yaml"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"   - Location: Location"},{"line_number":136,"context_line":"   - checksum: checksum"},{"line_number":137,"context_line":"   - container_format: container_format"},{"line_number":138,"context_line":"   - created_at: created_at"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"fad55976_c4625216","line":135,"range":{"start_line":135,"start_character":5,"end_line":135,"end_character":23},"in_reply_to":"fad55976_19233707","updated":"2016-07-15 16:01:58.000000000","message":"Done","commit_id":"9aa08ddbb090ec88c4cdd37dad827fe69f53fcd5"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"c2571fa8a3eeccc70d8d23c3180783731bfa5605","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":".. rest_parameters:: images-parameters.yaml"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"   - Location: Location"},{"line_number":136,"context_line":"   - checksum: checksum"},{"line_number":137,"context_line":"   - container_format: container_format"},{"line_number":138,"context_line":"   - created_at: created_at"}],"source_content_type":"text/x-c++src","patch_set":11,"id":"fad55976_19233707","line":135,"range":{"start_line":135,"start_character":5,"end_line":135,"end_character":23},"in_reply_to":"fad55976_59ee4fed","updated":"2016-07-15 15:39:36.000000000","message":"ah, thanks for clarifying.","commit_id":"9aa08ddbb090ec88c4cdd37dad827fe69f53fcd5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"596193d7e4f9e52d02c684e86f0b36d21d613250","unresolved":false,"context_lines":[{"line_number":307,"context_line":"It will not find an image named ``glass, darkly`` or an image named ``share"},{"line_number":308,"context_line":"me``."},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"If an image name contains both commas and quotation marks, you must still"},{"line_number":311,"context_line":"surround the expression with quotation marks so that the parser knows to ignore"},{"line_number":312,"context_line":"any commas it finds in the expression, and you must also escape the internal"},{"line_number":313,"context_line":"quotation marks so that the parser realizes that they are simply part of the"},{"line_number":314,"context_line":"name.  For example, an image named ``really, really \"good\" image`` would be"},{"line_number":315,"context_line":"written in a query string as:"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"``\"really,%20really%20\\\"good\\\"%20image\"``"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"**Size Comparison Filters**"},{"line_number":320,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":11,"id":"fad55976_dfa97fe1","line":317,"range":{"start_line":310,"start_character":0,"end_line":317,"end_character":41},"updated":"2016-07-15 16:01:58.000000000","message":"Will remove this in the next patch.  Need to figure out whether the escaping isn\u0027t explained correctly here, or whether there\u0027s a bug in the code that handles it.  I can\u0027t imagine this is a situation we\u0027ll come across a lot, though.","commit_id":"9aa08ddbb090ec88c4cdd37dad827fe69f53fcd5"}],"api-ref/source/v2/images-parameters.yaml":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"24f0970710dcd56369440b72d362a9d9d37bbed9","unresolved":false,"context_lines":[{"line_number":190,"context_line":"status-in-query:"},{"line_number":191,"context_line":"  description: |"},{"line_number":192,"context_line":"    Filters the response by an image status.  A valid value is ``queued``,"},{"line_number":193,"context_line":"    ``saving``, ``active``, ``killed``, ``deleted``, or ``pending_delete``."},{"line_number":194,"context_line":"  in: query"},{"line_number":195,"context_line":"  required: false"},{"line_number":196,"context_line":"  type: integer"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"fad55976_b6edcd27","line":193,"range":{"start_line":193,"start_character":40,"end_line":193,"end_character":74},"updated":"2016-07-15 19:40:31.000000000","message":"if the images with deleted and pending_delete status are not visible to users, why have it here?","commit_id":"a7ddcccc838e202e381296428bff60d1862ef5ea"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"d9c525ac80470d147e7675e75491fd0f507dd3c5","unresolved":false,"context_lines":[{"line_number":190,"context_line":"status-in-query:"},{"line_number":191,"context_line":"  description: |"},{"line_number":192,"context_line":"    Filters the response by an image status.  A valid value is ``queued``,"},{"line_number":193,"context_line":"    ``saving``, ``active``, ``killed``, ``deleted``, or ``pending_delete``."},{"line_number":194,"context_line":"  in: query"},{"line_number":195,"context_line":"  required: false"},{"line_number":196,"context_line":"  type: integer"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"dada55a8_fa2c154c","line":193,"range":{"start_line":193,"start_character":40,"end_line":193,"end_character":74},"in_reply_to":"dada55a8_08cf2d80","updated":"2016-07-19 04:36:07.000000000","message":"Cool, thanks for the clarification and update.","commit_id":"a7ddcccc838e202e381296428bff60d1862ef5ea"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9a55d0cfb5a71d20e4fe4c41f2068ef287ec5fd4","unresolved":false,"context_lines":[{"line_number":190,"context_line":"status-in-query:"},{"line_number":191,"context_line":"  description: |"},{"line_number":192,"context_line":"    Filters the response by an image status.  A valid value is ``queued``,"},{"line_number":193,"context_line":"    ``saving``, ``active``, ``killed``, ``deleted``, or ``pending_delete``."},{"line_number":194,"context_line":"  in: query"},{"line_number":195,"context_line":"  required: false"},{"line_number":196,"context_line":"  type: integer"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"dada55a8_08cf2d80","line":193,"range":{"start_line":193,"start_character":40,"end_line":193,"end_character":74},"in_reply_to":"fad55976_62bb3a28","updated":"2016-07-18 21:42:37.000000000","message":"The API will accept any value for this without choking, so I\u0027ll just remove the valid value list here.  (There\u0027s a list of image statuses given in the General Information section.)","commit_id":"a7ddcccc838e202e381296428bff60d1862ef5ea"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1acfaa5c19323132c9c88a76574091c221f4af5b","unresolved":false,"context_lines":[{"line_number":190,"context_line":"status-in-query:"},{"line_number":191,"context_line":"  description: |"},{"line_number":192,"context_line":"    Filters the response by an image status.  A valid value is ``queued``,"},{"line_number":193,"context_line":"    ``saving``, ``active``, ``killed``, ``deleted``, or ``pending_delete``."},{"line_number":194,"context_line":"  in: query"},{"line_number":195,"context_line":"  required: false"},{"line_number":196,"context_line":"  type: integer"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"fad55976_62bb3a28","line":193,"range":{"start_line":193,"start_character":40,"end_line":193,"end_character":74},"in_reply_to":"fad55976_b6edcd27","updated":"2016-07-16 12:30:41.000000000","message":"I\u0027ll have to check this.  I thought in some circumstances, regular users can see pending_delete images (though maybe that\u0027s only administrators).","commit_id":"a7ddcccc838e202e381296428bff60d1862ef5ea"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"24f0970710dcd56369440b72d362a9d9d37bbed9","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    For example, ``2015-08-27T09:49:58-05:00``."},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    If you omit the time zone, the UTC time zone is assumed."},{"line_number":224,"context_line":"  in: query"},{"line_number":225,"context_line":"  required: false"},{"line_number":226,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"fad55976_765235df","line":223,"range":{"start_line":223,"start_character":31,"end_line":223,"end_character":59},"updated":"2016-07-15 19:40:31.000000000","message":"I think the TZ assumed is the one that\u0027s set in the DB but openstack defaults to UTC TZ. An op can choose to set their own TZ, though. This is a muddy subject :/","commit_id":"a7ddcccc838e202e381296428bff60d1862ef5ea"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"d9c525ac80470d147e7675e75491fd0f507dd3c5","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    For example, ``2015-08-27T09:49:58-05:00``."},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    If you omit the time zone, the UTC time zone is assumed."},{"line_number":224,"context_line":"  in: query"},{"line_number":225,"context_line":"  required: false"},{"line_number":226,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"dada55a8_ba1bbd1a","line":223,"range":{"start_line":223,"start_character":31,"end_line":223,"end_character":59},"in_reply_to":"dada55a8_dc867ab8","updated":"2016-07-19 04:36:07.000000000","message":"Thanks for the details! Very good to know the background of the UTC changes.","commit_id":"a7ddcccc838e202e381296428bff60d1862ef5ea"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1acfaa5c19323132c9c88a76574091c221f4af5b","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    For example, ``2015-08-27T09:49:58-05:00``."},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    If you omit the time zone, the UTC time zone is assumed."},{"line_number":224,"context_line":"  in: query"},{"line_number":225,"context_line":"  required: false"},{"line_number":226,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"fad55976_77677e25","line":223,"range":{"start_line":223,"start_character":31,"end_line":223,"end_character":59},"in_reply_to":"fad55976_765235df","updated":"2016-07-16 12:30:41.000000000","message":"I had this on my todo list and forgot to follow up.  I think this is one thing that needs to be corrected before the patch is merged.  There was a discussion about the TZ formats back when the oslo library changed and Erno merged the utility function they were deprecating into Glance to keep our timestamps backwards-compatible that I can make use of.\n\nAlso, this reminds me: I don\u0027t think the changes_since stuff that stevelle did (pretty sure it landed in Mitaka) is documented in that long section discussing the image-list call in images-images-v2.inc ... I\u0027ll have to check that.","commit_id":"a7ddcccc838e202e381296428bff60d1862ef5ea"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9a55d0cfb5a71d20e4fe4c41f2068ef287ec5fd4","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    For example, ``2015-08-27T09:49:58-05:00``."},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    If you omit the time zone, the UTC time zone is assumed."},{"line_number":224,"context_line":"  in: query"},{"line_number":225,"context_line":"  required: false"},{"line_number":226,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"dada55a8_dc867ab8","line":223,"range":{"start_line":223,"start_character":31,"end_line":223,"end_character":59},"in_reply_to":"fad55976_77677e25","updated":"2016-07-18 21:42:37.000000000","message":"I think in terms of passing a time zone specification in a query string, this is correct; the parse utils take an absence of a specifier to mean UTC.\n\nAlso, stevelle didn\u0027t do changes_since, he did the created_at and updated_at filtering using the comparison operators.\n\nSo, I won\u0027t change anything here.","commit_id":"a7ddcccc838e202e381296428bff60d1862ef5ea"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"24f0970710dcd56369440b72d362a9d9d37bbed9","unresolved":false,"context_lines":[{"line_number":285,"context_line":"    The URL to access the image file kept in external store.  *It is present"},{"line_number":286,"context_line":"    only if the* ``show_image_direct_url`` *option is* ``true`` *in the Image"},{"line_number":287,"context_line":"    service\u0027s configuration file.*  **Because it presents a security risk, this"},{"line_number":288,"context_line":"    option is not enabled by default.**"},{"line_number":289,"context_line":"  in: body"},{"line_number":290,"context_line":"  required: false"},{"line_number":291,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"fad55976_76c5155a","line":288,"range":{"start_line":288,"start_character":14,"end_line":288,"end_character":25},"updated":"2016-07-15 19:40:31.000000000","message":"may be we can replace \u0027not enabled\u0027 with \u0027disabled\u0027 in another PS as the possibility of error in reading is high in cases of negatives in a sentence.","commit_id":"a7ddcccc838e202e381296428bff60d1862ef5ea"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1acfaa5c19323132c9c88a76574091c221f4af5b","unresolved":false,"context_lines":[{"line_number":285,"context_line":"    The URL to access the image file kept in external store.  *It is present"},{"line_number":286,"context_line":"    only if the* ``show_image_direct_url`` *option is* ``true`` *in the Image"},{"line_number":287,"context_line":"    service\u0027s configuration file.*  **Because it presents a security risk, this"},{"line_number":288,"context_line":"    option is not enabled by default.**"},{"line_number":289,"context_line":"  in: body"},{"line_number":290,"context_line":"  required: false"},{"line_number":291,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"fad55976_970672cc","line":288,"range":{"start_line":288,"start_character":14,"end_line":288,"end_character":25},"in_reply_to":"fad55976_76c5155a","updated":"2016-07-16 12:30:41.000000000","message":"That\u0027s a good point.","commit_id":"a7ddcccc838e202e381296428bff60d1862ef5ea"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"24f0970710dcd56369440b72d362a9d9d37bbed9","unresolved":false,"context_lines":[{"line_number":453,"context_line":"  type: string"},{"line_number":454,"context_line":"owner:"},{"line_number":455,"context_line":"  description: |"},{"line_number":456,"context_line":"    An identifier for the owner of the image, usually the tenant ID."},{"line_number":457,"context_line":"    The value might be ``null`` (JSON null data type)."},{"line_number":458,"context_line":"  in: body"},{"line_number":459,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"fad55976_96c40941","line":456,"range":{"start_line":456,"start_character":58,"end_line":456,"end_character":64},"updated":"2016-07-15 19:40:31.000000000","message":"not sure if we want to change this to project ID?","commit_id":"a7ddcccc838e202e381296428bff60d1862ef5ea"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"d9c525ac80470d147e7675e75491fd0f507dd3c5","unresolved":false,"context_lines":[{"line_number":453,"context_line":"  type: string"},{"line_number":454,"context_line":"owner:"},{"line_number":455,"context_line":"  description: |"},{"line_number":456,"context_line":"    An identifier for the owner of the image, usually the tenant ID."},{"line_number":457,"context_line":"    The value might be ``null`` (JSON null data type)."},{"line_number":458,"context_line":"  in: body"},{"line_number":459,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"dada55a8_5aca816f","line":456,"range":{"start_line":456,"start_character":58,"end_line":456,"end_character":64},"in_reply_to":"dada55a8_5f043c14","updated":"2016-07-19 04:36:07.000000000","message":"Thanks for changing this but I agree we\u0027d move to filing a bug for the tenant stuff that will refer to both tenant and project, as we clearly (like you point out) use tenant in configs too!","commit_id":"a7ddcccc838e202e381296428bff60d1862ef5ea"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1acfaa5c19323132c9c88a76574091c221f4af5b","unresolved":false,"context_lines":[{"line_number":453,"context_line":"  type: string"},{"line_number":454,"context_line":"owner:"},{"line_number":455,"context_line":"  description: |"},{"line_number":456,"context_line":"    An identifier for the owner of the image, usually the tenant ID."},{"line_number":457,"context_line":"    The value might be ``null`` (JSON null data type)."},{"line_number":458,"context_line":"  in: body"},{"line_number":459,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"fad55976_d7cbcaa3","line":456,"range":{"start_line":456,"start_character":58,"end_line":456,"end_character":64},"in_reply_to":"fad55976_96c40941","updated":"2016-07-16 12:30:41.000000000","message":"My impression is that we mostly use \u0027tenant\u0027 currently, though I did start to talk about \"project (or tenant)\" in some places, for example, the image sharing intro.  But I\u0027m pretty sure in other places I may have either just \"tenant\" or \"tenant (or project)\". I think it would be a good idea to file a bug after this is merged to \"make references to tenant/project consistent in the api-ref\".  I don\u0027t think we should completely eliminate tenant-talk, since one of our major config options is \"owner_is_tenant\".","commit_id":"a7ddcccc838e202e381296428bff60d1862ef5ea"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9a55d0cfb5a71d20e4fe4c41f2068ef287ec5fd4","unresolved":false,"context_lines":[{"line_number":453,"context_line":"  type: string"},{"line_number":454,"context_line":"owner:"},{"line_number":455,"context_line":"  description: |"},{"line_number":456,"context_line":"    An identifier for the owner of the image, usually the tenant ID."},{"line_number":457,"context_line":"    The value might be ``null`` (JSON null data type)."},{"line_number":458,"context_line":"  in: body"},{"line_number":459,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"dada55a8_5f043c14","line":456,"range":{"start_line":456,"start_character":58,"end_line":456,"end_character":64},"in_reply_to":"fad55976_d7cbcaa3","updated":"2016-07-18 21:42:37.000000000","message":"Anyway, I\u0027ll change this to \"project (also called the \u0027tenant\u0027) ID\" for now.","commit_id":"a7ddcccc838e202e381296428bff60d1862ef5ea"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"24f0970710dcd56369440b72d362a9d9d37bbed9","unresolved":false,"context_lines":[{"line_number":527,"context_line":"  in: body"},{"line_number":528,"context_line":"  required: false"},{"line_number":529,"context_line":"  type: array"},{"line_number":530,"context_line":"tasks:"},{"line_number":531,"context_line":"  description: |"},{"line_number":532,"context_line":"    A list of ``task`` objects."},{"line_number":533,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"fad55976_36f55d83","line":530,"range":{"start_line":530,"start_character":0,"end_line":530,"end_character":6},"updated":"2016-07-15 19:40:31.000000000","message":"interesting, I thought tasks was done separately?","commit_id":"a7ddcccc838e202e381296428bff60d1862ef5ea"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"d9c525ac80470d147e7675e75491fd0f507dd3c5","unresolved":false,"context_lines":[{"line_number":527,"context_line":"  in: body"},{"line_number":528,"context_line":"  required: false"},{"line_number":529,"context_line":"  type: array"},{"line_number":530,"context_line":"tasks:"},{"line_number":531,"context_line":"  description: |"},{"line_number":532,"context_line":"    A list of ``task`` objects."},{"line_number":533,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"dada55a8_daa4b1ba","line":530,"range":{"start_line":530,"start_character":0,"end_line":530,"end_character":6},"in_reply_to":"dada55a8_ff41b03a","updated":"2016-07-19 04:36:07.000000000","message":"Thanks.","commit_id":"a7ddcccc838e202e381296428bff60d1862ef5ea"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1acfaa5c19323132c9c88a76574091c221f4af5b","unresolved":false,"context_lines":[{"line_number":527,"context_line":"  in: body"},{"line_number":528,"context_line":"  required: false"},{"line_number":529,"context_line":"  type: array"},{"line_number":530,"context_line":"tasks:"},{"line_number":531,"context_line":"  description: |"},{"line_number":532,"context_line":"    A list of ``task`` objects."},{"line_number":533,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"fad55976_373186ed","line":530,"range":{"start_line":530,"start_character":0,"end_line":530,"end_character":6},"in_reply_to":"fad55976_36f55d83","updated":"2016-07-16 12:30:41.000000000","message":"Good catch, this must be left over from when I split tasks and metadefs into their own files.","commit_id":"a7ddcccc838e202e381296428bff60d1862ef5ea"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9a55d0cfb5a71d20e4fe4c41f2068ef287ec5fd4","unresolved":false,"context_lines":[{"line_number":527,"context_line":"  in: body"},{"line_number":528,"context_line":"  required: false"},{"line_number":529,"context_line":"  type: array"},{"line_number":530,"context_line":"tasks:"},{"line_number":531,"context_line":"  description: |"},{"line_number":532,"context_line":"    A list of ``task`` objects."},{"line_number":533,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"dada55a8_ff41b03a","line":530,"range":{"start_line":530,"start_character":0,"end_line":530,"end_character":6},"in_reply_to":"fad55976_373186ed","updated":"2016-07-18 21:42:37.000000000","message":"Removing on next patch set.","commit_id":"a7ddcccc838e202e381296428bff60d1862ef5ea"}],"api-ref/source/v2/images-schemas.inc":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"202f5bc48cd0c9f9532916e79cd532ea4045c5b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1aa78d24_ffb44783","line":139,"updated":"2016-07-07 23:01:34.000000000","message":"Should we mentioned `task` schema at here?","commit_id":"990c53bc648e7a42418fbf3de131e4434b904f56"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"36070f809244ae90841419c86c147ccd6a6ddc4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1aa78d24_4a6cb636","line":139,"in_reply_to":"1aa78d24_ffb44783","updated":"2016-07-08 02:19:14.000000000","message":"Good catch.  All the tasks stuff has been merged under a different patch: https://review.openstack.org/#/c/333029/\n\nSince the tasks api was made admin-only by default, I thought it was best to keep all the tasks-related calls together (even though, strictly speaking, the schemas are under the /v2/schemas endpoint, not the v2/tasks endpoint).  I thought it made for a more logical presentation of the info.","commit_id":"990c53bc648e7a42418fbf3de131e4434b904f56"}],"api-ref/source/v2/images-sharing-v2.inc":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"2c54c54f324492d49d0f3b129d130f1b08667e05","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Only the image owner may create members.  Only an image member may modify his"},{"line_number":14,"context_line":"or her member status."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Create image member"},{"line_number":18,"context_line":"~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"1aa78d24_adb659f6","line":15,"updated":"2016-07-07 01:37:14.000000000","message":"It would be nice if there is a clarification about the relationship between image owner, member and tenant/project.","commit_id":"f5943bc91b110a32f1b5242b25fde56caeaffa67"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"08a6f0eac4ce3a1569ebb355c8ae5e962ed1b951","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Only the image owner may create members.  Only an image member may modify his"},{"line_number":14,"context_line":"or her member status."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Create image member"},{"line_number":18,"context_line":"~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"1aa78d24_b74cad9e","line":15,"in_reply_to":"1aa78d24_adb659f6","updated":"2016-07-07 20:45:17.000000000","message":"I\u0027ll clarify on the next patch, but I\u0027m a bit worried that it introduces too much complexity for a quick reference guide.","commit_id":"f5943bc91b110a32f1b5242b25fde56caeaffa67"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"2c54c54f324492d49d0f3b129d130f1b08667e05","unresolved":false,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":".. rest_method::  PUT /v2/images/{image_id}/members/{member_id}"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Sets the status for an image member."},{"line_number":203,"context_line":"*(Since Image API v2.1)*"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"Preconditions"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"1aa78d24_cd25a55c","line":202,"updated":"2016-07-07 01:37:14.000000000","message":"I would suggest adding more details about this API. Though technically it\u0027s an updating action. But actually it\u0027s used for accept or deny the image sharing. Could you please add some explanations like that? I think it would be helpful for users.","commit_id":"f5943bc91b110a32f1b5242b25fde56caeaffa67"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"08a6f0eac4ce3a1569ebb355c8ae5e962ed1b951","unresolved":false,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":".. rest_method::  PUT /v2/images/{image_id}/members/{member_id}"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Sets the status for an image member."},{"line_number":203,"context_line":"*(Since Image API v2.1)*"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"Preconditions"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"1aa78d24_d73cd9e2","line":202,"in_reply_to":"1aa78d24_cd25a55c","updated":"2016-07-07 20:45:17.000000000","message":"Good idea, I\u0027ll add a bit more.","commit_id":"f5943bc91b110a32f1b5242b25fde56caeaffa67"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"e9ffcef09c2c62d94db9a19a9213bda9dff0b552","unresolved":false,"context_lines":[{"line_number":26,"context_line":"     uses the tenant ID for the image ``owner``, sharing will not work if you"},{"line_number":27,"context_line":"     use a user ID as the ``member_id`` of an image (and vice-versa)."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"   * Please consult your cloud\u0027s local documentation for details."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"When an image is shared, the member is given immediate access to the image."},{"line_number":32,"context_line":"In order to prevent spamming other users\u0027 image lists, a shared image does not"}],"source_content_type":"text/x-c++src","patch_set":13,"id":"dada55a8_4b091add","line":29,"range":{"start_line":29,"start_character":3,"end_line":29,"end_character":5},"updated":"2016-07-23 18:42:13.000000000","message":"I think we should highlight this line in bold or may be that\u0027s just me?","commit_id":"c028c2d23e3f32703f502e8919654df83f94e179"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"e9ffcef09c2c62d94db9a19a9213bda9dff0b552","unresolved":false,"context_lines":[{"line_number":26,"context_line":"     uses the tenant ID for the image ``owner``, sharing will not work if you"},{"line_number":27,"context_line":"     use a user ID as the ``member_id`` of an image (and vice-versa)."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"   * Please consult your cloud\u0027s local documentation for details."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"When an image is shared, the member is given immediate access to the image."},{"line_number":32,"context_line":"In order to prevent spamming other users\u0027 image lists, a shared image does not"}],"source_content_type":"text/x-c++src","patch_set":13,"id":"dada55a8_6b04dec5","line":29,"range":{"start_line":29,"start_character":53,"end_line":29,"end_character":57},"updated":"2016-07-23 18:42:13.000000000","message":"for further details ?","commit_id":"c028c2d23e3f32703f502e8919654df83f94e179"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0b36b79a2cc524df29a3da4c051965bbceeba2fb","unresolved":false,"context_lines":[{"line_number":26,"context_line":"     uses the tenant ID for the image ``owner``, sharing will not work if you"},{"line_number":27,"context_line":"     use a user ID as the ``member_id`` of an image (and vice-versa)."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"   * Please consult your cloud\u0027s local documentation for details."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"When an image is shared, the member is given immediate access to the image."},{"line_number":32,"context_line":"In order to prevent spamming other users\u0027 image lists, a shared image does not"}],"source_content_type":"text/x-c++src","patch_set":13,"id":"dada55a8_bc7ba2f3","line":29,"range":{"start_line":29,"start_character":53,"end_line":29,"end_character":57},"in_reply_to":"dada55a8_6b04dec5","updated":"2016-07-25 13:51:41.000000000","message":"This occurs in a few contexts (e.g., property protections).  We need to figure out good verbiage and good presentation for it.  I\u0027ll file a bug and ask the doc team to comment on it.","commit_id":"c028c2d23e3f32703f502e8919654df83f94e179"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"e9ffcef09c2c62d94db9a19a9213bda9dff0b552","unresolved":false,"context_lines":[{"line_number":93,"context_line":"   - image_id: image_id-in-path"},{"line_number":94,"context_line":"   - member: member_id"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Request Example"},{"line_number":97,"context_line":"---------------"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":".. literalinclude:: samples/image-member-create-request.json"},{"line_number":100,"context_line":"   :language: json"}],"source_content_type":"text/x-c++src","patch_set":13,"id":"dada55a8_8bb832e7","line":97,"range":{"start_line":96,"start_character":0,"end_line":97,"end_character":15},"updated":"2016-07-23 18:42:13.000000000","message":"dyk what\u0027s the history behind avoiding the can_share parameter in v2?","commit_id":"c028c2d23e3f32703f502e8919654df83f94e179"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0b36b79a2cc524df29a3da4c051965bbceeba2fb","unresolved":false,"context_lines":[{"line_number":93,"context_line":"   - image_id: image_id-in-path"},{"line_number":94,"context_line":"   - member: member_id"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Request Example"},{"line_number":97,"context_line":"---------------"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":".. literalinclude:: samples/image-member-create-request.json"},{"line_number":100,"context_line":"   :language: json"}],"source_content_type":"text/x-c++src","patch_set":13,"id":"dada55a8_37bfcdfd","line":97,"range":{"start_line":96,"start_character":0,"end_line":97,"end_character":15},"in_reply_to":"dada55a8_8bb832e7","updated":"2016-07-25 13:51:41.000000000","message":"A few things.  The goal of v2 sharing was to provide a basic infrastructure so that a cloud could have an image marketplace, so the thought was that can_share would mostly be false anyway.  Also at the time Mark indicated that there were some corner cases where can_share didn\u0027t work correctly in v1.  Also, transitive sharing makes the support network complicated to navigate for image consumers.\n\nFinally, community images are a better way to deal with the case where a producer creates an image and doesn\u0027t care who uses it.  It keeps the support network clear and allows for discovery, which doesn\u0027t work easily with can_share (even if we implemented a call that allowed you to see \"can_share\" images, someone who wants to use the image would still need someone with \"can_share\" permission to actually perform the sharing).\n\nI take it this question was a point of information, not a suggestion to mention it in the docs?","commit_id":"c028c2d23e3f32703f502e8919654df83f94e179"}],"api-ref/source/v2/images-tags.inc":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"e9ffcef09c2c62d94db9a19a9213bda9dff0b552","unresolved":false,"context_lines":[{"line_number":1,"context_line":".. -*- rst -*-"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Image tags"},{"line_number":4,"context_line":"**********"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Adds and deletes image tags."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":13,"id":"dada55a8_6ba05ea6","line":4,"range":{"start_line":3,"start_character":0,"end_line":4,"end_character":10},"updated":"2016-07-23 18:42:13.000000000","message":"Do we need to include the filtering using tags in this portion of the doc?","commit_id":"c028c2d23e3f32703f502e8919654df83f94e179"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0b36b79a2cc524df29a3da4c051965bbceeba2fb","unresolved":false,"context_lines":[{"line_number":1,"context_line":".. -*- rst -*-"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Image tags"},{"line_number":4,"context_line":"**********"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Adds and deletes image tags."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":13,"id":"dada55a8_979f995e","line":4,"range":{"start_line":3,"start_character":0,"end_line":4,"end_character":10},"in_reply_to":"dada55a8_6ba05ea6","updated":"2016-07-25 13:51:41.000000000","message":"It would definitely be useful to provide a link to the tag-filtering part of the image-list call.","commit_id":"c028c2d23e3f32703f502e8919654df83f94e179"}],"api-ref/source/v2/samples/image-update-response.json":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"e9ffcef09c2c62d94db9a19a9213bda9dff0b552","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    \"self\": \"/v2/images/da3b75d9-3f4a-40e7-8a2c-bfab23927dea\","},{"line_number":15,"context_line":"    \"file\": \"/v2/images/da3b75d9-3f4a-40e7-8a2c-bfab23927dea/file\","},{"line_number":16,"context_line":"    \"schema\": \"/v2/schemas/image\","},{"line_number":17,"context_line":"    \"owner\": null,"},{"line_number":18,"context_line":"    \"min_ram\": null,"},{"line_number":19,"context_line":"    \"min_disk\": null,"},{"line_number":20,"context_line":"    \"disk_format\": null,"}],"source_content_type":"application/json","patch_set":13,"id":"dada55a8_0b9c4268","line":17,"range":{"start_line":17,"start_character":13,"end_line":17,"end_character":17},"updated":"2016-07-23 18:42:13.000000000","message":"interesting response with a null owner!","commit_id":"c028c2d23e3f32703f502e8919654df83f94e179"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0b36b79a2cc524df29a3da4c051965bbceeba2fb","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    \"self\": \"/v2/images/da3b75d9-3f4a-40e7-8a2c-bfab23927dea\","},{"line_number":15,"context_line":"    \"file\": \"/v2/images/da3b75d9-3f4a-40e7-8a2c-bfab23927dea/file\","},{"line_number":16,"context_line":"    \"schema\": \"/v2/schemas/image\","},{"line_number":17,"context_line":"    \"owner\": null,"},{"line_number":18,"context_line":"    \"min_ram\": null,"},{"line_number":19,"context_line":"    \"min_disk\": null,"},{"line_number":20,"context_line":"    \"disk_format\": null,"}],"source_content_type":"application/json","patch_set":13,"id":"dada55a8_17b6098a","line":17,"range":{"start_line":17,"start_character":13,"end_line":17,"end_character":17},"in_reply_to":"dada55a8_0b9c4268","updated":"2016-07-25 13:51:41.000000000","message":"Good grief, this is a bad example!  Not only is the owner null, but the image is active and has a non-null file with null disk_format and container_format!  This is a priority to fix.","commit_id":"c028c2d23e3f32703f502e8919654df83f94e179"}],"api-ref/source/v2/samples/schemas-image-show-response.json":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"e9ffcef09c2c62d94db9a19a9213bda9dff0b552","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            ]"},{"line_number":76,"context_line":"        },"},{"line_number":77,"context_line":"        \"file\": {"},{"line_number":78,"context_line":"            \"description\": \"(READ-ONLY)\","},{"line_number":79,"context_line":"            \"type\": \"string\""},{"line_number":80,"context_line":"        },"},{"line_number":81,"context_line":"        \"id\": {"}],"source_content_type":"application/json","patch_set":13,"id":"dada55a8_eb6c4e38","line":78,"updated":"2016-07-23 18:42:13.000000000","message":"why not have something here?","commit_id":"c028c2d23e3f32703f502e8919654df83f94e179"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0b36b79a2cc524df29a3da4c051965bbceeba2fb","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            ]"},{"line_number":76,"context_line":"        },"},{"line_number":77,"context_line":"        \"file\": {"},{"line_number":78,"context_line":"            \"description\": \"(READ-ONLY)\","},{"line_number":79,"context_line":"            \"type\": \"string\""},{"line_number":80,"context_line":"        },"},{"line_number":81,"context_line":"        \"id\": {"}],"source_content_type":"application/json","patch_set":13,"id":"dada55a8_d2fe3f04","line":78,"in_reply_to":"dada55a8_eb6c4e38","updated":"2016-07-25 13:51:41.000000000","message":"This is my bad, I think I did not regenerate all the image schemas.  I will do that immediately and put up a new patch.  If the description on the latest schema doesn\u0027t have any useful info, I\u0027ll file a Glance bug and ask whoever fixes to give it a DocImpact flag so that we can follow up in the api-ref.","commit_id":"c028c2d23e3f32703f502e8919654df83f94e179"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"e9ffcef09c2c62d94db9a19a9213bda9dff0b552","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            \"type\": \"string\""},{"line_number":160,"context_line":"        },"},{"line_number":161,"context_line":"        \"schema\": {"},{"line_number":162,"context_line":"            \"description\": \"(READ-ONLY)\","},{"line_number":163,"context_line":"            \"type\": \"string\""},{"line_number":164,"context_line":"        },"},{"line_number":165,"context_line":"        \"self\": {"}],"source_content_type":"application/json","patch_set":13,"id":"dada55a8_cb698a27","line":162,"updated":"2016-07-23 18:42:13.000000000","message":"ditto","commit_id":"c028c2d23e3f32703f502e8919654df83f94e179"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"e9ffcef09c2c62d94db9a19a9213bda9dff0b552","unresolved":false,"context_lines":[{"line_number":163,"context_line":"            \"type\": \"string\""},{"line_number":164,"context_line":"        },"},{"line_number":165,"context_line":"        \"self\": {"},{"line_number":166,"context_line":"            \"description\": \"(READ-ONLY)\","},{"line_number":167,"context_line":"            \"type\": \"string\""},{"line_number":168,"context_line":"        },"},{"line_number":169,"context_line":"        \"size\": {"}],"source_content_type":"application/json","patch_set":13,"id":"dada55a8_2b778603","line":166,"updated":"2016-07-23 18:42:13.000000000","message":"ditto","commit_id":"c028c2d23e3f32703f502e8919654df83f94e179"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"e9ffcef09c2c62d94db9a19a9213bda9dff0b552","unresolved":false,"context_lines":[{"line_number":181,"context_line":"                \"active\","},{"line_number":182,"context_line":"                \"killed\","},{"line_number":183,"context_line":"                \"deleted\","},{"line_number":184,"context_line":"                \"pending_delete\""},{"line_number":185,"context_line":"            ],"},{"line_number":186,"context_line":"            \"type\": \"string\""},{"line_number":187,"context_line":"        },"}],"source_content_type":"application/json","patch_set":13,"id":"dada55a8_0b7442fb","line":184,"updated":"2016-07-23 18:42:13.000000000","message":"deactivated?","commit_id":"c028c2d23e3f32703f502e8919654df83f94e179"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0b36b79a2cc524df29a3da4c051965bbceeba2fb","unresolved":false,"context_lines":[{"line_number":181,"context_line":"                \"active\","},{"line_number":182,"context_line":"                \"killed\","},{"line_number":183,"context_line":"                \"deleted\","},{"line_number":184,"context_line":"                \"pending_delete\""},{"line_number":185,"context_line":"            ],"},{"line_number":186,"context_line":"            \"type\": \"string\""},{"line_number":187,"context_line":"        },"}],"source_content_type":"application/json","patch_set":13,"id":"dada55a8_9234c7de","line":184,"in_reply_to":"dada55a8_0b7442fb","updated":"2016-07-25 13:51:41.000000000","message":"Glad you caught all this, should be fixed with an updated schema.","commit_id":"c028c2d23e3f32703f502e8919654df83f94e179"}],"api-ref/source/v2/samples/schemas-images-list-response.json":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"e9ffcef09c2c62d94db9a19a9213bda9dff0b552","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                        \"description\": \"ID of image stored in Glance that should be used as the kernel when booting an AMI-style image.\","},{"line_number":114,"context_line":"                        \"is_base\": false,"},{"line_number":115,"context_line":"                        \"pattern\": \"^([0-9a-fA-F]){8}-([0-9a-fA-F]){4}-([0-9a-fA-F]){4}-([0-9a-fA-F]){4}-([0-9a-fA-F]){12}$\","},{"line_number":116,"context_line":"                        \"type\": \"string\""},{"line_number":117,"context_line":"                    },"},{"line_number":118,"context_line":"                    \"locations\": {"},{"line_number":119,"context_line":"                        \"description\": \"A set of URLs to access the image file kept in external store\","}],"source_content_type":"application/json","patch_set":13,"id":"dada55a8_abd096ca","line":116,"range":{"start_line":116,"start_character":32,"end_line":116,"end_character":40},"updated":"2016-07-23 18:42:13.000000000","message":"string or null https://github.com/openstack/glance/blob/master/etc/schema-image.json","commit_id":"c028c2d23e3f32703f502e8919654df83f94e179"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0b36b79a2cc524df29a3da4c051965bbceeba2fb","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                        \"description\": \"ID of image stored in Glance that should be used as the kernel when booting an AMI-style image.\","},{"line_number":114,"context_line":"                        \"is_base\": false,"},{"line_number":115,"context_line":"                        \"pattern\": \"^([0-9a-fA-F]){8}-([0-9a-fA-F]){4}-([0-9a-fA-F]){4}-([0-9a-fA-F]){4}-([0-9a-fA-F]){12}$\","},{"line_number":116,"context_line":"                        \"type\": \"string\""},{"line_number":117,"context_line":"                    },"},{"line_number":118,"context_line":"                    \"locations\": {"},{"line_number":119,"context_line":"                        \"description\": \"A set of URLs to access the image file kept in external store\","}],"source_content_type":"application/json","patch_set":13,"id":"dada55a8_f2a70309","line":116,"range":{"start_line":116,"start_character":32,"end_line":116,"end_character":40},"in_reply_to":"dada55a8_abd096ca","updated":"2016-07-25 13:51:41.000000000","message":"Good catch, this should all be fixed when I refresh the schemas.","commit_id":"c028c2d23e3f32703f502e8919654df83f94e179"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"e9ffcef09c2c62d94db9a19a9213bda9dff0b552","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                        \"description\": \"ID of image stored in Glance that should be used as the ramdisk when booting an AMI-style image.\","},{"line_number":178,"context_line":"                        \"is_base\": false,"},{"line_number":179,"context_line":"                        \"pattern\": \"^([0-9a-fA-F]){8}-([0-9a-fA-F]){4}-([0-9a-fA-F]){4}-([0-9a-fA-F]){4}-([0-9a-fA-F]){12}$\","},{"line_number":180,"context_line":"                        \"type\": \"string\""},{"line_number":181,"context_line":"                    },"},{"line_number":182,"context_line":"                    \"schema\": {"},{"line_number":183,"context_line":"                        \"description\": \"(READ-ONLY)\","}],"source_content_type":"application/json","patch_set":13,"id":"dada55a8_8b5e7274","line":180,"updated":"2016-07-23 18:42:13.000000000","message":"\"string\" or \"null\"","commit_id":"c028c2d23e3f32703f502e8919654df83f94e179"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"e9ffcef09c2c62d94db9a19a9213bda9dff0b552","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                        \"type\": \"string\""},{"line_number":181,"context_line":"                    },"},{"line_number":182,"context_line":"                    \"schema\": {"},{"line_number":183,"context_line":"                        \"description\": \"(READ-ONLY)\","},{"line_number":184,"context_line":"                        \"type\": \"string\""},{"line_number":185,"context_line":"                    },"},{"line_number":186,"context_line":"                    \"self\": {"}],"source_content_type":"application/json","patch_set":13,"id":"dada55a8_cb506a61","line":183,"updated":"2016-07-23 18:42:13.000000000","message":"ditto","commit_id":"c028c2d23e3f32703f502e8919654df83f94e179"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"e9ffcef09c2c62d94db9a19a9213bda9dff0b552","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                        \"type\": \"string\""},{"line_number":185,"context_line":"                    },"},{"line_number":186,"context_line":"                    \"self\": {"},{"line_number":187,"context_line":"                        \"description\": \"(READ-ONLY)\","},{"line_number":188,"context_line":"                        \"type\": \"string\""},{"line_number":189,"context_line":"                    },"},{"line_number":190,"context_line":"                    \"size\": {"}],"source_content_type":"application/json","patch_set":13,"id":"dada55a8_2b4e66c1","line":187,"updated":"2016-07-23 18:42:13.000000000","message":"ditto","commit_id":"c028c2d23e3f32703f502e8919654df83f94e179"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"e9ffcef09c2c62d94db9a19a9213bda9dff0b552","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                            \"active\","},{"line_number":203,"context_line":"                            \"killed\","},{"line_number":204,"context_line":"                            \"deleted\","},{"line_number":205,"context_line":"                            \"pending_delete\""},{"line_number":206,"context_line":"                        ],"},{"line_number":207,"context_line":"                        \"type\": \"string\""},{"line_number":208,"context_line":"                    },"}],"source_content_type":"application/json","patch_set":13,"id":"dada55a8_eb53ae6a","line":205,"updated":"2016-07-23 18:42:13.000000000","message":"ditto","commit_id":"c028c2d23e3f32703f502e8919654df83f94e179"}]}