)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"532cb91b493f5c0a25b8133e94f44197b9cf51fb","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove invalid test about config option location_strategy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Config option location_strategy with paramter choices\u003d(\u0027location_order\u0027,"},{"line_number":10,"context_line":"\u0027store_type\u0027), that means it only allows these two values in production"},{"line_number":11,"context_line":"environment, other vaule will raise ValueError.So don\u0027t test invalid value."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1517839"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3aaa91ec_d1961e4b","line":10,"updated":"2016-06-29 14:02:26.000000000","message":"So IIUC the error you printed happens when enforce\u003dTrue passed to tests. Do i get this correctly? \nIf yes could you please add explanation for that in commit message.","commit_id":"8d6403f22d5940e94035cf101cf0c6dc8c383b39"}],"glance/tests/unit/common/test_location_strategy.py":[{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"9480cf0b06acdddc4705415d689cbdd7c76ec5ef","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        strategy \u003d \u0027invalid_strategy\u0027"},{"line_number":112,"context_line":"        self.config(location_strategy\u003dstrategy)"},{"line_number":113,"context_line":"        self.assertRaises(RuntimeError,"},{"line_number":114,"context_line":"                          location_strategy.verify_location_strategy,"},{"line_number":115,"context_line":"                          strategy)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_get_ordered_locations_with_none_or_empty_locations(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_0b3716b1","side":"PARENT","line":114,"updated":"2016-06-28 13:39:38.000000000","message":"Could you please describe in details why this must be deleted?\nFrom my point of view, test checks that verify_location_strategy method fails with random value and it is not related to \"choices\" option because test does not specify any config option here.\nSo the test is ok as unit test IMO.","commit_id":"ed084110707a672f27a4f6cb978bc6c714866848"}]}