)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fd2191daeeb9aa703be159d72626c29277360dd9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Fei Long Wang \u003cflwang@catalyst.net.nz\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-02 15:36:15 +1200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove location strategy type ristrict"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The idea of location strategy is allowing cloud provider can"},{"line_number":10,"context_line":"add a customized location strategy. That said, no code change"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1aa78d24_0d439143","line":7,"range":{"start_line":7,"start_character":30,"end_line":7,"end_character":38},"updated":"2016-07-05 12:57:03.000000000","message":"nit: s/ristrict/restriction/","commit_id":"0567d67475715afab8d1b0ecbd69dd5e5a0fd038"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"7a4b709e3c12a5a6d285b95abaa520a8e0fba19e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove location strategy type restriction"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The idea of location strategy is allowing cloud provider can"},{"line_number":10,"context_line":"add a customized location strategy. That said, no code change"},{"line_number":11,"context_line":"should be involved and so it\u0027s not necessary to restrict the"},{"line_number":12,"context_line":"location strategy type in config file. The patch removes the"},{"line_number":13,"context_line":"restriction of oslo config, calls the given method to verify"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"dada55a8_68e04d97","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":35},"updated":"2016-07-25 10:03:27.000000000","message":"By looking the original blueprint [0] and commit [1] for this functionality there is no basis for this claim.\n\n[0] https://blueprints.launchpad.net/glance/+spec/image-location-selection-strategy\n[1] https://github.com/openstack/glance/commit/9567c2b6a06aa1e8205f9f30beca63d77500dd1d","commit_id":"d993ec4155d0420c6be0f6c067e42bde1fad9dbf"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"ea5c0bcfb8b9d49002bb05605912e924aa9136b1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove location strategy type restriction"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The idea of location strategy is allowing cloud provider can"},{"line_number":10,"context_line":"add a customized location strategy. That said, no code change"},{"line_number":11,"context_line":"should be involved and so it\u0027s not necessary to restrict the"},{"line_number":12,"context_line":"location strategy type in config file. The patch removes the"},{"line_number":13,"context_line":"restriction of oslo config, calls the given method to verify"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da36d5c6_2687c610","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":35},"in_reply_to":"dada55a8_68e04d97","updated":"2017-02-20 01:19:56.000000000","message":"Maybe it\u0027s not really accurate. But I don\u0027t think the original idea of location strategy is aim to limit it to the built-in strategy otherwise, no need to make it plugable.","commit_id":"d993ec4155d0420c6be0f6c067e42bde1fad9dbf"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"7a4b709e3c12a5a6d285b95abaa520a8e0fba19e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The idea of location strategy is allowing cloud provider can"},{"line_number":10,"context_line":"add a customized location strategy. That said, no code change"},{"line_number":11,"context_line":"should be involved and so it\u0027s not necessary to restrict the"},{"line_number":12,"context_line":"location strategy type in config file. The patch removes the"},{"line_number":13,"context_line":"restriction of oslo config, calls the given method to verify"},{"line_number":14,"context_line":"the strategy configured in glance-api.conf, and adds documentation"},{"line_number":15,"context_line":"about providing a customized location strategy."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"dada55a8_08127162","line":13,"range":{"start_line":12,"start_character":39,"end_line":13,"end_character":26},"updated":"2016-07-25 10:03:27.000000000","message":"Regardless of the above, this restriction was introduced in totally unrelated change c65d088b8d1f9fff94092142f0c6c3a6fc78e661","commit_id":"d993ec4155d0420c6be0f6c067e42bde1fad9dbf"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"ea5c0bcfb8b9d49002bb05605912e924aa9136b1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The idea of location strategy is allowing cloud provider can"},{"line_number":10,"context_line":"add a customized location strategy. That said, no code change"},{"line_number":11,"context_line":"should be involved and so it\u0027s not necessary to restrict the"},{"line_number":12,"context_line":"location strategy type in config file. The patch removes the"},{"line_number":13,"context_line":"restriction of oslo config, calls the given method to verify"},{"line_number":14,"context_line":"the strategy configured in glance-api.conf, and adds documentation"},{"line_number":15,"context_line":"about providing a customized location strategy."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da36d5c6_467cba20","line":13,"range":{"start_line":12,"start_character":39,"end_line":13,"end_character":26},"in_reply_to":"dada55a8_08127162","updated":"2017-02-20 01:19:56.000000000","message":"Yes, so it\u0027s not limited when the feature was introduced at the first time.","commit_id":"d993ec4155d0420c6be0f6c067e42bde1fad9dbf"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"7a4b709e3c12a5a6d285b95abaa520a8e0fba19e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"should be involved and so it\u0027s not necessary to restrict the"},{"line_number":12,"context_line":"location strategy type in config file. The patch removes the"},{"line_number":13,"context_line":"restriction of oslo config, calls the given method to verify"},{"line_number":14,"context_line":"the strategy configured in glance-api.conf, and adds documentation"},{"line_number":15,"context_line":"about providing a customized location strategy."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Co-Authored-By: ChangBo Guo \u003ceric.guo@easystack.cn\u003e"},{"line_number":18,"context_line":"Co-Authored-By: Fei Long Wang \u003cflwang@catalyst.net.nz\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"dada55a8_9384d65d","line":15,"range":{"start_line":14,"start_character":48,"end_line":15,"end_character":46},"updated":"2016-07-25 10:03:27.000000000","message":"Lots of the work to introduce the location strategies in the first place was invoked by the multiple locations work, which of lot has been closed down due to the severe security issues.\n\nI\u0027m not convinced we should encourage relying on it and document how to hack that functionality further.","commit_id":"d993ec4155d0420c6be0f6c067e42bde1fad9dbf"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"ea5c0bcfb8b9d49002bb05605912e924aa9136b1","unresolved":false,"context_lines":[{"line_number":11,"context_line":"should be involved and so it\u0027s not necessary to restrict the"},{"line_number":12,"context_line":"location strategy type in config file. The patch removes the"},{"line_number":13,"context_line":"restriction of oslo config, calls the given method to verify"},{"line_number":14,"context_line":"the strategy configured in glance-api.conf, and adds documentation"},{"line_number":15,"context_line":"about providing a customized location strategy."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Co-Authored-By: ChangBo Guo \u003ceric.guo@easystack.cn\u003e"},{"line_number":18,"context_line":"Co-Authored-By: Fei Long Wang \u003cflwang@catalyst.net.nz\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da36d5c6_c68eea26","line":15,"range":{"start_line":14,"start_character":48,"end_line":15,"end_character":46},"in_reply_to":"dada55a8_9384d65d","updated":"2017-02-20 01:19:56.000000000","message":"I think we\u0027re going to fix the multi location security issue finally, that should not block this, IMHO.","commit_id":"d993ec4155d0420c6be0f6c067e42bde1fad9dbf"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"7a4b709e3c12a5a6d285b95abaa520a8e0fba19e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Co-Authored-By: ChangBo Guo \u003ceric.guo@easystack.cn\u003e"},{"line_number":18,"context_line":"Co-Authored-By: Fei Long Wang \u003cflwang@catalyst.net.nz\u003e"},{"line_number":19,"context_line":"Co-Authored-By: Brian Rosmaita \u003cbrian.rosmaita@rackspace.com\u003e"},{"line_number":20,"context_line":"Closes-Bug: #1598282"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I3cafa44047b7529a255e5e686e78b98f30db48aa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"dada55a8_13d8e67e","line":20,"updated":"2016-07-25 10:03:27.000000000","message":"I\u0027m not fully convinced that this should be treated as bugfix (at least on the scale presented).","commit_id":"d993ec4155d0420c6be0f6c067e42bde1fad9dbf"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"ea5c0bcfb8b9d49002bb05605912e924aa9136b1","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Co-Authored-By: ChangBo Guo \u003ceric.guo@easystack.cn\u003e"},{"line_number":18,"context_line":"Co-Authored-By: Fei Long Wang \u003cflwang@catalyst.net.nz\u003e"},{"line_number":19,"context_line":"Co-Authored-By: Brian Rosmaita \u003cbrian.rosmaita@rackspace.com\u003e"},{"line_number":20,"context_line":"Closes-Bug: #1598282"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I3cafa44047b7529a255e5e686e78b98f30db48aa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da36d5c6_6679be2f","line":20,"in_reply_to":"dada55a8_13d8e67e","updated":"2017-02-20 01:19:56.000000000","message":"We can track it with a lite-spec, not a problem.","commit_id":"d993ec4155d0420c6be0f6c067e42bde1fad9dbf"}],"doc/source/image-location-strategy-modules.rst":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"7a4b709e3c12a5a6d285b95abaa520a8e0fba19e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Image Location Strategy Modules"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Glance comes pre-packaged with the following Location Strategy Modules.  An"},{"line_number":21,"context_line":"operator selects which one will be used by a Glance API instance by using the"},{"line_number":22,"context_line":"appropriate value for the ``location_strategy`` configuration option in the"},{"line_number":23,"context_line":"``glance-api.conf`` file."}],"source_content_type":"text/x-rst","patch_set":5,"id":"dada55a8_d3280e36","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":71},"updated":"2016-07-25 10:03:27.000000000","message":"The original wording in the bp (I\u0027d say rightfully so) empathizes that only those two are supported.","commit_id":"d993ec4155d0420c6be0f6c067e42bde1fad9dbf"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"ea5c0bcfb8b9d49002bb05605912e924aa9136b1","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Image Location Strategy Modules"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Glance comes pre-packaged with the following Location Strategy Modules.  An"},{"line_number":21,"context_line":"operator selects which one will be used by a Glance API instance by using the"},{"line_number":22,"context_line":"appropriate value for the ``location_strategy`` configuration option in the"},{"line_number":23,"context_line":"``glance-api.conf`` file."}],"source_content_type":"text/x-rst","patch_set":5,"id":"da36d5c6_46a3da9e","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":71},"in_reply_to":"dada55a8_d3280e36","updated":"2017-02-20 01:19:56.000000000","message":"I can\u0027t see any words in that bp says \"only those two are supported\u0027. I can see \u00271. Adding location_selection_strategy\" option, and ***currently*** support two strategies: \"location_order\" or \"store_type\".\"","commit_id":"d993ec4155d0420c6be0f6c067e42bde1fad9dbf"}],"glance/common/location_strategy/__init__.py":[{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"3dd38bd1a8a4ac9510999d8f5b023c3a0df879cc","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                 \u0027The valid strategy option(s) is(are): %(strategies)s\u0027) %"},{"line_number":78,"context_line":"               {\u0027name\u0027: conf, \u0027strategies\u0027: \", \".join(strategies.keys())})"},{"line_number":79,"context_line":"        LOG.error(msg)"},{"line_number":80,"context_line":"        raise RuntimeError(msg)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# NOTE(flwang): Verify the location strategy configured in glance-api.conf,"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_4fbd3db6","line":80,"updated":"2017-02-13 23:50:52.000000000","message":"I\u0027m not sure this is a recoverable error in this case. It would seem that all calls will fail. This should probably be a fatal error. There should be no need to log it then raise in that case, it will get logged elsewhere.","commit_id":"d993ec4155d0420c6be0f6c067e42bde1fad9dbf"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"ea5c0bcfb8b9d49002bb05605912e924aa9136b1","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                 \u0027The valid strategy option(s) is(are): %(strategies)s\u0027) %"},{"line_number":78,"context_line":"               {\u0027name\u0027: conf, \u0027strategies\u0027: \", \".join(strategies.keys())})"},{"line_number":79,"context_line":"        LOG.error(msg)"},{"line_number":80,"context_line":"        raise RuntimeError(msg)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# NOTE(flwang): Verify the location strategy configured in glance-api.conf,"}],"source_content_type":"text/x-python","patch_set":5,"id":"da36d5c6_66a0de91","line":80,"in_reply_to":"fa31d9ce_4fbd3db6","updated":"2017-02-20 01:19:56.000000000","message":"Do you mean just remove the LOG.error(msg)?","commit_id":"d993ec4155d0420c6be0f6c067e42bde1fad9dbf"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"c8f38f9578d09b96e8522f2c98099e163c2cffcf","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# NOTE(flwang): Verify the location strategy configured in glance-api.conf,"},{"line_number":84,"context_line":"# glance api can\u0027t be started if the strategy is invalid"},{"line_number":85,"context_line":"verify_location_strategy()"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"def get_ordered_locations(locations, **kwargs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_88e7813f","line":85,"updated":"2016-07-25 09:23:13.000000000","message":"is it possible to refactor this a bit before turning it on?\nI would like to get rig of mutable default in verify_location_strategy. Could you please pass the result of _load_strategies directly to verify_location_strategy? it would be perfect (but optional) if CONF.location_strategy will be directly passed to verify_location_strategy so we don\u0027t need it to be None by default. This looks a bit clearer for code reader.","commit_id":"d993ec4155d0420c6be0f6c067e42bde1fad9dbf"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"3dd38bd1a8a4ac9510999d8f5b023c3a0df879cc","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# NOTE(flwang): Verify the location strategy configured in glance-api.conf,"},{"line_number":84,"context_line":"# glance api can\u0027t be started if the strategy is invalid"},{"line_number":85,"context_line":"verify_location_strategy()"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"def get_ordered_locations(locations, **kwargs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_6f97613a","line":85,"in_reply_to":"dada55a8_88e7813f","updated":"2017-02-13 23:50:52.000000000","message":"+1","commit_id":"d993ec4155d0420c6be0f6c067e42bde1fad9dbf"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"ea5c0bcfb8b9d49002bb05605912e924aa9136b1","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# NOTE(flwang): Verify the location strategy configured in glance-api.conf,"},{"line_number":84,"context_line":"# glance api can\u0027t be started if the strategy is invalid"},{"line_number":85,"context_line":"verify_location_strategy()"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"def get_ordered_locations(locations, **kwargs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da36d5c6_c678aafb","line":85,"in_reply_to":"dada55a8_88e7813f","updated":"2017-02-20 01:19:56.000000000","message":"Yep, that makes sense. I\u0027m happy to refactor it after we make an agreement if we can roll this ball.","commit_id":"d993ec4155d0420c6be0f6c067e42bde1fad9dbf"}]}