)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"f5452302c8afe65f86b63f9022ad81c23a7671e0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improving help text for taskflow executor opts."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Partial bug:  #1570946"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I2c14301ac3ed881dc80c0e9bff3a092bc1cf0bc5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1aa78d24_13999479","line":9,"range":{"start_line":9,"start_character":12,"end_line":9,"end_character":14},"updated":"2016-07-12 17:30:09.000000000","message":"extra ws, so bug not linked","commit_id":"db4413a487e57d7be2928a34a0390d12443dc991"},{"author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"change_message_id":"85a5587a3cd70e71290971f5ad184af40f45c680","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improving help text for taskflow executor opts."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding improvised help texts for the config options engine_mode and max_workers"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Partial bug:  #1570946"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1aa78d24_f174a968","line":9,"range":{"start_line":9,"start_character":63,"end_line":9,"end_character":79},"updated":"2016-07-13 05:48:30.000000000","message":"Lines should be wrapped at 72 characters.","commit_id":"d63d9a2cb109fe0236b3421fbcc96009c39ed045"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"b41e5798eb6f19d25d01542a84abbbcc6cf9eb2d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improving help text for taskflow executor opts."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding improvised help texts for the config options engine_mode and max_workers"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Partial bug:  #1570946"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1aa78d24_1e8043f6","line":9,"range":{"start_line":9,"start_character":63,"end_line":9,"end_character":79},"in_reply_to":"1aa78d24_f174a968","updated":"2016-07-13 15:09:46.000000000","message":"Done","commit_id":"d63d9a2cb109fe0236b3421fbcc96009c39ed045"},{"author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"change_message_id":"85a5587a3cd70e71290971f5ad184af40f45c680","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding improvised help texts for the config options engine_mode and max_workers"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Partial bug:  #1570946"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I2c14301ac3ed881dc80c0e9bff3a092bc1cf0bc5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1aa78d24_315471c8","line":11,"range":{"start_line":11,"start_character":11,"end_line":11,"end_character":14},"updated":"2016-07-13 05:48:30.000000000","message":"One more spaces here.","commit_id":"d63d9a2cb109fe0236b3421fbcc96009c39ed045"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"b41e5798eb6f19d25d01542a84abbbcc6cf9eb2d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding improvised help texts for the config options engine_mode and max_workers"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Partial bug:  #1570946"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I2c14301ac3ed881dc80c0e9bff3a092bc1cf0bc5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1aa78d24_fe8297fd","line":11,"range":{"start_line":11,"start_character":11,"end_line":11,"end_character":14},"in_reply_to":"1aa78d24_315471c8","updated":"2016-07-13 15:09:46.000000000","message":"Done","commit_id":"d63d9a2cb109fe0236b3421fbcc96009c39ed045"}],"glance/async/taskflow_executor.py":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"67098aff813e4ba8b30e9667e10147a6ab9951ab","unresolved":false,"context_lines":[{"line_number":40,"context_line":"               help\u003d_(\"\"\""},{"line_number":41,"context_line":"Config option used to set the taskflow engine mode."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"This config option takes in a string type value to set the mode in"},{"line_number":44,"context_line":"which the taskflow engine would schedule tasks to the workers on"},{"line_number":45,"context_line":"remote hosts. Based on this mode, the workers accept and work on the"},{"line_number":46,"context_line":"task requests they recieve from the taskflow executor."}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_6e754ff9","line":43,"range":{"start_line":43,"start_character":5,"end_line":43,"end_character":11},"updated":"2016-07-13 17:59:34.000000000","message":"configuration","commit_id":"4b3678e5d7e4672d1dca94aa5eb50ed154b31f5d"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"67098aff813e4ba8b30e9667e10147a6ab9951ab","unresolved":false,"context_lines":[{"line_number":41,"context_line":"Config option used to set the taskflow engine mode."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"This config option takes in a string type value to set the mode in"},{"line_number":44,"context_line":"which the taskflow engine would schedule tasks to the workers on"},{"line_number":45,"context_line":"remote hosts. Based on this mode, the workers accept and work on the"},{"line_number":46,"context_line":"task requests they recieve from the taskflow executor."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Services which consume this:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_6e01cfaf","line":45,"range":{"start_line":44,"start_character":54,"end_line":45,"end_character":12},"updated":"2016-07-13 17:59:34.000000000","message":"I\u0027m not sure if we support remote workers yet.","commit_id":"4b3678e5d7e4672d1dca94aa5eb50ed154b31f5d"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"67098aff813e4ba8b30e9667e10147a6ab9951ab","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"This config option takes in a string type value to set the mode in"},{"line_number":44,"context_line":"which the taskflow engine would schedule tasks to the workers on"},{"line_number":45,"context_line":"remote hosts. Based on this mode, the workers accept and work on the"},{"line_number":46,"context_line":"task requests they recieve from the taskflow executor."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Services which consume this:"},{"line_number":49,"context_line":"    * glance-api"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_ee093f86","line":46,"range":{"start_line":45,"start_character":34,"end_line":46,"end_character":53},"updated":"2016-07-13 17:59:34.000000000","message":"\"the engine executes tasks either in a single or multiple threads. The possible values for this configuration option are: ``single`` and ``parallel``. When set to ``single``, the engine runs all the tasks in a single thread which results in serial execution of tasks. Setting this to ``parallel`` makes the engine run tasks in multiple threads. This results in parallel execution of tasks.\"","commit_id":"4b3678e5d7e4672d1dca94aa5eb50ed154b31f5d"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"8778ecd11ab6be3d115462e219a1cd8fe9ddfa44","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"This config option takes in a string type value to set the mode in"},{"line_number":44,"context_line":"which the taskflow engine would schedule tasks to the workers on"},{"line_number":45,"context_line":"remote hosts. Based on this mode, the workers accept and work on the"},{"line_number":46,"context_line":"task requests they recieve from the taskflow executor."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Services which consume this:"},{"line_number":49,"context_line":"    * glance-api"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_683ffab5","line":46,"range":{"start_line":45,"start_character":34,"end_line":46,"end_character":53},"in_reply_to":"1aa78d24_ee093f86","updated":"2016-07-13 21:14:29.000000000","message":"Sorry, I meant \"serial\" above not \"single\".","commit_id":"4b3678e5d7e4672d1dca94aa5eb50ed154b31f5d"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"67098aff813e4ba8b30e9667e10147a6ab9951ab","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    * parallel"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Related options:"},{"line_number":56,"context_line":"    * None"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"\"\"\")),"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_d709792c","line":56,"range":{"start_line":56,"start_character":6,"end_line":56,"end_character":10},"updated":"2016-07-13 17:59:34.000000000","message":"Is this related to max_workers?","commit_id":"4b3678e5d7e4672d1dca94aa5eb50ed154b31f5d"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"67098aff813e4ba8b30e9667e10147a6ab9951ab","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"\"\"\")),"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    cfg.IntOpt(\u0027max_workers\u0027,"},{"line_number":61,"context_line":"               default\u003d10,"},{"line_number":62,"context_line":"               help\u003d_(\"\"\""},{"line_number":63,"context_line":"Config option to set the number of engine executable tasks."}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_711b7074","line":60,"updated":"2016-07-13 17:59:34.000000000","message":"How about adding \"min\u003d1\" here?","commit_id":"4b3678e5d7e4672d1dca94aa5eb50ed154b31f5d"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"67098aff813e4ba8b30e9667e10147a6ab9951ab","unresolved":false,"context_lines":[{"line_number":62,"context_line":"               help\u003d_(\"\"\""},{"line_number":63,"context_line":"Config option to set the number of engine executable tasks."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"This config option takes in an integer value to limit the number of"},{"line_number":66,"context_line":"workers that can be instantiated on remote hosts. In other words,"},{"line_number":67,"context_line":"this number defines the number of parallel activities that can be"},{"line_number":68,"context_line":"executed at the same time by the taskflow engine. This value can be"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_8e623b3c","line":65,"range":{"start_line":65,"start_character":5,"end_line":65,"end_character":11},"updated":"2016-07-13 17:59:34.000000000","message":"configuration","commit_id":"4b3678e5d7e4672d1dca94aa5eb50ed154b31f5d"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"67098aff813e4ba8b30e9667e10147a6ab9951ab","unresolved":false,"context_lines":[{"line_number":63,"context_line":"Config option to set the number of engine executable tasks."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"This config option takes in an integer value to limit the number of"},{"line_number":66,"context_line":"workers that can be instantiated on remote hosts. In other words,"},{"line_number":67,"context_line":"this number defines the number of parallel activities that can be"},{"line_number":68,"context_line":"executed at the same time by the taskflow engine. This value can be"},{"line_number":69,"context_line":"greater than one when the engine mode is set to parallel."}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_0e848baf","line":66,"range":{"start_line":66,"start_character":33,"end_line":66,"end_character":48},"updated":"2016-07-13 17:59:34.000000000","message":"Same as above. I don\u0027t think we support remote execution, that is the remote worker model. So, these would worker processes or threads on the local machine.","commit_id":"4b3678e5d7e4672d1dca94aa5eb50ed154b31f5d"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"67098aff813e4ba8b30e9667e10147a6ab9951ab","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"This config option takes in an integer value to limit the number of"},{"line_number":66,"context_line":"workers that can be instantiated on remote hosts. In other words,"},{"line_number":67,"context_line":"this number defines the number of parallel activities that can be"},{"line_number":68,"context_line":"executed at the same time by the taskflow engine. This value can be"},{"line_number":69,"context_line":"greater than one when the engine mode is set to parallel."},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_ae60d70e","line":67,"range":{"start_line":67,"start_character":43,"end_line":67,"end_character":53},"updated":"2016-07-13 17:59:34.000000000","message":"let\u0027s call them \"tasks\"","commit_id":"4b3678e5d7e4672d1dca94aa5eb50ed154b31f5d"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"67098aff813e4ba8b30e9667e10147a6ab9951ab","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    * glance-api"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Possible values:"},{"line_number":75,"context_line":"    * Integer value between 0 and 10"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Related options:"},{"line_number":78,"context_line":"    * engine_mode"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_914ffc69","line":75,"range":{"start_line":75,"start_character":28,"end_line":75,"end_character":29},"updated":"2016-07-13 17:59:34.000000000","message":"Not sure if this can be zero. It has to be 1 or more I think.","commit_id":"4b3678e5d7e4672d1dca94aa5eb50ed154b31f5d"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"1ab769d1f8d02e4a61c4a8e49e33a146731d80a4","unresolved":false,"context_lines":[{"line_number":71,"context_line":"engine mode is set to parallel."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Possible values:"},{"line_number":74,"context_line":"    * Integer value between 1 and 10"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Related options:"},{"line_number":77,"context_line":"    * engine_mode"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_018039be","line":74,"range":{"start_line":74,"start_character":4,"end_line":74,"end_character":36},"updated":"2016-07-26 16:26:37.000000000","message":"Add max\u003d10","commit_id":"a3e880bba0a2714e3b4e7ab00ebc33fde5d9f952"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"05b6318284cb3c22cd845fbddd472b0408e5c80d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"engine mode is set to parallel."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Possible values:"},{"line_number":74,"context_line":"    * Integer value greater than 1"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Related options:"},{"line_number":77,"context_line":"    * engine_mode"}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_43ad109a","line":74,"updated":"2016-07-26 18:46:03.000000000","message":"Should this be greater than or equal to 1 since we mark min\u003d1?\nSetting this to 1 is essentially going to be sequential execution.","commit_id":"05520d31a81f76b4beb05c7c040476ff9e288e4b"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"fcbe799f9082496aabed3d77aa207ec00b15111c","unresolved":false,"context_lines":[{"line_number":71,"context_line":"engine mode is set to parallel."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Possible values:"},{"line_number":74,"context_line":"    * Integer value greater than than or equal to 1"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Related options:"},{"line_number":77,"context_line":"    * engine_mode"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_6632e25f","line":74,"range":{"start_line":74,"start_character":28,"end_line":74,"end_character":37},"updated":"2016-07-26 19:08:37.000000000","message":"Nit: \u0027than\u0027 appears twice.","commit_id":"2d78d08da9bbcea8e7a3a9fb8fd869b5e2ba66f1"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"ae9c5101ee12e4642f6bddafa1ecbd21b556a757","unresolved":false,"context_lines":[{"line_number":71,"context_line":"engine mode is set to parallel."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Possible values:"},{"line_number":74,"context_line":"    * Integer value greater than than or equal to 1"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Related options:"},{"line_number":77,"context_line":"    * engine_mode"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_86527665","line":74,"range":{"start_line":74,"start_character":28,"end_line":74,"end_character":37},"in_reply_to":"dada55a8_6632e25f","updated":"2016-07-26 19:10:30.000000000","message":"Done","commit_id":"2d78d08da9bbcea8e7a3a9fb8fd869b5e2ba66f1"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"518807e5320dbe20228951b471c4e5850c41f61e","unresolved":false,"context_lines":[{"line_number":68,"context_line":"instantiated on the hosts. In other words, this number defines the"},{"line_number":69,"context_line":"number of parallel tasks that can be executed at the same time by"},{"line_number":70,"context_line":"the taskflow engine. This value can be greater than one when the"},{"line_number":71,"context_line":"engine mode is set to parallel."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Possible values:"},{"line_number":74,"context_line":"    * Integer value greater than or equal to 1"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_7246fe7b","line":71,"updated":"2016-08-01 15:38:22.000000000","message":"I don\u0027t know if it matters a lot but having a recommended value might help the ops in the future. Though the default is like recommended but in reality recommended would be something that will relate to cores/sockets on a system.","commit_id":"276b40b86684618ac51b4f89b791ed84ca3aebf8"}]}