)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"80edda304181123682a9c909c213fb390e55a714","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dharini Chandrasekar \u003cdharini.chandrasekar@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-11 20:12:04 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improving help text for image conversion_format"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Partial bug: #1570946"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1aa78d24_1370743f","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":9},"updated":"2016-07-12 17:30:39.000000000","message":"please add more info to the commit message besides the title","commit_id":"575cd5f6fb58382597e2eea2cad9f2615a99fd45"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f0e4bd5fd6d0db3820ea0e14b6728cf8bc74b0ef","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improving help text for image conversion_format"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding improvised help text for conversion_format which is used to"},{"line_number":10,"context_line":"change the image format for stored images automnatically."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partial-Bug: #1570946"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"dada55a8_c4bb4f0d","line":9,"range":{"start_line":9,"start_character":7,"end_line":9,"end_character":17},"updated":"2016-07-18 16:20:23.000000000","message":"?","commit_id":"7d9615b9e843632e4e68225b441de825201c746a"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"26987a0c0e72074da0cc9b06594549500e8aabb2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improving help text for image conversion_format"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding improvised help text for conversion_format which is used to"},{"line_number":10,"context_line":"change the image format for stored images automnatically."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partial-Bug: #1570946"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"dada55a8_64d1c3cd","line":9,"range":{"start_line":9,"start_character":7,"end_line":9,"end_character":17},"in_reply_to":"dada55a8_c4bb4f0d","updated":"2016-07-18 16:26:18.000000000","message":"Done","commit_id":"7d9615b9e843632e4e68225b441de825201c746a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d629c0dba023f451850501c6674a45b4f4108848","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Improving help text for image conversion_format"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding improved help text for conversion_format which is used to"},{"line_number":10,"context_line":"change the image format for stored images automnatically."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partial-Bug: #1570946"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"dada55a8_81a8e0dc","line":10,"range":{"start_line":10,"start_character":47,"end_line":10,"end_character":48},"updated":"2016-07-25 19:43:09.000000000","message":"if you push up another patch, please remove the \u0027n\u0027.","commit_id":"fb765f229e1c3f3a7d758e04bba7e628c782dd08"}],"glance/async/flows/convert.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f0e4bd5fd6d0db3820ea0e14b6728cf8bc74b0ef","unresolved":false,"context_lines":[{"line_number":31,"context_line":"               help\u003d_(\"\"\""},{"line_number":32,"context_line":"Set the desired image conversion format."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Provide a valid image conversion format to convert images to,"},{"line_number":35,"context_line":"automatically for storage. Image format conversions help in efficient"},{"line_number":36,"context_line":"handling of bandwidth and usage of infrastructure when using storage"},{"line_number":37,"context_line":"backends. The \u0027raw\u0027 format should be chosen when RBD or Ceph backends"},{"line_number":38,"context_line":"are used."}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_e476533d","line":35,"range":{"start_line":34,"start_character":0,"end_line":35,"end_character":26},"updated":"2016-07-18 16:20:23.000000000","message":"This sentence could use a re-write.  Maybe something like:\n\nProvide a valid image format indicator to specify the format to which images should be converted before they are stored.","commit_id":"7d9615b9e843632e4e68225b441de825201c746a"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"26987a0c0e72074da0cc9b06594549500e8aabb2","unresolved":false,"context_lines":[{"line_number":31,"context_line":"               help\u003d_(\"\"\""},{"line_number":32,"context_line":"Set the desired image conversion format."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Provide a valid image conversion format to convert images to,"},{"line_number":35,"context_line":"automatically for storage. Image format conversions help in efficient"},{"line_number":36,"context_line":"handling of bandwidth and usage of infrastructure when using storage"},{"line_number":37,"context_line":"backends. The \u0027raw\u0027 format should be chosen when RBD or Ceph backends"},{"line_number":38,"context_line":"are used."}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_4488ffe7","line":35,"range":{"start_line":34,"start_character":0,"end_line":35,"end_character":26},"in_reply_to":"dada55a8_e476533d","updated":"2016-07-18 16:26:18.000000000","message":"Done","commit_id":"7d9615b9e843632e4e68225b441de825201c746a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d629c0dba023f451850501c6674a45b4f4108848","unresolved":false,"context_lines":[{"line_number":34,"context_line":"Provide a valid image format to which you want images to be"},{"line_number":35,"context_line":"converted to before they are stored for comsumption by Glance."},{"line_number":36,"context_line":"If not configured, images are retained in their original format."},{"line_number":37,"context_line":"Image format conversions help especially when storage backends"},{"line_number":38,"context_line":"are used for storing images by facilitating efficient handling"},{"line_number":39,"context_line":"of bandwidth and usage of the storage infrastructure. The \u0027raw\u0027"},{"line_number":40,"context_line":"format should be chosen when RBD or Ceph storage backends are"},{"line_number":41,"context_line":"used for image storage."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_01723049","line":39,"range":{"start_line":37,"start_character":0,"end_line":39,"end_character":53},"updated":"2016-07-25 19:43:09.000000000","message":"I suggest changing the first part of the sentence to:\n\nImage format conversions may be desirable for specific storage backends in order to facilitate efficient ...\n\n(because it\u0027s pretty rare to run glance without a storage backend)","commit_id":"fb765f229e1c3f3a7d758e04bba7e628c782dd08"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"1b19eeef94e6bfbceba05b6c2ebee13a4850f9e2","unresolved":false,"context_lines":[{"line_number":34,"context_line":"Provide a valid image format to which you want images to be"},{"line_number":35,"context_line":"converted to before they are stored for comsumption by Glance."},{"line_number":36,"context_line":"If not configured, images are retained in their original format."},{"line_number":37,"context_line":"Image format conversions help especially when storage backends"},{"line_number":38,"context_line":"are used for storing images by facilitating efficient handling"},{"line_number":39,"context_line":"of bandwidth and usage of the storage infrastructure. The \u0027raw\u0027"},{"line_number":40,"context_line":"format should be chosen when RBD or Ceph storage backends are"},{"line_number":41,"context_line":"used for image storage."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_14499931","line":39,"range":{"start_line":37,"start_character":0,"end_line":39,"end_character":53},"in_reply_to":"dada55a8_01723049","updated":"2016-07-26 16:33:40.000000000","message":"Done","commit_id":"fb765f229e1c3f3a7d758e04bba7e628c782dd08"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d629c0dba023f451850501c6674a45b4f4108848","unresolved":false,"context_lines":[{"line_number":38,"context_line":"are used for storing images by facilitating efficient handling"},{"line_number":39,"context_line":"of bandwidth and usage of the storage infrastructure. The \u0027raw\u0027"},{"line_number":40,"context_line":"format should be chosen when RBD or Ceph storage backends are"},{"line_number":41,"context_line":"used for image storage."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Possible values:"},{"line_number":44,"context_line":"    * qcow2"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_01d7d0ed","line":41,"updated":"2016-07-25 19:43:09.000000000","message":"I suggest making the last sentence into its own paragraph (it will stand out more clearly that way).","commit_id":"fb765f229e1c3f3a7d758e04bba7e628c782dd08"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"1b19eeef94e6bfbceba05b6c2ebee13a4850f9e2","unresolved":false,"context_lines":[{"line_number":38,"context_line":"are used for storing images by facilitating efficient handling"},{"line_number":39,"context_line":"of bandwidth and usage of the storage infrastructure. The \u0027raw\u0027"},{"line_number":40,"context_line":"format should be chosen when RBD or Ceph storage backends are"},{"line_number":41,"context_line":"used for image storage."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Possible values:"},{"line_number":44,"context_line":"    * qcow2"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_b45ecde6","line":41,"in_reply_to":"dada55a8_01d7d0ed","updated":"2016-07-26 16:33:40.000000000","message":"Done","commit_id":"fb765f229e1c3f3a7d758e04bba7e628c782dd08"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"5fec525564d1257416d61496903efa3f22b1f1f0","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    * raw"},{"line_number":46,"context_line":"    * vmdk"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Related options:"},{"line_number":49,"context_line":"    * None"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"\"\"\")),"},{"line_number":52,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_e1dec53c","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":10},"updated":"2016-07-26 16:22:11.000000000","message":"I suggest dropping sections that do not give any additional information.","commit_id":"fb765f229e1c3f3a7d758e04bba7e628c782dd08"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"1b19eeef94e6bfbceba05b6c2ebee13a4850f9e2","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    * raw"},{"line_number":46,"context_line":"    * vmdk"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Related options:"},{"line_number":49,"context_line":"    * None"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"\"\"\")),"},{"line_number":52,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_344c9d41","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":10},"in_reply_to":"dada55a8_e1dec53c","updated":"2016-07-26 16:33:40.000000000","message":"We retain this section even if it is \"None\".\nGuidelines to adding help texts in Glance: https://etherpad.openstack.org/p/improving-glance-config-opts","commit_id":"fb765f229e1c3f3a7d758e04bba7e628c782dd08"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a55efdb49a08e50aacccaa476262a07ef5d199ad","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Provide a valid image format to which you want images to be"},{"line_number":37,"context_line":"converted to before they are stored for comsumption by Glance."},{"line_number":38,"context_line":"By default, conversion_format is not set and requires that it"},{"line_number":39,"context_line":"be set explicitly. Appropriate image format conversions are"},{"line_number":40,"context_line":"desirable for specific storage backends in order to facilitate"},{"line_number":41,"context_line":"efficient handling of bandwidth and usage of the storage"},{"line_number":42,"context_line":"infrastructure."}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_ed5994fe","line":39,"range":{"start_line":38,"start_character":0,"end_line":39,"end_character":18},"updated":"2016-07-26 18:02:11.000000000","message":"Maybe move this to its own paragraph, after this one but before the next one about rbd.\n\nAlso, maybe change \u0027and requires that it\u0027 to \u0027and must\u0027","commit_id":"9dd147927a060d940d4f1d2904dce4b0c77d578e"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"a0508a521a7cce8cce39588b3d37b8e8271d4996","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Provide a valid image format to which you want images to be"},{"line_number":37,"context_line":"converted to before they are stored for comsumption by Glance."},{"line_number":38,"context_line":"By default, conversion_format is not set and requires that it"},{"line_number":39,"context_line":"be set explicitly. Appropriate image format conversions are"},{"line_number":40,"context_line":"desirable for specific storage backends in order to facilitate"},{"line_number":41,"context_line":"efficient handling of bandwidth and usage of the storage"},{"line_number":42,"context_line":"infrastructure."}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_631db461","line":39,"range":{"start_line":38,"start_character":0,"end_line":39,"end_character":18},"in_reply_to":"dada55a8_ed5994fe","updated":"2016-07-26 18:48:26.000000000","message":"Done","commit_id":"9dd147927a060d940d4f1d2904dce4b0c77d578e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4367840dcb03b9997b8ae9cb04ff8fe62abd77a2","unresolved":false,"context_lines":[{"line_number":34,"context_line":"Set the desired image conversion format."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Provide a valid image format to which you want images to be"},{"line_number":37,"context_line":"converted to before they are stored for comsumption by Glance."},{"line_number":38,"context_line":"Appropriate image format conversions are desirable for specific"},{"line_number":39,"context_line":"storage backends in order to facilitate efficient handling of"},{"line_number":40,"context_line":"bandwidth and usage of the storage infrastructure."}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_184b7f88","line":37,"range":{"start_line":37,"start_character":10,"end_line":37,"end_character":12},"updated":"2016-07-26 21:44:16.000000000","message":"Sorry for missing this on earlier patches.  Since you have \"to which\" earlier in this sentence, you don\u0027t need the \"to\" here.\n\nI read through again, and at this moment, I don\u0027t see any other corrections, so hopefully this is the last one!  Thanks for your patience.","commit_id":"04f62687abee41a305102610660975ceb4e3faeb"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"86c5ec6c43a836b256efff7598f13adc5814fa51","unresolved":false,"context_lines":[{"line_number":34,"context_line":"Set the desired image conversion format."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Provide a valid image format to which you want images to be"},{"line_number":37,"context_line":"converted to before they are stored for comsumption by Glance."},{"line_number":38,"context_line":"Appropriate image format conversions are desirable for specific"},{"line_number":39,"context_line":"storage backends in order to facilitate efficient handling of"},{"line_number":40,"context_line":"bandwidth and usage of the storage infrastructure."}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_2c70c4a3","line":37,"range":{"start_line":37,"start_character":10,"end_line":37,"end_character":12},"in_reply_to":"dada55a8_184b7f88","updated":"2016-07-26 21:48:40.000000000","message":"Done","commit_id":"04f62687abee41a305102610660975ceb4e3faeb"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"d49898dd293dde9b51711be539e58acea471a03e","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"convert_task_opts \u003d ["},{"line_number":29,"context_line":"    cfg.StrOpt(\u0027conversion_format\u0027,"},{"line_number":30,"context_line":"               default\u003d\"\","},{"line_number":31,"context_line":"               required\u003dTrue,"},{"line_number":32,"context_line":"               choices\u003d(\u0027qcow2\u0027, \u0027raw\u0027, \u0027vmdk\u0027),"},{"line_number":33,"context_line":"               help\u003d_(\"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_ef0a1ed1","line":30,"range":{"start_line":30,"start_character":15,"end_line":30,"end_character":26},"updated":"2016-07-26 22:25:29.000000000","message":"If there is no default for this config opt, we should drop this. Otherwise, it will result in a default that is empty string.\nAlso, is there a possibility for adding sample_default here?","commit_id":"11a7144547467635852d1beaaa07a406ef70027c"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"dd9648c871cea5d9789f660f796d10535513ff09","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"convert_task_opts \u003d ["},{"line_number":29,"context_line":"    cfg.StrOpt(\u0027conversion_format\u0027,"},{"line_number":30,"context_line":"               default\u003d\"\","},{"line_number":31,"context_line":"               required\u003dTrue,"},{"line_number":32,"context_line":"               choices\u003d(\u0027qcow2\u0027, \u0027raw\u0027, \u0027vmdk\u0027),"},{"line_number":33,"context_line":"               help\u003d_(\"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_9799ae22","line":30,"range":{"start_line":30,"start_character":15,"end_line":30,"end_character":26},"in_reply_to":"dada55a8_ef0a1ed1","updated":"2016-07-27 15:21:41.000000000","message":"Done","commit_id":"11a7144547467635852d1beaaa07a406ef70027c"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"fb5d8506b22edb11144c331ed2a7740eeb0ad59c","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"convert_task_opts \u003d ["},{"line_number":29,"context_line":"    cfg.StrOpt(\u0027conversion_format\u0027,"},{"line_number":30,"context_line":"               default\u003d\u0027raw\u0027,"},{"line_number":31,"context_line":"               required\u003dTrue,"},{"line_number":32,"context_line":"               choices\u003d(\u0027qcow2\u0027, \u0027raw\u0027, \u0027vmdk\u0027),"},{"line_number":33,"context_line":"               help\u003d_(\"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_89c0242c","line":30,"updated":"2016-07-28 21:53:51.000000000","message":"Not setting a \"default\" but marking the opt as \"required\", raises a RequiredOptError from oslo_config.cfg\nHence adding a safe default of \u0027raw\u0027.","commit_id":"e9cb7c11c88ccba9582a0e42229e5a260a2eb967"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"8e558e2dff648cb7507be3c76c61d3121f312859","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"convert_task_opts \u003d ["},{"line_number":29,"context_line":"    cfg.StrOpt(\u0027conversion_format\u0027,"},{"line_number":30,"context_line":"               default\u003d\u0027raw\u0027,"},{"line_number":31,"context_line":"               required\u003dTrue,"},{"line_number":32,"context_line":"               choices\u003d(\u0027qcow2\u0027, \u0027raw\u0027, \u0027vmdk\u0027),"},{"line_number":33,"context_line":"               help\u003d_(\"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_41bc18dc","line":30,"in_reply_to":"bacf61ea_5ea2354c","updated":"2016-07-29 16:07:15.000000000","message":"Since this had to be explicitly set, I marked it as \"required\". But looks like tagging an opt as required means we need to have a default set according to oslo. \nHowever, it makes more sense if an opt marked as required isn\u0027t provided with a default as only them will it prompt the operator to set it. \nBut looks like we have to either provide the default if we are marking something as \"required\", or not mark it as \"required\" in the first place if we do not have a sane default. This is, if we wish not to change the behavior of oslo_config/cfg.py in throwing an exception.","commit_id":"e9cb7c11c88ccba9582a0e42229e5a260a2eb967"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"29f09d9dd8f3101297d8d529f85716243fd28ab5","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"convert_task_opts \u003d ["},{"line_number":29,"context_line":"    cfg.StrOpt(\u0027conversion_format\u0027,"},{"line_number":30,"context_line":"               default\u003d\u0027raw\u0027,"},{"line_number":31,"context_line":"               required\u003dTrue,"},{"line_number":32,"context_line":"               choices\u003d(\u0027qcow2\u0027, \u0027raw\u0027, \u0027vmdk\u0027),"},{"line_number":33,"context_line":"               help\u003d_(\"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_5ea2354c","line":30,"in_reply_to":"bacf61ea_89c0242c","updated":"2016-07-29 16:00:20.000000000","message":"Except ... see Flavio\u0027s comment at line 80 about there being no sane default for this option.  There\u0027s a check in the code around line 84 to trap a None value for this option, so maybe the thing to do is not make it required?  (I\u0027m asking, not suggesting!)  What are our options here?","commit_id":"e9cb7c11c88ccba9582a0e42229e5a260a2eb967"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"f8f6c820a772a14855f2c43baa7e8fc9749e30b6","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Set the desired image conversion format."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Provide a valid image format to which you want images to be"},{"line_number":42,"context_line":"converted before they are stored for comsumption by Glance."},{"line_number":43,"context_line":"Appropriate image format conversions are desirable for specific"},{"line_number":44,"context_line":"storage backends in order to facilitate efficient handling of"},{"line_number":45,"context_line":"bandwidth and usage of the storage infrastructure."}],"source_content_type":"text/x-python","patch_set":15,"id":"1ac06dbe_51bfe35f","line":42,"range":{"start_line":42,"start_character":37,"end_line":42,"end_character":48},"updated":"2016-08-25 18:25:33.000000000","message":"consumption","commit_id":"efb4e72b635e195e052d7120677f2dd1a647bdb0"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"00d265fc331ea0d919a6c880414d6bc2a99a9fbe","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Set the desired image conversion format."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Provide a valid image format to which you want images to be"},{"line_number":42,"context_line":"converted before they are stored for comsumption by Glance."},{"line_number":43,"context_line":"Appropriate image format conversions are desirable for specific"},{"line_number":44,"context_line":"storage backends in order to facilitate efficient handling of"},{"line_number":45,"context_line":"bandwidth and usage of the storage infrastructure."}],"source_content_type":"text/x-python","patch_set":15,"id":"fa7ab95a_e86da7cd","line":42,"range":{"start_line":42,"start_character":37,"end_line":42,"end_character":48},"in_reply_to":"1ac06dbe_51bfe35f","updated":"2016-08-25 20:25:10.000000000","message":"Done","commit_id":"efb4e72b635e195e052d7120677f2dd1a647bdb0"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"f8f6c820a772a14855f2c43baa7e8fc9749e30b6","unresolved":false,"context_lines":[{"line_number":44,"context_line":"storage backends in order to facilitate efficient handling of"},{"line_number":45,"context_line":"bandwidth and usage of the storage infrastructure."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"By default, conversion_format is not set and must be set"},{"line_number":48,"context_line":"explicitly in the configuration file."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"The \u0027raw\u0027 format should be chosen when RBD or Ceph storage"}],"source_content_type":"text/x-python","patch_set":15,"id":"1ac06dbe_d172b3e2","line":47,"range":{"start_line":47,"start_character":12,"end_line":47,"end_character":29},"updated":"2016-08-25 18:25:33.000000000","message":"``conversion_format``","commit_id":"efb4e72b635e195e052d7120677f2dd1a647bdb0"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"00d265fc331ea0d919a6c880414d6bc2a99a9fbe","unresolved":false,"context_lines":[{"line_number":44,"context_line":"storage backends in order to facilitate efficient handling of"},{"line_number":45,"context_line":"bandwidth and usage of the storage infrastructure."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"By default, conversion_format is not set and must be set"},{"line_number":48,"context_line":"explicitly in the configuration file."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"The \u0027raw\u0027 format should be chosen when RBD or Ceph storage"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa7ab95a_0873abb2","line":47,"range":{"start_line":47,"start_character":12,"end_line":47,"end_character":29},"in_reply_to":"1ac06dbe_d172b3e2","updated":"2016-08-25 20:25:10.000000000","message":"Done","commit_id":"efb4e72b635e195e052d7120677f2dd1a647bdb0"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"f8f6c820a772a14855f2c43baa7e8fc9749e30b6","unresolved":false,"context_lines":[{"line_number":50,"context_line":"The \u0027raw\u0027 format should be chosen when RBD or Ceph storage"},{"line_number":51,"context_line":"backends are used for image storage."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Possiblei values:"},{"line_number":54,"context_line":"    * qcow2"},{"line_number":55,"context_line":"    * raw"},{"line_number":56,"context_line":"    * vmdk"}],"source_content_type":"text/x-python","patch_set":15,"id":"1ac06dbe_118f2bcd","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":9},"updated":"2016-08-25 18:25:33.000000000","message":"Possible","commit_id":"efb4e72b635e195e052d7120677f2dd1a647bdb0"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"00d265fc331ea0d919a6c880414d6bc2a99a9fbe","unresolved":false,"context_lines":[{"line_number":50,"context_line":"The \u0027raw\u0027 format should be chosen when RBD or Ceph storage"},{"line_number":51,"context_line":"backends are used for image storage."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Possiblei values:"},{"line_number":54,"context_line":"    * qcow2"},{"line_number":55,"context_line":"    * raw"},{"line_number":56,"context_line":"    * vmdk"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa7ab95a_28686fba","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":9},"in_reply_to":"1ac06dbe_118f2bcd","updated":"2016-08-25 20:25:10.000000000","message":"Done","commit_id":"efb4e72b635e195e052d7120677f2dd1a647bdb0"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"4e610f034e41fa89c64f07d0aac161bb6e612fb3","unresolved":false,"context_lines":[{"line_number":47,"context_line":"By default, ``conversion_format`` is not set and must be set"},{"line_number":48,"context_line":"explicitly in the configuration file."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"The \u0027raw\u0027 format should be chosen when RBD or Ceph storage"},{"line_number":51,"context_line":"backends are used for image storage."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Possible values:"},{"line_number":54,"context_line":"    * qcow2"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa7ab95a_363a90ce","line":51,"range":{"start_line":50,"start_character":0,"end_line":51,"end_character":36},"updated":"2016-08-25 21:05:51.000000000","message":"why is elaboration only on raw ? or do you intend to add more later?","commit_id":"b963a74c2f984810820e8c69a27bd2d66ff6ca3f"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"75622247dbdbb573d35ec66fb80582d26f7e3fa6","unresolved":false,"context_lines":[{"line_number":47,"context_line":"By default, ``conversion_format`` is not set and must be set"},{"line_number":48,"context_line":"explicitly in the configuration file."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"The \u0027raw\u0027 format should be chosen when RBD or Ceph storage"},{"line_number":51,"context_line":"backends are used for image storage."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Possible values:"},{"line_number":54,"context_line":"    * qcow2"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa7ab95a_915fe60d","line":51,"range":{"start_line":50,"start_character":0,"end_line":51,"end_character":36},"in_reply_to":"fa7ab95a_169e6c56","updated":"2016-08-25 21:26:52.000000000","message":"Yeah, otherwise it would seem that we are encouraging operators to use one over other. If you have a choice and mention information about one, please ensure to add a bit about others or mention that no info is known. Since this is open source, the later is rare so having some info is useful for operators to make informed decisions.","commit_id":"b963a74c2f984810820e8c69a27bd2d66ff6ca3f"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"219ec6fe9ac09f41c95b6a7b6b3e3f267c0e5dbf","unresolved":false,"context_lines":[{"line_number":47,"context_line":"By default, ``conversion_format`` is not set and must be set"},{"line_number":48,"context_line":"explicitly in the configuration file."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"The \u0027raw\u0027 format should be chosen when RBD or Ceph storage"},{"line_number":51,"context_line":"backends are used for image storage."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Possible values:"},{"line_number":54,"context_line":"    * qcow2"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa7ab95a_169e6c56","line":51,"range":{"start_line":50,"start_character":0,"end_line":51,"end_character":36},"in_reply_to":"fa7ab95a_363a90ce","updated":"2016-08-25 21:14:34.000000000","message":"Honestly, only because it is the unstructured disc format whereas qcow2 is bound to quemu and vmdk is restricted to certain VM mointors.\nDo you suggest that I add a line about the other two too?","commit_id":"b963a74c2f984810820e8c69a27bd2d66ff6ca3f"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"1958c340a00edcddaeffd6bb91907d609469f98c","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    * vmdk"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Related options:"},{"line_number":64,"context_line":"    * None"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"\"\"\")),"},{"line_number":67,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_57ad4e30","line":64,"range":{"start_line":64,"start_character":6,"end_line":64,"end_character":10},"updated":"2016-08-25 22:20:52.000000000","message":"I wonder if the disk_formats option in the default group is related here but can\u0027t decide.\n\nBasically, the conversion_format can never be a superset of the disk_formats Glance supports.\n\nThoughts?","commit_id":"bbcca2397039d2c7b655deebd64f37d13f7d9265"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"2ca241b57d711be850e8f2ac9094d3067f200781","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    * vmdk"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Related options:"},{"line_number":64,"context_line":"    * None"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"\"\"\")),"},{"line_number":67,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_c7b977eb","line":64,"range":{"start_line":64,"start_character":6,"end_line":64,"end_character":10},"in_reply_to":"fa7ab95a_0738bfd2","updated":"2016-08-26 16:18:09.000000000","message":"I agree.","commit_id":"bbcca2397039d2c7b655deebd64f37d13f7d9265"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"a34aeda8cc6685c7426c6d16571162ee5a09f940","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    * vmdk"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Related options:"},{"line_number":64,"context_line":"    * None"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"\"\"\")),"},{"line_number":67,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_e964c64a","line":64,"range":{"start_line":64,"start_character":6,"end_line":64,"end_character":10},"in_reply_to":"fa7ab95a_29eceec6","updated":"2016-08-25 22:41:00.000000000","message":"Dharini, it\u0027s not hardcoded but deprecated in favor of the new import refactor which introduces some similar opts.\n\nsee https://review.openstack.org/#/c/270980/ for more details\n\nthat opt currently being used here: https://github.com/openstack/glance/blob/6543a135f89b5efaf7663bd5efb18f7f6ad037c7/glance/api/v2/images.py#L890","commit_id":"bbcca2397039d2c7b655deebd64f37d13f7d9265"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"70d890ccbbe4ff84fc8936c42f3081ccfaa4f2b9","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    * vmdk"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Related options:"},{"line_number":64,"context_line":"    * None"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"\"\"\")),"},{"line_number":67,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_29eceec6","line":64,"range":{"start_line":64,"start_character":6,"end_line":64,"end_character":10},"in_reply_to":"fa7ab95a_57ad4e30","updated":"2016-08-25 22:36:22.000000000","message":"Nikhil,  Correct me if I am wrong. \nIn glance/common/config.py it was added to DeprecatedOpt and I guess the formats were hard coded.\nhttps://github.com/openstack/glance/blob/master/glance/common/config.py#L55","commit_id":"bbcca2397039d2c7b655deebd64f37d13f7d9265"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"87b6153ffbedaeee6165500628130e2f3ede07d6","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    * vmdk"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Related options:"},{"line_number":64,"context_line":"    * None"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"\"\"\")),"},{"line_number":67,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_0738bfd2","line":64,"range":{"start_line":64,"start_character":6,"end_line":64,"end_character":10},"in_reply_to":"fa7ab95a_e94e8695","updated":"2016-08-26 16:10:20.000000000","message":"I think Nikhil\u0027s correct here, the default.disk_format is a related option.  The point of these enhancements is to make it clear to operators how the config options hang together, so I think we should mention disk_format here.\n\nAlternatively, I could be talked out of this position!","commit_id":"bbcca2397039d2c7b655deebd64f37d13f7d9265"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"c2118037c0f3d058c212b349b488fa7731bd970a","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    * vmdk"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Related options:"},{"line_number":64,"context_line":"    * None"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"\"\"\")),"},{"line_number":67,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_e94e8695","line":64,"range":{"start_line":64,"start_character":6,"end_line":64,"end_character":10},"in_reply_to":"fa7ab95a_e964c64a","updated":"2016-08-25 22:45:23.000000000","message":"Ahhh. Makes sense. \nThanks Nikhil.","commit_id":"bbcca2397039d2c7b655deebd64f37d13f7d9265"}]}