)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"099d0341bbded74e4773f80cd8fb4c3c607b47af","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Adding improved help texts for the config options to be used for"},{"line_number":10,"context_line":"WSGI servers of the API services."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"partial bug: #1570946"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I4e3bd855cef08c8b385eebb5dbb72aaa8e51fd7e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"fa7ab95a_90dcf9e5","line":12,"updated":"2016-08-26 21:49:05.000000000","message":"Make sure you use the right syntax otherwise the link is only partially set. See an example here https://review.openstack.org/#/c/361474/\n\nmore info: http://docs.openstack.org/infra/manual/developers.html","commit_id":"e473eda58a1580b507c56537b570e7e3ac0f5f01"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"0211d5d549be37d86e0fc8efeebd46c3401fb9d9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Adding improved help texts for the config options to be used for"},{"line_number":10,"context_line":"WSGI servers of the API services."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"partial bug: #1570946"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I4e3bd855cef08c8b385eebb5dbb72aaa8e51fd7e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"fa7ab95a_1bc0734f","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":21},"updated":"2016-08-30 15:51:32.000000000","message":"Partial-Bug: #1570946","commit_id":"29f2f610aee29906aa2c543275849a36102f8057"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"8cb220cbd2f160234809b6d5d776eef58d7c8173","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Adding improved help texts for the config options to be used for"},{"line_number":10,"context_line":"WSGI servers of the API services."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"partial bug: #1570946"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I4e3bd855cef08c8b385eebb5dbb72aaa8e51fd7e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"fa7ab95a_9bc80357","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":21},"in_reply_to":"fa7ab95a_1bc0734f","updated":"2016-08-30 15:53:00.000000000","message":"Done","commit_id":"29f2f610aee29906aa2c543275849a36102f8057"}],"glance/common/wsgi.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"0e80ef96b633c79b7f390e5bc33a38edba78eda3","unresolved":false,"context_lines":[{"line_number":68,"context_line":"Services which consume this:"},{"line_number":69,"context_line":"    * glance-api"},{"line_number":70,"context_line":"    * glare-api"},{"line_number":71,"context_line":"    * glance-registry"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Possible values:"},{"line_number":74,"context_line":"    * A valid IPv4 address"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_121bdb73","line":71,"updated":"2016-07-18 22:11:02.000000000","message":"These are not correct on any of these changes.","commit_id":"0726bf7762a13e74117c66e838844e1208913a50"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8f75d3207a8878634d2cb51aea37069b3789ecfc","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Provide an IP address to bind the glance server to. The default"},{"line_number":64,"context_line":"value is 0.0.0.0 and can be edited to enable the server to listen"},{"line_number":65,"context_line":"to only one particular IP address on the network card. This, thus"},{"line_number":66,"context_line":"facilitates selection of a particular network interface for the"},{"line_number":67,"context_line":"server."},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"dada55a8_be50a35f","line":65,"range":{"start_line":65,"start_character":59,"end_line":65,"end_character":60},"updated":"2016-07-19 20:38:39.000000000","message":"nit: delete the comma","commit_id":"e65b4fd0b36c3bb020dcbf5c8076107ea6e8f058"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8f75d3207a8878634d2cb51aea37069b3789ecfc","unresolved":false,"context_lines":[{"line_number":67,"context_line":"server."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Possible values:"},{"line_number":70,"context_line":"    * A valid IPv4 address"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Related options:"},{"line_number":73,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":8,"id":"dada55a8_fee17b9b","line":70,"range":{"start_line":70,"start_character":6,"end_line":70,"end_character":26},"updated":"2016-07-19 20:38:39.000000000","message":"Can IPv6 be used for this?","commit_id":"e65b4fd0b36c3bb020dcbf5c8076107ea6e8f058"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"036370a58acb4ce595017be99e232e73991664a9","unresolved":false,"context_lines":[{"line_number":67,"context_line":"server."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Possible values:"},{"line_number":70,"context_line":"    * A valid IPv4 address"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Related options:"},{"line_number":73,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":8,"id":"dada55a8_cf4cbf44","line":70,"range":{"start_line":70,"start_character":6,"end_line":70,"end_character":26},"in_reply_to":"dada55a8_fee17b9b","updated":"2016-07-19 21:04:57.000000000","message":"I do not think we can use an IPv6 address for the bind_host as of now. Please correct me if i am wrong.","commit_id":"e65b4fd0b36c3bb020dcbf5c8076107ea6e8f058"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8f75d3207a8878634d2cb51aea37069b3789ecfc","unresolved":false,"context_lines":[{"line_number":104,"context_line":"for incoming traffic."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Possible values:"},{"line_number":107,"context_line":"    * Integer value for the number of requests"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Related options:"},{"line_number":110,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":8,"id":"dada55a8_7e3f4bd6","line":107,"range":{"start_line":107,"start_character":6,"end_line":107,"end_character":13},"updated":"2016-07-19 20:38:39.000000000","message":"Is this supposed to be a positive integer, or is this one of those cases where a negative value means \"unlimited\"?  What about zero?","commit_id":"e65b4fd0b36c3bb020dcbf5c8076107ea6e8f058"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"ebaaad8b8a581ad7c8c8685de4f86f4067c7b5a1","unresolved":false,"context_lines":[{"line_number":104,"context_line":"for incoming traffic."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Possible values:"},{"line_number":107,"context_line":"    * Integer value for the number of requests"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Related options:"},{"line_number":110,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":8,"id":"dada55a8_e80b4222","line":107,"range":{"start_line":107,"start_character":6,"end_line":107,"end_character":13},"in_reply_to":"dada55a8_7e3f4bd6","updated":"2016-07-20 19:25:51.000000000","message":"Done","commit_id":"e65b4fd0b36c3bb020dcbf5c8076107ea6e8f058"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"a08b0077715a87d4cd86d0d97fdd33a9e896314a","unresolved":false,"context_lines":[{"line_number":104,"context_line":"for incoming traffic."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Possible values:"},{"line_number":107,"context_line":"    * Integer value for the number of requests"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Related options:"},{"line_number":110,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":8,"id":"dada55a8_cffaba42","line":107,"range":{"start_line":107,"start_character":6,"end_line":107,"end_character":13},"in_reply_to":"dada55a8_e80b4222","updated":"2016-07-21 01:19:59.000000000","message":"The backlog value needs to be greater than 0 as defined in the tox genconfig file for wsgi.py","commit_id":"e65b4fd0b36c3bb020dcbf5c8076107ea6e8f058"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8f75d3207a8878634d2cb51aea37069b3789ecfc","unresolved":false,"context_lines":[{"line_number":122,"context_line":"restablishments."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Possible values:"},{"line_number":125,"context_line":"    * Integer value for time in seconds"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Related options:"},{"line_number":128,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":8,"id":"dada55a8_fe021b0a","line":125,"range":{"start_line":125,"start_character":6,"end_line":125,"end_character":13},"updated":"2016-07-19 20:38:39.000000000","message":"Same question as above ... what effect would a zero or negative value have?","commit_id":"e65b4fd0b36c3bb020dcbf5c8076107ea6e8f058"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"ebaaad8b8a581ad7c8c8685de4f86f4067c7b5a1","unresolved":false,"context_lines":[{"line_number":122,"context_line":"restablishments."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Possible values:"},{"line_number":125,"context_line":"    * Integer value for time in seconds"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Related options:"},{"line_number":128,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":8,"id":"dada55a8_0807b618","line":125,"range":{"start_line":125,"start_character":6,"end_line":125,"end_character":13},"in_reply_to":"dada55a8_fe021b0a","updated":"2016-07-20 19:25:51.000000000","message":"Done","commit_id":"e65b4fd0b36c3bb020dcbf5c8076107ea6e8f058"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8f75d3207a8878634d2cb51aea37069b3789ecfc","unresolved":false,"context_lines":[{"line_number":197,"context_line":"of CPUs available."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"Possible values:"},{"line_number":200,"context_line":"    * Integer value typically equal to the number of CPUs"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Related options:"},{"line_number":203,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":8,"id":"dada55a8_049cfe67","line":200,"range":{"start_line":200,"start_character":6,"end_line":200,"end_character":13},"updated":"2016-07-19 20:38:39.000000000","message":"Positive integer?","commit_id":"e65b4fd0b36c3bb020dcbf5c8076107ea6e8f058"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"ebaaad8b8a581ad7c8c8685de4f86f4067c7b5a1","unresolved":false,"context_lines":[{"line_number":197,"context_line":"of CPUs available."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"Possible values:"},{"line_number":200,"context_line":"    * Integer value typically equal to the number of CPUs"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Related options:"},{"line_number":203,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":8,"id":"dada55a8_2d0bac2b","line":200,"range":{"start_line":200,"start_character":6,"end_line":200,"end_character":13},"in_reply_to":"dada55a8_049cfe67","updated":"2016-07-20 19:25:51.000000000","message":"Done","commit_id":"e65b4fd0b36c3bb020dcbf5c8076107ea6e8f058"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8f75d3207a8878634d2cb51aea37069b3789ecfc","unresolved":false,"context_lines":[{"line_number":216,"context_line":"for max_header_line is 16384."},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"Possible values:"},{"line_number":219,"context_line":"    * Valid integer value for length"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"Related options:"},{"line_number":222,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":8,"id":"dada55a8_e4cbaa51","line":219,"range":{"start_line":219,"start_character":12,"end_line":219,"end_character":19},"updated":"2016-07-19 20:38:39.000000000","message":"What happens for zero or negative value?","commit_id":"e65b4fd0b36c3bb020dcbf5c8076107ea6e8f058"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"ebaaad8b8a581ad7c8c8685de4f86f4067c7b5a1","unresolved":false,"context_lines":[{"line_number":216,"context_line":"for max_header_line is 16384."},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"Possible values:"},{"line_number":219,"context_line":"    * Valid integer value for length"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"Related options:"},{"line_number":222,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":8,"id":"dada55a8_c800fe03","line":219,"range":{"start_line":219,"start_character":12,"end_line":219,"end_character":19},"in_reply_to":"dada55a8_e4cbaa51","updated":"2016-07-20 19:25:51.000000000","message":"Done","commit_id":"e65b4fd0b36c3bb020dcbf5c8076107ea6e8f058"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8f75d3207a8878634d2cb51aea37069b3789ecfc","unresolved":false,"context_lines":[{"line_number":256,"context_line":"value of 0 seconds means a wait forever."},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"Possible values:"},{"line_number":259,"context_line":"    * Valid integer value for time in seconds"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"Related options:"},{"line_number":262,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":8,"id":"dada55a8_2422e200","line":259,"range":{"start_line":259,"start_character":12,"end_line":259,"end_character":19},"updated":"2016-07-19 20:38:39.000000000","message":"Positive integer?","commit_id":"e65b4fd0b36c3bb020dcbf5c8076107ea6e8f058"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"ebaaad8b8a581ad7c8c8685de4f86f4067c7b5a1","unresolved":false,"context_lines":[{"line_number":256,"context_line":"value of 0 seconds means a wait forever."},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"Possible values:"},{"line_number":259,"context_line":"    * Valid integer value for time in seconds"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"Related options:"},{"line_number":262,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":8,"id":"dada55a8_a805ca11","line":259,"range":{"start_line":259,"start_character":12,"end_line":259,"end_character":19},"in_reply_to":"dada55a8_2422e200","updated":"2016-07-20 19:25:51.000000000","message":"Done","commit_id":"e65b4fd0b36c3bb020dcbf5c8076107ea6e8f058"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"68a0fb62890f0d1e6ab71f261fa68a2609561981","unresolved":false,"context_lines":[{"line_number":67,"context_line":"server."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Possible values:"},{"line_number":70,"context_line":"    * A valid IPv4 address"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Related options:"},{"line_number":73,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_12a360b3","line":70,"updated":"2016-07-20 22:27:35.000000000","message":"I tried this in devstack and IPv6 does seem to work.","commit_id":"04d20f5e1025eb715f90fb4d8837cc76f694a617"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"b8c9639449a4d95bd8f3215b0f1e9ef463f5ea3b","unresolved":false,"context_lines":[{"line_number":67,"context_line":"server."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Possible values:"},{"line_number":70,"context_line":"    * A valid IPv4 address"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Related options:"},{"line_number":73,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_f8a14bf9","line":70,"in_reply_to":"dada55a8_12a360b3","updated":"2016-07-21 00:57:34.000000000","message":"Done","commit_id":"04d20f5e1025eb715f90fb4d8837cc76f694a617"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"ccace691c1e20963eaa98e12bff14f31e2e2c7ea","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    * A valid IPv4 address"},{"line_number":71,"context_line":"    * A valid IPv6 address"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Related options:"},{"line_number":74,"context_line":"    * None"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"\"\"\")),"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_612e558d","line":74,"range":{"start_line":73,"start_character":0,"end_line":74,"end_character":10},"updated":"2016-07-26 16:18:39.000000000","message":"I suggest dropping sections that do not give any additional information.","commit_id":"759473022f8d984166f3b99fc456242dcd0a4850"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"ccace691c1e20963eaa98e12bff14f31e2e2c7ea","unresolved":false,"context_lines":[{"line_number":87,"context_line":"Possible values:"},{"line_number":88,"context_line":"    * A valid port number (0 to 65535)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Related options:"},{"line_number":91,"context_line":"    * None"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"\"\"\")),"},{"line_number":94,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_a1520d11","line":91,"range":{"start_line":90,"start_character":0,"end_line":91,"end_character":10},"updated":"2016-07-26 16:18:39.000000000","message":"Ditto","commit_id":"759473022f8d984166f3b99fc456242dcd0a4850"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"ccace691c1e20963eaa98e12bff14f31e2e2c7ea","unresolved":false,"context_lines":[{"line_number":104,"context_line":"server. Setting the backlog for a TCP socket ensures a limited queue"},{"line_number":105,"context_line":"size for incoming traffic."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Possible values:"},{"line_number":108,"context_line":"    * Positive integer"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Related options:"},{"line_number":111,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_4142313f","line":108,"range":{"start_line":107,"start_character":0,"end_line":108,"end_character":22},"updated":"2016-07-26 16:18:39.000000000","message":"Add min\u003d0 to IntOpt and drop this section. It is self-explanatory.","commit_id":"759473022f8d984166f3b99fc456242dcd0a4850"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"ccace691c1e20963eaa98e12bff14f31e2e2c7ea","unresolved":false,"context_lines":[{"line_number":107,"context_line":"Possible values:"},{"line_number":108,"context_line":"    * Positive integer"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Related options:"},{"line_number":111,"context_line":"    * None"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"\"\"\")),"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_8148a95d","line":111,"range":{"start_line":110,"start_character":0,"end_line":111,"end_character":10},"updated":"2016-07-26 16:18:39.000000000","message":"I suggest dropping sections that do not give any additional information.","commit_id":"759473022f8d984166f3b99fc456242dcd0a4850"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"ccace691c1e20963eaa98e12bff14f31e2e2c7ea","unresolved":false,"context_lines":[{"line_number":122,"context_line":"intact at regular intervals thereby preventing frequent TCP"},{"line_number":123,"context_line":"connection restablishments. The default value is 600 seconds."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Possible values:"},{"line_number":126,"context_line":"    * Positive integer value for time in seconds"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Related options:"},{"line_number":129,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_e16fe5c1","line":126,"range":{"start_line":125,"start_character":0,"end_line":126,"end_character":48},"updated":"2016-07-26 16:18:39.000000000","message":"Ditto","commit_id":"759473022f8d984166f3b99fc456242dcd0a4850"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"ccace691c1e20963eaa98e12bff14f31e2e2c7ea","unresolved":false,"context_lines":[{"line_number":125,"context_line":"Possible values:"},{"line_number":126,"context_line":"    * Positive integer value for time in seconds"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Related options:"},{"line_number":129,"context_line":"    * None"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"\"\"\")),"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_a1796d95","line":129,"range":{"start_line":128,"start_character":0,"end_line":129,"end_character":10},"updated":"2016-07-26 16:18:39.000000000","message":"Ditto","commit_id":"759473022f8d984166f3b99fc456242dcd0a4850"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"ccace691c1e20963eaa98e12bff14f31e2e2c7ea","unresolved":false,"context_lines":[{"line_number":197,"context_line":"helps increase the overall perfomance. The default number for"},{"line_number":198,"context_line":"workers is the number of CPUs available."},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"Possible values:"},{"line_number":201,"context_line":"    * Positive integer value typically equal to the number of CPUs"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"Related options:"},{"line_number":204,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_615c9519","line":201,"range":{"start_line":200,"start_character":0,"end_line":201,"end_character":66},"updated":"2016-07-26 16:18:39.000000000","message":"Ditto","commit_id":"759473022f8d984166f3b99fc456242dcd0a4850"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"ccace691c1e20963eaa98e12bff14f31e2e2c7ea","unresolved":false,"context_lines":[{"line_number":200,"context_line":"Possible values:"},{"line_number":201,"context_line":"    * Positive integer value typically equal to the number of CPUs"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"Related options:"},{"line_number":204,"context_line":"    * None"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"\"\"\")),"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_815f090e","line":204,"range":{"start_line":203,"start_character":0,"end_line":204,"end_character":10},"updated":"2016-07-26 16:18:39.000000000","message":"Ditto","commit_id":"759473022f8d984166f3b99fc456242dcd0a4850"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"ccace691c1e20963eaa98e12bff14f31e2e2c7ea","unresolved":false,"context_lines":[{"line_number":217,"context_line":"max_header_line to 0 sets no limit for the line size of message"},{"line_number":218,"context_line":"headers. The default value is 16384."},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"Possible values:"},{"line_number":221,"context_line":"    * 0"},{"line_number":222,"context_line":"    * Positive integer"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"Related options:"},{"line_number":225,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_21ad7de9","line":222,"range":{"start_line":220,"start_character":0,"end_line":222,"end_character":22},"updated":"2016-07-26 16:18:39.000000000","message":"Ditto","commit_id":"759473022f8d984166f3b99fc456242dcd0a4850"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"ccace691c1e20963eaa98e12bff14f31e2e2c7ea","unresolved":false,"context_lines":[{"line_number":221,"context_line":"    * 0"},{"line_number":222,"context_line":"    * Positive integer"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"Related options:"},{"line_number":225,"context_line":"    * None"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"\"\"\")),"},{"line_number":228,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_c19bc1c7","line":225,"range":{"start_line":224,"start_character":0,"end_line":225,"end_character":10},"updated":"2016-07-26 16:18:39.000000000","message":"Ditto","commit_id":"759473022f8d984166f3b99fc456242dcd0a4850"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"ccace691c1e20963eaa98e12bff14f31e2e2c7ea","unresolved":false,"context_lines":[{"line_number":243,"context_line":"    * True"},{"line_number":244,"context_line":"    * False"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"Related options:"},{"line_number":247,"context_line":"    * None"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"\"\"\")),"},{"line_number":250,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_61b3f54d","line":247,"range":{"start_line":246,"start_character":0,"end_line":247,"end_character":10},"updated":"2016-07-26 16:18:39.000000000","message":"Ditto","commit_id":"759473022f8d984166f3b99fc456242dcd0a4850"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"ccace691c1e20963eaa98e12bff14f31e2e2c7ea","unresolved":false,"context_lines":[{"line_number":262,"context_line":"    * None"},{"line_number":263,"context_line":"    * Positive integer"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"Related options:"},{"line_number":266,"context_line":"    * None"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"\"\"\")),"},{"line_number":269,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_4197d18f","line":266,"range":{"start_line":265,"start_character":0,"end_line":266,"end_character":10},"updated":"2016-07-26 16:18:39.000000000","message":"Ditto","commit_id":"759473022f8d984166f3b99fc456242dcd0a4850"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"099d0341bbded74e4773f80cd8fb4c3c607b47af","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"bind_opts \u003d ["},{"line_number":59,"context_line":"    cfg.IPOpt(\u0027bind_host\u0027,"},{"line_number":60,"context_line":"              default\u003d\u00270.0.0.0\u0027,"},{"line_number":61,"context_line":"              help\u003d_(\"\"\""},{"line_number":62,"context_line":"IP address to bind the glance servers to."}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_f0f8e54b","line":59,"range":{"start_line":59,"start_character":8,"end_line":59,"end_character":13},"updated":"2016-08-26 21:49:05.000000000","message":"Does changing the opt type affect ops in any significant or non-significant way?","commit_id":"e473eda58a1580b507c56537b570e7e3ac0f5f01"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"c1bdf70185684551e71eaa1a1ffc52f9498ce796","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"bind_opts \u003d ["},{"line_number":59,"context_line":"    cfg.IPOpt(\u0027bind_host\u0027,"},{"line_number":60,"context_line":"              default\u003d\u00270.0.0.0\u0027,"},{"line_number":61,"context_line":"              help\u003d_(\"\"\""},{"line_number":62,"context_line":"IP address to bind the glance servers to."}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_e8e8f97e","line":59,"range":{"start_line":59,"start_character":8,"end_line":59,"end_character":13},"in_reply_to":"fa7ab95a_f0f8e54b","updated":"2016-08-26 23:01:49.000000000","message":"I changed this Opt type based on the test files for this opt and also as the bind server addresses are IP addresses.\nI am not very sure if it will affect ops. Please advise if we should stick with StrOpt here.","commit_id":"e473eda58a1580b507c56537b570e7e3ac0f5f01"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"536c846bd409ffa952ad980e55a233a81f6386d8","unresolved":false,"context_lines":[{"line_number":207,"context_line":"               help\u003d_(\"\"\""},{"line_number":208,"context_line":"Number of Glance worker processes to start."},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Provide a positive integer value to set the number of child process"},{"line_number":211,"context_line":"workers to service requests. By default, the number of CPUs available"},{"line_number":212,"context_line":"is set as the value for ``workers``."},{"line_number":213,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_c64c0773","line":210,"range":{"start_line":210,"start_character":10,"end_line":210,"end_character":18},"updated":"2016-08-26 22:17:43.000000000","message":"s/positive/non-negative/","commit_id":"e473eda58a1580b507c56537b570e7e3ac0f5f01"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"c1bdf70185684551e71eaa1a1ffc52f9498ce796","unresolved":false,"context_lines":[{"line_number":207,"context_line":"               help\u003d_(\"\"\""},{"line_number":208,"context_line":"Number of Glance worker processes to start."},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Provide a positive integer value to set the number of child process"},{"line_number":211,"context_line":"workers to service requests. By default, the number of CPUs available"},{"line_number":212,"context_line":"is set as the value for ``workers``."},{"line_number":213,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_2803c143","line":210,"range":{"start_line":210,"start_character":10,"end_line":210,"end_character":18},"in_reply_to":"fa7ab95a_c64c0773","updated":"2016-08-26 23:01:49.000000000","message":"Done","commit_id":"e473eda58a1580b507c56537b570e7e3ac0f5f01"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"536c846bd409ffa952ad980e55a233a81f6386d8","unresolved":false,"context_lines":[{"line_number":215,"context_line":"configuration file. Increasing the number of workers helps"},{"line_number":216,"context_line":"increase the overall perfomance."},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"NOTE: Setting the number of workers to zero, triggers a creation of"},{"line_number":219,"context_line":"an eventlet pool of size 1000."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_c6ba4723","line":218,"range":{"start_line":218,"start_character":54,"end_line":218,"end_character":56},"updated":"2016-08-26 22:17:43.000000000","message":"s/a/the/","commit_id":"e473eda58a1580b507c56537b570e7e3ac0f5f01"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"c1bdf70185684551e71eaa1a1ffc52f9498ce796","unresolved":false,"context_lines":[{"line_number":215,"context_line":"configuration file. Increasing the number of workers helps"},{"line_number":216,"context_line":"increase the overall perfomance."},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"NOTE: Setting the number of workers to zero, triggers a creation of"},{"line_number":219,"context_line":"an eventlet pool of size 1000."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_48fe4539","line":218,"range":{"start_line":218,"start_character":54,"end_line":218,"end_character":56},"in_reply_to":"fa7ab95a_c6ba4723","updated":"2016-08-26 23:01:49.000000000","message":"Done","commit_id":"e473eda58a1580b507c56537b570e7e3ac0f5f01"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"536c846bd409ffa952ad980e55a233a81f6386d8","unresolved":false,"context_lines":[{"line_number":219,"context_line":"an eventlet pool of size 1000."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"Possible values:"},{"line_number":222,"context_line":"    * Positive integer value typically equal to the number of CPUs"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"Related options:"},{"line_number":225,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_a66463e5","line":222,"range":{"start_line":222,"start_character":4,"end_line":222,"end_character":66},"updated":"2016-08-26 22:17:43.000000000","message":"* 0\n* Positive integer value...","commit_id":"e473eda58a1580b507c56537b570e7e3ac0f5f01"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"c1bdf70185684551e71eaa1a1ffc52f9498ce796","unresolved":false,"context_lines":[{"line_number":219,"context_line":"an eventlet pool of size 1000."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"Possible values:"},{"line_number":222,"context_line":"    * Positive integer value typically equal to the number of CPUs"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"Related options:"},{"line_number":225,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_68fdc939","line":222,"range":{"start_line":222,"start_character":4,"end_line":222,"end_character":66},"in_reply_to":"fa7ab95a_a66463e5","updated":"2016-08-26 23:01:49.000000000","message":"Done","commit_id":"e473eda58a1580b507c56537b570e7e3ac0f5f01"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"536c846bd409ffa952ad980e55a233a81f6386d8","unresolved":false,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"NOTE: ``max_header_line`` may need to be increased when using large"},{"line_number":239,"context_line":"tokens (typically those generated by the Keystone v3 API with big"},{"line_number":240,"context_line":"service catalogs). However, it is to be kept in mind that larger"},{"line_number":241,"context_line":"values for max_header_line would flood the logs."},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"Setting ``max_header_line`` to 0 sets no limit for the line size of"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_66cedbb5","line":240,"range":{"start_line":240,"start_character":58,"end_line":240,"end_character":64},"updated":"2016-08-26 22:17:43.000000000","message":"Just wondering, do we have any idea of the \"larger\" threshold? This seems nebulous.","commit_id":"e473eda58a1580b507c56537b570e7e3ac0f5f01"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"c1bdf70185684551e71eaa1a1ffc52f9498ce796","unresolved":false,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"NOTE: ``max_header_line`` may need to be increased when using large"},{"line_number":239,"context_line":"tokens (typically those generated by the Keystone v3 API with big"},{"line_number":240,"context_line":"service catalogs). However, it is to be kept in mind that larger"},{"line_number":241,"context_line":"values for max_header_line would flood the logs."},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"Setting ``max_header_line`` to 0 sets no limit for the line size of"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_88a68d51","line":240,"range":{"start_line":240,"start_character":58,"end_line":240,"end_character":64},"in_reply_to":"fa7ab95a_66cedbb5","updated":"2016-08-26 23:01:49.000000000","message":"Unfortunately in the code, there is no threshold Alex. This opt is to help limit the size. But there is no max maybe cos it is totally upto the user here. Hence we just give a warning here.","commit_id":"e473eda58a1580b507c56537b570e7e3ac0f5f01"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"536c846bd409ffa952ad980e55a233a81f6386d8","unresolved":false,"context_lines":[{"line_number":238,"context_line":"NOTE: ``max_header_line`` may need to be increased when using large"},{"line_number":239,"context_line":"tokens (typically those generated by the Keystone v3 API with big"},{"line_number":240,"context_line":"service catalogs). However, it is to be kept in mind that larger"},{"line_number":241,"context_line":"values for max_header_line would flood the logs."},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"Setting ``max_header_line`` to 0 sets no limit for the line size of"},{"line_number":244,"context_line":"message headers."}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_e6baeb09","line":241,"range":{"start_line":241,"start_character":11,"end_line":241,"end_character":26},"updated":"2016-08-26 22:17:43.000000000","message":"s/max_header_line/``max_header_line``/","commit_id":"e473eda58a1580b507c56537b570e7e3ac0f5f01"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"c1bdf70185684551e71eaa1a1ffc52f9498ce796","unresolved":false,"context_lines":[{"line_number":238,"context_line":"NOTE: ``max_header_line`` may need to be increased when using large"},{"line_number":239,"context_line":"tokens (typically those generated by the Keystone v3 API with big"},{"line_number":240,"context_line":"service catalogs). However, it is to be kept in mind that larger"},{"line_number":241,"context_line":"values for max_header_line would flood the logs."},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"Setting ``max_header_line`` to 0 sets no limit for the line size of"},{"line_number":244,"context_line":"message headers."}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_287821c4","line":241,"range":{"start_line":241,"start_character":11,"end_line":241,"end_character":26},"in_reply_to":"fa7ab95a_e6baeb09","updated":"2016-08-26 23:01:49.000000000","message":"Done","commit_id":"e473eda58a1580b507c56537b570e7e3ac0f5f01"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"536c846bd409ffa952ad980e55a233a81f6386d8","unresolved":false,"context_lines":[{"line_number":260,"context_line":"Provide a boolean value to determine sending of keep alive packets."},{"line_number":261,"context_line":"If set to ``False``, the server returns the header \"Connection: close\"."},{"line_number":262,"context_line":"If set to ``True``, the server returns a \"Connection: Keep-Alive\" in its"},{"line_number":263,"context_line":"responses. This enables retainment of the same TCP connection for"},{"line_number":264,"context_line":"HTTP conversations instead of opening a new one with each new"},{"line_number":265,"context_line":"request."},{"line_number":266,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_26d77324","line":263,"range":{"start_line":263,"start_character":24,"end_line":263,"end_character":34},"updated":"2016-08-26 22:17:43.000000000","message":"this is a total nit, feel free to ignore, but: s/retainment/retention/","commit_id":"e473eda58a1580b507c56537b570e7e3ac0f5f01"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"c1bdf70185684551e71eaa1a1ffc52f9498ce796","unresolved":false,"context_lines":[{"line_number":260,"context_line":"Provide a boolean value to determine sending of keep alive packets."},{"line_number":261,"context_line":"If set to ``False``, the server returns the header \"Connection: close\"."},{"line_number":262,"context_line":"If set to ``True``, the server returns a \"Connection: Keep-Alive\" in its"},{"line_number":263,"context_line":"responses. This enables retainment of the same TCP connection for"},{"line_number":264,"context_line":"HTTP conversations instead of opening a new one with each new"},{"line_number":265,"context_line":"request."},{"line_number":266,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_68822996","line":263,"range":{"start_line":263,"start_character":24,"end_line":263,"end_character":34},"in_reply_to":"fa7ab95a_26d77324","updated":"2016-08-26 23:01:49.000000000","message":"Done","commit_id":"e473eda58a1580b507c56537b570e7e3ac0f5f01"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ae7c3d9c352ed84f9edb610eb5a9affabb8353e1","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"bind_opts \u003d ["},{"line_number":59,"context_line":"    cfg.IPOpt(\u0027bind_host\u0027,"},{"line_number":60,"context_line":"              default\u003d\u00270.0.0.0\u0027,"},{"line_number":61,"context_line":"              help\u003d_(\"\"\""},{"line_number":62,"context_line":"IP address to bind the glance servers to."}],"source_content_type":"text/x-python","patch_set":18,"id":"fa7ab95a_1ce8ffe1","line":59,"range":{"start_line":59,"start_character":8,"end_line":59,"end_character":13},"updated":"2016-08-27 01:26:32.000000000","message":"I tried this in devstack with StrOpt.  It\u0027s possible to define a symbolic name in /etc/hosts, put it here, and start the API.  The API appears to be usable, though there was a little weirdness (you have to make sure the symbolic name is mapped to the IP address that keystone has in the service catalog, though in a real deployment, you\u0027d probably have symbolic names in the service catalog, too).\n\nMy advice is that although this option seems better suited to use an IP address, since it\u0027s possible to have things work with a symbolic name, we\u0027d better keep this a StrOpt -- otherwise this may break some deployments.","commit_id":"a8be47824ee8fa074eed1df4bd77b3daf8de0aa4"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"d1feedb2f1f89430a91318a6ec3fcc0a939fbc38","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"bind_opts \u003d ["},{"line_number":59,"context_line":"    cfg.IPOpt(\u0027bind_host\u0027,"},{"line_number":60,"context_line":"              default\u003d\u00270.0.0.0\u0027,"},{"line_number":61,"context_line":"              help\u003d_(\"\"\""},{"line_number":62,"context_line":"IP address to bind the glance servers to."}],"source_content_type":"text/x-python","patch_set":18,"id":"fa7ab95a_b7500c0c","line":59,"range":{"start_line":59,"start_character":8,"end_line":59,"end_character":13},"in_reply_to":"fa7ab95a_1ce8ffe1","updated":"2016-08-27 02:26:35.000000000","message":"Awesome. Thanks for clarifying Brian.","commit_id":"a8be47824ee8fa074eed1df4bd77b3daf8de0aa4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a3bb90205d405ac5213376a9c0d69a2b3ab64260","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Setting ``tcp_keepidle`` helps verify at regular intervals that a"},{"line_number":131,"context_line":"connection is intact and prevents frequent TCP connection"},{"line_number":132,"context_line":"restablishments."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Possible values:"},{"line_number":135,"context_line":"    * Positive integer value representing time in seconds"}],"source_content_type":"text/x-python","patch_set":19,"id":"fa7ab95a_a2d36837","line":132,"range":{"start_line":132,"start_character":0,"end_line":132,"end_character":15},"updated":"2016-08-27 03:47:05.000000000","message":"I think you can use a singular here, but more importantly, the spelling needs to be corrected (there\u0027s a missing \u0027e\u0027):\n\nreestablishment","commit_id":"3375c1d3821f59e9f1438a95daea11aea65c86c7"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"6700efe032f214b657732dfea0afae7eb22c7d39","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Setting ``tcp_keepidle`` helps verify at regular intervals that a"},{"line_number":131,"context_line":"connection is intact and prevents frequent TCP connection"},{"line_number":132,"context_line":"restablishments."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Possible values:"},{"line_number":135,"context_line":"    * Positive integer value representing time in seconds"}],"source_content_type":"text/x-python","patch_set":19,"id":"fa7ab95a_16da9078","line":132,"range":{"start_line":132,"start_character":0,"end_line":132,"end_character":15},"in_reply_to":"fa7ab95a_a2d36837","updated":"2016-08-27 18:39:56.000000000","message":"Done","commit_id":"3375c1d3821f59e9f1438a95daea11aea65c86c7"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"2b26229ab7d5e788fa846a04f5933d53415e6095","unresolved":false,"context_lines":[{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Provide a non-negative integer value to set the number of child"},{"line_number":211,"context_line":"process workers to service requests. By default, the number of CPUs"},{"line_number":212,"context_line":"available is set as the value for ``workers``."},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"Each worker process is made to listen on the port set in the"},{"line_number":215,"context_line":"configuration file. Increasing the number of workers helps"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa7ab95a_b8318a5c","line":212,"updated":"2016-08-29 20:06:39.000000000","message":"Let\u0027s add a line mentioning that each child process creates contains a greenthread pool of size 1000.","commit_id":"bbdb5781a3375776de59e39602842d86a157a171"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"2167161e3b19b209cc73d5af61d99bf3ff0062ba","unresolved":false,"context_lines":[{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Provide a non-negative integer value to set the number of child"},{"line_number":211,"context_line":"process workers to service requests. By default, the number of CPUs"},{"line_number":212,"context_line":"available is set as the value for ``workers``."},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"Each worker process is made to listen on the port set in the"},{"line_number":215,"context_line":"configuration file. Increasing the number of workers helps"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa7ab95a_6991f2f0","line":212,"in_reply_to":"fa7ab95a_b8318a5c","updated":"2016-08-29 20:58:57.000000000","message":"Done","commit_id":"bbdb5781a3375776de59e39602842d86a157a171"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"2b26229ab7d5e788fa846a04f5933d53415e6095","unresolved":false,"context_lines":[{"line_number":212,"context_line":"available is set as the value for ``workers``."},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"Each worker process is made to listen on the port set in the"},{"line_number":215,"context_line":"configuration file. Increasing the number of workers helps"},{"line_number":216,"context_line":"increase the overall perfomance."},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"NOTE: Setting the number of workers to zero, triggers the creation of"},{"line_number":219,"context_line":"an eventlet pool of size 1000."}],"source_content_type":"text/x-python","patch_set":20,"id":"fa7ab95a_7818e275","line":216,"range":{"start_line":215,"start_character":20,"end_line":216,"end_character":32},"updated":"2016-08-29 20:06:39.000000000","message":"This isn\u0027t true necessarily. It is really depends on how glance is deployed and what the load characteristics. If the glance API is doing import/export like operations, it\u0027s bound to degrade the performance. \n\nI recommend dropping this line.","commit_id":"bbdb5781a3375776de59e39602842d86a157a171"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"2167161e3b19b209cc73d5af61d99bf3ff0062ba","unresolved":false,"context_lines":[{"line_number":212,"context_line":"available is set as the value for ``workers``."},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"Each worker process is made to listen on the port set in the"},{"line_number":215,"context_line":"configuration file. Increasing the number of workers helps"},{"line_number":216,"context_line":"increase the overall perfomance."},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"NOTE: Setting the number of workers to zero, triggers the creation of"},{"line_number":219,"context_line":"an eventlet pool of size 1000."}],"source_content_type":"text/x-python","patch_set":20,"id":"fa7ab95a_4988aec5","line":216,"range":{"start_line":215,"start_character":20,"end_line":216,"end_character":32},"in_reply_to":"fa7ab95a_7818e275","updated":"2016-08-29 20:58:57.000000000","message":"Done","commit_id":"bbdb5781a3375776de59e39602842d86a157a171"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"2b26229ab7d5e788fa846a04f5933d53415e6095","unresolved":false,"context_lines":[{"line_number":216,"context_line":"increase the overall perfomance."},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"NOTE: Setting the number of workers to zero, triggers the creation of"},{"line_number":219,"context_line":"an eventlet pool of size 1000."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"Possible values:"},{"line_number":222,"context_line":"    * 0"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa7ab95a_b8d98a59","line":219,"range":{"start_line":219,"start_character":0,"end_line":219,"end_character":28},"updated":"2016-08-29 20:06:39.000000000","message":"\"a single API process with a greenthread pool of size 1000\"","commit_id":"bbdb5781a3375776de59e39602842d86a157a171"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"2167161e3b19b209cc73d5af61d99bf3ff0062ba","unresolved":false,"context_lines":[{"line_number":216,"context_line":"increase the overall perfomance."},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"NOTE: Setting the number of workers to zero, triggers the creation of"},{"line_number":219,"context_line":"an eventlet pool of size 1000."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"Possible values:"},{"line_number":222,"context_line":"    * 0"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa7ab95a_298b6ac4","line":219,"range":{"start_line":219,"start_character":0,"end_line":219,"end_character":28},"in_reply_to":"fa7ab95a_b8d98a59","updated":"2016-08-29 20:58:57.000000000","message":"Done","commit_id":"bbdb5781a3375776de59e39602842d86a157a171"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"2b26229ab7d5e788fa846a04f5933d53415e6095","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"Possible values:"},{"line_number":222,"context_line":"    * 0"},{"line_number":223,"context_line":"    * Positive integer value typically equal to the number of CPUs"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"Related options:"},{"line_number":226,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa7ab95a_f8ccf2bc","line":223,"range":{"start_line":223,"start_character":29,"end_line":223,"end_character":66},"updated":"2016-08-29 20:06:39.000000000","message":"let\u0027s add parenthesis around this.","commit_id":"bbdb5781a3375776de59e39602842d86a157a171"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"2167161e3b19b209cc73d5af61d99bf3ff0062ba","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"Possible values:"},{"line_number":222,"context_line":"    * 0"},{"line_number":223,"context_line":"    * Positive integer value typically equal to the number of CPUs"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"Related options:"},{"line_number":226,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa7ab95a_89f71658","line":223,"range":{"start_line":223,"start_character":29,"end_line":223,"end_character":66},"in_reply_to":"fa7ab95a_f8ccf2bc","updated":"2016-08-29 20:58:57.000000000","message":"Done","commit_id":"bbdb5781a3375776de59e39602842d86a157a171"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"2b26229ab7d5e788fa846a04f5933d53415e6095","unresolved":false,"context_lines":[{"line_number":260,"context_line":""},{"line_number":261,"context_line":"Provide a boolean value to determine sending of keep alive packets."},{"line_number":262,"context_line":"If set to ``False``, the server returns the header \"Connection: close\"."},{"line_number":263,"context_line":"If set to ``True``, the server returns a \"Connection: Keep-Alive\" in its"},{"line_number":264,"context_line":"responses. This enables retention of the same TCP connection for"},{"line_number":265,"context_line":"HTTP conversations instead of opening a new one with each new"},{"line_number":266,"context_line":"request."}],"source_content_type":"text/x-python","patch_set":20,"id":"fa7ab95a_3801fa38","line":263,"range":{"start_line":263,"start_character":0,"end_line":263,"end_character":72},"updated":"2016-08-29 20:06:39.000000000","message":"This line will break the formatting as it goes beyond 69.","commit_id":"bbdb5781a3375776de59e39602842d86a157a171"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"2167161e3b19b209cc73d5af61d99bf3ff0062ba","unresolved":false,"context_lines":[{"line_number":260,"context_line":""},{"line_number":261,"context_line":"Provide a boolean value to determine sending of keep alive packets."},{"line_number":262,"context_line":"If set to ``False``, the server returns the header \"Connection: close\"."},{"line_number":263,"context_line":"If set to ``True``, the server returns a \"Connection: Keep-Alive\" in its"},{"line_number":264,"context_line":"responses. This enables retention of the same TCP connection for"},{"line_number":265,"context_line":"HTTP conversations instead of opening a new one with each new"},{"line_number":266,"context_line":"request."}],"source_content_type":"text/x-python","patch_set":20,"id":"fa7ab95a_e957c257","line":263,"range":{"start_line":263,"start_character":0,"end_line":263,"end_character":72},"in_reply_to":"fa7ab95a_3801fa38","updated":"2016-08-29 20:58:57.000000000","message":"Done","commit_id":"bbdb5781a3375776de59e39602842d86a157a171"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"2b26229ab7d5e788fa846a04f5933d53415e6095","unresolved":false,"context_lines":[{"line_number":288,"context_line":"the period of wait before an incoming connection can be closed. The"},{"line_number":289,"context_line":"default value is 900 seconds."},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"A None value implies a wait forever."},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"Possible values:"},{"line_number":294,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa7ab95a_9861263c","line":291,"range":{"start_line":291,"start_character":2,"end_line":291,"end_character":6},"updated":"2016-08-29 20:06:39.000000000","message":"You mean a zero value?","commit_id":"bbdb5781a3375776de59e39602842d86a157a171"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"2167161e3b19b209cc73d5af61d99bf3ff0062ba","unresolved":false,"context_lines":[{"line_number":288,"context_line":"the period of wait before an incoming connection can be closed. The"},{"line_number":289,"context_line":"default value is 900 seconds."},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"A None value implies a wait forever."},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"Possible values:"},{"line_number":294,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa7ab95a_c9667e50","line":291,"range":{"start_line":291,"start_character":2,"end_line":291,"end_character":6},"in_reply_to":"fa7ab95a_9861263c","updated":"2016-08-29 20:58:57.000000000","message":"It accepts \"None\" too. But i guess 0 is more appropriate here.\nWill change it to \"0\".\nThanks Hemanth.","commit_id":"bbdb5781a3375776de59e39602842d86a157a171"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"32d75b0fc481453654c0f3d47b7d11d00fe7ea93","unresolved":false,"context_lines":[{"line_number":288,"context_line":"the period of wait before an incoming connection can be closed. The"},{"line_number":289,"context_line":"default value is 900 seconds."},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"A None value implies a wait forever."},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"Possible values:"},{"line_number":294,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa7ab95a_df0f1037","line":291,"range":{"start_line":291,"start_character":2,"end_line":291,"end_character":6},"in_reply_to":"fa7ab95a_a42cff02","updated":"2016-08-29 21:40:30.000000000","message":"Ahhh my bad. I meant the code interprets a \u00270\u0027 value to None. \n(https://github.com/openstack/glance/blob/master/glance/common/wsgi.py#L387).\nBut as you told, if not set, it has the default anyway. It is not appropriate to have the help text say \"None\" is a forever wait.","commit_id":"bbdb5781a3375776de59e39602842d86a157a171"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"11ea6ac7b7e18312a47bf857b88971f0ca8c8f1a","unresolved":false,"context_lines":[{"line_number":288,"context_line":"the period of wait before an incoming connection can be closed. The"},{"line_number":289,"context_line":"default value is 900 seconds."},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"A None value implies a wait forever."},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"Possible values:"},{"line_number":294,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa7ab95a_a42cff02","line":291,"range":{"start_line":291,"start_character":2,"end_line":291,"end_character":6},"in_reply_to":"fa7ab95a_c9667e50","updated":"2016-08-29 21:12:57.000000000","message":"How can one set an config opt to None in the config file?\nIt is either set to something or not set at al.\nNone could be interpretation in code when an opt is not set. In that case, we have the default any way.\n\nDoes that make sense?","commit_id":"bbdb5781a3375776de59e39602842d86a157a171"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"8c7b0c1ebbfaf937d756c256f4dc6d4e7a6c4006","unresolved":false,"context_lines":[{"line_number":287,"context_line":"the period of wait before an incoming connection can be closed. The"},{"line_number":288,"context_line":"default value is 900 seconds."},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"A value of \u00270\u0027 implies a wait forever."},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"Possible values:"},{"line_number":293,"context_line":"    * Zero"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa7ab95a_4425f306","line":290,"range":{"start_line":290,"start_character":12,"end_line":290,"end_character":13},"updated":"2016-08-29 21:16:20.000000000","message":"zero or ``0`` to be consistent with our other patches.\nHow about \"The value zero implies wait forever\".","commit_id":"17abb2de480fccc2f29b78bbc051c6cb6cc07b6a"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"bf7e1dd8c77db572ecd7bfd0db150c9deca3355f","unresolved":false,"context_lines":[{"line_number":287,"context_line":"the period of wait before an incoming connection can be closed. The"},{"line_number":288,"context_line":"default value is 900 seconds."},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"A value of \u00270\u0027 implies a wait forever."},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"Possible values:"},{"line_number":293,"context_line":"    * Zero"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa7ab95a_9a2756b5","line":290,"range":{"start_line":290,"start_character":12,"end_line":290,"end_character":13},"in_reply_to":"fa7ab95a_4425f306","updated":"2016-08-29 21:40:38.000000000","message":"Done","commit_id":"17abb2de480fccc2f29b78bbc051c6cb6cc07b6a"}]}