)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"3e28a81cf9f251244837a3395c63b1e44404fdb4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gábor Antal \u003cantal@inf.u-szeged.hu\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-14 16:03:19 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Correct exception catching in metadef_namespaces.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In glance/api/v2/metadef.py:208, a non-exception is catched."},{"line_number":10,"context_line":"Corrected to general exception class."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1aa78d24_2aa2e19a","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":51},"updated":"2016-07-14 14:50:22.000000000","message":"Fix NameError in metadef_namespaces\n\nIn glance/api/v2/metadef.py exception is used instead of Exception for catching generic exception which will result in NameError.\n\nChanged exception to Exception to resolve this.","commit_id":"60b3f06f72aed5828e4b41f85bbafef9ebe307ab"}],"glance/api/v2/metadef_namespaces.py":[{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"0cf97cd93012eacc86240529f7ef9418a5ba83ac","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                namespace_repo.remove(namespace_obj)"},{"line_number":206,"context_line":"                LOG.debug(\"Cleaned up namespace %(namespace)s \","},{"line_number":207,"context_line":"                          {\u0027namespace\u0027: namespace.namespace})"},{"line_number":208,"context_line":"            except Exception:"},{"line_number":209,"context_line":"                msg \u003d (_LE(\"Failed to delete namespace %(namespace)s \") %"},{"line_number":210,"context_line":"                       {\u0027namespace\u0027: namespace.namespace})"},{"line_number":211,"context_line":"                LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_ca151d4a","line":208,"updated":"2016-07-14 14:55:41.000000000","message":"Some info about exception would be good in msg.","commit_id":"60b3f06f72aed5828e4b41f85bbafef9ebe307ab"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f1172636b75a329fc112e514a1fff458fc07b46b","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                msg \u003d (_LE(\"Failed to delete namespace %(namespace)s \") %"},{"line_number":210,"context_line":"                       {\u0027namespace\u0027: namespace.namespace})"},{"line_number":211,"context_line":"                LOG.error(msg)"},{"line_number":212,"context_line":"                LOG.error(encodeutils.exception_to_unicode(e))"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def show(self, req, namespace, filters\u003dNone):"},{"line_number":215,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_d0765fa2","line":212,"updated":"2017-01-10 22:54:02.000000000","message":"I think it would be better to combine the exception into the msg and have a single log line, similar to what\u0027s done on line 166 (though the message up there isn\u0027t logged, but you see what I mean).  It will make it more clear in the log that this is one error, not two.","commit_id":"423c1cc447f39016027bd37145359fd72665bd7f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0576587257ea183ec1267fef2825e63bc1d6185a","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                LOG.debug(\"Cleaned up namespace %(namespace)s \","},{"line_number":207,"context_line":"                          {\u0027namespace\u0027: namespace.namespace})"},{"line_number":208,"context_line":"            except Exception as e:"},{"line_number":209,"context_line":"                msg \u003d (_LE(\"Failed to delete namespace %(namespace)s. Exception: %(exception)\") %"},{"line_number":210,"context_line":"                       {\u0027namespace\u0027: namespace.namespace,"},{"line_number":211,"context_line":"                        \u0027exception\u0027: encodeutils.exception_to_unicode(e)})"},{"line_number":212,"context_line":"                LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a3c09a3_f27e39ad","line":209,"range":{"start_line":209,"start_character":81,"end_line":209,"end_character":93},"updated":"2017-01-13 16:22:21.000000000","message":"This line is also causing the other failure, you forgot to put the \u0027s\u0027 after the named placeholder at the end, i.e., \u0027%(exception)\u0027 should be \u0027%(exception)s\u0027","commit_id":"895e1a81961578cb483f203d5115b5c1506399c1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0576587257ea183ec1267fef2825e63bc1d6185a","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                LOG.debug(\"Cleaned up namespace %(namespace)s \","},{"line_number":207,"context_line":"                          {\u0027namespace\u0027: namespace.namespace})"},{"line_number":208,"context_line":"            except Exception as e:"},{"line_number":209,"context_line":"                msg \u003d (_LE(\"Failed to delete namespace %(namespace)s. Exception: %(exception)\") %"},{"line_number":210,"context_line":"                       {\u0027namespace\u0027: namespace.namespace,"},{"line_number":211,"context_line":"                        \u0027exception\u0027: encodeutils.exception_to_unicode(e)})"},{"line_number":212,"context_line":"                LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a3c09a3_52a54d02","line":209,"updated":"2017-01-13 16:22:21.000000000","message":"This line is too long, causing the pep8 failure.\n\nSince it\u0027s in parentheses already, you can just split the strings like this:\n\n  _LE(\"first part. \"\n      \"second part\") %","commit_id":"895e1a81961578cb483f203d5115b5c1506399c1"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"3459ce330f7f00905541eb4ca198affcc3180198","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                          {\u0027namespace\u0027: namespace.namespace})"},{"line_number":208,"context_line":"            except Exception as e:"},{"line_number":209,"context_line":"                msg \u003d (_LE(\"Failed to delete namespace %(namespace)s.\""},{"line_number":210,"context_line":"                           \"Exception: %(exception)s\") %"},{"line_number":211,"context_line":"                       {\u0027namespace\u0027: namespace.namespace,"},{"line_number":212,"context_line":"                        \u0027exception\u0027: encodeutils.exception_to_unicode(e)})"},{"line_number":213,"context_line":"                LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a3c09a3_81d46cbd","line":210,"range":{"start_line":210,"start_character":55,"end_line":210,"end_character":56},"updated":"2017-01-16 19:29:26.000000000","message":"I think you need to pass the references as arguments to the translation string instead of doing it prior to the translation using a \u0027%\u0027\n\nref: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages","commit_id":"714c104af005551056a5fb61aa490996abcec8d1"}]}