)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"23ddbfceeddf3e57433d20f8555c91e14861d8f6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improving help text for swift_store_utils opts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding improvised help texts for default_swift_reference and"},{"line_number":10,"context_line":"swift_store_config_file"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie1145c7c907310f60fbb2a5bee021c00309f4e81"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dada55a8_e5c5ba5b","line":9,"range":{"start_line":9,"start_character":7,"end_line":9,"end_character":17},"updated":"2016-07-18 13:58:41.000000000","message":"Maybe you mean \"improved\" here?  Or maybe you\u0027re taking a jazz approach to writing?","commit_id":"9ae85bd9bd0a7e63335a6eec2182c86756199dc2"}],"glance/common/swift_store_utils.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"23ddbfceeddf3e57433d20f8555c91e14861d8f6","unresolved":false,"context_lines":[{"line_number":25,"context_line":"               help\u003d_(\"\"\""},{"line_number":26,"context_line":"Reference to default Swift account/backing store parameters."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Provide a string value representing a reference to the default swift"},{"line_number":29,"context_line":"account/backing store parameters. This value enables dereferencing of"},{"line_number":30,"context_line":"the parameters that are required to use while adding new images. The"},{"line_number":31,"context_line":"default value for default_swift_reference is ``ref1``."}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_05dc4e11","line":28,"range":{"start_line":28,"start_character":55,"end_line":28,"end_character":62},"updated":"2016-07-18 13:58:41.000000000","message":"Maybe say \"default set of\"?  (It needs to be clear that we\u0027re talking about the reference to the place where the actual parameters are defined, not the parameters themselves.)","commit_id":"9ae85bd9bd0a7e63335a6eec2182c86756199dc2"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"4e49e89c811e983d8902f559ecf6436f416200b0","unresolved":false,"context_lines":[{"line_number":25,"context_line":"               help\u003d_(\"\"\""},{"line_number":26,"context_line":"Reference to default Swift account/backing store parameters."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Provide a string value representing a reference to the default swift"},{"line_number":29,"context_line":"account/backing store parameters. This value enables dereferencing of"},{"line_number":30,"context_line":"the parameters that are required to use while adding new images. The"},{"line_number":31,"context_line":"default value for default_swift_reference is ``ref1``."}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_02aef784","line":28,"range":{"start_line":28,"start_character":55,"end_line":28,"end_character":62},"in_reply_to":"dada55a8_05dc4e11","updated":"2016-07-18 16:56:34.000000000","message":"Done","commit_id":"9ae85bd9bd0a7e63335a6eec2182c86756199dc2"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"23ddbfceeddf3e57433d20f8555c91e14861d8f6","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Provide a string value representing a reference to the default swift"},{"line_number":29,"context_line":"account/backing store parameters. This value enables dereferencing of"},{"line_number":30,"context_line":"the parameters that are required to use while adding new images. The"},{"line_number":31,"context_line":"default value for default_swift_reference is ``ref1``."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Services which consume this:"},{"line_number":34,"context_line":"    * glance-api"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_25651245","line":31,"range":{"start_line":31,"start_character":47,"end_line":31,"end_character":51},"updated":"2016-07-18 13:58:41.000000000","message":"Not your fault, but too bad the author used a 1 here, it looks just like an l (lowercase L).  Just something to keep in mind when you have an opportunity to name things.","commit_id":"9ae85bd9bd0a7e63335a6eec2182c86756199dc2"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"23ddbfceeddf3e57433d20f8555c91e14861d8f6","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Include a string value representing the path to a configuration file"},{"line_number":60,"context_line":"that has references for each of the configured Swift"},{"line_number":61,"context_line":"account(s)/backing stores. This option if used, helps avoid storage"},{"line_number":62,"context_line":"of credentials in the database. If left empty, customized Swift"},{"line_number":63,"context_line":"referencing gets disabled."},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_0559ee5a","line":61,"range":{"start_line":61,"start_character":39,"end_line":61,"end_character":47},"updated":"2016-07-18 13:58:41.000000000","message":"I\u0027d suggest dropping this clause.","commit_id":"9ae85bd9bd0a7e63335a6eec2182c86756199dc2"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"4e49e89c811e983d8902f559ecf6436f416200b0","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Include a string value representing the path to a configuration file"},{"line_number":60,"context_line":"that has references for each of the configured Swift"},{"line_number":61,"context_line":"account(s)/backing stores. This option if used, helps avoid storage"},{"line_number":62,"context_line":"of credentials in the database. If left empty, customized Swift"},{"line_number":63,"context_line":"referencing gets disabled."},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_629ed357","line":61,"range":{"start_line":61,"start_character":39,"end_line":61,"end_character":47},"in_reply_to":"dada55a8_0559ee5a","updated":"2016-07-18 16:56:34.000000000","message":"Done","commit_id":"9ae85bd9bd0a7e63335a6eec2182c86756199dc2"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"23ddbfceeddf3e57433d20f8555c91e14861d8f6","unresolved":false,"context_lines":[{"line_number":60,"context_line":"that has references for each of the configured Swift"},{"line_number":61,"context_line":"account(s)/backing stores. This option if used, helps avoid storage"},{"line_number":62,"context_line":"of credentials in the database. If left empty, customized Swift"},{"line_number":63,"context_line":"referencing gets disabled."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Services which consume this:"},{"line_number":66,"context_line":"    * glance-api"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_853b1eeb","line":63,"range":{"start_line":63,"start_character":12,"end_line":63,"end_character":16},"updated":"2016-07-18 13:58:41.000000000","message":"s/gets/is/","commit_id":"9ae85bd9bd0a7e63335a6eec2182c86756199dc2"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"4e49e89c811e983d8902f559ecf6436f416200b0","unresolved":false,"context_lines":[{"line_number":60,"context_line":"that has references for each of the configured Swift"},{"line_number":61,"context_line":"account(s)/backing stores. This option if used, helps avoid storage"},{"line_number":62,"context_line":"of credentials in the database. If left empty, customized Swift"},{"line_number":63,"context_line":"referencing gets disabled."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Services which consume this:"},{"line_number":66,"context_line":"    * glance-api"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_82994771","line":63,"range":{"start_line":63,"start_character":12,"end_line":63,"end_character":16},"in_reply_to":"dada55a8_853b1eeb","updated":"2016-07-18 16:56:34.000000000","message":"Done","commit_id":"9ae85bd9bd0a7e63335a6eec2182c86756199dc2"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"23ddbfceeddf3e57433d20f8555c91e14861d8f6","unresolved":false,"context_lines":[{"line_number":61,"context_line":"account(s)/backing stores. This option if used, helps avoid storage"},{"line_number":62,"context_line":"of credentials in the database. If left empty, customized Swift"},{"line_number":63,"context_line":"referencing gets disabled."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Services which consume this:"},{"line_number":66,"context_line":"    * glance-api"},{"line_number":67,"context_line":"    * glare-api"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_e81aaf6d","line":64,"updated":"2016-07-18 13:58:41.000000000","message":"Maybe add, \"We highly recommend the use of this option.\"","commit_id":"9ae85bd9bd0a7e63335a6eec2182c86756199dc2"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"4e49e89c811e983d8902f559ecf6436f416200b0","unresolved":false,"context_lines":[{"line_number":61,"context_line":"account(s)/backing stores. This option if used, helps avoid storage"},{"line_number":62,"context_line":"of credentials in the database. If left empty, customized Swift"},{"line_number":63,"context_line":"referencing gets disabled."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Services which consume this:"},{"line_number":66,"context_line":"    * glance-api"},{"line_number":67,"context_line":"    * glare-api"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_2294db35","line":64,"in_reply_to":"dada55a8_e81aaf6d","updated":"2016-07-18 16:56:34.000000000","message":"Done","commit_id":"9ae85bd9bd0a7e63335a6eec2182c86756199dc2"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"448cf9fc8a50ad24b2ea5c8899e4102ae3544346","unresolved":false,"context_lines":[{"line_number":35,"context_line":"Possible values:"},{"line_number":36,"context_line":"    * A valid string value"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Related options:"},{"line_number":39,"context_line":"    * None"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"\"\"\")),"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_1ef6d88e","line":39,"range":{"start_line":38,"start_character":0,"end_line":39,"end_character":10},"updated":"2016-07-26 16:16:02.000000000","message":"I suggest dropping sections that do not give any additional information. Also, remove empty line at the end of help text :)","commit_id":"5beabd6d04a71eaefed915203aae4a4fb2f793c2"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"448cf9fc8a50ad24b2ea5c8899e4102ae3544346","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    * None"},{"line_number":67,"context_line":"    * String value representing a vaid configuration file path"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Related options:"},{"line_number":70,"context_line":"    * None"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"\"\"\")),"},{"line_number":73,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_fe31445a","line":70,"range":{"start_line":69,"start_character":0,"end_line":70,"end_character":10},"updated":"2016-07-26 16:16:02.000000000","message":"Ditto","commit_id":"5beabd6d04a71eaefed915203aae4a4fb2f793c2"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"75bde936e5960b359a68a5dc35feb93d7405ebd3","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    * None"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"\"\"\")),"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    cfg.StrOpt(\u0027swift_store_auth_address\u0027,"},{"line_number":44,"context_line":"               deprecated_reason\u003d(\"\"\""},{"line_number":45,"context_line":"The option auth_address in the Swift back-end configuration file is"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_1d5543f9","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":0},"updated":"2016-07-30 23:28:45.000000000","message":"This extra blank line can be removed","commit_id":"f735da9efbd78e38f7f0ccd89bd00b3134c4cce4"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"75bde936e5960b359a68a5dc35feb93d7405ebd3","unresolved":false,"context_lines":[{"line_number":47,"context_line":"\"\"\"),"},{"line_number":48,"context_line":"               help\u003d_(\u0027The address where the Swift authentication service \u0027"},{"line_number":49,"context_line":"                      \u0027is listening.\u0027)),"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    cfg.StrOpt(\u0027swift_store_user\u0027, secret\u003dTrue,"},{"line_number":52,"context_line":"               deprecated_reason\u003d(\"\"\""},{"line_number":53,"context_line":"The option \u0027user\u0027 in the Swift back-end configuration file is set instead."}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_fd594f36","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":0},"updated":"2016-07-30 23:28:45.000000000","message":"Same here","commit_id":"f735da9efbd78e38f7f0ccd89bd00b3134c4cce4"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"75bde936e5960b359a68a5dc35feb93d7405ebd3","unresolved":false,"context_lines":[{"line_number":61,"context_line":"\"\"\"),"},{"line_number":62,"context_line":"               help\u003d_(\u0027Auth key for the user authenticating against the \u0027"},{"line_number":63,"context_line":"                      \u0027Swift authentication service.\u0027)),"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    cfg.StrOpt(\u0027swift_store_config_file\u0027, secret\u003dTrue,"},{"line_number":66,"context_line":"               help\u003d_(\"\"\""},{"line_number":67,"context_line":"File containing the swift account(s) configurations."}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_5d433b42","line":64,"range":{"start_line":64,"start_character":0,"end_line":64,"end_character":0},"updated":"2016-07-30 23:28:45.000000000","message":"Same here","commit_id":"f735da9efbd78e38f7f0ccd89bd00b3134c4cce4"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"a5eaa49253162fd2034a8138c6ce9763de982054","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Possible values:"},{"line_number":75,"context_line":"    * None"},{"line_number":76,"context_line":"    * String value representing a vaid configuration file path"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Related options:"},{"line_number":79,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_c0b55bed","line":76,"range":{"start_line":76,"start_character":53,"end_line":76,"end_character":62},"updated":"2016-08-05 16:54:10.000000000","message":"I think this should be:\n\nAbsolute path on the glance-api node","commit_id":"d66d0c31852781f72f26b8438cbb3da225511285"}]}
