)]}'
{"glance/registry/client/__init__.py":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"2abe3067ead0756439e556384e9af371fd972635","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    * registry_client_key_file"},{"line_number":101,"context_line":"    * registry_client_cert_file"},{"line_number":102,"context_line":"    * registry_client_insecure"},{"line_number":103,"context_line":"               "},{"line_number":104,"context_line":"\"\"\")),"},{"line_number":105,"context_line":"    cfg.BoolOpt(\u0027registry_client_insecure\u0027, default\u003dFalse,"},{"line_number":106,"context_line":"                help\u003d_(\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_1cd3da39","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":15},"updated":"2016-08-03 16:16:17.000000000","message":"This is causing the pep8 failure.","commit_id":"7ccf41902040d33fbf72bd216ccdbf7f547ddcb1"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"9bebaedd6ad485e99a5991aa31492f059eba801e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"default, this option is set to http which means that a secure"},{"line_number":32,"context_line":"connection is not established."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Possible values:"},{"line_number":35,"context_line":"    * http"},{"line_number":36,"context_line":"    * https"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_153a45cc","line":34,"updated":"2016-08-10 16:29:44.000000000","message":"If these are the 2 possible values only, can we add them to \"choices\" for this config opt?","commit_id":"e3440f4be085d33e36d465e15152915223928fb4"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"6d39b0db8952eb24b16f90b86e98bf18e58d8497","unresolved":false,"context_lines":[{"line_number":31,"context_line":"default, this option is set to http which means that a secure"},{"line_number":32,"context_line":"connection is not established."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Possible values:"},{"line_number":35,"context_line":"    * http"},{"line_number":36,"context_line":"    * https"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_999dc768","line":34,"in_reply_to":"9ad45d7e_153a45cc","updated":"2016-08-10 20:18:18.000000000","message":"Done","commit_id":"e3440f4be085d33e36d465e15152915223928fb4"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"9bebaedd6ad485e99a5991aa31492f059eba801e","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"\"\"\")),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027registry_client_key_file\u0027,"},{"line_number":46,"context_line":"               help\u003d_(\"\"\""},{"line_number":47,"context_line":"Relative path to the key file."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"This configuration option enables the user to specify the relative"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_1541a538","line":46,"updated":"2016-08-10 16:29:44.000000000","message":"secret\u003dTrue?","commit_id":"e3440f4be085d33e36d465e15152915223928fb4"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"6d39b0db8952eb24b16f90b86e98bf18e58d8497","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"\"\"\")),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027registry_client_key_file\u0027,"},{"line_number":46,"context_line":"               help\u003d_(\"\"\""},{"line_number":47,"context_line":"Relative path to the key file."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"This configuration option enables the user to specify the relative"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_b9bc0bbc","line":46,"in_reply_to":"9ad45d7e_1541a538","updated":"2016-08-10 20:18:18.000000000","message":"Done","commit_id":"e3440f4be085d33e36d465e15152915223928fb4"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"9bebaedd6ad485e99a5991aa31492f059eba801e","unresolved":false,"context_lines":[{"line_number":132,"context_line":"This configuration option takes in the period of time (in seconds)"},{"line_number":133,"context_line":"that the API server will wait for a registry request to complete. A"},{"line_number":134,"context_line":"value of 0 implies a request will never timeout."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Possible values:"},{"line_number":137,"context_line":"    * Any non-negative integer"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_359949c5","line":135,"updated":"2016-08-10 16:29:44.000000000","message":"The default is 600 seconds. \n\nAlways good to have a line about the default in the description as well.","commit_id":"e3440f4be085d33e36d465e15152915223928fb4"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"6d39b0db8952eb24b16f90b86e98bf18e58d8497","unresolved":false,"context_lines":[{"line_number":132,"context_line":"This configuration option takes in the period of time (in seconds)"},{"line_number":133,"context_line":"that the API server will wait for a registry request to complete. A"},{"line_number":134,"context_line":"value of 0 implies a request will never timeout."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Possible values:"},{"line_number":137,"context_line":"    * Any non-negative integer"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_d9de1f10","line":135,"in_reply_to":"9ad45d7e_359949c5","updated":"2016-08-10 20:18:18.000000000","message":"Done","commit_id":"e3440f4be085d33e36d465e15152915223928fb4"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"fa3e2fdbade5562517a669c8e4b9c333ba153935","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Related options:"},{"line_number":40,"context_line":"    * registry_client_key_file"},{"line_number":41,"context_line":"    * registry_client_cert_file"},{"line_number":42,"context_line":"    * registry_client_ca_file"},{"line_number":43,"context_line":"    * registry_client_insecure"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"\"\"\")),"},{"line_number":46,"context_line":"    cfg.StrOpt(\u0027registry_client_key_file\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_2f45cd6f","line":43,"range":{"start_line":42,"start_character":1,"end_line":43,"end_character":30},"updated":"2016-08-15 23:22:21.000000000","message":"Could you mention how the \u0027registry_client_ca_file\u0027 and \u0027registry_client_insecure\u0027 options are related in the description above?","commit_id":"780413f030d719285f82882a9fb87b124d18196b"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"fa3e2fdbade5562517a669c8e4b9c333ba153935","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Related options:"},{"line_number":62,"context_line":"    * registry_client_protocol"},{"line_number":63,"context_line":"    * registry_client_cert_file"},{"line_number":64,"context_line":"    * registry_client_ca_file"},{"line_number":65,"context_line":"    * registry_client_insecure"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"\"\"\")),"},{"line_number":68,"context_line":"    cfg.StrOpt(\u0027registry_client_cert_file\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_327d306f","line":65,"range":{"start_line":63,"start_character":0,"end_line":65,"end_character":30},"updated":"2016-08-15 23:22:21.000000000","message":"It seems that \u0027registry_client_cert_file\u0027, \u0027registry_client_ca_file\u0027 and \u0027registry_client_insecure\u0027 options are very loosely related to this particular option. In my opinion, they shouldn\u0027t even be mentioned as related.","commit_id":"780413f030d719285f82882a9fb87b124d18196b"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"fa3e2fdbade5562517a669c8e4b9c333ba153935","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Related options:"},{"line_number":81,"context_line":"    * registry_client_protocol"},{"line_number":82,"context_line":"    * registry_client_key_file"},{"line_number":83,"context_line":"    * registry_client_ca_file"},{"line_number":84,"context_line":"    * registry_client_insecure"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"\"\"\")),"},{"line_number":87,"context_line":"    cfg.StrOpt(\u0027registry_client_ca_file\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_f2e9d81b","line":84,"range":{"start_line":82,"start_character":0,"end_line":84,"end_character":30},"updated":"2016-08-15 23:22:21.000000000","message":"ditto comment on lines 63-65","commit_id":"780413f030d719285f82882a9fb87b124d18196b"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"fa3e2fdbade5562517a669c8e4b9c333ba153935","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Related options:"},{"line_number":101,"context_line":"    * registry_client_protocol"},{"line_number":102,"context_line":"    * registry_client_key_file"},{"line_number":103,"context_line":"    * registry_client_cert_file"},{"line_number":104,"context_line":"    * registry_client_insecure"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"\"\"\")),"},{"line_number":107,"context_line":"    cfg.BoolOpt(\u0027registry_client_insecure\u0027, default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_d2ec9c2b","line":104,"range":{"start_line":102,"start_character":0,"end_line":104,"end_character":30},"updated":"2016-08-15 23:22:21.000000000","message":"ditto comment on lines 63-65","commit_id":"780413f030d719285f82882a9fb87b124d18196b"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"fa3e2fdbade5562517a669c8e4b9c333ba153935","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Related options:"},{"line_number":124,"context_line":"    * registry_client_protocol"},{"line_number":125,"context_line":"    * registry_client_key_file"},{"line_number":126,"context_line":"    * registry_client_cert_file"},{"line_number":127,"context_line":"    * registry_client_ca_file"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"\"\"\")),"},{"line_number":130,"context_line":"    cfg.IntOpt(\u0027registry_client_timeout\u0027, default\u003d600,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_12f754f6","line":127,"range":{"start_line":125,"start_character":0,"end_line":127,"end_character":29},"updated":"2016-08-15 23:22:21.000000000","message":"ditto comment on lines 63-65","commit_id":"780413f030d719285f82882a9fb87b124d18196b"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"8a741685e50934b2afec0596c9bd0fed0a84493e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"               help\u003d_(\"\"\""},{"line_number":52,"context_line":"Absolute path to the private key file."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Provide a string value representing a valid  absolute path to the"},{"line_number":55,"context_line":"private key file to use for establishing a secure connection to the"},{"line_number":56,"context_line":"registry server, if any."},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_fab606db","line":54,"range":{"start_line":54,"start_character":43,"end_line":54,"end_character":45},"updated":"2016-08-26 21:07:20.000000000","message":"nit: extra space","commit_id":"d3c3f10058da6ca49b93860d7ad791d48bc02240"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"b6c70550946fc10eb7de2cebfe9b2034fd62d56b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"               help\u003d_(\"\"\""},{"line_number":52,"context_line":"Absolute path to the private key file."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Provide a string value representing a valid  absolute path to the"},{"line_number":55,"context_line":"private key file to use for establishing a secure connection to the"},{"line_number":56,"context_line":"registry server, if any."},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_308c0d35","line":54,"range":{"start_line":54,"start_character":43,"end_line":54,"end_character":45},"in_reply_to":"fa7ab95a_fab606db","updated":"2016-08-26 21:41:18.000000000","message":"Done","commit_id":"d3c3f10058da6ca49b93860d7ad791d48bc02240"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"8a741685e50934b2afec0596c9bd0fed0a84493e","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Provide a string value representing a valid  absolute path to the"},{"line_number":55,"context_line":"private key file to use for establishing a secure connection to the"},{"line_number":56,"context_line":"registry server, if any."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"NOTE: This option must be set if ``registry_client_protocol`` is"},{"line_number":59,"context_line":"set to ``https``. Alternately, the GLANCE_CLIENT_KEY_FILE environment"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_3ae86eb4","line":56,"range":{"start_line":56,"start_character":17,"end_line":56,"end_character":23},"updated":"2016-08-26 21:07:20.000000000","message":"what does \"if any\" refer to here?","commit_id":"d3c3f10058da6ca49b93860d7ad791d48bc02240"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"b6c70550946fc10eb7de2cebfe9b2034fd62d56b","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Provide a string value representing a valid  absolute path to the"},{"line_number":55,"context_line":"private key file to use for establishing a secure connection to the"},{"line_number":56,"context_line":"registry server, if any."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"NOTE: This option must be set if ``registry_client_protocol`` is"},{"line_number":59,"context_line":"set to ``https``. Alternately, the GLANCE_CLIENT_KEY_FILE environment"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_50835104","line":56,"range":{"start_line":56,"start_character":17,"end_line":56,"end_character":23},"in_reply_to":"fa7ab95a_3ae86eb4","updated":"2016-08-26 21:41:18.000000000","message":"It was to tell that only if SSL is used, you will need this. \nRemoved it as in the next para we anyway say it is required for SSL connections.","commit_id":"d3c3f10058da6ca49b93860d7ad791d48bc02240"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"8a741685e50934b2afec0596c9bd0fed0a84493e","unresolved":false,"context_lines":[{"line_number":72,"context_line":"Absolute path to the certificate file."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Provide a string value representing a valid absolute path to the"},{"line_number":75,"context_line":"certificate file to use for establishing a SSL connection to the"},{"line_number":76,"context_line":"registry server, if any."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"NOTE: This option must be set if ``registry_client_protocol`` is"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_daeea2b3","line":75,"range":{"start_line":75,"start_character":43,"end_line":75,"end_character":46},"updated":"2016-08-26 21:07:20.000000000","message":"probably better to: s/SSL/secure/","commit_id":"d3c3f10058da6ca49b93860d7ad791d48bc02240"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"b6c70550946fc10eb7de2cebfe9b2034fd62d56b","unresolved":false,"context_lines":[{"line_number":72,"context_line":"Absolute path to the certificate file."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Provide a string value representing a valid absolute path to the"},{"line_number":75,"context_line":"certificate file to use for establishing a SSL connection to the"},{"line_number":76,"context_line":"registry server, if any."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"NOTE: This option must be set if ``registry_client_protocol`` is"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_907dd91e","line":75,"range":{"start_line":75,"start_character":43,"end_line":75,"end_character":46},"in_reply_to":"fa7ab95a_daeea2b3","updated":"2016-08-26 21:41:18.000000000","message":"Done","commit_id":"d3c3f10058da6ca49b93860d7ad791d48bc02240"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"8a741685e50934b2afec0596c9bd0fed0a84493e","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Provide a string value representing a valid absolute path to the"},{"line_number":75,"context_line":"certificate file to use for establishing a SSL connection to the"},{"line_number":76,"context_line":"registry server, if any."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"NOTE: This option must be set if ``registry_client_protocol`` is"},{"line_number":79,"context_line":"set to ``https``. Alternately, the GLANCE_CLIENT_CERT_FILE"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_5a10d2a8","line":76,"range":{"start_line":76,"start_character":17,"end_line":76,"end_character":23},"updated":"2016-08-26 21:07:20.000000000","message":"same question as line 56","commit_id":"d3c3f10058da6ca49b93860d7ad791d48bc02240"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"b6c70550946fc10eb7de2cebfe9b2034fd62d56b","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Provide a string value representing a valid absolute path to the"},{"line_number":75,"context_line":"certificate file to use for establishing a SSL connection to the"},{"line_number":76,"context_line":"registry server, if any."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"NOTE: This option must be set if ``registry_client_protocol`` is"},{"line_number":79,"context_line":"set to ``https``. Alternately, the GLANCE_CLIENT_CERT_FILE"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_b0781d2d","line":76,"range":{"start_line":76,"start_character":17,"end_line":76,"end_character":23},"in_reply_to":"fa7ab95a_5a10d2a8","updated":"2016-08-26 21:41:18.000000000","message":"Done","commit_id":"d3c3f10058da6ca49b93860d7ad791d48bc02240"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"8a741685e50934b2afec0596c9bd0fed0a84493e","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    cfg.StrOpt(\u0027registry_client_ca_file\u0027,"},{"line_number":91,"context_line":"               sample_default\u003d\u0027/etc/ssl/cafile/file.ca\u0027,"},{"line_number":92,"context_line":"               help\u003d_(\"\"\""},{"line_number":93,"context_line":"Absolute path to the CA file."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Provide a string value representing a valid absolute path to the"},{"line_number":96,"context_line":"certificate authority file to use for establishing a SSL connection"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_da730214","line":93,"range":{"start_line":93,"start_character":21,"end_line":93,"end_character":23},"updated":"2016-08-26 21:07:20.000000000","message":"s/CA/Certificate Authority/","commit_id":"d3c3f10058da6ca49b93860d7ad791d48bc02240"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"b6c70550946fc10eb7de2cebfe9b2034fd62d56b","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    cfg.StrOpt(\u0027registry_client_ca_file\u0027,"},{"line_number":91,"context_line":"               sample_default\u003d\u0027/etc/ssl/cafile/file.ca\u0027,"},{"line_number":92,"context_line":"               help\u003d_(\"\"\""},{"line_number":93,"context_line":"Absolute path to the CA file."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Provide a string value representing a valid absolute path to the"},{"line_number":96,"context_line":"certificate authority file to use for establishing a SSL connection"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_d0776138","line":93,"range":{"start_line":93,"start_character":21,"end_line":93,"end_character":23},"in_reply_to":"fa7ab95a_da730214","updated":"2016-08-26 21:41:18.000000000","message":"Done","commit_id":"d3c3f10058da6ca49b93860d7ad791d48bc02240"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"8a741685e50934b2afec0596c9bd0fed0a84493e","unresolved":false,"context_lines":[{"line_number":93,"context_line":"Absolute path to the CA file."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Provide a string value representing a valid absolute path to the"},{"line_number":96,"context_line":"certificate authority file to use for establishing a SSL connection"},{"line_number":97,"context_line":"to the registry server, if any."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"NOTE: This option must be set if ``registry_client_protocol`` is"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_3a5b0e89","line":96,"range":{"start_line":96,"start_character":53,"end_line":96,"end_character":56},"updated":"2016-08-26 21:07:20.000000000","message":"s/SSL/secure","commit_id":"d3c3f10058da6ca49b93860d7ad791d48bc02240"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"b6c70550946fc10eb7de2cebfe9b2034fd62d56b","unresolved":false,"context_lines":[{"line_number":93,"context_line":"Absolute path to the CA file."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Provide a string value representing a valid absolute path to the"},{"line_number":96,"context_line":"certificate authority file to use for establishing a SSL connection"},{"line_number":97,"context_line":"to the registry server, if any."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"NOTE: This option must be set if ``registry_client_protocol`` is"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_509a7164","line":96,"range":{"start_line":96,"start_character":53,"end_line":96,"end_character":56},"in_reply_to":"fa7ab95a_3a5b0e89","updated":"2016-08-26 21:41:18.000000000","message":"Done","commit_id":"d3c3f10058da6ca49b93860d7ad791d48bc02240"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"8a741685e50934b2afec0596c9bd0fed0a84493e","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Provide a string value representing a valid absolute path to the"},{"line_number":96,"context_line":"certificate authority file to use for establishing a SSL connection"},{"line_number":97,"context_line":"to the registry server, if any."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"NOTE: This option must be set if ``registry_client_protocol`` is"},{"line_number":100,"context_line":"set to ``https``. Alternately, the GLANCE_CLIENT_CA_FILE environment"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_ba4f1ebc","line":97,"range":{"start_line":97,"start_character":24,"end_line":97,"end_character":30},"updated":"2016-08-26 21:07:20.000000000","message":"same question as lines 56 \u0026 76","commit_id":"d3c3f10058da6ca49b93860d7ad791d48bc02240"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"b6c70550946fc10eb7de2cebfe9b2034fd62d56b","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Provide a string value representing a valid absolute path to the"},{"line_number":96,"context_line":"certificate authority file to use for establishing a SSL connection"},{"line_number":97,"context_line":"to the registry server, if any."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"NOTE: This option must be set if ``registry_client_protocol`` is"},{"line_number":100,"context_line":"set to ``https``. Alternately, the GLANCE_CLIENT_CA_FILE environment"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_709db558","line":97,"range":{"start_line":97,"start_character":24,"end_line":97,"end_character":30},"in_reply_to":"fa7ab95a_ba4f1ebc","updated":"2016-08-26 21:41:18.000000000","message":"Done","commit_id":"d3c3f10058da6ca49b93860d7ad791d48bc02240"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"8a741685e50934b2afec0596c9bd0fed0a84493e","unresolved":false,"context_lines":[{"line_number":116,"context_line":"Set verification of the registry server certificate."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Provide a boolean value to determine whether or not to validate"},{"line_number":119,"context_line":"SSL connections (if any) to the registry server. By default, this"},{"line_number":120,"context_line":"option is set to ``False`` and the SSL connections are validated."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"If set to ``True``, the connection to the registry server is not"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_ba82be92","line":119,"range":{"start_line":119,"start_character":16,"end_line":119,"end_character":24},"updated":"2016-08-26 21:07:20.000000000","message":"I think this can be removed.","commit_id":"d3c3f10058da6ca49b93860d7ad791d48bc02240"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"b6c70550946fc10eb7de2cebfe9b2034fd62d56b","unresolved":false,"context_lines":[{"line_number":116,"context_line":"Set verification of the registry server certificate."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Provide a boolean value to determine whether or not to validate"},{"line_number":119,"context_line":"SSL connections (if any) to the registry server. By default, this"},{"line_number":120,"context_line":"option is set to ``False`` and the SSL connections are validated."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"If set to ``True``, the connection to the registry server is not"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_90a4f9a6","line":119,"range":{"start_line":119,"start_character":16,"end_line":119,"end_character":24},"in_reply_to":"fa7ab95a_ba82be92","updated":"2016-08-26 21:41:18.000000000","message":"Done","commit_id":"d3c3f10058da6ca49b93860d7ad791d48bc02240"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"09f7672ff87d465f57b5756e63ffde5ed8e304cf","unresolved":false,"context_lines":[{"line_number":56,"context_line":"the registry server."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"NOTE: This option must be set if ``registry_client_protocol`` is"},{"line_number":59,"context_line":"set to ``https``. Alternately, the GLANCE_CLIENT_KEY_FILE environment"},{"line_number":60,"context_line":"variable may be set to a filepath of the key file."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_abc0ae7d","line":59,"range":{"start_line":59,"start_character":18,"end_line":59,"end_character":29},"updated":"2016-08-26 21:58:05.000000000","message":"s/Alternately/Alternatively/","commit_id":"e971b55ffdcb1d59e7de6fa337e7cedfc24ce5f5"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"61f874d8cf840d782471572c58cadf68df47698c","unresolved":false,"context_lines":[{"line_number":56,"context_line":"the registry server."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"NOTE: This option must be set if ``registry_client_protocol`` is"},{"line_number":59,"context_line":"set to ``https``. Alternately, the GLANCE_CLIENT_KEY_FILE environment"},{"line_number":60,"context_line":"variable may be set to a filepath of the key file."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_4be802b5","line":59,"range":{"start_line":59,"start_character":18,"end_line":59,"end_character":29},"in_reply_to":"fa7ab95a_abc0ae7d","updated":"2016-08-26 22:02:35.000000000","message":"Done","commit_id":"e971b55ffdcb1d59e7de6fa337e7cedfc24ce5f5"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"09f7672ff87d465f57b5756e63ffde5ed8e304cf","unresolved":false,"context_lines":[{"line_number":76,"context_line":"the registry server."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"NOTE: This option must be set if ``registry_client_protocol`` is"},{"line_number":79,"context_line":"set to ``https``. Alternately, the GLANCE_CLIENT_CERT_FILE"},{"line_number":80,"context_line":"environment variable may be set to a filepath of the certificate file."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_ab926e9d","line":79,"range":{"start_line":79,"start_character":18,"end_line":79,"end_character":29},"updated":"2016-08-26 21:58:05.000000000","message":"s/Alternately/Alternatively/","commit_id":"e971b55ffdcb1d59e7de6fa337e7cedfc24ce5f5"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"61f874d8cf840d782471572c58cadf68df47698c","unresolved":false,"context_lines":[{"line_number":76,"context_line":"the registry server."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"NOTE: This option must be set if ``registry_client_protocol`` is"},{"line_number":79,"context_line":"set to ``https``. Alternately, the GLANCE_CLIENT_CERT_FILE"},{"line_number":80,"context_line":"environment variable may be set to a filepath of the certificate file."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_6beb06b1","line":79,"range":{"start_line":79,"start_character":18,"end_line":79,"end_character":29},"in_reply_to":"fa7ab95a_ab926e9d","updated":"2016-08-26 22:02:35.000000000","message":"Done","commit_id":"e971b55ffdcb1d59e7de6fa337e7cedfc24ce5f5"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"09f7672ff87d465f57b5756e63ffde5ed8e304cf","unresolved":false,"context_lines":[{"line_number":97,"context_line":"connection to the registry server."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"NOTE: This option must be set if ``registry_client_protocol`` is"},{"line_number":100,"context_line":"set to ``https``. Alternately, the GLANCE_CLIENT_CA_FILE environment"},{"line_number":101,"context_line":"variable may be set to a filepath of the CA file."},{"line_number":102,"context_line":"This option is ignored if the ``registry_client_insecure`` option is"},{"line_number":103,"context_line":"set to ``True``."}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_cb91729b","line":100,"range":{"start_line":100,"start_character":18,"end_line":100,"end_character":29},"updated":"2016-08-26 21:58:05.000000000","message":"s/Alternately/Alternatively/","commit_id":"e971b55ffdcb1d59e7de6fa337e7cedfc24ce5f5"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"61f874d8cf840d782471572c58cadf68df47698c","unresolved":false,"context_lines":[{"line_number":97,"context_line":"connection to the registry server."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"NOTE: This option must be set if ``registry_client_protocol`` is"},{"line_number":100,"context_line":"set to ``https``. Alternately, the GLANCE_CLIENT_CA_FILE environment"},{"line_number":101,"context_line":"variable may be set to a filepath of the CA file."},{"line_number":102,"context_line":"This option is ignored if the ``registry_client_insecure`` option is"},{"line_number":103,"context_line":"set to ``True``."}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_cbdc1215","line":100,"range":{"start_line":100,"start_character":18,"end_line":100,"end_character":29},"in_reply_to":"fa7ab95a_cb91729b","updated":"2016-08-26 22:02:35.000000000","message":"Done","commit_id":"e971b55ffdcb1d59e7de6fa337e7cedfc24ce5f5"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"843c9ce0dbd6b4514d7f2c7d0c43731f8552ed6e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"Protocol to use for communication with the registry server."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Provide a string value representing the protocol to use for"},{"line_number":29,"context_line":"communication with the registry server. By default, this option is"},{"line_number":30,"context_line":"set to ``http` and the connection is not secure."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"This option can be set to ``https`` to establish a secure connection"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa7ab95a_224038a5","line":29,"updated":"2016-08-27 04:05:06.000000000","message":"I will ask I asked the question on Brian\u0027s patch, is there a particular reason why the word wrap is way below 80?","commit_id":"a74bc943af24ad13bc036b14c8645a915ffa9301"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"c8b0ab4d912998ea6d84ab396de4cf672554cdde","unresolved":false,"context_lines":[{"line_number":26,"context_line":"Protocol to use for communication with the registry server."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Provide a string value representing the protocol to use for"},{"line_number":29,"context_line":"communication with the registry server. By default, this option is"},{"line_number":30,"context_line":"set to ``http` and the connection is not secure."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"This option can be set to ``https`` to establish a secure connection"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa7ab95a_76eafc10","line":29,"in_reply_to":"fa7ab95a_224038a5","updated":"2016-08-27 18:37:03.000000000","message":"Nikhil, Oslo\u0027s config generator wraps lines at 70 chars and so it results in formatting issues. So we make sure to have the wrap at 70 too for help texts.\nhttps://github.com/openstack/oslo.config/blob/master/oslo_config/generator.py#L136\n\nHemanth had proposed a change with respect to this: https://review.openstack.org/#/c/343887/","commit_id":"a74bc943af24ad13bc036b14c8645a915ffa9301"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"ac92266a0b217b8c117d81954d5b9772f5dd730d","unresolved":false,"context_lines":[{"line_number":56,"context_line":"the registry server."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"NOTE: This option must be set if ``registry_client_protocol`` is"},{"line_number":59,"context_line":"set to ``https``. Alternatively, the GLANCE_CLIENT_KEY_FILE environment"},{"line_number":60,"context_line":"variable may be set to a filepath of the key file."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa7ab95a_095dc678","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":71},"updated":"2016-08-29 21:10:04.000000000","message":"This line will break the formatting as well.","commit_id":"a74bc943af24ad13bc036b14c8645a915ffa9301"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"31b2d927d344f6dd651103b862823d93b39e5db0","unresolved":false,"context_lines":[{"line_number":56,"context_line":"the registry server."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"NOTE: This option must be set if ``registry_client_protocol`` is"},{"line_number":59,"context_line":"set to ``https``. Alternatively, the GLANCE_CLIENT_KEY_FILE environment"},{"line_number":60,"context_line":"variable may be set to a filepath of the key file."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa7ab95a_ff593436","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":71},"in_reply_to":"fa7ab95a_095dc678","updated":"2016-08-29 21:23:36.000000000","message":"Done","commit_id":"a74bc943af24ad13bc036b14c8645a915ffa9301"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"ac92266a0b217b8c117d81954d5b9772f5dd730d","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"\"\"\")),"},{"line_number":137,"context_line":"    cfg.IntOpt(\u0027registry_client_timeout\u0027,"},{"line_number":138,"context_line":"               default\u003d600,"},{"line_number":139,"context_line":"               help\u003d_(\"\"\""},{"line_number":140,"context_line":"Timeout value for registry requests."},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa7ab95a_a4895f28","line":138,"updated":"2016-08-29 21:10:04.000000000","message":"min\u003d0 since this can be set to zero?","commit_id":"a74bc943af24ad13bc036b14c8645a915ffa9301"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"31b2d927d344f6dd651103b862823d93b39e5db0","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"\"\"\")),"},{"line_number":137,"context_line":"    cfg.IntOpt(\u0027registry_client_timeout\u0027,"},{"line_number":138,"context_line":"               default\u003d600,"},{"line_number":139,"context_line":"               help\u003d_(\"\"\""},{"line_number":140,"context_line":"Timeout value for registry requests."},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa7ab95a_df5470ff","line":138,"in_reply_to":"fa7ab95a_a4895f28","updated":"2016-08-29 21:23:36.000000000","message":"Done","commit_id":"a74bc943af24ad13bc036b14c8645a915ffa9301"}]}