)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"8f7da0a32031e354121d315a4c7d6385723bc0dd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dharini Chandrasekar \u003cdharini.chandrasekar@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-25 15:09:57 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improving help text for proprty utils opts."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding improved help text for property_protection_file and"},{"line_number":10,"context_line":"property_protection_rule_format"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dada55a8_81290e8c","line":7,"range":{"start_line":7,"start_character":24,"end_line":7,"end_character":37},"updated":"2016-07-25 15:34:04.000000000","message":"Let\u0027s call these property protection opts","commit_id":"562bf81b23f45779a1d8bef5e95569e986541a43"}],"glance/common/property_utils.py":[{"author":{"_account_id":19845,"name":"Anush Krishnamurthy","email":"anush.krishnamurthy@intel.com","username":"akrish9"},"change_message_id":"23822be63af5d412a8a0f879dcfd749916910de4","unresolved":false,"context_lines":[{"line_number":52,"context_line":"               default\u003d\u0027roles\u0027,"},{"line_number":53,"context_line":"               choices\u003d(\u0027roles\u0027, \u0027policies\u0027),"},{"line_number":54,"context_line":"               help\u003d_(\"\"\""},{"line_number":55,"context_line":"Rule type to define property protection."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Provide the desired way you want to set property protection on"},{"line_number":58,"context_line":"Glance meta image properties. The two permissable values are"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_8dbe66fd","line":55,"updated":"2016-07-25 13:59:28.000000000","message":"Could it be reformatted as: \"Rule format choice for property protection\"","commit_id":"c3d7e37d9a07c9a9b9facab093b2eba5e5e4c9ab"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"0e87ad5b6c4a80d73a417cc21fcd686e8d52488c","unresolved":false,"context_lines":[{"line_number":52,"context_line":"               default\u003d\u0027roles\u0027,"},{"line_number":53,"context_line":"               choices\u003d(\u0027roles\u0027, \u0027policies\u0027),"},{"line_number":54,"context_line":"               help\u003d_(\"\"\""},{"line_number":55,"context_line":"Rule type to define property protection."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Provide the desired way you want to set property protection on"},{"line_number":58,"context_line":"Glance meta image properties. The two permissable values are"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_d60c6e96","line":55,"in_reply_to":"dada55a8_8dbe66fd","updated":"2016-07-25 15:11:32.000000000","message":"Done","commit_id":"c3d7e37d9a07c9a9b9facab093b2eba5e5e4c9ab"},{"author":{"_account_id":19845,"name":"Anush Krishnamurthy","email":"anush.krishnamurthy@intel.com","username":"akrish9"},"change_message_id":"23822be63af5d412a8a0f879dcfd749916910de4","unresolved":false,"context_lines":[{"line_number":62,"context_line":"operations for the property being protected in the property"},{"line_number":63,"context_line":"protection file. If set to ``policies``, a policy defined in"},{"line_number":64,"context_line":"policy.json is added for each of the CRUD operations. The default"},{"line_number":65,"context_line":"for property_protection_rule_format is roles."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Possible values:"},{"line_number":68,"context_line":"    * roles"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_f2ad439c","line":65,"updated":"2016-07-25 13:59:28.000000000","message":"Double entry: \"The default for....\" Please remove it here.","commit_id":"c3d7e37d9a07c9a9b9facab093b2eba5e5e4c9ab"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"0e87ad5b6c4a80d73a417cc21fcd686e8d52488c","unresolved":false,"context_lines":[{"line_number":62,"context_line":"operations for the property being protected in the property"},{"line_number":63,"context_line":"protection file. If set to ``policies``, a policy defined in"},{"line_number":64,"context_line":"policy.json is added for each of the CRUD operations. The default"},{"line_number":65,"context_line":"for property_protection_rule_format is roles."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Possible values:"},{"line_number":68,"context_line":"    * roles"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_b60f3a87","line":65,"in_reply_to":"dada55a8_f2ad439c","updated":"2016-07-25 15:11:32.000000000","message":"Done","commit_id":"c3d7e37d9a07c9a9b9facab093b2eba5e5e4c9ab"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"8f7da0a32031e354121d315a4c7d6385723bc0dd","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Provide a valid path to the property protection file which contains"},{"line_number":35,"context_line":"the rules for property protections and the roles/policies associated"},{"line_number":36,"context_line":"with it. A property protection file is added to restrict the Glance"},{"line_number":37,"context_line":"meta image properties to certain set of users identified by either"},{"line_number":38,"context_line":"roles or policies. If this configuration option is not configured,"},{"line_number":39,"context_line":"by default, property protections won\u0027t be enforced. If a value is"},{"line_number":40,"context_line":"specified and the file is not found, the glance-api service will"},{"line_number":41,"context_line":"fail to start."}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_21a4a2a4","line":38,"range":{"start_line":36,"start_character":9,"end_line":38,"end_character":18},"updated":"2016-07-25 15:34:04.000000000","message":"Good idea to add this. How about we include the following link for more information on property protections and this sentence?\ndocs.openstack.org/developer/glance/property-protections.html","commit_id":"562bf81b23f45779a1d8bef5e95569e986541a43"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"8f7da0a32031e354121d315a4c7d6385723bc0dd","unresolved":false,"context_lines":[{"line_number":35,"context_line":"the rules for property protections and the roles/policies associated"},{"line_number":36,"context_line":"with it. A property protection file is added to restrict the Glance"},{"line_number":37,"context_line":"meta image properties to certain set of users identified by either"},{"line_number":38,"context_line":"roles or policies. If this configuration option is not configured,"},{"line_number":39,"context_line":"by default, property protections won\u0027t be enforced. If a value is"},{"line_number":40,"context_line":"specified and the file is not found, the glance-api service will"},{"line_number":41,"context_line":"fail to start."}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_41a9d67a","line":38,"range":{"start_line":38,"start_character":55,"end_line":38,"end_character":65},"updated":"2016-07-25 15:34:04.000000000","message":"set","commit_id":"562bf81b23f45779a1d8bef5e95569e986541a43"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"8f7da0a32031e354121d315a4c7d6385723bc0dd","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Possible values:"},{"line_number":44,"context_line":"    * Empty string"},{"line_number":45,"context_line":"    * Valid path to the property protection conf file"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Related options:"},{"line_number":48,"context_line":"    * property_protection_rule_format"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_c1f666f8","line":45,"range":{"start_line":45,"start_character":44,"end_line":45,"end_character":48},"updated":"2016-07-25 15:34:04.000000000","message":"configuration","commit_id":"562bf81b23f45779a1d8bef5e95569e986541a43"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"8f7da0a32031e354121d315a4c7d6385723bc0dd","unresolved":false,"context_lines":[{"line_number":52,"context_line":"               default\u003d\u0027roles\u0027,"},{"line_number":53,"context_line":"               choices\u003d(\u0027roles\u0027, \u0027policies\u0027),"},{"line_number":54,"context_line":"               help\u003d_(\"\"\""},{"line_number":55,"context_line":"Rule format choice for property protection."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Provide the desired way you want to set property protection on"},{"line_number":58,"context_line":"Glance meta image properties. The two permissable values are"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_81858e5a","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":42},"updated":"2016-07-25 15:34:04.000000000","message":"Rule format for property protections.","commit_id":"562bf81b23f45779a1d8bef5e95569e986541a43"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"8f7da0a32031e354121d315a4c7d6385723bc0dd","unresolved":false,"context_lines":[{"line_number":55,"context_line":"Rule format choice for property protection."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Provide the desired way you want to set property protection on"},{"line_number":58,"context_line":"Glance meta image properties. The two permissable values are"},{"line_number":59,"context_line":"``roles`` and ``policies``. The default value for"},{"line_number":60,"context_line":"property_protection_rule_format is roles. if the value is ``roles``,"},{"line_number":61,"context_line":"a comma seperated list of user roles is added for each of the CRUD"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_21dca2e3","line":58,"range":{"start_line":58,"start_character":7,"end_line":58,"end_character":28},"updated":"2016-07-25 15:34:04.000000000","message":"Let\u0027s call this either Image metadata or image properties. I\u0027d suggest this:\n\"Provide the desired way to enforce protections on Glance image properties.\"","commit_id":"562bf81b23f45779a1d8bef5e95569e986541a43"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"8f7da0a32031e354121d315a4c7d6385723bc0dd","unresolved":false,"context_lines":[{"line_number":57,"context_line":"Provide the desired way you want to set property protection on"},{"line_number":58,"context_line":"Glance meta image properties. The two permissable values are"},{"line_number":59,"context_line":"``roles`` and ``policies``. The default value for"},{"line_number":60,"context_line":"property_protection_rule_format is roles. if the value is ``roles``,"},{"line_number":61,"context_line":"a comma seperated list of user roles is added for each of the CRUD"},{"line_number":62,"context_line":"operations for the property being protected in the property"},{"line_number":63,"context_line":"protection file. If set to ``policies``, a policy defined in"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_616dfa97","line":60,"range":{"start_line":60,"start_character":42,"end_line":60,"end_character":44},"updated":"2016-07-25 15:34:04.000000000","message":"If","commit_id":"562bf81b23f45779a1d8bef5e95569e986541a43"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"8f7da0a32031e354121d315a4c7d6385723bc0dd","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Provide the desired way you want to set property protection on"},{"line_number":58,"context_line":"Glance meta image properties. The two permissable values are"},{"line_number":59,"context_line":"``roles`` and ``policies``. The default value for"},{"line_number":60,"context_line":"property_protection_rule_format is roles. if the value is ``roles``,"},{"line_number":61,"context_line":"a comma seperated list of user roles is added for each of the CRUD"},{"line_number":62,"context_line":"operations for the property being protected in the property"},{"line_number":63,"context_line":"protection file. If set to ``policies``, a policy defined in"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_01acfe33","line":60,"range":{"start_line":59,"start_character":46,"end_line":60,"end_character":31},"updated":"2016-07-25 15:34:04.000000000","message":"We can drop this.","commit_id":"562bf81b23f45779a1d8bef5e95569e986541a43"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"8f7da0a32031e354121d315a4c7d6385723bc0dd","unresolved":false,"context_lines":[{"line_number":57,"context_line":"Provide the desired way you want to set property protection on"},{"line_number":58,"context_line":"Glance meta image properties. The two permissable values are"},{"line_number":59,"context_line":"``roles`` and ``policies``. The default value for"},{"line_number":60,"context_line":"property_protection_rule_format is roles. if the value is ``roles``,"},{"line_number":61,"context_line":"a comma seperated list of user roles is added for each of the CRUD"},{"line_number":62,"context_line":"operations for the property being protected in the property"},{"line_number":63,"context_line":"protection file. If set to ``policies``, a policy defined in"},{"line_number":64,"context_line":"policy.json is added for each of the CRUD operations."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Possible values:"},{"line_number":67,"context_line":"    * roles"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_bccd59b9","line":64,"range":{"start_line":60,"start_character":42,"end_line":64,"end_character":53},"updated":"2016-07-25 15:34:04.000000000","message":"Be it \"roles\" or \"policies\", we don\u0027t really \"add\" them to CRUD operations. The protection rules, which could either be expressed in terms of roles or policies, are provided by the user. This just describes what the protections are expressed as.\n\nLet me know if I made sense.","commit_id":"562bf81b23f45779a1d8bef5e95569e986541a43"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"e9b05c0726c68bc769cb7bdeb1bedfd940be1b23","unresolved":false,"context_lines":[{"line_number":57,"context_line":"Provide the desired way you want to set property protection on"},{"line_number":58,"context_line":"Glance meta image properties. The two permissable values are"},{"line_number":59,"context_line":"``roles`` and ``policies``. The default value for"},{"line_number":60,"context_line":"property_protection_rule_format is roles. if the value is ``roles``,"},{"line_number":61,"context_line":"a comma seperated list of user roles is added for each of the CRUD"},{"line_number":62,"context_line":"operations for the property being protected in the property"},{"line_number":63,"context_line":"protection file. If set to ``policies``, a policy defined in"},{"line_number":64,"context_line":"policy.json is added for each of the CRUD operations."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Possible values:"},{"line_number":67,"context_line":"    * roles"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_00c50f8d","line":64,"range":{"start_line":60,"start_character":42,"end_line":64,"end_character":53},"in_reply_to":"dada55a8_bccd59b9","updated":"2016-07-25 18:05:22.000000000","message":"So based on the value chosen for this configuration option, a \"list of roles\" or a \"policy\" is given for each of the CRUD operation right? \nhttp://docs.openstack.org/developer/glance/property-protections.html#examples\nHowever, adding the role or policy is not directly related to this config option.","commit_id":"562bf81b23f45779a1d8bef5e95569e986541a43"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"8f7da0a32031e354121d315a4c7d6385723bc0dd","unresolved":false,"context_lines":[{"line_number":62,"context_line":"operations for the property being protected in the property"},{"line_number":63,"context_line":"protection file. If set to ``policies``, a policy defined in"},{"line_number":64,"context_line":"policy.json is added for each of the CRUD operations."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Possible values:"},{"line_number":67,"context_line":"    * roles"},{"line_number":68,"context_line":"    * policies"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_811bce7f","line":65,"updated":"2016-07-25 15:34:04.000000000","message":"Let\u0027s include the above URL here for more information on property protections.","commit_id":"562bf81b23f45779a1d8bef5e95569e986541a43"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"40e87c8699df3b127e6efa906888f66de2c60c1a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"the rules for property protections and the roles/policies associated"},{"line_number":36,"context_line":"with it."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"A property protection file is added to restrict the Glance"},{"line_number":39,"context_line":"image properties to certain set of users identified by either roles"},{"line_number":40,"context_line":"or policies. More information on property protections can be found"},{"line_number":41,"context_line":"at: http://docs.openstack.org/developer/glance/property-protections.html"},{"line_number":42,"context_line":"If this configuration option is not configured, by default, property"},{"line_number":43,"context_line":"protections won\u0027t be enforced. If a value is specified and the file"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_57f02afd","line":40,"range":{"start_line":38,"start_character":0,"end_line":40,"end_character":12},"updated":"2016-07-26 20:23:16.000000000","message":"How about the following?\n\"A property protection file, when set, restricts the Glance\nimage properties to be created, read, updated and/or deleted by a specific set of users that are identified by either roles\nor policies.\"","commit_id":"622f174da7e97175efe90fe50b4e88fa6a536173"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"898af72e0d7faf20c4cc22a6588c52bda7108036","unresolved":false,"context_lines":[{"line_number":35,"context_line":"the rules for property protections and the roles/policies associated"},{"line_number":36,"context_line":"with it."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"A property protection file is added to restrict the Glance"},{"line_number":39,"context_line":"image properties to certain set of users identified by either roles"},{"line_number":40,"context_line":"or policies. More information on property protections can be found"},{"line_number":41,"context_line":"at: http://docs.openstack.org/developer/glance/property-protections.html"},{"line_number":42,"context_line":"If this configuration option is not configured, by default, property"},{"line_number":43,"context_line":"protections won\u0027t be enforced. If a value is specified and the file"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_72e57c07","line":40,"range":{"start_line":38,"start_character":0,"end_line":40,"end_character":12},"in_reply_to":"dada55a8_57f02afd","updated":"2016-07-26 20:39:25.000000000","message":"Done","commit_id":"622f174da7e97175efe90fe50b4e88fa6a536173"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"40e87c8699df3b127e6efa906888f66de2c60c1a","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"A property protection file is added to restrict the Glance"},{"line_number":39,"context_line":"image properties to certain set of users identified by either roles"},{"line_number":40,"context_line":"or policies. More information on property protections can be found"},{"line_number":41,"context_line":"at: http://docs.openstack.org/developer/glance/property-protections.html"},{"line_number":42,"context_line":"If this configuration option is not configured, by default, property"},{"line_number":43,"context_line":"protections won\u0027t be enforced. If a value is specified and the file"},{"line_number":44,"context_line":"is not found, the glance-api service will fail to start."}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_a3dccce4","line":41,"range":{"start_line":40,"start_character":13,"end_line":41,"end_character":72},"updated":"2016-07-26 20:23:16.000000000","message":"Let\u0027s move this towards the end of this paragraph.","commit_id":"622f174da7e97175efe90fe50b4e88fa6a536173"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"898af72e0d7faf20c4cc22a6588c52bda7108036","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"A property protection file is added to restrict the Glance"},{"line_number":39,"context_line":"image properties to certain set of users identified by either roles"},{"line_number":40,"context_line":"or policies. More information on property protections can be found"},{"line_number":41,"context_line":"at: http://docs.openstack.org/developer/glance/property-protections.html"},{"line_number":42,"context_line":"If this configuration option is not configured, by default, property"},{"line_number":43,"context_line":"protections won\u0027t be enforced. If a value is specified and the file"},{"line_number":44,"context_line":"is not found, the glance-api service will fail to start."}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_d2eee8eb","line":41,"range":{"start_line":40,"start_character":13,"end_line":41,"end_character":72},"in_reply_to":"dada55a8_a3dccce4","updated":"2016-07-26 20:39:25.000000000","message":"Done","commit_id":"622f174da7e97175efe90fe50b4e88fa6a536173"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"40e87c8699df3b127e6efa906888f66de2c60c1a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"image properties to certain set of users identified by either roles"},{"line_number":40,"context_line":"or policies. More information on property protections can be found"},{"line_number":41,"context_line":"at: http://docs.openstack.org/developer/glance/property-protections.html"},{"line_number":42,"context_line":"If this configuration option is not configured, by default, property"},{"line_number":43,"context_line":"protections won\u0027t be enforced. If a value is specified and the file"},{"line_number":44,"context_line":"is not found, the glance-api service will fail to start."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_97de226b","line":42,"range":{"start_line":42,"start_character":36,"end_line":42,"end_character":46},"updated":"2016-07-26 20:23:16.000000000","message":"set","commit_id":"622f174da7e97175efe90fe50b4e88fa6a536173"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"898af72e0d7faf20c4cc22a6588c52bda7108036","unresolved":false,"context_lines":[{"line_number":39,"context_line":"image properties to certain set of users identified by either roles"},{"line_number":40,"context_line":"or policies. More information on property protections can be found"},{"line_number":41,"context_line":"at: http://docs.openstack.org/developer/glance/property-protections.html"},{"line_number":42,"context_line":"If this configuration option is not configured, by default, property"},{"line_number":43,"context_line":"protections won\u0027t be enforced. If a value is specified and the file"},{"line_number":44,"context_line":"is not found, the glance-api service will fail to start."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_b2eb74db","line":42,"range":{"start_line":42,"start_character":36,"end_line":42,"end_character":46},"in_reply_to":"dada55a8_97de226b","updated":"2016-07-26 20:39:25.000000000","message":"Done","commit_id":"622f174da7e97175efe90fe50b4e88fa6a536173"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"40e87c8699df3b127e6efa906888f66de2c60c1a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    * Valid path to the property protection configuration file"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Related options:"},{"line_number":51,"context_line":"    * None"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"\"\"\")),"},{"line_number":54,"context_line":"    cfg.StrOpt(\u0027property_protection_rule_format\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_8c8735b4","line":51,"range":{"start_line":51,"start_character":6,"end_line":51,"end_character":10},"updated":"2016-07-26 20:23:16.000000000","message":"Let\u0027s retain the related option","commit_id":"622f174da7e97175efe90fe50b4e88fa6a536173"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"40e87c8699df3b127e6efa906888f66de2c60c1a","unresolved":false,"context_lines":[{"line_number":57,"context_line":"               help\u003d_(\"\"\""},{"line_number":58,"context_line":"Rule format for property protection."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Provide the desired way you want to set property protection on"},{"line_number":61,"context_line":"Glance image properties. The two permissable values are ``roles``"},{"line_number":62,"context_line":"and ``policies``. The default value is roles."},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_77e56e07","line":60,"range":{"start_line":60,"start_character":24,"end_line":60,"end_character":32},"updated":"2016-07-26 20:23:16.000000000","message":"Let\u0027s drop this.","commit_id":"622f174da7e97175efe90fe50b4e88fa6a536173"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"898af72e0d7faf20c4cc22a6588c52bda7108036","unresolved":false,"context_lines":[{"line_number":57,"context_line":"               help\u003d_(\"\"\""},{"line_number":58,"context_line":"Rule format for property protection."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Provide the desired way you want to set property protection on"},{"line_number":61,"context_line":"Glance image properties. The two permissable values are ``roles``"},{"line_number":62,"context_line":"and ``policies``. The default value is roles."},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_f2bfaccd","line":60,"range":{"start_line":60,"start_character":24,"end_line":60,"end_character":32},"in_reply_to":"dada55a8_77e56e07","updated":"2016-07-26 20:39:25.000000000","message":"Done","commit_id":"622f174da7e97175efe90fe50b4e88fa6a536173"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"40e87c8699df3b127e6efa906888f66de2c60c1a","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Provide the desired way you want to set property protection on"},{"line_number":61,"context_line":"Glance image properties. The two permissable values are ``roles``"},{"line_number":62,"context_line":"and ``policies``. The default value is roles."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"If the value is ``roles``, the property protection file is to"},{"line_number":65,"context_line":"contain a comma seperated list of user roles indicating"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_17899226","line":62,"range":{"start_line":62,"start_character":39,"end_line":62,"end_character":44},"updated":"2016-07-26 20:23:16.000000000","message":"quotes around roles?","commit_id":"622f174da7e97175efe90fe50b4e88fa6a536173"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"898af72e0d7faf20c4cc22a6588c52bda7108036","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Provide the desired way you want to set property protection on"},{"line_number":61,"context_line":"Glance image properties. The two permissable values are ``roles``"},{"line_number":62,"context_line":"and ``policies``. The default value is roles."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"If the value is ``roles``, the property protection file is to"},{"line_number":65,"context_line":"contain a comma seperated list of user roles indicating"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_52b15800","line":62,"range":{"start_line":62,"start_character":39,"end_line":62,"end_character":44},"in_reply_to":"dada55a8_17899226","updated":"2016-07-26 20:39:25.000000000","message":"Done","commit_id":"622f174da7e97175efe90fe50b4e88fa6a536173"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"40e87c8699df3b127e6efa906888f66de2c60c1a","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"If the value is ``roles``, the property protection file is to"},{"line_number":65,"context_line":"contain a comma seperated list of user roles indicating"},{"line_number":66,"context_line":"permissions for each of the CRUD operations on the property"},{"line_number":67,"context_line":"being protected. If set to ``policies``, a policy defined in"},{"line_number":68,"context_line":"policy.json is added for each of the CRUD operations."},{"line_number":69,"context_line":"Examples of how property protections are enforced based on"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_b7d526e6","line":66,"range":{"start_line":66,"start_character":51,"end_line":66,"end_character":59},"updated":"2016-07-26 20:23:16.000000000","message":"property/properties","commit_id":"622f174da7e97175efe90fe50b4e88fa6a536173"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"898af72e0d7faf20c4cc22a6588c52bda7108036","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"If the value is ``roles``, the property protection file is to"},{"line_number":65,"context_line":"contain a comma seperated list of user roles indicating"},{"line_number":66,"context_line":"permissions for each of the CRUD operations on the property"},{"line_number":67,"context_line":"being protected. If set to ``policies``, a policy defined in"},{"line_number":68,"context_line":"policy.json is added for each of the CRUD operations."},{"line_number":69,"context_line":"Examples of how property protections are enforced based on"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_92cf507e","line":66,"range":{"start_line":66,"start_character":51,"end_line":66,"end_character":59},"in_reply_to":"dada55a8_b7d526e6","updated":"2016-07-26 20:39:25.000000000","message":"Done","commit_id":"622f174da7e97175efe90fe50b4e88fa6a536173"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"40e87c8699df3b127e6efa906888f66de2c60c1a","unresolved":false,"context_lines":[{"line_number":65,"context_line":"contain a comma seperated list of user roles indicating"},{"line_number":66,"context_line":"permissions for each of the CRUD operations on the property"},{"line_number":67,"context_line":"being protected. If set to ``policies``, a policy defined in"},{"line_number":68,"context_line":"policy.json is added for each of the CRUD operations."},{"line_number":69,"context_line":"Examples of how property protections are enforced based on"},{"line_number":70,"context_line":"``roles`` or ``policies`` can be found at:"},{"line_number":71,"context_line":"http://docs.openstack.org/developer/glance/property-protections.html#examples"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_97558251","line":68,"range":{"start_line":68,"start_character":15,"end_line":68,"end_character":20},"updated":"2016-07-26 20:23:16.000000000","message":"used to express property protections","commit_id":"622f174da7e97175efe90fe50b4e88fa6a536173"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"898af72e0d7faf20c4cc22a6588c52bda7108036","unresolved":false,"context_lines":[{"line_number":65,"context_line":"contain a comma seperated list of user roles indicating"},{"line_number":66,"context_line":"permissions for each of the CRUD operations on the property"},{"line_number":67,"context_line":"being protected. If set to ``policies``, a policy defined in"},{"line_number":68,"context_line":"policy.json is added for each of the CRUD operations."},{"line_number":69,"context_line":"Examples of how property protections are enforced based on"},{"line_number":70,"context_line":"``roles`` or ``policies`` can be found at:"},{"line_number":71,"context_line":"http://docs.openstack.org/developer/glance/property-protections.html#examples"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_72cc5c89","line":68,"range":{"start_line":68,"start_character":15,"end_line":68,"end_character":20},"in_reply_to":"dada55a8_97558251","updated":"2016-07-26 20:39:25.000000000","message":"Done","commit_id":"622f174da7e97175efe90fe50b4e88fa6a536173"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"40e87c8699df3b127e6efa906888f66de2c60c1a","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    * policies"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Related options:"},{"line_number":78,"context_line":"    * None"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"\"\"\")),"},{"line_number":81,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_ac8af9bc","line":78,"range":{"start_line":78,"start_character":6,"end_line":78,"end_character":10},"updated":"2016-07-26 20:23:16.000000000","message":"Let\u0027s retain the related option","commit_id":"622f174da7e97175efe90fe50b4e88fa6a536173"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"bfabe59e57be824cb809ca49e417aa496db42ef8","unresolved":false,"context_lines":[{"line_number":59,"context_line":"Rule format for property protection."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Provide the desired way to set property protection on Glance"},{"line_number":62,"context_line":"image properties. The two permissable values are ``roles``"},{"line_number":63,"context_line":"and ``policies``. The default value is ``roles``."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"If the value is ``roles``, the property protection file is to"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_5d3cdbc7","line":62,"range":{"start_line":62,"start_character":26,"end_line":62,"end_character":37},"updated":"2016-07-30 23:18:38.000000000","message":"Small typo: \u0027permissible\u0027","commit_id":"01faaf7996bbea866b2bb1515a61410fe7d9efba"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"9299b4bb37d9f4ed138ba6f10a4a42b5f8a6dd87","unresolved":false,"context_lines":[{"line_number":59,"context_line":"Rule format for property protection."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Provide the desired way to set property protection on Glance"},{"line_number":62,"context_line":"image properties. The two permissable values are ``roles``"},{"line_number":63,"context_line":"and ``policies``. The default value is ``roles``."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"If the value is ``roles``, the property protection file is to"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_60fc6f3e","line":62,"range":{"start_line":62,"start_character":26,"end_line":62,"end_character":37},"in_reply_to":"bacf61ea_5d3cdbc7","updated":"2016-08-01 14:20:37.000000000","message":"+1","commit_id":"01faaf7996bbea866b2bb1515a61410fe7d9efba"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"bfabe59e57be824cb809ca49e417aa496db42ef8","unresolved":false,"context_lines":[{"line_number":63,"context_line":"and ``policies``. The default value is ``roles``."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"If the value is ``roles``, the property protection file is to"},{"line_number":66,"context_line":"contain a comma seperated list of user roles indicating"},{"line_number":67,"context_line":"permissions for each of the CRUD operations on the"},{"line_number":68,"context_line":"property/properties being protected. If set to ``policies``,"},{"line_number":69,"context_line":"a policy defined in policy.json is used to express property"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_3d3927d8","line":66,"range":{"start_line":66,"start_character":16,"end_line":66,"end_character":25},"updated":"2016-07-30 23:18:38.000000000","message":"Small typo: \u0027separated\u0027","commit_id":"01faaf7996bbea866b2bb1515a61410fe7d9efba"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"9299b4bb37d9f4ed138ba6f10a4a42b5f8a6dd87","unresolved":false,"context_lines":[{"line_number":63,"context_line":"and ``policies``. The default value is ``roles``."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"If the value is ``roles``, the property protection file is to"},{"line_number":66,"context_line":"contain a comma seperated list of user roles indicating"},{"line_number":67,"context_line":"permissions for each of the CRUD operations on the"},{"line_number":68,"context_line":"property/properties being protected. If set to ``policies``,"},{"line_number":69,"context_line":"a policy defined in policy.json is used to express property"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_208d57d6","line":66,"range":{"start_line":66,"start_character":16,"end_line":66,"end_character":25},"in_reply_to":"bacf61ea_3d3927d8","updated":"2016-08-01 14:20:37.000000000","message":"+1","commit_id":"01faaf7996bbea866b2bb1515a61410fe7d9efba"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3d563543153300f56c0e1c7bf252cc1fd5241cd3","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Provide a valid path to the property protection file which contains"},{"line_number":35,"context_line":"the rules for property protections and the roles/policies associated"},{"line_number":36,"context_line":"with it."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"A property protection file, when set, restricts the Glance image"},{"line_number":39,"context_line":"properties to be created, read, updated and/or deleted by a specific"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_728b931f","line":36,"range":{"start_line":36,"start_character":5,"end_line":36,"end_character":7},"updated":"2016-08-01 19:04:39.000000000","message":"grammar nit: \"it\" here refers back to file, whereas you are talking about the rules, so this should be \"them\".","commit_id":"1e52f02ff321bb51c067f43ab37d940fb2d1c267"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"283ae1506a6ba905394066ca3d7524074588c444","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Provide a valid path to the property protection file which contains"},{"line_number":35,"context_line":"the rules for property protections and the roles/policies associated"},{"line_number":36,"context_line":"with it."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"A property protection file, when set, restricts the Glance image"},{"line_number":39,"context_line":"properties to be created, read, updated and/or deleted by a specific"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_038e4bcf","line":36,"range":{"start_line":36,"start_character":5,"end_line":36,"end_character":7},"in_reply_to":"bacf61ea_728b931f","updated":"2016-08-01 20:25:01.000000000","message":"Done","commit_id":"1e52f02ff321bb51c067f43ab37d940fb2d1c267"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3d563543153300f56c0e1c7bf252cc1fd5241cd3","unresolved":false,"context_lines":[{"line_number":62,"context_line":"image properties. The two permissible values are ``roles``"},{"line_number":63,"context_line":"and ``policies``. The default value is ``roles``."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"If the value is ``roles``, the property protection file is to"},{"line_number":66,"context_line":"contain a comma separated list of user roles indicating"},{"line_number":67,"context_line":"permissions for each of the CRUD operations on the"},{"line_number":68,"context_line":"property/properties being protected. If set to ``policies``,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_d2c87f57","line":65,"range":{"start_line":65,"start_character":56,"end_line":65,"end_character":61},"updated":"2016-08-01 19:04:39.000000000","message":"I\u0027d suggest changing \"is to\" to \"must\".","commit_id":"1e52f02ff321bb51c067f43ab37d940fb2d1c267"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"283ae1506a6ba905394066ca3d7524074588c444","unresolved":false,"context_lines":[{"line_number":62,"context_line":"image properties. The two permissible values are ``roles``"},{"line_number":63,"context_line":"and ``policies``. The default value is ``roles``."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"If the value is ``roles``, the property protection file is to"},{"line_number":66,"context_line":"contain a comma separated list of user roles indicating"},{"line_number":67,"context_line":"permissions for each of the CRUD operations on the"},{"line_number":68,"context_line":"property/properties being protected. If set to ``policies``,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_a3b5bf7e","line":65,"range":{"start_line":65,"start_character":56,"end_line":65,"end_character":61},"in_reply_to":"bacf61ea_d2c87f57","updated":"2016-08-01 20:25:01.000000000","message":"Done","commit_id":"1e52f02ff321bb51c067f43ab37d940fb2d1c267"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3d563543153300f56c0e1c7bf252cc1fd5241cd3","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"If the value is ``roles``, the property protection file is to"},{"line_number":66,"context_line":"contain a comma separated list of user roles indicating"},{"line_number":67,"context_line":"permissions for each of the CRUD operations on the"},{"line_number":68,"context_line":"property/properties being protected. If set to ``policies``,"},{"line_number":69,"context_line":"a policy defined in policy.json is used to express property"},{"line_number":70,"context_line":"protections for each of the CRUD operations."},{"line_number":71,"context_line":"Examples of how property protections are enforced based on"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_d23d1f2c","line":68,"range":{"start_line":67,"start_character":47,"end_line":68,"end_character":19},"updated":"2016-08-01 19:04:39.000000000","message":"This one is up to you.  I think it might be more clear to say \"for each of the CRUD operations on each property being protected\", but I don\u0027t insist.","commit_id":"1e52f02ff321bb51c067f43ab37d940fb2d1c267"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"283ae1506a6ba905394066ca3d7524074588c444","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"If the value is ``roles``, the property protection file is to"},{"line_number":66,"context_line":"contain a comma separated list of user roles indicating"},{"line_number":67,"context_line":"permissions for each of the CRUD operations on the"},{"line_number":68,"context_line":"property/properties being protected. If set to ``policies``,"},{"line_number":69,"context_line":"a policy defined in policy.json is used to express property"},{"line_number":70,"context_line":"protections for each of the CRUD operations."},{"line_number":71,"context_line":"Examples of how property protections are enforced based on"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_e3b33796","line":68,"range":{"start_line":67,"start_character":47,"end_line":68,"end_character":19},"in_reply_to":"bacf61ea_d23d1f2c","updated":"2016-08-01 20:25:01.000000000","message":"Done","commit_id":"1e52f02ff321bb51c067f43ab37d940fb2d1c267"}]}
