)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"35895c9e5b127555aab1831b551fae3bec24b7e7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dharini Chandrasekar \u003cdharini.chandrasekar@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-22 22:47:10 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improving help text for store type property opt."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added improved help text for store_type_preference configuration"},{"line_number":10,"context_line":"option."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1ac06dbe_39e66544","line":7,"range":{"start_line":7,"start_character":35,"end_line":7,"end_character":43},"updated":"2016-08-23 02:10:17.000000000","message":"preference\nor let\u0027s just refer to the exact option name, store_type_preference","commit_id":"9193fd2f864f635f46157cf5b169a199062214b3"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"e6c9d19842677e1f57f80ea700daed2d9a97a7c6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dharini Chandrasekar \u003cdharini.chandrasekar@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-22 22:47:10 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improving help text for store type property opt."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added improved help text for store_type_preference configuration"},{"line_number":10,"context_line":"option."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1ac06dbe_84070481","line":7,"range":{"start_line":7,"start_character":35,"end_line":7,"end_character":43},"in_reply_to":"1ac06dbe_39e66544","updated":"2016-08-23 15:22:22.000000000","message":"Done","commit_id":"9193fd2f864f635f46157cf5b169a199062214b3"}],"glance/common/location_strategy/store_type.py":[{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"f754e5dd0ee90eae5da60b14d6df33478e0e61a8","unresolved":false,"context_lines":[{"line_number":34,"context_line":"\u0027known_stores\u0027 configuration option. store_type_preference"},{"line_number":35,"context_line":"configuration option is applied only if \u0027store_type\u0027 is chosen"},{"line_number":36,"context_line":"as a value for the location_strategy configuration option which"},{"line_number":37,"context_line":"is used to set the preferred order of image consumption by Glance."},{"line_number":38,"context_line":"An empty list value for store_type_preference defaults to a store"},{"line_number":39,"context_line":"preference of filesystem followed by http."},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_22f4b8cd","line":37,"updated":"2016-08-03 16:36:13.000000000","message":"This is a bit unclear to me. Is it the location_strategy config option that sets the preferred order of image consumption, or the store_type_preference option?","commit_id":"6051afa592463cafdba42ddda62fac8fe9a58320"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"dfc14ed7dc0117565ba8a5b3bcfda45f87cfb26c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"\u0027known_stores\u0027 configuration option. store_type_preference"},{"line_number":35,"context_line":"configuration option is applied only if \u0027store_type\u0027 is chosen"},{"line_number":36,"context_line":"as a value for the location_strategy configuration option which"},{"line_number":37,"context_line":"is used to set the preferred order of image consumption by Glance."},{"line_number":38,"context_line":"An empty list value for store_type_preference defaults to a store"},{"line_number":39,"context_line":"preference of filesystem followed by http."},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_4ce8f310","line":37,"in_reply_to":"bacf61ea_22f4b8cd","updated":"2016-08-03 23:03:09.000000000","message":"It is a bit tricky here with a lot of dependencies. \nThe location_strategy is used to set the preferred order of images for consumption by Glance. And only if store_type is chosen for location_strategy, can we use ``store_type_preference`` config option.","commit_id":"6051afa592463cafdba42ddda62fac8fe9a58320"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"f754e5dd0ee90eae5da60b14d6df33478e0e61a8","unresolved":false,"context_lines":[{"line_number":35,"context_line":"configuration option is applied only if \u0027store_type\u0027 is chosen"},{"line_number":36,"context_line":"as a value for the location_strategy configuration option which"},{"line_number":37,"context_line":"is used to set the preferred order of image consumption by Glance."},{"line_number":38,"context_line":"An empty list value for store_type_preference defaults to a store"},{"line_number":39,"context_line":"preference of filesystem followed by http."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Possible values:"},{"line_number":42,"context_line":"    * Empty list"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_e2b2a0e4","line":39,"range":{"start_line":38,"start_character":0,"end_line":39,"end_character":42},"updated":"2016-08-03 16:36:13.000000000","message":"small nit - I\u0027d change this to say:\n\n\"An empty list value defaults the store preference to filesystem followed by http.\"","commit_id":"6051afa592463cafdba42ddda62fac8fe9a58320"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"dfc14ed7dc0117565ba8a5b3bcfda45f87cfb26c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"configuration option is applied only if \u0027store_type\u0027 is chosen"},{"line_number":36,"context_line":"as a value for the location_strategy configuration option which"},{"line_number":37,"context_line":"is used to set the preferred order of image consumption by Glance."},{"line_number":38,"context_line":"An empty list value for store_type_preference defaults to a store"},{"line_number":39,"context_line":"preference of filesystem followed by http."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Possible values:"},{"line_number":42,"context_line":"    * Empty list"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_2ce3ff34","line":39,"range":{"start_line":38,"start_character":0,"end_line":39,"end_character":42},"in_reply_to":"bacf61ea_e2b2a0e4","updated":"2016-08-03 23:03:09.000000000","message":"Done","commit_id":"6051afa592463cafdba42ddda62fac8fe9a58320"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"09b65b3b8644c50f6ca9816a74194f35af012bbc","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    cfg.ListOpt(\u0027store_type_preference\u0027,"},{"line_number":27,"context_line":"                default\u003d[],"},{"line_number":28,"context_line":"                help\u003d_(\"\"\""},{"line_number":29,"context_line":"Set the order of preference for storage backends."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Provide a comma separated list of store names to set the"},{"line_number":32,"context_line":"preferred order for retrieving images from storage backends."}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_2e18e81d","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":49},"updated":"2016-08-04 16:44:32.000000000","message":"\"Preference order of storage backends\"","commit_id":"6676fade0f17638369828fbcd7d0f71d04828105"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"09b65b3b8644c50f6ca9816a74194f35af012bbc","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                help\u003d_(\"\"\""},{"line_number":29,"context_line":"Set the order of preference for storage backends."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Provide a comma separated list of store names to set the"},{"line_number":32,"context_line":"preferred order for retrieving images from storage backends."},{"line_number":33,"context_line":"These store names must be registered as values with the"},{"line_number":34,"context_line":"\u0027known_stores\u0027 configuration option. ``store_type_preference``"},{"line_number":35,"context_line":"configuration option is applied only if \u0027store_type\u0027 is chosen"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_442c1b99","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":60},"updated":"2016-08-04 16:44:32.000000000","message":"How about \"Provide a comma separated list of store names in the order in which images should be retrieved from storage backends.\"?\nI don\u0027t insist on this, it\u0027s up to you.","commit_id":"6676fade0f17638369828fbcd7d0f71d04828105"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"09b65b3b8644c50f6ca9816a74194f35af012bbc","unresolved":false,"context_lines":[{"line_number":31,"context_line":"Provide a comma separated list of store names to set the"},{"line_number":32,"context_line":"preferred order for retrieving images from storage backends."},{"line_number":33,"context_line":"These store names must be registered as values with the"},{"line_number":34,"context_line":"\u0027known_stores\u0027 configuration option. ``store_type_preference``"},{"line_number":35,"context_line":"configuration option is applied only if \u0027store_type\u0027 is chosen"},{"line_number":36,"context_line":"as a value for the ``location_strategy`` configuration option."},{"line_number":37,"context_line":"An empty list value defaults the store preference to filesystem"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_2e2d88a8","line":34,"range":{"start_line":34,"start_character":36,"end_line":34,"end_character":37},"updated":"2016-08-04 16:44:32.000000000","message":"The","commit_id":"6676fade0f17638369828fbcd7d0f71d04828105"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"09b65b3b8644c50f6ca9816a74194f35af012bbc","unresolved":false,"context_lines":[{"line_number":31,"context_line":"Provide a comma separated list of store names to set the"},{"line_number":32,"context_line":"preferred order for retrieving images from storage backends."},{"line_number":33,"context_line":"These store names must be registered as values with the"},{"line_number":34,"context_line":"\u0027known_stores\u0027 configuration option. ``store_type_preference``"},{"line_number":35,"context_line":"configuration option is applied only if \u0027store_type\u0027 is chosen"},{"line_number":36,"context_line":"as a value for the ``location_strategy`` configuration option."},{"line_number":37,"context_line":"An empty list value defaults the store preference to filesystem"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_2432c7f2","line":34,"range":{"start_line":34,"start_character":1,"end_line":34,"end_character":13},"updated":"2016-08-04 16:44:32.000000000","message":"``known_stores``","commit_id":"6676fade0f17638369828fbcd7d0f71d04828105"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"09b65b3b8644c50f6ca9816a74194f35af012bbc","unresolved":false,"context_lines":[{"line_number":32,"context_line":"preferred order for retrieving images from storage backends."},{"line_number":33,"context_line":"These store names must be registered as values with the"},{"line_number":34,"context_line":"\u0027known_stores\u0027 configuration option. ``store_type_preference``"},{"line_number":35,"context_line":"configuration option is applied only if \u0027store_type\u0027 is chosen"},{"line_number":36,"context_line":"as a value for the ``location_strategy`` configuration option."},{"line_number":37,"context_line":"An empty list value defaults the store preference to filesystem"},{"line_number":38,"context_line":"followed by http."}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_2e7f48ac","line":35,"range":{"start_line":35,"start_character":41,"end_line":35,"end_character":51},"updated":"2016-08-04 16:44:32.000000000","message":"``store_type``","commit_id":"6676fade0f17638369828fbcd7d0f71d04828105"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"09b65b3b8644c50f6ca9816a74194f35af012bbc","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Possible values:"},{"line_number":41,"context_line":"    * Empty list"},{"line_number":42,"context_line":"    * List of registered store names that can include:"},{"line_number":43,"context_line":"        * swift"},{"line_number":44,"context_line":"        * http"},{"line_number":45,"context_line":"        * rbd"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_29746234","line":42,"updated":"2016-08-04 16:44:32.000000000","message":"Comma separated","commit_id":"6676fade0f17638369828fbcd7d0f71d04828105"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"09b65b3b8644c50f6ca9816a74194f35af012bbc","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        * http"},{"line_number":45,"context_line":"        * rbd"},{"line_number":46,"context_line":"        * sheepdog"},{"line_number":47,"context_line":"        * filesystem"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Related options:"},{"line_number":50,"context_line":"    * known_stores"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_e96eca2d","line":47,"updated":"2016-08-04 16:44:32.000000000","message":"\"cinder\" and \"vmware\" missing.","commit_id":"6676fade0f17638369828fbcd7d0f71d04828105"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"09b65b3b8644c50f6ca9816a74194f35af012bbc","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        * http"},{"line_number":45,"context_line":"        * rbd"},{"line_number":46,"context_line":"        * sheepdog"},{"line_number":47,"context_line":"        * filesystem"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Related options:"},{"line_number":50,"context_line":"    * known_stores"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_c96b061d","line":47,"range":{"start_line":47,"start_character":10,"end_line":47,"end_character":20},"updated":"2016-08-04 16:44:32.000000000","message":"This should be \"file\".","commit_id":"6676fade0f17638369828fbcd7d0f71d04828105"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"7bf74aa8980eeb8ce124063a8964868ebef9b046","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Provide a comma separated list of store names in the order in"},{"line_number":32,"context_line":"which images should be retrieved from storage backends."},{"line_number":33,"context_line":"These store names must be registered as values with the"},{"line_number":34,"context_line":"``known_stores`` configuration option."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"The ``store_type_preference`` configuration option is applied"},{"line_number":37,"context_line":"only if ``store_type`` is chosen as a value for the"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_cb8820c8","line":34,"range":{"start_line":33,"start_character":0,"end_line":34,"end_character":38},"updated":"2016-08-22 22:20:45.000000000","message":"This code has its own mapping for the stores and schemes. It doesn\u0027t refer to anything configured with glance_store. (by the \"stores\" opt)\nMeaning we should not be having this line here (nor should it have been in the old help text).\nWas hoping to get this confirmed.\nUntil we edit the map, submitting a patch with a help text that agrees with this code and the mapping here.","commit_id":"b3f289031e434e380d3fb14a5e4f0f5e4d47b618"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"f607d9a3ad189334c6d34c82c24b24936a80d65a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"Provide a comma separated list of store names in the order in"},{"line_number":32,"context_line":"which images should be retrieved from storage backends."},{"line_number":33,"context_line":"These store names must be registered as values with the"},{"line_number":34,"context_line":"``known_stores`` configuration option."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"The ``store_type_preference`` configuration option is applied"},{"line_number":37,"context_line":"only if ``store_type`` is chosen as a value for the"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_ef1c706c","line":34,"range":{"start_line":34,"start_character":2,"end_line":34,"end_character":14},"updated":"2016-08-12 20:21:58.000000000","message":"We don\u0027t have the \"known_stores\" opt any more. It\u0027s just \"stores\"","commit_id":"b3f289031e434e380d3fb14a5e4f0f5e4d47b618"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"cab5884de3cdadee4842085b68b14d73f44f1bd4","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Provide a comma separated list of store names in the order in"},{"line_number":32,"context_line":"which images should be retrieved from storage backends."},{"line_number":33,"context_line":"These store names must be registered as values with the"},{"line_number":34,"context_line":"``known_stores`` configuration option."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"The ``store_type_preference`` configuration option is applied"},{"line_number":37,"context_line":"only if ``store_type`` is chosen as a value for the"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_66284387","line":34,"range":{"start_line":33,"start_character":0,"end_line":34,"end_character":38},"in_reply_to":"1ac06dbe_cb8820c8","updated":"2016-08-22 22:27:48.000000000","message":"I\u0027d say keep the highlighted line in tact. Just explicitly mention the difference of names here.","commit_id":"b3f289031e434e380d3fb14a5e4f0f5e4d47b618"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"3a97851a2da30008fb1abf4f1ef2933fb6fa9113","unresolved":false,"context_lines":[{"line_number":36,"context_line":"The ``store_type_preference`` configuration option is applied"},{"line_number":37,"context_line":"only if ``store_type`` is chosen as a value for the"},{"line_number":38,"context_line":"``location_strategy`` configuration option. An empty list value"},{"line_number":39,"context_line":"defaults the store preference to filesystem followed by http."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Possible values:"},{"line_number":42,"context_line":"    * Empty list"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_67e39306","line":39,"range":{"start_line":39,"start_character":33,"end_line":39,"end_character":43},"updated":"2016-08-12 16:46:53.000000000","message":"couple nits: what\u0027s the purpose of double tick quotes around option names? should filesystem store type above be quoted also?","commit_id":"b3f289031e434e380d3fb14a5e4f0f5e4d47b618"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a75256eb13679e6f56d4d1398967d9c6149152cb","unresolved":false,"context_lines":[{"line_number":36,"context_line":"The ``store_type_preference`` configuration option is applied"},{"line_number":37,"context_line":"only if ``store_type`` is chosen as a value for the"},{"line_number":38,"context_line":"``location_strategy`` configuration option. An empty list value"},{"line_number":39,"context_line":"defaults the store preference to filesystem followed by http."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Possible values:"},{"line_number":42,"context_line":"    * Empty list"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_c671a079","line":39,"range":{"start_line":39,"start_character":33,"end_line":39,"end_character":43},"in_reply_to":"9ad45d7e_67e39306","updated":"2016-08-12 17:22:42.000000000","message":"The double backticks are RST code for \"display in monospace font\".  So the option names are being written that way to make them stand out.\n\nSo it turns out the filesystem store is a weird one.  It uses the scheme \u0027file\u0027, it\u0027s referred to by the symbol \u0027file\u0027, but it\u0027s called the filesystem store.  On the other hand, the http store is referred to by the symbol \u0027http\u0027.  So we\u0027re probably OK in with no quotes around filesystem or http in the above ... or it may be confusing!  I don\u0027t have a strong preference.","commit_id":"b3f289031e434e380d3fb14a5e4f0f5e4d47b618"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"3a97851a2da30008fb1abf4f1ef2933fb6fa9113","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        * sheepdog"},{"line_number":48,"context_line":"        * file"},{"line_number":49,"context_line":"        * vmware"},{"line_number":50,"context_line":"        * cinder"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Related options:"},{"line_number":53,"context_line":"    * known_stores"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_a79bcb71","line":50,"updated":"2016-08-12 16:46:53.000000000","message":"Should filesystem be in this list of possible values?","commit_id":"b3f289031e434e380d3fb14a5e4f0f5e4d47b618"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"cf88085348a4b38fea6a843c9bd3ecacafe0faa8","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        * sheepdog"},{"line_number":48,"context_line":"        * file"},{"line_number":49,"context_line":"        * vmware"},{"line_number":50,"context_line":"        * cinder"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Related options:"},{"line_number":53,"context_line":"    * known_stores"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac969e8_6c76ef3f","line":50,"in_reply_to":"7ac969e8_292509c2","updated":"2016-08-12 22:01:21.000000000","message":"Referring to the older patch sets, I had ``filesystem`` earlier. Then based on opts in glance_store and reviews on the patch set, changed it to ``file``.\nHopefully we have the store opts merged and work on this soon, to be in accordance with that.","commit_id":"b3f289031e434e380d3fb14a5e4f0f5e4d47b618"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"f607d9a3ad189334c6d34c82c24b24936a80d65a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        * sheepdog"},{"line_number":48,"context_line":"        * file"},{"line_number":49,"context_line":"        * vmware"},{"line_number":50,"context_line":"        * cinder"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Related options:"},{"line_number":53,"context_line":"    * known_stores"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_62fd376e","line":50,"in_reply_to":"9ad45d7e_2616bca7","updated":"2016-08-12 20:21:58.000000000","message":"Oh well!\nLook at this https://github.com/openstack/glance/blob/master/glance/common/location_strategy/store_type.py#L57-L64\n\nIt\u0027s unfortunate that we don\u0027t have a consistent way of referring to our stores. It indeed looks like we need \"filesystem\" here instead of \"file\" and \"vmware_datastore\" instead of \"vmware\"\n\nBut mind you, this is very very specific to just this configuration opt and should not be considered valid for other configuration opts unless mentioned otherwise specifically.","commit_id":"b3f289031e434e380d3fb14a5e4f0f5e4d47b618"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"91c69fe84d687a009bd886d76aec3287de20827b","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        * sheepdog"},{"line_number":48,"context_line":"        * file"},{"line_number":49,"context_line":"        * vmware"},{"line_number":50,"context_line":"        * cinder"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Related options:"},{"line_number":53,"context_line":"    * known_stores"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_e5dad116","line":50,"in_reply_to":"9ad45d7e_455bdd2e","updated":"2016-08-12 20:43:11.000000000","message":"Looks like we need to repopulate the config options in Ocata so that all the configs related to store setup can use multiple names. filesystem can be used along with (instead of) file and vmware_datastore along with vmware.\n\nOr do you see an issue with that change somewhere else?\n\nI am trying to figure out if we are going to face an issue somewhere in the pipe -- like may be at the entry_points ?","commit_id":"b3f289031e434e380d3fb14a5e4f0f5e4d47b618"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4810ffbfa0bef22cc22d083958325a1ad5384ccb","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        * sheepdog"},{"line_number":48,"context_line":"        * file"},{"line_number":49,"context_line":"        * vmware"},{"line_number":50,"context_line":"        * cinder"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Related options:"},{"line_number":53,"context_line":"    * known_stores"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_455bdd2e","line":50,"in_reply_to":"9ad45d7e_62fd376e","updated":"2016-08-12 20:31:48.000000000","message":"Good grief.  That is completely crazy.  Since this is in Glance and not glance_store, we have a little more time. I think we should (a) file a bug to fix the map Hemanth linked to above so that it includes the \"correct\" options, leaving the old ones there for old config files, (b) only mention the \"correct\" glance_store names here, and (c) make this patch depend on the patch that fixes (a).","commit_id":"b3f289031e434e380d3fb14a5e4f0f5e4d47b618"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"9f93aa33ba95197f0ae88017ac19ec5ac9a56a96","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        * sheepdog"},{"line_number":48,"context_line":"        * file"},{"line_number":49,"context_line":"        * vmware"},{"line_number":50,"context_line":"        * cinder"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Related options:"},{"line_number":53,"context_line":"    * known_stores"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_2616bca7","line":50,"in_reply_to":"9ad45d7e_6613940e","updated":"2016-08-12 17:29:56.000000000","message":"Thanks Brian.\nAlex, as Brian has explained, \u0027filesystem\u0027 is one of the schemes apart from \u0027file\u0027 that the store - \u0027file\u0027 uses. \nSo these are the stores and they have 1 or more schemes associated with them.","commit_id":"b3f289031e434e380d3fb14a5e4f0f5e4d47b618"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a75256eb13679e6f56d4d1398967d9c6149152cb","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        * sheepdog"},{"line_number":48,"context_line":"        * file"},{"line_number":49,"context_line":"        * vmware"},{"line_number":50,"context_line":"        * cinder"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Related options:"},{"line_number":53,"context_line":"    * known_stores"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_6613940e","line":50,"in_reply_to":"9ad45d7e_a79bcb71","updated":"2016-08-12 17:22:42.000000000","message":"I think not, see explanation above.","commit_id":"b3f289031e434e380d3fb14a5e4f0f5e4d47b618"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"efb235b3161985248400ab9dfd9f319f25904183","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        * sheepdog"},{"line_number":48,"context_line":"        * file"},{"line_number":49,"context_line":"        * vmware"},{"line_number":50,"context_line":"        * cinder"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Related options:"},{"line_number":53,"context_line":"    * known_stores"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac969e8_292509c2","line":50,"in_reply_to":"9ad45d7e_e5dad116","updated":"2016-08-12 21:44:22.000000000","message":"Thanks Hemanth, Brian and Nikhil.\nThis is totally not in sync with stores and schemes config opts in Glance store. I wrote this help text keeping the stores and schemes of Glance store config options in mind. \nWill set workflow to -1 until we get the store names conflict resolved.","commit_id":"b3f289031e434e380d3fb14a5e4f0f5e4d47b618"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"f607d9a3ad189334c6d34c82c24b24936a80d65a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        * cinder"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Related options:"},{"line_number":53,"context_line":"    * known_stores"},{"line_number":54,"context_line":"    * location_strategy"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"\"\"\"))"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_4f5bfc2e","line":53,"range":{"start_line":53,"start_character":6,"end_line":53,"end_character":18},"updated":"2016-08-12 20:21:58.000000000","message":"stores","commit_id":"b3f289031e434e380d3fb14a5e4f0f5e4d47b618"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5f74302f4dfb2829c450d3ec1827dc8babe4055d","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Possible values:"},{"line_number":42,"context_line":"    * Empty list"},{"line_number":43,"context_line":"    * Comma separated list of registered store names that can include:"},{"line_number":44,"context_line":"        * filesystem"},{"line_number":45,"context_line":"        * http"},{"line_number":46,"context_line":"        * rbd"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ac06dbe_8388a8c6","line":43,"range":{"start_line":43,"start_character":6,"end_line":43,"end_character":70},"updated":"2016-08-23 13:24:37.000000000","message":"As Hemanth pointed out, we need to mention that this list of values is specific to this option.  Let\u0027s rewrite the above sentence to something like:\n\nComma separated list of registered store names.  Use only the following choices, which, unfortunately, are not named entirely consistently with the store names used in other similar configuration options.  Take extra care in setting this option, and read the help text carefully when setting other similar options.\n\nAlso, Hemanth mentioned on an earlier patch set filing a bug about making the store names consistent and backwards compatible.  Please add a TODO comment before this option giving the bug number and saying the help text needs to be rewritten when that bug is fixed.","commit_id":"9193fd2f864f635f46157cf5b169a199062214b3"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"e6c9d19842677e1f57f80ea700daed2d9a97a7c6","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Possible values:"},{"line_number":42,"context_line":"    * Empty list"},{"line_number":43,"context_line":"    * Comma separated list of registered store names that can include:"},{"line_number":44,"context_line":"        * filesystem"},{"line_number":45,"context_line":"        * http"},{"line_number":46,"context_line":"        * rbd"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ac06dbe_3b93cffb","line":43,"range":{"start_line":43,"start_character":6,"end_line":43,"end_character":70},"in_reply_to":"1ac06dbe_8388a8c6","updated":"2016-08-23 15:22:22.000000000","message":"Done","commit_id":"9193fd2f864f635f46157cf5b169a199062214b3"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"2b18407e8dc3e6808a368defebfdca80ecd85fe6","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from glance.i18n import _"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# TODO(dharinic): The help text for this option needs to be edited upon"},{"line_number":25,"context_line":"# resolving of Bug #1615852"},{"line_number":26,"context_line":"store_type_opts \u003d ["},{"line_number":27,"context_line":"    cfg.ListOpt(\u0027store_type_preference\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ac06dbe_8f61ddab","line":24,"range":{"start_line":24,"start_character":36,"end_line":24,"end_character":40},"updated":"2016-08-23 15:39:28.000000000","message":"If you are pushing another patchset, let\u0027s explicitly mention store_type_preference here.","commit_id":"021934236a01fd38228b97a1dad8a3c3d7d1f821"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"2b18407e8dc3e6808a368defebfdca80ecd85fe6","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from glance.i18n import _"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# TODO(dharinic): The help text for this option needs to be edited upon"},{"line_number":25,"context_line":"# resolving of Bug #1615852"},{"line_number":26,"context_line":"store_type_opts \u003d ["},{"line_number":27,"context_line":"    cfg.ListOpt(\u0027store_type_preference\u0027,"},{"line_number":28,"context_line":"                default\u003d[],"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ac06dbe_cfd0f5cb","line":25,"range":{"start_line":24,"start_character":67,"end_line":25,"end_character":14},"updated":"2016-08-23 15:39:28.000000000","message":"nit: how about \"upon resolution of the\" or \"after resolving the\"?","commit_id":"021934236a01fd38228b97a1dad8a3c3d7d1f821"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"2b18407e8dc3e6808a368defebfdca80ecd85fe6","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"NOTE: The ``store_type_preference`` configuration option is applied"},{"line_number":38,"context_line":"only if ``store_type`` is chosen as a value for the"},{"line_number":39,"context_line":"``location_strategy`` configuration option. An empty list value"},{"line_number":40,"context_line":"defaults the store preference to filesystem followed by http."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Possible values:"},{"line_number":43,"context_line":"    * Empty list"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ac06dbe_ef7a1123","line":40,"range":{"start_line":39,"start_character":44,"end_line":40,"end_character":60},"updated":"2016-08-23 15:39:28.000000000","message":"Then, wonder why we default to an empty list?\nWhy can\u0027t we default to [\u0027filesystem\u0027, \u0027http\u0027] directly?\n\nYou haven\u0027t changed this but I\u0027m wondering if it\u0027s a good change to make here?","commit_id":"021934236a01fd38228b97a1dad8a3c3d7d1f821"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"2b18407e8dc3e6808a368defebfdca80ecd85fe6","unresolved":false,"context_lines":[{"line_number":37,"context_line":"NOTE: The ``store_type_preference`` configuration option is applied"},{"line_number":38,"context_line":"only if ``store_type`` is chosen as a value for the"},{"line_number":39,"context_line":"``location_strategy`` configuration option. An empty list value"},{"line_number":40,"context_line":"defaults the store preference to filesystem followed by http."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Possible values:"},{"line_number":43,"context_line":"    * Empty list"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ac06dbe_af001967","line":40,"range":{"start_line":40,"start_character":33,"end_line":40,"end_character":43},"updated":"2016-08-23 15:39:28.000000000","message":"``filesystem``","commit_id":"021934236a01fd38228b97a1dad8a3c3d7d1f821"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"2b18407e8dc3e6808a368defebfdca80ecd85fe6","unresolved":false,"context_lines":[{"line_number":37,"context_line":"NOTE: The ``store_type_preference`` configuration option is applied"},{"line_number":38,"context_line":"only if ``store_type`` is chosen as a value for the"},{"line_number":39,"context_line":"``location_strategy`` configuration option. An empty list value"},{"line_number":40,"context_line":"defaults the store preference to filesystem followed by http."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Possible values:"},{"line_number":43,"context_line":"    * Empty list"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ac06dbe_8f2efdf8","line":40,"range":{"start_line":40,"start_character":56,"end_line":40,"end_character":60},"updated":"2016-08-23 15:39:28.000000000","message":"``http``","commit_id":"021934236a01fd38228b97a1dad8a3c3d7d1f821"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"0cbb5a195b8f2e6fb0a2cba0dd9b50d3a5d056ce","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"NOTE: The ``store_type_preference`` configuration option is applied"},{"line_number":38,"context_line":"only if ``store_type`` is chosen as a value for the"},{"line_number":39,"context_line":"``location_strategy`` configuration option. An empty list value"},{"line_number":40,"context_line":"defaults the store preference to filesystem followed by http."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Possible values:"},{"line_number":43,"context_line":"    * Empty list"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ac06dbe_44477a1d","line":40,"range":{"start_line":39,"start_character":44,"end_line":40,"end_character":60},"in_reply_to":"1ac06dbe_4ea87e77","updated":"2016-08-24 16:40:02.000000000","message":"We should drop this line. It isn\u0027t accurate. If no store type preferences are given, the original order of location is retained. And, that\u0027s what we should mention here.","commit_id":"021934236a01fd38228b97a1dad8a3c3d7d1f821"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"a11e93ed818a6506359b637ef541096cbda5f910","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"NOTE: The ``store_type_preference`` configuration option is applied"},{"line_number":38,"context_line":"only if ``store_type`` is chosen as a value for the"},{"line_number":39,"context_line":"``location_strategy`` configuration option. An empty list value"},{"line_number":40,"context_line":"defaults the store preference to filesystem followed by http."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Possible values:"},{"line_number":43,"context_line":"    * Empty list"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ac06dbe_4ea87e77","line":40,"range":{"start_line":39,"start_character":44,"end_line":40,"end_character":60},"in_reply_to":"1ac06dbe_5a767c3e","updated":"2016-08-23 17:35:30.000000000","message":"What you said makes sense about how [\u0027filesystem\u0027, \u0027http\u0027] can\u0027t the default here.\nI\u0027m thinking if this line should be dropped altogether and it could even be wrong. Looking further.","commit_id":"021934236a01fd38228b97a1dad8a3c3d7d1f821"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"11700ea276c7d9aed4d5b95b6a6fa998116088c1","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"NOTE: The ``store_type_preference`` configuration option is applied"},{"line_number":38,"context_line":"only if ``store_type`` is chosen as a value for the"},{"line_number":39,"context_line":"``location_strategy`` configuration option. An empty list value"},{"line_number":40,"context_line":"defaults the store preference to filesystem followed by http."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Possible values:"},{"line_number":43,"context_line":"    * Empty list"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ac06dbe_5a767c3e","line":40,"range":{"start_line":39,"start_character":44,"end_line":40,"end_character":60},"in_reply_to":"1ac06dbe_ef7a1123","updated":"2016-08-23 16:43:40.000000000","message":"I did think of that Hemanth. \nHowever, reconsidering the default, it so happens that in this code, we do not return the preferred order of [\u0027filesystem\u0027, \u0027http\u0027]. An empty list is returned here.\n[\u0027feile\u0027, \u0027http\u0027] is the default of the stores made available for storing glance images in the glance_store code.\nHowever, indirectly/implictly,  the default goes to storing images in file followed by http as per glance_store.\nPlease advise if we still need to have this line here. Cos implicitly that is what is happening. But actually this code would only return an empty list of preferred stores.","commit_id":"021934236a01fd38228b97a1dad8a3c3d7d1f821"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"2b18407e8dc3e6808a368defebfdca80ecd85fe6","unresolved":false,"context_lines":[{"line_number":42,"context_line":"Possible values:"},{"line_number":43,"context_line":"    * Empty list"},{"line_number":44,"context_line":"    * Comma separated list of registered store names that must include:"},{"line_number":45,"context_line":"      NOTE: Use only the following choices, which, unfortunately,"},{"line_number":46,"context_line":"      are not entirely consistent with the store names used in other"},{"line_number":47,"context_line":"      similar configuration options. Please take extra care while"},{"line_number":48,"context_line":"      setting this option, and read the help text carefully when"},{"line_number":49,"context_line":"      setting other similar options."},{"line_number":50,"context_line":"        * filesystem"},{"line_number":51,"context_line":"        * http"},{"line_number":52,"context_line":"        * rbd"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ac06dbe_6fe3c1d9","line":49,"range":{"start_line":45,"start_character":6,"end_line":49,"end_character":36},"updated":"2016-08-23 15:39:28.000000000","message":"How about adding parentheses around this?","commit_id":"021934236a01fd38228b97a1dad8a3c3d7d1f821"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"531f0d25850374e63a5440956f70bef40c667c4a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"NOTE: The ``store_type_preference`` configuration option is applied"},{"line_number":39,"context_line":"only if ``store_type`` is chosen as a value for the"},{"line_number":40,"context_line":"``location_strategy`` configuration option. An empty list value"},{"line_number":41,"context_line":"defaults the store preference to the order in which the locations"},{"line_number":42,"context_line":"are provided."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ac06dbe_03256fad","line":41,"range":{"start_line":41,"start_character":9,"end_line":41,"end_character":32},"updated":"2016-08-24 19:26:47.000000000","message":"This could be misleading.\nIt doesn\u0027t default the store preference.\nIt just doesn\u0027t do anything with the locations. Just returns the location in whatever order they appear in the database.\nSo, I\u0027d say we communication that explicitly with something like \"An empty list will not change the location order\".","commit_id":"fd6180a7c6c12b5b73f5db565e66fd459dcf8a54"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"681ae41cdf3fc7478eecbdcbf1053b307f983c08","unresolved":false,"context_lines":[{"line_number":38,"context_line":"NOTE: The ``store_type_preference`` configuration option is applied"},{"line_number":39,"context_line":"only if ``store_type`` is chosen as a value for the"},{"line_number":40,"context_line":"``location_strategy`` configuration option. An empty list value"},{"line_number":41,"context_line":"defaults the store preference to the order in which the locations"},{"line_number":42,"context_line":"are provided."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ac06dbe_07629ad8","line":41,"range":{"start_line":41,"start_character":9,"end_line":41,"end_character":32},"in_reply_to":"1ac06dbe_03256fad","updated":"2016-08-24 19:41:30.000000000","message":"Done","commit_id":"fd6180a7c6c12b5b73f5db565e66fd459dcf8a54"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"531f0d25850374e63a5440956f70bef40c667c4a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"      setting this option, and read the help text carefully when"},{"line_number":51,"context_line":"      setting other similar options.)"},{"line_number":52,"context_line":"        * filesystem"},{"line_number":53,"context_line":"        * file"},{"line_number":54,"context_line":"        * http"},{"line_number":55,"context_line":"        * rbd"},{"line_number":56,"context_line":"        * swift"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ac06dbe_436da7cb","line":53,"range":{"start_line":53,"start_character":10,"end_line":53,"end_character":14},"updated":"2016-08-24 19:26:47.000000000","message":"Too soon to add this here. We should change the help text to reflect this in your other patch where we actually start accepting \"file\".","commit_id":"fd6180a7c6c12b5b73f5db565e66fd459dcf8a54"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"681ae41cdf3fc7478eecbdcbf1053b307f983c08","unresolved":false,"context_lines":[{"line_number":50,"context_line":"      setting this option, and read the help text carefully when"},{"line_number":51,"context_line":"      setting other similar options.)"},{"line_number":52,"context_line":"        * filesystem"},{"line_number":53,"context_line":"        * file"},{"line_number":54,"context_line":"        * http"},{"line_number":55,"context_line":"        * rbd"},{"line_number":56,"context_line":"        * swift"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ac06dbe_479ad2c6","line":53,"range":{"start_line":53,"start_character":10,"end_line":53,"end_character":14},"in_reply_to":"1ac06dbe_436da7cb","updated":"2016-08-24 19:41:30.000000000","message":"Done","commit_id":"fd6180a7c6c12b5b73f5db565e66fd459dcf8a54"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"531f0d25850374e63a5440956f70bef40c667c4a","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        * sheepdog"},{"line_number":58,"context_line":"        * cinder"},{"line_number":59,"context_line":"        * vmware_datastore"},{"line_number":60,"context_line":"        * vmware"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Related options:"},{"line_number":63,"context_line":"    * location_strategy"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ac06dbe_636423e5","line":60,"range":{"start_line":60,"start_character":10,"end_line":60,"end_character":16},"updated":"2016-08-24 19:26:47.000000000","message":"same","commit_id":"fd6180a7c6c12b5b73f5db565e66fd459dcf8a54"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"681ae41cdf3fc7478eecbdcbf1053b307f983c08","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        * sheepdog"},{"line_number":58,"context_line":"        * cinder"},{"line_number":59,"context_line":"        * vmware_datastore"},{"line_number":60,"context_line":"        * vmware"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Related options:"},{"line_number":63,"context_line":"    * location_strategy"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ac06dbe_279fd6b5","line":60,"range":{"start_line":60,"start_character":10,"end_line":60,"end_character":16},"in_reply_to":"1ac06dbe_636423e5","updated":"2016-08-24 19:41:30.000000000","message":"Done","commit_id":"fd6180a7c6c12b5b73f5db565e66fd459dcf8a54"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"f09d70af637d9200543bee810181c3384107b9f5","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from glance.i18n import _"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# TODO(dharinic): The help text for ``store_type_preference`` must be"},{"line_number":25,"context_line":"# edited to replace ``filesystem``and ``vmware_datastore`` with ``file``"},{"line_number":26,"context_line":"# and ``vmware`` respectively upon resolution of Bug #1615852."},{"line_number":27,"context_line":"store_type_opts \u003d ["},{"line_number":28,"context_line":"    cfg.ListOpt(\u0027store_type_preference\u0027,"},{"line_number":29,"context_line":"                default\u003d[],"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ac06dbe_07f1facd","line":26,"range":{"start_line":24,"start_character":0,"end_line":26,"end_character":62},"updated":"2016-08-24 19:46:23.000000000","message":"Hmmm, I\u0027m thinking maybe we can\u0027t get rid of \"filesystem\" and \"vmware_datastore\" right away without deprecating them. And, the other thing I\u0027m not sure about is, how to deprecate a particular value for a config opt?\n\nThe current deprecation practices address the entire option. I don\u0027t know if there\u0027s a good way to deprecate only certain values for a config option. \n\nLet\u0027s see what others say.","commit_id":"841ae0fd18db4e8930a8d8ad74f36ee8fb6c598e"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"683c126bf39612f97c419c8a4366933a4000a331","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from glance.i18n import _"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# TODO(dharinic): The help text for ``store_type_preference`` must be"},{"line_number":25,"context_line":"# edited to replace ``filesystem``and ``vmware_datastore`` with ``file``"},{"line_number":26,"context_line":"# and ``vmware`` respectively upon resolution of Bug #1615852."},{"line_number":27,"context_line":"store_type_opts \u003d ["},{"line_number":28,"context_line":"    cfg.ListOpt(\u0027store_type_preference\u0027,"},{"line_number":29,"context_line":"                default\u003d[],"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ac06dbe_e7549e22","line":26,"range":{"start_line":24,"start_character":0,"end_line":26,"end_character":62},"in_reply_to":"1ac06dbe_07f1facd","updated":"2016-08-24 19:54:44.000000000","message":"But we wouldn\u0027t be deprecating the values right? We would still be accepting them (if the old conf files had it; thereby supporting backward compatibility).\nJust that we are encouraging the operators to provide the new and consistent store names if they are to configure this in the future. (Which is why i thought we can replace the old values in the ``Possible values`` section)","commit_id":"841ae0fd18db4e8930a8d8ad74f36ee8fb6c598e"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"c4d438e0f1f1b33c5e2a7e32440480b73f4cb422","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from glance.i18n import _"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# TODO(dharinic): The help text for ``store_type_preference`` must be"},{"line_number":25,"context_line":"# edited to replace ``filesystem``and ``vmware_datastore`` with ``file``"},{"line_number":26,"context_line":"# and ``vmware`` respectively upon resolution of Bug #1615852."},{"line_number":27,"context_line":"store_type_opts \u003d ["},{"line_number":28,"context_line":"    cfg.ListOpt(\u0027store_type_preference\u0027,"},{"line_number":29,"context_line":"                default\u003d[],"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ac06dbe_bc911155","line":26,"range":{"start_line":24,"start_character":0,"end_line":26,"end_character":62},"in_reply_to":"1ac06dbe_0d58f955","updated":"2016-08-24 22:00:15.000000000","message":"Thanks Brian for pointing out that we need to remove the Note paragraph in the  Possible Values sections.\nAdded the NOTE.","commit_id":"841ae0fd18db4e8930a8d8ad74f36ee8fb6c598e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"527a1ce85792581bda95750684dd395dd6fc28fe","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from glance.i18n import _"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# TODO(dharinic): The help text for ``store_type_preference`` must be"},{"line_number":25,"context_line":"# edited to replace ``filesystem``and ``vmware_datastore`` with ``file``"},{"line_number":26,"context_line":"# and ``vmware`` respectively upon resolution of Bug #1615852."},{"line_number":27,"context_line":"store_type_opts \u003d ["},{"line_number":28,"context_line":"    cfg.ListOpt(\u0027store_type_preference\u0027,"},{"line_number":29,"context_line":"                default\u003d[],"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ac06dbe_0d58f955","line":26,"range":{"start_line":24,"start_character":0,"end_line":26,"end_character":62},"in_reply_to":"1ac06dbe_6a451316","updated":"2016-08-24 20:35:25.000000000","message":"Dharini is correct, we\u0027ll continue to accept the \"old\" values, but as far as the help text and docs go, we\u0027ll pretend that they don\u0027t exist.  Unfortunately, that means that (as Hemanth points out) that we cannot use a \"choices\" argument here.  But I don\u0027t think a ListOpt currently takes \u0027choices\u0027 anyway, so maybe we don\u0027t need to worry?  On the other hand, I can see someone implementing \u0027choices\u0027 for ListOpt.  Maybe we need another comment here, something like:\n\nNOTE(dharinic): We cannot restrict the choices for this option for backward compatability reasons.  See Bug #1615852.\n\nMake this a different comment from the one above so that when the Bug is fixed, the comment you have above can be deleted, but this new one can be left behind.\n\nAlso, on that note (and maybe this is overdoing it), your current comment could mention that when the values are fixed after the bug is fixed, the Note in the \"possible values\" section should also be removed.","commit_id":"841ae0fd18db4e8930a8d8ad74f36ee8fb6c598e"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"11a2d51ec91c9d853b19aca81e561d69d9f404dd","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from glance.i18n import _"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# TODO(dharinic): The help text for ``store_type_preference`` must be"},{"line_number":25,"context_line":"# edited to replace ``filesystem``and ``vmware_datastore`` with ``file``"},{"line_number":26,"context_line":"# and ``vmware`` respectively upon resolution of Bug #1615852."},{"line_number":27,"context_line":"store_type_opts \u003d ["},{"line_number":28,"context_line":"    cfg.ListOpt(\u0027store_type_preference\u0027,"},{"line_number":29,"context_line":"                default\u003d[],"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ac06dbe_6a451316","line":26,"range":{"start_line":24,"start_character":0,"end_line":26,"end_character":62},"in_reply_to":"1ac06dbe_e7549e22","updated":"2016-08-24 19:59:28.000000000","message":"Oh well, sorry I confused myself there. I thought we had \"choices\" here. If we had choices and if we removed filesystem and vmware_datatstore from it, then it won\u0027t accept those values, which breaks backwards compatibility.\n\nThat\u0027s where I was coming from. Sorry, the context switches are making me go crazy I guess.","commit_id":"841ae0fd18db4e8930a8d8ad74f36ee8fb6c598e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"527a1ce85792581bda95750684dd395dd6fc28fe","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Possible values:"},{"line_number":44,"context_line":"    * Empty list"},{"line_number":45,"context_line":"    * Comma separated list of registered store names that must include:"},{"line_number":46,"context_line":"      (NOTE: Use only the following choices, which, unfortunately,"},{"line_number":47,"context_line":"      are not entirely consistent with the store names used in other"},{"line_number":48,"context_line":"      similar configuration options. Please take extra care while"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ac06dbe_30beead4","line":45,"range":{"start_line":45,"start_character":53,"end_line":45,"end_character":70},"updated":"2016-08-24 20:35:25.000000000","message":"This isn\u0027t quite right (it implies that the list must include all the values).  Maybe change it to:\n\nComma separated list of registered store names.  Legal values are:","commit_id":"841ae0fd18db4e8930a8d8ad74f36ee8fb6c598e"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"c4d438e0f1f1b33c5e2a7e32440480b73f4cb422","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Possible values:"},{"line_number":44,"context_line":"    * Empty list"},{"line_number":45,"context_line":"    * Comma separated list of registered store names that must include:"},{"line_number":46,"context_line":"      (NOTE: Use only the following choices, which, unfortunately,"},{"line_number":47,"context_line":"      are not entirely consistent with the store names used in other"},{"line_number":48,"context_line":"      similar configuration options. Please take extra care while"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ac06dbe_f34d77c5","line":45,"range":{"start_line":45,"start_character":53,"end_line":45,"end_character":70},"in_reply_to":"1ac06dbe_30beead4","updated":"2016-08-24 22:00:15.000000000","message":"Done","commit_id":"841ae0fd18db4e8930a8d8ad74f36ee8fb6c598e"}]}