)]}'
{"glance/tests/unit/v2/test_registry_api.py":[{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"fa87a00ff44650a0f8e89b679293579fca7264b8","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        db_models.register_models(db_api.get_engine())"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def _compare_images_and_uuids(self, uuids, images):"},{"line_number":116,"context_line":"        self.assertEqual(uuids, [image[\u0027id\u0027] for image in images])"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def test_show(self):"},{"line_number":119,"context_line":"        \"\"\"Tests that registry API endpoint returns the expected image.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_a514309f","line":116,"updated":"2016-07-25 09:10:56.000000000","message":"Hi, thanks for the patch! From my point of view it is not clear if this unification brings some value because assertListEqual is also tells the reviewer that 2 lists are compated. Also assertListEqual is not deprecated so I do not see a reason to remove usage of this method from the code.\nLet\u0027s see what other folks will say.","commit_id":"0a3a6a0742c44e98ffb7e62bbc3de01b7f5788e1"},{"author":{"_account_id":22834,"name":"liwei","email":"wei.li@easystack.cn","username":"liwei1"},"change_message_id":"7679cdb6723a556298ec47a12c94cb11da626623","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        db_models.register_models(db_api.get_engine())"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def _compare_images_and_uuids(self, uuids, images):"},{"line_number":116,"context_line":"        self.assertEqual(uuids, [image[\u0027id\u0027] for image in images])"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def test_show(self):"},{"line_number":119,"context_line":"        \"\"\"Tests that registry API endpoint returns the expected image.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_56696cf8","line":116,"in_reply_to":"dada55a8_48546953","updated":"2016-07-26 11:19:53.000000000","message":"Thank you for your correct, my understanding is not enough","commit_id":"0a3a6a0742c44e98ffb7e62bbc3de01b7f5788e1"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"3638acbe731780149d7d17108b7ee6542ab7c0d2","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        db_models.register_models(db_api.get_engine())"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def _compare_images_and_uuids(self, uuids, images):"},{"line_number":116,"context_line":"        self.assertEqual(uuids, [image[\u0027id\u0027] for image in images])"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def test_show(self):"},{"line_number":119,"context_line":"        \"\"\"Tests that registry API endpoint returns the expected image.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_48546953","line":116,"in_reply_to":"dada55a8_a514309f","updated":"2016-07-25 09:38:08.000000000","message":"+1.\n\nI really do not get the point of this patch. AssertListEqual seems much better than assertEqual, since it \" shows only the differences between the two [lists]\" (https://docs.python.org/2.7/library/unittest.html#unittest.TestCase.assertListEqual).","commit_id":"0a3a6a0742c44e98ffb7e62bbc3de01b7f5788e1"},{"author":{"_account_id":22834,"name":"liwei","email":"wei.li@easystack.cn","username":"liwei1"},"change_message_id":"7679cdb6723a556298ec47a12c94cb11da626623","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        db_models.register_models(db_api.get_engine())"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def _compare_images_and_uuids(self, uuids, images):"},{"line_number":116,"context_line":"        self.assertEqual(uuids, [image[\u0027id\u0027] for image in images])"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def test_show(self):"},{"line_number":119,"context_line":"        \"\"\"Tests that registry API endpoint returns the expected image.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_9637644c","line":116,"in_reply_to":"dada55a8_a514309f","updated":"2016-07-26 11:19:53.000000000","message":"Thank you for your advice, I will continue to work hard","commit_id":"0a3a6a0742c44e98ffb7e62bbc3de01b7f5788e1"}]}