)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"cfc8b62fb4147956e890f94a361a65cd2fd5a856","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-09-01 03:28:48 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improving help text for data access API option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ib7e265c3b1c3fc7752c77ef75fa28c9b4151f8e3"},{"line_number":10,"context_line":"Partial-Bug: #1570946"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"fa7ab95a_d1be8063","line":8,"updated":"2016-09-01 03:32:23.000000000","message":"Let\u0027s add Co-Authored-By tags here.","commit_id":"56082145ef9d0eaf1aff27e906e7d3e053355c9a"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"3cf146a9503a2b8290b89db1f135a7af029519be","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Partial-Bug: #1570946"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Co-Authored-By: Dharini Chandrasekar \u003cdharini.chandrasekar@intel.com\u003e"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib7e265c3b1c3fc7752c77ef75fa28c9b4151f8e3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"fa7ab95a_3c1b031e","line":12,"updated":"2016-09-01 03:45:11.000000000","message":"Let\u0027s add the following as well:\n\nCo-Authored-By: Alexander Bashmakov \u003calexander.bashmakov@intel.com\u003e","commit_id":"73a7c58a899f1aa154cce49a2aa54abc0894a5aa"}],"glance/common/config.py":[{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"f605d801b515cefd7c4751735c8c142ce0d78baa","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    * enable_v2_api"},{"line_number":120,"context_line":"    * enable_v2_registry"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"If this option is set to glance.db.registry.api and enable_v2_api is"},{"line_number":123,"context_line":"set to True, then enable_v2_registry must also be set to True."},{"line_number":124,"context_line":"\"\"\")),"},{"line_number":125,"context_line":"    cfg.IntOpt(\u0027limit_param_default\u0027, default\u003d25,"},{"line_number":126,"context_line":"               help\u003d_(\u0027Default value for the number of items returned by a \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_2da40b06","line":123,"range":{"start_line":122,"start_character":0,"end_line":123,"end_character":62},"updated":"2016-08-12 00:11:19.000000000","message":"Can we add this above \"Possible values\" under a \"NOTE:\" section?","commit_id":"d0a0b6d528835032cfade786bf9879a8c648628e"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"b5e4605ba0644a77f0abd4b19856105c46efc766","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    * enable_v2_api"},{"line_number":120,"context_line":"    * enable_v2_registry"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"If this option is set to glance.db.registry.api and enable_v2_api is"},{"line_number":123,"context_line":"set to True, then enable_v2_registry must also be set to True."},{"line_number":124,"context_line":"\"\"\")),"},{"line_number":125,"context_line":"    cfg.IntOpt(\u0027limit_param_default\u0027, default\u003d25,"},{"line_number":126,"context_line":"               help\u003d_(\u0027Default value for the number of items returned by a \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_adbd9b03","line":123,"range":{"start_line":122,"start_character":0,"end_line":123,"end_character":62},"in_reply_to":"9ad45d7e_2da40b06","updated":"2016-08-12 00:15:55.000000000","message":"Done","commit_id":"d0a0b6d528835032cfade786bf9879a8c648628e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3563652ed53cbb7db045db703368b3b191c41cec","unresolved":false,"context_lines":[{"line_number":103,"context_line":"               help\u003d_(\u0027Maximum number of locations allowed on an image. \u0027"},{"line_number":104,"context_line":"                      \u0027Negative values evaluate to unlimited.\u0027)),"},{"line_number":105,"context_line":"    cfg.StrOpt(\u0027data_api\u0027,"},{"line_number":106,"context_line":"               default\u003d\u0027glance.db.sqlalchemy.api\u0027,"},{"line_number":107,"context_line":"               help\u003d_(\"\"\""},{"line_number":108,"context_line":"Python module path of data access API."},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_163c48c7","line":106,"updated":"2016-08-16 13:24:05.000000000","message":"Check with Dharini and Hemanth, but I think you could add a \u0027choices\u0027 argument here to restrict the values to the three you list below.","commit_id":"548df29ae560017884b2953fe7111bce6b565c1a"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"a22333cfac3b3d148f57e0a813115bc1fa9f5ee4","unresolved":false,"context_lines":[{"line_number":103,"context_line":"               help\u003d_(\u0027Maximum number of locations allowed on an image. \u0027"},{"line_number":104,"context_line":"                      \u0027Negative values evaluate to unlimited.\u0027)),"},{"line_number":105,"context_line":"    cfg.StrOpt(\u0027data_api\u0027,"},{"line_number":106,"context_line":"               default\u003d\u0027glance.db.sqlalchemy.api\u0027,"},{"line_number":107,"context_line":"               help\u003d_(\"\"\""},{"line_number":108,"context_line":"Python module path of data access API."},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_f7b08345","line":106,"in_reply_to":"3ac371cc_163c48c7","updated":"2016-08-16 15:10:05.000000000","message":"Thanks, will add.","commit_id":"548df29ae560017884b2953fe7111bce6b565c1a"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"262e50cef5bd3a8336a917f6a24714d316c6d69c","unresolved":false,"context_lines":[{"line_number":103,"context_line":"               help\u003d_(\u0027Maximum number of locations allowed on an image. \u0027"},{"line_number":104,"context_line":"                      \u0027Negative values evaluate to unlimited.\u0027)),"},{"line_number":105,"context_line":"    cfg.StrOpt(\u0027data_api\u0027,"},{"line_number":106,"context_line":"               default\u003d\u0027glance.db.sqlalchemy.api\u0027,"},{"line_number":107,"context_line":"               help\u003d_(\"\"\""},{"line_number":108,"context_line":"Python module path of data access API."},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_4d8c6a35","line":106,"in_reply_to":"3ac371cc_f7b08345","updated":"2016-08-16 15:15:29.000000000","message":"As Brian said, if we are to restrict the operator to these 3 values, we can add a `choices` argument for them.","commit_id":"548df29ae560017884b2953fe7111bce6b565c1a"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"d093d1f653a203eaeb2b4604817baaeac8bdc690","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                      \u0027Negative values evaluate to unlimited.\u0027)),"},{"line_number":105,"context_line":"    cfg.StrOpt(\u0027data_api\u0027,"},{"line_number":106,"context_line":"               default\u003d\u0027glance.db.sqlalchemy.api\u0027,"},{"line_number":107,"context_line":"               choices\u003d(\u0027glance.db.sqlalchemy.api\u0027,"},{"line_number":108,"context_line":"                        \u0027glance.db.registry.api\u0027,"},{"line_number":109,"context_line":"                        \u0027glance.db.simple.api\u0027),"},{"line_number":110,"context_line":"               help\u003d_(\"\"\""},{"line_number":111,"context_line":"Python module path of data access API."},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_7dc29735","line":109,"range":{"start_line":107,"start_character":14,"end_line":109,"end_character":48},"updated":"2016-08-29 18:55:33.000000000","message":"How about we drop this?\nI think we solve this problem in the next cycle.\nLet\u0027s document this in a bug report and move ahead with merging this for now.\n\nSince the values are already mentioned in the possible values sections, operators would know what they should be configuring this to and why. The other option really doesn\u0027t impact the operators in any way. So, let\u0027s ahead with this for now?","commit_id":"ba5de4d7d4426f59e67c53fd8b40d39e066bb479"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"28e10ad03755674177cf7736229c8d7696f5615f","unresolved":false,"context_lines":[{"line_number":141,"context_line":"Python module path of data access API."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Specifies the path to the API to use for accessing the data model."},{"line_number":144,"context_line":"This option determines how the image catalog database is accessed."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Possible values:"},{"line_number":147,"context_line":"    * glance.db.sqlalchemy.api"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa7ab95a_2e945041","line":144,"range":{"start_line":144,"start_character":45,"end_line":144,"end_character":53},"updated":"2016-08-29 20:42:19.000000000","message":"\"data\"\nIt may not necessarily be a database. In the case of simple API, it is just an in-memory data structure.","commit_id":"83101de1e1b1160c3001b8a09252bdbc4e2ae740"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"de8893a0464381f888d8561508f60890b75a7585","unresolved":false,"context_lines":[{"line_number":141,"context_line":"Python module path of data access API."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Specifies the path to the API to use for accessing the data model."},{"line_number":144,"context_line":"This option determines how the image catalog database is accessed."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Possible values:"},{"line_number":147,"context_line":"    * glance.db.sqlalchemy.api"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa7ab95a_8946364d","line":144,"range":{"start_line":144,"start_character":45,"end_line":144,"end_character":53},"in_reply_to":"fa7ab95a_2e945041","updated":"2016-08-29 20:47:38.000000000","message":"Done","commit_id":"83101de1e1b1160c3001b8a09252bdbc4e2ae740"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"28e10ad03755674177cf7736229c8d7696f5615f","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    * glance.db.simple.api"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"If this option is set to ``glance.db.sqlalchemy.api`` then the"},{"line_number":152,"context_line":"the database will be accessed using the Python SQL toolkit."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"Setting this option to ``glance.db.registry.api`` will force all"},{"line_number":155,"context_line":"database access requests to be routed through the Registry layer"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa7ab95a_aebce0bb","line":152,"range":{"start_line":152,"start_character":0,"end_line":152,"end_character":59},"updated":"2016-08-29 20:42:19.000000000","message":"image catalog data is stored in and read from the database via the SQLAlchemy ORM.","commit_id":"83101de1e1b1160c3001b8a09252bdbc4e2ae740"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"de8893a0464381f888d8561508f60890b75a7585","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    * glance.db.simple.api"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"If this option is set to ``glance.db.sqlalchemy.api`` then the"},{"line_number":152,"context_line":"the database will be accessed using the Python SQL toolkit."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"Setting this option to ``glance.db.registry.api`` will force all"},{"line_number":155,"context_line":"database access requests to be routed through the Registry layer"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa7ab95a_69b7323a","line":152,"range":{"start_line":152,"start_character":0,"end_line":152,"end_character":59},"in_reply_to":"fa7ab95a_aebce0bb","updated":"2016-08-29 20:47:38.000000000","message":"Done","commit_id":"83101de1e1b1160c3001b8a09252bdbc4e2ae740"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"28e10ad03755674177cf7736229c8d7696f5615f","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"Setting this option to ``glance.db.registry.api`` will force all"},{"line_number":155,"context_line":"database access requests to be routed through the Registry layer"},{"line_number":156,"context_line":"which runs as a separate service and is used for secure"},{"line_number":157,"context_line":"communication."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"NOTE: In v2 OpenStack Images API, the registry service is optional."},{"line_number":160,"context_line":"In order to use the Registry API in v2, the option"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa7ab95a_8eef1c86","line":157,"range":{"start_line":156,"start_character":33,"end_line":157,"end_character":14},"updated":"2016-08-29 20:42:19.000000000","message":"How about we replace this with the following:\nThe Registry service may in turn use the sqlalchemy or simple API to access data. This is primarily used to avoid database access from the Glance API nodes for an added layer of security and scalability.","commit_id":"83101de1e1b1160c3001b8a09252bdbc4e2ae740"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"de8893a0464381f888d8561508f60890b75a7585","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"Setting this option to ``glance.db.registry.api`` will force all"},{"line_number":155,"context_line":"database access requests to be routed through the Registry layer"},{"line_number":156,"context_line":"which runs as a separate service and is used for secure"},{"line_number":157,"context_line":"communication."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"NOTE: In v2 OpenStack Images API, the registry service is optional."},{"line_number":160,"context_line":"In order to use the Registry API in v2, the option"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa7ab95a_49950e85","line":157,"range":{"start_line":156,"start_character":33,"end_line":157,"end_character":14},"in_reply_to":"fa7ab95a_8eef1c86","updated":"2016-08-29 20:47:38.000000000","message":"Done","commit_id":"83101de1e1b1160c3001b8a09252bdbc4e2ae740"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"28e10ad03755674177cf7736229c8d7696f5615f","unresolved":false,"context_lines":[{"line_number":160,"context_line":"In order to use the Registry API in v2, the option"},{"line_number":161,"context_line":"``enable_v2_registry`` must be set to ``True``."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Finally, to use the simple API for data access, set the value of"},{"line_number":164,"context_line":"this option to ``glance.db.simple.api``."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Related options:"},{"line_number":167,"context_line":"    * enable_v2_api"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa7ab95a_ae506033","line":164,"range":{"start_line":163,"start_character":0,"end_line":164,"end_character":40},"updated":"2016-08-29 20:42:19.000000000","message":"How about this:\nFinally, when this configuration option is set to ``glance.db.simple.api``, image catalog data is stored in and read from an in-memory data structure. This is primarily used for testing needs.","commit_id":"83101de1e1b1160c3001b8a09252bdbc4e2ae740"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"de8893a0464381f888d8561508f60890b75a7585","unresolved":false,"context_lines":[{"line_number":160,"context_line":"In order to use the Registry API in v2, the option"},{"line_number":161,"context_line":"``enable_v2_registry`` must be set to ``True``."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Finally, to use the simple API for data access, set the value of"},{"line_number":164,"context_line":"this option to ``glance.db.simple.api``."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Related options:"},{"line_number":167,"context_line":"    * enable_v2_api"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa7ab95a_e93ee289","line":164,"range":{"start_line":163,"start_character":0,"end_line":164,"end_character":40},"in_reply_to":"fa7ab95a_ae506033","updated":"2016-08-29 20:47:38.000000000","message":"Done","commit_id":"83101de1e1b1160c3001b8a09252bdbc4e2ae740"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"4c56fbc652a68b47a818316b187c20fbbcc77be7","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"\"\"\")),"},{"line_number":138,"context_line":"    # TODO(abashmak): Add choices parameter to this option:"},{"line_number":139,"context_line":"    # choices(\u0027glance.db.sqlalchemy.api\u0027,"},{"line_number":140,"context_line":"    #         \u0027glance.db.registry.api\u0027,"},{"line_number":141,"context_line":"    #         \u0027glance.db.simple.api\u0027)"},{"line_number":142,"context_line":"    # This will require a fix to the functional tests which"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa7ab95a_6972397e","line":139,"updated":"2016-08-31 20:28:24.000000000","message":"when we make this improvement, we should consider creating aliases like simple, sqlalchemy, registry for the choices shown -- as asking the operators to specify the entire namespace is rather unfriendly.","commit_id":"5bbaf6223a7c4543e30b18c3549fd523ce0db0c3"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"813beb87476781747f254943a71d93d0f5df7729","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"\"\"\")),"},{"line_number":138,"context_line":"    # TODO(abashmak): Add choices parameter to this option:"},{"line_number":139,"context_line":"    # choices(\u0027glance.db.sqlalchemy.api\u0027,"},{"line_number":140,"context_line":"    #         \u0027glance.db.registry.api\u0027,"},{"line_number":141,"context_line":"    #         \u0027glance.db.simple.api\u0027)"},{"line_number":142,"context_line":"    # This will require a fix to the functional tests which"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa7ab95a_34b088dd","line":139,"in_reply_to":"fa7ab95a_6972397e","updated":"2016-08-31 20:51:24.000000000","message":"I had a similar thought, but never voiced out loud. I\u0027ll update TODO text to say that.","commit_id":"5bbaf6223a7c4543e30b18c3549fd523ce0db0c3"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"4c56fbc652a68b47a818316b187c20fbbcc77be7","unresolved":false,"context_lines":[{"line_number":151,"context_line":"Python module path of data access API."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Specifies the path to the API to use for accessing the data model."},{"line_number":154,"context_line":"This option determines how the image catalog data is accessed."},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"Possible values:"},{"line_number":157,"context_line":"    * glance.db.sqlalchemy.api"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa7ab95a_89f4ddcf","line":154,"range":{"start_line":154,"start_character":50,"end_line":154,"end_character":52},"updated":"2016-08-31 20:28:24.000000000","message":"s/is/will be\n\nbecause you used the word determines","commit_id":"5bbaf6223a7c4543e30b18c3549fd523ce0db0c3"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"813beb87476781747f254943a71d93d0f5df7729","unresolved":false,"context_lines":[{"line_number":151,"context_line":"Python module path of data access API."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Specifies the path to the API to use for accessing the data model."},{"line_number":154,"context_line":"This option determines how the image catalog data is accessed."},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"Possible values:"},{"line_number":157,"context_line":"    * glance.db.sqlalchemy.api"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa7ab95a_54b34ce9","line":154,"range":{"start_line":154,"start_character":50,"end_line":154,"end_character":52},"in_reply_to":"fa7ab95a_89f4ddcf","updated":"2016-08-31 20:51:24.000000000","message":"Done","commit_id":"5bbaf6223a7c4543e30b18c3549fd523ce0db0c3"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"4c56fbc652a68b47a818316b187c20fbbcc77be7","unresolved":false,"context_lines":[{"line_number":163,"context_line":"SQLAlchemy Core and ORM APIs."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Setting this option to ``glance.db.registry.api`` will force all"},{"line_number":166,"context_line":"database access requests to be routed through the Registry layer"},{"line_number":167,"context_line":"which runs as a separate service. The Registry service may in turn"},{"line_number":168,"context_line":"use the sqlalchemy or simple API to access data. This is primarily"},{"line_number":169,"context_line":"used to avoid data access from the Glance API nodes for an added"},{"line_number":170,"context_line":"layer of security and scalability."}],"source_content_type":"text/x-python","patch_set":10,"id":"fa7ab95a_098b6d1f","line":167,"range":{"start_line":166,"start_character":59,"end_line":167,"end_character":32},"updated":"2016-08-31 20:28:24.000000000","message":"\"Registry service\" is good enough\n\nspecifying layer in this sentence isn\u0027t necessary for the operators","commit_id":"5bbaf6223a7c4543e30b18c3549fd523ce0db0c3"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"4c56fbc652a68b47a818316b187c20fbbcc77be7","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Setting this option to ``glance.db.registry.api`` will force all"},{"line_number":166,"context_line":"database access requests to be routed through the Registry layer"},{"line_number":167,"context_line":"which runs as a separate service. The Registry service may in turn"},{"line_number":168,"context_line":"use the sqlalchemy or simple API to access data. This is primarily"},{"line_number":169,"context_line":"used to avoid data access from the Glance API nodes for an added"},{"line_number":170,"context_line":"layer of security and scalability."}],"source_content_type":"text/x-python","patch_set":10,"id":"fa7ab95a_2982f100","line":167,"range":{"start_line":167,"start_character":34,"end_line":167,"end_character":54},"updated":"2016-08-31 20:28:24.000000000","message":"s/The Registry service/It/","commit_id":"5bbaf6223a7c4543e30b18c3549fd523ce0db0c3"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"285adb7610d8482e5be6a551758eb6e84c288eff","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Setting this option to ``glance.db.registry.api`` will force all"},{"line_number":166,"context_line":"database access requests to be routed through the Registry layer"},{"line_number":167,"context_line":"which runs as a separate service. The Registry service may in turn"},{"line_number":168,"context_line":"use the sqlalchemy or simple API to access data. This is primarily"},{"line_number":169,"context_line":"used to avoid data access from the Glance API nodes for an added"},{"line_number":170,"context_line":"layer of security and scalability."}],"source_content_type":"text/x-python","patch_set":10,"id":"fa7ab95a_89abfd1d","line":167,"range":{"start_line":167,"start_character":34,"end_line":167,"end_character":54},"in_reply_to":"fa7ab95a_2982f100","updated":"2016-08-31 20:39:49.000000000","message":"I agree, it\u0027s probably a bit too much detail","commit_id":"5bbaf6223a7c4543e30b18c3549fd523ce0db0c3"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1a27affe1e866a0d43d7e5189f80aac3dcce9a6a","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Setting this option to ``glance.db.registry.api`` will force all"},{"line_number":166,"context_line":"database access requests to be routed through the Registry layer"},{"line_number":167,"context_line":"which runs as a separate service. The Registry service may in turn"},{"line_number":168,"context_line":"use the sqlalchemy or simple API to access data. This is primarily"},{"line_number":169,"context_line":"used to avoid data access from the Glance API nodes for an added"},{"line_number":170,"context_line":"layer of security and scalability."}],"source_content_type":"text/x-python","patch_set":10,"id":"fa7ab95a_cf2fc586","line":167,"range":{"start_line":167,"start_character":34,"end_line":167,"end_character":54},"in_reply_to":"fa7ab95a_54018c69","updated":"2016-08-31 21:02:04.000000000","message":"@Alex: I think your proposal makes sense.","commit_id":"5bbaf6223a7c4543e30b18c3549fd523ce0db0c3"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"5a95b74624bb283a325e37a33ccf6dcaeb5831ec","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Setting this option to ``glance.db.registry.api`` will force all"},{"line_number":166,"context_line":"database access requests to be routed through the Registry layer"},{"line_number":167,"context_line":"which runs as a separate service. The Registry service may in turn"},{"line_number":168,"context_line":"use the sqlalchemy or simple API to access data. This is primarily"},{"line_number":169,"context_line":"used to avoid data access from the Glance API nodes for an added"},{"line_number":170,"context_line":"layer of security and scalability."}],"source_content_type":"text/x-python","patch_set":10,"id":"fa7ab95a_af1d2168","line":167,"range":{"start_line":167,"start_character":34,"end_line":167,"end_character":54},"in_reply_to":"fa7ab95a_54018c69","updated":"2016-08-31 21:01:03.000000000","message":"works for me","commit_id":"5bbaf6223a7c4543e30b18c3549fd523ce0db0c3"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"813beb87476781747f254943a71d93d0f5df7729","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Setting this option to ``glance.db.registry.api`` will force all"},{"line_number":166,"context_line":"database access requests to be routed through the Registry layer"},{"line_number":167,"context_line":"which runs as a separate service. The Registry service may in turn"},{"line_number":168,"context_line":"use the sqlalchemy or simple API to access data. This is primarily"},{"line_number":169,"context_line":"used to avoid data access from the Glance API nodes for an added"},{"line_number":170,"context_line":"layer of security and scalability."}],"source_content_type":"text/x-python","patch_set":10,"id":"fa7ab95a_54018c69","line":167,"range":{"start_line":167,"start_character":34,"end_line":167,"end_character":54},"in_reply_to":"fa7ab95a_89abfd1d","updated":"2016-08-31 20:51:24.000000000","message":"Should I just remove the sentence starting with \"The Registry service may in turn...\" ?","commit_id":"5bbaf6223a7c4543e30b18c3549fd523ce0db0c3"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"4c56fbc652a68b47a818316b187c20fbbcc77be7","unresolved":false,"context_lines":[{"line_number":167,"context_line":"which runs as a separate service. The Registry service may in turn"},{"line_number":168,"context_line":"use the sqlalchemy or simple API to access data. This is primarily"},{"line_number":169,"context_line":"used to avoid data access from the Glance API nodes for an added"},{"line_number":170,"context_line":"layer of security and scalability."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"NOTE: In v2 OpenStack Images API, the registry service is optional."},{"line_number":173,"context_line":"In order to use the Registry API in v2, the option"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa7ab95a_899e9d52","line":170,"updated":"2016-08-31 20:28:24.000000000","message":"manageability too as some operators use it during uploads","commit_id":"5bbaf6223a7c4543e30b18c3549fd523ce0db0c3"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"5a95b74624bb283a325e37a33ccf6dcaeb5831ec","unresolved":false,"context_lines":[{"line_number":167,"context_line":"which runs as a separate service. The Registry service may in turn"},{"line_number":168,"context_line":"use the sqlalchemy or simple API to access data. This is primarily"},{"line_number":169,"context_line":"used to avoid data access from the Glance API nodes for an added"},{"line_number":170,"context_line":"layer of security and scalability."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"NOTE: In v2 OpenStack Images API, the registry service is optional."},{"line_number":173,"context_line":"In order to use the Registry API in v2, the option"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa7ab95a_ef2569ae","line":170,"in_reply_to":"fa7ab95a_296d9104","updated":"2016-08-31 21:01:03.000000000","message":"ans given there","commit_id":"5bbaf6223a7c4543e30b18c3549fd523ce0db0c3"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"285adb7610d8482e5be6a551758eb6e84c288eff","unresolved":false,"context_lines":[{"line_number":167,"context_line":"which runs as a separate service. The Registry service may in turn"},{"line_number":168,"context_line":"use the sqlalchemy or simple API to access data. This is primarily"},{"line_number":169,"context_line":"used to avoid data access from the Glance API nodes for an added"},{"line_number":170,"context_line":"layer of security and scalability."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"NOTE: In v2 OpenStack Images API, the registry service is optional."},{"line_number":173,"context_line":"In order to use the Registry API in v2, the option"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa7ab95a_296d9104","line":170,"in_reply_to":"fa7ab95a_899e9d52","updated":"2016-08-31 20:39:49.000000000","message":"Curious about this, but will ask in openstack-glance channel","commit_id":"5bbaf6223a7c4543e30b18c3549fd523ce0db0c3"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"292f1907d01163bd22bc064fa73686a83f3c9b01","unresolved":false,"context_lines":[{"line_number":163,"context_line":"SQLAlchemy Core and ORM APIs."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Setting this option to ``glance.db.registry.api`` will force all"},{"line_number":166,"context_line":"database access requests to be routed through the Registry service."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"NOTE: In v2 OpenStack Images API, the registry service is optional."},{"line_number":169,"context_line":"In order to use the Registry API in v2, the option"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa7ab95a_08b7ddf5","line":166,"updated":"2016-09-01 01:27:52.000000000","message":"Ummm ... you removed two sentences.  I thought you were going to leave the one reading, \"This is primarily used to avoid direct data access from the Glance API nodes for an added layer of security, manageability, and scalability.\"  On the other hand, that makes the Registry sound really useful, and there\u0027s a move afoot to get rid of it, so maybe we should leave it out.  I\u0027m not sure, am open to suggestions.","commit_id":"ed01c0c448ddb4863740cd5d16cea18e92c5a94c"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"c96c3af2d02310dbf4beb2cc51c7b916b033f102","unresolved":false,"context_lines":[{"line_number":163,"context_line":"SQLAlchemy Core and ORM APIs."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Setting this option to ``glance.db.registry.api`` will force all"},{"line_number":166,"context_line":"database access requests to be routed through the Registry service."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"NOTE: In v2 OpenStack Images API, the registry service is optional."},{"line_number":169,"context_line":"In order to use the Registry API in v2, the option"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa7ab95a_4ecc8d61","line":166,"in_reply_to":"fa7ab95a_08b7ddf5","updated":"2016-09-01 02:47:39.000000000","message":"I think that statement about the registry is true irrespective of our decision to get rid of registry. And, looks like we maybe getting rid of the registry knowing that it could be a useful thing to some. Or maybe the usefulness is all theoretical and doesn\u0027t necessarily translate to practical gains.\n\nI\u0027d like to retain that line about the registry, in short.","commit_id":"ed01c0c448ddb4863740cd5d16cea18e92c5a94c"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"cfc8b62fb4147956e890f94a361a65cd2fd5a856","unresolved":false,"context_lines":[{"line_number":165,"context_line":"Setting this option to ``glance.db.registry.api`` will force all"},{"line_number":166,"context_line":"database access requests to be routed through the Registry service."},{"line_number":167,"context_line":"This avoids data access from the Glance API nodes for an added layer"},{"line_number":168,"context_line":"of security and scalability."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"NOTE: In v2 OpenStack Images API, the registry service is optional."},{"line_number":171,"context_line":"In order to use the Registry API in v2, the option"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa7ab95a_11a2a84b","line":168,"range":{"start_line":168,"start_character":3,"end_line":168,"end_character":27},"updated":"2016-09-01 03:32:23.000000000","message":"security, scalability and manageability.","commit_id":"56082145ef9d0eaf1aff27e906e7d3e053355c9a"}]}