)]}'
{"doc/source/contributing/refreshing-configs.rst":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"a7371189ed6c25c945ac88f6955be6e3a3548f1f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"      License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"      under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Guideline On Refreshing Config files under etc/"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"During a release cycle many config options are changed or updated. The sample"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_716eb197","line":17,"range":{"start_line":17,"start_character":24,"end_line":17,"end_character":30},"updated":"2016-08-12 16:47:12.000000000","message":"Configuration","commit_id":"0ed02f6a44916d3246ff7cba3171730a912ae343"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"a7371189ed6c25c945ac88f6955be6e3a3548f1f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"      License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"      under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Guideline On Refreshing Config files under etc/"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"During a release cycle many config options are changed or updated. The sample"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_b1682989","line":17,"range":{"start_line":17,"start_character":31,"end_line":17,"end_character":32},"updated":"2016-08-12 16:47:12.000000000","message":"F","commit_id":"0ed02f6a44916d3246ff7cba3171730a912ae343"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"a7371189ed6c25c945ac88f6955be6e3a3548f1f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"      License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"      under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Guideline On Refreshing Config files under etc/"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"During a release cycle many config options are changed or updated. The sample"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_3113990f","line":17,"range":{"start_line":17,"start_character":37,"end_line":17,"end_character":38},"updated":"2016-08-12 16:47:12.000000000","message":"U","commit_id":"0ed02f6a44916d3246ff7cba3171730a912ae343"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"d842edf0d9c7fea23e3e987d5c6c657cd9a4ff84","unresolved":false,"context_lines":[{"line_number":14,"context_line":"      License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"      under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Guideline On Refreshing Config files under etc/"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"During a release cycle many config options are changed or updated. The sample"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_afa27898","line":17,"range":{"start_line":17,"start_character":37,"end_line":17,"end_character":38},"in_reply_to":"9ad45d7e_3113990f","updated":"2016-08-12 20:17:11.000000000","message":"Done","commit_id":"0ed02f6a44916d3246ff7cba3171730a912ae343"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"d842edf0d9c7fea23e3e987d5c6c657cd9a4ff84","unresolved":false,"context_lines":[{"line_number":14,"context_line":"      License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"      under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Guideline On Refreshing Config files under etc/"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"During a release cycle many config options are changed or updated. The sample"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_8f9fb44f","line":17,"range":{"start_line":17,"start_character":24,"end_line":17,"end_character":30},"in_reply_to":"9ad45d7e_716eb197","updated":"2016-08-12 20:17:11.000000000","message":"Done","commit_id":"0ed02f6a44916d3246ff7cba3171730a912ae343"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"d842edf0d9c7fea23e3e987d5c6c657cd9a4ff84","unresolved":false,"context_lines":[{"line_number":14,"context_line":"      License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"      under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Guideline On Refreshing Config files under etc/"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"During a release cycle many config options are changed or updated. The sample"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_efac708e","line":17,"range":{"start_line":17,"start_character":31,"end_line":17,"end_character":32},"in_reply_to":"9ad45d7e_b1682989","updated":"2016-08-12 20:17:11.000000000","message":"Done","commit_id":"0ed02f6a44916d3246ff7cba3171730a912ae343"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"a7371189ed6c25c945ac88f6955be6e3a3548f1f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Guideline On Refreshing Config files under etc/"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"During a release cycle many config options are changed or updated. The sample"},{"line_number":21,"context_line":"config files provided in tree (under ``etc/*``) need to be updated using the"},{"line_number":22,"context_line":"autogeneration tool as these files are being used in different places. Some"},{"line_number":23,"context_line":"examples are devstack gates, downstream packagers shipping with the same (or"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_ac30d0e9","line":20,"range":{"start_line":20,"start_character":28,"end_line":20,"end_character":34},"updated":"2016-08-12 16:47:12.000000000","message":"configuration","commit_id":"0ed02f6a44916d3246ff7cba3171730a912ae343"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"d842edf0d9c7fea23e3e987d5c6c657cd9a4ff84","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Guideline On Refreshing Config files under etc/"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"During a release cycle many config options are changed or updated. The sample"},{"line_number":21,"context_line":"config files provided in tree (under ``etc/*``) need to be updated using the"},{"line_number":22,"context_line":"autogeneration tool as these files are being used in different places. Some"},{"line_number":23,"context_line":"examples are devstack gates, downstream packagers shipping with the same (or"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_ef4d90c5","line":20,"range":{"start_line":20,"start_character":28,"end_line":20,"end_character":34},"in_reply_to":"9ad45d7e_ac30d0e9","updated":"2016-08-12 20:17:11.000000000","message":"Done","commit_id":"0ed02f6a44916d3246ff7cba3171730a912ae343"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"a7371189ed6c25c945ac88f6955be6e3a3548f1f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"During a release cycle many config options are changed or updated. The sample"},{"line_number":21,"context_line":"config files provided in tree (under ``etc/*``) need to be updated using the"},{"line_number":22,"context_line":"autogeneration tool as these files are being used in different places. Some"},{"line_number":23,"context_line":"examples are devstack gates, downstream packagers shipping with the same (or"},{"line_number":24,"context_line":"using defaults from these files), etc. Hence, before we cut a release we need"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_0c4c7c75","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":6},"updated":"2016-08-12 16:47:12.000000000","message":"configuration","commit_id":"0ed02f6a44916d3246ff7cba3171730a912ae343"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"d842edf0d9c7fea23e3e987d5c6c657cd9a4ff84","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"During a release cycle many config options are changed or updated. The sample"},{"line_number":21,"context_line":"config files provided in tree (under ``etc/*``) need to be updated using the"},{"line_number":22,"context_line":"autogeneration tool as these files are being used in different places. Some"},{"line_number":23,"context_line":"examples are devstack gates, downstream packagers shipping with the same (or"},{"line_number":24,"context_line":"using defaults from these files), etc. Hence, before we cut a release we need"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_2fc68816","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":6},"in_reply_to":"9ad45d7e_0c4c7c75","updated":"2016-08-12 20:17:11.000000000","message":"Done","commit_id":"0ed02f6a44916d3246ff7cba3171730a912ae343"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"a7371189ed6c25c945ac88f6955be6e3a3548f1f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"autogeneration tool as these files are being used in different places. Some"},{"line_number":23,"context_line":"examples are devstack gates, downstream packagers shipping with the same (or"},{"line_number":24,"context_line":"using defaults from these files), etc. Hence, before we cut a release we need"},{"line_number":25,"context_line":"to refresh the config files shipped with tree to match the changes done in the"},{"line_number":26,"context_line":"source code during the release cycle."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"In an ideal world, every review that proposes a addition, removal or updated to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_0c73dcb5","line":25,"range":{"start_line":25,"start_character":15,"end_line":25,"end_character":21},"updated":"2016-08-12 16:47:12.000000000","message":"configuration","commit_id":"0ed02f6a44916d3246ff7cba3171730a912ae343"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"d842edf0d9c7fea23e3e987d5c6c657cd9a4ff84","unresolved":false,"context_lines":[{"line_number":22,"context_line":"autogeneration tool as these files are being used in different places. Some"},{"line_number":23,"context_line":"examples are devstack gates, downstream packagers shipping with the same (or"},{"line_number":24,"context_line":"using defaults from these files), etc. Hence, before we cut a release we need"},{"line_number":25,"context_line":"to refresh the config files shipped with tree to match the changes done in the"},{"line_number":26,"context_line":"source code during the release cycle."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"In an ideal world, every review that proposes a addition, removal or updated to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_6fd080ca","line":25,"range":{"start_line":25,"start_character":15,"end_line":25,"end_character":21},"in_reply_to":"9ad45d7e_0c73dcb5","updated":"2016-08-12 20:17:11.000000000","message":"Done","commit_id":"0ed02f6a44916d3246ff7cba3171730a912ae343"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"a7371189ed6c25c945ac88f6955be6e3a3548f1f","unresolved":false,"context_lines":[{"line_number":25,"context_line":"to refresh the config files shipped with tree to match the changes done in the"},{"line_number":26,"context_line":"source code during the release cycle."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"In an ideal world, every review that proposes a addition, removal or updated to"},{"line_number":29,"context_line":"a config option should use the tox tool to refresh only the configs they have"},{"line_number":30,"context_line":"changed. However, many of the configuration options like those coming from"},{"line_number":31,"context_line":"oslo.messaging, oslo_middleware, etc. may have changed in the meantime. So,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_31b439d0","line":28,"range":{"start_line":28,"start_character":69,"end_line":28,"end_character":76},"updated":"2016-08-12 16:47:12.000000000","message":"update","commit_id":"0ed02f6a44916d3246ff7cba3171730a912ae343"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"d842edf0d9c7fea23e3e987d5c6c657cd9a4ff84","unresolved":false,"context_lines":[{"line_number":25,"context_line":"to refresh the config files shipped with tree to match the changes done in the"},{"line_number":26,"context_line":"source code during the release cycle."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"In an ideal world, every review that proposes a addition, removal or updated to"},{"line_number":29,"context_line":"a config option should use the tox tool to refresh only the configs they have"},{"line_number":30,"context_line":"changed. However, many of the configuration options like those coming from"},{"line_number":31,"context_line":"oslo.messaging, oslo_middleware, etc. may have changed in the meantime. So,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_4fd5bcb7","line":28,"range":{"start_line":28,"start_character":69,"end_line":28,"end_character":76},"in_reply_to":"9ad45d7e_31b439d0","updated":"2016-08-12 20:17:11.000000000","message":"Done","commit_id":"0ed02f6a44916d3246ff7cba3171730a912ae343"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"a7371189ed6c25c945ac88f6955be6e3a3548f1f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"source code during the release cycle."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"In an ideal world, every review that proposes a addition, removal or updated to"},{"line_number":29,"context_line":"a config option should use the tox tool to refresh only the configs they have"},{"line_number":30,"context_line":"changed. However, many of the configuration options like those coming from"},{"line_number":31,"context_line":"oslo.messaging, oslo_middleware, etc. may have changed in the meantime. So,"},{"line_number":32,"context_line":"whenever someone uses the tool to autogenerate the configs based on the options"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_f1e0e1ce","line":29,"range":{"start_line":29,"start_character":2,"end_line":29,"end_character":8},"updated":"2016-08-12 16:47:12.000000000","message":"configuration","commit_id":"0ed02f6a44916d3246ff7cba3171730a912ae343"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"a7371189ed6c25c945ac88f6955be6e3a3548f1f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"source code during the release cycle."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"In an ideal world, every review that proposes a addition, removal or updated to"},{"line_number":29,"context_line":"a config option should use the tox tool to refresh only the configs they have"},{"line_number":30,"context_line":"changed. However, many of the configuration options like those coming from"},{"line_number":31,"context_line":"oslo.messaging, oslo_middleware, etc. may have changed in the meantime. So,"},{"line_number":32,"context_line":"whenever someone uses the tool to autogenerate the configs based on the options"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_b1d789ec","line":29,"range":{"start_line":29,"start_character":60,"end_line":29,"end_character":67},"updated":"2016-08-12 16:47:12.000000000","message":"configuration options","commit_id":"0ed02f6a44916d3246ff7cba3171730a912ae343"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"d842edf0d9c7fea23e3e987d5c6c657cd9a4ff84","unresolved":false,"context_lines":[{"line_number":26,"context_line":"source code during the release cycle."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"In an ideal world, every review that proposes a addition, removal or updated to"},{"line_number":29,"context_line":"a config option should use the tox tool to refresh only the configs they have"},{"line_number":30,"context_line":"changed. However, many of the configuration options like those coming from"},{"line_number":31,"context_line":"oslo.messaging, oslo_middleware, etc. may have changed in the meantime. So,"},{"line_number":32,"context_line":"whenever someone uses the tool to autogenerate the configs based on the options"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_4fec9c8f","line":29,"range":{"start_line":29,"start_character":60,"end_line":29,"end_character":67},"in_reply_to":"9ad45d7e_b1d789ec","updated":"2016-08-12 20:17:11.000000000","message":"I changed it to \"configuration option\" (singular)","commit_id":"0ed02f6a44916d3246ff7cba3171730a912ae343"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"d842edf0d9c7fea23e3e987d5c6c657cd9a4ff84","unresolved":false,"context_lines":[{"line_number":26,"context_line":"source code during the release cycle."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"In an ideal world, every review that proposes a addition, removal or updated to"},{"line_number":29,"context_line":"a config option should use the tox tool to refresh only the configs they have"},{"line_number":30,"context_line":"changed. However, many of the configuration options like those coming from"},{"line_number":31,"context_line":"oslo.messaging, oslo_middleware, etc. may have changed in the meantime. So,"},{"line_number":32,"context_line":"whenever someone uses the tool to autogenerate the configs based on the options"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_af88b8c7","line":29,"range":{"start_line":29,"start_character":2,"end_line":29,"end_character":8},"in_reply_to":"9ad45d7e_f1e0e1ce","updated":"2016-08-12 20:17:11.000000000","message":"Done","commit_id":"0ed02f6a44916d3246ff7cba3171730a912ae343"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"a7371189ed6c25c945ac88f6955be6e3a3548f1f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"a config option should use the tox tool to refresh only the configs they have"},{"line_number":30,"context_line":"changed. However, many of the configuration options like those coming from"},{"line_number":31,"context_line":"oslo.messaging, oslo_middleware, etc. may have changed in the meantime. So,"},{"line_number":32,"context_line":"whenever someone uses the tool to autogenerate the configs based on the options"},{"line_number":33,"context_line":"in tree, there are more changes than those made just by the author."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"We do not recommend the authors to manually edit the autogenerated files so, a"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_6c9258a1","line":32,"range":{"start_line":32,"start_character":51,"end_line":32,"end_character":58},"updated":"2016-08-12 16:47:12.000000000","message":"configuration files","commit_id":"0ed02f6a44916d3246ff7cba3171730a912ae343"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"d842edf0d9c7fea23e3e987d5c6c657cd9a4ff84","unresolved":false,"context_lines":[{"line_number":29,"context_line":"a config option should use the tox tool to refresh only the configs they have"},{"line_number":30,"context_line":"changed. However, many of the configuration options like those coming from"},{"line_number":31,"context_line":"oslo.messaging, oslo_middleware, etc. may have changed in the meantime. So,"},{"line_number":32,"context_line":"whenever someone uses the tool to autogenerate the configs based on the options"},{"line_number":33,"context_line":"in tree, there are more changes than those made just by the author."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"We do not recommend the authors to manually edit the autogenerated files so, a"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_6fb5207d","line":32,"range":{"start_line":32,"start_character":51,"end_line":32,"end_character":58},"in_reply_to":"9ad45d7e_6c9258a1","updated":"2016-08-12 20:17:11.000000000","message":"Done","commit_id":"0ed02f6a44916d3246ff7cba3171730a912ae343"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"a7371189ed6c25c945ac88f6955be6e3a3548f1f","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    $ tox -e genconfig"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"When To Refresh The Sample Configs"},{"line_number":44,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* Ideally reviewers should request update to configs for each change that may"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_5143ad6c","line":43,"range":{"start_line":43,"start_character":27,"end_line":43,"end_character":34},"updated":"2016-08-12 16:47:12.000000000","message":"Configuration Files","commit_id":"0ed02f6a44916d3246ff7cba3171730a912ae343"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"d842edf0d9c7fea23e3e987d5c6c657cd9a4ff84","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    $ tox -e genconfig"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"When To Refresh The Sample Configs"},{"line_number":44,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* Ideally reviewers should request update to configs for each change that may"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_cfa6cc52","line":43,"range":{"start_line":43,"start_character":27,"end_line":43,"end_character":34},"in_reply_to":"9ad45d7e_5143ad6c","updated":"2016-08-12 20:17:11.000000000","message":"Done","commit_id":"0ed02f6a44916d3246ff7cba3171730a912ae343"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"a7371189ed6c25c945ac88f6955be6e3a3548f1f","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"When To Refresh The Sample Configs"},{"line_number":44,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* Ideally reviewers should request update to configs for each change that may"},{"line_number":47,"context_line":"  result into an update to the sample config files."},{"line_number":48,"context_line":"* In some situations however, there may be a bunch of similar changes that are"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_3171d9e1","line":45,"updated":"2016-08-12 16:47:12.000000000","message":"Is there a reason we don\u0027t mention what you said earlier about how every patch that changes a config opt should revise the sample configs as well? I think that should be the first trigger. Depending on reviewers to request for an update should only be a fallback option.\n\nAm I missing anything here?","commit_id":"0ed02f6a44916d3246ff7cba3171730a912ae343"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"d842edf0d9c7fea23e3e987d5c6c657cd9a4ff84","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"When To Refresh The Sample Configs"},{"line_number":44,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* Ideally reviewers should request update to configs for each change that may"},{"line_number":47,"context_line":"  result into an update to the sample config files."},{"line_number":48,"context_line":"* In some situations however, there may be a bunch of similar changes that are"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_8f5a144f","line":45,"in_reply_to":"9ad45d7e_3171d9e1","updated":"2016-08-12 20:17:11.000000000","message":"No, thanks for pointing out. I was under the impression that it would be considered repetition but if that\u0027s okay to be included then we should.","commit_id":"0ed02f6a44916d3246ff7cba3171730a912ae343"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"a7371189ed6c25c945ac88f6955be6e3a3548f1f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"When To Refresh The Sample Configs"},{"line_number":44,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* Ideally reviewers should request update to configs for each change that may"},{"line_number":47,"context_line":"  result into an update to the sample config files."},{"line_number":48,"context_line":"* In some situations however, there may be a bunch of similar changes that are"},{"line_number":49,"context_line":"  affecting the config files. In this case, in order to make the developers\u0027"},{"line_number":50,"context_line":"* and reviewers\u0027 effort easier, we recommend an update to the configs in bulk"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_8795e789","line":47,"range":{"start_line":46,"start_character":2,"end_line":47,"end_character":51},"updated":"2016-08-12 16:47:12.000000000","message":"How about something like this \u0027Ideally reviewers should request updates to sample configuration files for every change that attempts to add/delete/modify a configuration option in the code.\u0027 ?","commit_id":"0ed02f6a44916d3246ff7cba3171730a912ae343"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"a7371189ed6c25c945ac88f6955be6e3a3548f1f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* Ideally reviewers should request update to configs for each change that may"},{"line_number":47,"context_line":"  result into an update to the sample config files."},{"line_number":48,"context_line":"* In some situations however, there may be a bunch of similar changes that are"},{"line_number":49,"context_line":"  affecting the config files. In this case, in order to make the developers\u0027"},{"line_number":50,"context_line":"* and reviewers\u0027 effort easier, we recommend an update to the configs in bulk"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_6c3b7839","line":47,"range":{"start_line":47,"start_character":38,"end_line":47,"end_character":44},"updated":"2016-08-12 16:47:12.000000000","message":"configuration","commit_id":"0ed02f6a44916d3246ff7cba3171730a912ae343"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"d842edf0d9c7fea23e3e987d5c6c657cd9a4ff84","unresolved":false,"context_lines":[{"line_number":44,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* Ideally reviewers should request update to configs for each change that may"},{"line_number":47,"context_line":"  result into an update to the sample config files."},{"line_number":48,"context_line":"* In some situations however, there may be a bunch of similar changes that are"},{"line_number":49,"context_line":"  affecting the config files. In this case, in order to make the developers\u0027"},{"line_number":50,"context_line":"* and reviewers\u0027 effort easier, we recommend an update to the configs in bulk"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_0251db0e","line":47,"range":{"start_line":47,"start_character":38,"end_line":47,"end_character":44},"in_reply_to":"9ad45d7e_6c3b7839","updated":"2016-08-12 20:17:11.000000000","message":"Done","commit_id":"0ed02f6a44916d3246ff7cba3171730a912ae343"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"d842edf0d9c7fea23e3e987d5c6c657cd9a4ff84","unresolved":false,"context_lines":[{"line_number":43,"context_line":"When To Refresh The Sample Configs"},{"line_number":44,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* Ideally reviewers should request update to configs for each change that may"},{"line_number":47,"context_line":"  result into an update to the sample config files."},{"line_number":48,"context_line":"* In some situations however, there may be a bunch of similar changes that are"},{"line_number":49,"context_line":"  affecting the config files. In this case, in order to make the developers\u0027"},{"line_number":50,"context_line":"* and reviewers\u0027 effort easier, we recommend an update to the configs in bulk"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_224cdf75","line":47,"range":{"start_line":46,"start_character":2,"end_line":47,"end_character":51},"in_reply_to":"9ad45d7e_8795e789","updated":"2016-08-12 20:17:11.000000000","message":"Done","commit_id":"0ed02f6a44916d3246ff7cba3171730a912ae343"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"a7371189ed6c25c945ac88f6955be6e3a3548f1f","unresolved":false,"context_lines":[{"line_number":46,"context_line":"* Ideally reviewers should request update to configs for each change that may"},{"line_number":47,"context_line":"  result into an update to the sample config files."},{"line_number":48,"context_line":"* In some situations however, there may be a bunch of similar changes that are"},{"line_number":49,"context_line":"  affecting the config files. In this case, in order to make the developers\u0027"},{"line_number":50,"context_line":"* and reviewers\u0027 effort easier, we recommend an update to the configs in bulk"},{"line_number":51,"context_line":"  right after all the update changes have been made/merged."},{"line_number":52,"context_line":"* **NOTE**: All sample files mush be updated before the milestone-3 (or the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_cc76e405","line":49,"range":{"start_line":49,"start_character":16,"end_line":49,"end_character":22},"updated":"2016-08-12 16:47:12.000000000","message":"configuration","commit_id":"0ed02f6a44916d3246ff7cba3171730a912ae343"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"d842edf0d9c7fea23e3e987d5c6c657cd9a4ff84","unresolved":false,"context_lines":[{"line_number":46,"context_line":"* Ideally reviewers should request update to configs for each change that may"},{"line_number":47,"context_line":"  result into an update to the sample config files."},{"line_number":48,"context_line":"* In some situations however, there may be a bunch of similar changes that are"},{"line_number":49,"context_line":"  affecting the config files. In this case, in order to make the developers\u0027"},{"line_number":50,"context_line":"* and reviewers\u0027 effort easier, we recommend an update to the configs in bulk"},{"line_number":51,"context_line":"  right after all the update changes have been made/merged."},{"line_number":52,"context_line":"* **NOTE**: All sample files mush be updated before the milestone-3 (or the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_0278bb8e","line":49,"range":{"start_line":49,"start_character":16,"end_line":49,"end_character":22},"in_reply_to":"9ad45d7e_cc76e405","updated":"2016-08-12 20:17:11.000000000","message":"Done","commit_id":"0ed02f6a44916d3246ff7cba3171730a912ae343"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"a7371189ed6c25c945ac88f6955be6e3a3548f1f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  result into an update to the sample config files."},{"line_number":48,"context_line":"* In some situations however, there may be a bunch of similar changes that are"},{"line_number":49,"context_line":"  affecting the config files. In this case, in order to make the developers\u0027"},{"line_number":50,"context_line":"* and reviewers\u0027 effort easier, we recommend an update to the configs in bulk"},{"line_number":51,"context_line":"  right after all the update changes have been made/merged."},{"line_number":52,"context_line":"* **NOTE**: All sample files mush be updated before the milestone-3 (or the"},{"line_number":53,"context_line":"  final release) of the project."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_6c50985f","line":50,"range":{"start_line":50,"start_character":62,"end_line":50,"end_character":69},"updated":"2016-08-12 16:47:12.000000000","message":"configuration files","commit_id":"0ed02f6a44916d3246ff7cba3171730a912ae343"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"d842edf0d9c7fea23e3e987d5c6c657cd9a4ff84","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  result into an update to the sample config files."},{"line_number":48,"context_line":"* In some situations however, there may be a bunch of similar changes that are"},{"line_number":49,"context_line":"  affecting the config files. In this case, in order to make the developers\u0027"},{"line_number":50,"context_line":"* and reviewers\u0027 effort easier, we recommend an update to the configs in bulk"},{"line_number":51,"context_line":"  right after all the update changes have been made/merged."},{"line_number":52,"context_line":"* **NOTE**: All sample files mush be updated before the milestone-3 (or the"},{"line_number":53,"context_line":"  final release) of the project."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_4272b3ae","line":50,"range":{"start_line":50,"start_character":62,"end_line":50,"end_character":69},"in_reply_to":"9ad45d7e_6c50985f","updated":"2016-08-12 20:17:11.000000000","message":"Done","commit_id":"0ed02f6a44916d3246ff7cba3171730a912ae343"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"a7371189ed6c25c945ac88f6955be6e3a3548f1f","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  affecting the config files. In this case, in order to make the developers\u0027"},{"line_number":50,"context_line":"* and reviewers\u0027 effort easier, we recommend an update to the configs in bulk"},{"line_number":51,"context_line":"  right after all the update changes have been made/merged."},{"line_number":52,"context_line":"* **NOTE**: All sample files mush be updated before the milestone-3 (or the"},{"line_number":53,"context_line":"  final release) of the project."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_4cd034ca","line":52,"updated":"2016-08-12 16:47:12.000000000","message":"configuration","commit_id":"0ed02f6a44916d3246ff7cba3171730a912ae343"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"d842edf0d9c7fea23e3e987d5c6c657cd9a4ff84","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  affecting the config files. In this case, in order to make the developers\u0027"},{"line_number":50,"context_line":"* and reviewers\u0027 effort easier, we recommend an update to the configs in bulk"},{"line_number":51,"context_line":"  right after all the update changes have been made/merged."},{"line_number":52,"context_line":"* **NOTE**: All sample files mush be updated before the milestone-3 (or the"},{"line_number":53,"context_line":"  final release) of the project."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_62a41708","line":52,"in_reply_to":"9ad45d7e_4cd034ca","updated":"2016-08-12 20:17:11.000000000","message":"Done","commit_id":"0ed02f6a44916d3246ff7cba3171730a912ae343"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"6af0545fc682d2bacbf45c5acdd378f4a92e3eb1","unresolved":false,"context_lines":[{"line_number":25,"context_line":"to refresh the config files shipped with tree to match the changes done in the"},{"line_number":26,"context_line":"source code during the release cycle."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"In an ideal world, every review that proposes a addition, removal or updated to"},{"line_number":29,"context_line":"a config option should use the tox tool to refresh only the configs they have"},{"line_number":30,"context_line":"changed. However, many of the configuration options like those coming from"},{"line_number":31,"context_line":"oslo.messaging, oslo_middleware, etc. may have changed in the meantime. So,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad45d7e_0c675226","line":28,"range":{"start_line":28,"start_character":46,"end_line":28,"end_character":76},"updated":"2016-08-12 19:44:07.000000000","message":"nits: s/a/an/; s/updated/update/","commit_id":"ae27433b1d8c10518c7d0bef3b0070733ac4d209"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"5758b1434c48524cfb281eab5dd401447e66a59f","unresolved":false,"context_lines":[{"line_number":25,"context_line":"to refresh the config files shipped with tree to match the changes done in the"},{"line_number":26,"context_line":"source code during the release cycle."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"In an ideal world, every review that proposes a addition, removal or updated to"},{"line_number":29,"context_line":"a config option should use the tox tool to refresh only the configs they have"},{"line_number":30,"context_line":"changed. However, many of the configuration options like those coming from"},{"line_number":31,"context_line":"oslo.messaging, oslo_middleware, etc. may have changed in the meantime. So,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad45d7e_a2f8cfc5","line":28,"range":{"start_line":28,"start_character":46,"end_line":28,"end_character":76},"in_reply_to":"9ad45d7e_0c675226","updated":"2016-08-12 20:17:00.000000000","message":"Done","commit_id":"ae27433b1d8c10518c7d0bef3b0070733ac4d209"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"6af0545fc682d2bacbf45c5acdd378f4a92e3eb1","unresolved":false,"context_lines":[{"line_number":26,"context_line":"source code during the release cycle."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"In an ideal world, every review that proposes a addition, removal or updated to"},{"line_number":29,"context_line":"a config option should use the tox tool to refresh only the configs they have"},{"line_number":30,"context_line":"changed. However, many of the configuration options like those coming from"},{"line_number":31,"context_line":"oslo.messaging, oslo_middleware, etc. may have changed in the meantime. So,"},{"line_number":32,"context_line":"whenever someone uses the tool to autogenerate the configs based on the options"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad45d7e_6c436e6d","line":29,"range":{"start_line":29,"start_character":68,"end_line":29,"end_character":77},"updated":"2016-08-12 19:44:07.000000000","message":"nit: s/they have/that were/","commit_id":"ae27433b1d8c10518c7d0bef3b0070733ac4d209"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"5758b1434c48524cfb281eab5dd401447e66a59f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"source code during the release cycle."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"In an ideal world, every review that proposes a addition, removal or updated to"},{"line_number":29,"context_line":"a config option should use the tox tool to refresh only the configs they have"},{"line_number":30,"context_line":"changed. However, many of the configuration options like those coming from"},{"line_number":31,"context_line":"oslo.messaging, oslo_middleware, etc. may have changed in the meantime. So,"},{"line_number":32,"context_line":"whenever someone uses the tool to autogenerate the configs based on the options"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad45d7e_6225375b","line":29,"range":{"start_line":29,"start_character":68,"end_line":29,"end_character":77},"in_reply_to":"9ad45d7e_6c436e6d","updated":"2016-08-12 20:17:00.000000000","message":"Done","commit_id":"ae27433b1d8c10518c7d0bef3b0070733ac4d209"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"6af0545fc682d2bacbf45c5acdd378f4a92e3eb1","unresolved":false,"context_lines":[{"line_number":44,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* Ideally reviewers should request update to configs for each change that may"},{"line_number":47,"context_line":"  result into an update to the sample config files."},{"line_number":48,"context_line":"* In some situations however, there may be a bunch of similar changes that are"},{"line_number":49,"context_line":"  affecting the config files. In this case, in order to make the developers\u0027"},{"line_number":50,"context_line":"* and reviewers\u0027 effort easier, we recommend an update to the configs in bulk"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad45d7e_8c08622f","line":47,"updated":"2016-08-12 19:44:07.000000000","message":"nit: s/into/in/","commit_id":"ae27433b1d8c10518c7d0bef3b0070733ac4d209"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"5758b1434c48524cfb281eab5dd401447e66a59f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* Ideally reviewers should request update to configs for each change that may"},{"line_number":47,"context_line":"  result into an update to the sample config files."},{"line_number":48,"context_line":"* In some situations however, there may be a bunch of similar changes that are"},{"line_number":49,"context_line":"  affecting the config files. In this case, in order to make the developers\u0027"},{"line_number":50,"context_line":"* and reviewers\u0027 effort easier, we recommend an update to the configs in bulk"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad45d7e_a2e60f14","line":47,"in_reply_to":"9ad45d7e_8c08622f","updated":"2016-08-12 20:17:00.000000000","message":"I changed the sentence as per Hemanth\u0027s suggestion as it reads better.","commit_id":"ae27433b1d8c10518c7d0bef3b0070733ac4d209"}]}