)]}'
{"bin/glance-control":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"2b57335126c2cd4d8cb58e3a06c7698e9100b346","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            def respawn(self, num, stack):"},{"line_number":175,"context_line":"                running \u003d os.path.exists(self.pid_file)"},{"line_number":176,"context_line":"                bouncing \u003d running and not \\"},{"line_number":177,"context_line":"                           os.path.getmtime(self.pid_file) \u003c time.time() - 1"},{"line_number":178,"context_line":"                if running and not bouncing:"},{"line_number":179,"context_line":"                    launch(self.pid_file, self.conf, self.conf_file)"},{"line_number":180,"context_line":"                else:"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAEH%2F%2F870%3D","line":177,"updated":"2012-01-30 20:38:22.000000000","message":"Two comments:\n\n1) You could drop the \u0027not\u0027 by changing the operator to \u0027\u003e\u003d\u0027\n\n2) Could you please put this expression in parentheses so you don\u0027t have to use backslash continuation?","commit_id":"e123213eecfd58f4fece1024b52c05d140ac6875"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"55ac1eb45a09dc3e1ccca31ebdf622bdf1056094","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    if verb !\u003d \u0027Respawn\u0027:"},{"line_number":96,"context_line":"        for pid_file, pid in pid_files(server, conf):"},{"line_number":97,"context_line":"            if os.path.exists(\u0027/proc/%s\u0027 % pid):"},{"line_number":98,"context_line":"                print \"%s appears to already be running: %s\" % \\"},{"line_number":99,"context_line":"                      (server, pid_file)"},{"line_number":100,"context_line":"                return"},{"line_number":101,"context_line":"            else:"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAAEn%2F%2F9YY%3D","line":98,"updated":"2012-02-08 16:32:40.000000000","message":"Could you wrap the string in parentheses so that we don\u0027t need the backslash continuation?","commit_id":"804396204e23ebb6c29c396396027bc3b09b0eab"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"55ac1eb45a09dc3e1ccca31ebdf622bdf1056094","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"def get_pid_file(pid, conf):"},{"line_number":209,"context_line":"    return os.path.abspath(conf.pid_file) if conf.pid_file else \\"},{"line_number":210,"context_line":"           \u0027/var/run/glance/%s.pid\u0027 % server"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAAEn%2F%2F9YI%3D","line":209,"updated":"2012-02-08 16:32:40.000000000","message":"If you enclose this in parentheses, we can avoid having this backslash continuation","commit_id":"804396204e23ebb6c29c396396027bc3b09b0eab"}],"glance/tests/functional/__init__.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"2b57335126c2cd4d8cb58e3a06c7698e9100b346","unresolved":false,"context_lines":[{"line_number":561,"context_line":"        # Spin down the requested server"},{"line_number":562,"context_line":"        exitcode, out, err \u003d server.stop()"},{"line_number":563,"context_line":"        self.assertEqual(0, exitcode,"},{"line_number":564,"context_line":"                         \"Failed to spin down the %s server. Got: %s\" % \\"},{"line_number":565,"context_line":"                         (err, name))"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"    def stop_servers(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEH%2F%2F87w%3D","line":564,"updated":"2012-01-30 20:38:22.000000000","message":"There is no need for the backslash here.","commit_id":"e123213eecfd58f4fece1024b52c05d140ac6875"}],"glance/tests/functional/test_respawn.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"2b57335126c2cd4d8cb58e3a06c7698e9100b346","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        # wait for pid to cycle"},{"line_number":81,"context_line":"        pid_changed \u003d lambda: old_pid !\u003d self.get_pid()"},{"line_number":82,"context_line":"        self.wait_for(pid_changed)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        # ensure API service port is re-activated"},{"line_number":85,"context_line":"        self.wait_for_servers([self.api_server.bind_port])"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEH%2F%2F87s%3D","line":82,"updated":"2012-01-30 20:38:22.000000000","message":"I worry that, on a loaded machine, this test could fail transiently.  Not sure what to suggest as an alternative, though.  Perhaps making the count in wait_for() go a little higher, or the sleep go a little longer, if we see this problem…","commit_id":"e123213eecfd58f4fece1024b52c05d140ac6875"}]}