)]}'
{"glance/registry/client/v1/client.py":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"fc536637aa62057c269583023c8d3c7a75caa057","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        # a 404 condition is not fatal, we shouldn\u0027t log at a fatal"},{"line_number":135,"context_line":"        # level for it."},{"line_number":136,"context_line":"        except exception.NotFound:"},{"line_number":137,"context_line":"            raise"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        # The following exception logging should only really be used"},{"line_number":140,"context_line":"        # in extreme and unexpected cases."}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_aadea70e","line":137,"range":{"start_line":137,"start_character":12,"end_line":137,"end_character":17},"updated":"2016-08-16 14:24:37.000000000","message":"second thought, I wonder if we need to use save_and_reraise here as well like in line 142","commit_id":"5caf1c739e190338e87be8bcd880cb88b0920299"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1d2293c5e1804ba6dc555536858323ac683e2c7c","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        # a 404 condition is not fatal, we shouldn\u0027t log at a fatal"},{"line_number":135,"context_line":"        # level for it."},{"line_number":136,"context_line":"        except exception.NotFound:"},{"line_number":137,"context_line":"            raise"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        # The following exception logging should only really be used"},{"line_number":140,"context_line":"        # in extreme and unexpected cases."}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_daac8e37","line":137,"range":{"start_line":137,"start_character":12,"end_line":137,"end_character":17},"in_reply_to":"3ac371cc_1a1746ee","updated":"2016-08-16 15:14:08.000000000","message":"Got stuck in standup, sorry for the slow reply.  I\u0027m inclined to agree with Sean and Matt, just raise. Either way it gets reraised as an exception.NotFound, and will be sorted out higher up into a 404 or 401, depending on who\u0027s making the request.\n\nI\u0027m trying to think of a circumstance under which this log message will be useful, but I\u0027m having a failure of imagination.","commit_id":"5caf1c739e190338e87be8bcd880cb88b0920299"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"c5f42ed7a5884b2575b3189dd4ee732d2276cdeb","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        # a 404 condition is not fatal, we shouldn\u0027t log at a fatal"},{"line_number":135,"context_line":"        # level for it."},{"line_number":136,"context_line":"        except exception.NotFound:"},{"line_number":137,"context_line":"            raise"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        # The following exception logging should only really be used"},{"line_number":140,"context_line":"        # in extreme and unexpected cases."}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_1a1746ee","line":137,"range":{"start_line":137,"start_character":12,"end_line":137,"end_character":17},"in_reply_to":"3ac371cc_572a377f","updated":"2016-08-16 15:01:35.000000000","message":"right, like matt said, you only use the context manager if you are going to do something which could cause another exception, as that ensures that the one you care about is the one raised.\n\nOtherwise raise does the correct thing.","commit_id":"5caf1c739e190338e87be8bcd880cb88b0920299"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"aa1c6e3b0d8b638739c79ae85a4036838eaa558d","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        # a 404 condition is not fatal, we shouldn\u0027t log at a fatal"},{"line_number":135,"context_line":"        # level for it."},{"line_number":136,"context_line":"        except exception.NotFound:"},{"line_number":137,"context_line":"            raise"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        # The following exception logging should only really be used"},{"line_number":140,"context_line":"        # in extreme and unexpected cases."}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_572a377f","line":137,"range":{"start_line":137,"start_character":12,"end_line":137,"end_character":17},"in_reply_to":"3ac371cc_aadea70e","updated":"2016-08-16 14:43:23.000000000","message":"Unless your save_and_reraise_exception context is going to do something, I think it\u0027s pointless (same thing as this).","commit_id":"5caf1c739e190338e87be8bcd880cb88b0920299"}]}