)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"04f1e4cd4420c9e53dbf561e5e1e9095a3349559","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alexander Bashmakov \u003calexander.bashmakov@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-25 11:38:25 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improving help text for v1/v2 API and v1/v2 Registry opts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I36e34b6eb6f8e9595c9bcf852b8c2cde614b2fc9"},{"line_number":10,"context_line":"Partial-bug: #1570946"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1ac06dbe_674d0199","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":57},"updated":"2016-08-25 19:18:42.000000000","message":"The first line of the commit message can\u0027t be more than 50 chars in length. So, maybe something like \"Improving help text of v1/v2 API \u0026 Registry opts\"?\n\nFor your reference: See \"Summary of Git commit message structure\" at https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"55816c09c9a20580ce362ed26dbc10a8b3242e31"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"a3e4b8fe7a42562626a05337adbf17f4e20d6286","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alexander Bashmakov \u003calexander.bashmakov@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-25 11:38:25 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improving help text for v1/v2 API and v1/v2 Registry opts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I36e34b6eb6f8e9595c9bcf852b8c2cde614b2fc9"},{"line_number":10,"context_line":"Partial-bug: #1570946"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa7ab95a_2295ee3f","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":57},"in_reply_to":"1ac06dbe_674d0199","updated":"2016-08-25 20:12:30.000000000","message":"Done","commit_id":"55816c09c9a20580ce362ed26dbc10a8b3242e31"}],"glance/common/config.py":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"cf4370b1f2e2b067b716cd9cd6dd7521e4b7b3b8","unresolved":false,"context_lines":[{"line_number":218,"context_line":"                help\u003d_(\"\"\""},{"line_number":219,"context_line":"Deploy the v1 API Registry service."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"When this option is set to True, Glance will use the optional"},{"line_number":222,"context_line":"registry service for secure communication to the database"},{"line_number":223,"context_line":"abstraction layer when processing v1 API requrests."},{"line_number":224,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_248aecbf","line":221,"range":{"start_line":221,"start_character":53,"end_line":221,"end_character":61},"updated":"2016-08-25 18:02:36.000000000","message":"Registry isn\u0027t optional in v1. And, let\u0027s mention that here.","commit_id":"dabfd0569646b817820e45ae26be15d70be6ef5e"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"cf4370b1f2e2b067b716cd9cd6dd7521e4b7b3b8","unresolved":false,"context_lines":[{"line_number":216,"context_line":"    cfg.BoolOpt(\u0027enable_v1_registry\u0027,"},{"line_number":217,"context_line":"                default\u003dTrue,"},{"line_number":218,"context_line":"                help\u003d_(\"\"\""},{"line_number":219,"context_line":"Deploy the v1 API Registry service."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"When this option is set to True, Glance will use the optional"},{"line_number":222,"context_line":"registry service for secure communication to the database"},{"line_number":223,"context_line":"abstraction layer when processing v1 API requrests."},{"line_number":224,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_714dbf71","line":221,"range":{"start_line":219,"start_character":35,"end_line":221,"end_character":33},"updated":"2016-08-25 18:02:36.000000000","message":"This is slightly misleading maybe.\nGlance uses registry by default in v1. And, it is mandatory. So, setting this config opt to True, isn\u0027t really making Glance use the registry. It really only enables the v1 registry.","commit_id":"dabfd0569646b817820e45ae26be15d70be6ef5e"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"cf4370b1f2e2b067b716cd9cd6dd7521e4b7b3b8","unresolved":false,"context_lines":[{"line_number":229,"context_line":"    cfg.BoolOpt(\u0027enable_v2_registry\u0027,"},{"line_number":230,"context_line":"                default\u003dTrue,"},{"line_number":231,"context_line":"                help\u003d_(\"\"\""},{"line_number":232,"context_line":"Deploy the v2 API Registry service."},{"line_number":233,"context_line":"When this option is set to True, Glance will use the optional"},{"line_number":234,"context_line":"registry service for secure communication to the database"},{"line_number":235,"context_line":"abstraction layer when processing v2 API requrests."}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_4473a815","line":232,"updated":"2016-08-25 18:02:36.000000000","message":"Need a blank line here after the first line.","commit_id":"dabfd0569646b817820e45ae26be15d70be6ef5e"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"cf4370b1f2e2b067b716cd9cd6dd7521e4b7b3b8","unresolved":false,"context_lines":[{"line_number":230,"context_line":"                default\u003dTrue,"},{"line_number":231,"context_line":"                help\u003d_(\"\"\""},{"line_number":232,"context_line":"Deploy the v2 API Registry service."},{"line_number":233,"context_line":"When this option is set to True, Glance will use the optional"},{"line_number":234,"context_line":"registry service for secure communication to the database"},{"line_number":235,"context_line":"abstraction layer when processing v2 API requrests."},{"line_number":236,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_ce07b21b","line":233,"range":{"start_line":233,"start_character":33,"end_line":233,"end_character":48},"updated":"2016-08-25 18:02:36.000000000","message":"Setting this to true doesn\u0027t really force glance to use registry in V2. Even if this is set to True, if the data_api is not set to registry api, glance won\u0027t use the registry.\n\nThis config opt merely enables the v2 registry to run.","commit_id":"dabfd0569646b817820e45ae26be15d70be6ef5e"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"04f1e4cd4420c9e53dbf561e5e1e9095a3349559","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"When this option is set to True, Glance service will respond to requests"},{"line_number":198,"context_line":"on registered endpoints conforming to the v1 OpenStack Images API."},{"line_number":199,"context_line":"Note, if this option is enabled, then enable_v1_registry must also be"},{"line_number":200,"context_line":"set to True to enable mandatory usage of Registry service with v1 API."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_82d0eb54","line":199,"range":{"start_line":199,"start_character":0,"end_line":199,"end_character":7},"updated":"2016-08-25 19:18:42.000000000","message":"NOTE: If\n\nJust so that we are consistent with how we are adding \"NOTE\" sections so far.","commit_id":"55816c09c9a20580ce362ed26dbc10a8b3242e31"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"04f1e4cd4420c9e53dbf561e5e1e9095a3349559","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"When this option is set to True, Glance service will respond to requests"},{"line_number":198,"context_line":"on registered endpoints conforming to the v1 OpenStack Images API."},{"line_number":199,"context_line":"Note, if this option is enabled, then enable_v1_registry must also be"},{"line_number":200,"context_line":"set to True to enable mandatory usage of Registry service with v1 API."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_e2355fdb","line":199,"range":{"start_line":199,"start_character":38,"end_line":199,"end_character":56},"updated":"2016-08-25 19:18:42.000000000","message":"``enable_v1_registry``","commit_id":"55816c09c9a20580ce362ed26dbc10a8b3242e31"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"a3e4b8fe7a42562626a05337adbf17f4e20d6286","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"When this option is set to True, Glance service will respond to requests"},{"line_number":198,"context_line":"on registered endpoints conforming to the v1 OpenStack Images API."},{"line_number":199,"context_line":"Note, if this option is enabled, then enable_v1_registry must also be"},{"line_number":200,"context_line":"set to True to enable mandatory usage of Registry service with v1 API."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_c293624e","line":199,"range":{"start_line":199,"start_character":0,"end_line":199,"end_character":7},"in_reply_to":"1ac06dbe_82d0eb54","updated":"2016-08-25 20:12:30.000000000","message":"Done","commit_id":"55816c09c9a20580ce362ed26dbc10a8b3242e31"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"a3e4b8fe7a42562626a05337adbf17f4e20d6286","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"When this option is set to True, Glance service will respond to requests"},{"line_number":198,"context_line":"on registered endpoints conforming to the v1 OpenStack Images API."},{"line_number":199,"context_line":"Note, if this option is enabled, then enable_v1_registry must also be"},{"line_number":200,"context_line":"set to True to enable mandatory usage of Registry service with v1 API."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_e298666d","line":199,"range":{"start_line":199,"start_character":38,"end_line":199,"end_character":56},"in_reply_to":"1ac06dbe_e2355fdb","updated":"2016-08-25 20:12:30.000000000","message":"Done","commit_id":"55816c09c9a20580ce362ed26dbc10a8b3242e31"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"04f1e4cd4420c9e53dbf561e5e1e9095a3349559","unresolved":false,"context_lines":[{"line_number":197,"context_line":"When this option is set to True, Glance service will respond to requests"},{"line_number":198,"context_line":"on registered endpoints conforming to the v1 OpenStack Images API."},{"line_number":199,"context_line":"Note, if this option is enabled, then enable_v1_registry must also be"},{"line_number":200,"context_line":"set to True to enable mandatory usage of Registry service with v1 API."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Possible values:"},{"line_number":203,"context_line":"    * True"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_a2a887dc","line":200,"range":{"start_line":200,"start_character":7,"end_line":200,"end_character":11},"updated":"2016-08-25 19:18:42.000000000","message":"``True``","commit_id":"55816c09c9a20580ce362ed26dbc10a8b3242e31"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"a3e4b8fe7a42562626a05337adbf17f4e20d6286","unresolved":false,"context_lines":[{"line_number":197,"context_line":"When this option is set to True, Glance service will respond to requests"},{"line_number":198,"context_line":"on registered endpoints conforming to the v1 OpenStack Images API."},{"line_number":199,"context_line":"Note, if this option is enabled, then enable_v1_registry must also be"},{"line_number":200,"context_line":"set to True to enable mandatory usage of Registry service with v1 API."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Possible values:"},{"line_number":203,"context_line":"    * True"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_e234e64b","line":200,"range":{"start_line":200,"start_character":7,"end_line":200,"end_character":11},"in_reply_to":"1ac06dbe_a2a887dc","updated":"2016-08-25 20:12:30.000000000","message":"Done","commit_id":"55816c09c9a20580ce362ed26dbc10a8b3242e31"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"04f1e4cd4420c9e53dbf561e5e1e9095a3349559","unresolved":false,"context_lines":[{"line_number":204,"context_line":"    * False"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"Related options:"},{"line_number":207,"context_line":"    * enable_v1_registry"},{"line_number":208,"context_line":"\"\"\")),"},{"line_number":209,"context_line":"    cfg.BoolOpt(\u0027enable_v2_api\u0027,"},{"line_number":210,"context_line":"                default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_62d32f60","line":207,"updated":"2016-08-25 19:18:42.000000000","message":"Let\u0027s add a blank line here as well","commit_id":"55816c09c9a20580ce362ed26dbc10a8b3242e31"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"a3e4b8fe7a42562626a05337adbf17f4e20d6286","unresolved":false,"context_lines":[{"line_number":204,"context_line":"    * False"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"Related options:"},{"line_number":207,"context_line":"    * enable_v1_registry"},{"line_number":208,"context_line":"\"\"\")),"},{"line_number":209,"context_line":"    cfg.BoolOpt(\u0027enable_v2_api\u0027,"},{"line_number":210,"context_line":"                default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_e20b067c","line":207,"in_reply_to":"1ac06dbe_62d32f60","updated":"2016-08-25 20:12:30.000000000","message":"Done","commit_id":"55816c09c9a20580ce362ed26dbc10a8b3242e31"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"04f1e4cd4420c9e53dbf561e5e1e9095a3349559","unresolved":false,"context_lines":[{"line_number":224,"context_line":"Deploy the v1 API Registry service."},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"When this option is set to True, Glance will enable the Registry"},{"line_number":227,"context_line":"service, which is used for secure communication to the database"},{"line_number":228,"context_line":"abstraction layer when making API requests. Note, use of Registry"},{"line_number":229,"context_line":"is mandatory in v1 API, so this option must be set to True if the"},{"line_number":230,"context_line":"enable_v1_api option is enabled."},{"line_number":231,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_822bcbea","line":228,"range":{"start_line":227,"start_character":23,"end_line":228,"end_character":42},"updated":"2016-08-25 19:18:42.000000000","message":"Same as below","commit_id":"55816c09c9a20580ce362ed26dbc10a8b3242e31"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"a3e4b8fe7a42562626a05337adbf17f4e20d6286","unresolved":false,"context_lines":[{"line_number":224,"context_line":"Deploy the v1 API Registry service."},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"When this option is set to True, Glance will enable the Registry"},{"line_number":227,"context_line":"service, which is used for secure communication to the database"},{"line_number":228,"context_line":"abstraction layer when making API requests. Note, use of Registry"},{"line_number":229,"context_line":"is mandatory in v1 API, so this option must be set to True if the"},{"line_number":230,"context_line":"enable_v1_api option is enabled."},{"line_number":231,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_02170a52","line":228,"range":{"start_line":227,"start_character":23,"end_line":228,"end_character":42},"in_reply_to":"1ac06dbe_822bcbea","updated":"2016-08-25 20:12:30.000000000","message":"Done","commit_id":"55816c09c9a20580ce362ed26dbc10a8b3242e31"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"04f1e4cd4420c9e53dbf561e5e1e9095a3349559","unresolved":false,"context_lines":[{"line_number":225,"context_line":""},{"line_number":226,"context_line":"When this option is set to True, Glance will enable the Registry"},{"line_number":227,"context_line":"service, which is used for secure communication to the database"},{"line_number":228,"context_line":"abstraction layer when making API requests. Note, use of Registry"},{"line_number":229,"context_line":"is mandatory in v1 API, so this option must be set to True if the"},{"line_number":230,"context_line":"enable_v1_api option is enabled."},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"Possible values:"},{"line_number":233,"context_line":"    * True"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_c2b66389","line":230,"range":{"start_line":228,"start_character":44,"end_line":230,"end_character":32},"updated":"2016-08-25 19:18:42.000000000","message":"Let\u0027s get this on a new line. And, Note should appear in uppercase.","commit_id":"55816c09c9a20580ce362ed26dbc10a8b3242e31"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"a3e4b8fe7a42562626a05337adbf17f4e20d6286","unresolved":false,"context_lines":[{"line_number":225,"context_line":""},{"line_number":226,"context_line":"When this option is set to True, Glance will enable the Registry"},{"line_number":227,"context_line":"service, which is used for secure communication to the database"},{"line_number":228,"context_line":"abstraction layer when making API requests. Note, use of Registry"},{"line_number":229,"context_line":"is mandatory in v1 API, so this option must be set to True if the"},{"line_number":230,"context_line":"enable_v1_api option is enabled."},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"Possible values:"},{"line_number":233,"context_line":"    * True"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_220c0e42","line":230,"range":{"start_line":228,"start_character":44,"end_line":230,"end_character":32},"in_reply_to":"1ac06dbe_c2b66389","updated":"2016-08-25 20:12:30.000000000","message":"Done","commit_id":"55816c09c9a20580ce362ed26dbc10a8b3242e31"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"04f1e4cd4420c9e53dbf561e5e1e9095a3349559","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    * False"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"Related options:"},{"line_number":237,"context_line":"    * enable_v1_api"},{"line_number":238,"context_line":"\"\"\")),"},{"line_number":239,"context_line":"    cfg.BoolOpt(\u0027enable_v2_registry\u0027,"},{"line_number":240,"context_line":"                default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_e2bf1ffa","line":237,"updated":"2016-08-25 19:18:42.000000000","message":"same","commit_id":"55816c09c9a20580ce362ed26dbc10a8b3242e31"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"a3e4b8fe7a42562626a05337adbf17f4e20d6286","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    * False"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"Related options:"},{"line_number":237,"context_line":"    * enable_v1_api"},{"line_number":238,"context_line":"\"\"\")),"},{"line_number":239,"context_line":"    cfg.BoolOpt(\u0027enable_v2_registry\u0027,"},{"line_number":240,"context_line":"                default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_82f95a50","line":237,"in_reply_to":"1ac06dbe_e2bf1ffa","updated":"2016-08-25 20:12:30.000000000","message":"Done","commit_id":"55816c09c9a20580ce362ed26dbc10a8b3242e31"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"04f1e4cd4420c9e53dbf561e5e1e9095a3349559","unresolved":false,"context_lines":[{"line_number":242,"context_line":"Deploy the v2 API Registry service."},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"When this option is set to True, Glance will enable the Registry"},{"line_number":245,"context_line":"service, which is used for secure communication to the database"},{"line_number":246,"context_line":"abstraction layer when making API requests. Note, use of Registry"},{"line_number":247,"context_line":"is optional in v2 API, so this option must only be enabled if both"},{"line_number":248,"context_line":"enable_v2_api is set to True and the data_api option is set to"},{"line_number":249,"context_line":"``glance.db.registry.api``."}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_22d777ee","line":246,"range":{"start_line":245,"start_character":27,"end_line":246,"end_character":43},"updated":"2016-08-25 19:18:42.000000000","message":"1) This should be secure communication with the database. Because registry itself is/has the database abstraction layer here.\n2) Secure communication is only one usecase for using the registry. There are other reasons to like horizontal scalability. So, I\u0027m thinking if we should mention this at all?","commit_id":"55816c09c9a20580ce362ed26dbc10a8b3242e31"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"a3e4b8fe7a42562626a05337adbf17f4e20d6286","unresolved":false,"context_lines":[{"line_number":242,"context_line":"Deploy the v2 API Registry service."},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"When this option is set to True, Glance will enable the Registry"},{"line_number":245,"context_line":"service, which is used for secure communication to the database"},{"line_number":246,"context_line":"abstraction layer when making API requests. Note, use of Registry"},{"line_number":247,"context_line":"is optional in v2 API, so this option must only be enabled if both"},{"line_number":248,"context_line":"enable_v2_api is set to True and the data_api option is set to"},{"line_number":249,"context_line":"``glance.db.registry.api``."}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_629376fb","line":246,"range":{"start_line":245,"start_character":27,"end_line":246,"end_character":43},"in_reply_to":"1ac06dbe_22d777ee","updated":"2016-08-25 20:12:30.000000000","message":"Will remove","commit_id":"55816c09c9a20580ce362ed26dbc10a8b3242e31"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"04f1e4cd4420c9e53dbf561e5e1e9095a3349559","unresolved":false,"context_lines":[{"line_number":245,"context_line":"service, which is used for secure communication to the database"},{"line_number":246,"context_line":"abstraction layer when making API requests. Note, use of Registry"},{"line_number":247,"context_line":"is optional in v2 API, so this option must only be enabled if both"},{"line_number":248,"context_line":"enable_v2_api is set to True and the data_api option is set to"},{"line_number":249,"context_line":"``glance.db.registry.api``."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_624def98","line":248,"range":{"start_line":248,"start_character":24,"end_line":248,"end_character":28},"updated":"2016-08-25 19:18:42.000000000","message":"``True``","commit_id":"55816c09c9a20580ce362ed26dbc10a8b3242e31"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"04f1e4cd4420c9e53dbf561e5e1e9095a3349559","unresolved":false,"context_lines":[{"line_number":245,"context_line":"service, which is used for secure communication to the database"},{"line_number":246,"context_line":"abstraction layer when making API requests. Note, use of Registry"},{"line_number":247,"context_line":"is optional in v2 API, so this option must only be enabled if both"},{"line_number":248,"context_line":"enable_v2_api is set to True and the data_api option is set to"},{"line_number":249,"context_line":"``glance.db.registry.api``."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_025fdb41","line":248,"range":{"start_line":248,"start_character":37,"end_line":248,"end_character":45},"updated":"2016-08-25 19:18:42.000000000","message":"``data_api``","commit_id":"55816c09c9a20580ce362ed26dbc10a8b3242e31"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"04f1e4cd4420c9e53dbf561e5e1e9095a3349559","unresolved":false,"context_lines":[{"line_number":245,"context_line":"service, which is used for secure communication to the database"},{"line_number":246,"context_line":"abstraction layer when making API requests. Note, use of Registry"},{"line_number":247,"context_line":"is optional in v2 API, so this option must only be enabled if both"},{"line_number":248,"context_line":"enable_v2_api is set to True and the data_api option is set to"},{"line_number":249,"context_line":"``glance.db.registry.api``."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_42827395","line":248,"range":{"start_line":248,"start_character":0,"end_line":248,"end_character":13},"updated":"2016-08-25 19:18:42.000000000","message":"``enable_v2_api``","commit_id":"55816c09c9a20580ce362ed26dbc10a8b3242e31"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"a3e4b8fe7a42562626a05337adbf17f4e20d6286","unresolved":false,"context_lines":[{"line_number":245,"context_line":"service, which is used for secure communication to the database"},{"line_number":246,"context_line":"abstraction layer when making API requests. Note, use of Registry"},{"line_number":247,"context_line":"is optional in v2 API, so this option must only be enabled if both"},{"line_number":248,"context_line":"enable_v2_api is set to True and the data_api option is set to"},{"line_number":249,"context_line":"``glance.db.registry.api``."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_82907aee","line":248,"range":{"start_line":248,"start_character":37,"end_line":248,"end_character":45},"in_reply_to":"1ac06dbe_025fdb41","updated":"2016-08-25 20:12:30.000000000","message":"Done","commit_id":"55816c09c9a20580ce362ed26dbc10a8b3242e31"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"a3e4b8fe7a42562626a05337adbf17f4e20d6286","unresolved":false,"context_lines":[{"line_number":245,"context_line":"service, which is used for secure communication to the database"},{"line_number":246,"context_line":"abstraction layer when making API requests. Note, use of Registry"},{"line_number":247,"context_line":"is optional in v2 API, so this option must only be enabled if both"},{"line_number":248,"context_line":"enable_v2_api is set to True and the data_api option is set to"},{"line_number":249,"context_line":"``glance.db.registry.api``."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_a2bbbe74","line":248,"range":{"start_line":248,"start_character":0,"end_line":248,"end_character":13},"in_reply_to":"1ac06dbe_42827395","updated":"2016-08-25 20:12:30.000000000","message":"Done","commit_id":"55816c09c9a20580ce362ed26dbc10a8b3242e31"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"a3e4b8fe7a42562626a05337adbf17f4e20d6286","unresolved":false,"context_lines":[{"line_number":245,"context_line":"service, which is used for secure communication to the database"},{"line_number":246,"context_line":"abstraction layer when making API requests. Note, use of Registry"},{"line_number":247,"context_line":"is optional in v2 API, so this option must only be enabled if both"},{"line_number":248,"context_line":"enable_v2_api is set to True and the data_api option is set to"},{"line_number":249,"context_line":"``glance.db.registry.api``."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_e2b5c67e","line":248,"range":{"start_line":248,"start_character":24,"end_line":248,"end_character":28},"in_reply_to":"1ac06dbe_624def98","updated":"2016-08-25 20:12:30.000000000","message":"Done","commit_id":"55816c09c9a20580ce362ed26dbc10a8b3242e31"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"04f1e4cd4420c9e53dbf561e5e1e9095a3349559","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"When this option is set to True, Glance will enable the Registry"},{"line_number":245,"context_line":"service, which is used for secure communication to the database"},{"line_number":246,"context_line":"abstraction layer when making API requests. Note, use of Registry"},{"line_number":247,"context_line":"is optional in v2 API, so this option must only be enabled if both"},{"line_number":248,"context_line":"enable_v2_api is set to True and the data_api option is set to"},{"line_number":249,"context_line":"``glance.db.registry.api``."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"Possible values:"},{"line_number":252,"context_line":"    * True"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_e2ab9f1c","line":249,"range":{"start_line":246,"start_character":44,"end_line":249,"end_character":27},"updated":"2016-08-25 19:18:42.000000000","message":"Same as above.","commit_id":"55816c09c9a20580ce362ed26dbc10a8b3242e31"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"a3e4b8fe7a42562626a05337adbf17f4e20d6286","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"When this option is set to True, Glance will enable the Registry"},{"line_number":245,"context_line":"service, which is used for secure communication to the database"},{"line_number":246,"context_line":"abstraction layer when making API requests. Note, use of Registry"},{"line_number":247,"context_line":"is optional in v2 API, so this option must only be enabled if both"},{"line_number":248,"context_line":"enable_v2_api is set to True and the data_api option is set to"},{"line_number":249,"context_line":"``glance.db.registry.api``."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"Possible values:"},{"line_number":252,"context_line":"    * True"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_82a79a4e","line":249,"range":{"start_line":246,"start_character":44,"end_line":249,"end_character":27},"in_reply_to":"1ac06dbe_e2ab9f1c","updated":"2016-08-25 20:12:30.000000000","message":"Done","commit_id":"55816c09c9a20580ce362ed26dbc10a8b3242e31"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"04f1e4cd4420c9e53dbf561e5e1e9095a3349559","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    * False"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"Related options:"},{"line_number":256,"context_line":"    enable_v2_api"},{"line_number":257,"context_line":"    data_api"},{"line_number":258,"context_line":"\"\"\")),"},{"line_number":259,"context_line":"    cfg.StrOpt(\u0027pydev_worker_debug_host\u0027,"},{"line_number":260,"context_line":"               help\u003d_(\u0027The hostname/IP of the pydev process listening for \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_024cfb40","line":257,"range":{"start_line":256,"start_character":0,"end_line":257,"end_character":12},"updated":"2016-08-25 19:18:42.000000000","message":"* enable_v2_api\n   * data_api","commit_id":"55816c09c9a20580ce362ed26dbc10a8b3242e31"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"a3e4b8fe7a42562626a05337adbf17f4e20d6286","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    * False"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"Related options:"},{"line_number":256,"context_line":"    enable_v2_api"},{"line_number":257,"context_line":"    data_api"},{"line_number":258,"context_line":"\"\"\")),"},{"line_number":259,"context_line":"    cfg.StrOpt(\u0027pydev_worker_debug_host\u0027,"},{"line_number":260,"context_line":"               help\u003d_(\u0027The hostname/IP of the pydev process listening for \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_e5dcf048","line":257,"range":{"start_line":256,"start_character":0,"end_line":257,"end_character":12},"in_reply_to":"1ac06dbe_024cfb40","updated":"2016-08-25 20:12:30.000000000","message":"Done","commit_id":"55816c09c9a20580ce362ed26dbc10a8b3242e31"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"04f1e4cd4420c9e53dbf561e5e1e9095a3349559","unresolved":false,"context_lines":[{"line_number":255,"context_line":"Related options:"},{"line_number":256,"context_line":"    enable_v2_api"},{"line_number":257,"context_line":"    data_api"},{"line_number":258,"context_line":"\"\"\")),"},{"line_number":259,"context_line":"    cfg.StrOpt(\u0027pydev_worker_debug_host\u0027,"},{"line_number":260,"context_line":"               help\u003d_(\u0027The hostname/IP of the pydev process listening for \u0027"},{"line_number":261,"context_line":"                      \u0027debug connections\u0027)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_e2f43fd0","line":258,"updated":"2016-08-25 19:18:42.000000000","message":"blank line here","commit_id":"55816c09c9a20580ce362ed26dbc10a8b3242e31"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"a3e4b8fe7a42562626a05337adbf17f4e20d6286","unresolved":false,"context_lines":[{"line_number":255,"context_line":"Related options:"},{"line_number":256,"context_line":"    enable_v2_api"},{"line_number":257,"context_line":"    data_api"},{"line_number":258,"context_line":"\"\"\")),"},{"line_number":259,"context_line":"    cfg.StrOpt(\u0027pydev_worker_debug_host\u0027,"},{"line_number":260,"context_line":"               help\u003d_(\u0027The hostname/IP of the pydev process listening for \u0027"},{"line_number":261,"context_line":"                      \u0027debug connections\u0027)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_6281b68f","line":258,"in_reply_to":"1ac06dbe_e2f43fd0","updated":"2016-08-25 20:12:30.000000000","message":"Done","commit_id":"55816c09c9a20580ce362ed26dbc10a8b3242e31"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"67ea0f3ca293a4650cde7fdd9e6832d27c455a25","unresolved":false,"context_lines":[{"line_number":218,"context_line":"When this option is set to ``True``, Glance service will respond"},{"line_number":219,"context_line":"to requests on registered endpoints conforming to the v2 OpenStack"},{"line_number":220,"context_line":"Images API."},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"Possible values:"},{"line_number":223,"context_line":"    * True"},{"line_number":224,"context_line":"    * False"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_02234dbe","line":221,"updated":"2016-08-26 16:40:10.000000000","message":"I think adding a note here and in the above help indicating that ``enable_v[1,2]_api`` are independent of each other will help.","commit_id":"6c1e1e23740187119b7b8079c48e4b849a1d5a5a"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"b9ba6d98e5c7fdcd1e970f44c7db244d5c6ba0eb","unresolved":false,"context_lines":[{"line_number":218,"context_line":"When this option is set to ``True``, Glance service will respond"},{"line_number":219,"context_line":"to requests on registered endpoints conforming to the v2 OpenStack"},{"line_number":220,"context_line":"Images API."},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"Possible values:"},{"line_number":223,"context_line":"    * True"},{"line_number":224,"context_line":"    * False"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_3d7f96ab","line":221,"in_reply_to":"fa7ab95a_02234dbe","updated":"2016-08-26 17:12:01.000000000","message":"Done","commit_id":"6c1e1e23740187119b7b8079c48e4b849a1d5a5a"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"67ea0f3ca293a4650cde7fdd9e6832d27c455a25","unresolved":false,"context_lines":[{"line_number":234,"context_line":""},{"line_number":235,"context_line":"NOTE: Use of Registry is mandatory in v1 API, so this option must"},{"line_number":236,"context_line":"be set to ``True`` if the ``enable_v1_api`` option is enabled."},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"Possible values:"},{"line_number":239,"context_line":"    * True"},{"line_number":240,"context_line":"    * False"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_dd3a2acd","line":237,"updated":"2016-08-26 16:40:10.000000000","message":"Don\u0027t use it if you are deploying only v2 OpenStack Images API.","commit_id":"6c1e1e23740187119b7b8079c48e4b849a1d5a5a"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"b9ba6d98e5c7fdcd1e970f44c7db244d5c6ba0eb","unresolved":false,"context_lines":[{"line_number":234,"context_line":""},{"line_number":235,"context_line":"NOTE: Use of Registry is mandatory in v1 API, so this option must"},{"line_number":236,"context_line":"be set to ``True`` if the ``enable_v1_api`` option is enabled."},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"Possible values:"},{"line_number":239,"context_line":"    * True"},{"line_number":240,"context_line":"    * False"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_d872387c","line":237,"in_reply_to":"fa7ab95a_dd3a2acd","updated":"2016-08-26 17:12:01.000000000","message":"Done","commit_id":"6c1e1e23740187119b7b8079c48e4b849a1d5a5a"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"67ea0f3ca293a4650cde7fdd9e6832d27c455a25","unresolved":false,"context_lines":[{"line_number":254,"context_line":"NOTE: Use of Registry is optional in v2 API, so this option"},{"line_number":255,"context_line":"must only be enabled if both ``enable_v2_api`` is set to ``True``"},{"line_number":256,"context_line":"and the ``data_api`` option is set to ``glance.db.registry.api``."},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"Possible values:"},{"line_number":259,"context_line":"    * True"},{"line_number":260,"context_line":"    * False"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_7d791e93","line":257,"updated":"2016-08-26 16:40:10.000000000","message":"ditto","commit_id":"6c1e1e23740187119b7b8079c48e4b849a1d5a5a"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"a466aabbefd1ec96c8edfa3c70102eda17ce3198","unresolved":false,"context_lines":[{"line_number":219,"context_line":"to requests on registered endpoints conforming to the v2 OpenStack"},{"line_number":220,"context_line":"Images API."},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"NOTE: This option is separate from enable_v1_api, both v1 and v2"},{"line_number":223,"context_line":"OpenStack Images API can be deployed independent of each other."},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_d825d8c2","line":222,"range":{"start_line":222,"start_character":35,"end_line":222,"end_character":48},"updated":"2016-08-26 17:09:28.000000000","message":"``enable_v1_api``","commit_id":"944aee972086e8c38a2b3d12da82fba6292a9798"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"c5b6b81d82cd9b77941a3da0a3cf773579018b6e","unresolved":false,"context_lines":[{"line_number":219,"context_line":"to requests on registered endpoints conforming to the v2 OpenStack"},{"line_number":220,"context_line":"Images API."},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"NOTE: This option is separate from enable_v1_api, both v1 and v2"},{"line_number":223,"context_line":"OpenStack Images API can be deployed independent of each other."},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_fa3a9197","line":222,"range":{"start_line":222,"start_character":35,"end_line":222,"end_character":48},"in_reply_to":"fa7ab95a_d825d8c2","updated":"2016-08-26 17:12:40.000000000","message":"Done","commit_id":"944aee972086e8c38a2b3d12da82fba6292a9798"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"a466aabbefd1ec96c8edfa3c70102eda17ce3198","unresolved":false,"context_lines":[{"line_number":219,"context_line":"to requests on registered endpoints conforming to the v2 OpenStack"},{"line_number":220,"context_line":"Images API."},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"NOTE: This option is separate from enable_v1_api, both v1 and v2"},{"line_number":223,"context_line":"OpenStack Images API can be deployed independent of each other."},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"Possible values:"},{"line_number":226,"context_line":"    * True"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_58ee288c","line":223,"range":{"start_line":222,"start_character":0,"end_line":223,"end_character":63},"updated":"2016-08-26 17:09:28.000000000","message":"Let\u0027s add a similar note for enable_v1_api as well?","commit_id":"944aee972086e8c38a2b3d12da82fba6292a9798"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"c5b6b81d82cd9b77941a3da0a3cf773579018b6e","unresolved":false,"context_lines":[{"line_number":219,"context_line":"to requests on registered endpoints conforming to the v2 OpenStack"},{"line_number":220,"context_line":"Images API."},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"NOTE: This option is separate from enable_v1_api, both v1 and v2"},{"line_number":223,"context_line":"OpenStack Images API can be deployed independent of each other."},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"Possible values:"},{"line_number":226,"context_line":"    * True"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_1a42d510","line":223,"range":{"start_line":222,"start_character":0,"end_line":223,"end_character":63},"in_reply_to":"fa7ab95a_58ee288c","updated":"2016-08-26 17:12:40.000000000","message":"Done","commit_id":"944aee972086e8c38a2b3d12da82fba6292a9798"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"a466aabbefd1ec96c8edfa3c70102eda17ce3198","unresolved":false,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"NOTE: Use of Registry is mandatory in v1 API, so this option must"},{"line_number":239,"context_line":"be set to ``True`` if the ``enable_v1_api`` option is enabled."},{"line_number":240,"context_line":"If only deploying the v2 OpensStack Images API, this option should"},{"line_number":241,"context_line":"be disabled."},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_3856c429","line":240,"range":{"start_line":240,"start_character":3,"end_line":240,"end_character":16},"updated":"2016-08-26 17:09:28.000000000","message":"deploying only?","commit_id":"944aee972086e8c38a2b3d12da82fba6292a9798"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"c5b6b81d82cd9b77941a3da0a3cf773579018b6e","unresolved":false,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"NOTE: Use of Registry is mandatory in v1 API, so this option must"},{"line_number":239,"context_line":"be set to ``True`` if the ``enable_v1_api`` option is enabled."},{"line_number":240,"context_line":"If only deploying the v2 OpensStack Images API, this option should"},{"line_number":241,"context_line":"be disabled."},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_3a45d916","line":240,"range":{"start_line":240,"start_character":3,"end_line":240,"end_character":16},"in_reply_to":"fa7ab95a_3856c429","updated":"2016-08-26 17:12:40.000000000","message":"Done","commit_id":"944aee972086e8c38a2b3d12da82fba6292a9798"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"630258bf8e8c5a1e6992937c5f0dab1623693335","unresolved":false,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"NOTE: Use of Registry is mandatory in v1 API, so this option must"},{"line_number":239,"context_line":"be set to ``True`` if the ``enable_v1_api`` option is enabled."},{"line_number":240,"context_line":"If only deploying the v2 OpensStack Images API, this option should"},{"line_number":241,"context_line":"be disabled."},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_dad06d56","line":240,"range":{"start_line":240,"start_character":3,"end_line":240,"end_character":16},"in_reply_to":"fa7ab95a_3856c429","updated":"2016-08-26 17:12:38.000000000","message":"I like Hemanth\u0027s suggestion.  Also, unless it would conflict with how we\u0027re doing things for other options, this should be a separate NOTE paragraph by itself.  It\u0027s making a different point from the first sentence, and it will stand out more that way.","commit_id":"944aee972086e8c38a2b3d12da82fba6292a9798"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"4fd80f47180c894b9c3dbcdd1f303f81eb48cd3e","unresolved":false,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"NOTE: Use of Registry is mandatory in v1 API, so this option must"},{"line_number":239,"context_line":"be set to ``True`` if the ``enable_v1_api`` option is enabled."},{"line_number":240,"context_line":"If only deploying the v2 OpensStack Images API, this option should"},{"line_number":241,"context_line":"be disabled."},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_7ac6814a","line":240,"range":{"start_line":240,"start_character":3,"end_line":240,"end_character":16},"in_reply_to":"fa7ab95a_dad06d56","updated":"2016-08-26 17:19:23.000000000","message":"Done","commit_id":"944aee972086e8c38a2b3d12da82fba6292a9798"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"a466aabbefd1ec96c8edfa3c70102eda17ce3198","unresolved":false,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"NOTE: Use of Registry is mandatory in v1 API, so this option must"},{"line_number":239,"context_line":"be set to ``True`` if the ``enable_v1_api`` option is enabled."},{"line_number":240,"context_line":"If only deploying the v2 OpensStack Images API, this option should"},{"line_number":241,"context_line":"be disabled."},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"Possible values:"},{"line_number":244,"context_line":"    * True"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_1882e094","line":241,"range":{"start_line":240,"start_character":0,"end_line":241,"end_character":12},"updated":"2016-08-26 17:09:28.000000000","message":"Think Nikhil wants a similar note for enable_v2_registry as well.","commit_id":"944aee972086e8c38a2b3d12da82fba6292a9798"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"c5b6b81d82cd9b77941a3da0a3cf773579018b6e","unresolved":false,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"NOTE: Use of Registry is mandatory in v1 API, so this option must"},{"line_number":239,"context_line":"be set to ``True`` if the ``enable_v1_api`` option is enabled."},{"line_number":240,"context_line":"If only deploying the v2 OpensStack Images API, this option should"},{"line_number":241,"context_line":"be disabled."},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"Possible values:"},{"line_number":244,"context_line":"    * True"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_5a4c5d42","line":241,"range":{"start_line":240,"start_character":0,"end_line":241,"end_character":12},"in_reply_to":"fa7ab95a_1882e094","updated":"2016-08-26 17:12:40.000000000","message":"Done","commit_id":"944aee972086e8c38a2b3d12da82fba6292a9798"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d0627bed183307c1652de3a914bb1b8a4a9ab54d","unresolved":false,"context_lines":[{"line_number":241,"context_line":"NOTE: Use of Registry is mandatory in v1 API, so this option must"},{"line_number":242,"context_line":"be set to ``True`` if the ``enable_v1_api`` option is enabled."},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"NOTE: If deploying only the v2 OpensStack Images API, this option"},{"line_number":245,"context_line":"should be disabled."},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_3aecf98e","line":244,"range":{"start_line":244,"start_character":35,"end_line":244,"end_character":36},"updated":"2016-08-26 17:23:59.000000000","message":"extra \u0027s\u0027","commit_id":"932878f69106aebe65d19e0f1e763b9896ad953a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d0627bed183307c1652de3a914bb1b8a4a9ab54d","unresolved":false,"context_lines":[{"line_number":264,"context_line":"must only be enabled if both ``enable_v2_api`` is set to ``True``"},{"line_number":265,"context_line":"and the ``data_api`` option is set to ``glance.db.registry.api``."},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"NOTE: If deploying only the v1 OpensStack Images API, this option"},{"line_number":268,"context_line":"should be disabled."},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_baf8094b","line":267,"range":{"start_line":267,"start_character":35,"end_line":267,"end_character":36},"updated":"2016-08-26 17:23:59.000000000","message":"extra \u0027s\u0027","commit_id":"932878f69106aebe65d19e0f1e763b9896ad953a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d954b3cfe4754204ae43d66d77cfe80840726dca","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"NOTE: If deploying only the v2 OpenStack Images API, this option"},{"line_number":245,"context_line":"should be disabled."},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"Possible values:"},{"line_number":248,"context_line":"    * True"},{"line_number":249,"context_line":"    * False"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_fd98cb1d","line":246,"updated":"2016-08-26 17:44:33.000000000","message":"This was a good catch by Nikhil ... an operator has to explicitly change this since the default is True.  I wonder whether we should add another note to the enable_v2_api option, something like:\n\nNOTE: If deploying only the v2 Images API, the option ``enable_v1_registry``, which is enabled by default, should be disabled.\n\nand maybe one to the enable_v1_api option saying,\n\nNOTE: If this option is disabled, the option ``enable_v1_registry``, which is enabled by default, should also be disabled.","commit_id":"b644d8ce0f2df65eddf563f0dff7490d4f8c8199"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"80400ef9ef80e8420c5c595029a5094706fa0e38","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"NOTE: If deploying only the v2 OpenStack Images API, this option"},{"line_number":245,"context_line":"should be disabled."},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"Possible values:"},{"line_number":248,"context_line":"    * True"},{"line_number":249,"context_line":"    * False"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_40138a0d","line":246,"in_reply_to":"fa7ab95a_fd98cb1d","updated":"2016-08-26 17:53:22.000000000","message":"+1","commit_id":"b644d8ce0f2df65eddf563f0dff7490d4f8c8199"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"cf384001e72b98caea7815d7fa771af767ee2676","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"NOTE: If deploying only the v2 OpenStack Images API, this option"},{"line_number":245,"context_line":"should be disabled."},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"Possible values:"},{"line_number":248,"context_line":"    * True"},{"line_number":249,"context_line":"    * False"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_803d92bd","line":246,"in_reply_to":"fa7ab95a_fd98cb1d","updated":"2016-08-26 17:47:53.000000000","message":"It is mentioned for the registry opts, but I guess it doesn\u0027t hurt mentioning it for api opts too.","commit_id":"b644d8ce0f2df65eddf563f0dff7490d4f8c8199"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"12997be88e88b86f71f53bf35d735b967c3e9d70","unresolved":false,"context_lines":[{"line_number":204,"context_line":"      service with v1 API."},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    * If this option is disabled, then the ``enable_v1_registry``"},{"line_number":207,"context_line":"      option, which is enabled by default, should also be disabled."},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    * This option is separate from ``enable_v2_api``, both v1 and v2"},{"line_number":210,"context_line":"      OpenStack Images API can be deployed independent of each"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa7ab95a_ae9447e2","line":207,"range":{"start_line":207,"start_character":43,"end_line":207,"end_character":66},"updated":"2016-08-26 18:46:58.000000000","message":"\"is recommended to be disabled\"?\nBecause, it nothing really mandates that this MUST be off if not using v1 api.","commit_id":"7cf202475dd8ec4a403a7cd1d49a404f3efbee7d"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"c8e267516cadac24ea7cf36a4422818668085228","unresolved":false,"context_lines":[{"line_number":262,"context_line":"will be enabled in Glance for v1 API requests."},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"NOTES:"},{"line_number":265,"context_line":"    * Use of Registry is mandatory in v1 API, so this option must"},{"line_number":266,"context_line":"      be set to ``True`` if the ``enable_v1_api`` option is enabled."},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    * If deploying only the v2 OpenStack Images API, this option,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_37cb27a7","line":265,"range":{"start_line":265,"start_character":61,"end_line":265,"end_character":65},"updated":"2016-08-26 20:38:45.000000000","message":"bold or caps whatever we decide to do.. I do remember that\u0027s gunna be part of the next iteration of improvements","commit_id":"56623710e199bbd750c381b42fc730b7c8401c72"}]}