)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"6c674443720a497c38b62669e1fa9ab6eb1387f2","unresolved":false,"context_lines":[{"line_number":11,"context_line":"to ``vmware`` and ``file`` respectively to be in sync with glance_store"},{"line_number":12,"context_line":"names and at the same time accommodate backoward compatibility for old"},{"line_number":13,"context_line":"conf files using ``filesystem`` and ``vmware_datastore``."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I3d8593cdae6780ae721afedcf47dd45afa684f25"},{"line_number":16,"context_line":"closes-bug:1615852"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"7a8ec9b2_43e23130","line":14,"updated":"2016-09-16 21:15:49.000000000","message":"Can you add some info on the impact on Glance due to this inconsistency? (here and on the bug)\n\nwhen I read this line and the bug, I cannot understand why this is a problem, so why is it?","commit_id":"194b4ec8b0f2d09e87ab836130552bb3a6eacca9"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"f7a141981fe0bddbe9b1ee5e7aab66c2f83aa400","unresolved":false,"context_lines":[{"line_number":11,"context_line":"to ``vmware`` and ``file`` respectively to be in sync with glance_store"},{"line_number":12,"context_line":"names and at the same time accommodate backoward compatibility for old"},{"line_number":13,"context_line":"conf files using ``filesystem`` and ``vmware_datastore``."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I3d8593cdae6780ae721afedcf47dd45afa684f25"},{"line_number":16,"context_line":"closes-bug:1615852"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"7a8ec9b2_9cd65a4d","line":14,"in_reply_to":"7a8ec9b2_43e23130","updated":"2016-09-16 22:53:50.000000000","message":"Done","commit_id":"194b4ec8b0f2d09e87ab836130552bb3a6eacca9"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"6c674443720a497c38b62669e1fa9ab6eb1387f2","unresolved":false,"context_lines":[{"line_number":13,"context_line":"conf files using ``filesystem`` and ``vmware_datastore``."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I3d8593cdae6780ae721afedcf47dd45afa684f25"},{"line_number":16,"context_line":"closes-bug:1615852"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"7a8ec9b2_c3cc81bd","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":18},"updated":"2016-09-16 21:15:49.000000000","message":"this will be femto nit but talking about consistency\n\n\"Closes-Bug: 1615852\"\n\nif someone is parsing git log and due to a glitch in the script they may miss your bug","commit_id":"194b4ec8b0f2d09e87ab836130552bb3a6eacca9"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"f7a141981fe0bddbe9b1ee5e7aab66c2f83aa400","unresolved":false,"context_lines":[{"line_number":13,"context_line":"conf files using ``filesystem`` and ``vmware_datastore``."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I3d8593cdae6780ae721afedcf47dd45afa684f25"},{"line_number":16,"context_line":"closes-bug:1615852"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"7a8ec9b2_bcc956ae","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":18},"in_reply_to":"7a8ec9b2_c3cc81bd","updated":"2016-09-16 22:53:50.000000000","message":"Done","commit_id":"194b4ec8b0f2d09e87ab836130552bb3a6eacca9"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"3e934af761f58854bacf78beb0f07237418787d1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fixing inconsistency in Glance store names."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The store names used in Glance and glance_store are not in sync with"},{"line_number":10,"context_line":"each other."},{"line_number":11,"context_line":"This can confuse operators who have to use different names to refer to"},{"line_number":12,"context_line":"the same store while setting values for configuration options such as"},{"line_number":13,"context_line":"``store_type_preference`` in glance and configuration option like ``store`` in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"7a8ec9b2_3c6c669b","line":10,"range":{"start_line":10,"start_character":10,"end_line":10,"end_character":11},"updated":"2016-09-16 22:59:10.000000000","message":"paragraph","commit_id":"2575167125c748fa581d8221f81823c0bf986422"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"3e934af761f58854bacf78beb0f07237418787d1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"each other."},{"line_number":11,"context_line":"This can confuse operators who have to use different names to refer to"},{"line_number":12,"context_line":"the same store while setting values for configuration options such as"},{"line_number":13,"context_line":"``store_type_preference`` in glance and configuration option like ``store`` in"},{"line_number":14,"context_line":"glance_store. This inconsistency may also confuse for developers during"},{"line_number":15,"context_line":"code changes, complicating  future code changes with respect to this."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"7a8ec9b2_fc759e63","line":13,"range":{"start_line":13,"start_character":66,"end_line":13,"end_character":78},"updated":"2016-09-16 22:59:10.000000000","message":"over 72 chars","commit_id":"2575167125c748fa581d8221f81823c0bf986422"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"3e934af761f58854bacf78beb0f07237418787d1","unresolved":false,"context_lines":[{"line_number":11,"context_line":"This can confuse operators who have to use different names to refer to"},{"line_number":12,"context_line":"the same store while setting values for configuration options such as"},{"line_number":13,"context_line":"``store_type_preference`` in glance and configuration option like ``store`` in"},{"line_number":14,"context_line":"glance_store. This inconsistency may also confuse for developers during"},{"line_number":15,"context_line":"code changes, complicating  future code changes with respect to this."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Converting store names: ``vmware_datastore`` and ``filesystem``"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"7a8ec9b2_7c08aeda","line":14,"range":{"start_line":14,"start_character":50,"end_line":14,"end_character":53},"updated":"2016-09-16 22:59:10.000000000","message":"s/for//","commit_id":"2575167125c748fa581d8221f81823c0bf986422"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"3e934af761f58854bacf78beb0f07237418787d1","unresolved":false,"context_lines":[{"line_number":12,"context_line":"the same store while setting values for configuration options such as"},{"line_number":13,"context_line":"``store_type_preference`` in glance and configuration option like ``store`` in"},{"line_number":14,"context_line":"glance_store. This inconsistency may also confuse for developers during"},{"line_number":15,"context_line":"code changes, complicating  future code changes with respect to this."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Converting store names: ``vmware_datastore`` and ``filesystem``"},{"line_number":18,"context_line":"to ``vmware`` and ``file`` respectively to be in sync with glance_store"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"7a8ec9b2_bc0eb6e2","line":15,"range":{"start_line":15,"start_character":26,"end_line":15,"end_character":28},"updated":"2016-09-16 22:59:10.000000000","message":"extra ws","commit_id":"2575167125c748fa581d8221f81823c0bf986422"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"3e934af761f58854bacf78beb0f07237418787d1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"``store_type_preference`` in glance and configuration option like ``store`` in"},{"line_number":14,"context_line":"glance_store. This inconsistency may also confuse for developers during"},{"line_number":15,"context_line":"code changes, complicating  future code changes with respect to this."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Converting store names: ``vmware_datastore`` and ``filesystem``"},{"line_number":18,"context_line":"to ``vmware`` and ``file`` respectively to be in sync with glance_store"},{"line_number":19,"context_line":"names and at the same time accommodate backoward compatibility for old"},{"line_number":20,"context_line":"conf files that might still be using ``filesystem`` and ``vmware_datastore``."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"7a8ec9b2_3c0386b9","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":10},"updated":"2016-09-16 22:59:10.000000000","message":"s/Converting/Mapping/","commit_id":"2575167125c748fa581d8221f81823c0bf986422"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"3e934af761f58854bacf78beb0f07237418787d1","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Converting store names: ``vmware_datastore`` and ``filesystem``"},{"line_number":18,"context_line":"to ``vmware`` and ``file`` respectively to be in sync with glance_store"},{"line_number":19,"context_line":"names and at the same time accommodate backoward compatibility for old"},{"line_number":20,"context_line":"conf files that might still be using ``filesystem`` and ``vmware_datastore``."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I3d8593cdae6780ae721afedcf47dd45afa684f25"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"7a8ec9b2_fc23de53","line":19,"range":{"start_line":19,"start_character":39,"end_line":19,"end_character":48},"updated":"2016-09-16 22:59:10.000000000","message":"backward","commit_id":"2575167125c748fa581d8221f81823c0bf986422"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"3e934af761f58854bacf78beb0f07237418787d1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"code changes, complicating  future code changes with respect to this."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Converting store names: ``vmware_datastore`` and ``filesystem``"},{"line_number":18,"context_line":"to ``vmware`` and ``file`` respectively to be in sync with glance_store"},{"line_number":19,"context_line":"names and at the same time accommodate backoward compatibility for old"},{"line_number":20,"context_line":"conf files that might still be using ``filesystem`` and ``vmware_datastore``."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I3d8593cdae6780ae721afedcf47dd45afa684f25"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"7a8ec9b2_bc25d65c","line":19,"range":{"start_line":18,"start_character":59,"end_line":19,"end_character":5},"updated":"2016-09-16 22:59:10.000000000","message":"glance_store entry point names \n\nhttps://github.com/openstack/glance_store/blob/master/setup.cfg#L27","commit_id":"2575167125c748fa581d8221f81823c0bf986422"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"3e934af761f58854bacf78beb0f07237418787d1","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Converting store names: ``vmware_datastore`` and ``filesystem``"},{"line_number":18,"context_line":"to ``vmware`` and ``file`` respectively to be in sync with glance_store"},{"line_number":19,"context_line":"names and at the same time accommodate backoward compatibility for old"},{"line_number":20,"context_line":"conf files that might still be using ``filesystem`` and ``vmware_datastore``."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I3d8593cdae6780ae721afedcf47dd45afa684f25"},{"line_number":23,"context_line":"Closes-Bug: #1615852"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"7a8ec9b2_5c15b2e2","line":20,"range":{"start_line":20,"start_character":56,"end_line":20,"end_character":76},"updated":"2016-09-16 22:59:10.000000000","message":"wrap text","commit_id":"2575167125c748fa581d8221f81823c0bf986422"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"c2e9bc521fa03a76207da35d787b46bf165f8a2b","unresolved":false,"context_lines":[{"line_number":16,"context_line":"developers during code changes, complicating future code changes with"},{"line_number":17,"context_line":"respect to this."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Mapping store names: ``vmware_datastore`` and ``filesystem``"},{"line_number":20,"context_line":"to ``vmware`` and ``file`` respectively to be in sync with glance_store"},{"line_number":21,"context_line":"entry point names and at the same time accommodate backward"},{"line_number":22,"context_line":"compatibility for old configuration files that might still be using"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"7a8ec9b2_3dc5af3b","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":19},"updated":"2016-09-20 20:55:33.000000000","message":"please use the suggestion from rel note and indicate that this affects only multiple locations while using location strategy.","commit_id":"b1bc7d16d57303b85905706647f6061f03a3a7b9"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"b220d170a9fbd589b8c92736653468252c1886c1","unresolved":false,"context_lines":[{"line_number":16,"context_line":"developers during code changes, complicating future code changes with"},{"line_number":17,"context_line":"respect to this."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Mapping store names: ``vmware_datastore`` and ``filesystem``"},{"line_number":20,"context_line":"to ``vmware`` and ``file`` respectively to be in sync with glance_store"},{"line_number":21,"context_line":"entry point names and at the same time accommodate backward"},{"line_number":22,"context_line":"compatibility for old configuration files that might still be using"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"7a8ec9b2_a9bfbd5e","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":19},"in_reply_to":"7a8ec9b2_3dc5af3b","updated":"2016-09-20 23:37:40.000000000","message":"Done","commit_id":"b1bc7d16d57303b85905706647f6061f03a3a7b9"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"5611ca3dc2fafa95bf616c0e4513b028d6e44051","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Credit:"},{"line_number":34,"context_line":"This patch has a release note authored by"},{"line_number":35,"context_line":"Brian Rosmaita \u003cbrian.rosmaita@rackspace.com\u003e"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Change-Id: I3d8593cdae6780ae721afedcf47dd45afa684f25"},{"line_number":38,"context_line":"Closes-Bug: #1615852"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"7a8ec9b2_49ad0b83","line":35,"range":{"start_line":35,"start_character":15,"end_line":35,"end_character":45},"updated":"2016-09-22 00:44:19.000000000","message":"I don\u0027t think we need emails for this new credit block in the CM. These are not parsed.","commit_id":"17bc05edffd72d2bd7589aa7edfabc161b620b38"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"2707dde64be698a99a11213278376700ba92b4c0","unresolved":false,"context_lines":[{"line_number":25,"context_line":"used and ``location_strategy`` configuration option is set to"},{"line_number":26,"context_line":"``store_type``."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Note: This change does not require a config refresh change."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Impact:"},{"line_number":31,"context_line":"UpgradeImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"5a8bc5a2_e9f1206c","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":59},"updated":"2016-09-27 21:07:05.000000000","message":"please refresh configs the help text changes.\n\nmaster configs are released with the release of the source tree so although you have time to fix it, make sure you do it early and correct this statement in your follow up patch","commit_id":"dfa0682cac93938fc6fe3c0ccfb0640a0a18ee33"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"e6501d02751eedd6fadbfa3c1e8df7bd548b0951","unresolved":false,"context_lines":[{"line_number":25,"context_line":"used and ``location_strategy`` configuration option is set to"},{"line_number":26,"context_line":"``store_type``."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Note: This change does not require a config refresh change."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Impact:"},{"line_number":31,"context_line":"UpgradeImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"5a8bc5a2_7cf070ca","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":59},"in_reply_to":"5a8bc5a2_e9f1206c","updated":"2016-09-27 21:19:41.000000000","message":"Sure Nikhil. Will do. Thanks.","commit_id":"dfa0682cac93938fc6fe3c0ccfb0640a0a18ee33"}],"glance/common/location_strategy/store_type.py":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"ab15e5af86e2afe75e3803ec7e04d2cbf3085dae","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    # possible to prevent make relationships with Glance(server)-specific code,"},{"line_number":55,"context_line":"    # for example: using functions within store module to validate"},{"line_number":56,"context_line":"    # \u0027store_type_preference\u0027 option."},{"line_number":57,"context_line":"    mapping \u003d {\u0027filesystem\u0027: [\u0027file\u0027, \u0027filesystem\u0027],"},{"line_number":58,"context_line":"               \u0027http\u0027: [\u0027http\u0027, \u0027https\u0027],"},{"line_number":59,"context_line":"               \u0027rbd\u0027: [\u0027rbd\u0027],"},{"line_number":60,"context_line":"               \u0027swift\u0027: [\u0027swift\u0027, \u0027swift+https\u0027, \u0027swift+http\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ac06dbe_c07cffed","line":57,"range":{"start_line":57,"start_character":15,"end_line":57,"end_character":52},"updated":"2016-08-24 15:34:17.000000000","message":"We don\u0027t need this.","commit_id":"215331a037d20ebc6338d5bb16104b0ecfad7263"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"d0a13b6c17cd0182f535af85f73b7147912f9210","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    # possible to prevent make relationships with Glance(server)-specific code,"},{"line_number":55,"context_line":"    # for example: using functions within store module to validate"},{"line_number":56,"context_line":"    # \u0027store_type_preference\u0027 option."},{"line_number":57,"context_line":"    mapping \u003d {\u0027filesystem\u0027: [\u0027file\u0027, \u0027filesystem\u0027],"},{"line_number":58,"context_line":"               \u0027http\u0027: [\u0027http\u0027, \u0027https\u0027],"},{"line_number":59,"context_line":"               \u0027rbd\u0027: [\u0027rbd\u0027],"},{"line_number":60,"context_line":"               \u0027swift\u0027: [\u0027swift\u0027, \u0027swift+https\u0027, \u0027swift+http\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ac06dbe_58abdfd6","line":57,"range":{"start_line":57,"start_character":15,"end_line":57,"end_character":52},"in_reply_to":"1ac06dbe_c07cffed","updated":"2016-08-24 16:43:44.000000000","message":"I agree.","commit_id":"215331a037d20ebc6338d5bb16104b0ecfad7263"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"ab15e5af86e2afe75e3803ec7e04d2cbf3085dae","unresolved":false,"context_lines":[{"line_number":60,"context_line":"               \u0027swift\u0027: [\u0027swift\u0027, \u0027swift+https\u0027, \u0027swift+http\u0027],"},{"line_number":61,"context_line":"               \u0027sheepdog\u0027: [\u0027sheepdog\u0027],"},{"line_number":62,"context_line":"               \u0027cinder\u0027: [\u0027cinder\u0027],"},{"line_number":63,"context_line":"               \u0027vmware_datastore\u0027: [\u0027vsphere\u0027],"},{"line_number":64,"context_line":"               \u0027file\u0027: [\u0027file\u0027, \u0027filesystem\u0027],"},{"line_number":65,"context_line":"               \u0027vmware\u0027: [\u0027vsphere\u0027]}"},{"line_number":66,"context_line":"    _STORE_TO_SCHEME_MAP.clear()"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ac06dbe_804a07ab","line":63,"range":{"start_line":63,"start_character":15,"end_line":63,"end_character":47},"updated":"2016-08-24 15:34:17.000000000","message":"And, neither do we need this any more, do we?\n\nThe mapping is consumed internally, so we don\u0027t need to keep mapping for both filesystem and file. Really all that we need is some sanitization of the input (config in this) coming from the user. As long as we convert filesystem to file and vmware_datastore to vmware when we read the config, we should be fine.\n\nIf we do this, we don\u0027t need line 107 and 108.","commit_id":"215331a037d20ebc6338d5bb16104b0ecfad7263"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"d0a13b6c17cd0182f535af85f73b7147912f9210","unresolved":false,"context_lines":[{"line_number":60,"context_line":"               \u0027swift\u0027: [\u0027swift\u0027, \u0027swift+https\u0027, \u0027swift+http\u0027],"},{"line_number":61,"context_line":"               \u0027sheepdog\u0027: [\u0027sheepdog\u0027],"},{"line_number":62,"context_line":"               \u0027cinder\u0027: [\u0027cinder\u0027],"},{"line_number":63,"context_line":"               \u0027vmware_datastore\u0027: [\u0027vsphere\u0027],"},{"line_number":64,"context_line":"               \u0027file\u0027: [\u0027file\u0027, \u0027filesystem\u0027],"},{"line_number":65,"context_line":"               \u0027vmware\u0027: [\u0027vsphere\u0027]}"},{"line_number":66,"context_line":"    _STORE_TO_SCHEME_MAP.clear()"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ac06dbe_5892bfa0","line":63,"range":{"start_line":63,"start_character":15,"end_line":63,"end_character":47},"in_reply_to":"1ac06dbe_804a07ab","updated":"2016-08-24 16:43:44.000000000","message":"I agree. We don\u0027t need this and \u0027vmware_datastore\u0027 in the mapping. This dictionary is actually just used to match locations with schemes.\nWill get rid of this.","commit_id":"215331a037d20ebc6338d5bb16104b0ecfad7263"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"f4a4d6e5d182e8b33c0b31fe6f519e19ddf26d7a","unresolved":false,"context_lines":[{"line_number":62,"context_line":"               \u0027cinder\u0027: [\u0027cinder\u0027],"},{"line_number":63,"context_line":"               \u0027vmware_datastore\u0027: [\u0027vsphere\u0027],"},{"line_number":64,"context_line":"               \u0027file\u0027: [\u0027file\u0027, \u0027filesystem\u0027],"},{"line_number":65,"context_line":"               \u0027vmware\u0027: [\u0027vsphere\u0027]}"},{"line_number":66,"context_line":"    _STORE_TO_SCHEME_MAP.clear()"},{"line_number":67,"context_line":"    _STORE_TO_SCHEME_MAP.update(mapping)"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1ac06dbe_49fb2a79","line":65,"updated":"2016-08-24 11:15:18.000000000","message":"I think \"[\u0027file\u0027, \u0027filesystem\u0027]\" and \"[\u0027vsphere\u0027]\" should be in a variable, so that mappings[\u0027filesystem\u0027] cannot be modified without modifying mappings[\u0027file\u0027] by mistake. WDYT?","commit_id":"215331a037d20ebc6338d5bb16104b0ecfad7263"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"d0a13b6c17cd0182f535af85f73b7147912f9210","unresolved":false,"context_lines":[{"line_number":62,"context_line":"               \u0027cinder\u0027: [\u0027cinder\u0027],"},{"line_number":63,"context_line":"               \u0027vmware_datastore\u0027: [\u0027vsphere\u0027],"},{"line_number":64,"context_line":"               \u0027file\u0027: [\u0027file\u0027, \u0027filesystem\u0027],"},{"line_number":65,"context_line":"               \u0027vmware\u0027: [\u0027vsphere\u0027]}"},{"line_number":66,"context_line":"    _STORE_TO_SCHEME_MAP.clear()"},{"line_number":67,"context_line":"    _STORE_TO_SCHEME_MAP.update(mapping)"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1ac06dbe_787b3b2a","line":65,"in_reply_to":"1ac06dbe_49fb2a79","updated":"2016-08-24 16:43:44.000000000","message":"Cyrill. I wasn\u0027t sure why we would be modifying the schemes of a store in the dictionary. \nAnyhow, we wouldn\u0027t need to have vmware_datastore and filesystem as Hemanth pointed out. That eliminates this concern of double modification.","commit_id":"215331a037d20ebc6338d5bb16104b0ecfad7263"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c77e4271f779bd78ac9be4cfde9b64dae202d9a7","unresolved":false,"context_lines":[{"line_number":62,"context_line":"               \u0027cinder\u0027: [\u0027cinder\u0027],"},{"line_number":63,"context_line":"               \u0027vmware_datastore\u0027: [\u0027vsphere\u0027],"},{"line_number":64,"context_line":"               \u0027file\u0027: [\u0027file\u0027, \u0027filesystem\u0027],"},{"line_number":65,"context_line":"               \u0027vmware\u0027: [\u0027vsphere\u0027]}"},{"line_number":66,"context_line":"    _STORE_TO_SCHEME_MAP.clear()"},{"line_number":67,"context_line":"    _STORE_TO_SCHEME_MAP.update(mapping)"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1ac06dbe_852e99a3","line":65,"in_reply_to":"1ac06dbe_49fb2a79","updated":"2016-08-24 14:32:20.000000000","message":"I agree with Cyril\u0027s suggestion.\n\nAlso, I think we need a comment here with the bug number saying something about \u0027filesystem\u0027 and \u0027vmware_datastore\u0027 being left in the mapping for backward compatability and that they should not be documented as legitimate values for this option.  (You might want to reorder the dict so that the 2 \"bad\" values show up together at the bottom introduced by your commment.)","commit_id":"215331a037d20ebc6338d5bb16104b0ecfad7263"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"ab15e5af86e2afe75e3803ec7e04d2cbf3085dae","unresolved":false,"context_lines":[{"line_number":62,"context_line":"               \u0027cinder\u0027: [\u0027cinder\u0027],"},{"line_number":63,"context_line":"               \u0027vmware_datastore\u0027: [\u0027vsphere\u0027],"},{"line_number":64,"context_line":"               \u0027file\u0027: [\u0027file\u0027, \u0027filesystem\u0027],"},{"line_number":65,"context_line":"               \u0027vmware\u0027: [\u0027vsphere\u0027]}"},{"line_number":66,"context_line":"    _STORE_TO_SCHEME_MAP.clear()"},{"line_number":67,"context_line":"    _STORE_TO_SCHEME_MAP.update(mapping)"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1ac06dbe_db8d0e2c","line":65,"in_reply_to":"1ac06dbe_852e99a3","updated":"2016-08-24 15:34:17.000000000","message":"We don\u0027t need the variable if we drop filesystem and vmware_datastore mappings.","commit_id":"215331a037d20ebc6338d5bb16104b0ecfad7263"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"d0a13b6c17cd0182f535af85f73b7147912f9210","unresolved":false,"context_lines":[{"line_number":62,"context_line":"               \u0027cinder\u0027: [\u0027cinder\u0027],"},{"line_number":63,"context_line":"               \u0027vmware_datastore\u0027: [\u0027vsphere\u0027],"},{"line_number":64,"context_line":"               \u0027file\u0027: [\u0027file\u0027, \u0027filesystem\u0027],"},{"line_number":65,"context_line":"               \u0027vmware\u0027: [\u0027vsphere\u0027]}"},{"line_number":66,"context_line":"    _STORE_TO_SCHEME_MAP.clear()"},{"line_number":67,"context_line":"    _STORE_TO_SCHEME_MAP.update(mapping)"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1ac06dbe_189de759","line":65,"in_reply_to":"1ac06dbe_db8d0e2c","updated":"2016-08-24 16:43:44.000000000","message":"Done","commit_id":"215331a037d20ebc6338d5bb16104b0ecfad7263"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"ab15e5af86e2afe75e3803ec7e04d2cbf3085dae","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        store_name \u003d None"},{"line_number":105,"context_line":"        for store, schemes in six.iteritems(_STORE_TO_SCHEME_MAP):"},{"line_number":106,"context_line":"            if pieces.scheme.strip() in schemes:"},{"line_number":107,"context_line":"                if store \u003d\u003d \u0027filesystem\u0027 or store \u003d\u003d \u0027vmware_datastore\u0027:"},{"line_number":108,"context_line":"                    continue"},{"line_number":109,"context_line":"                store_name \u003d store"},{"line_number":110,"context_line":"                break"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1ac06dbe_dbb4eed5","line":108,"range":{"start_line":107,"start_character":0,"end_line":108,"end_character":28},"updated":"2016-08-24 15:34:17.000000000","message":"We won\u0027t need this either if we get rid of the redundant mappings.","commit_id":"215331a037d20ebc6338d5bb16104b0ecfad7263"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"d0a13b6c17cd0182f535af85f73b7147912f9210","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        store_name \u003d None"},{"line_number":105,"context_line":"        for store, schemes in six.iteritems(_STORE_TO_SCHEME_MAP):"},{"line_number":106,"context_line":"            if pieces.scheme.strip() in schemes:"},{"line_number":107,"context_line":"                if store \u003d\u003d \u0027filesystem\u0027 or store \u003d\u003d \u0027vmware_datastore\u0027:"},{"line_number":108,"context_line":"                    continue"},{"line_number":109,"context_line":"                store_name \u003d store"},{"line_number":110,"context_line":"                break"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1ac06dbe_589f5f50","line":108,"range":{"start_line":107,"start_character":0,"end_line":108,"end_character":28},"in_reply_to":"1ac06dbe_dbb4eed5","updated":"2016-08-24 16:43:44.000000000","message":"Done","commit_id":"215331a037d20ebc6338d5bb16104b0ecfad7263"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"cffe4e069557540a40884aaad8f69d5d4ea56229","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            if preferred_store \u003d\u003d \u0027filesystem\u0027:"},{"line_number":83,"context_line":"                preferred_store \u003d \u0027file\u0027"},{"line_number":84,"context_line":"            if preferred_store \u003d\u003d \u0027vmware_datastore\u0027:"},{"line_number":85,"context_line":"                preferred_store \u003d \u0027vmware\u0027"},{"line_number":86,"context_line":"            yield preferred_store"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    if not locations:"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ac06dbe_e3e013cf","line":85,"updated":"2016-08-24 19:36:25.000000000","message":"OK, this patch makes more sense.  Only the correct values are used in the mapping, and backwards compatibility is managed here.  I think you need a comment before this series of \u0027if\u0027 statements explaining why you need to do this, though.","commit_id":"d65eac5bebce35748f99c62b9c47c31459659d83"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"1d2b3408684ebb809fd9de1e4a740e89b718676e","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            if preferred_store \u003d\u003d \u0027filesystem\u0027:"},{"line_number":83,"context_line":"                preferred_store \u003d \u0027file\u0027"},{"line_number":84,"context_line":"            if preferred_store \u003d\u003d \u0027vmware_datastore\u0027:"},{"line_number":85,"context_line":"                preferred_store \u003d \u0027vmware\u0027"},{"line_number":86,"context_line":"            yield preferred_store"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    if not locations:"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ac06dbe_27087691","line":85,"in_reply_to":"1ac06dbe_e3e013cf","updated":"2016-08-24 19:54:27.000000000","message":"+1","commit_id":"d65eac5bebce35748f99c62b9c47c31459659d83"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"24ab5fd639e817805e4b27d182e760db160fb44d","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            preferred_store \u003d str(preferred_store).strip()"},{"line_number":80,"context_line":"            if not preferred_store:"},{"line_number":81,"context_line":"                continue"},{"line_number":82,"context_line":"            # The following changes of ``filesystem`` and ``vmware_datastore``"},{"line_number":83,"context_line":"            # to ``file`` and ``vmware`` are to make store names consistent in"},{"line_number":84,"context_line":"            # Glance and glance_store and also be backward compatible."},{"line_number":85,"context_line":"            if preferred_store \u003d\u003d \u0027filesystem\u0027:"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ac06dbe_2d2a157f","line":82,"range":{"start_line":82,"start_character":28,"end_line":82,"end_character":35},"updated":"2016-08-24 20:17:04.000000000","message":"conversion","commit_id":"e6266d2d8254ad842bda52dc586eea58e2ce89cb"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"b03219d8a2d86de2857b73de22996da007b3b0d7","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            preferred_store \u003d str(preferred_store).strip()"},{"line_number":80,"context_line":"            if not preferred_store:"},{"line_number":81,"context_line":"                continue"},{"line_number":82,"context_line":"            # The following changes of ``filesystem`` and ``vmware_datastore``"},{"line_number":83,"context_line":"            # to ``file`` and ``vmware`` are to make store names consistent in"},{"line_number":84,"context_line":"            # Glance and glance_store and also be backward compatible."},{"line_number":85,"context_line":"            if preferred_store \u003d\u003d \u0027filesystem\u0027:"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ac06dbe_0651f30e","line":82,"range":{"start_line":82,"start_character":28,"end_line":82,"end_character":35},"in_reply_to":"1ac06dbe_2d2a157f","updated":"2016-08-24 22:05:05.000000000","message":"Done","commit_id":"e6266d2d8254ad842bda52dc586eea58e2ce89cb"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"24ab5fd639e817805e4b27d182e760db160fb44d","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                continue"},{"line_number":82,"context_line":"            # The following changes of ``filesystem`` and ``vmware_datastore``"},{"line_number":83,"context_line":"            # to ``file`` and ``vmware`` are to make store names consistent in"},{"line_number":84,"context_line":"            # Glance and glance_store and also be backward compatible."},{"line_number":85,"context_line":"            if preferred_store \u003d\u003d \u0027filesystem\u0027:"},{"line_number":86,"context_line":"                preferred_store \u003d \u0027file\u0027"},{"line_number":87,"context_line":"            if preferred_store \u003d\u003d \u0027vmware_datastore\u0027:"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ac06dbe_ed30fdea","line":84,"updated":"2016-08-24 20:17:04.000000000","message":"Let\u0027s add the bug ID here for reference.","commit_id":"e6266d2d8254ad842bda52dc586eea58e2ce89cb"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"b03219d8a2d86de2857b73de22996da007b3b0d7","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                continue"},{"line_number":82,"context_line":"            # The following changes of ``filesystem`` and ``vmware_datastore``"},{"line_number":83,"context_line":"            # to ``file`` and ``vmware`` are to make store names consistent in"},{"line_number":84,"context_line":"            # Glance and glance_store and also be backward compatible."},{"line_number":85,"context_line":"            if preferred_store \u003d\u003d \u0027filesystem\u0027:"},{"line_number":86,"context_line":"                preferred_store \u003d \u0027file\u0027"},{"line_number":87,"context_line":"            if preferred_store \u003d\u003d \u0027vmware_datastore\u0027:"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ac06dbe_6656e707","line":84,"in_reply_to":"1ac06dbe_ed30fdea","updated":"2016-08-24 22:05:05.000000000","message":"Done","commit_id":"e6266d2d8254ad842bda52dc586eea58e2ce89cb"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"83a65e33df3b0a7824f87610df56785611c49911","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            # are to make store names consistent in Glance and glance_store"},{"line_number":120,"context_line":"            # and also be backward compatible."},{"line_number":121,"context_line":"            # Reference: Bug 1615852"},{"line_number":122,"context_line":"            if preferred_store \u003d\u003d \u0027filesystem\u0027:"},{"line_number":123,"context_line":"                preferred_store \u003d \u0027file\u0027"},{"line_number":124,"context_line":"            if preferred_store \u003d\u003d \u0027vmware_datastore\u0027:"},{"line_number":125,"context_line":"                preferred_store \u003d \u0027vmware\u0027"}],"source_content_type":"text/x-python","patch_set":18,"id":"7a8ec9b2_f534414b","line":122,"range":{"start_line":122,"start_character":12,"end_line":122,"end_character":47},"updated":"2016-09-20 19:36:43.000000000","message":"How about logging a warning here mentioning that \"filesystem\"  is deprecated and will be dropped in the next couple of cycles?","commit_id":"b1bc7d16d57303b85905706647f6061f03a3a7b9"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"c2e9bc521fa03a76207da35d787b46bf165f8a2b","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            # are to make store names consistent in Glance and glance_store"},{"line_number":120,"context_line":"            # and also be backward compatible."},{"line_number":121,"context_line":"            # Reference: Bug 1615852"},{"line_number":122,"context_line":"            if preferred_store \u003d\u003d \u0027filesystem\u0027:"},{"line_number":123,"context_line":"                preferred_store \u003d \u0027file\u0027"},{"line_number":124,"context_line":"            if preferred_store \u003d\u003d \u0027vmware_datastore\u0027:"},{"line_number":125,"context_line":"                preferred_store \u003d \u0027vmware\u0027"}],"source_content_type":"text/x-python","patch_set":18,"id":"7a8ec9b2_5d16fbf1","line":122,"range":{"start_line":122,"start_character":12,"end_line":122,"end_character":47},"in_reply_to":"7a8ec9b2_95721d10","updated":"2016-09-20 20:55:33.000000000","message":"see my comment on rel note.","commit_id":"b1bc7d16d57303b85905706647f6061f03a3a7b9"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e7f5d43950fea0c05e139bc1d88336ee28eb2664","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            # are to make store names consistent in Glance and glance_store"},{"line_number":120,"context_line":"            # and also be backward compatible."},{"line_number":121,"context_line":"            # Reference: Bug 1615852"},{"line_number":122,"context_line":"            if preferred_store \u003d\u003d \u0027filesystem\u0027:"},{"line_number":123,"context_line":"                preferred_store \u003d \u0027file\u0027"},{"line_number":124,"context_line":"            if preferred_store \u003d\u003d \u0027vmware_datastore\u0027:"},{"line_number":125,"context_line":"                preferred_store \u003d \u0027vmware\u0027"}],"source_content_type":"text/x-python","patch_set":18,"id":"7a8ec9b2_95721d10","line":122,"range":{"start_line":122,"start_character":12,"end_line":122,"end_character":47},"in_reply_to":"7a8ec9b2_f534414b","updated":"2016-09-20 20:27:17.000000000","message":"Good idea.","commit_id":"b1bc7d16d57303b85905706647f6061f03a3a7b9"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"83a65e33df3b0a7824f87610df56785611c49911","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            # Reference: Bug 1615852"},{"line_number":122,"context_line":"            if preferred_store \u003d\u003d \u0027filesystem\u0027:"},{"line_number":123,"context_line":"                preferred_store \u003d \u0027file\u0027"},{"line_number":124,"context_line":"            if preferred_store \u003d\u003d \u0027vmware_datastore\u0027:"},{"line_number":125,"context_line":"                preferred_store \u003d \u0027vmware\u0027"},{"line_number":126,"context_line":"            yield preferred_store"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"7a8ec9b2_553a5535","line":124,"range":{"start_line":124,"start_character":35,"end_line":124,"end_character":51},"updated":"2016-09-20 19:36:43.000000000","message":"same","commit_id":"b1bc7d16d57303b85905706647f6061f03a3a7b9"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"8386b98abdca3954848bec7e2f15fdfe31595d18","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            # ``vmware_datastore`` to ``file`` and ``vmware`` respectively"},{"line_number":119,"context_line":"            # are to make store names consistent in Glance and glance_store"},{"line_number":120,"context_line":"            # and also be backward compatible."},{"line_number":121,"context_line":"            # Reference: Bug 1615852"},{"line_number":122,"context_line":"            if preferred_store \u003d\u003d \u0027filesystem\u0027:"},{"line_number":123,"context_line":"                preferred_store \u003d \u0027file\u0027"},{"line_number":124,"context_line":"            if preferred_store \u003d\u003d \u0027vmware_datastore\u0027:"}],"source_content_type":"text/x-python","patch_set":20,"id":"7a8ec9b2_edfa78bc","line":121,"updated":"2016-09-21 16:26:44.000000000","message":"I would prefer to use oslo.config for option validation/enforcement as well as deprecation messaging and transformations if possible.\n\nIf that turns out to be significantly harder, please be sure to also note the removal in Pike release in this comment block as well.  If you can use oslo.config for the deprecation management then the code itself will allow you to specify the cycle for removal and the additional note in the block comment would not be necessary.","commit_id":"8145173aa1985ee49242a460d4cf7dc552cc6e57"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"91340b6b093b0d1a465f7159086634fc42d5c81d","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            # ``vmware_datastore`` to ``file`` and ``vmware`` respectively"},{"line_number":119,"context_line":"            # are to make store names consistent in Glance and glance_store"},{"line_number":120,"context_line":"            # and also be backward compatible."},{"line_number":121,"context_line":"            # Reference: Bug 1615852"},{"line_number":122,"context_line":"            if preferred_store \u003d\u003d \u0027filesystem\u0027:"},{"line_number":123,"context_line":"                preferred_store \u003d \u0027file\u0027"},{"line_number":124,"context_line":"            if preferred_store \u003d\u003d \u0027vmware_datastore\u0027:"}],"source_content_type":"text/x-python","patch_set":20,"id":"7a8ec9b2_928d90d5","line":121,"in_reply_to":"7a8ec9b2_edfa78bc","updated":"2016-09-21 17:01:26.000000000","message":"I agree but I don\u0027t know if oslo.config has a way to deprecate a particular value of a config opt directly or indirectly. Hence, my push to log a warn message.","commit_id":"8145173aa1985ee49242a460d4cf7dc552cc6e57"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"3b5f57632edc3f517e412406a6b1500cb98a8e49","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            if preferred_store \u003d\u003d \u0027filesystem\u0027:"},{"line_number":126,"context_line":"                preferred_store \u003d \u0027file\u0027"},{"line_number":127,"context_line":"                msg \u003d _LW(\u0027The value of ``filesystem`` in\u0027"},{"line_number":128,"context_line":"                          \u0027``store_type_preference`` is deprecated. It\\\u0027s\u0027"},{"line_number":129,"context_line":"                          \u0027support will be removed in the Pike release.\u0027"},{"line_number":130,"context_line":"                          \u0027Use of the new value ``file`` for\u0027"},{"line_number":131,"context_line":"                          \u0027``store_type_preference`` in ``glance-api.conf`` is\u0027"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a8ec9b2_a129549d","line":128,"range":{"start_line":128,"start_character":68,"end_line":128,"end_character":73},"updated":"2016-09-21 18:52:52.000000000","message":"its","commit_id":"49591160550845f3389d9944f2d370cd7209acd7"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"3b5f57632edc3f517e412406a6b1500cb98a8e49","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            # Reference: Bug 1615852"},{"line_number":125,"context_line":"            if preferred_store \u003d\u003d \u0027filesystem\u0027:"},{"line_number":126,"context_line":"                preferred_store \u003d \u0027file\u0027"},{"line_number":127,"context_line":"                msg \u003d _LW(\u0027The value of ``filesystem`` in\u0027"},{"line_number":128,"context_line":"                          \u0027``store_type_preference`` is deprecated. It\\\u0027s\u0027"},{"line_number":129,"context_line":"                          \u0027support will be removed in the Pike release.\u0027"},{"line_number":130,"context_line":"                          \u0027Use of the new value ``file`` for\u0027"},{"line_number":131,"context_line":"                          \u0027``store_type_preference`` in ``glance-api.conf`` is\u0027"},{"line_number":132,"context_line":"                          \u0027strongly recommended\u0027)"},{"line_number":133,"context_line":"                LOG.warning(msg)"},{"line_number":134,"context_line":"            if preferred_store \u003d\u003d \u0027vmware_datastore\u0027:"},{"line_number":135,"context_line":"                preferred_store \u003d \u0027vmware\u0027"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a8ec9b2_2c437b14","line":132,"range":{"start_line":127,"start_character":26,"end_line":132,"end_character":48},"updated":"2016-09-21 18:52:52.000000000","message":"How about \n\"\u0027The value ``filesystem`` is deprecated for use with ``store_type_preference``. It will be removed in the Pike release. Please use ``file`` instead\" ?","commit_id":"49591160550845f3389d9944f2d370cd7209acd7"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3f55b7d37ee15fdb1ca0e3da1aa39b0fbe619616","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                          \u0027support will be removed in the Pike release.\u0027"},{"line_number":130,"context_line":"                          \u0027Use of the new value ``file`` for\u0027"},{"line_number":131,"context_line":"                          \u0027``store_type_preference`` in ``glance-api.conf`` is\u0027"},{"line_number":132,"context_line":"                          \u0027strongly recommended\u0027)"},{"line_number":133,"context_line":"                LOG.warning(msg)"},{"line_number":134,"context_line":"            if preferred_store \u003d\u003d \u0027vmware_datastore\u0027:"},{"line_number":135,"context_line":"                preferred_store \u003d \u0027vmware\u0027"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a8ec9b2_cc4db773","line":132,"updated":"2016-09-21 18:47:26.000000000","message":"Two things: (1) you need spaces before the \u0027 at the end of each string or else the words will run together in the log message. (2) I think the message is confusing concerning whether the filesystem store itself or just the string \u0027filesystem\u0027 is being deprecated.\n\nHere\u0027s a suggestion you can start with for rewriting the message:\n\nThe value you have used for store_type_preference in glance-api.conf is DEPRECATED.  Instead of using \u0027filesystem\u0027, you should now use the value \u0027file\u0027.  Support for the DEPRECATED value will be removed in the Pike release.  Please see the Glance Newton release notes for more information.","commit_id":"49591160550845f3389d9944f2d370cd7209acd7"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"35c0bb6764f837684364b441a482dc81b6c6f98d","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            # Reference: Bug 1615852"},{"line_number":125,"context_line":"            if preferred_store \u003d\u003d \u0027filesystem\u0027:"},{"line_number":126,"context_line":"                preferred_store \u003d \u0027file\u0027"},{"line_number":127,"context_line":"                msg \u003d _LW(\u0027The value of ``filesystem`` in\u0027"},{"line_number":128,"context_line":"                          \u0027``store_type_preference`` is deprecated. It\\\u0027s\u0027"},{"line_number":129,"context_line":"                          \u0027support will be removed in the Pike release.\u0027"},{"line_number":130,"context_line":"                          \u0027Use of the new value ``file`` for\u0027"},{"line_number":131,"context_line":"                          \u0027``store_type_preference`` in ``glance-api.conf`` is\u0027"},{"line_number":132,"context_line":"                          \u0027strongly recommended\u0027)"},{"line_number":133,"context_line":"                LOG.warning(msg)"},{"line_number":134,"context_line":"            if preferred_store \u003d\u003d \u0027vmware_datastore\u0027:"},{"line_number":135,"context_line":"                preferred_store \u003d \u0027vmware\u0027"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a8ec9b2_c78f5021","line":132,"range":{"start_line":127,"start_character":26,"end_line":132,"end_character":48},"in_reply_to":"7a8ec9b2_2c437b14","updated":"2016-09-21 19:19:55.000000000","message":"Done","commit_id":"49591160550845f3389d9944f2d370cd7209acd7"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"f089574128a1c0a37fe2edde73c8a2db2a928be7","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                          \u0027Use of the new value ``file`` for\u0027"},{"line_number":131,"context_line":"                          \u0027``store_type_preference`` in ``glance-api.conf`` is\u0027"},{"line_number":132,"context_line":"                          \u0027strongly recommended\u0027)"},{"line_number":133,"context_line":"                LOG.warning(msg)"},{"line_number":134,"context_line":"            if preferred_store \u003d\u003d \u0027vmware_datastore\u0027:"},{"line_number":135,"context_line":"                preferred_store \u003d \u0027vmware\u0027"},{"line_number":136,"context_line":"                msg \u003d _LW(\u0027The value of ``vmware_datastore`` in\u0027"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a8ec9b2_6ccca389","line":133,"range":{"start_line":133,"start_character":20,"end_line":133,"end_character":27},"updated":"2016-09-21 18:56:00.000000000","message":"Although both LOG.warn and LOG.warning can be used. Let\u0027s use LOG.warn because we use that more often. I won\u0027t insist though :)","commit_id":"49591160550845f3389d9944f2d370cd7209acd7"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"35c0bb6764f837684364b441a482dc81b6c6f98d","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                          \u0027Use of the new value ``file`` for\u0027"},{"line_number":131,"context_line":"                          \u0027``store_type_preference`` in ``glance-api.conf`` is\u0027"},{"line_number":132,"context_line":"                          \u0027strongly recommended\u0027)"},{"line_number":133,"context_line":"                LOG.warning(msg)"},{"line_number":134,"context_line":"            if preferred_store \u003d\u003d \u0027vmware_datastore\u0027:"},{"line_number":135,"context_line":"                preferred_store \u003d \u0027vmware\u0027"},{"line_number":136,"context_line":"                msg \u003d _LW(\u0027The value of ``vmware_datastore`` in\u0027"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a8ec9b2_a7708441","line":133,"range":{"start_line":133,"start_character":20,"end_line":133,"end_character":27},"in_reply_to":"7a8ec9b2_6ccca389","updated":"2016-09-21 19:19:55.000000000","message":"Done","commit_id":"49591160550845f3389d9944f2d370cd7209acd7"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"3b5f57632edc3f517e412406a6b1500cb98a8e49","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            if preferred_store \u003d\u003d \u0027vmware_datastore\u0027:"},{"line_number":135,"context_line":"                preferred_store \u003d \u0027vmware\u0027"},{"line_number":136,"context_line":"                msg \u003d _LW(\u0027The value of ``vmware_datastore`` in\u0027"},{"line_number":137,"context_line":"                          \u0027``store_type_preference`` is deprecated. It\\\u0027s\u0027"},{"line_number":138,"context_line":"                          \u0027support will be removed in the Pike release.\u0027"},{"line_number":139,"context_line":"                          \u0027Use of the new value ``vmware`` for\u0027"},{"line_number":140,"context_line":"                          \u0027``store_type_preference`` in ``glance-api.conf`` is\u0027"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a8ec9b2_ac45cb43","line":137,"range":{"start_line":137,"start_character":68,"end_line":137,"end_character":73},"updated":"2016-09-21 18:52:52.000000000","message":"its","commit_id":"49591160550845f3389d9944f2d370cd7209acd7"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3f55b7d37ee15fdb1ca0e3da1aa39b0fbe619616","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                          \u0027support will be removed in the Pike release.\u0027"},{"line_number":139,"context_line":"                          \u0027Use of the new value ``vmware`` for\u0027"},{"line_number":140,"context_line":"                          \u0027``store_type_preference`` in ``glance-api.conf`` is\u0027"},{"line_number":141,"context_line":"                          \u0027strongly recommended\u0027)"},{"line_number":142,"context_line":"                LOG.warning(msg)"},{"line_number":143,"context_line":"            yield preferred_store"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7a8ec9b2_0c54fffb","line":141,"updated":"2016-09-21 18:47:26.000000000","message":"Same comment as above.","commit_id":"49591160550845f3389d9944f2d370cd7209acd7"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"3b5f57632edc3f517e412406a6b1500cb98a8e49","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                LOG.warning(msg)"},{"line_number":134,"context_line":"            if preferred_store \u003d\u003d \u0027vmware_datastore\u0027:"},{"line_number":135,"context_line":"                preferred_store \u003d \u0027vmware\u0027"},{"line_number":136,"context_line":"                msg \u003d _LW(\u0027The value of ``vmware_datastore`` in\u0027"},{"line_number":137,"context_line":"                          \u0027``store_type_preference`` is deprecated. It\\\u0027s\u0027"},{"line_number":138,"context_line":"                          \u0027support will be removed in the Pike release.\u0027"},{"line_number":139,"context_line":"                          \u0027Use of the new value ``vmware`` for\u0027"},{"line_number":140,"context_line":"                          \u0027``store_type_preference`` in ``glance-api.conf`` is\u0027"},{"line_number":141,"context_line":"                          \u0027strongly recommended\u0027)"},{"line_number":142,"context_line":"                LOG.warning(msg)"},{"line_number":143,"context_line":"            yield preferred_store"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7a8ec9b2_ac4f8b32","line":141,"range":{"start_line":136,"start_character":26,"end_line":141,"end_character":48},"updated":"2016-09-21 18:52:52.000000000","message":"same","commit_id":"49591160550845f3389d9944f2d370cd7209acd7"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"35c0bb6764f837684364b441a482dc81b6c6f98d","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                LOG.warning(msg)"},{"line_number":134,"context_line":"            if preferred_store \u003d\u003d \u0027vmware_datastore\u0027:"},{"line_number":135,"context_line":"                preferred_store \u003d \u0027vmware\u0027"},{"line_number":136,"context_line":"                msg \u003d _LW(\u0027The value of ``vmware_datastore`` in\u0027"},{"line_number":137,"context_line":"                          \u0027``store_type_preference`` is deprecated. It\\\u0027s\u0027"},{"line_number":138,"context_line":"                          \u0027support will be removed in the Pike release.\u0027"},{"line_number":139,"context_line":"                          \u0027Use of the new value ``vmware`` for\u0027"},{"line_number":140,"context_line":"                          \u0027``store_type_preference`` in ``glance-api.conf`` is\u0027"},{"line_number":141,"context_line":"                          \u0027strongly recommended\u0027)"},{"line_number":142,"context_line":"                LOG.warning(msg)"},{"line_number":143,"context_line":"            yield preferred_store"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7a8ec9b2_e7944c38","line":141,"range":{"start_line":136,"start_character":26,"end_line":141,"end_character":48},"in_reply_to":"7a8ec9b2_ac4f8b32","updated":"2016-09-21 19:19:55.000000000","message":"Done","commit_id":"49591160550845f3389d9944f2d370cd7209acd7"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"f089574128a1c0a37fe2edde73c8a2db2a928be7","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                          \u0027Use of the new value ``vmware`` for\u0027"},{"line_number":140,"context_line":"                          \u0027``store_type_preference`` in ``glance-api.conf`` is\u0027"},{"line_number":141,"context_line":"                          \u0027strongly recommended\u0027)"},{"line_number":142,"context_line":"                LOG.warning(msg)"},{"line_number":143,"context_line":"            yield preferred_store"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    if not locations:"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a8ec9b2_acc22b51","line":142,"range":{"start_line":142,"start_character":20,"end_line":142,"end_character":27},"updated":"2016-09-21 18:56:00.000000000","message":"same","commit_id":"49591160550845f3389d9944f2d370cd7209acd7"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"075c386f691ba6a08ddf163d048e2f28f25f87e7","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                msg \u003d _LW(\u0027The value ``filesystem`` is deprecated for use \u0027"},{"line_number":128,"context_line":"                          \u0027with ``store_type_preference``. It will be \u0027"},{"line_number":129,"context_line":"                          \u0027removed in the Pike release. Please use ``file`` \u0027"},{"line_number":130,"context_line":"                          \u0027instead\u0027)"},{"line_number":131,"context_line":"                LOG.warn(msg)"},{"line_number":132,"context_line":"            if preferred_store \u003d\u003d \u0027vmware_datastore\u0027:"},{"line_number":133,"context_line":"                preferred_store \u003d \u0027vmware\u0027"}],"source_content_type":"text/x-python","patch_set":22,"id":"7a8ec9b2_87ef08b0","line":130,"updated":"2016-09-21 19:23:19.000000000","message":"Oops looks like I missed the period at the end.\nAlso, let\u0027s add this line from Brian\u0027s suggestion\n\"Please see the Glance Newton release notes for more information.\"","commit_id":"4cf49a59c95ff7ffa8f5cf3ace36c5b4477f78e2"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"075c386f691ba6a08ddf163d048e2f28f25f87e7","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                msg \u003d _LW(\u0027The value ``vmware_datastore`` is deprecated for \u0027"},{"line_number":135,"context_line":"                          \u0027use with ``store_type_preference``. It will be \u0027"},{"line_number":136,"context_line":"                          \u0027removed in the Pike release. Please use ``vmware`` \u0027"},{"line_number":137,"context_line":"                          \u0027instead\u0027)"},{"line_number":138,"context_line":"                LOG.warn(msg)"},{"line_number":139,"context_line":"            yield preferred_store"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"7a8ec9b2_0732185e","line":137,"updated":"2016-09-21 19:23:19.000000000","message":"same","commit_id":"4cf49a59c95ff7ffa8f5cf3ace36c5b4477f78e2"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"69d578ee6b7f418f5320b8dd8fa64cffd549e0c3","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# NOTE(dharinic): We cannot restrict the choices for ``store_type_preference``"},{"line_number":28,"context_line":"# for backward compatability reasons. See Bug #1615852."},{"line_number":29,"context_line":"store_type_opts \u003d ["},{"line_number":30,"context_line":"    cfg.ListOpt(\u0027store_type_preference\u0027,"},{"line_number":31,"context_line":"                default\u003d[],"}],"source_content_type":"text/x-python","patch_set":24,"id":"7a8ec9b2_6374a9fd","line":28,"range":{"start_line":27,"start_character":0,"end_line":28,"end_character":55},"updated":"2016-09-21 22:06:20.000000000","message":"Should we get rid of this?","commit_id":"2995a01ca299f3efe127637c707cefc503a01a85"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"5611ca3dc2fafa95bf616c0e4513b028d6e44051","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            # Reference: Bug 1615852"},{"line_number":112,"context_line":"            if preferred_store \u003d\u003d \u0027filesystem\u0027:"},{"line_number":113,"context_line":"                preferred_store \u003d \u0027file\u0027"},{"line_number":114,"context_line":"                msg \u003d _LW(\u0027The value ``filesystem`` is deprecated for use \u0027"},{"line_number":115,"context_line":"                          \u0027with ``store_type_preference``. It will be \u0027"},{"line_number":116,"context_line":"                          \u0027removed in the Pike release. Please use ``file`` \u0027"},{"line_number":117,"context_line":"                          \u0027instead. Please see the Glance Newton release \u0027"}],"source_content_type":"text/x-python","patch_set":25,"id":"7a8ec9b2_69e9e7b6","line":114,"range":{"start_line":114,"start_character":55,"end_line":114,"end_character":65},"updated":"2016-09-22 00:44:19.000000000","message":"DEPRECATED","commit_id":"17bc05edffd72d2bd7589aa7edfabc161b620b38"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"5611ca3dc2fafa95bf616c0e4513b028d6e44051","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                LOG.warn(msg)"},{"line_number":120,"context_line":"            if preferred_store \u003d\u003d \u0027vmware_datastore\u0027:"},{"line_number":121,"context_line":"                preferred_store \u003d \u0027vmware\u0027"},{"line_number":122,"context_line":"                msg \u003d _LW(\u0027The value ``vmware_datastore`` is deprecated for \u0027"},{"line_number":123,"context_line":"                          \u0027use with ``store_type_preference``. It will be \u0027"},{"line_number":124,"context_line":"                          \u0027removed in the Pike release. Please use ``vmware`` \u0027"},{"line_number":125,"context_line":"                          \u0027instead. Please see the Glance Newton release \u0027"}],"source_content_type":"text/x-python","patch_set":25,"id":"7a8ec9b2_89d2b3fe","line":122,"range":{"start_line":122,"start_character":61,"end_line":122,"end_character":71},"updated":"2016-09-22 00:44:19.000000000","message":"ditto","commit_id":"17bc05edffd72d2bd7589aa7edfabc161b620b38"}],"glance/tests/unit/common/test_location_strategy.py":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"6c674443720a497c38b62669e1fa9ab6eb1387f2","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def test_get_ordered_locations(self):"},{"line_number":160,"context_line":"        self.config(store_type_preference\u003d[\u0027  rbd\u0027, \u0027sheepdog \u0027, \u0027 filesystem\u0027,"},{"line_number":161,"context_line":"                                           \u0027swift  \u0027, \u0027  http  \u0027, \u0027s3\u0027,"},{"line_number":162,"context_line":"                                           \u0027vmware_datastore\u0027],"},{"line_number":163,"context_line":"                    group\u003d\u0027store_type_location_strategy\u0027)"},{"line_number":164,"context_line":"        locs \u003d [{\u0027url\u0027: \u0027file://image0\u0027, \u0027metadata\u0027: {\u0027idx\u0027: 3}},"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_63772da0","line":161,"range":{"start_line":161,"start_character":66,"end_line":161,"end_character":70},"updated":"2016-09-16 21:15:49.000000000","message":"s3 has been removed from glance support system, so this needs to go.","commit_id":"194b4ec8b0f2d09e87ab836130552bb3a6eacca9"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"f7a141981fe0bddbe9b1ee5e7aab66c2f83aa400","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def test_get_ordered_locations(self):"},{"line_number":160,"context_line":"        self.config(store_type_preference\u003d[\u0027  rbd\u0027, \u0027sheepdog \u0027, \u0027 filesystem\u0027,"},{"line_number":161,"context_line":"                                           \u0027swift  \u0027, \u0027  http  \u0027, \u0027s3\u0027,"},{"line_number":162,"context_line":"                                           \u0027vmware_datastore\u0027],"},{"line_number":163,"context_line":"                    group\u003d\u0027store_type_location_strategy\u0027)"},{"line_number":164,"context_line":"        locs \u003d [{\u0027url\u0027: \u0027file://image0\u0027, \u0027metadata\u0027: {\u0027idx\u0027: 3}},"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_3c5546c5","line":161,"range":{"start_line":161,"start_character":66,"end_line":161,"end_character":70},"in_reply_to":"7a8ec9b2_63772da0","updated":"2016-09-16 22:53:50.000000000","message":"Done","commit_id":"194b4ec8b0f2d09e87ab836130552bb3a6eacca9"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"6c674443720a497c38b62669e1fa9ab6eb1387f2","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        # The result will ordered by preferred store type order."},{"line_number":193,"context_line":"        self.assertEqual(locs, ordered_locs)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def test_get_ordered_locations_with_updated_store_name(self):"},{"line_number":196,"context_line":"        self.config(store_type_preference\u003d[\u0027  rbd\u0027, \u0027sheepdog \u0027, \u0027file\u0027,"},{"line_number":197,"context_line":"                                           \u0027swift  \u0027, \u0027 http  \u0027, \u0027vmware\u0027],"},{"line_number":198,"context_line":"                    group\u003d\u0027store_type_location_strategy\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_03ae69e5","line":195,"range":{"start_line":195,"start_character":35,"end_line":195,"end_character":58},"updated":"2016-09-16 21:15:49.000000000","message":"this test will become outdated with future changes and slip from reviewers notice.\n\nmay be say \n\ntest_get_ordered_locations_with_consistent_store_names","commit_id":"194b4ec8b0f2d09e87ab836130552bb3a6eacca9"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"f7a141981fe0bddbe9b1ee5e7aab66c2f83aa400","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        # The result will ordered by preferred store type order."},{"line_number":193,"context_line":"        self.assertEqual(locs, ordered_locs)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def test_get_ordered_locations_with_updated_store_name(self):"},{"line_number":196,"context_line":"        self.config(store_type_preference\u003d[\u0027  rbd\u0027, \u0027sheepdog \u0027, \u0027file\u0027,"},{"line_number":197,"context_line":"                                           \u0027swift  \u0027, \u0027 http  \u0027, \u0027vmware\u0027],"},{"line_number":198,"context_line":"                    group\u003d\u0027store_type_location_strategy\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_fc4e7e39","line":195,"range":{"start_line":195,"start_character":35,"end_line":195,"end_character":58},"in_reply_to":"7a8ec9b2_03ae69e5","updated":"2016-09-16 22:53:50.000000000","message":"Done","commit_id":"194b4ec8b0f2d09e87ab836130552bb3a6eacca9"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"6c674443720a497c38b62669e1fa9ab6eb1387f2","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        self.assertEqual(locs, ordered_locs)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def test_get_ordered_locations_with_updated_store_name(self):"},{"line_number":196,"context_line":"        self.config(store_type_preference\u003d[\u0027  rbd\u0027, \u0027sheepdog \u0027, \u0027file\u0027,"},{"line_number":197,"context_line":"                                           \u0027swift  \u0027, \u0027 http  \u0027, \u0027vmware\u0027],"},{"line_number":198,"context_line":"                    group\u003d\u0027store_type_location_strategy\u0027)"},{"line_number":199,"context_line":"        locs \u003d [{\u0027url\u0027: \u0027file://image0\u0027, \u0027metadata\u0027: {\u0027idx\u0027: 3}},"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_8388b972","line":196,"updated":"2016-09-16 21:15:49.000000000","message":"add a docstring to this test including info for the reason we are calling consistent store names","commit_id":"194b4ec8b0f2d09e87ab836130552bb3a6eacca9"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"f7a141981fe0bddbe9b1ee5e7aab66c2f83aa400","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        self.assertEqual(locs, ordered_locs)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def test_get_ordered_locations_with_updated_store_name(self):"},{"line_number":196,"context_line":"        self.config(store_type_preference\u003d[\u0027  rbd\u0027, \u0027sheepdog \u0027, \u0027file\u0027,"},{"line_number":197,"context_line":"                                           \u0027swift  \u0027, \u0027 http  \u0027, \u0027vmware\u0027],"},{"line_number":198,"context_line":"                    group\u003d\u0027store_type_location_strategy\u0027)"},{"line_number":199,"context_line":"        locs \u003d [{\u0027url\u0027: \u0027file://image0\u0027, \u0027metadata\u0027: {\u0027idx\u0027: 3}},"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_1c4a4a26","line":196,"in_reply_to":"7a8ec9b2_8388b972","updated":"2016-09-16 22:53:50.000000000","message":"Done","commit_id":"194b4ec8b0f2d09e87ab836130552bb3a6eacca9"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"6df4b8d34c6812a36785c66ed063a891aa7709cd","unresolved":false,"context_lines":[{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def test_get_ordered_locations_with_consistent_store_names(self):"},{"line_number":196,"context_line":"        \"\"\"This test is for the change made with respect to making store names"},{"line_number":197,"context_line":"        in glance to be consistent with store names used in glance_store."},{"line_number":198,"context_line":"        \"\"\""},{"line_number":199,"context_line":"        self.config(store_type_preference\u003d[\u0027  rbd\u0027, \u0027sheepdog \u0027, \u0027file\u0027,"},{"line_number":200,"context_line":"                                           \u0027swift  \u0027, \u0027 http  \u0027, \u0027vmware\u0027],"}],"source_content_type":"text/x-python","patch_set":17,"id":"7a8ec9b2_2995fb31","line":197,"updated":"2016-09-17 18:15:56.000000000","message":"add bug #","commit_id":"fd6c22e7afa2d41e4ff32d299c253e07ee2869fc"}],"releasenotes/notes/consistent-store-names-57374b9505d530d0.yaml":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"6df4b8d34c6812a36785c66ed063a891aa7709cd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Store names in glance and glance_store now consistent. Please refer to the"},{"line_number":4,"context_line":"    ``upgrade`` section for morevinformation."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7a8ec9b2_89d1af25","line":3,"range":{"start_line":3,"start_character":43,"end_line":3,"end_character":46},"updated":"2016-09-17 18:15:56.000000000","message":"are now consistent","commit_id":"fd6c22e7afa2d41e4ff32d299c253e07ee2869fc"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"6df4b8d34c6812a36785c66ed063a891aa7709cd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Store names in glance and glance_store now consistent. Please refer to the"},{"line_number":4,"context_line":"    ``upgrade`` section for morevinformation."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - The names used to refer to stores in glance and glance_store are now"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7a8ec9b2_49b3270a","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":45},"updated":"2016-09-17 18:15:56.000000000","message":"Please use bullet points for prelude too. I think we need to include that in our docs but that\u0027s a better look to the release notes http://docs.openstack.org/releasenotes/glance/newton.html\n\nAlso, in releasenotes we wrap at 61 (max width is 60). (need to update the docs)","commit_id":"fd6c22e7afa2d41e4ff32d299c253e07ee2869fc"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"6df4b8d34c6812a36785c66ed063a891aa7709cd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Store names in glance and glance_store now consistent. Please refer to the"},{"line_number":4,"context_line":"    ``upgrade`` section for morevinformation."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - The names used to refer to stores in glance and glance_store are now"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7a8ec9b2_c9c73762","line":4,"range":{"start_line":3,"start_character":59,"end_line":4,"end_character":45},"updated":"2016-09-17 18:15:56.000000000","message":"we have decided to not use this line in prelude as it seems rather redundant \"Please refer to the ``upgrade`` section for morevinformation.\" so remove it.","commit_id":"fd6c22e7afa2d41e4ff32d299c253e07ee2869fc"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"6df4b8d34c6812a36785c66ed063a891aa7709cd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    ``upgrade`` section for morevinformation."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - The names used to refer to stores in glance and glance_store are now"},{"line_number":8,"context_line":"    made consistent. The store names ``vmware_datastore`` and ``filesystem``"},{"line_number":9,"context_line":"    are now mapped to ``vmware`` and ``file`` respectively. This facilitates"},{"line_number":10,"context_line":"    consistency with glance_store entry point names and at the same time"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7a8ec9b2_e9c23352","line":7,"range":{"start_line":7,"start_character":28,"end_line":7,"end_character":30},"updated":"2016-09-17 18:15:56.000000000","message":"s/to//","commit_id":"fd6c22e7afa2d41e4ff32d299c253e07ee2869fc"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"6df4b8d34c6812a36785c66ed063a891aa7709cd","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - The names used to refer to stores in glance and glance_store are now"},{"line_number":8,"context_line":"    made consistent. The store names ``vmware_datastore`` and ``filesystem``"},{"line_number":9,"context_line":"    are now mapped to ``vmware`` and ``file`` respectively. This facilitates"},{"line_number":10,"context_line":"    consistency with glance_store entry point names and at the same time"},{"line_number":11,"context_line":"    accommodates backward compatibility for old configuration files that"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7a8ec9b2_49aa4786","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":8},"updated":"2016-09-17 18:15:56.000000000","message":"s/made//","commit_id":"fd6c22e7afa2d41e4ff32d299c253e07ee2869fc"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"6df4b8d34c6812a36785c66ed063a891aa7709cd","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - The names used to refer to stores in glance and glance_store are now"},{"line_number":8,"context_line":"    made consistent. The store names ``vmware_datastore`` and ``filesystem``"},{"line_number":9,"context_line":"    are now mapped to ``vmware`` and ``file`` respectively. This facilitates"},{"line_number":10,"context_line":"    consistency with glance_store entry point names and at the same time"},{"line_number":11,"context_line":"    accommodates backward compatibility for old configuration files that"},{"line_number":12,"context_line":"    might still be using the old store names."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7a8ec9b2_e9707342","line":9,"range":{"start_line":8,"start_character":21,"end_line":9,"end_character":59},"updated":"2016-09-17 18:15:56.000000000","message":"This information is useless and even confusing for the operators.\n\nMay be have:\n\nOperators can choose to use store names ``vmware`` and ``file`` in their configuration files \u003cspecify the files\u003e as opposed to earlier requirement to use ``vmware_datastore`` and ``filesystem`` for the vsphere and filesystem stores. This facilitates consistency between glance_store entry point names, store names in glance_store configurations and in glance configuration files. It also accommodates backward compatibility for old configuration files that might still be using the old references namely ``vmware_datastore`` and ``filesystem``. You can continue to use either ``vmware`` and ``file`` or ``vmware_datastore`` and ``filesystem``. However, we strongly recommending using ``vmware`` and ``file``.","commit_id":"fd6c22e7afa2d41e4ff32d299c253e07ee2869fc"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"83a65e33df3b0a7824f87610df56785611c49911","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    ``vmware_datastore`` and ``filesystem``. You can"},{"line_number":19,"context_line":"    continue to use either ``vmware`` and ``file`` or"},{"line_number":20,"context_line":"    ``vmware_datastore`` and ``filesystem``. However, we"},{"line_number":21,"context_line":"    strongly recommending using ``vmware`` and ``file``."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"7a8ec9b2_95edbdb9","line":21,"updated":"2016-09-20 19:36:43.000000000","message":"Looks good but should we mention that support for the old names will be dropped in the next couple of cycles?","commit_id":"b1bc7d16d57303b85905706647f6061f03a3a7b9"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"c2e9bc521fa03a76207da35d787b46bf165f8a2b","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    ``vmware_datastore`` and ``filesystem``. You can"},{"line_number":19,"context_line":"    continue to use either ``vmware`` and ``file`` or"},{"line_number":20,"context_line":"    ``vmware_datastore`` and ``filesystem``. However, we"},{"line_number":21,"context_line":"    strongly recommending using ``vmware`` and ``file``."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"7a8ec9b2_bd261f66","line":21,"in_reply_to":"7a8ec9b2_95edbdb9","updated":"2016-09-20 20:55:33.000000000","message":"I wasn\u0027t keen on removing them. I think these will work great as aliases (like for Config opts) and ops don\u0027t really have to worry.\n\nI\u0027m not sure about removing them.","commit_id":"b1bc7d16d57303b85905706647f6061f03a3a7b9"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e7f5d43950fea0c05e139bc1d88336ee28eb2664","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"7a8ec9b2_ba6e25c7","line":22,"updated":"2016-09-20 20:27:17.000000000","message":"After not looking at this for a week or so, I find this message confusing and vague (and I say that in the knowledge that I +2\u0027d this not very long ago!).   I suggest we rewrite to be more specific about what the problem is and what we are asking operators to do.  Something like this:\n\n  upgrade:\n  - |\n    Some backend store names were inconsistent between glance\n    and glance_store.  This meant that users of the VMware\n    datastore or file system store were required to use store\n    names in ``glance-api.conf`` that did not correspond to\n    any valid identifier in glance_store.  As this situation\n    encouraged misconfiguration and operator unhappiness, we\n    have made the store names consistent in the Newton\n    release.  What this means for you:\n  \n    - This change applies only to operators who are using\n      multiple image locations.\n    - This change applies only to operators using the VMware\n      datastore or filesystem stores.\n    - This change applies only to the ``store_type_preference``\n      option.\n    - *VMware datastore users*: the old name, now\n      **deprecated**, was ``vmware_datastore``.  The **new**\n      name, used in both glance and glance_store, is\n      ``vmware``.\n    - *File system store users*: the old name, now\n      **deprecated**, was ``filesystem``.  The **new** name,\n      used in both glance and glance_store, is ``file``.\n    - During the deprecation period, this change is backward\n      compatible, that is, the old names will be recognized by\n      the code.  *The deprecation period will end with the\n      Ocata release.*\n    - We strongly encourage operators to modify their\n      ``glance-api.conf`` files immediately to use the **new**\n      names.\n\nNote that the text has Ocata as the release where the backward compat will be pulled, not sure if that\u0027s too soon, though.","commit_id":"b1bc7d16d57303b85905706647f6061f03a3a7b9"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"b220d170a9fbd589b8c92736653468252c1886c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"7a8ec9b2_29856dac","line":22,"in_reply_to":"7a8ec9b2_7db657dd","updated":"2016-09-20 23:37:40.000000000","message":"Done","commit_id":"b1bc7d16d57303b85905706647f6061f03a3a7b9"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"b220d170a9fbd589b8c92736653468252c1886c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"7a8ec9b2_e9a2a54a","line":22,"in_reply_to":"7a8ec9b2_ba6e25c7","updated":"2016-09-20 23:37:40.000000000","message":"Done","commit_id":"b1bc7d16d57303b85905706647f6061f03a3a7b9"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"c2e9bc521fa03a76207da35d787b46bf165f8a2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"7a8ec9b2_7db657dd","line":22,"in_reply_to":"7a8ec9b2_ba6e25c7","updated":"2016-09-20 20:55:33.000000000","message":"Oh no, we can\u0027t remove this in Ocata.\n\nThough, you do mention the deprecation to end with Ocata. I don\u0027t think that\u0027s consistent with what we\u0027ve used in other places. I\u0027d prefer keeping it simple and saying this will be removed in Pike release.","commit_id":"b1bc7d16d57303b85905706647f6061f03a3a7b9"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"e75af2b9e4292c15ae1635b11fc5d59130da70ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"7a8ec9b2_ddcdabb8","line":22,"in_reply_to":"7a8ec9b2_ba6e25c7","updated":"2016-09-20 20:49:05.000000000","message":"Thanks for the nice suggestion Brian.\n\nI think we need to be consistent of the work \"users\" overall in openstack -- it means end-users.\n\nPlease use either \"admins\" or \"operators\" instead of users, for example instead of *VMware datastore users* try *VMware datastore operators*","commit_id":"b1bc7d16d57303b85905706647f6061f03a3a7b9"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"b220d170a9fbd589b8c92736653468252c1886c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"7a8ec9b2_098a71bf","line":22,"in_reply_to":"7a8ec9b2_ddcdabb8","updated":"2016-09-20 23:37:40.000000000","message":"Done","commit_id":"b1bc7d16d57303b85905706647f6061f03a3a7b9"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"ac30ad5a2f1a9fec35261c34e5cdf7dbc056e714","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    consistent."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - Some backend store names were inconsistent between glance"},{"line_number":8,"context_line":"    and glance_store.  This meant that operatorss of the"},{"line_number":9,"context_line":"    VMware datastore or file system store were required to use"},{"line_number":10,"context_line":"    store names in ``glance-api.conf`` that did not correspond"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7a8ec9b2_29fe4d38","line":7,"updated":"2016-09-20 23:41:22.000000000","message":"there\u0027s a reason Brian suggested that formatting.\n\nSee the example here: http://docs.openstack.org/developer/reno/usage.html#formatting\n\nyou need \"|\" in the first bullet point\n\nalso blank line before the sub-points (line 15)","commit_id":"81935bbc6d743c037d5c1989129c5ab582de4668"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"6b257210644aba29f216bb1b9c39b68eefe6bab6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    consistent."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - Some backend store names were inconsistent between glance"},{"line_number":8,"context_line":"    and glance_store.  This meant that operatorss of the"},{"line_number":9,"context_line":"    VMware datastore or file system store were required to use"},{"line_number":10,"context_line":"    store names in ``glance-api.conf`` that did not correspond"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7a8ec9b2_741cacc1","line":7,"in_reply_to":"7a8ec9b2_29fe4d38","updated":"2016-09-21 00:24:13.000000000","message":"My bad. For some reason my pep8 was throwing errors when I used that formatting. Will revert back.","commit_id":"81935bbc6d743c037d5c1989129c5ab582de4668"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"fe0dcb2edf10826f7d161f8fc7da8af2501a4889","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    consistent."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - Some backend store names were inconsistent between glance"},{"line_number":8,"context_line":"    and glance_store.  This meant that operatorss of the"},{"line_number":9,"context_line":"    VMware datastore or file system store were required to use"},{"line_number":10,"context_line":"    store names in ``glance-api.conf`` that did not correspond"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7a8ec9b2_97b057df","line":7,"in_reply_to":"7a8ec9b2_741cacc1","updated":"2016-09-21 02:41:29.000000000","message":"not sure how it looked when you copied, just make sure you get it the way it\u0027s shown in the docs","commit_id":"81935bbc6d743c037d5c1989129c5ab582de4668"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"22c04be892dbc3657a99b11c0eed1db6dd41f5c8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    consistent."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - Some backend store names were inconsistent between glance"},{"line_number":8,"context_line":"    and glance_store.  This meant that operatorss of the"},{"line_number":9,"context_line":"    VMware datastore or file system store were required to use"},{"line_number":10,"context_line":"    store names in ``glance-api.conf`` that did not correspond"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7a8ec9b2_461ef1bb","line":7,"in_reply_to":"7a8ec9b2_97b057df","updated":"2016-09-21 15:27:29.000000000","message":"Done","commit_id":"81935bbc6d743c037d5c1989129c5ab582de4668"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"ac30ad5a2f1a9fec35261c34e5cdf7dbc056e714","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    have made the store names consistent in the Newton"},{"line_number":14,"context_line":"    release.  What this means for you -"},{"line_number":15,"context_line":"    - This change applies only to operators who are using"},{"line_number":16,"context_line":"      multiple image locations."},{"line_number":17,"context_line":"    - This change applies only to operators using the VMware"},{"line_number":18,"context_line":"      datastore or filesystem stores."},{"line_number":19,"context_line":"    - This change applies only to the ``store_type_preference``"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7a8ec9b2_49ab991d","line":16,"range":{"start_line":16,"start_character":30,"end_line":16,"end_character":31},"updated":"2016-09-20 23:41:22.000000000","message":"remove the periods, as the message is fragmented","commit_id":"81935bbc6d743c037d5c1989129c5ab582de4668"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"22c04be892dbc3657a99b11c0eed1db6dd41f5c8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    have made the store names consistent in the Newton"},{"line_number":14,"context_line":"    release.  What this means for you -"},{"line_number":15,"context_line":"    - This change applies only to operators who are using"},{"line_number":16,"context_line":"      multiple image locations."},{"line_number":17,"context_line":"    - This change applies only to operators using the VMware"},{"line_number":18,"context_line":"      datastore or filesystem stores."},{"line_number":19,"context_line":"    - This change applies only to the ``store_type_preference``"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7a8ec9b2_661bedca","line":16,"range":{"start_line":16,"start_character":30,"end_line":16,"end_character":31},"in_reply_to":"7a8ec9b2_49ab991d","updated":"2016-09-21 15:27:29.000000000","message":"Done","commit_id":"81935bbc6d743c037d5c1989129c5ab582de4668"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"ac30ad5a2f1a9fec35261c34e5cdf7dbc056e714","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    - This change applies only to operators who are using"},{"line_number":16,"context_line":"      multiple image locations."},{"line_number":17,"context_line":"    - This change applies only to operators using the VMware"},{"line_number":18,"context_line":"      datastore or filesystem stores."},{"line_number":19,"context_line":"    - This change applies only to the ``store_type_preference``"},{"line_number":20,"context_line":"      option."},{"line_number":21,"context_line":"    - *VMware datastore operators*: The old name, now"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7a8ec9b2_8963e119","line":18,"range":{"start_line":18,"start_character":36,"end_line":18,"end_character":37},"updated":"2016-09-20 23:41:22.000000000","message":"ditto, all points","commit_id":"81935bbc6d743c037d5c1989129c5ab582de4668"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"22c04be892dbc3657a99b11c0eed1db6dd41f5c8","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    - This change applies only to operators who are using"},{"line_number":16,"context_line":"      multiple image locations."},{"line_number":17,"context_line":"    - This change applies only to operators using the VMware"},{"line_number":18,"context_line":"      datastore or filesystem stores."},{"line_number":19,"context_line":"    - This change applies only to the ``store_type_preference``"},{"line_number":20,"context_line":"      option."},{"line_number":21,"context_line":"    - *VMware datastore operators*: The old name, now"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7a8ec9b2_867ab9ef","line":18,"range":{"start_line":18,"start_character":36,"end_line":18,"end_character":37},"in_reply_to":"7a8ec9b2_8963e119","updated":"2016-09-21 15:27:29.000000000","message":"Done","commit_id":"81935bbc6d743c037d5c1989129c5ab582de4668"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"ac30ad5a2f1a9fec35261c34e5cdf7dbc056e714","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    - This change applies only to the ``store_type_preference``"},{"line_number":20,"context_line":"      option."},{"line_number":21,"context_line":"    - *VMware datastore operators*: The old name, now"},{"line_number":22,"context_line":"      **deprecated**, was ``vmware_datastore``.  The **new**"},{"line_number":23,"context_line":"      name, used in both glance and glance_store, is"},{"line_number":24,"context_line":"      ``vmware``."},{"line_number":25,"context_line":"    - *File system store operators*: the old name, now"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7a8ec9b2_e970e5de","line":22,"range":{"start_line":22,"start_character":8,"end_line":22,"end_character":18},"updated":"2016-09-20 23:41:22.000000000","message":"for consistency sake, make this caps http://docs.openstack.org/releasenotes/glance/newton.html#upgrade-notes\n\nthe caps comes from what exists in the source code and bold is strong message.","commit_id":"81935bbc6d743c037d5c1989129c5ab582de4668"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"22c04be892dbc3657a99b11c0eed1db6dd41f5c8","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    - This change applies only to the ``store_type_preference``"},{"line_number":20,"context_line":"      option."},{"line_number":21,"context_line":"    - *VMware datastore operators*: The old name, now"},{"line_number":22,"context_line":"      **deprecated**, was ``vmware_datastore``.  The **new**"},{"line_number":23,"context_line":"      name, used in both glance and glance_store, is"},{"line_number":24,"context_line":"      ``vmware``."},{"line_number":25,"context_line":"    - *File system store operators*: the old name, now"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7a8ec9b2_a67fb5de","line":22,"range":{"start_line":22,"start_character":8,"end_line":22,"end_character":18},"in_reply_to":"7a8ec9b2_e970e5de","updated":"2016-09-21 15:27:29.000000000","message":"Done","commit_id":"81935bbc6d743c037d5c1989129c5ab582de4668"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"ac30ad5a2f1a9fec35261c34e5cdf7dbc056e714","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      name, used in both glance and glance_store, is"},{"line_number":24,"context_line":"      ``vmware``."},{"line_number":25,"context_line":"    - *File system store operators*: the old name, now"},{"line_number":26,"context_line":"      **deprecated**, was ``filesystem``.  The **new** name,"},{"line_number":27,"context_line":"      used in both glance and glance_store, is ``file``."},{"line_number":28,"context_line":"    - During the deprecation period, this change is backward"},{"line_number":29,"context_line":"      compatible, that is, the old names will be recognized by"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7a8ec9b2_0978b1c3","line":26,"range":{"start_line":26,"start_character":8,"end_line":26,"end_character":18},"updated":"2016-09-20 23:41:22.000000000","message":"ditto","commit_id":"81935bbc6d743c037d5c1989129c5ab582de4668"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"22c04be892dbc3657a99b11c0eed1db6dd41f5c8","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      name, used in both glance and glance_store, is"},{"line_number":24,"context_line":"      ``vmware``."},{"line_number":25,"context_line":"    - *File system store operators*: the old name, now"},{"line_number":26,"context_line":"      **deprecated**, was ``filesystem``.  The **new** name,"},{"line_number":27,"context_line":"      used in both glance and glance_store, is ``file``."},{"line_number":28,"context_line":"    - During the deprecation period, this change is backward"},{"line_number":29,"context_line":"      compatible, that is, the old names will be recognized by"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7a8ec9b2_c68041c2","line":26,"range":{"start_line":26,"start_character":8,"end_line":26,"end_character":18},"in_reply_to":"7a8ec9b2_0978b1c3","updated":"2016-09-21 15:27:29.000000000","message":"Done","commit_id":"81935bbc6d743c037d5c1989129c5ab582de4668"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"ac30ad5a2f1a9fec35261c34e5cdf7dbc056e714","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    - *File system store operators*: the old name, now"},{"line_number":26,"context_line":"      **deprecated**, was ``filesystem``.  The **new** name,"},{"line_number":27,"context_line":"      used in both glance and glance_store, is ``file``."},{"line_number":28,"context_line":"    - During the deprecation period, this change is backward"},{"line_number":29,"context_line":"      compatible, that is, the old names will be recognized by"},{"line_number":30,"context_line":"      the code.  They will be removed in the Pike release."},{"line_number":31,"context_line":"    - We strongly encourage operators to modify their"},{"line_number":32,"context_line":"      ``glance-api.conf`` files immediately to use the **new**"},{"line_number":33,"context_line":"      names."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7a8ec9b2_095fd141","line":30,"range":{"start_line":28,"start_character":6,"end_line":30,"end_character":58},"updated":"2016-09-20 23:41:22.000000000","message":"I don\u0027t think we reached agreement if we need to deprecate it as I need to get back opinions why people think we should.\n\nAlso, there\u0027s no warning message in the code so this needs further eval.","commit_id":"81935bbc6d743c037d5c1989129c5ab582de4668"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"6b257210644aba29f216bb1b9c39b68eefe6bab6","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    - *File system store operators*: the old name, now"},{"line_number":26,"context_line":"      **deprecated**, was ``filesystem``.  The **new** name,"},{"line_number":27,"context_line":"      used in both glance and glance_store, is ``file``."},{"line_number":28,"context_line":"    - During the deprecation period, this change is backward"},{"line_number":29,"context_line":"      compatible, that is, the old names will be recognized by"},{"line_number":30,"context_line":"      the code.  They will be removed in the Pike release."},{"line_number":31,"context_line":"    - We strongly encourage operators to modify their"},{"line_number":32,"context_line":"      ``glance-api.conf`` files immediately to use the **new**"},{"line_number":33,"context_line":"      names."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7a8ec9b2_3485c4ac","line":30,"range":{"start_line":28,"start_character":6,"end_line":30,"end_character":58},"in_reply_to":"7a8ec9b2_095fd141","updated":"2016-09-21 00:24:13.000000000","message":"Can you please clarify what we can have hear?\n\nMaybe just \"This change is backward compatible, that is, the old names                \nwill be recognized by the code.\" ?","commit_id":"81935bbc6d743c037d5c1989129c5ab582de4668"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"fe0dcb2edf10826f7d161f8fc7da8af2501a4889","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    - *File system store operators*: the old name, now"},{"line_number":26,"context_line":"      **deprecated**, was ``filesystem``.  The **new** name,"},{"line_number":27,"context_line":"      used in both glance and glance_store, is ``file``."},{"line_number":28,"context_line":"    - During the deprecation period, this change is backward"},{"line_number":29,"context_line":"      compatible, that is, the old names will be recognized by"},{"line_number":30,"context_line":"      the code.  They will be removed in the Pike release."},{"line_number":31,"context_line":"    - We strongly encourage operators to modify their"},{"line_number":32,"context_line":"      ``glance-api.conf`` files immediately to use the **new**"},{"line_number":33,"context_line":"      names."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7a8ec9b2_57ddef12","line":30,"range":{"start_line":28,"start_character":6,"end_line":30,"end_character":58},"in_reply_to":"7a8ec9b2_3485c4ac","updated":"2016-09-21 02:41:29.000000000","message":"yes, that looks good to me","commit_id":"81935bbc6d743c037d5c1989129c5ab582de4668"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"22c04be892dbc3657a99b11c0eed1db6dd41f5c8","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    - *File system store operators*: the old name, now"},{"line_number":26,"context_line":"      **deprecated**, was ``filesystem``.  The **new** name,"},{"line_number":27,"context_line":"      used in both glance and glance_store, is ``file``."},{"line_number":28,"context_line":"    - During the deprecation period, this change is backward"},{"line_number":29,"context_line":"      compatible, that is, the old names will be recognized by"},{"line_number":30,"context_line":"      the code.  They will be removed in the Pike release."},{"line_number":31,"context_line":"    - We strongly encourage operators to modify their"},{"line_number":32,"context_line":"      ``glance-api.conf`` files immediately to use the **new**"},{"line_number":33,"context_line":"      names."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7a8ec9b2_e6853dcf","line":30,"range":{"start_line":28,"start_character":6,"end_line":30,"end_character":58},"in_reply_to":"7a8ec9b2_57ddef12","updated":"2016-09-21 15:27:29.000000000","message":"Done","commit_id":"81935bbc6d743c037d5c1989129c5ab582de4668"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"f32eae8e265803e575d78dd30f3d0134a9d9cce1","unresolved":false,"context_lines":[{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    Some backend store names were inconsistent between glance"},{"line_number":9,"context_line":"    and glance_store.  This meant that operatorss of the"},{"line_number":10,"context_line":"    VMware datastore or file system store were required to use"},{"line_number":11,"context_line":"    store names in ``glance-api.conf`` that did not correspond"},{"line_number":12,"context_line":"    to any valid identifier in glance_store.  As this situation"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"7a8ec9b2_799c72c0","line":9,"range":{"start_line":9,"start_character":39,"end_line":9,"end_character":49},"updated":"2016-09-21 15:40:20.000000000","message":"operators","commit_id":"8145173aa1985ee49242a460d4cf7dc552cc6e57"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"cd94f4b9aab28f92d27d7bf5ed5984db2d490560","unresolved":false,"context_lines":[{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    Some backend store names were inconsistent between glance"},{"line_number":9,"context_line":"    and glance_store.  This meant that operatorss of the"},{"line_number":10,"context_line":"    VMware datastore or file system store were required to use"},{"line_number":11,"context_line":"    store names in ``glance-api.conf`` that did not correspond"},{"line_number":12,"context_line":"    to any valid identifier in glance_store.  As this situation"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"7a8ec9b2_729004ee","line":9,"range":{"start_line":9,"start_character":39,"end_line":9,"end_character":49},"in_reply_to":"7a8ec9b2_799c72c0","updated":"2016-09-21 17:39:09.000000000","message":"Done","commit_id":"8145173aa1985ee49242a460d4cf7dc552cc6e57"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"58754c0547994023a5427be7e88cdf06cfef52e2","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    to any valid identifier in glance_store.  As this situation"},{"line_number":13,"context_line":"    encouraged misconfiguration and operator unhappiness, we"},{"line_number":14,"context_line":"    have made the store names consistent in the Newton"},{"line_number":15,"context_line":"    release.  What this means for you -"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    - This change applies only to operators who are using"},{"line_number":18,"context_line":"      multiple image locations"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"7a8ec9b2_6d5f48e5","line":15,"range":{"start_line":15,"start_character":37,"end_line":15,"end_character":39},"updated":"2016-09-21 16:24:49.000000000","message":"nit: I think this should be a colon instead of a dash","commit_id":"8145173aa1985ee49242a460d4cf7dc552cc6e57"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3e515e1cdf609ed6bbed1e2c24f65e410257835e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    to any valid identifier in glance_store.  As this situation"},{"line_number":13,"context_line":"    encouraged misconfiguration and operator unhappiness, we"},{"line_number":14,"context_line":"    have made the store names consistent in the Newton"},{"line_number":15,"context_line":"    release.  What this means for you -"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    - This change applies only to operators who are using"},{"line_number":18,"context_line":"      multiple image locations"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"7a8ec9b2_ac8a2b62","line":15,"range":{"start_line":15,"start_character":37,"end_line":15,"end_character":39},"in_reply_to":"7a8ec9b2_528788b4","updated":"2016-09-21 18:53:00.000000000","message":"The only way to tell is to build the release notes.  I\u0027ve noticed that not all ReST markup works properly in release notes (for instance, you can\u0027t begin an item with a word enclosed in ``).  But a colon is OK in this location in ReST.","commit_id":"8145173aa1985ee49242a460d4cf7dc552cc6e57"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"cd94f4b9aab28f92d27d7bf5ed5984db2d490560","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    to any valid identifier in glance_store.  As this situation"},{"line_number":13,"context_line":"    encouraged misconfiguration and operator unhappiness, we"},{"line_number":14,"context_line":"    have made the store names consistent in the Newton"},{"line_number":15,"context_line":"    release.  What this means for you -"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    - This change applies only to operators who are using"},{"line_number":18,"context_line":"      multiple image locations"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"7a8ec9b2_528788b4","line":15,"range":{"start_line":15,"start_character":37,"end_line":15,"end_character":39},"in_reply_to":"7a8ec9b2_6d5f48e5","updated":"2016-09-21 17:39:09.000000000","message":"Brian, Not sure if a colon is accepted here. Can you please confirm?","commit_id":"8145173aa1985ee49242a460d4cf7dc552cc6e57"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"cd94f4b9aab28f92d27d7bf5ed5984db2d490560","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    have made the store names consistent in the Newton"},{"line_number":15,"context_line":"    release.  What this means for you -"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    - This change applies only to operators who are using"},{"line_number":18,"context_line":"      multiple image locations"},{"line_number":19,"context_line":"    - This change applies only to operators using the VMware"},{"line_number":20,"context_line":"      datastore or filesystem stores"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"7a8ec9b2_5b116351","line":17,"updated":"2016-09-21 17:39:09.000000000","message":"using bullets as per formatting in http://docs.openstack.org/developer/reno/usage.html#formatting.\nPlease confirm.","commit_id":"8145173aa1985ee49242a460d4cf7dc552cc6e57"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3e515e1cdf609ed6bbed1e2c24f65e410257835e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    have made the store names consistent in the Newton"},{"line_number":15,"context_line":"    release.  What this means for you -"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    - This change applies only to operators who are using"},{"line_number":18,"context_line":"      multiple image locations"},{"line_number":19,"context_line":"    - This change applies only to operators using the VMware"},{"line_number":20,"context_line":"      datastore or filesystem stores"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"7a8ec9b2_6c490331","line":17,"in_reply_to":"7a8ec9b2_5b116351","updated":"2016-09-21 18:53:00.000000000","message":"I\u0027m pretty sure either the - or * is OK as a bullet indicator, sphinx looks at the level of indentation to distinguish a sub-list from the main list.  The key thing is to make sure there\u0027s a blank line before the start of a list (or sub-list).","commit_id":"8145173aa1985ee49242a460d4cf7dc552cc6e57"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"f32eae8e265803e575d78dd30f3d0134a9d9cce1","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    - This change applies only to the ``store_type_preference``"},{"line_number":22,"context_line":"      option"},{"line_number":23,"context_line":"    - *VMware datastore operators*: The old name, now"},{"line_number":24,"context_line":"      **DEPRECATED**, was ``vmware_datastore``.  The **new**"},{"line_number":25,"context_line":"      name, used in both glance and glance_store, is"},{"line_number":26,"context_line":"      ``vmware``"},{"line_number":27,"context_line":"    - *File system store operators*: the old name, now"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"7a8ec9b2_79055278","line":24,"range":{"start_line":24,"start_character":8,"end_line":24,"end_character":18},"updated":"2016-09-21 15:40:20.000000000","message":"Trying to understand .. so, we are deprecating the values but don\u0027t want to remove them ever?","commit_id":"8145173aa1985ee49242a460d4cf7dc552cc6e57"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"58754c0547994023a5427be7e88cdf06cfef52e2","unresolved":false,"context_lines":[{"line_number":28,"context_line":"      **DEPRECATED**, was ``filesystem``.  The **new** name,"},{"line_number":29,"context_line":"      used in both glance and glance_store, is ``file``"},{"line_number":30,"context_line":"    - This change is backward compatible, that is, the old"},{"line_number":31,"context_line":"      names will be recognized by the code"},{"line_number":32,"context_line":"    - We strongly encourage operators to modify their"},{"line_number":33,"context_line":"      ``glance-api.conf`` files immediately to use the **new**"},{"line_number":34,"context_line":"      names"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"7a8ec9b2_8d881473","line":31,"updated":"2016-09-21 16:24:49.000000000","message":"add to the above sentence: \"during the deprecation period.  Support for the deprecated names will be removed in the Pike release\"","commit_id":"8145173aa1985ee49242a460d4cf7dc552cc6e57"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"cd94f4b9aab28f92d27d7bf5ed5984db2d490560","unresolved":false,"context_lines":[{"line_number":28,"context_line":"      **DEPRECATED**, was ``filesystem``.  The **new** name,"},{"line_number":29,"context_line":"      used in both glance and glance_store, is ``file``"},{"line_number":30,"context_line":"    - This change is backward compatible, that is, the old"},{"line_number":31,"context_line":"      names will be recognized by the code"},{"line_number":32,"context_line":"    - We strongly encourage operators to modify their"},{"line_number":33,"context_line":"      ``glance-api.conf`` files immediately to use the **new**"},{"line_number":34,"context_line":"      names"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"7a8ec9b2_f29b3415","line":31,"in_reply_to":"7a8ec9b2_8d881473","updated":"2016-09-21 17:39:09.000000000","message":"Done","commit_id":"8145173aa1985ee49242a460d4cf7dc552cc6e57"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"f32eae8e265803e575d78dd30f3d0134a9d9cce1","unresolved":false,"context_lines":[{"line_number":29,"context_line":"      used in both glance and glance_store, is ``file``"},{"line_number":30,"context_line":"    - This change is backward compatible, that is, the old"},{"line_number":31,"context_line":"      names will be recognized by the code"},{"line_number":32,"context_line":"    - We strongly encourage operators to modify their"},{"line_number":33,"context_line":"      ``glance-api.conf`` files immediately to use the **new**"},{"line_number":34,"context_line":"      names"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"7a8ec9b2_1988cec4","line":34,"range":{"start_line":32,"start_character":6,"end_line":34,"end_character":11},"updated":"2016-09-21 15:40:20.000000000","message":"I\u0027m wondering if a warning message in code sends out a stronger signal than a release note. If we really want operators to start using the new values, we have to warn them to stop using them old ones. And, just a release note is not enough to do that in my opinion.","commit_id":"8145173aa1985ee49242a460d4cf7dc552cc6e57"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"32b408e9c988fb5d89ab05560005a428d4243eaa","unresolved":false,"context_lines":[{"line_number":29,"context_line":"      used in both glance and glance_store, is ``file``"},{"line_number":30,"context_line":"    - This change is backward compatible, that is, the old"},{"line_number":31,"context_line":"      names will be recognized by the code"},{"line_number":32,"context_line":"    - We strongly encourage operators to modify their"},{"line_number":33,"context_line":"      ``glance-api.conf`` files immediately to use the **new**"},{"line_number":34,"context_line":"      names"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"7a8ec9b2_9ccdac33","line":34,"range":{"start_line":32,"start_character":6,"end_line":34,"end_character":11},"in_reply_to":"7a8ec9b2_1988cec4","updated":"2016-09-21 15:50:25.000000000","message":"Thanks Hemanth. I will add a warning message in the code.\nDo we want to retain this however in the release note as well?\n\nAlso, since the values to the opt are going to be deprecated, is a warning message that goes like \"The value ``filesystem`` is deprecated and the use of the new value ``file`` is strongly recommended\" ?\nWanted to make sure the warning message is clear before pushing a patch.","commit_id":"8145173aa1985ee49242a460d4cf7dc552cc6e57"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"5611ca3dc2fafa95bf616c0e4513b028d6e44051","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    to any valid identifier in glance_store.  As this situation"},{"line_number":13,"context_line":"    encouraged misconfiguration and operator unhappiness, we"},{"line_number":14,"context_line":"    have made the store names consistent in the Newton"},{"line_number":15,"context_line":"    release. What this means for you is:"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    * This change applies only to operators who are using"},{"line_number":18,"context_line":"      multiple image locations"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"7a8ec9b2_0905c378","line":15,"range":{"start_line":15,"start_character":36,"end_line":15,"end_character":39},"updated":"2016-09-22 00:44:19.000000000","message":"s/is//","commit_id":"17bc05edffd72d2bd7589aa7edfabc161b620b38"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"5611ca3dc2fafa95bf616c0e4513b028d6e44051","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    * This change is backward compatible, that is, the old"},{"line_number":31,"context_line":"      names will be recognized by the code during the deprecation"},{"line_number":32,"context_line":"      period. Support for the deprecated names will be removed in"},{"line_number":33,"context_line":"      the Pike release"},{"line_number":34,"context_line":"    * We strongly encourage operators to modify their"},{"line_number":35,"context_line":"      ``glance-api.conf`` files immediately to use the **new**"},{"line_number":36,"context_line":"      names"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"7a8ec9b2_c9ef5baf","line":33,"range":{"start_line":33,"start_character":10,"end_line":33,"end_character":14},"updated":"2016-09-22 00:44:19.000000000","message":"**Pike**","commit_id":"17bc05edffd72d2bd7589aa7edfabc161b620b38"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"b4ccfb7987fe0ecab0d5a8f686fb643351807e80","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Store names in glance and glance_store are now"},{"line_number":4,"context_line":"    consistent."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"5a8bc5a2_08742b66","line":3,"updated":"2016-09-23 15:51:13.000000000","message":"Based on some developer docs that just merged, I don\u0027t think we want to add this to the prelude. I think we want to reserve this for *very* important changes and this isn\u0027t one of those, IMO","commit_id":"f437a7f2ae5300a9a5d58abccdc0126a2060b0fc"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"c7d898407d1f63e1ee4e8bc85d3ef74c9199f3bc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Store names in glance and glance_store are now"},{"line_number":4,"context_line":"    consistent."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"5a8bc5a2_731da4bc","line":3,"in_reply_to":"5a8bc5a2_08742b66","updated":"2016-09-23 16:09:14.000000000","message":"+1","commit_id":"f437a7f2ae5300a9a5d58abccdc0126a2060b0fc"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"16bb66e0d2c22154b0bc38f1ef87c1c080255519","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Store names in glance and glance_store are now"},{"line_number":4,"context_line":"    consistent."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"5a8bc5a2_d3b75884","line":3,"in_reply_to":"5a8bc5a2_08742b66","updated":"2016-09-23 16:12:02.000000000","message":"Done","commit_id":"f437a7f2ae5300a9a5d58abccdc0126a2060b0fc"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"16bb66e0d2c22154b0bc38f1ef87c1c080255519","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Store names in glance and glance_store are now"},{"line_number":4,"context_line":"    consistent."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"5a8bc5a2_f3ba946d","line":3,"in_reply_to":"5a8bc5a2_731da4bc","updated":"2016-09-23 16:12:02.000000000","message":"Done","commit_id":"f437a7f2ae5300a9a5d58abccdc0126a2060b0fc"}]}