)]}'
{"glance/common/config.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2a123706d75cb69d4c6ee89af65a347bff2227c2","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Possible values:"},{"line_number":71,"context_line":"    * A string value of the format:"},{"line_number":72,"context_line":"      \u003ccomponent\u003e-paste.ini"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Related Options:"},{"line_number":75,"context_line":"    * flavor"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_0a93bffb","line":72,"updated":"2016-08-24 20:17:22.000000000","message":"I don\u0027t think you must have that format, looks like line 337 will let you specify any file name.","commit_id":"fc49f37c5e2a92f6e6bc820c2b2db93dec11e867"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"161e83eca0be6721dd52d87f9c9a953b45f5ce7f","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Possible values:"},{"line_number":71,"context_line":"    * A string value of the format:"},{"line_number":72,"context_line":"      \u003ccomponent\u003e-paste.ini"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Related Options:"},{"line_number":75,"context_line":"    * flavor"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_c41fd307","line":72,"in_reply_to":"1ac06dbe_0a93bffb","updated":"2016-08-24 23:01:11.000000000","message":"Brian, from my understanding of the code, I think if the operator gives a filename like \"something-paste.ini\", that will be absolutized as in line 343 and used.\nBut if the user does not, then the file is searched for using the oslo,config\u0027s find_file() (line 329) method to locate the paste-ini file that is being assumed to have been loaded. The absolute path to that found file is returned if found. If oslo.config file doesnt find it, we throw an error as in line 342.\nI will add a lint stating that if left empty, the paste.ini file is searched for.\nWhat do you suggest?","commit_id":"fc49f37c5e2a92f6e6bc820c2b2db93dec11e867"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b4037704b593ed5f9b9a8b1818ee7cdff367150f","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Possible values:"},{"line_number":71,"context_line":"    * A string value of the format:"},{"line_number":72,"context_line":"      \u003ccomponent\u003e-paste.ini"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Related Options:"},{"line_number":75,"context_line":"    * flavor"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_46773d3b","line":72,"in_reply_to":"1ac06dbe_c41fd307","updated":"2016-08-25 13:27:06.000000000","message":"(1) I think the paste config file can be named anything the operator wants (as long as it\u0027s specified as the value for this config option).  It doesn\u0027t need to have the \u0027-paste.ini\u0027 suffix\n\n(2) Yes, add the line about if this line is empty, the file will be searched for (along with what name(s) will be used)","commit_id":"fc49f37c5e2a92f6e6bc820c2b2db93dec11e867"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2a123706d75cb69d4c6ee89af65a347bff2227c2","unresolved":false,"context_lines":[{"line_number":70,"context_line":"Possible values:"},{"line_number":71,"context_line":"    * A string value of the format:"},{"line_number":72,"context_line":"      \u003ccomponent\u003e-paste.ini"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Related Options:"},{"line_number":75,"context_line":"    * flavor"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_8df22905","line":73,"updated":"2016-08-24 20:17:22.000000000","message":"Also, this has a default value, but in a weird way, namely, if you leave this option empty, the function at line 320 will create a default filename for you.  It\u0027s probably worth mentioning that, unless you think it would be confusing.","commit_id":"fc49f37c5e2a92f6e6bc820c2b2db93dec11e867"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"256572518e21d3d154defba06a74092c3f02dcb3","unresolved":false,"context_lines":[{"line_number":63,"context_line":"a paste configuration file ``glance-api-paste.ini`` is included"},{"line_number":64,"context_line":"with a section ``[filter:cache]``."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"NOTE: The paste configuration file need not be edited in most cases"},{"line_number":67,"context_line":"as it ships with ready-made pipelines for all common deployment"},{"line_number":68,"context_line":"flavors."},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_b6e1d900","line":66,"range":{"start_line":66,"start_character":6,"end_line":66,"end_character":10},"updated":"2016-08-28 17:20:25.000000000","message":"How about \"The sample paste configuration file shipped with Glance need not be edited ...\"","commit_id":"c33cdb12cb5ae500f036c97dba316b2564d8db42"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"e10c1428cf4b602d94b377dfbcf20580994924f4","unresolved":false,"context_lines":[{"line_number":63,"context_line":"a paste configuration file ``glance-api-paste.ini`` is included"},{"line_number":64,"context_line":"with a section ``[filter:cache]``."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"NOTE: The paste configuration file need not be edited in most cases"},{"line_number":67,"context_line":"as it ships with ready-made pipelines for all common deployment"},{"line_number":68,"context_line":"flavors."},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_91be9fd2","line":66,"range":{"start_line":66,"start_character":6,"end_line":66,"end_character":10},"in_reply_to":"fa7ab95a_b6e1d900","updated":"2016-08-28 19:56:17.000000000","message":"Done","commit_id":"c33cdb12cb5ae500f036c97dba316b2564d8db42"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"256572518e21d3d154defba06a74092c3f02dcb3","unresolved":false,"context_lines":[{"line_number":66,"context_line":"NOTE: The paste configuration file need not be edited in most cases"},{"line_number":67,"context_line":"as it ships with ready-made pipelines for all common deployment"},{"line_number":68,"context_line":"flavors."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Possible values:"},{"line_number":71,"context_line":"    * A string value representing the name of the paste configuration"},{"line_number":72,"context_line":"      file."}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_361789ee","line":69,"updated":"2016-08-28 17:20:25.000000000","message":"I think we need to say something about the default value being empty for this option.  Maybe say something like:\n\nIf no value is specified for this option, the default file will be searched for in the standard configuration file locations.","commit_id":"c33cdb12cb5ae500f036c97dba316b2564d8db42"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"e10c1428cf4b602d94b377dfbcf20580994924f4","unresolved":false,"context_lines":[{"line_number":66,"context_line":"NOTE: The paste configuration file need not be edited in most cases"},{"line_number":67,"context_line":"as it ships with ready-made pipelines for all common deployment"},{"line_number":68,"context_line":"flavors."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Possible values:"},{"line_number":71,"context_line":"    * A string value representing the name of the paste configuration"},{"line_number":72,"context_line":"      file."}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_b1b563ef","line":69,"in_reply_to":"fa7ab95a_361789ee","updated":"2016-08-28 19:56:17.000000000","message":"Done","commit_id":"c33cdb12cb5ae500f036c97dba316b2564d8db42"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"89c63fd2a6924e5dbe90ddba8eba0f33a34903cf","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"paste_deploy_opts \u003d ["},{"line_number":34,"context_line":"    cfg.StrOpt(\u0027flavor\u0027,"},{"line_number":35,"context_line":"               sample_default\u003d\u0027caching\u0027,"},{"line_number":36,"context_line":"               help\u003d_(\"\"\""},{"line_number":37,"context_line":"Deployment flavor to use in the server application pipeline."},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_81f7add1","line":35,"range":{"start_line":35,"start_character":31,"end_line":35,"end_character":38},"updated":"2016-08-30 17:45:39.000000000","message":"I suggest replacing this with \u0027keystone\u0027.\nThis config option is used both for API and registry. And, the only common flavor is keystone.","commit_id":"357930469e4ffc38d5d0fc346cb81a5ab61c0f7e"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"5e9a2167494590acc0276e868e187c6c6acb8929","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"paste_deploy_opts \u003d ["},{"line_number":34,"context_line":"    cfg.StrOpt(\u0027flavor\u0027,"},{"line_number":35,"context_line":"               sample_default\u003d\u0027caching\u0027,"},{"line_number":36,"context_line":"               help\u003d_(\"\"\""},{"line_number":37,"context_line":"Deployment flavor to use in the server application pipeline."},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_f4b4b682","line":35,"range":{"start_line":35,"start_character":31,"end_line":35,"end_character":38},"in_reply_to":"fa7ab95a_81f7add1","updated":"2016-08-30 17:53:45.000000000","message":"Done","commit_id":"357930469e4ffc38d5d0fc346cb81a5ab61c0f7e"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"89c63fd2a6924e5dbe90ddba8eba0f33a34903cf","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    * String value representing a partial pipeline name."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Related Options:"},{"line_number":51,"context_line":"    * config_file."},{"line_number":52,"context_line":"\"\"\")),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027config_file\u0027,"},{"line_number":54,"context_line":"               sample_default\u003d\u0027glance-api-paste.ini\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_e1d5d91b","line":51,"range":{"start_line":51,"start_character":17,"end_line":51,"end_character":18},"updated":"2016-08-30 17:45:39.000000000","message":"Drop the period.\nAnd, also add a blank like after the last related option","commit_id":"357930469e4ffc38d5d0fc346cb81a5ab61c0f7e"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"5e9a2167494590acc0276e868e187c6c6acb8929","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    * String value representing a partial pipeline name."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Related Options:"},{"line_number":51,"context_line":"    * config_file."},{"line_number":52,"context_line":"\"\"\")),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027config_file\u0027,"},{"line_number":54,"context_line":"               sample_default\u003d\u0027glance-api-paste.ini\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_14b83a74","line":51,"range":{"start_line":51,"start_character":17,"end_line":51,"end_character":18},"in_reply_to":"fa7ab95a_e1d5d91b","updated":"2016-08-30 17:53:45.000000000","message":"Done","commit_id":"357930469e4ffc38d5d0fc346cb81a5ab61c0f7e"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"89c63fd2a6924e5dbe90ddba8eba0f33a34903cf","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    cfg.StrOpt(\u0027config_file\u0027,"},{"line_number":54,"context_line":"               sample_default\u003d\u0027glance-api-paste.ini\u0027,"},{"line_number":55,"context_line":"               help\u003d_(\"\"\""},{"line_number":56,"context_line":"Name of the paste configuration file."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Provide a string value representing the name of the paste"},{"line_number":59,"context_line":"configuration file to use for configuring piplelines for"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_92761d04","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":7},"updated":"2016-08-30 17:45:39.000000000","message":"Path to?","commit_id":"357930469e4ffc38d5d0fc346cb81a5ab61c0f7e"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"c495e8c798c53e749cc9bf0781151bdd1fb44501","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    cfg.StrOpt(\u0027config_file\u0027,"},{"line_number":54,"context_line":"               sample_default\u003d\u0027glance-api-paste.ini\u0027,"},{"line_number":55,"context_line":"               help\u003d_(\"\"\""},{"line_number":56,"context_line":"Name of the paste configuration file."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Provide a string value representing the name of the paste"},{"line_number":59,"context_line":"configuration file to use for configuring piplelines for"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_97144ce9","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":7},"in_reply_to":"fa7ab95a_54000234","updated":"2016-08-30 18:04:18.000000000","message":"Yes, not necessarily. But, it isn\u0027t name either I think.\n\nThis is the only usage in code\nhttps://github.com/openstack/glance/blob/master/glance/common/config.py#L408-L414\n\nAnd, if the config is populated, it\u0027s trying to fetch an absolute path based on it. So, this could be just a file name, relative path and an absolute path too.","commit_id":"357930469e4ffc38d5d0fc346cb81a5ab61c0f7e"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"5e9a2167494590acc0276e868e187c6c6acb8929","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    cfg.StrOpt(\u0027config_file\u0027,"},{"line_number":54,"context_line":"               sample_default\u003d\u0027glance-api-paste.ini\u0027,"},{"line_number":55,"context_line":"               help\u003d_(\"\"\""},{"line_number":56,"context_line":"Name of the paste configuration file."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Provide a string value representing the name of the paste"},{"line_number":59,"context_line":"configuration file to use for configuring piplelines for"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_54000234","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":7},"in_reply_to":"fa7ab95a_92761d04","updated":"2016-08-30 17:53:45.000000000","message":"Not necessarily path. The code handles adding of the absolute path to the file name.","commit_id":"357930469e4ffc38d5d0fc346cb81a5ab61c0f7e"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"89c63fd2a6924e5dbe90ddba8eba0f33a34903cf","unresolved":false,"context_lines":[{"line_number":55,"context_line":"               help\u003d_(\"\"\""},{"line_number":56,"context_line":"Name of the paste configuration file."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Provide a string value representing the name of the paste"},{"line_number":59,"context_line":"configuration file to use for configuring piplelines for"},{"line_number":60,"context_line":"server application deployments."},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_52573557","line":58,"range":{"start_line":58,"start_character":40,"end_line":58,"end_character":44},"updated":"2016-08-30 17:45:39.000000000","message":"path?","commit_id":"357930469e4ffc38d5d0fc346cb81a5ab61c0f7e"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"89c63fd2a6924e5dbe90ddba8eba0f33a34903cf","unresolved":false,"context_lines":[{"line_number":59,"context_line":"configuration file to use for configuring piplelines for"},{"line_number":60,"context_line":"server application deployments."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"For example, to enable local image caching in Glance API servers,"},{"line_number":63,"context_line":"a paste configuration file ``glance-api-paste.ini`` is included"},{"line_number":64,"context_line":"with a section ``[filter:cache]``."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"NOTE: The sample paste configuration file shipped with Glance need"},{"line_number":67,"context_line":"not be edited in most cases as it comes with ready-made pipelines"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_34c7fe96","line":64,"range":{"start_line":62,"start_character":0,"end_line":64,"end_character":33},"updated":"2016-08-30 17:45:39.000000000","message":"Do we want to say that a default paste config file is included with Glance? If so, we should probably reword this to something like \n\"Default paste configuration files ``glance-api-paste.ini`` and ``glance-registry-paste.ini`` are provided for Glance API and registry services respectively. For example: the ``keystone`` for both API and registry services is provided by the section ``[pipeline:glance-registry-keystone]``.\"","commit_id":"357930469e4ffc38d5d0fc346cb81a5ab61c0f7e"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"5e9a2167494590acc0276e868e187c6c6acb8929","unresolved":false,"context_lines":[{"line_number":59,"context_line":"configuration file to use for configuring piplelines for"},{"line_number":60,"context_line":"server application deployments."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"For example, to enable local image caching in Glance API servers,"},{"line_number":63,"context_line":"a paste configuration file ``glance-api-paste.ini`` is included"},{"line_number":64,"context_line":"with a section ``[filter:cache]``."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"NOTE: The sample paste configuration file shipped with Glance need"},{"line_number":67,"context_line":"not be edited in most cases as it comes with ready-made pipelines"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_d4cc1237","line":64,"range":{"start_line":62,"start_character":0,"end_line":64,"end_character":33},"in_reply_to":"fa7ab95a_34c7fe96","updated":"2016-08-30 17:53:45.000000000","message":"No Hemanth. What I meant was the paste configuration file will have a section corresponding to the deployment (here, image caching)\n\nI guess we can remove this paragraph as it might be confusing for the operator. It talks about the contents of the paste conf file and not the file itself (which is the purpose of this opt)","commit_id":"357930469e4ffc38d5d0fc346cb81a5ab61c0f7e"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"c495e8c798c53e749cc9bf0781151bdd1fb44501","unresolved":false,"context_lines":[{"line_number":59,"context_line":"configuration file to use for configuring piplelines for"},{"line_number":60,"context_line":"server application deployments."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"For example, to enable local image caching in Glance API servers,"},{"line_number":63,"context_line":"a paste configuration file ``glance-api-paste.ini`` is included"},{"line_number":64,"context_line":"with a section ``[filter:cache]``."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"NOTE: The sample paste configuration file shipped with Glance need"},{"line_number":67,"context_line":"not be edited in most cases as it comes with ready-made pipelines"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_b7015007","line":64,"range":{"start_line":62,"start_character":0,"end_line":64,"end_character":33},"in_reply_to":"fa7ab95a_d4cc1237","updated":"2016-08-30 18:04:18.000000000","message":"Yeah, let\u0027s  drop it in that case.","commit_id":"357930469e4ffc38d5d0fc346cb81a5ab61c0f7e"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"89c63fd2a6924e5dbe90ddba8eba0f33a34903cf","unresolved":false,"context_lines":[{"line_number":67,"context_line":"not be edited in most cases as it comes with ready-made pipelines"},{"line_number":68,"context_line":"for all common deployment flavors."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"If no value is specified for this option, the ``paste.ini``"},{"line_number":71,"context_line":"file with the prefix of the corresponding Glance service\u0027s"},{"line_number":72,"context_line":"configuration file will be searched for in the known configuration"},{"line_number":73,"context_line":"directories and used if found. If not found, the service errors out."}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_9257fd24","line":70,"range":{"start_line":70,"start_character":42,"end_line":70,"end_character":59},"updated":"2016-08-30 17:45:39.000000000","message":"Can we explicitly list what it may look for if this opt is not set?","commit_id":"357930469e4ffc38d5d0fc346cb81a5ab61c0f7e"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"c495e8c798c53e749cc9bf0781151bdd1fb44501","unresolved":false,"context_lines":[{"line_number":67,"context_line":"not be edited in most cases as it comes with ready-made pipelines"},{"line_number":68,"context_line":"for all common deployment flavors."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"If no value is specified for this option, the ``paste.ini``"},{"line_number":71,"context_line":"file with the prefix of the corresponding Glance service\u0027s"},{"line_number":72,"context_line":"configuration file will be searched for in the known configuration"},{"line_number":73,"context_line":"directories and used if found. If not found, the service errors out."}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_f71e785d","line":70,"range":{"start_line":70,"start_character":42,"end_line":70,"end_character":59},"in_reply_to":"fa7ab95a_14d3dad5","updated":"2016-08-30 18:04:18.000000000","message":"Maybe it makes more sense to just include what the code looks for explicitly than describing the logic in code.","commit_id":"357930469e4ffc38d5d0fc346cb81a5ab61c0f7e"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"5e9a2167494590acc0276e868e187c6c6acb8929","unresolved":false,"context_lines":[{"line_number":67,"context_line":"not be edited in most cases as it comes with ready-made pipelines"},{"line_number":68,"context_line":"for all common deployment flavors."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"If no value is specified for this option, the ``paste.ini``"},{"line_number":71,"context_line":"file with the prefix of the corresponding Glance service\u0027s"},{"line_number":72,"context_line":"configuration file will be searched for in the known configuration"},{"line_number":73,"context_line":"directories and used if found. If not found, the service errors out."}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_14d3dad5","line":70,"range":{"start_line":70,"start_character":42,"end_line":70,"end_character":59},"in_reply_to":"fa7ab95a_9257fd24","updated":"2016-08-30 17:53:45.000000000","message":"if the conf file is glance-api.conf for this opt, it will look for \"glance-api-paste.ini\"\nTried to explain that in general in the following few lines.","commit_id":"357930469e4ffc38d5d0fc346cb81a5ab61c0f7e"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"89c63fd2a6924e5dbe90ddba8eba0f33a34903cf","unresolved":false,"context_lines":[{"line_number":116,"context_line":"and/or functions that are combined together into flows in a"},{"line_number":117,"context_line":"declarative manner. Hence it is recommended that ``TaskFlow``"},{"line_number":118,"context_line":"executor is used."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Possible values:"},{"line_number":121,"context_line":"    * taskflow"},{"line_number":122,"context_line":"    * eventlet"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_7cd972f2","line":119,"updated":"2016-08-30 17:45:39.000000000","message":"How about a line or two describing eventlet executor as well?","commit_id":"357930469e4ffc38d5d0fc346cb81a5ab61c0f7e"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"89c63fd2a6924e5dbe90ddba8eba0f33a34903cf","unresolved":false,"context_lines":[{"line_number":132,"context_line":"task operations."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Provide a string value representing the absolute path to the"},{"line_number":135,"context_line":"directory to be used to operate over images, normally before"},{"line_number":136,"context_line":"they are imported in the destination store."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"NOTE: When providing a value for ``work_dir``, please make sure"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_77f7cbd2","line":135,"range":{"start_line":135,"start_character":43,"end_line":135,"end_character":44},"updated":"2016-08-30 17:45:39.000000000","message":"- is probably more accurate like in the original text.\nBut, I\u0027ll leave that for the grammar experts.","commit_id":"357930469e4ffc38d5d0fc346cb81a5ab61c0f7e"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"89c63fd2a6924e5dbe90ddba8eba0f33a34903cf","unresolved":false,"context_lines":[{"line_number":132,"context_line":"task operations."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Provide a string value representing the absolute path to the"},{"line_number":135,"context_line":"directory to be used to operate over images, normally before"},{"line_number":136,"context_line":"they are imported in the destination store."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"NOTE: When providing a value for ``work_dir``, please make sure"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_974a8f53","line":135,"range":{"start_line":135,"start_character":13,"end_line":135,"end_character":24},"updated":"2016-08-30 17:45:39.000000000","message":"How about dropping this?","commit_id":"357930469e4ffc38d5d0fc346cb81a5ab61c0f7e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a1afc860f6c335a5848b3922ec9c6b345627d148","unresolved":false,"context_lines":[{"line_number":65,"context_line":"not be edited in most cases as it comes with ready-made pipelines"},{"line_number":66,"context_line":"for all common deployment flavors."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"If no value is specified for this option, the ``paste.ini``"},{"line_number":69,"context_line":"file with the prefix of the corresponding Glance service\u0027s"},{"line_number":70,"context_line":"configuration file name (For example, ``glance-api-paste.ini`` if"},{"line_number":71,"context_line":"this opt is configured in ``glance-api.conf``) will be searched for"},{"line_number":72,"context_line":"in the known configuration directories and used if found. If not"},{"line_number":73,"context_line":"found, the service errors out."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Possible values:"},{"line_number":76,"context_line":"    * A string value representing the name of the paste configuration"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_fe83ac00","line":73,"range":{"start_line":68,"start_character":0,"end_line":73,"end_character":30},"updated":"2016-08-30 20:21:04.000000000","message":"I think this paragraph will flow better if you move the example, something like this:\n\nIf no value is specified for this option, the ``paste.ini`` file with the prefix of the corresponding Glance service\u0027s configuration file name will be searched for in the known configuration directories.  (For example, if this option is configured in ``glance-api.conf``, the service will look for a file named ``glance-api-paste.ini``.)  If the paste configuration file is not found, the service errors out.\n\n(Also, maybe \"refuses to start\" instead of \"errors out\"?  Whatever you think is more accurate.)","commit_id":"5d0c9ed5f77fe626700f0c16ea157bb7d247776b"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"c1d849529d64d4219a5049498de3c0744206d9e0","unresolved":false,"context_lines":[{"line_number":65,"context_line":"not be edited in most cases as it comes with ready-made pipelines"},{"line_number":66,"context_line":"for all common deployment flavors."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"If no value is specified for this option, the ``paste.ini``"},{"line_number":69,"context_line":"file with the prefix of the corresponding Glance service\u0027s"},{"line_number":70,"context_line":"configuration file name (For example, ``glance-api-paste.ini`` if"},{"line_number":71,"context_line":"this opt is configured in ``glance-api.conf``) will be searched for"},{"line_number":72,"context_line":"in the known configuration directories and used if found. If not"},{"line_number":73,"context_line":"found, the service errors out."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Possible values:"},{"line_number":76,"context_line":"    * A string value representing the name of the paste configuration"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_91eb7112","line":73,"range":{"start_line":68,"start_character":0,"end_line":73,"end_character":30},"in_reply_to":"fa7ab95a_fe83ac00","updated":"2016-08-30 20:35:51.000000000","message":"Done","commit_id":"5d0c9ed5f77fe626700f0c16ea157bb7d247776b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a1afc860f6c335a5848b3922ec9c6b345627d148","unresolved":false,"context_lines":[{"line_number":114,"context_line":"executions. By default, ``TaskFlow`` executor is used."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"``Eventlet`` executors use a green thread pool to execute calls"},{"line_number":117,"context_line":"asynchrnously. The coroutines are confined to the parent threads and"},{"line_number":118,"context_line":"execution of tasks on remote workers is not supported."},{"line_number":119,"context_line":"``TaskFlow`` helps make task executions easy, consistent, scalable"},{"line_number":120,"context_line":"and reliable. It also enables creation of lightweight task objects"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_5ec73863","line":117,"range":{"start_line":117,"start_character":0,"end_line":117,"end_character":13},"updated":"2016-08-30 20:21:04.000000000","message":"asynchronously","commit_id":"5d0c9ed5f77fe626700f0c16ea157bb7d247776b"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"c1d849529d64d4219a5049498de3c0744206d9e0","unresolved":false,"context_lines":[{"line_number":114,"context_line":"executions. By default, ``TaskFlow`` executor is used."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"``Eventlet`` executors use a green thread pool to execute calls"},{"line_number":117,"context_line":"asynchrnously. The coroutines are confined to the parent threads and"},{"line_number":118,"context_line":"execution of tasks on remote workers is not supported."},{"line_number":119,"context_line":"``TaskFlow`` helps make task executions easy, consistent, scalable"},{"line_number":120,"context_line":"and reliable. It also enables creation of lightweight task objects"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_518f2974","line":117,"range":{"start_line":117,"start_character":0,"end_line":117,"end_character":13},"in_reply_to":"fa7ab95a_5ec73863","updated":"2016-08-30 20:35:51.000000000","message":"Done","commit_id":"5d0c9ed5f77fe626700f0c16ea157bb7d247776b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a1afc860f6c335a5848b3922ec9c6b345627d148","unresolved":false,"context_lines":[{"line_number":116,"context_line":"``Eventlet`` executors use a green thread pool to execute calls"},{"line_number":117,"context_line":"asynchrnously. The coroutines are confined to the parent threads and"},{"line_number":118,"context_line":"execution of tasks on remote workers is not supported."},{"line_number":119,"context_line":"``TaskFlow`` helps make task executions easy, consistent, scalable"},{"line_number":120,"context_line":"and reliable. It also enables creation of lightweight task objects"},{"line_number":121,"context_line":"and/or functions that are combined together into flows in a"},{"line_number":122,"context_line":"declarative manner. Hence it is recommended that ``TaskFlow``"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_feac8ca0","line":119,"updated":"2016-08-30 20:21:04.000000000","message":"I suggest making the TaskFlow description into its own paragraph.","commit_id":"5d0c9ed5f77fe626700f0c16ea157bb7d247776b"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"c1d849529d64d4219a5049498de3c0744206d9e0","unresolved":false,"context_lines":[{"line_number":116,"context_line":"``Eventlet`` executors use a green thread pool to execute calls"},{"line_number":117,"context_line":"asynchrnously. The coroutines are confined to the parent threads and"},{"line_number":118,"context_line":"execution of tasks on remote workers is not supported."},{"line_number":119,"context_line":"``TaskFlow`` helps make task executions easy, consistent, scalable"},{"line_number":120,"context_line":"and reliable. It also enables creation of lightweight task objects"},{"line_number":121,"context_line":"and/or functions that are combined together into flows in a"},{"line_number":122,"context_line":"declarative manner. Hence it is recommended that ``TaskFlow``"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_718a6d65","line":119,"in_reply_to":"fa7ab95a_feac8ca0","updated":"2016-08-30 20:35:51.000000000","message":"Done","commit_id":"5d0c9ed5f77fe626700f0c16ea157bb7d247776b"}]}