)]}'
{"glance/common/config.py":[{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"beacaf461390e995911adedbf1c09de84320d156","unresolved":false,"context_lines":[{"line_number":208,"context_line":"               help\u003d_(\"\"\""},{"line_number":209,"context_line":"The default number of results to return for a request."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Response to certain API requests, like list images, may return"},{"line_number":212,"context_line":"multiple items. The number of results returned can be explicitly"},{"line_number":213,"context_line":"controlled by specifying the ``limit`` parameter in the API request."},{"line_number":214,"context_line":"However, if a ``limit`` parameter is not specified, this"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_558423d3","line":211,"range":{"start_line":211,"start_character":0,"end_line":211,"end_character":8},"updated":"2016-08-26 21:34:56.000000000","message":"s/Response/Responses/","commit_id":"d04d4321c0d7229c317338dbceabcee597b358cf"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"897f868331ee0e3bed2fdff5a1f8341b98298838","unresolved":false,"context_lines":[{"line_number":208,"context_line":"               help\u003d_(\"\"\""},{"line_number":209,"context_line":"The default number of results to return for a request."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Response to certain API requests, like list images, may return"},{"line_number":212,"context_line":"multiple items. The number of results returned can be explicitly"},{"line_number":213,"context_line":"controlled by specifying the ``limit`` parameter in the API request."},{"line_number":214,"context_line":"However, if a ``limit`` parameter is not specified, this"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_90cf997e","line":211,"range":{"start_line":211,"start_character":0,"end_line":211,"end_character":8},"in_reply_to":"fa7ab95a_558423d3","updated":"2016-08-26 21:50:29.000000000","message":"Done","commit_id":"d04d4321c0d7229c317338dbceabcee597b358cf"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"beacaf461390e995911adedbf1c09de84320d156","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    * api_limit_max"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"\"\"\")),"},{"line_number":228,"context_line":"    cfg.IntOpt(\u0027api_limit_max\u0027, default\u003d1000, min\u003d1,"},{"line_number":229,"context_line":"               help\u003d_(\"\"\""},{"line_number":230,"context_line":"Maximum number of results that could be returned by a request."},{"line_number":231,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_f5a61752","line":228,"range":{"start_line":228,"start_character":16,"end_line":228,"end_character":29},"updated":"2016-08-26 21:34:56.000000000","message":"Does this option server any other purpose? Unless I\u0027m missing something, from the description, it seems redundant with \u0027limit_param_default\u0027. If so, we should consider deprecating one or the other.","commit_id":"d04d4321c0d7229c317338dbceabcee597b358cf"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"897f868331ee0e3bed2fdff5a1f8341b98298838","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    * api_limit_max"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"\"\"\")),"},{"line_number":228,"context_line":"    cfg.IntOpt(\u0027api_limit_max\u0027, default\u003d1000, min\u003d1,"},{"line_number":229,"context_line":"               help\u003d_(\"\"\""},{"line_number":230,"context_line":"Maximum number of results that could be returned by a request."},{"line_number":231,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_d0e681b3","line":228,"range":{"start_line":228,"start_character":16,"end_line":228,"end_character":29},"in_reply_to":"fa7ab95a_f5a61752","updated":"2016-08-26 21:50:29.000000000","message":"It isn\u0027t redundant. This is the upper cap on how many results can be returned for a request. On the other hand, limit_param_default, is the default number of results returned for a request when no explicit limit is specified in the request. \n\nFor example:\n1) GET /images?limit\u003d10\nThis will fetch us 10 images because it is explicitly mentioned in the request.\n\n2) GET /images\nThis will fetch us 25 images because it isn\u0027t explicitly mentioned in the request. And, this is where limit_param_default will kick in.\n\n3) GET /images?limit\u003d2000\nThis will fetch us 1000 because api_limit_max is defined as 1000.\n\n4) GET /images (with limit_param_default\u003d2000)\nThis will also fetch us 1000 because api_limit_max is defined as 1000.\n\nDoes it make sense?","commit_id":"d04d4321c0d7229c317338dbceabcee597b358cf"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"beacaf461390e995911adedbf1c09de84320d156","unresolved":false,"context_lines":[{"line_number":262,"context_line":"      image locations can sometimes include credentials. Hence, this"},{"line_number":263,"context_line":"      is set to ``False`` by default. Set this to ``True`` with"},{"line_number":264,"context_line":"      EXTREME CAUTION and ONLY IF you know what you are doing!"},{"line_number":265,"context_line":"    * If this is set to ``False`` to avoid showing image locations"},{"line_number":266,"context_line":"      to the user, then ``show_multiple_locations`` MUST be set to"},{"line_number":267,"context_line":"      ``False`` as well."},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"Possible values:"},{"line_number":270,"context_line":"    * True"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_50a6f110","line":267,"range":{"start_line":265,"start_character":6,"end_line":267,"end_character":23},"updated":"2016-08-26 21:34:56.000000000","message":"Seems that the options are not exactly interdependent, one can be false, while the other is true. So I would re-phrase this sentence like this:\n\nIf the operator wishes to avoid showing any image location(s) to the user, then both this option and ``show_multiple_locations`` MUST be set to ``False``.","commit_id":"d04d4321c0d7229c317338dbceabcee597b358cf"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"897f868331ee0e3bed2fdff5a1f8341b98298838","unresolved":false,"context_lines":[{"line_number":262,"context_line":"      image locations can sometimes include credentials. Hence, this"},{"line_number":263,"context_line":"      is set to ``False`` by default. Set this to ``True`` with"},{"line_number":264,"context_line":"      EXTREME CAUTION and ONLY IF you know what you are doing!"},{"line_number":265,"context_line":"    * If this is set to ``False`` to avoid showing image locations"},{"line_number":266,"context_line":"      to the user, then ``show_multiple_locations`` MUST be set to"},{"line_number":267,"context_line":"      ``False`` as well."},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"Possible values:"},{"line_number":270,"context_line":"    * True"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_f0a9c57c","line":267,"range":{"start_line":265,"start_character":6,"end_line":267,"end_character":23},"in_reply_to":"fa7ab95a_50a6f110","updated":"2016-08-26 21:50:29.000000000","message":"Done","commit_id":"d04d4321c0d7229c317338dbceabcee597b358cf"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"beacaf461390e995911adedbf1c09de84320d156","unresolved":false,"context_lines":[{"line_number":279,"context_line":"                help\u003d_(\"\"\""},{"line_number":280,"context_line":"Show all image locations when returning an image."},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"This configuration option indicates whether to show the all image"},{"line_number":283,"context_line":"locations when returning image details to the user. When multiple"},{"line_number":284,"context_line":"image locations exist for an image, the locations are ordered based"},{"line_number":285,"context_line":"on the location strategy indicated by the configuration opt"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_b5080f2f","line":282,"range":{"start_line":282,"start_character":52,"end_line":282,"end_character":55},"updated":"2016-08-26 21:34:56.000000000","message":"s/the all/all available/","commit_id":"d04d4321c0d7229c317338dbceabcee597b358cf"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"897f868331ee0e3bed2fdff5a1f8341b98298838","unresolved":false,"context_lines":[{"line_number":279,"context_line":"                help\u003d_(\"\"\""},{"line_number":280,"context_line":"Show all image locations when returning an image."},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"This configuration option indicates whether to show the all image"},{"line_number":283,"context_line":"locations when returning image details to the user. When multiple"},{"line_number":284,"context_line":"image locations exist for an image, the locations are ordered based"},{"line_number":285,"context_line":"on the location strategy indicated by the configuration opt"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_b073bde6","line":282,"range":{"start_line":282,"start_character":52,"end_line":282,"end_character":55},"in_reply_to":"fa7ab95a_b5080f2f","updated":"2016-08-26 21:50:29.000000000","message":"Done","commit_id":"d04d4321c0d7229c317338dbceabcee597b358cf"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"beacaf461390e995911adedbf1c09de84320d156","unresolved":false,"context_lines":[{"line_number":291,"context_line":"      image locations can sometimes include credentials. Hence, this"},{"line_number":292,"context_line":"      is set to ``False`` by default. Set this to ``True`` with"},{"line_number":293,"context_line":"      EXTREME CAUTION and ONLY IF you know what you are doing!"},{"line_number":294,"context_line":"    * If this is set to ``False`` to avoid showing image locations"},{"line_number":295,"context_line":"      to the user, then ``show_image_direct_url`` MUST be set to"},{"line_number":296,"context_line":"      ``False`` as well."},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"Possible values:"},{"line_number":299,"context_line":"    * True"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_b092dd9d","line":296,"range":{"start_line":294,"start_character":5,"end_line":296,"end_character":23},"updated":"2016-08-26 21:34:56.000000000","message":"ditto lines 265-267","commit_id":"d04d4321c0d7229c317338dbceabcee597b358cf"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"beacaf461390e995911adedbf1c09de84320d156","unresolved":false,"context_lines":[{"line_number":314,"context_line":"1099511627776 bytes (1 TiB)."},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"NOTE: this value should only be increased after"},{"line_number":317,"context_line":"careful consideration and must be set to a value under"},{"line_number":318,"context_line":"8 EiB (9223372036854775808)."},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_f051c5d9","line":317,"range":{"start_line":317,"start_character":49,"end_line":317,"end_character":54},"updated":"2016-08-26 21:34:56.000000000","message":"\"under\" here conflicts with \"\u003c\u003d\" below","commit_id":"d04d4321c0d7229c317338dbceabcee597b358cf"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"897f868331ee0e3bed2fdff5a1f8341b98298838","unresolved":false,"context_lines":[{"line_number":314,"context_line":"1099511627776 bytes (1 TiB)."},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"NOTE: this value should only be increased after"},{"line_number":317,"context_line":"careful consideration and must be set to a value under"},{"line_number":318,"context_line":"8 EiB (9223372036854775808)."},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_301c0d77","line":317,"range":{"start_line":317,"start_character":49,"end_line":317,"end_character":54},"in_reply_to":"fa7ab95a_f051c5d9","updated":"2016-08-26 21:50:29.000000000","message":"Done","commit_id":"d04d4321c0d7229c317338dbceabcee597b358cf"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"2a465b1fcc27ef6034927c669731a03089e583b3","unresolved":false,"context_lines":[{"line_number":161,"context_line":"Glance defines a standard set of properties (in its schema) that"},{"line_number":162,"context_line":"appear on every image. These properties are also known as"},{"line_number":163,"context_line":"``core properties``. In addition to these properties, Glance"},{"line_number":164,"context_line":"allows users to add custom properties to images. These are called"},{"line_number":165,"context_line":"as ``additional properties``."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"By default, this configuration option is set to ``True`` and users"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_b0e3bd04","line":164,"range":{"start_line":164,"start_character":59,"end_line":164,"end_character":65},"updated":"2016-08-26 21:37:19.000000000","message":"s/called/known/","commit_id":"e62aad6fdb784ebe81d681226c6b111823858890"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"4cd4c449a9a5aeebba515806b3af4994de9f9fa0","unresolved":false,"context_lines":[{"line_number":161,"context_line":"Glance defines a standard set of properties (in its schema) that"},{"line_number":162,"context_line":"appear on every image. These properties are also known as"},{"line_number":163,"context_line":"``core properties``. In addition to these properties, Glance"},{"line_number":164,"context_line":"allows users to add custom properties to images. These are called"},{"line_number":165,"context_line":"as ``additional properties``."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"By default, this configuration option is set to ``True`` and users"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_90f95983","line":164,"range":{"start_line":164,"start_character":59,"end_line":164,"end_character":65},"in_reply_to":"fa7ab95a_b0e3bd04","updated":"2016-08-26 21:40:25.000000000","message":"Done","commit_id":"e62aad6fdb784ebe81d681226c6b111823858890"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"2a465b1fcc27ef6034927c669731a03089e583b3","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    * False"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"Related options:"},{"line_number":175,"context_line":"    * image_property_quota"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"\"\"\")),"},{"line_number":178,"context_line":"    cfg.IntOpt(\u0027image_member_quota\u0027, default\u003d128,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_50b511ec","line":175,"range":{"start_line":175,"start_character":6,"end_line":175,"end_character":26},"updated":"2016-08-26 21:37:19.000000000","message":"Maybe a note in the description on how this option is related?","commit_id":"e62aad6fdb784ebe81d681226c6b111823858890"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"4cd4c449a9a5aeebba515806b3af4994de9f9fa0","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    * False"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"Related options:"},{"line_number":175,"context_line":"    * image_property_quota"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"\"\"\")),"},{"line_number":178,"context_line":"    cfg.IntOpt(\u0027image_member_quota\u0027, default\u003d128,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_d0f3e19c","line":175,"range":{"start_line":175,"start_character":6,"end_line":175,"end_character":26},"in_reply_to":"fa7ab95a_50b511ec","updated":"2016-08-26 21:40:25.000000000","message":"Done","commit_id":"e62aad6fdb784ebe81d681226c6b111823858890"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"893674fe4c83f99071076dd94afe26c4d5779cf6","unresolved":false,"context_lines":[{"line_number":167,"context_line":"By default, this configuration option is set to ``True`` and users"},{"line_number":168,"context_line":"are allowed to add additional properties. The number of additional"},{"line_number":169,"context_line":"properties that can be added to an image can be controlled via"},{"line_number":170,"context_line":"``image_property_quota`` configuration opt."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"Possible values:"},{"line_number":173,"context_line":"    * True"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_c2630c40","line":170,"range":{"start_line":170,"start_character":39,"end_line":170,"end_character":42},"updated":"2016-08-27 04:14:43.000000000","message":"nit: write out \u0027option\u0027","commit_id":"0031ad65ca9f0811f7158a4e3e7dc985e9c3b7de"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"893674fe4c83f99071076dd94afe26c4d5779cf6","unresolved":false,"context_lines":[{"line_number":275,"context_line":""},{"line_number":276,"context_line":"When multiple image locations exist for an image, the best location"},{"line_number":277,"context_line":"is displayed based on the location strategy indicated by the"},{"line_number":278,"context_line":"configuration opt ``location_strategy``."},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"NOTES:"},{"line_number":281,"context_line":"    * Revealing image locations can present a GRACE SECURITY RISK as"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_624fa0bd","line":278,"range":{"start_line":278,"start_character":14,"end_line":278,"end_character":17},"updated":"2016-08-27 04:14:43.000000000","message":"nit: write out \u0027option\u0027","commit_id":"0031ad65ca9f0811f7158a4e3e7dc985e9c3b7de"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"893674fe4c83f99071076dd94afe26c4d5779cf6","unresolved":false,"context_lines":[{"line_number":278,"context_line":"configuration opt ``location_strategy``."},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"NOTES:"},{"line_number":281,"context_line":"    * Revealing image locations can present a GRACE SECURITY RISK as"},{"line_number":282,"context_line":"      image locations can sometimes include credentials. Hence, this"},{"line_number":283,"context_line":"      is set to ``False`` by default. Set this to ``True`` with"},{"line_number":284,"context_line":"      EXTREME CAUTION and ONLY IF you know what you are doing!"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_c2ca2c1a","line":281,"range":{"start_line":281,"start_character":46,"end_line":281,"end_character":51},"updated":"2016-08-27 04:14:43.000000000","message":"I think you mean \"GRAVE\" here.","commit_id":"0031ad65ca9f0811f7158a4e3e7dc985e9c3b7de"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"893674fe4c83f99071076dd94afe26c4d5779cf6","unresolved":false,"context_lines":[{"line_number":307,"context_line":"image property ``locations``."},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"NOTES:"},{"line_number":310,"context_line":"    * Revealing image locations can present a GRACE SECURITY RISK as"},{"line_number":311,"context_line":"      image locations can sometimes include credentials. Hence, this"},{"line_number":312,"context_line":"      is set to ``False`` by default. Set this to ``True`` with"},{"line_number":313,"context_line":"      EXTREME CAUTION and ONLY IF you know what you are doing!"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_22dcb8e3","line":310,"range":{"start_line":310,"start_character":46,"end_line":310,"end_character":51},"updated":"2016-08-27 04:14:43.000000000","message":"\"GRAVE\"?","commit_id":"0031ad65ca9f0811f7158a4e3e7dc985e9c3b7de"}]}