)]}'
{"glance/db/sqlalchemy/metadata.py":[{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"a284f3f4d5335a7dc67f94897c3e133c310a5c9c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    cfg.StrOpt(\u0027metadata_source_path\u0027,"},{"line_number":42,"context_line":"               default\u003d\u0027/etc/glance/metadefs/\u0027,"},{"line_number":43,"context_line":"               help\u003d_(\"\"\""},{"line_number":44,"context_line":"Path to the directory where JSON metadefs files are stored."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Glance Metadata Definitions (\"metadefs\") are served from the database,"},{"line_number":47,"context_line":"but are stored in files in the JSON format.  The files in this"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_a66e2394","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":4},"updated":"2016-08-26 22:14:59.000000000","message":"Maybe we can say \"absolute path\" here in the title too?","commit_id":"977b021c6e8a6a0c9b4f7fb7a23f65d0c199693c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e4a1cd06796ac6db43fdb6346663ac1a5fb2f68a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    cfg.StrOpt(\u0027metadata_source_path\u0027,"},{"line_number":42,"context_line":"               default\u003d\u0027/etc/glance/metadefs/\u0027,"},{"line_number":43,"context_line":"               help\u003d_(\"\"\""},{"line_number":44,"context_line":"Path to the directory where JSON metadefs files are stored."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Glance Metadata Definitions (\"metadefs\") are served from the database,"},{"line_number":47,"context_line":"but are stored in files in the JSON format.  The files in this"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_86e83fe4","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":4},"in_reply_to":"fa7ab95a_a66e2394","updated":"2016-08-26 22:17:09.000000000","message":"Done","commit_id":"977b021c6e8a6a0c9b4f7fb7a23f65d0c199693c"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"b9264bd280acec8fd9c5090b4f22cf588c5c06a2","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"metadata_opts \u003d ["},{"line_number":41,"context_line":"    cfg.StrOpt(\u0027metadata_source_path\u0027,"},{"line_number":42,"context_line":"               default\u003d\u0027/etc/glance/metadefs/\u0027,"},{"line_number":43,"context_line":"               help\u003d_(\"\"\""},{"line_number":44,"context_line":"Absolute path to the directory where JSON metadefs files are stored."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_46839704","line":42,"range":{"start_line":42,"start_character":15,"end_line":42,"end_character":46},"updated":"2016-08-26 22:24:59.000000000","message":"I\u0027m always skeptical about defaults for paths.\nBut I don\u0027t know enough about metadefs to take a strong stance.","commit_id":"be714d9c214fcade01f690e4c0db9197229f78e8"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"47f2f0df5022e8dc1e56e3f450685aeb2364f342","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"metadata_opts \u003d ["},{"line_number":41,"context_line":"    cfg.StrOpt(\u0027metadata_source_path\u0027,"},{"line_number":42,"context_line":"               default\u003d\u0027/etc/glance/metadefs/\u0027,"},{"line_number":43,"context_line":"               help\u003d_(\"\"\""},{"line_number":44,"context_line":"Absolute path to the directory where JSON metadefs files are stored."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_e602eb0a","line":42,"range":{"start_line":42,"start_character":15,"end_line":42,"end_character":46},"in_reply_to":"fa7ab95a_46839704","updated":"2016-08-26 22:40:26.000000000","message":"I think distributions are supposed to make sure the files go there.","commit_id":"be714d9c214fcade01f690e4c0db9197229f78e8"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"b9264bd280acec8fd9c5090b4f22cf588c5c06a2","unresolved":false,"context_lines":[{"line_number":44,"context_line":"Absolute path to the directory where JSON metadefs files are stored."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Glance Metadata Definitions (\"metadefs\") are served from the database,"},{"line_number":47,"context_line":"but are stored in files in the JSON format.  The files in this"},{"line_number":48,"context_line":"directory are used to initialize the metadefs in the database."},{"line_number":49,"context_line":"Additionally, when metadefs are exported from the database, the files"},{"line_number":50,"context_line":"are written to this directory."},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_86d2fffe","line":48,"range":{"start_line":47,"start_character":45,"end_line":48,"end_character":61},"updated":"2016-08-26 22:24:59.000000000","message":"So, since we have a default path, do we expect the files to be present there to initialize the metadefs?","commit_id":"be714d9c214fcade01f690e4c0db9197229f78e8"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"47f2f0df5022e8dc1e56e3f450685aeb2364f342","unresolved":false,"context_lines":[{"line_number":44,"context_line":"Absolute path to the directory where JSON metadefs files are stored."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Glance Metadata Definitions (\"metadefs\") are served from the database,"},{"line_number":47,"context_line":"but are stored in files in the JSON format.  The files in this"},{"line_number":48,"context_line":"directory are used to initialize the metadefs in the database."},{"line_number":49,"context_line":"Additionally, when metadefs are exported from the database, the files"},{"line_number":50,"context_line":"are written to this directory."},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_08243dad","line":48,"range":{"start_line":47,"start_character":45,"end_line":48,"end_character":61},"in_reply_to":"fa7ab95a_86d2fffe","updated":"2016-08-26 22:40:26.000000000","message":"Yes, see above.","commit_id":"be714d9c214fcade01f690e4c0db9197229f78e8"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"b9264bd280acec8fd9c5090b4f22cf588c5c06a2","unresolved":false,"context_lines":[{"line_number":46,"context_line":"Glance Metadata Definitions (\"metadefs\") are served from the database,"},{"line_number":47,"context_line":"but are stored in files in the JSON format.  The files in this"},{"line_number":48,"context_line":"directory are used to initialize the metadefs in the database."},{"line_number":49,"context_line":"Additionally, when metadefs are exported from the database, the files"},{"line_number":50,"context_line":"are written to this directory."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Possible values:"},{"line_number":53,"context_line":"    * An absolute pathname"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_26085391","line":50,"range":{"start_line":49,"start_character":60,"end_line":50,"end_character":29},"updated":"2016-08-26 22:24:59.000000000","message":"How about mentioning that this directory needs write access?","commit_id":"be714d9c214fcade01f690e4c0db9197229f78e8"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"47f2f0df5022e8dc1e56e3f450685aeb2364f342","unresolved":false,"context_lines":[{"line_number":46,"context_line":"Glance Metadata Definitions (\"metadefs\") are served from the database,"},{"line_number":47,"context_line":"but are stored in files in the JSON format.  The files in this"},{"line_number":48,"context_line":"directory are used to initialize the metadefs in the database."},{"line_number":49,"context_line":"Additionally, when metadefs are exported from the database, the files"},{"line_number":50,"context_line":"are written to this directory."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Possible values:"},{"line_number":53,"context_line":"    * An absolute pathname"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_e86e39c8","line":50,"range":{"start_line":49,"start_character":60,"end_line":50,"end_character":29},"in_reply_to":"fa7ab95a_26085391","updated":"2016-08-26 22:40:26.000000000","message":"Done","commit_id":"be714d9c214fcade01f690e4c0db9197229f78e8"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"5f6fc2ae11b5ac7f4e3a0c12228d9daaebab363a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"are written to this directory."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Possible values:"},{"line_number":53,"context_line":"    * An absolute pathname"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Related options:"},{"line_number":56,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_06b7cfd8","line":53,"updated":"2016-08-26 22:22:54.000000000","message":"I generally say something like \"String value representing a valid absolute pathname\" just to be more precise. \nPlease feel free to ignore it.","commit_id":"be714d9c214fcade01f690e4c0db9197229f78e8"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"8a6c9c6a959dbf198760cf01aaf95e1608be0a18","unresolved":false,"context_lines":[{"line_number":50,"context_line":"are written to this directory."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Possible values:"},{"line_number":53,"context_line":"    * An absolute pathname"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Related options:"},{"line_number":56,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_a622a3ff","line":53,"in_reply_to":"fa7ab95a_06b7cfd8","updated":"2016-08-26 22:27:06.000000000","message":"We haven\u0027t been very consistent with it.\nAnd, it is very likely that people won\u0027t stick to one way of describing possible values once all these go in. So, I think it\u0027s okay as long as it make sense.","commit_id":"be714d9c214fcade01f690e4c0db9197229f78e8"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"47f2f0df5022e8dc1e56e3f450685aeb2364f342","unresolved":false,"context_lines":[{"line_number":50,"context_line":"are written to this directory."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Possible values:"},{"line_number":53,"context_line":"    * An absolute pathname"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Related options:"},{"line_number":56,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_483d65ba","line":53,"in_reply_to":"fa7ab95a_a622a3ff","updated":"2016-08-26 22:40:26.000000000","message":"I\u0027m ok with the change.","commit_id":"be714d9c214fcade01f690e4c0db9197229f78e8"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"43736ed4e9bfee504c99554e947af7b2f7173e08","unresolved":false,"context_lines":[{"line_number":50,"context_line":"are written to this directory."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"NOTE: If you plan to export metadefs, make sure that this directory"},{"line_number":53,"context_line":"has write permissions set for the Glance user."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Possible values:"},{"line_number":56,"context_line":"    * String value representing a valid absolute pathname"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_bc3ab396","line":53,"range":{"start_line":53,"start_character":30,"end_line":53,"end_character":45},"updated":"2016-08-27 01:15:39.000000000","message":"I wonder if Glance with G in caps was intentional here. Or may be we can rewrite this as \"the user used to run the glance-api service\".","commit_id":"b8451da63a97eb2ef5ba1be0e67d606ae62656d5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"49415bd0b76b7e9edea9c0a3434607c99bd7a836","unresolved":false,"context_lines":[{"line_number":50,"context_line":"are written to this directory."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"NOTE: If you plan to export metadefs, make sure that this directory"},{"line_number":53,"context_line":"has write permissions set for the Glance user."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Possible values:"},{"line_number":56,"context_line":"    * String value representing a valid absolute pathname"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_42d9bc82","line":53,"range":{"start_line":53,"start_character":30,"end_line":53,"end_character":45},"in_reply_to":"fa7ab95a_bc3ab396","updated":"2016-08-27 03:34:12.000000000","message":"Your suggestion is what i was aiming for, but couldn\u0027t think of at the time.  Will put up a new PS with the change in a minute.","commit_id":"b8451da63a97eb2ef5ba1be0e67d606ae62656d5"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"cb68e682fba0a7f52ff6d43e8f0485b29dd11761","unresolved":false,"context_lines":[{"line_number":43,"context_line":"               help\u003d_(\"\"\""},{"line_number":44,"context_line":"Absolute path to the directory where JSON metadefs files are stored."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Glance Metadata Definitions (\"metadefs\") are served from the database,"},{"line_number":47,"context_line":"but are stored in files in the JSON format.  The files in this"},{"line_number":48,"context_line":"directory are used to initialize the metadefs in the database."},{"line_number":49,"context_line":"Additionally, when metadefs are exported from the database, the files"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_22f91881","line":46,"updated":"2016-08-27 04:02:14.000000000","message":"the word wrap seems to be way below 80. any particular reason?","commit_id":"9a298502d9e2f97bb67cb6f52b630585cc1e8ec6"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"cd9a67b01381d14897b341266625fe1326e79c0d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"               help\u003d_(\"\"\""},{"line_number":44,"context_line":"Absolute path to the directory where JSON metadefs files are stored."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Glance Metadata Definitions (\"metadefs\") are served from the database,"},{"line_number":47,"context_line":"but are stored in files in the JSON format.  The files in this"},{"line_number":48,"context_line":"directory are used to initialize the metadefs in the database."},{"line_number":49,"context_line":"Additionally, when metadefs are exported from the database, the files"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_226e782f","line":46,"in_reply_to":"fa7ab95a_22f91881","updated":"2016-08-27 04:08:58.000000000","message":"IIUC, we\u0027re wrapping at 70 because otherwise oslo.config wraps and then respects the newline, making the sample config look really bad.  I think there\u0027s a way to change this, but it hasn\u0027t merged yet.","commit_id":"9a298502d9e2f97bb67cb6f52b630585cc1e8ec6"}]}