)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"89852c61e767c0812a953dcce0bd45a178dbe2ec","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  database duplicate exception - `db_exc.DBDuplicateEntry`."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"glance/db/sqlalchemy/migrate_repo/versions/012_id_to_uuid.py"},{"line_number":33,"context_line":"- removed `meta` from global module functions to fixed race condition."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"glance/db/sqlalchemy/migration.py"},{"line_number":36,"context_line":"- general refactioring due to changes in nova"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"AAAARn%2F%2F7fM%3D","line":33,"updated":"2013-08-20 04:23:07.000000000","message":"I\u0027m not sure I understand the race condition here. Other than trying to upgrade and downgrade the schema at the same time, what else am I missing?","commit_id":"99628e8aa2a3f5e8eeeebeb12639590a7380fd78"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"f7a8e48734dad3d39195be2b447d85060079604f","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Global variable _ENGINE was replaced by common function get_engine()."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"New database config options came from Oslo. See Table below"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"-------------------------------------------------------------------"},{"line_number":39,"context_line":"Database config options ([group] option)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":32,"id":"AAAATn%2F82cw%3D","line":36,"updated":"2013-12-19 16:02:28.000000000","message":"This patch needs to be tagged with DocImpact. \n\nI\u0027d also like to see the documentation changed in order to reflect this changes, where needed.","commit_id":"fd31f8d024970ecc133ee8b6b5fef032041d6257"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"fd40ef067c2cfdca8567d2608a957bc28c6c28d0","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Global variable _ENGINE was replaced by common function get_engine()."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"New database config options came from Oslo. See Table below"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"-------------------------------------------------------------------"},{"line_number":39,"context_line":"Database config options ([group] option)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":32,"id":"AAAATn%2F8xNw%3D","line":36,"in_reply_to":"AAAATn%2F82cw%3D","updated":"2013-12-20 14:24:28.000000000","message":"Added DocImpact. If it\u0027s not enough, please clarify, what documentation do you mean.","commit_id":"fd31f8d024970ecc133ee8b6b5fef032041d6257"}],"glance/cmd/manage.py":[{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"d83c74ad767622eed02a4b218cf7a0b67c2e9638","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"from glance.common import config"},{"line_number":45,"context_line":"from glance.common import exception"},{"line_number":46,"context_line":"import glance.db.sqlalchemy.api  # noqa"},{"line_number":47,"context_line":"from glance.db.sqlalchemy import migration"},{"line_number":48,"context_line":"from glance.openstack.common import log"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"AAAAT3%2F%2FtpM%3D","line":46,"updated":"2014-01-03 01:26:18.000000000","message":"Does the #noqa here indicate that we don\u0027t actually reference this module any more? If so why can\u0027t it be removed? Thanks.","commit_id":"925ec411c4f2a3c8b9cdad36df4b7930e6ce305f"}],"glance/common/wsgi.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"f7a8e48734dad3d39195be2b447d85060079604f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"from glance.common import utils"},{"line_number":45,"context_line":"import glance.openstack.common.log as logging"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"eventlet.monkey_patch(time\u003dTrue)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"bind_opts \u003d ["},{"line_number":50,"context_line":"    cfg.StrOpt(\u0027bind_host\u0027, default\u003d\u00270.0.0.0\u0027,"}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAATn%2F82bM%3D","line":47,"updated":"2013-12-19 16:02:28.000000000","message":"Why is this needed? Can this be moved under the Server start method or the instance creation?","commit_id":"fd31f8d024970ecc133ee8b6b5fef032041d6257"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"fd40ef067c2cfdca8567d2608a957bc28c6c28d0","unresolved":false,"context_lines":[{"line_number":44,"context_line":"from glance.common import utils"},{"line_number":45,"context_line":"import glance.openstack.common.log as logging"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"eventlet.monkey_patch(time\u003dTrue)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"bind_opts \u003d ["},{"line_number":50,"context_line":"    cfg.StrOpt(\u0027bind_host\u0027, default\u003d\u00270.0.0.0\u0027,"}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAATn%2F8yGE%3D","line":47,"in_reply_to":"AAAATn%2F82bM%3D","updated":"2013-12-20 14:24:28.000000000","message":"Removed","commit_id":"fd31f8d024970ecc133ee8b6b5fef032041d6257"}],"glance/db/sqlalchemy/api.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"9f372b0118441896293429adf0ec11edbde89fb4","unresolved":false,"context_lines":[{"line_number":48,"context_line":"CONF.import_opt(\u0027debug\u0027, \u0027glance.openstack.common.log\u0027)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def setup_db_env():"},{"line_number":52,"context_line":"    \"\"\""},{"line_number":53,"context_line":"    Setup global configuration for database."},{"line_number":54,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAATn%2F%2BsHU%3D","line":51,"updated":"2013-11-21 14:38:15.000000000","message":"could we remove this in future patches?","commit_id":"a0ad984cc4b29cb1b9f561ed3b368d86b7aa1f3e"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"9f372b0118441896293429adf0ec11edbde89fb4","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"_get_session \u003d session.get_session"},{"line_number":78,"context_line":"get_engine \u003d session.get_engine"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"def image_create(context, values):"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAATn%2F%2BsHM%3D","line":78,"updated":"2013-11-21 14:38:15.000000000","message":"I think that we should unify this as well in next patch set","commit_id":"a0ad984cc4b29cb1b9f561ed3b368d86b7aa1f3e"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"f7a8e48734dad3d39195be2b447d85060079604f","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            raise"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"def setup_db_env():"},{"line_number":112,"context_line":"    \"\"\"Setup global configuration for database.\"\"\""},{"line_number":113,"context_line":"    global sa_logger, _IDLE_TIMEOUT, _MAX_RETRIES, _RETRY_INTERVAL, _CONNECTION"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAATn%2F82aU%3D","side":"PARENT","line":111,"updated":"2013-12-19 16:02:28.000000000","message":"What\u0027s the counterpart of this? How is the env set in oslo.db?","commit_id":"9ff915a262c1eb80a2b938ee20b3d72b51f80365"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"fd40ef067c2cfdca8567d2608a957bc28c6c28d0","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            raise"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"def setup_db_env():"},{"line_number":112,"context_line":"    \"\"\"Setup global configuration for database.\"\"\""},{"line_number":113,"context_line":"    global sa_logger, _IDLE_TIMEOUT, _MAX_RETRIES, _RETRY_INTERVAL, _CONNECTION"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAATn%2F8yGM%3D","side":"PARENT","line":111,"in_reply_to":"AAAATn%2F82aU%3D","updated":"2013-12-20 14:24:28.000000000","message":"We take this variable from config and use in create_engine() function directly. See \nhttps://github.com/openstack/oslo-incubator/blob/master/openstack/common/db/sqlalchemy/session.py#L661\n\nOr I understood you in a wrong way?","commit_id":"9ff915a262c1eb80a2b938ee20b3d72b51f80365"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"f7a8e48734dad3d39195be2b447d85060079604f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from glance.common import exception"},{"line_number":31,"context_line":"from glance.db.sqlalchemy import models"},{"line_number":32,"context_line":"import glance.openstack.common.log as os_logging"},{"line_number":33,"context_line":"from glance.openstack.common.db import exception as db_exc"},{"line_number":34,"context_line":"from glance.openstack.common.db.sqlalchemy import session"},{"line_number":35,"context_line":"from glance.openstack.common import timeutils"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAATn%2F82aw%3D","line":33,"updated":"2013-12-19 16:02:28.000000000","message":"I think this 2 import should be above the log import","commit_id":"fd31f8d024970ecc133ee8b6b5fef032041d6257"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"fd40ef067c2cfdca8567d2608a957bc28c6c28d0","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from glance.common import exception"},{"line_number":31,"context_line":"from glance.db.sqlalchemy import models"},{"line_number":32,"context_line":"import glance.openstack.common.log as os_logging"},{"line_number":33,"context_line":"from glance.openstack.common.db import exception as db_exc"},{"line_number":34,"context_line":"from glance.openstack.common.db.sqlalchemy import session"},{"line_number":35,"context_line":"from glance.openstack.common import timeutils"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAATn%2F8yNk%3D","line":33,"in_reply_to":"AAAATn%2F82aw%3D","updated":"2013-12-20 14:24:28.000000000","message":"Done","commit_id":"fd31f8d024970ecc133ee8b6b5fef032041d6257"}],"glance/db/sqlalchemy/migrate_repo/versions/012_id_to_uuid.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"9f372b0118441896293429adf0ec11edbde89fb4","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from glance.openstack.common import uuidutils"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"meta \u003d sqlalchemy.MetaData()"},{"line_number":31,"context_line":"and_ \u003d sqlalchemy.and_"},{"line_number":32,"context_line":"or_ \u003d sqlalchemy.or_"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAATn%2F%2BsFw%3D","side":"PARENT","line":30,"updated":"2013-11-21 14:38:15.000000000","message":"could we make this change in separated patch set?","commit_id":"7cd036cabdf72a73afa97734d124bf509ef49772"}],"glance/db/sqlalchemy/migrate_repo/versions/028_rename_unique_constraints.py":[{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"e1869fc07874a6bb0327653cd03e03e55f5edf64","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        for old_uc_name, columns in UC_DATA[table_name]:"},{"line_number":45,"context_line":"            if old_uc_name \u003d\u003d \"ix_image_properties_image_id_name\" \\"},{"line_number":46,"context_line":"               and migrate_engine.name \u003d\u003d \"postgresql\":"},{"line_number":47,"context_line":"                # one UC name different in postgresql so we sould get this name"},{"line_number":48,"context_line":"                # and drop UC using it"},{"line_number":49,"context_line":"                query \u003d \"\"\""},{"line_number":50,"context_line":"                    SELECT conname FROM pg_constraint WHERE"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAARn%2F%2F8gk%3D","line":47,"updated":"2013-08-19 21:34:49.000000000","message":"sould -\u003e should?","commit_id":"99628e8aa2a3f5e8eeeebeb12639590a7380fd78"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"bcea40878c82957cdd8e804c7f50b2f08cabf36f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        for old_uc_name, columns in UC_DATA[table_name]:"},{"line_number":45,"context_line":"            if old_uc_name \u003d\u003d \"ix_image_properties_image_id_name\" \\"},{"line_number":46,"context_line":"               and migrate_engine.name \u003d\u003d \"postgresql\":"},{"line_number":47,"context_line":"                # one UC name different in postgresql so we sould get this name"},{"line_number":48,"context_line":"                # and drop UC using it"},{"line_number":49,"context_line":"                query \u003d \"\"\""},{"line_number":50,"context_line":"                    SELECT conname FROM pg_constraint WHERE"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAARn%2F%2FwNM%3D","line":47,"in_reply_to":"AAAARn%2F%2F8gk%3D","updated":"2013-08-22 13:50:24.000000000","message":"Done","commit_id":"99628e8aa2a3f5e8eeeebeb12639590a7380fd78"}],"glance/db/sqlalchemy/migration.py":[{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"e1869fc07874a6bb0327653cd03e03e55f5edf64","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            engine.dispose()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# TODO(jkoelker) When migrate 0.7.3 is released and nova depends"},{"line_number":47,"context_line":"#                on that version or higher, this can be removed"},{"line_number":48,"context_line":"import migrate"},{"line_number":49,"context_line":"import distutils.version as dist_version"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAARn%2F%2F8gY%3D","line":46,"updated":"2013-08-19 21:34:49.000000000","message":"nova -\u003e glance?","commit_id":"99628e8aa2a3f5e8eeeebeb12639590a7380fd78"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"bcea40878c82957cdd8e804c7f50b2f08cabf36f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            engine.dispose()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# TODO(jkoelker) When migrate 0.7.3 is released and nova depends"},{"line_number":47,"context_line":"#                on that version or higher, this can be removed"},{"line_number":48,"context_line":"import migrate"},{"line_number":49,"context_line":"import distutils.version as dist_version"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAARn%2F%2FvyQ%3D","line":46,"in_reply_to":"AAAARn%2F%2F8gY%3D","updated":"2013-08-22 13:50:24.000000000","message":"Done","commit_id":"99628e8aa2a3f5e8eeeebeb12639590a7380fd78"}],"glance/tests/functional/db/test_registry.py":[{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"9e157bd2c5db264dc0f140e46ca2f55f32847bb4","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def get_db(config):"},{"line_number":26,"context_line":"    config(group\u003d\u0027database\u0027, connection\u003d\u0027sqlite://\u0027)"},{"line_number":27,"context_line":"    db_api \u003d glance.db.registry.api"},{"line_number":28,"context_line":"    db_api.setup_db_env()"},{"line_number":29,"context_line":"    return db_api"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAARn%2F%2F9g8%3D","line":26,"updated":"2013-08-19 17:07:09.000000000","message":"This change tells me that we\u0027re modifying how the database has to be configured. Will this change break previous configs out in the wild? Is there any way to avoid that problem?","commit_id":"99628e8aa2a3f5e8eeeebeb12639590a7380fd78"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"966adad483ab6fa1206b60c6d045109d8e17497a","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def get_db(config):"},{"line_number":26,"context_line":"    config(group\u003d\u0027database\u0027, connection\u003d\u0027sqlite://\u0027)"},{"line_number":27,"context_line":"    db_api \u003d glance.db.registry.api"},{"line_number":28,"context_line":"    db_api.setup_db_env()"},{"line_number":29,"context_line":"    return db_api"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAARn%2F%2F8mc%3D","line":26,"in_reply_to":"AAAARn%2F%2F9g8%3D","updated":"2013-08-19 21:04:44.000000000","message":"Actually it won\u0027t break because if you take a look at \nhttps://review.openstack.org/#/c/31068/5/glance/openstack/common/db/sqlalchemy/session.py\nline 281, \nyou will see that \u0027sql_connection\u0027 is deprecated and new value is stored in conf.database.connection\n\nSo in glance.conf you are still able to use sql_connection as a parameter, but all occurrences in code should be changed, so we are not able to access it in code using something like conf.sql_connection.","commit_id":"99628e8aa2a3f5e8eeeebeb12639590a7380fd78"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"f7a8e48734dad3d39195be2b447d85060079604f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"def get_db(config):"},{"line_number":23,"context_line":"    config(group\u003d\u0027database\u0027, connection\u003d\u0027sqlite://\u0027)"},{"line_number":24,"context_line":"    db_api \u003d glance.db.registry.api"},{"line_number":25,"context_line":"    db_api.setup_db_env()"},{"line_number":26,"context_line":"    return db_api"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAATn%2F82Wg%3D","line":25,"updated":"2013-12-19 16:02:28.000000000","message":"`setup_db_env` was removed in sqlalchemy, I think we should remove it from the registry API as well. I\u0027d like the db APIs to be consistent.","commit_id":"fd31f8d024970ecc133ee8b6b5fef032041d6257"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"fd40ef067c2cfdca8567d2608a957bc28c6c28d0","unresolved":false,"context_lines":[{"line_number":22,"context_line":"def get_db(config):"},{"line_number":23,"context_line":"    config(group\u003d\u0027database\u0027, connection\u003d\u0027sqlite://\u0027)"},{"line_number":24,"context_line":"    db_api \u003d glance.db.registry.api"},{"line_number":25,"context_line":"    db_api.setup_db_env()"},{"line_number":26,"context_line":"    return db_api"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAATn%2F8ySU%3D","line":25,"in_reply_to":"AAAATn%2F82Wg%3D","updated":"2013-12-20 14:24:28.000000000","message":"this method from glance.db.registry.api module and it calls configure_registry_client() function. See \nhttps://github.com/openstack/glance/blob/master/glance/db/registry/api.py#L42\n\nRemoved.","commit_id":"fd31f8d024970ecc133ee8b6b5fef032041d6257"}],"glance/tests/functional/db/test_sqlalchemy.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"11cc726680c95c02b52e8801c2e5739d678c9f50","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    config(connection\u003d\u0027sqlite://\u0027, group\u003d\u0027database\u0027)"},{"line_number":26,"context_line":"    config(verbose\u003dFalse, debug\u003dFalse)"},{"line_number":27,"context_line":"    db_api \u003d glance.db.sqlalchemy.api"},{"line_number":28,"context_line":"    db_api.setup_db_env()"},{"line_number":29,"context_line":"    return db_api"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAATn%2F%2BOU4%3D","line":28,"updated":"2013-11-28 17:39:05.000000000","message":"could we remove db_apb.setup_db_env() at all it just makes pass..","commit_id":"774d856240e53f92098ce7cd780e37a9491c6762"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"b1e34f5cd3907f824940266b96e334d819cb5ad0","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    config(connection\u003d\u0027sqlite://\u0027, group\u003d\u0027database\u0027)"},{"line_number":26,"context_line":"    config(verbose\u003dFalse, debug\u003dFalse)"},{"line_number":27,"context_line":"    db_api \u003d glance.db.sqlalchemy.api"},{"line_number":28,"context_line":"    db_api.setup_db_env()"},{"line_number":29,"context_line":"    return db_api"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAATn%2F%2BMoo%3D","line":28,"in_reply_to":"AAAATn%2F%2BOU4%3D","updated":"2013-11-29 10:54:50.000000000","message":"Done","commit_id":"774d856240e53f92098ce7cd780e37a9491c6762"}],"glance/tests/functional/test_glance_manage.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"9f372b0118441896293429adf0ec11edbde89fb4","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        #NOTE(bcwaldon): For some reason we need double-quotes around"},{"line_number":60,"context_line":"        # these two table names"},{"line_number":61,"context_line":"        # NOTE(vsergeyev): There are some cases when we have no double-quotes"},{"line_number":62,"context_line":"        self.assertTrue("},{"line_number":63,"context_line":"            \u0027CREATE TABLE \"image_members\"\u0027 in out or"},{"line_number":64,"context_line":"            \u0027CREATE TABLE image_members\u0027 in out)"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAATn%2F%2BsDE%3D","line":61,"updated":"2013-11-21 14:38:15.000000000","message":"this could be changed in separated patch","commit_id":"a0ad984cc4b29cb1b9f561ed3b368d86b7aa1f3e"}],"glance/tests/unit/v1/test_registry_api.py":[{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"9e157bd2c5db264dc0f140e46ca2f55f32847bb4","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def destroy_fixtures(self):"},{"line_number":109,"context_line":"        # Easiest to just drop the models and re-create them..."},{"line_number":110,"context_line":"        db_models.unregister_models(db_api.get_engine())"},{"line_number":111,"context_line":"        db_models.register_models(db_api.get_engine())"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def test_show(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAARn%2F%2F9gg%3D","line":110,"updated":"2013-08-19 17:07:09.000000000","message":"Would it make more sense to do\n\n    engine \u003d db_api.get_engine()\n    unregister_models(engine)\n    registrer_model(engine)","commit_id":"99628e8aa2a3f5e8eeeebeb12639590a7380fd78"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"bcea40878c82957cdd8e804c7f50b2f08cabf36f","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def destroy_fixtures(self):"},{"line_number":109,"context_line":"        # Easiest to just drop the models and re-create them..."},{"line_number":110,"context_line":"        db_models.unregister_models(db_api.get_engine())"},{"line_number":111,"context_line":"        db_models.register_models(db_api.get_engine())"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def test_show(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAARn%2F%2Fvwc%3D","line":110,"in_reply_to":"AAAARn%2F%2F9gg%3D","updated":"2013-08-22 13:50:24.000000000","message":"Done","commit_id":"99628e8aa2a3f5e8eeeebeb12639590a7380fd78"}]}