)]}'
{"glance/common/config.py":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"e35c0786dfef0dfc8fc5d370240d1cae0340f805","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Glance defines a standard set of properties (in its schema) that"},{"line_number":106,"context_line":"appear on every image. These properties are also known as"},{"line_number":107,"context_line":"``core properties``. In addition to these properties, Glance"},{"line_number":108,"context_line":"allows users to add custom properties to images. These are known"},{"line_number":109,"context_line":"as ``additional properties``."},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_e4a58b47","line":107,"range":{"start_line":107,"start_character":2,"end_line":107,"end_character":17},"updated":"2016-08-31 22:27:14.000000000","message":"\"base properties\" not core properties","commit_id":"80f071b89d84e85815a9f4ceb8e169abce46fe17"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"e02adc18873d049bb485e166dff7c240142ddd5f","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Glance defines a standard set of properties (in its schema) that"},{"line_number":106,"context_line":"appear on every image. These properties are also known as"},{"line_number":107,"context_line":"``core properties``. In addition to these properties, Glance"},{"line_number":108,"context_line":"allows users to add custom properties to images. These are known"},{"line_number":109,"context_line":"as ``additional properties``."},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_375887fa","line":107,"range":{"start_line":107,"start_character":2,"end_line":107,"end_character":17},"in_reply_to":"fa7ab95a_e4a58b47","updated":"2016-08-31 22:48:00.000000000","message":"Done","commit_id":"80f071b89d84e85815a9f4ceb8e169abce46fe17"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"e35c0786dfef0dfc8fc5d370240d1cae0340f805","unresolved":false,"context_lines":[{"line_number":177,"context_line":"controlled by specifying the ``limit`` parameter in the API request."},{"line_number":178,"context_line":"However, if a ``limit`` parameter is not specified, this"},{"line_number":179,"context_line":"configuration value will be used as the default number of results to"},{"line_number":180,"context_line":"be returned for any API request."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"NOTE: The value of this configuration option may not be greater than"},{"line_number":183,"context_line":"the value specified by ``api_limit_max``."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_244db399","line":180,"updated":"2016-08-31 22:27:14.000000000","message":"Please add a note saying that setting this to a large value will result into a degraded DB performance and having it too low will be a bad user experience.","commit_id":"80f071b89d84e85815a9f4ceb8e169abce46fe17"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"e02adc18873d049bb485e166dff7c240142ddd5f","unresolved":false,"context_lines":[{"line_number":177,"context_line":"controlled by specifying the ``limit`` parameter in the API request."},{"line_number":178,"context_line":"However, if a ``limit`` parameter is not specified, this"},{"line_number":179,"context_line":"configuration value will be used as the default number of results to"},{"line_number":180,"context_line":"be returned for any API request."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"NOTE: The value of this configuration option may not be greater than"},{"line_number":183,"context_line":"the value specified by ``api_limit_max``."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_17662329","line":180,"in_reply_to":"fa7ab95a_244db399","updated":"2016-08-31 22:48:00.000000000","message":"Done","commit_id":"80f071b89d84e85815a9f4ceb8e169abce46fe17"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"e35c0786dfef0dfc8fc5d370240d1cae0340f805","unresolved":false,"context_lines":[{"line_number":199,"context_line":"request or the ``limit_param_default`` configuration option."},{"line_number":200,"context_line":"The value in either case, can\u0027t be greater than the absolute maximum"},{"line_number":201,"context_line":"defined by this configuration option. Anything greater than this"},{"line_number":202,"context_line":"value is trimmed down to the maximum value defined here."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"Possible values:"},{"line_number":205,"context_line":"    * Any positive integer"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_e4010b08","line":202,"updated":"2016-08-31 22:27:14.000000000","message":"Copy over the note suggested above.","commit_id":"80f071b89d84e85815a9f4ceb8e169abce46fe17"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"e02adc18873d049bb485e166dff7c240142ddd5f","unresolved":false,"context_lines":[{"line_number":199,"context_line":"request or the ``limit_param_default`` configuration option."},{"line_number":200,"context_line":"The value in either case, can\u0027t be greater than the absolute maximum"},{"line_number":201,"context_line":"defined by this configuration option. Anything greater than this"},{"line_number":202,"context_line":"value is trimmed down to the maximum value defined here."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"Possible values:"},{"line_number":205,"context_line":"    * Any positive integer"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_f7629f15","line":202,"in_reply_to":"fa7ab95a_e4010b08","updated":"2016-08-31 22:48:00.000000000","message":"Done","commit_id":"80f071b89d84e85815a9f4ceb8e169abce46fe17"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"e35c0786dfef0dfc8fc5d370240d1cae0340f805","unresolved":false,"context_lines":[{"line_number":285,"context_line":"An image upload greater than the size mentioned here would result"},{"line_number":286,"context_line":"in an image creation failure. This configuration option defaults to"},{"line_number":287,"context_line":"1099511627776 bytes (1 TiB)."},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"NOTE: This value should only be increased after careful"},{"line_number":290,"context_line":"consideration and must be set less than or equal to"},{"line_number":291,"context_line":"8 EiB (9223372036854775808)."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_77684fbb","line":288,"updated":"2016-08-31 22:27:14.000000000","message":"Add a note here indicating that this value must be based on the backend storage capacity. Setting this too low may result into multiple image creation failures and bad user experience and having it too close to the total capacity may trouble the capacity planners.","commit_id":"80f071b89d84e85815a9f4ceb8e169abce46fe17"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"e02adc18873d049bb485e166dff7c240142ddd5f","unresolved":false,"context_lines":[{"line_number":285,"context_line":"An image upload greater than the size mentioned here would result"},{"line_number":286,"context_line":"in an image creation failure. This configuration option defaults to"},{"line_number":287,"context_line":"1099511627776 bytes (1 TiB)."},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"NOTE: This value should only be increased after careful"},{"line_number":290,"context_line":"consideration and must be set less than or equal to"},{"line_number":291,"context_line":"8 EiB (9223372036854775808)."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_b7aad717","line":288,"in_reply_to":"fa7ab95a_77684fbb","updated":"2016-08-31 22:48:00.000000000","message":"Done","commit_id":"80f071b89d84e85815a9f4ceb8e169abce46fe17"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f349e0cf14547782ac12018aac544ac3b3ed420f","unresolved":false,"context_lines":[{"line_number":208,"context_line":"NOTE: Setting this to a really large value may slow down database"},{"line_number":209,"context_line":"      queries and increase response times. While setting this to a"},{"line_number":210,"context_line":"      really low value may result in poor user experience."},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"Possible values:"},{"line_number":213,"context_line":"    * Any positive integer"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_ba771e01","line":211,"updated":"2016-08-31 23:03:14.000000000","message":"I suggest s/really/very/ in both sentences.\n\nGrammar nit: Begin the second sentence with \"Setting\" (beginning with \"While\" makes it a clause, not a standalone sentence).","commit_id":"5e353bfd40242017b725ab98812999fbdc7f2396"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f349e0cf14547782ac12018aac544ac3b3ed420f","unresolved":false,"context_lines":[{"line_number":303,"context_line":"      may result in a large number of image failures. And, setting"},{"line_number":304,"context_line":"      this to a really large value may result in faster consumption"},{"line_number":305,"context_line":"      of storage. Hence, this must be set according to the nature of"},{"line_number":306,"context_line":"      images created and storage capacity available."},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"Possible values:"},{"line_number":309,"context_line":"    * Any positive number less than or equal to 9223372036854775808"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_5a8612dc","line":306,"updated":"2016-08-31 23:03:14.000000000","message":"Again, I suggest \u0027very\u0027 instead of \u0027really\u0027.  (But I only suggest!)","commit_id":"5e353bfd40242017b725ab98812999fbdc7f2396"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"e7482a22ae16c7d44387f865a6b2cbf23fc72019","unresolved":false,"context_lines":[{"line_number":303,"context_line":"      may result in a large number of image failures. And, setting"},{"line_number":304,"context_line":"      this to a very large value may result in faster consumption"},{"line_number":305,"context_line":"      of storage. Hence, this must be set according to the nature of"},{"line_number":306,"context_line":"      images created and storage capacity available."},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"Possible values:"},{"line_number":309,"context_line":"    * Any positive number less than or equal to 9223372036854775808"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_ee5721c8","line":306,"updated":"2016-09-01 02:38:25.000000000","message":"all these are quite good additions and helpful for operators while making informed decisions.\n\nthanks much!","commit_id":"1f5deddf2e3af229bac624559d86f21434ff4967"}]}