)]}'
{"glance/common/config.py":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"2cce68a74c6d0d2ec36f43eb1c53762e42505a1d","unresolved":false,"context_lines":[{"line_number":72,"context_line":"``glance-api.conf``, the service will look for a file named"},{"line_number":73,"context_line":"``glance-api-paste.ini``.) If the paste configuration file is not"},{"line_number":74,"context_line":"found, the service refuses to start."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Possible values:"},{"line_number":77,"context_line":"    * A string value representing the name of the paste configuration"},{"line_number":78,"context_line":"      file."}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_2450530a","line":75,"updated":"2016-08-31 21:59:08.000000000","message":"May be a note saying, don\u0027t provide absolute path. It\u0027s a nit though.","commit_id":"b82d50cc4787df72a016be47e34c30003c2f2dd0"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"fca39476af599da4b8f64d32288e1352f00e3db7","unresolved":false,"context_lines":[{"line_number":72,"context_line":"``glance-api.conf``, the service will look for a file named"},{"line_number":73,"context_line":"``glance-api-paste.ini``.) If the paste configuration file is not"},{"line_number":74,"context_line":"found, the service refuses to start."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Possible values:"},{"line_number":77,"context_line":"    * A string value representing the name of the paste configuration"},{"line_number":78,"context_line":"      file."}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_d7011b08","line":75,"in_reply_to":"fa7ab95a_17bd43d7","updated":"2016-08-31 22:49:25.000000000","message":"Cool. Added the note.","commit_id":"b82d50cc4787df72a016be47e34c30003c2f2dd0"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"e35557cc67a06d9196379bfc8c1ebe23df7d7661","unresolved":false,"context_lines":[{"line_number":72,"context_line":"``glance-api.conf``, the service will look for a file named"},{"line_number":73,"context_line":"``glance-api-paste.ini``.) If the paste configuration file is not"},{"line_number":74,"context_line":"found, the service refuses to start."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Possible values:"},{"line_number":77,"context_line":"    * A string value representing the name of the paste configuration"},{"line_number":78,"context_line":"      file."}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_a48463b1","line":75,"in_reply_to":"fa7ab95a_2450530a","updated":"2016-08-31 22:19:02.000000000","message":"Also, relative path right?\nAs per https://github.com/openstack/glance/blob/master/glance/common/config.py#L423","commit_id":"b82d50cc4787df72a016be47e34c30003c2f2dd0"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"93f238c5159b3cf73363c6288efe7ecc12985ae1","unresolved":false,"context_lines":[{"line_number":72,"context_line":"``glance-api.conf``, the service will look for a file named"},{"line_number":73,"context_line":"``glance-api-paste.ini``.) If the paste configuration file is not"},{"line_number":74,"context_line":"found, the service refuses to start."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Possible values:"},{"line_number":77,"context_line":"    * A string value representing the name of the paste configuration"},{"line_number":78,"context_line":"      file."}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_17bd43d7","line":75,"in_reply_to":"fa7ab95a_a48463b1","updated":"2016-08-31 22:40:14.000000000","message":"cool, good digging. I was running under assumptions which is a bad idea usually, unless it\u0027s a release week :)","commit_id":"b82d50cc4787df72a016be47e34c30003c2f2dd0"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"2cce68a74c6d0d2ec36f43eb1c53762e42505a1d","unresolved":false,"context_lines":[{"line_number":114,"context_line":"Provide a string value representing the executor to use for task"},{"line_number":115,"context_line":"executions. By default, ``TaskFlow`` executor is used."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"``Eventlet`` executors use a green thread pool to execute calls"},{"line_number":118,"context_line":"asynchronously. The coroutines are confined to the parent threads"},{"line_number":119,"context_line":"and execution of tasks on remote workers is not supported."},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_e4466b4e","line":117,"range":{"start_line":117,"start_character":0,"end_line":117,"end_character":12},"updated":"2016-08-31 21:59:08.000000000","message":"but this is deprecated\n\nhttps://github.com/openstack/glance/blob/78d581365a47aa053fbbf5e9c3244fb0b7ceddd8/glance/domain/__init__.py#L495-L503","commit_id":"b82d50cc4787df72a016be47e34c30003c2f2dd0"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"0fea7dac16e3c894841791f563c1386b05fcade2","unresolved":false,"context_lines":[{"line_number":114,"context_line":"Provide a string value representing the executor to use for task"},{"line_number":115,"context_line":"executions. By default, ``TaskFlow`` executor is used."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"``Eventlet`` executors use a green thread pool to execute calls"},{"line_number":118,"context_line":"asynchronously. The coroutines are confined to the parent threads"},{"line_number":119,"context_line":"and execution of tasks on remote workers is not supported."},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_b7e7373f","line":117,"range":{"start_line":117,"start_character":0,"end_line":117,"end_character":12},"in_reply_to":"fa7ab95a_84f83f7e","updated":"2016-08-31 22:30:45.000000000","message":"Actually since the code handles it for backward compatibility, do we just say that eventlet is deprecated and taskflow is the preferred executor as a \"note\" ?","commit_id":"b82d50cc4787df72a016be47e34c30003c2f2dd0"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"93f238c5159b3cf73363c6288efe7ecc12985ae1","unresolved":false,"context_lines":[{"line_number":114,"context_line":"Provide a string value representing the executor to use for task"},{"line_number":115,"context_line":"executions. By default, ``TaskFlow`` executor is used."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"``Eventlet`` executors use a green thread pool to execute calls"},{"line_number":118,"context_line":"asynchronously. The coroutines are confined to the parent threads"},{"line_number":119,"context_line":"and execution of tasks on remote workers is not supported."},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_579c2b5d","line":117,"range":{"start_line":117,"start_character":0,"end_line":117,"end_character":12},"in_reply_to":"fa7ab95a_84f83f7e","updated":"2016-08-31 22:40:14.000000000","message":"Those opts are different, ignore those.","commit_id":"b82d50cc4787df72a016be47e34c30003c2f2dd0"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"93f238c5159b3cf73363c6288efe7ecc12985ae1","unresolved":false,"context_lines":[{"line_number":114,"context_line":"Provide a string value representing the executor to use for task"},{"line_number":115,"context_line":"executions. By default, ``TaskFlow`` executor is used."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"``Eventlet`` executors use a green thread pool to execute calls"},{"line_number":118,"context_line":"asynchronously. The coroutines are confined to the parent threads"},{"line_number":119,"context_line":"and execution of tasks on remote workers is not supported."},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_f7dc5f1a","line":117,"range":{"start_line":117,"start_character":0,"end_line":117,"end_character":12},"in_reply_to":"fa7ab95a_b7e7373f","updated":"2016-08-31 22:40:14.000000000","message":"code is ignoring the config option so I don\u0027t consider it to be back compat.\n\nBut you are on right track for the note on preferred value.","commit_id":"b82d50cc4787df72a016be47e34c30003c2f2dd0"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"e35557cc67a06d9196379bfc8c1ebe23df7d7661","unresolved":false,"context_lines":[{"line_number":114,"context_line":"Provide a string value representing the executor to use for task"},{"line_number":115,"context_line":"executions. By default, ``TaskFlow`` executor is used."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"``Eventlet`` executors use a green thread pool to execute calls"},{"line_number":118,"context_line":"asynchronously. The coroutines are confined to the parent threads"},{"line_number":119,"context_line":"and execution of tasks on remote workers is not supported."},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_84f83f7e","line":117,"range":{"start_line":117,"start_character":0,"end_line":117,"end_character":12},"in_reply_to":"fa7ab95a_e4466b4e","updated":"2016-08-31 22:19:02.000000000","message":"I will go ahead and remove this. And also edit the ``choices`` parameter. \nA quick clarification here though. The eventlet opts in common/wsgi.py are handled to allow backward compatibility in a similar way? \n(https://github.com/openstack/glance/blob/master/glance/common/wsgi.py#L82-L106)","commit_id":"b82d50cc4787df72a016be47e34c30003c2f2dd0"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"fca39476af599da4b8f64d32288e1352f00e3db7","unresolved":false,"context_lines":[{"line_number":114,"context_line":"Provide a string value representing the executor to use for task"},{"line_number":115,"context_line":"executions. By default, ``TaskFlow`` executor is used."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"``Eventlet`` executors use a green thread pool to execute calls"},{"line_number":118,"context_line":"asynchronously. The coroutines are confined to the parent threads"},{"line_number":119,"context_line":"and execution of tasks on remote workers is not supported."},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_fafe0604","line":117,"range":{"start_line":117,"start_character":0,"end_line":117,"end_character":12},"in_reply_to":"fa7ab95a_f7dc5f1a","updated":"2016-08-31 22:49:25.000000000","message":"Done","commit_id":"b82d50cc4787df72a016be47e34c30003c2f2dd0"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"2cce68a74c6d0d2ec36f43eb1c53762e42505a1d","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Possible values:"},{"line_number":128,"context_line":"    * taskflow"},{"line_number":129,"context_line":"    * eventlet"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Related Options:"},{"line_number":132,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_a446231f","line":129,"updated":"2016-08-31 21:59:08.000000000","message":"ditto","commit_id":"b82d50cc4787df72a016be47e34c30003c2f2dd0"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"1e3d5e03bd980604e466c4a33de10b7a2bd07c2e","unresolved":false,"context_lines":[{"line_number":62,"context_line":"server application deployments."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"NOTES:"},{"line_number":65,"context_line":"    * Provide just the name and not the relative/absolute path to"},{"line_number":66,"context_line":"      the paste configuration file."},{"line_number":67,"context_line":"    * The sample paste configuration file shipped with Glance need"},{"line_number":68,"context_line":"      not be edited in most cases as it comes with ready-made"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_fa7366b2","line":65,"range":{"start_line":65,"start_character":40,"end_line":65,"end_character":48},"updated":"2016-08-31 22:57:56.000000000","message":"Isn\u0027t relative path valid?","commit_id":"fb4d7a4e1745c5509f88f60921f09082b6bc9761"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"83acdde80020162945e07ae4eca13d282a423833","unresolved":false,"context_lines":[{"line_number":62,"context_line":"server application deployments."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"NOTES:"},{"line_number":65,"context_line":"    * Provide just the name and not the relative/absolute path to"},{"line_number":66,"context_line":"      the paste configuration file."},{"line_number":67,"context_line":"    * The sample paste configuration file shipped with Glance need"},{"line_number":68,"context_line":"      not be edited in most cases as it comes with ready-made"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_95c4eb92","line":65,"range":{"start_line":65,"start_character":40,"end_line":65,"end_character":48},"in_reply_to":"fa7ab95a_3a0cee93","updated":"2016-08-31 23:13:39.000000000","message":"True, but if you give \"../glance/sample.txt\", it\u0027ll be resolved as \"/opt/stack/glance/sample.txt\"\n\nBasically, it takes a relative path and resolves it to an absolute path.","commit_id":"fb4d7a4e1745c5509f88f60921f09082b6bc9761"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"73ca6bf9bdb6c5cb32ea197ed323905f4305d8ce","unresolved":false,"context_lines":[{"line_number":62,"context_line":"server application deployments."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"NOTES:"},{"line_number":65,"context_line":"    * Provide just the name and not the relative/absolute path to"},{"line_number":66,"context_line":"      the paste configuration file."},{"line_number":67,"context_line":"    * The sample paste configuration file shipped with Glance need"},{"line_number":68,"context_line":"      not be edited in most cases as it comes with ready-made"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_35ca3f1b","line":65,"range":{"start_line":65,"start_character":40,"end_line":65,"end_character":48},"in_reply_to":"fa7ab95a_95a30b9e","updated":"2016-08-31 23:24:03.000000000","message":"How about a path relative to the glance directory?","commit_id":"fb4d7a4e1745c5509f88f60921f09082b6bc9761"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"2d85be1742d13c219cc5c73773fad030526b9aac","unresolved":false,"context_lines":[{"line_number":62,"context_line":"server application deployments."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"NOTES:"},{"line_number":65,"context_line":"    * Provide just the name and not the relative/absolute path to"},{"line_number":66,"context_line":"      the paste configuration file."},{"line_number":67,"context_line":"    * The sample paste configuration file shipped with Glance need"},{"line_number":68,"context_line":"      not be edited in most cases as it comes with ready-made"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_95a30b9e","line":65,"range":{"start_line":65,"start_character":40,"end_line":65,"end_character":48},"in_reply_to":"fa7ab95a_95c4eb92","updated":"2016-08-31 23:17:13.000000000","message":"True. Do we have to add the right format to give for relative path just to make it clear? Or do you suggest I just remove \"relative\"?","commit_id":"fb4d7a4e1745c5509f88f60921f09082b6bc9761"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"2e0d02213c05f75a81f60719d54bd2c596066823","unresolved":false,"context_lines":[{"line_number":62,"context_line":"server application deployments."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"NOTES:"},{"line_number":65,"context_line":"    * Provide just the name and not the relative/absolute path to"},{"line_number":66,"context_line":"      the paste configuration file."},{"line_number":67,"context_line":"    * The sample paste configuration file shipped with Glance need"},{"line_number":68,"context_line":"      not be edited in most cases as it comes with ready-made"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_3a0cee93","line":65,"range":{"start_line":65,"start_character":40,"end_line":65,"end_character":48},"in_reply_to":"fa7ab95a_fa7366b2","updated":"2016-08-31 23:02:56.000000000","message":"Hemanth, if a relative path is given, os.path.abspath(relative_path) appends the given relative path with the partial absolute path.\n\nFor example: If \"stack/glance/sample.txt\" is given, os.path.abspath returns \"/opt/stack/stack/glance/sample.txt\"","commit_id":"fb4d7a4e1745c5509f88f60921f09082b6bc9761"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"1e3d5e03bd980604e466c4a33de10b7a2bd07c2e","unresolved":false,"context_lines":[{"line_number":121,"context_line":"declarative manner. Hence it is recommended that ``TaskFlow``"},{"line_number":122,"context_line":"executor is used."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"NOTE: ``Eventlet`` executors confine coroutines to the parent"},{"line_number":125,"context_line":"threads and execution of tasks on remote workers is not supported."},{"line_number":126,"context_line":"For this reason, it is strongly recommended to use the default value"},{"line_number":127,"context_line":"for this configuration option."},{"line_number":128,"context_line":"If ``task_executor`` is set to ``eventlet``, Glance will"},{"line_number":129,"context_line":"automatically use ``taskflow`` executor instead."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Possible values:"},{"line_number":132,"context_line":"    * taskflow"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_3addce42","line":129,"range":{"start_line":124,"start_character":0,"end_line":129,"end_character":48},"updated":"2016-08-31 22:57:56.000000000","message":"I don\u0027t think this is required. If eventlet is not one of the possible values, then there is no point adding a note about it.\n\nWhen we do get rid of the code that falls-back to taskflow, this NOTE will become obsolete because I\u0027m more or less sure  we\u0027ll forget to update the help text :)","commit_id":"fb4d7a4e1745c5509f88f60921f09082b6bc9761"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"a558ae8059c5e4ccbf845381f790a0a1228fc77a","unresolved":false,"context_lines":[{"line_number":121,"context_line":"declarative manner. Hence it is recommended that ``TaskFlow``"},{"line_number":122,"context_line":"executor is used."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"NOTE: ``Eventlet`` executors confine coroutines to the parent"},{"line_number":125,"context_line":"threads and execution of tasks on remote workers is not supported."},{"line_number":126,"context_line":"For this reason, it is strongly recommended to use the default value"},{"line_number":127,"context_line":"for this configuration option."},{"line_number":128,"context_line":"If ``task_executor`` is set to ``eventlet``, Glance will"},{"line_number":129,"context_line":"automatically use ``taskflow`` executor instead."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Possible values:"},{"line_number":132,"context_line":"    * taskflow"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_fa11a6b0","line":129,"range":{"start_line":124,"start_character":0,"end_line":129,"end_character":48},"in_reply_to":"fa7ab95a_3addce42","updated":"2016-08-31 23:02:05.000000000","message":"+1","commit_id":"fb4d7a4e1745c5509f88f60921f09082b6bc9761"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"2e0d02213c05f75a81f60719d54bd2c596066823","unresolved":false,"context_lines":[{"line_number":121,"context_line":"declarative manner. Hence it is recommended that ``TaskFlow``"},{"line_number":122,"context_line":"executor is used."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"NOTE: ``Eventlet`` executors confine coroutines to the parent"},{"line_number":125,"context_line":"threads and execution of tasks on remote workers is not supported."},{"line_number":126,"context_line":"For this reason, it is strongly recommended to use the default value"},{"line_number":127,"context_line":"for this configuration option."},{"line_number":128,"context_line":"If ``task_executor`` is set to ``eventlet``, Glance will"},{"line_number":129,"context_line":"automatically use ``taskflow`` executor instead."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Possible values:"},{"line_number":132,"context_line":"    * taskflow"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_da722211","line":129,"range":{"start_line":124,"start_character":0,"end_line":129,"end_character":48},"in_reply_to":"fa7ab95a_fa11a6b0","updated":"2016-08-31 23:02:56.000000000","message":"Done","commit_id":"fb4d7a4e1745c5509f88f60921f09082b6bc9761"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3d589827fc90c07e09474684bc35b9e534beed37","unresolved":false,"context_lines":[{"line_number":118,"context_line":"``TaskFlow`` helps make task executions easy, consistent, scalable"},{"line_number":119,"context_line":"and reliable. It also enables creation of lightweight task objects"},{"line_number":120,"context_line":"and/or functions that are combined together into flows in a"},{"line_number":121,"context_line":"declarative manner. Hence it is recommended that ``TaskFlow``"},{"line_number":122,"context_line":"executor is used."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Possible values:"},{"line_number":125,"context_line":"    * taskflow"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_75f687fa","line":122,"range":{"start_line":121,"start_character":20,"end_line":122,"end_character":17},"updated":"2016-08-31 23:12:00.000000000","message":"Seems redundant now?  But I\u0027m not going to insist on removing it.","commit_id":"705a57d467a7f22ad803a0e6761ebe325793ceaa"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"72beb451fe6a82ad131d5ae4814f40bfeb2cb313","unresolved":false,"context_lines":[{"line_number":118,"context_line":"``TaskFlow`` helps make task executions easy, consistent, scalable"},{"line_number":119,"context_line":"and reliable. It also enables creation of lightweight task objects"},{"line_number":120,"context_line":"and/or functions that are combined together into flows in a"},{"line_number":121,"context_line":"declarative manner. Hence it is recommended that ``TaskFlow``"},{"line_number":122,"context_line":"executor is used."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Possible values:"},{"line_number":125,"context_line":"    * taskflow"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_b5e2cfff","line":122,"range":{"start_line":121,"start_character":20,"end_line":122,"end_character":17},"in_reply_to":"fa7ab95a_75f687fa","updated":"2016-08-31 23:16:11.000000000","message":"+1\nI think the config opt itself is redundant if there is just one choice. But, yeah, we can get rid of it.","commit_id":"705a57d467a7f22ad803a0e6761ebe325793ceaa"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"f8e88b3181b957182db86ef29198681572ad9a6d","unresolved":false,"context_lines":[{"line_number":118,"context_line":"``TaskFlow`` helps make task executions easy, consistent, scalable"},{"line_number":119,"context_line":"and reliable. It also enables creation of lightweight task objects"},{"line_number":120,"context_line":"and/or functions that are combined together into flows in a"},{"line_number":121,"context_line":"declarative manner. Hence it is recommended that ``TaskFlow``"},{"line_number":122,"context_line":"executor is used."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Possible values:"},{"line_number":125,"context_line":"    * taskflow"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_d56cb39e","line":122,"range":{"start_line":121,"start_character":20,"end_line":122,"end_character":17},"in_reply_to":"fa7ab95a_75f687fa","updated":"2016-08-31 23:13:55.000000000","message":"It can be removed. For now, this opt is all for taskflow. No other choices anyway.","commit_id":"705a57d467a7f22ad803a0e6761ebe325793ceaa"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"5ef044c621d4de28e15009e00bb3289a63609e8f","unresolved":false,"context_lines":[{"line_number":71,"context_line":"If no value is specified for this option, the ``paste.ini`` file"},{"line_number":72,"context_line":"with the prefix of the corresponding Glance service\u0027s configuration"},{"line_number":73,"context_line":"file name will be searched for in the known configuration"},{"line_number":74,"context_line":"directories. (For example, if this option is configured in"},{"line_number":75,"context_line":"``glance-api.conf``, the service will look for a file named"},{"line_number":76,"context_line":"``glance-api-paste.ini``.) If the paste configuration file is not"},{"line_number":77,"context_line":"found, the service refuses to start."},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_7044d51a","line":75,"range":{"start_line":74,"start_character":27,"end_line":75,"end_character":17},"updated":"2016-08-31 23:38:36.000000000","message":"I\u0027m a bit confused on this, if this option is already configured in glance-api.conf, wouldn\u0027t that specify the name of the paste file? Why would the service look for something named glance-api-paste.ini?","commit_id":"ed8a213139cd91afc83a11960103f96e56893aad"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"60e469b3e74b6e33d5a6dd20558d3899e90e88a2","unresolved":false,"context_lines":[{"line_number":71,"context_line":"If no value is specified for this option, the ``paste.ini`` file"},{"line_number":72,"context_line":"with the prefix of the corresponding Glance service\u0027s configuration"},{"line_number":73,"context_line":"file name will be searched for in the known configuration"},{"line_number":74,"context_line":"directories. (For example, if this option is configured in"},{"line_number":75,"context_line":"``glance-api.conf``, the service will look for a file named"},{"line_number":76,"context_line":"``glance-api-paste.ini``.) If the paste configuration file is not"},{"line_number":77,"context_line":"found, the service refuses to start."},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_7038553e","line":75,"range":{"start_line":74,"start_character":27,"end_line":75,"end_character":17},"in_reply_to":"fa7ab95a_308b2d20","updated":"2016-08-31 23:47:47.000000000","message":"Done","commit_id":"ed8a213139cd91afc83a11960103f96e56893aad"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"28d49f3cc5f9c4638732dc38c6bfebc7aa02ebec","unresolved":false,"context_lines":[{"line_number":71,"context_line":"If no value is specified for this option, the ``paste.ini`` file"},{"line_number":72,"context_line":"with the prefix of the corresponding Glance service\u0027s configuration"},{"line_number":73,"context_line":"file name will be searched for in the known configuration"},{"line_number":74,"context_line":"directories. (For example, if this option is configured in"},{"line_number":75,"context_line":"``glance-api.conf``, the service will look for a file named"},{"line_number":76,"context_line":"``glance-api-paste.ini``.) If the paste configuration file is not"},{"line_number":77,"context_line":"found, the service refuses to start."},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_b0e2ddff","line":75,"range":{"start_line":74,"start_character":27,"end_line":75,"end_character":17},"in_reply_to":"fa7ab95a_7044d51a","updated":"2016-08-31 23:41:48.000000000","message":"What I meant was if this option is found in glance-api and is missing, it will look for glance-api-paste.ini.\nGood catch Alex. It is kinda confusing. \nShall I edit it to (For example, if this option is found with no value set in ``glance-api.conf`` ..... ?","commit_id":"ed8a213139cd91afc83a11960103f96e56893aad"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"69d89448a05f65ac745da4c7e83eff5549d80398","unresolved":false,"context_lines":[{"line_number":71,"context_line":"If no value is specified for this option, the ``paste.ini`` file"},{"line_number":72,"context_line":"with the prefix of the corresponding Glance service\u0027s configuration"},{"line_number":73,"context_line":"file name will be searched for in the known configuration"},{"line_number":74,"context_line":"directories. (For example, if this option is configured in"},{"line_number":75,"context_line":"``glance-api.conf``, the service will look for a file named"},{"line_number":76,"context_line":"``glance-api-paste.ini``.) If the paste configuration file is not"},{"line_number":77,"context_line":"found, the service refuses to start."},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_308b2d20","line":75,"range":{"start_line":74,"start_character":27,"end_line":75,"end_character":17},"in_reply_to":"fa7ab95a_b0e2ddff","updated":"2016-08-31 23:44:02.000000000","message":"I think that would be good. Maybe something like:\n\"...if this option is missing from or has no value set in glance-api.conf...\"","commit_id":"ed8a213139cd91afc83a11960103f96e56893aad"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e3e3313753a27e2dfe31b33291d08e96059a0bfe","unresolved":false,"context_lines":[{"line_number":108,"context_line":"               deprecated_opts\u003d[cfg.DeprecatedOpt(\u0027task_time_to_live\u0027,"},{"line_number":109,"context_line":"                                                  group\u003d\u0027DEFAULT\u0027)]),"},{"line_number":110,"context_line":"    cfg.StrOpt(\u0027task_executor\u0027,"},{"line_number":111,"context_line":"               default\u003d\u0027taskflow\u0027,"},{"line_number":112,"context_line":"               help\u003d_(\"\"\""},{"line_number":113,"context_line":"Task executor to be used to run task scripts."},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_47829253","line":111,"updated":"2016-09-01 12:59:59.000000000","message":"This will make sure the option appears correctly in the config file as all lowercase.","commit_id":"ef0475dd3fa2e4c4b53cbc274fea8bc03754f022"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e3e3313753a27e2dfe31b33291d08e96059a0bfe","unresolved":false,"context_lines":[{"line_number":113,"context_line":"Task executor to be used to run task scripts."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Provide a string value representing the executor to use for task"},{"line_number":116,"context_line":"executions. By default, ``TaskFlow`` executor is used."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"``TaskFlow`` helps make task executions easy, consistent, scalable"},{"line_number":119,"context_line":"and reliable. It also enables creation of lightweight task objects"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_641b1481","line":116,"range":{"start_line":116,"start_character":24,"end_line":116,"end_character":36},"updated":"2016-09-01 12:59:59.000000000","message":"I suggest changing to:\n\nBy default, the TaskFlow executor is used\n\n(no quotes, we\u0027re talking about the project)","commit_id":"ef0475dd3fa2e4c4b53cbc274fea8bc03754f022"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e3e3313753a27e2dfe31b33291d08e96059a0bfe","unresolved":false,"context_lines":[{"line_number":115,"context_line":"Provide a string value representing the executor to use for task"},{"line_number":116,"context_line":"executions. By default, ``TaskFlow`` executor is used."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"``TaskFlow`` helps make task executions easy, consistent, scalable"},{"line_number":119,"context_line":"and reliable. It also enables creation of lightweight task objects"},{"line_number":120,"context_line":"and/or functions that are combined together into flows in a"},{"line_number":121,"context_line":"declarative manner."}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_c713025b","line":118,"range":{"start_line":118,"start_character":0,"end_line":118,"end_character":12},"updated":"2016-09-01 12:59:59.000000000","message":"Again, we\u0027re talking about the product, so remove the quotes","commit_id":"ef0475dd3fa2e4c4b53cbc274fea8bc03754f022"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"74bffaf38921dff66fb3c1f5d1c8fa86a34522c0","unresolved":false,"context_lines":[{"line_number":121,"context_line":"declarative manner."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Possible values:"},{"line_number":124,"context_line":"    * taskflow"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Related Options:"},{"line_number":127,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_aea0b9a6","line":124,"range":{"start_line":124,"start_character":6,"end_line":124,"end_character":14},"updated":"2016-09-01 02:44:28.000000000","message":"has anyone tested caps for the config values?\n\nWe do refer to these things in the above text in caps. I think an operator may inadvertently copy that one and service may refuse to start.\n\nNot a big deal because we provide appropriate possible values but extra checks would be a nice courtesy addition.","commit_id":"ef0475dd3fa2e4c4b53cbc274fea8bc03754f022"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e3e3313753a27e2dfe31b33291d08e96059a0bfe","unresolved":false,"context_lines":[{"line_number":121,"context_line":"declarative manner."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Possible values:"},{"line_number":124,"context_line":"    * taskflow"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Related Options:"},{"line_number":127,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_2454ac1f","line":124,"range":{"start_line":124,"start_character":6,"end_line":124,"end_character":14},"in_reply_to":"fa7ab95a_8ed695ef","updated":"2016-09-01 12:59:59.000000000","message":"Good catch, Nikhil.\n\nDharini, I suggest changing the ``TaskFlow`` above to plain text as indicated above.\n\nI think leave the text as it is here, just plain. I think we\u0027ve been consistent about plain text in the \"Possible values\" list on all the patches (but correct me if I\u0027m wrong about that).","commit_id":"ef0475dd3fa2e4c4b53cbc274fea8bc03754f022"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"f1767dce623ce6567641a4f7203b24978873122f","unresolved":false,"context_lines":[{"line_number":121,"context_line":"declarative manner."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Possible values:"},{"line_number":124,"context_line":"    * taskflow"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Related Options:"},{"line_number":127,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_8ed695ef","line":124,"range":{"start_line":124,"start_character":6,"end_line":124,"end_character":14},"in_reply_to":"fa7ab95a_aea0b9a6","updated":"2016-09-01 02:48:01.000000000","message":"I capitalized it cos we were talking in general about the executor. \nShould actually not be in caps. \nWill do a follow up for this. Thanks Nikhil.","commit_id":"ef0475dd3fa2e4c4b53cbc274fea8bc03754f022"},{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"2703ac897c20be1baecd9b1de1037c5ac51cea7f","unresolved":false,"context_lines":[{"line_number":37,"context_line":"Deployment flavor to use in the server application pipeline."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Provide a string value representing the appropriate deployment"},{"line_number":40,"context_line":"flavor used in the server application pipleline. This is typically"},{"line_number":41,"context_line":"the partial name of a pipeline in the paste configuration file with"},{"line_number":42,"context_line":"the service name removed."},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_9e0ce33c","line":40,"range":{"start_line":40,"start_character":38,"end_line":40,"end_character":47},"updated":"2016-09-01 13:59:48.000000000","message":"s/pipleline/pipeline","commit_id":"afb18df869946a4a1175fc20268417671da7dcf3"}]}