)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"8189c0f40280fec6671d6e01f64ce84dc6ad55c1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Cyril Roelandt \u003ccyril@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-05 18:12:04 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Emit a warning when using the db.simple.api backend with more than 1 worker"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When using more than one worker, only one of them will return data, thus"},{"line_number":10,"context_line":"leading users to not have access to every single piece of data at once."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a89bdaa_a8997b21","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":75},"updated":"2016-09-06 13:48:03.000000000","message":"Please wrap this at 50","commit_id":"f8cf06dde0a82378a2474eb9552696a3512bb21e"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"7a728040de680aa977f502058500dcc4f1722e40","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Cyril Roelandt \u003ccyril@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-20 18:03:04 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Emit a warning when using the db.simple.api"},{"line_number":8,"context_line":"backend with more than 1 worker"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"When using more than one worker, only one of them will return data, thus"},{"line_number":11,"context_line":"leading users to not have access to every single piece of data at once."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a8ec9b2_534998cf","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":31},"updated":"2016-09-20 16:19:48.000000000","message":"Not sure if this can span over two lines. Think it should be just one line not exceeding 50.","commit_id":"25262f24ebf90e06dfc5cdd8e7d0f5d361de361a"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"796428f384d440640dbbcc4fa361b8ca9a8dd084","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-09-20 18:03:04 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Emit a warning when using the db.simple.api"},{"line_number":8,"context_line":"backend with more than 1 worker"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"When using more than one worker, only one of them will return data, thus"},{"line_number":11,"context_line":"leading users to not have access to every single piece of data at once."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a8ec9b2_8d7f34df","line":8,"in_reply_to":"7a8ec9b2_534998cf","updated":"2016-09-21 16:30:17.000000000","message":"Will do, but really, this sounds a bit crazy. Why 50?","commit_id":"25262f24ebf90e06dfc5cdd8e7d0f5d361de361a"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"1792ffc3cd38a89b067aa18859a1ff10c788c2d3","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-09-20 18:03:04 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Emit a warning when using the db.simple.api"},{"line_number":8,"context_line":"backend with more than 1 worker"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"When using more than one worker, only one of them will return data, thus"},{"line_number":11,"context_line":"leading users to not have access to every single piece of data at once."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a8ec9b2_32f91c81","line":8,"in_reply_to":"7a8ec9b2_8d7f34df","updated":"2016-09-21 16:57:28.000000000","message":"No clue really.\nThat\u0027s what Openstack recommends\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"25262f24ebf90e06dfc5cdd8e7d0f5d361de361a"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"9701f109718c847e17610c7a43246336bef9168d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hemanth Makkapati \u003chemanth.makkapati@rackspace.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-27 17:09:58 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"db.simple.api: do not use it if #workers !\u003d 1"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When using more than one worker, only one of them will return data, thus"},{"line_number":10,"context_line":"leading users to not have access to every single piece of data at once."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ba2be162_c7c17c82","line":7,"range":{"start_line":7,"start_character":44,"end_line":7,"end_character":45},"updated":"2017-03-01 04:56:12.000000000","message":"0 or 1","commit_id":"a877f96a0236f6c645b17bcf7a00678fa0aa7eed"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"fdf8379799508e21ac98af5be024e126c153f483","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hemanth Makkapati \u003chemanth.makkapati@rackspace.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-27 17:09:58 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"db.simple.api: do not use it if #workers !\u003d 1"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When using more than one worker, only one of them will return data, thus"},{"line_number":10,"context_line":"leading users to not have access to every single piece of data at once."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ba2be162_8ca5ce05","line":7,"range":{"start_line":7,"start_character":44,"end_line":7,"end_character":45},"in_reply_to":"ba2be162_c7c17c82","updated":"2017-03-01 16:42:22.000000000","message":"sure","commit_id":"a877f96a0236f6c645b17bcf7a00678fa0aa7eed"}],"doc/source/configuring.rst":[{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"9701f109718c847e17610c7a43246336bef9168d","unresolved":false,"context_lines":[{"line_number":187,"context_line":"Number of Glance API or Registry worker processes to start. Each worker"},{"line_number":188,"context_line":"process will listen on the same port. Increasing this value may increase"},{"line_number":189,"context_line":"performance (especially if using SSL with compression enabled). Typically"},{"line_number":190,"context_line":"it is recommended to have one worker process per CPU. The value `0`"},{"line_number":191,"context_line":"will prevent any new processes from being created. If the parameter"},{"line_number":192,"context_line":"``data_api`` has been set to ``glance.db.simple.api``, only one worker"},{"line_number":193,"context_line":"shall be used."},{"line_number":194,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba2be162_c73edcb7","line":191,"range":{"start_line":190,"start_character":54,"end_line":191,"end_character":50},"updated":"2017-03-01 04:56:12.000000000","message":"Not sure this is correct.\nhttps://github.com/openstack/glance/blob/master/glance/common/wsgi.py#L520-L523\n\n\u00270\u0027 workers mean single process. So does \u00271\u0027 when given for workers.\nAnd a \u0027None\u0027 value means number of processes \u003d number of CPUs.","commit_id":"a877f96a0236f6c645b17bcf7a00678fa0aa7eed"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"fdf8379799508e21ac98af5be024e126c153f483","unresolved":false,"context_lines":[{"line_number":187,"context_line":"Number of Glance API or Registry worker processes to start. Each worker"},{"line_number":188,"context_line":"process will listen on the same port. Increasing this value may increase"},{"line_number":189,"context_line":"performance (especially if using SSL with compression enabled). Typically"},{"line_number":190,"context_line":"it is recommended to have one worker process per CPU. The value `0`"},{"line_number":191,"context_line":"will prevent any new processes from being created. If the parameter"},{"line_number":192,"context_line":"``data_api`` has been set to ``glance.db.simple.api``, only one worker"},{"line_number":193,"context_line":"shall be used."},{"line_number":194,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba2be162_27479bbc","line":191,"range":{"start_line":190,"start_character":54,"end_line":191,"end_character":50},"in_reply_to":"ba2be162_c73edcb7","updated":"2017-03-01 16:42:22.000000000","message":"We are talking about worker processes here. If the valus is 0, no worker processes are created. One worker process is created when it is set to 1. Maybe I can mention \u0027worker\u0027 processes explicitly.","commit_id":"a877f96a0236f6c645b17bcf7a00678fa0aa7eed"}],"glance/db/simple/api.py":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"8189c0f40280fec6671d6e01f64ce84dc6ad55c1","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"def configure():"},{"line_number":75,"context_line":"    if CONF.workers !\u003d 1:"},{"line_number":76,"context_line":"        LOG.warn(_LW(\u0027CONF.workers should be set to 1 \u0027"},{"line_number":77,"context_line":"                     \u0027when using the db.simple.api backend\u0027))"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_dcde806c","line":75,"range":{"start_line":75,"start_character":20,"end_line":75,"end_character":24},"updated":"2016-09-06 13:48:03.000000000","message":"How about \u003e 1?\nBecause \"workers\" can take zero as a value too and if I\u0027m not wrong that\u0027s what is used in functional tests where we use simple db.","commit_id":"f8cf06dde0a82378a2474eb9552696a3512bb21e"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"1f58e6d13ac5bc542c26948d2b6408db2f23e5eb","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"def configure():"},{"line_number":75,"context_line":"    if CONF.workers !\u003d 1:"},{"line_number":76,"context_line":"        LOG.warn(_LW(\u0027CONF.workers should be set to 1 \u0027"},{"line_number":77,"context_line":"                     \u0027when using the db.simple.api backend\u0027))"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_47ed2b24","line":75,"range":{"start_line":75,"start_character":20,"end_line":75,"end_character":24},"in_reply_to":"9a89bdaa_dcde806c","updated":"2016-09-06 19:08:40.000000000","message":"great catch","commit_id":"f8cf06dde0a82378a2474eb9552696a3512bb21e"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"2db0abdc98482cfb83de776cbe930dafe458cb2b","unresolved":false,"context_lines":[{"line_number":74,"context_line":"def configure():"},{"line_number":75,"context_line":"    if CONF.workers !\u003d 1:"},{"line_number":76,"context_line":"        LOG.warn(_LW(\u0027CONF.workers should be set to 1 \u0027"},{"line_number":77,"context_line":"                     \u0027when using the db.simple.api backend\u0027))"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"def reset():"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_e0c49b60","line":77,"updated":"2016-09-06 01:36:55.000000000","message":"I think we should also explain why here.","commit_id":"f8cf06dde0a82378a2474eb9552696a3512bb21e"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"57e177bf81df8047a481d6e3d973641f1e292ea3","unresolved":false,"context_lines":[{"line_number":74,"context_line":"def configure():"},{"line_number":75,"context_line":"    if CONF.workers !\u003d 1:"},{"line_number":76,"context_line":"        LOG.warn(_LW(\u0027CONF.workers should be set to 1 \u0027"},{"line_number":77,"context_line":"                     \u0027when using the db.simple.api backend\u0027))"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"def reset():"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_d2375bae","line":77,"in_reply_to":"9a89bdaa_035edc75","updated":"2016-09-06 09:43:51.000000000","message":"I mean we can tell uses that if the worker is more than 1, it may lead data missed. Any way, it\u0027s not the block to this patch.:)","commit_id":"f8cf06dde0a82378a2474eb9552696a3512bb21e"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"1f58e6d13ac5bc542c26948d2b6408db2f23e5eb","unresolved":false,"context_lines":[{"line_number":74,"context_line":"def configure():"},{"line_number":75,"context_line":"    if CONF.workers !\u003d 1:"},{"line_number":76,"context_line":"        LOG.warn(_LW(\u0027CONF.workers should be set to 1 \u0027"},{"line_number":77,"context_line":"                     \u0027when using the db.simple.api backend\u0027))"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"def reset():"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_075243dd","line":77,"in_reply_to":"9a89bdaa_d2375bae","updated":"2016-09-06 19:08:40.000000000","message":"I\u0027m actually in favor of adding details for the questions/people who ask \u0027why\u0027?\n\nBut we don\u0027t have to document that here. Having a glance doc page and a link to that page in this warning will suffice.\n\nAlso, this warning is not emitted to the users, it\u0027s emitted to the operators and maintainers -- who are sometimes interested in making architectural decisions and need to know \u0027why\u0027.\n\nAnyway, like I mentioned in the bug report we need documentation on this. Since this patch /commit says Partial bug I am okay with the message as is or having a line which says \"for more info see bug \u003cbug number\u003e\"","commit_id":"f8cf06dde0a82378a2474eb9552696a3512bb21e"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"c5394ce900ff793b023a0fd3f2986e4698384289","unresolved":false,"context_lines":[{"line_number":74,"context_line":"def configure():"},{"line_number":75,"context_line":"    if CONF.workers !\u003d 1:"},{"line_number":76,"context_line":"        LOG.warn(_LW(\u0027CONF.workers should be set to 1 \u0027"},{"line_number":77,"context_line":"                     \u0027when using the db.simple.api backend\u0027))"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"def reset():"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_035edc75","line":77,"in_reply_to":"9a89bdaa_e0c49b60","updated":"2016-09-06 09:22:41.000000000","message":"Do we really want to give implementation details to the user? Isn\u0027t it enough to say \"well, this only works with a single worker, after all it is called \u0027simple\u0027\"?","commit_id":"f8cf06dde0a82378a2474eb9552696a3512bb21e"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"7a728040de680aa977f502058500dcc4f1722e40","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"def configure():"},{"line_number":75,"context_line":"    if CONF.workers \u003e 1:"},{"line_number":76,"context_line":"        LOG.warn(_LW(\u0027CONF.workers should be set to 1 \u0027"},{"line_number":77,"context_line":"                     \u0027when using the db.simple.api backend. \u0027"},{"line_number":78,"context_line":"                     \u0027Fore more info, see \u0027"},{"line_number":79,"context_line":"                     \u0027https://bugs.launchpad.net/glance/+bug/1619508\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_d37be879","line":76,"range":{"start_line":76,"start_character":52,"end_line":76,"end_character":53},"updated":"2016-09-20 16:19:48.000000000","message":"How about 0 or 1?","commit_id":"25262f24ebf90e06dfc5cdd8e7d0f5d361de361a"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"796428f384d440640dbbcc4fa361b8ca9a8dd084","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"def configure():"},{"line_number":75,"context_line":"    if CONF.workers \u003e 1:"},{"line_number":76,"context_line":"        LOG.warn(_LW(\u0027CONF.workers should be set to 1 \u0027"},{"line_number":77,"context_line":"                     \u0027when using the db.simple.api backend. \u0027"},{"line_number":78,"context_line":"                     \u0027Fore more info, see \u0027"},{"line_number":79,"context_line":"                     \u0027https://bugs.launchpad.net/glance/+bug/1619508\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_6d13c8b8","line":76,"in_reply_to":"7a8ec9b2_d37be879","updated":"2016-09-21 16:30:17.000000000","message":"Done","commit_id":"25262f24ebf90e06dfc5cdd8e7d0f5d361de361a"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"71f32e8c13ce23f09acd120ac6d3458fc184fb3b","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"def configure():"},{"line_number":75,"context_line":"    if CONF.workers is None or CONF.workers \u003e 1:"},{"line_number":76,"context_line":"        LOG.warn(_LW(\u0027CONF.workers should be set to 0 or 1 \u0027"},{"line_number":77,"context_line":"                     \u0027when using the db.simple.api backend. \u0027"},{"line_number":78,"context_line":"                     \u0027Fore more info, see \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a8bc5a2_aa544a54","line":75,"range":{"start_line":75,"start_character":20,"end_line":75,"end_character":27},"updated":"2016-09-22 16:41:26.000000000","message":"Hmmm, this is probably the result of not setting a default during the opt definition.","commit_id":"33a52c932f3340f12bdc01b4e8b0cad7a4f9d895"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"3dc653753f9c35dc816cd06d3799b7fbda97480a","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"def configure():"},{"line_number":75,"context_line":"    if CONF.workers is None or CONF.workers \u003e 1:"},{"line_number":76,"context_line":"        LOG.warn(_LW(\u0027CONF.workers should be set to 0 or 1 \u0027"},{"line_number":77,"context_line":"                     \u0027when using the db.simple.api backend. \u0027"},{"line_number":78,"context_line":"                     \u0027Fore more info, see \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a8bc5a2_2336a5b4","line":75,"range":{"start_line":75,"start_character":20,"end_line":75,"end_character":27},"in_reply_to":"5a8bc5a2_aa544a54","updated":"2016-09-28 11:50:32.000000000","message":"Nope, by design None takes the count of available cores and uses that.","commit_id":"33a52c932f3340f12bdc01b4e8b0cad7a4f9d895"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"e3bd1ab8fb9832f863b0dff328dfadf7e0df0043","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                      \u0027when using the db.simple.api backend. \u0027"},{"line_number":79,"context_line":"                      \u0027Fore more info, see \u0027"},{"line_number":80,"context_line":"                      \u0027https://bugs.launchpad.net/glance/+bug/1619508\u0027))"},{"line_number":81,"context_line":"        sys.exit(1)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"def reset():"}],"source_content_type":"text/x-python","patch_set":6,"id":"da4df55a_9a2c4cad","line":81,"updated":"2016-12-21 23:40:57.000000000","message":"Not sure LOG.error with sys.exit is the right solution. Perhaps raise a SystemExit and/or possibly LOG.critical instead since this is treated as a fatal configuration error.","commit_id":"f68b263cd3650dd2063cb94a8ed9a99a523ab185"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"8aed591dd3d555e649604832dd5e8c8efe8c4108","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                      \u0027when using the db.simple.api backend. \u0027"},{"line_number":79,"context_line":"                      \u0027Fore more info, see \u0027"},{"line_number":80,"context_line":"                      \u0027https://bugs.launchpad.net/glance/+bug/1619508\u0027))"},{"line_number":81,"context_line":"        sys.exit(1)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"def reset():"}],"source_content_type":"text/x-python","patch_set":6,"id":"da4df55a_74adf030","line":81,"in_reply_to":"da4df55a_9a2c4cad","updated":"2016-12-22 08:57:37.000000000","message":"++ for LOG.critical","commit_id":"f68b263cd3650dd2063cb94a8ed9a99a523ab185"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"a3e2cc410ae83deb652f387712765a6dc17f0e98","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                      \u0027when using the db.simple.api backend. \u0027"},{"line_number":79,"context_line":"                      \u0027Fore more info, see \u0027"},{"line_number":80,"context_line":"                      \u0027https://bugs.launchpad.net/glance/+bug/1619508\u0027))"},{"line_number":81,"context_line":"        sys.exit(1)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"def reset():"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_f2adeb9b","line":81,"in_reply_to":"da4df55a_9a2c4cad","updated":"2017-01-11 23:08:03.000000000","message":"Agreeing with Steve, I think we can just have:\nmsg \u003d _(\u0027CONF.workers should be set to 0 or 1 \u0027\n               \u0027when using the db.simple.api backend. \u0027\n               \u0027Fore more info, see \u0027\n               \u0027https://bugs.launchpad.net/glance/+bug/1619508\u0027)\nraise SystemExit(msg)","commit_id":"f68b263cd3650dd2063cb94a8ed9a99a523ab185"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"558e71d3cbe79782dd3d31fc7ea9f78311a46170","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"def configure():"},{"line_number":75,"context_line":"    if CONF.workers is None or CONF.workers \u003e 1:"},{"line_number":76,"context_line":"        msg \u003d _(\u0027CONF.workers should be set to 0 or 1 when using the \u0027"},{"line_number":77,"context_line":"                \u0027db.simple.api backend. Fore more info, see \u0027"},{"line_number":78,"context_line":"                \u0027https://bugs.launchpad.net/glance/+bug/1619508\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da36d5c6_916b4e85","line":75,"range":{"start_line":75,"start_character":4,"end_line":75,"end_character":48},"updated":"2017-02-27 22:25:14.000000000","message":"How about\n    if CONF.workers not in [0, 1]:","commit_id":"a877f96a0236f6c645b17bcf7a00678fa0aa7eed"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"d27eeac78711f5bcbd09b02fb045e20f237d23f5","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"def configure():"},{"line_number":75,"context_line":"    if CONF.workers is None or CONF.workers \u003e 1:"},{"line_number":76,"context_line":"        msg \u003d _(\u0027CONF.workers should be set to 0 or 1 when using the \u0027"},{"line_number":77,"context_line":"                \u0027db.simple.api backend. Fore more info, see \u0027"},{"line_number":78,"context_line":"                \u0027https://bugs.launchpad.net/glance/+bug/1619508\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba2be162_e2481130","line":75,"range":{"start_line":75,"start_character":4,"end_line":75,"end_character":48},"in_reply_to":"ba2be162_22b7893a","updated":"2017-03-01 16:44:41.000000000","message":"Well, on a second thought I like your suggestion better. I\u0027m going to include it in the next PS.","commit_id":"a877f96a0236f6c645b17bcf7a00678fa0aa7eed"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"489d71e00a52e409c88e28b989e03170f5660785","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"def configure():"},{"line_number":75,"context_line":"    if CONF.workers is None or CONF.workers \u003e 1:"},{"line_number":76,"context_line":"        msg \u003d _(\u0027CONF.workers should be set to 0 or 1 when using the \u0027"},{"line_number":77,"context_line":"                \u0027db.simple.api backend. Fore more info, see \u0027"},{"line_number":78,"context_line":"                \u0027https://bugs.launchpad.net/glance/+bug/1619508\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba2be162_8b4046a7","line":75,"range":{"start_line":75,"start_character":4,"end_line":75,"end_character":48},"in_reply_to":"ba2be162_e2481130","updated":"2017-03-01 22:58:06.000000000","message":"Cool, we need not check for \u0027None\u0027 here cos \u0027None\u0027 gets defaulted to either the number of CPUs or \u00271\u0027 in wsgi layer.","commit_id":"a877f96a0236f6c645b17bcf7a00678fa0aa7eed"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"fdf8379799508e21ac98af5be024e126c153f483","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"def configure():"},{"line_number":75,"context_line":"    if CONF.workers is None or CONF.workers \u003e 1:"},{"line_number":76,"context_line":"        msg \u003d _(\u0027CONF.workers should be set to 0 or 1 when using the \u0027"},{"line_number":77,"context_line":"                \u0027db.simple.api backend. Fore more info, see \u0027"},{"line_number":78,"context_line":"                \u0027https://bugs.launchpad.net/glance/+bug/1619508\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba2be162_22b7893a","line":75,"range":{"start_line":75,"start_character":4,"end_line":75,"end_character":48},"in_reply_to":"da36d5c6_2ca32551","updated":"2017-03-01 16:42:22.000000000","message":"I don\u0027t know why one would be better than the other. They are both correct. In case of \u0027not in\u0027 we are creating an extra list but it is more readable. Let\u0027s see what others think.","commit_id":"a877f96a0236f6c645b17bcf7a00678fa0aa7eed"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"d92c2ec07df2a0118f4979d90ee3e9ff09f3cb4b","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"def configure():"},{"line_number":75,"context_line":"    if CONF.workers is None or CONF.workers \u003e 1:"},{"line_number":76,"context_line":"        msg \u003d _(\u0027CONF.workers should be set to 0 or 1 when using the \u0027"},{"line_number":77,"context_line":"                \u0027db.simple.api backend. Fore more info, see \u0027"},{"line_number":78,"context_line":"                \u0027https://bugs.launchpad.net/glance/+bug/1619508\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba2be162_b74c8f71","line":75,"range":{"start_line":75,"start_character":4,"end_line":75,"end_character":48},"in_reply_to":"da36d5c6_2ca32551","updated":"2017-03-01 20:00:23.000000000","message":"awesome, thank you","commit_id":"a877f96a0236f6c645b17bcf7a00678fa0aa7eed"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"c016ef6a179660118ea3003c9b59d76c6b08f6c3","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"def configure():"},{"line_number":75,"context_line":"    if CONF.workers is None or CONF.workers \u003e 1:"},{"line_number":76,"context_line":"        msg \u003d _(\u0027CONF.workers should be set to 0 or 1 when using the \u0027"},{"line_number":77,"context_line":"                \u0027db.simple.api backend. Fore more info, see \u0027"},{"line_number":78,"context_line":"                \u0027https://bugs.launchpad.net/glance/+bug/1619508\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da36d5c6_ac9b9571","line":75,"range":{"start_line":75,"start_character":4,"end_line":75,"end_character":48},"in_reply_to":"da36d5c6_916b4e85","updated":"2017-02-27 23:03:37.000000000","message":"what if someone tries to set it to -ve value?","commit_id":"a877f96a0236f6c645b17bcf7a00678fa0aa7eed"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"ff1a78729b55bb1cc64fac30a9b497b64b87484a","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"def configure():"},{"line_number":75,"context_line":"    if CONF.workers is None or CONF.workers \u003e 1:"},{"line_number":76,"context_line":"        msg \u003d _(\u0027CONF.workers should be set to 0 or 1 when using the \u0027"},{"line_number":77,"context_line":"                \u0027db.simple.api backend. Fore more info, see \u0027"},{"line_number":78,"context_line":"                \u0027https://bugs.launchpad.net/glance/+bug/1619508\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da36d5c6_2ca32551","line":75,"range":{"start_line":75,"start_character":4,"end_line":75,"end_character":48},"in_reply_to":"da36d5c6_ac9b9571","updated":"2017-02-27 23:19:03.000000000","message":"worker does not take negative integer values.\nhttps://github.com/openstack/glance/blob/master/glance/common/wsgi.py#L213","commit_id":"a877f96a0236f6c645b17bcf7a00678fa0aa7eed"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"558e71d3cbe79782dd3d31fc7ea9f78311a46170","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"def configure():"},{"line_number":75,"context_line":"    if CONF.workers is None or CONF.workers \u003e 1:"},{"line_number":76,"context_line":"        msg \u003d _(\u0027CONF.workers should be set to 0 or 1 when using the \u0027"},{"line_number":77,"context_line":"                \u0027db.simple.api backend. Fore more info, see \u0027"},{"line_number":78,"context_line":"                \u0027https://bugs.launchpad.net/glance/+bug/1619508\u0027)"},{"line_number":79,"context_line":"        LOG.critical(msg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da36d5c6_f161eaa9","line":76,"range":{"start_line":76,"start_character":53,"end_line":76,"end_character":54},"updated":"2017-02-27 22:25:14.000000000","message":"Nit for clarity: s//signifying a single API process to use ?","commit_id":"a877f96a0236f6c645b17bcf7a00678fa0aa7eed"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"d92c2ec07df2a0118f4979d90ee3e9ff09f3cb4b","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"def configure():"},{"line_number":75,"context_line":"    if CONF.workers is None or CONF.workers \u003e 1:"},{"line_number":76,"context_line":"        msg \u003d _(\u0027CONF.workers should be set to 0 or 1 when using the \u0027"},{"line_number":77,"context_line":"                \u0027db.simple.api backend. Fore more info, see \u0027"},{"line_number":78,"context_line":"                \u0027https://bugs.launchpad.net/glance/+bug/1619508\u0027)"},{"line_number":79,"context_line":"        LOG.critical(msg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba2be162_1778fb8e","line":76,"range":{"start_line":76,"start_character":53,"end_line":76,"end_character":54},"in_reply_to":"da36d5c6_4c53f96c","updated":"2017-03-01 20:00:23.000000000","message":":thumbsup:","commit_id":"a877f96a0236f6c645b17bcf7a00678fa0aa7eed"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"ff1a78729b55bb1cc64fac30a9b497b64b87484a","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"def configure():"},{"line_number":75,"context_line":"    if CONF.workers is None or CONF.workers \u003e 1:"},{"line_number":76,"context_line":"        msg \u003d _(\u0027CONF.workers should be set to 0 or 1 when using the \u0027"},{"line_number":77,"context_line":"                \u0027db.simple.api backend. Fore more info, see \u0027"},{"line_number":78,"context_line":"                \u0027https://bugs.launchpad.net/glance/+bug/1619508\u0027)"},{"line_number":79,"context_line":"        LOG.critical(msg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da36d5c6_4c53f96c","line":76,"range":{"start_line":76,"start_character":53,"end_line":76,"end_character":54},"in_reply_to":"da36d5c6_ccb449d6","updated":"2017-02-27 23:19:03.000000000","message":"Yeah Nikhil.\nhttps://github.com/openstack/glance/blob/master/glance/common/wsgi.py#L520-L523","commit_id":"a877f96a0236f6c645b17bcf7a00678fa0aa7eed"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"c016ef6a179660118ea3003c9b59d76c6b08f6c3","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"def configure():"},{"line_number":75,"context_line":"    if CONF.workers is None or CONF.workers \u003e 1:"},{"line_number":76,"context_line":"        msg \u003d _(\u0027CONF.workers should be set to 0 or 1 when using the \u0027"},{"line_number":77,"context_line":"                \u0027db.simple.api backend. Fore more info, see \u0027"},{"line_number":78,"context_line":"                \u0027https://bugs.launchpad.net/glance/+bug/1619508\u0027)"},{"line_number":79,"context_line":"        LOG.critical(msg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da36d5c6_ccb449d6","line":76,"range":{"start_line":76,"start_character":53,"end_line":76,"end_character":54},"in_reply_to":"da36d5c6_f161eaa9","updated":"2017-02-27 23:03:37.000000000","message":"does 0 indicate a single API process","commit_id":"a877f96a0236f6c645b17bcf7a00678fa0aa7eed"}]}