)]}'
{"bin/glance-control":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"61416878f21504ba2df5e687555d3fc384b43794","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        fp.close()"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def await_child(pid):"},{"line_number":115,"context_line":"        if (conf.await_child):"},{"line_number":116,"context_line":"            bail_time \u003d time.time() + conf.await_child"},{"line_number":117,"context_line":"            while time.time() \u003c bail_time:"},{"line_number":118,"context_line":"                reported_pid, status \u003d os.waitpid(pid, os.WNOHANG)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAEn%2F%2F%2F0E%3D","line":115,"updated":"2012-02-02 17:15:10.000000000","message":"The parentheses above are unnecessary...","commit_id":"787674cbd6e84081c2e49949e5cfd8a59dc08bfa"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"c95a52da4a6d27af5880fe8d4a78ae770efcbdf8","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        fp.close()"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def await_child(pid):"},{"line_number":115,"context_line":"        if (conf.await_child):"},{"line_number":116,"context_line":"            bail_time \u003d time.time() + conf.await_child"},{"line_number":117,"context_line":"            while time.time() \u003c bail_time:"},{"line_number":118,"context_line":"                reported_pid, status \u003d os.waitpid(pid, os.WNOHANG)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAEn%2F%2F%2FzM%3D","line":115,"in_reply_to":"AAAAEn%2F%2F%2F0E%3D","updated":"2012-02-02 17:40:13.000000000","message":"Done","commit_id":"787674cbd6e84081c2e49949e5cfd8a59dc08bfa"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"61416878f21504ba2df5e687555d3fc384b43794","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                reported_pid, status \u003d os.waitpid(pid, os.WNOHANG)"},{"line_number":119,"context_line":"                if reported_pid \u003d\u003d pid:"},{"line_number":120,"context_line":"                    global exitcode"},{"line_number":121,"context_line":"                    exitcode \u003d status \u003e\u003e 8"},{"line_number":122,"context_line":"                    break"},{"line_number":123,"context_line":"                time.sleep(0.05)"},{"line_number":124,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAEn%2F%2F%2Fz8%3D","line":121,"updated":"2012-02-02 17:15:10.000000000","message":"Perhaps a quick comment informing the reader why the \u003e\u003e 8 is done above?","commit_id":"787674cbd6e84081c2e49949e5cfd8a59dc08bfa"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"c95a52da4a6d27af5880fe8d4a78ae770efcbdf8","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                reported_pid, status \u003d os.waitpid(pid, os.WNOHANG)"},{"line_number":119,"context_line":"                if reported_pid \u003d\u003d pid:"},{"line_number":120,"context_line":"                    global exitcode"},{"line_number":121,"context_line":"                    exitcode \u003d status \u003e\u003e 8"},{"line_number":122,"context_line":"                    break"},{"line_number":123,"context_line":"                time.sleep(0.05)"},{"line_number":124,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAEn%2F%2F%2FzI%3D","line":121,"in_reply_to":"AAAAEn%2F%2F%2Fz8%3D","updated":"2012-02-02 17:40:13.000000000","message":"Done","commit_id":"787674cbd6e84081c2e49949e5cfd8a59dc08bfa"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"696eac9b3f251218513b74c6671dc589dcfb9412","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":196,"context_line":"    global exitcode"},{"line_number":197,"context_line":"    exitcode \u003d 0"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    conf \u003d config.GlanceConfigOpts(usage\u003dUSAGE)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAEn%2F%2F%2F0Y%3D","line":196,"updated":"2012-02-02 17:05:54.000000000","message":"Do we need this line here?  I don\u0027t think \u0027if\u0027 opens a new scope, but I could be wrong.","commit_id":"787674cbd6e84081c2e49949e5cfd8a59dc08bfa"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"c95a52da4a6d27af5880fe8d4a78ae770efcbdf8","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":196,"context_line":"    global exitcode"},{"line_number":197,"context_line":"    exitcode \u003d 0"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    conf \u003d config.GlanceConfigOpts(usage\u003dUSAGE)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAEn%2F%2F%2FzA%3D","line":196,"in_reply_to":"AAAAEn%2F%2F%2F0Y%3D","updated":"2012-02-02 17:40:13.000000000","message":"Good catch, it\u0027s not needed. \n\nNow gone.","commit_id":"787674cbd6e84081c2e49949e5cfd8a59dc08bfa"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"61416878f21504ba2df5e687555d3fc384b43794","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                                     metavar\u003d\u0027DELAY\u0027,"},{"line_number":206,"context_line":"                                     default\u003d0,"},{"line_number":207,"context_line":"                                     help\u003d\u0027Period to wait for service death \u0027"},{"line_number":208,"context_line":"                                          \u0027in order to report exit code\u0027))"},{"line_number":209,"context_line":"    args \u003d conf()"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    if len(args) \u003c 2:"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAEn%2F%2F%2Fzw%3D","line":208,"updated":"2012-02-02 17:15:10.000000000","message":"What does the default of 0 mean? Might want to note that in the help comment...","commit_id":"787674cbd6e84081c2e49949e5cfd8a59dc08bfa"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"c95a52da4a6d27af5880fe8d4a78ae770efcbdf8","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                                     metavar\u003d\u0027DELAY\u0027,"},{"line_number":206,"context_line":"                                     default\u003d0,"},{"line_number":207,"context_line":"                                     help\u003d\u0027Period to wait for service death \u0027"},{"line_number":208,"context_line":"                                          \u0027in order to report exit code\u0027))"},{"line_number":209,"context_line":"    args \u003d conf()"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    if len(args) \u003c 2:"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAEn%2F%2F%2Fyg%3D","line":208,"in_reply_to":"AAAAEn%2F%2F%2Fzw%3D","updated":"2012-02-02 17:40:13.000000000","message":"Good point, the default of zero means don\u0027t wait at all (i.e. the status quo ante).\n\nHelp updated.","commit_id":"787674cbd6e84081c2e49949e5cfd8a59dc08bfa"}],"glance/tests/functional/__init__.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"61416878f21504ba2df5e687555d3fc384b43794","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        self.server_control \u003d \u0027./bin/glance-control\u0027"},{"line_number":88,"context_line":"        self.exec_env \u003d None"},{"line_number":89,"context_line":"        self.deployment_flavor \u003d \u0027\u0027"},{"line_number":90,"context_line":"        self.options \u003d \u0027\u0027"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def write_conf(self, **kwargs):"},{"line_number":93,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2F%2Fzo%3D","line":90,"updated":"2012-02-02 17:15:10.000000000","message":"Please make this server_control_options to make it explicit that this refers to options passed to glance-control et al and not the main config options...","commit_id":"787674cbd6e84081c2e49949e5cfd8a59dc08bfa"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"c95a52da4a6d27af5880fe8d4a78ae770efcbdf8","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        self.server_control \u003d \u0027./bin/glance-control\u0027"},{"line_number":88,"context_line":"        self.exec_env \u003d None"},{"line_number":89,"context_line":"        self.deployment_flavor \u003d \u0027\u0027"},{"line_number":90,"context_line":"        self.options \u003d \u0027\u0027"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def write_conf(self, **kwargs):"},{"line_number":93,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2F%2FzQ%3D","line":90,"in_reply_to":"AAAAEn%2F%2F%2Fzo%3D","updated":"2012-02-02 17:40:13.000000000","message":"Done","commit_id":"787674cbd6e84081c2e49949e5cfd8a59dc08bfa"}]}