)]}'
{"id":"openstack%2Fglance~368","triplet_id":"openstack%2Fglance~master~I83345f87c7e5f1e35ef6646cb360819d489ec256","project":"openstack/glance","branch":"master","hashtags":[],"change_id":"I83345f87c7e5f1e35ef6646cb360819d489ec256","subject":"Fix cached-images API endpoint","status":"MERGED","created":"2011-08-31 03:46:08.000000000","updated":"2011-08-31 15:30:47.000000000","submitted":"2011-08-31 15:30:47.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2eb2883f6afe9bda1ad77d475a7746733bfac529","_number":368,"virtual_id_number":368,"owner":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},{"value":0,"_account_id":1032,"name":"Justin Shepherd","email":"jshepher@rackspace.com","username":"jshepher"},{"value":0,"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":1,"date":"2011-08-31 15:30:47.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"recommended":{"_account_id":1032,"name":"Justin Shepherd","email":"jshepher@rackspace.com","username":"jshepher"},"all":[{"value":0,"date":"2011-08-31 13:00:29.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},{"value":1,"date":"2011-08-31 04:13:17.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1032,"name":"Justin Shepherd","email":"jshepher@rackspace.com","username":"jshepher"},{"value":2,"date":"2011-08-31 15:29:19.000000000","_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"date":"2011-08-31 15:29:23.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},{"value":0,"_account_id":1032,"name":"Justin Shepherd","email":"jshepher@rackspace.com","username":"jshepher"},{"value":0,"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},{"value":0,"_account_id":1032,"name":"Justin Shepherd","email":"jshepher@rackspace.com","username":"jshepher"},{"value":0,"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"_account_id":1032,"name":"Justin Shepherd","email":"jshepher@rackspace.com","username":"jshepher"},{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2011-08-31 04:13:17.000000000","updated_by":{"_account_id":1032,"name":"Justin Shepherd","email":"jshepher@rackspace.com","username":"jshepher"},"reviewer":{"_account_id":1032,"name":"Justin Shepherd","email":"jshepher@rackspace.com","username":"jshepher"},"state":"REVIEWER"},{"updated":"2011-08-31 15:29:19.000000000","updated_by":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"reviewer":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"state":"REVIEWER"},{"updated":"2011-08-31 15:30:47.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"7c35d38e153680d0031b10098031469764927794","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2011-08-31 03:47:37.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"82d6ea0bf522a824d8e3fba777acdd79efda846a","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2011-08-31 03:49:02.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"c417e249b937062eb305452dd166c471a8277f56","author":{"_account_id":1032,"name":"Justin Shepherd","email":"jshepher@rackspace.com","username":"jshepher"},"date":"2011-08-31 04:13:17.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\nSorry.. did not catch that earlier..","accounts_in_message":[],"_revision_number":3},{"id":"41c3689391ee65e51f4d8848cfef723a2df7a1d7","author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"date":"2011-08-31 11:50:43.000000000","message":"Patch Set 3:\n\nI don\u0027t understand why the name of the variable is mandated by routes.","accounts_in_message":[],"_revision_number":3},{"id":"d474054126df822b05233b42907b9669f829964b","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2011-08-31 13:00:29.000000000","message":"Patch Set 3:\n\nThe mapper.resource call uses the keyword \u0027id\u0027 by default. So for a url like /images/12, routes will parse that into a dictionary like {\u0027id\u0027: 12}. We then pass that into our controller method like so: delete(self, id\u003did). Even though \u0027id\u0027 isn\u0027t defined as a keyword argument, we still pass it in as if it were. Changing \u0027id\u0027 to \u0027image_id\u0027 breaks this because we are still going to get \u0027id\u0027 back from routes.","accounts_in_message":[],"_revision_number":3},{"id":"b93b4b57956acc57e5c800fc0bc95456134007fc","author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"date":"2011-08-31 15:20:25.000000000","message":"Patch Set 3:\n\nHow on Earth did all the functional and unit tests pass, then, if that is the case? :(","accounts_in_message":[],"_revision_number":3},{"id":"8b15adc55bd38a0cd69b2ff381367895212dba70","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2011-08-31 15:22:52.000000000","message":"Patch Set 3:\n\nThere are no functional tests for the cache, and the unit tests are quite lacking.","accounts_in_message":[],"_revision_number":3},{"id":"632caaf928d2dfdbdca6f21eb1ff0a93f8eceff3","author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"date":"2011-08-31 15:29:19.000000000","message":"Patch Set 3: Looks good to me, approved\n\nOK, I understand now... Shep, looks like this is more involved than we thought...","accounts_in_message":[],"_revision_number":3},{"id":"c73f2391af4db2bfc5625e846323c92bcf5c426a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-08-31 15:29:23.000000000","message":"Patch Set 3:\n\nBuild Started https://jenkins.openstack.org/job/glance-merge/42/ (1/3)","accounts_in_message":[],"_revision_number":3},{"id":"4c1f821236dcec06abe1c1d557a2e9a2bde7f730","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-08-31 15:29:23.000000000","message":"Patch Set 3:\n\nBuild Started https://jenkins.openstack.org/job/glance/89208/ (2/3)","accounts_in_message":[],"_revision_number":3},{"id":"811420e2ab4bddd9ce84e1e1d1d65c89d9423aa3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-08-31 15:29:28.000000000","message":"Patch Set 3:\n\nBuild Started https://jenkins.openstack.org/job/glance-pep8/213/ (3/3)","accounts_in_message":[],"_revision_number":3},{"id":"6957f645eb7c7577d45923991db3ee74bca098f4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-08-31 15:30:47.000000000","message":"Patch Set 3: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/glance/89208/ : SUCCESS \nhttps://jenkins.openstack.org/job/glance-merge/42/ : SUCCESS \nhttps://jenkins.openstack.org/job/glance-pep8/213/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"2eb2883f6afe9bda1ad77d475a7746733bfac529","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-08-31 15:30:47.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"09ea2718a219b13ea9cd67bf80d8fe83b499e153","revisions":{"914ff7f77ab3c8770571dc084bb4d8a8e158ac3a":{"kind":"REWORK","_number":1,"created":"2011-08-31 03:46:08.000000000","uploader":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"ref":"refs/changes/68/368/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/68/368/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/68/368/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/68/368/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/68/368/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/68/368/1"}}},"commit":{"parents":[{"commit":"3cd46135c9926684858b08f4583844b7dbab1ba7","subject":"Bug fix lp:726864","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/3cd46135c9926684858b08f4583844b7dbab1ba7"}]}],"author":{"name":"Brian Waldon","email":"brian.waldon@rackspace.com","date":"2011-08-31 03:43:33.000000000","tz":-240},"committer":{"name":"Brian Waldon","email":"brian.waldon@rackspace.com","date":"2011-08-31 03:43:33.000000000","tz":-240},"subject":"correcting recent changes","message":"correcting recent changes\n\nChange-Id: I83345f87c7e5f1e35ef6646cb360819d489ec256\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/914ff7f77ab3c8770571dc084bb4d8a8e158ac3a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/914ff7f77ab3c8770571dc084bb4d8a8e158ac3a"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"3cd46135c9926684858b08f4583844b7dbab1ba7","is_merged_in_target_branch":true,"change_id":"I79605275bf2607331f5b74076cb5689f071c92d5","change_number":367,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"},"20ec57e0988b975009dd2df64406c4f4a30d6e9b":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2011-08-31 03:47:37.000000000","uploader":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"ref":"refs/changes/68/368/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/68/368/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/68/368/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/68/368/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/68/368/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/68/368/2"}}},"commit":{"parents":[{"commit":"3cd46135c9926684858b08f4583844b7dbab1ba7","subject":"Bug fix lp:726864","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/3cd46135c9926684858b08f4583844b7dbab1ba7"}]}],"author":{"name":"Brian Waldon","email":"brian.waldon@rackspace.com","date":"2011-08-31 03:43:33.000000000","tz":-240},"committer":{"name":"Brian Waldon","email":"brian.waldon@rackspace.com","date":"2011-08-31 03:47:08.000000000","tz":-240},"subject":"Fix cached-images API endpoint","message":"Fix cached-images API endpoint\n\nChange-Id: I83345f87c7e5f1e35ef6646cb360819d489ec256\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/20ec57e0988b975009dd2df64406c4f4a30d6e9b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/20ec57e0988b975009dd2df64406c4f4a30d6e9b"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"3cd46135c9926684858b08f4583844b7dbab1ba7","is_merged_in_target_branch":true,"change_id":"I79605275bf2607331f5b74076cb5689f071c92d5","change_number":367,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"},"09ea2718a219b13ea9cd67bf80d8fe83b499e153":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2011-08-31 03:49:02.000000000","uploader":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"ref":"refs/changes/68/368/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/68/368/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/68/368/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/68/368/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/68/368/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/68/368/3"}}},"commit":{"parents":[{"commit":"3cd46135c9926684858b08f4583844b7dbab1ba7","subject":"Bug fix lp:726864","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/3cd46135c9926684858b08f4583844b7dbab1ba7"}]}],"author":{"name":"Brian Waldon","email":"brian.waldon@rackspace.com","date":"2011-08-31 03:43:33.000000000","tz":-240},"committer":{"name":"Brian Waldon","email":"brian.waldon@rackspace.com","date":"2011-08-31 03:47:52.000000000","tz":-240},"subject":"Fix cached-images API endpoint","message":"Fix cached-images API endpoint\n\nThe recent chages that renamed \u0027id\u0027 to \u0027image_id\u0027 in the cached_images controller broke the API. This reverts a couple\nof those changes.\n\nChange-Id: I83345f87c7e5f1e35ef6646cb360819d489ec256\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/09ea2718a219b13ea9cd67bf80d8fe83b499e153"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/09ea2718a219b13ea9cd67bf80d8fe83b499e153"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"3cd46135c9926684858b08f4583844b7dbab1ba7","is_merged_in_target_branch":true,"change_id":"I79605275bf2607331f5b74076cb5689f071c92d5","change_number":367,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}