)]}'
{"doc/source/policies.rst":[{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"ecf8a4839814f4b469f18f9dc9ecbeed093d722f","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  * ``PUT /v1/images/\u003cIMAGE_ID\u003e``"},{"line_number":72,"context_line":"  * ``PUT /v2/images/\u003cIMAGE_ID\u003e``"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"* ``publicize_image`` - Create or update images with attribute"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  * ``POST /v1/images`` with attribute ``is_public`` \u003d ``true``"},{"line_number":77,"context_line":"  * ``PUT /v1/images/\u003cIMAGE_ID\u003e`` with attribute ``is_public`` \u003d ``true``"}],"source_content_type":"text/x-rst","patch_set":49,"id":"ba5da102_2a1ca876","line":74,"range":{"start_line":74,"start_character":41,"end_line":74,"end_character":62},"updated":"2016-10-28 19:00:55.000000000","message":"Suggested clarification nit:\ns/images with attribute/public images/","commit_id":"b436ac6623ac1599239ff5f263bd963017510768"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"864777c2147c692b0c83b7271356fffd6505dccf","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  * ``PUT /v1/images/\u003cIMAGE_ID\u003e``"},{"line_number":72,"context_line":"  * ``PUT /v2/images/\u003cIMAGE_ID\u003e``"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"* ``publicize_image`` - Create or update images with attribute"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  * ``POST /v1/images`` with attribute ``is_public`` \u003d ``true``"},{"line_number":77,"context_line":"  * ``PUT /v1/images/\u003cIMAGE_ID\u003e`` with attribute ``is_public`` \u003d ``true``"}],"source_content_type":"text/x-rst","patch_set":49,"id":"9a629dbe_29822f01","line":74,"range":{"start_line":74,"start_character":41,"end_line":74,"end_character":62},"in_reply_to":"ba5da102_2a1ca876","updated":"2016-11-07 16:45:10.000000000","message":"Done","commit_id":"b436ac6623ac1599239ff5f263bd963017510768"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"ecf8a4839814f4b469f18f9dc9ecbeed093d722f","unresolved":false,"context_lines":[{"line_number":78,"context_line":"  * ``POST /v2/images`` with attribute ``visibility`` \u003d ``public``"},{"line_number":79,"context_line":"  * ``PUT /v2/images/\u003cIMAGE_ID\u003e`` with attribute ``visibility`` \u003d ``public``"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"* ``communitize_image`` - Create or update images with attribute"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  * ``POST /v2/images`` with attribute ``visibility`` \u003d ``community``"},{"line_number":84,"context_line":"  * ``PUT /v2/images/\u003cIMAGE_ID\u003e`` with attribute ``visibility`` \u003d ``community``"}],"source_content_type":"text/x-rst","patch_set":49,"id":"ba5da102_4a139c66","line":81,"range":{"start_line":81,"start_character":43,"end_line":81,"end_character":64},"updated":"2016-10-28 19:00:55.000000000","message":"Suggested clarification nit:\ns/images with attribute/community images/","commit_id":"b436ac6623ac1599239ff5f263bd963017510768"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"864777c2147c692b0c83b7271356fffd6505dccf","unresolved":false,"context_lines":[{"line_number":78,"context_line":"  * ``POST /v2/images`` with attribute ``visibility`` \u003d ``public``"},{"line_number":79,"context_line":"  * ``PUT /v2/images/\u003cIMAGE_ID\u003e`` with attribute ``visibility`` \u003d ``public``"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"* ``communitize_image`` - Create or update images with attribute"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  * ``POST /v2/images`` with attribute ``visibility`` \u003d ``community``"},{"line_number":84,"context_line":"  * ``PUT /v2/images/\u003cIMAGE_ID\u003e`` with attribute ``visibility`` \u003d ``community``"}],"source_content_type":"text/x-rst","patch_set":49,"id":"9a629dbe_4987630f","line":81,"range":{"start_line":81,"start_character":43,"end_line":81,"end_character":64},"in_reply_to":"ba5da102_4a139c66","updated":"2016-11-07 16:45:10.000000000","message":"Done","commit_id":"b436ac6623ac1599239ff5f263bd963017510768"}],"glance/api/authorization.py":[{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"bbc7d083f8dd73195802605e98ec84be2a1764e7","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            member_proxy_kwargs\u003dproxy_kwargs)"},{"line_number":127,"context_line":"        self._check_image_visibility()"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def _check_image_visibility(self):"},{"line_number":130,"context_line":"        if self.image.visibility !\u003d \u0027shared\u0027:"},{"line_number":131,"context_line":"            message \u003d _(\"Only shared images have members.\")"},{"line_number":132,"context_line":"            raise exception.Forbidden(message)"}],"source_content_type":"text/x-python","patch_set":48,"id":"da6895a0_f0b0bd45","line":129,"updated":"2016-10-25 23:57:56.000000000","message":"This method could use a rename while you are in here. The name has little to do with the functionality anymore.\nOne suggestion: _validate_image_accepts_members","commit_id":"f455a23f8c82dafa27fafce867e5e0b4f2878ed7"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"d383c9892f16b7052bd137d7baf39ef41a8071d8","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            member_proxy_kwargs\u003dproxy_kwargs)"},{"line_number":127,"context_line":"        self._check_image_visibility()"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def _check_image_visibility(self):"},{"line_number":130,"context_line":"        if self.image.visibility !\u003d \u0027shared\u0027:"},{"line_number":131,"context_line":"            message \u003d _(\"Only shared images have members.\")"},{"line_number":132,"context_line":"            raise exception.Forbidden(message)"}],"source_content_type":"text/x-python","patch_set":48,"id":"ba5da102_86693628","line":129,"in_reply_to":"da6895a0_f0b0bd45","updated":"2016-10-28 14:02:52.000000000","message":"Done","commit_id":"f455a23f8c82dafa27fafce867e5e0b4f2878ed7"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"bbc7d083f8dd73195802605e98ec84be2a1764e7","unresolved":false,"context_lines":[{"line_number":220,"context_line":"                            \"for the image.\")"},{"line_number":221,"context_line":"                raise exception.Forbidden(message)"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        if image.visibility !\u003d \u0027shared\u0027:"},{"line_number":224,"context_line":"            message \u003d _(\"Only shared images have members.\")"},{"line_number":225,"context_line":"            raise exception.Forbidden(message)"},{"line_number":226,"context_line":""}],"source_content_type":"text/x-python","patch_set":48,"id":"da6895a0_f097dd8d","line":223,"updated":"2016-10-25 23:57:56.000000000","message":"This block is identical to the implementation of _check_image_visibility which I recommended for a rename above. This logic should be replaced with an invocation of that method, regardless of the name.","commit_id":"f455a23f8c82dafa27fafce867e5e0b4f2878ed7"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"d383c9892f16b7052bd137d7baf39ef41a8071d8","unresolved":false,"context_lines":[{"line_number":220,"context_line":"                            \"for the image.\")"},{"line_number":221,"context_line":"                raise exception.Forbidden(message)"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        if image.visibility !\u003d \u0027shared\u0027:"},{"line_number":224,"context_line":"            message \u003d _(\"Only shared images have members.\")"},{"line_number":225,"context_line":"            raise exception.Forbidden(message)"},{"line_number":226,"context_line":""}],"source_content_type":"text/x-python","patch_set":48,"id":"ba5da102_a678faf3","line":223,"in_reply_to":"da6895a0_f097dd8d","updated":"2016-10-28 14:02:52.000000000","message":"Done","commit_id":"f455a23f8c82dafa27fafce867e5e0b4f2878ed7"}],"glance/api/policy.py":[{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"bbc7d083f8dd73195802605e98ec84be2a1764e7","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    @visibility.setter"},{"line_number":139,"context_line":"    def visibility(self, value):"},{"line_number":140,"context_line":"        if value \u003d\u003d \u0027public\u0027:"},{"line_number":141,"context_line":"            self.policy.enforce(self.context, \u0027publicize_image\u0027, self.target)"},{"line_number":142,"context_line":"        elif value \u003d\u003d \u0027community\u0027:"},{"line_number":143,"context_line":"            self.policy.enforce(self.context, \u0027communitize_image\u0027, self.target)"}],"source_content_type":"text/x-python","patch_set":48,"id":"da6895a0_abac14a1","line":140,"updated":"2016-10-25 23:57:56.000000000","message":"I would like to see the common parts of this method and ImageFactoryProxy\u0027s new_image method extracted to a helper function, perhaps: \n\n  _enforce_image_visibility(context, visibility, target)\n\nor something to that effect.","commit_id":"f455a23f8c82dafa27fafce867e5e0b4f2878ed7"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"d383c9892f16b7052bd137d7baf39ef41a8071d8","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    @visibility.setter"},{"line_number":139,"context_line":"    def visibility(self, value):"},{"line_number":140,"context_line":"        if value \u003d\u003d \u0027public\u0027:"},{"line_number":141,"context_line":"            self.policy.enforce(self.context, \u0027publicize_image\u0027, self.target)"},{"line_number":142,"context_line":"        elif value \u003d\u003d \u0027community\u0027:"},{"line_number":143,"context_line":"            self.policy.enforce(self.context, \u0027communitize_image\u0027, self.target)"}],"source_content_type":"text/x-python","patch_set":48,"id":"ba5da102_06644647","line":140,"in_reply_to":"da6895a0_abac14a1","updated":"2016-10-28 14:02:52.000000000","message":"Done","commit_id":"f455a23f8c82dafa27fafce867e5e0b4f2878ed7"}],"glance/db/registry/api.py":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"ac4fb6e82f4ee9b1e5391977eb1691f41c5a8f0b","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        return True"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    # Public visibility \u003d\u003d image visible"},{"line_number":97,"context_line":"    if \u0027public\u0027 \u003d\u003d image[\u0027visibility\u0027]:"},{"line_number":98,"context_line":"        return True"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    # Perform tests based on whether we have an owner"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_d4f3c008","line":97,"updated":"2016-09-20 23:55:30.000000000","message":"just making a note here, as I\u0027m not sure if we need to return true by default for visibility.","commit_id":"1ba6f48a06bebb6b827da98a5b214d9043d23ad4"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"c5511b0edf804dd5b3e0f97ef00d797cf09c6b28","unresolved":false,"context_lines":[{"line_number":121,"context_line":"@_get_client"},{"line_number":122,"context_line":"def image_get_all(client, filters\u003dNone, marker\u003dNone, limit\u003dNone,"},{"line_number":123,"context_line":"                  sort_key\u003dNone, sort_dir\u003dNone,"},{"line_number":124,"context_line":"                  member_status\u003d\u0027accepted\u0027, is_public\u003dNone,"},{"line_number":125,"context_line":"                  admin_as_user\u003dFalse, return_tag\u003dFalse, v1_mode\u003dFalse):"},{"line_number":126,"context_line":"    \"\"\""},{"line_number":127,"context_line":"    Get all images that match zero or more filters."}],"source_content_type":"text/x-python","patch_set":31,"id":"fa6399be_040d303e","line":124,"range":{"start_line":124,"start_character":44,"end_line":124,"end_character":58},"updated":"2016-10-11 17:48:37.000000000","message":"Q: does it make sense to replace this with a visibility parameter?","commit_id":"bc58fa62bfd6c33de6d57a38b58f1bbba818bf51"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"eb31988c33effa8ecece8bd8e37e224c21b9b3b8","unresolved":false,"context_lines":[{"line_number":121,"context_line":"@_get_client"},{"line_number":122,"context_line":"def image_get_all(client, filters\u003dNone, marker\u003dNone, limit\u003dNone,"},{"line_number":123,"context_line":"                  sort_key\u003dNone, sort_dir\u003dNone,"},{"line_number":124,"context_line":"                  member_status\u003d\u0027accepted\u0027, is_public\u003dNone,"},{"line_number":125,"context_line":"                  admin_as_user\u003dFalse, return_tag\u003dFalse, v1_mode\u003dFalse):"},{"line_number":126,"context_line":"    \"\"\""},{"line_number":127,"context_line":"    Get all images that match zero or more filters."}],"source_content_type":"text/x-python","patch_set":31,"id":"fa6399be_67ab4e75","line":124,"range":{"start_line":124,"start_character":44,"end_line":124,"end_character":58},"in_reply_to":"fa6399be_040d303e","updated":"2016-10-11 17:59:39.000000000","message":"visibility is currently passed in the filters section, so that\u0027s already being passed. and in the interest of full backwards compatibility, we should not remove is_public (this one or others) until v1 can be completely removed.","commit_id":"bc58fa62bfd6c33de6d57a38b58f1bbba818bf51"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"e5b8fbed8e1e4aa61ffa5accdf931739726fb712","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    if image[\u0027owner\u0027] is None:"},{"line_number":98,"context_line":"        return True"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    # Public visibility \u003d\u003d image visible"},{"line_number":101,"context_line":"    if \u0027public\u0027 \u003d\u003d image[\u0027visibility\u0027]:"},{"line_number":102,"context_line":"        return True"},{"line_number":103,"context_line":"    # Community visibility \u003d\u003d image visible"},{"line_number":104,"context_line":"    if \u0027community\u0027 \u003d\u003d image[\u0027visibility\u0027]:"},{"line_number":105,"context_line":"        return True"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    # Perform tests based on whether we have an owner"}],"source_content_type":"text/x-python","patch_set":37,"id":"fa6399be_dae09acf","line":104,"range":{"start_line":100,"start_character":0,"end_line":104,"end_character":42},"updated":"2016-10-17 17:55:27.000000000","message":"nit:\nif image[\u0027visibility\u0027] in [\u0027public\u0027, \u0027community\u0027]:\n    return true","commit_id":"11c678fdd246797f061d7bb4048c9dbc8825ed4d"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"09fa45f5acc1176c18af210b83bd257920ffa89d","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    if image[\u0027owner\u0027] is None:"},{"line_number":98,"context_line":"        return True"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    # Public visibility \u003d\u003d image visible"},{"line_number":101,"context_line":"    if \u0027public\u0027 \u003d\u003d image[\u0027visibility\u0027]:"},{"line_number":102,"context_line":"        return True"},{"line_number":103,"context_line":"    # Community visibility \u003d\u003d image visible"},{"line_number":104,"context_line":"    if \u0027community\u0027 \u003d\u003d image[\u0027visibility\u0027]:"},{"line_number":105,"context_line":"        return True"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    # Perform tests based on whether we have an owner"}],"source_content_type":"text/x-python","patch_set":37,"id":"fa6399be_e81031ae","line":104,"range":{"start_line":100,"start_character":0,"end_line":104,"end_character":42},"in_reply_to":"fa6399be_dae09acf","updated":"2016-10-17 19:35:24.000000000","message":"Done","commit_id":"11c678fdd246797f061d7bb4048c9dbc8825ed4d"}],"glance/db/simple/api.py":[{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"d6d5864cb3e08f144e9c6f2beb582e0d97b811b5","unresolved":false,"context_lines":[{"line_number":202,"context_line":"    image[\u0027properties\u0027].extend(properties)"},{"line_number":203,"context_line":"    if \u0027is_public\u0027 in values:"},{"line_number":204,"context_line":"        if \u0027visibility\u0027 in values:"},{"line_number":205,"context_line":"            msg \u003d \"Specifying both \u0027visibility\u0027 and \u0027is_public\u0027 is not \" \\"},{"line_number":206,"context_line":"                  \"permitted\""},{"line_number":207,"context_line":"            raise exception.Invalid(msg)"},{"line_number":208,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a95cdbc_46a0ff43","line":205,"updated":"2016-10-05 23:11:31.000000000","message":"Identical message to sqlalchemy/api.py:205 so this message should probably be somewhere in db/__init__.py or something, and there is can be marked for il8n once","commit_id":"3c90ccc4403f4ac68cd5f14508b4304a36be4d8f"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"72f8c70d34ad27b0e54e3f87cbc594b2c277aa5e","unresolved":false,"context_lines":[{"line_number":202,"context_line":"    image[\u0027properties\u0027].extend(properties)"},{"line_number":203,"context_line":"    if \u0027is_public\u0027 in values:"},{"line_number":204,"context_line":"        if \u0027visibility\u0027 in values:"},{"line_number":205,"context_line":"            msg \u003d \"Specifying both \u0027visibility\u0027 and \u0027is_public\u0027 is not \" \\"},{"line_number":206,"context_line":"                  \"permitted\""},{"line_number":207,"context_line":"            raise exception.Invalid(msg)"},{"line_number":208,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a95cdbc_616f77c5","line":205,"in_reply_to":"1a95cdbc_19b01143","updated":"2016-10-06 17:42:59.000000000","message":"Both the functionality and error message has been centralized to db/utils.py","commit_id":"3c90ccc4403f4ac68cd5f14508b4304a36be4d8f"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"aa913d844f312bb969f25fa568f0c007531f9d23","unresolved":false,"context_lines":[{"line_number":202,"context_line":"    image[\u0027properties\u0027].extend(properties)"},{"line_number":203,"context_line":"    if \u0027is_public\u0027 in values:"},{"line_number":204,"context_line":"        if \u0027visibility\u0027 in values:"},{"line_number":205,"context_line":"            msg \u003d \"Specifying both \u0027visibility\u0027 and \u0027is_public\u0027 is not \" \\"},{"line_number":206,"context_line":"                  \"permitted\""},{"line_number":207,"context_line":"            raise exception.Invalid(msg)"},{"line_number":208,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a95cdbc_19b01143","line":205,"in_reply_to":"1a95cdbc_46a0ff43","updated":"2016-10-06 00:48:55.000000000","message":"Investigating this.","commit_id":"3c90ccc4403f4ac68cd5f14508b4304a36be4d8f"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"d6d5864cb3e08f144e9c6f2beb582e0d97b811b5","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                  \"permitted\""},{"line_number":207,"context_line":"            raise exception.Invalid(msg)"},{"line_number":208,"context_line":"        else:"},{"line_number":209,"context_line":"            values[\u0027visibility\u0027] \u003d \u0027public\u0027 \\"},{"line_number":210,"context_line":"                                   if values.pop(\u0027is_public\u0027) else \u0027private\u0027"},{"line_number":211,"context_line":"    image.update(values)"},{"line_number":212,"context_line":"    return image"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a95cdbc_66a33b50","line":209,"updated":"2016-10-05 23:11:31.000000000","message":"OpenStack prefers () to \\","commit_id":"3c90ccc4403f4ac68cd5f14508b4304a36be4d8f"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"aa913d844f312bb969f25fa568f0c007531f9d23","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                  \"permitted\""},{"line_number":207,"context_line":"            raise exception.Invalid(msg)"},{"line_number":208,"context_line":"        else:"},{"line_number":209,"context_line":"            values[\u0027visibility\u0027] \u003d \u0027public\u0027 \\"},{"line_number":210,"context_line":"                                   if values.pop(\u0027is_public\u0027) else \u0027private\u0027"},{"line_number":211,"context_line":"    image.update(values)"},{"line_number":212,"context_line":"    return image"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a95cdbc_999b41c9","line":209,"in_reply_to":"1a95cdbc_66a33b50","updated":"2016-10-06 00:48:55.000000000","message":"Done","commit_id":"3c90ccc4403f4ac68cd5f14508b4304a36be4d8f"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"d6d5864cb3e08f144e9c6f2beb582e0d97b811b5","unresolved":false,"context_lines":[{"line_number":268,"context_line":"                                   member\u003dcontext.owner, status\u003dstatus)"},{"line_number":269,"context_line":"        is_member \u003d len(member) \u003e 0"},{"line_number":270,"context_line":"        has_ownership \u003d context.owner and image[\u0027owner\u0027] \u003d\u003d context.owner"},{"line_number":271,"context_line":"        can_see \u003d ((image[\u0027visibility\u0027] \u003d\u003d \u0027public\u0027) or has_ownership or"},{"line_number":272,"context_line":"                   is_member or (context.is_admin and not admin_as_user))"},{"line_number":273,"context_line":"        if not can_see:"},{"line_number":274,"context_line":"            continue"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a95cdbc_c1ab191c","line":271,"updated":"2016-10-05 23:11:31.000000000","message":"This line is straining comprehensibility as written. I\u0027d recommend extracting an evaluation, such as:\n\nis_public_image \u003d image[\u0027visibility\u0027] \u003d\u003d \u0027public\u0027\n\nPossibly also extracting:\n\nacts_as_admin \u003d context.is_admin and not admin_as_user\n\n...then repeat use of is_public_image throughout the function.","commit_id":"3c90ccc4403f4ac68cd5f14508b4304a36be4d8f"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"aa913d844f312bb969f25fa568f0c007531f9d23","unresolved":false,"context_lines":[{"line_number":268,"context_line":"                                   member\u003dcontext.owner, status\u003dstatus)"},{"line_number":269,"context_line":"        is_member \u003d len(member) \u003e 0"},{"line_number":270,"context_line":"        has_ownership \u003d context.owner and image[\u0027owner\u0027] \u003d\u003d context.owner"},{"line_number":271,"context_line":"        can_see \u003d ((image[\u0027visibility\u0027] \u003d\u003d \u0027public\u0027) or has_ownership or"},{"line_number":272,"context_line":"                   is_member or (context.is_admin and not admin_as_user))"},{"line_number":273,"context_line":"        if not can_see:"},{"line_number":274,"context_line":"            continue"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a95cdbc_596379dc","line":271,"in_reply_to":"1a95cdbc_c1ab191c","updated":"2016-10-06 00:48:55.000000000","message":"Done","commit_id":"3c90ccc4403f4ac68cd5f14508b4304a36be4d8f"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"d6d5864cb3e08f144e9c6f2beb582e0d97b811b5","unresolved":false,"context_lines":[{"line_number":435,"context_line":"    image \u003d _normalize_locations(context, image,"},{"line_number":436,"context_line":"                                 force_show_deleted\u003dforce_show_deleted)"},{"line_number":437,"context_line":"    if v1_mode:"},{"line_number":438,"context_line":"        db_utils.mutate_image_dict_to_v1(image)"},{"line_number":439,"context_line":"    return image"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"1a95cdbc_a5829850","line":438,"updated":"2016-10-05 23:11:31.000000000","message":"nit: the blended use of reassignment of image and the side-effect behavior of mutate_image_dict_to_v1 here seems odd. Might be better if mutate_image_dict_to_v1 returned it\u0027s parameter?\n\nThis is repeated throughout this file and in others but I\u0027ll only mention it once.","commit_id":"3c90ccc4403f4ac68cd5f14508b4304a36be4d8f"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"aa913d844f312bb969f25fa568f0c007531f9d23","unresolved":false,"context_lines":[{"line_number":435,"context_line":"    image \u003d _normalize_locations(context, image,"},{"line_number":436,"context_line":"                                 force_show_deleted\u003dforce_show_deleted)"},{"line_number":437,"context_line":"    if v1_mode:"},{"line_number":438,"context_line":"        db_utils.mutate_image_dict_to_v1(image)"},{"line_number":439,"context_line":"    return image"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"1a95cdbc_59ba9924","line":438,"in_reply_to":"1a95cdbc_a5829850","updated":"2016-10-06 00:48:55.000000000","message":"Done","commit_id":"3c90ccc4403f4ac68cd5f14508b4304a36be4d8f"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"e5b8fbed8e1e4aa61ffa5accdf931739726fb712","unresolved":false,"context_lines":[{"line_number":857,"context_line":"    if image[\u0027owner\u0027] is None:"},{"line_number":858,"context_line":"        return True"},{"line_number":859,"context_line":""},{"line_number":860,"context_line":"    # Public visibility \u003d\u003d image visible"},{"line_number":861,"context_line":"    if \u0027public\u0027 \u003d\u003d image[\u0027visibility\u0027]:"},{"line_number":862,"context_line":"        return True"},{"line_number":863,"context_line":"    # Community visibility \u003d\u003d image visible"},{"line_number":864,"context_line":"    if \u0027community\u0027 \u003d\u003d image[\u0027visibility\u0027]:"},{"line_number":865,"context_line":"        return True"},{"line_number":866,"context_line":""},{"line_number":867,"context_line":"    # Perform tests based on whether we have an owner"},{"line_number":868,"context_line":"    if context.owner is not None:"}],"source_content_type":"text/x-python","patch_set":37,"id":"fa6399be_fa9d5e0b","line":865,"range":{"start_line":860,"start_character":0,"end_line":865,"end_character":19},"updated":"2016-10-17 17:55:27.000000000","message":"nit:\nif image[\u0027visibility\u0027] in [\u0027public\u0027, \u0027community\u0027]:\n    return true","commit_id":"11c678fdd246797f061d7bb4048c9dbc8825ed4d"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"09fa45f5acc1176c18af210b83bd257920ffa89d","unresolved":false,"context_lines":[{"line_number":857,"context_line":"    if image[\u0027owner\u0027] is None:"},{"line_number":858,"context_line":"        return True"},{"line_number":859,"context_line":""},{"line_number":860,"context_line":"    # Public visibility \u003d\u003d image visible"},{"line_number":861,"context_line":"    if \u0027public\u0027 \u003d\u003d image[\u0027visibility\u0027]:"},{"line_number":862,"context_line":"        return True"},{"line_number":863,"context_line":"    # Community visibility \u003d\u003d image visible"},{"line_number":864,"context_line":"    if \u0027community\u0027 \u003d\u003d image[\u0027visibility\u0027]:"},{"line_number":865,"context_line":"        return True"},{"line_number":866,"context_line":""},{"line_number":867,"context_line":"    # Perform tests based on whether we have an owner"},{"line_number":868,"context_line":"    if context.owner is not None:"}],"source_content_type":"text/x-python","patch_set":37,"id":"fa6399be_68250109","line":865,"range":{"start_line":860,"start_character":0,"end_line":865,"end_character":19},"in_reply_to":"fa6399be_fa9d5e0b","updated":"2016-10-17 19:35:24.000000000","message":"Done","commit_id":"11c678fdd246797f061d7bb4048c9dbc8825ed4d"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"ecf8a4839814f4b469f18f9dc9ecbeed093d722f","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    if \u0027properties\u0027 not in image.keys():"},{"line_number":201,"context_line":"        image[\u0027properties\u0027] \u003d []"},{"line_number":202,"context_line":"    image[\u0027properties\u0027].extend(properties)"},{"line_number":203,"context_line":"    if \u0027is_public\u0027 in values:"},{"line_number":204,"context_line":"        values \u003d db_utils.ensure_image_dict_v2_compliant(values)"},{"line_number":205,"context_line":"    image.update(values)"},{"line_number":206,"context_line":"    return image"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":49,"id":"ba5da102_ddc0542d","line":204,"range":{"start_line":203,"start_character":0,"end_line":204,"end_character":64},"updated":"2016-10-28 19:00:55.000000000","message":"In sqlalchemy/api.py, there is an \"else\" clause to this equivalent \"if\" statement, on line 832. Do we want to add similar functionality here? Also, ensure_image_dict_v2_compliant already checks for is_public in values, so no need to do that here.","commit_id":"b436ac6623ac1599239ff5f263bd963017510768"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"864777c2147c692b0c83b7271356fffd6505dccf","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    if \u0027properties\u0027 not in image.keys():"},{"line_number":201,"context_line":"        image[\u0027properties\u0027] \u003d []"},{"line_number":202,"context_line":"    image[\u0027properties\u0027].extend(properties)"},{"line_number":203,"context_line":"    if \u0027is_public\u0027 in values:"},{"line_number":204,"context_line":"        values \u003d db_utils.ensure_image_dict_v2_compliant(values)"},{"line_number":205,"context_line":"    image.update(values)"},{"line_number":206,"context_line":"    return image"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":49,"id":"9a629dbe_c97e13ae","line":204,"range":{"start_line":203,"start_character":0,"end_line":204,"end_character":64},"in_reply_to":"ba5da102_ddc0542d","updated":"2016-11-07 16:45:10.000000000","message":"Re the redundant if, done.\n\nRegarding the same call in sqlalchemy - that else block is there to guess at a default value for visibility, the same way that it used to guess at a default value for is_public. Since simple did not have the same default-guessing behaviour, I did not include it here.","commit_id":"b436ac6623ac1599239ff5f263bd963017510768"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"ecf8a4839814f4b469f18f9dc9ecbeed093d722f","unresolved":false,"context_lines":[{"line_number":870,"context_line":"        if status \u003d\u003d \u0027all\u0027:"},{"line_number":871,"context_line":"            status \u003d None"},{"line_number":872,"context_line":""},{"line_number":873,"context_line":"        if \u0027shared\u0027 \u003d\u003d image[\u0027visibility\u0027]:"},{"line_number":874,"context_line":"            members \u003d image_member_find(context,"},{"line_number":875,"context_line":"                                        image_id\u003dimage[\u0027id\u0027],"},{"line_number":876,"context_line":"                                        member\u003dcontext.owner,"}],"source_content_type":"text/x-python","patch_set":49,"id":"ba5da102_bd21e0fd","line":873,"range":{"start_line":873,"start_character":0,"end_line":873,"end_character":43},"updated":"2016-10-28 19:00:55.000000000","message":"not sure, but is it possible to filter on visibility\u003d\u0027shared\u0027 here instead of explicitly checking?","commit_id":"b436ac6623ac1599239ff5f263bd963017510768"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"864777c2147c692b0c83b7271356fffd6505dccf","unresolved":false,"context_lines":[{"line_number":870,"context_line":"        if status \u003d\u003d \u0027all\u0027:"},{"line_number":871,"context_line":"            status \u003d None"},{"line_number":872,"context_line":""},{"line_number":873,"context_line":"        if \u0027shared\u0027 \u003d\u003d image[\u0027visibility\u0027]:"},{"line_number":874,"context_line":"            members \u003d image_member_find(context,"},{"line_number":875,"context_line":"                                        image_id\u003dimage[\u0027id\u0027],"},{"line_number":876,"context_line":"                                        member\u003dcontext.owner,"}],"source_content_type":"text/x-python","patch_set":49,"id":"9a629dbe_4c2bf130","line":873,"range":{"start_line":873,"start_character":0,"end_line":873,"end_character":43},"in_reply_to":"ba5da102_bd21e0fd","updated":"2016-11-07 16:45:10.000000000","message":"I had it implemented something like that at some point in the past, but rewrote it as I prefer this way\u0027s readability and simplicity.","commit_id":"b436ac6623ac1599239ff5f263bd963017510768"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"120cc3c993b39c498a173165e83b8b97aad8974f","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        \u0027locations\u0027: [],"},{"line_number":215,"context_line":"        \u0027status\u0027: \u0027queued\u0027,"},{"line_number":216,"context_line":"        \u0027protected\u0027: False,"},{"line_number":217,"context_line":"        \u0027visibility\u0027: \u0027shared\u0027,"},{"line_number":218,"context_line":"        \u0027container_format\u0027: None,"},{"line_number":219,"context_line":"        \u0027disk_format\u0027: None,"},{"line_number":220,"context_line":"        \u0027min_ram\u0027: 0,"}],"source_content_type":"text/x-python","patch_set":51,"id":"9a629dbe_340e32e5","line":217,"updated":"2016-11-11 15:25:07.000000000","message":"This is backwards incompatible change that breaks our API.","commit_id":"8f55ebafbf6dd1e2ec2a839824e3a73c73fbded2"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"6f483489748bbaba940507c5fe93967bf9d26af7","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        \u0027locations\u0027: [],"},{"line_number":215,"context_line":"        \u0027status\u0027: \u0027queued\u0027,"},{"line_number":216,"context_line":"        \u0027protected\u0027: False,"},{"line_number":217,"context_line":"        \u0027visibility\u0027: \u0027shared\u0027,"},{"line_number":218,"context_line":"        \u0027container_format\u0027: None,"},{"line_number":219,"context_line":"        \u0027disk_format\u0027: None,"},{"line_number":220,"context_line":"        \u0027min_ram\u0027: 0,"}],"source_content_type":"text/x-python","patch_set":51,"id":"9a629dbe_943379f5","line":217,"in_reply_to":"9a629dbe_340e32e5","updated":"2016-11-11 17:22:45.000000000","message":"\u0027shared\u0027 visibility is functionality identical to the old is_public\u003dfalse.","commit_id":"8f55ebafbf6dd1e2ec2a839824e3a73c73fbded2"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"5a942182c52a570aeec816a108b702da1e9ff823","unresolved":false,"context_lines":[{"line_number":440,"context_line":"    image \u003d _normalize_locations(context, image,"},{"line_number":441,"context_line":"                                 force_show_deleted\u003dforce_show_deleted)"},{"line_number":442,"context_line":"    if v1_mode:"},{"line_number":443,"context_line":"        image \u003d db_utils.mutate_image_dict_to_v1(image)"},{"line_number":444,"context_line":"    return image"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":""}],"source_content_type":"text/x-python","patch_set":52,"id":"7a77a97e_50cb9472","line":443,"updated":"2016-11-14 20:55:08.000000000","message":"I\u0027d love it if we would stop redefining \"image\" constantly throughout this function, but I don\u0027t want to block this patch on this.","commit_id":"0b3517fd57cdba4a0a7859fe52539da557e7e0e6"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"51c1809eada36b387b68eb90257b3dc025fe5f43","unresolved":false,"context_lines":[{"line_number":440,"context_line":"    image \u003d _normalize_locations(context, image,"},{"line_number":441,"context_line":"                                 force_show_deleted\u003dforce_show_deleted)"},{"line_number":442,"context_line":"    if v1_mode:"},{"line_number":443,"context_line":"        image \u003d db_utils.mutate_image_dict_to_v1(image)"},{"line_number":444,"context_line":"    return image"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":""}],"source_content_type":"text/x-python","patch_set":52,"id":"7a77a97e_0bec8dc6","line":443,"in_reply_to":"7a77a97e_50cb9472","updated":"2016-11-14 21:59:46.000000000","message":"As discussed on IRC, leaving this alone.","commit_id":"0b3517fd57cdba4a0a7859fe52539da557e7e0e6"}],"glance/db/sqlalchemy/api.py":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"b997699a67abab3d25ff158fe3c6381cbf03a0cb","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    _FACADE \u003d None"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"def _check_mutate_authorization(context, image_ref):"},{"line_number":134,"context_line":"    if not is_image_mutable(context, image_ref):"},{"line_number":135,"context_line":"        LOG.warn(_LW(\"Attempted to modify image user did not own.\"))"},{"line_number":136,"context_line":"        msg \u003d _(\"You do not own this image\")"}],"source_content_type":"text/x-python","patch_set":20,"id":"7a8ec9b2_144c4841","line":133,"updated":"2016-09-20 23:59:57.000000000","message":"this method is used for destroy and update\n\nso we will need to add a check for community along with public","commit_id":"f9c3fd757836ff25448fc06b0552cc77a3a9c1ab"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"7d10041d176331ac88d0f307a64b502dbac34b83","unresolved":false,"context_lines":[{"line_number":71,"context_line":"_LOCK \u003d threading.Lock()"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"def _force_v1_mode(image):"},{"line_number":75,"context_line":"    image[\u0027is_public\u0027] \u003d True if \u0027public\u0027 \u003d\u003d image.pop(\u0027visibility\u0027) else False"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"def _retry_on_deadlock(exc):"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a98d1f4_7b2bc994","line":75,"range":{"start_line":74,"start_character":0,"end_line":75,"end_character":79},"updated":"2016-09-29 17:22:17.000000000","message":"Can this method and the one in simple/api be factored out into a common one in db/__init__.py?","commit_id":"db2e6a87fd0b5d263867a3e1d3e0608defd4dc13"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"ecbd006665afdc0a31223edeb533cb555fd2ad34","unresolved":false,"context_lines":[{"line_number":71,"context_line":"_LOCK \u003d threading.Lock()"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"def _force_v1_mode(image):"},{"line_number":75,"context_line":"    image[\u0027is_public\u0027] \u003d True if \u0027public\u0027 \u003d\u003d image.pop(\u0027visibility\u0027) else False"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"def _retry_on_deadlock(exc):"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a98d1f4_c5de6c10","line":75,"range":{"start_line":74,"start_character":0,"end_line":75,"end_character":79},"in_reply_to":"3a98d1f4_1241b8a9","updated":"2016-09-30 22:37:34.000000000","message":"Perhaps a new /glance/db/common.py module?","commit_id":"db2e6a87fd0b5d263867a3e1d3e0608defd4dc13"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"29b035107485aa784bc94a3455e419d62fdbb23b","unresolved":false,"context_lines":[{"line_number":71,"context_line":"_LOCK \u003d threading.Lock()"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"def _force_v1_mode(image):"},{"line_number":75,"context_line":"    image[\u0027is_public\u0027] \u003d True if \u0027public\u0027 \u003d\u003d image.pop(\u0027visibility\u0027) else False"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"def _retry_on_deadlock(exc):"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a98d1f4_1241b8a9","line":75,"range":{"start_line":74,"start_character":0,"end_line":75,"end_character":79},"in_reply_to":"3a98d1f4_7b2bc994","updated":"2016-09-29 22:34:46.000000000","message":"I love this idea but don\u0027t know that I\u0027d agree that db/__init__.py is an appropriate place for it.\n\nIf there IS an appropriate place for that, I\u0027d further argue that the 3 different copy/paste copies of is_image_visible (simple/api.py, sqlalchemy/api.py, registry/api.py) should also be banished to there.","commit_id":"db2e6a87fd0b5d263867a3e1d3e0608defd4dc13"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"8e202f7d760b185a8c45b0b49b32c3ea15202472","unresolved":false,"context_lines":[{"line_number":71,"context_line":"_LOCK \u003d threading.Lock()"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"def _force_v1_mode(image):"},{"line_number":75,"context_line":"    image[\u0027is_public\u0027] \u003d True if \u0027public\u0027 \u003d\u003d image.pop(\u0027visibility\u0027) else False"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"def _retry_on_deadlock(exc):"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a98d1f4_a8801f8c","line":75,"range":{"start_line":74,"start_character":0,"end_line":75,"end_character":79},"in_reply_to":"3a98d1f4_c5de6c10","updated":"2016-10-03 17:40:19.000000000","message":"Done","commit_id":"db2e6a87fd0b5d263867a3e1d3e0608defd4dc13"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"d6d5864cb3e08f144e9c6f2beb582e0d97b811b5","unresolved":false,"context_lines":[{"line_number":467,"context_line":"    tag_conditions \u003d []"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"    if is_public is not None:"},{"line_number":470,"context_line":"        image_conditions.append(models.Image.visibility"},{"line_number":471,"context_line":"                                \u003d\u003d (\u0027public\u0027 if is_public else \u0027private\u0027))"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"    if \u0027checksum\u0027 in filters:"},{"line_number":474,"context_line":"        checksum \u003d filters.pop(\u0027checksum\u0027)"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a95cdbc_2b4017a5","line":471,"range":{"start_line":470,"start_character":32,"end_line":471,"end_character":73},"updated":"2016-10-05 23:11:31.000000000","message":"extracting a local variable here would improve readability","commit_id":"3c90ccc4403f4ac68cd5f14508b4304a36be4d8f"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"aa913d844f312bb969f25fa568f0c007531f9d23","unresolved":false,"context_lines":[{"line_number":467,"context_line":"    tag_conditions \u003d []"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"    if is_public is not None:"},{"line_number":470,"context_line":"        image_conditions.append(models.Image.visibility"},{"line_number":471,"context_line":"                                \u003d\u003d (\u0027public\u0027 if is_public else \u0027private\u0027))"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"    if \u0027checksum\u0027 in filters:"},{"line_number":474,"context_line":"        checksum \u003d filters.pop(\u0027checksum\u0027)"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a95cdbc_f97fe563","line":471,"range":{"start_line":470,"start_character":32,"end_line":471,"end_character":73},"in_reply_to":"1a95cdbc_2b4017a5","updated":"2016-10-06 00:48:55.000000000","message":"Done","commit_id":"3c90ccc4403f4ac68cd5f14508b4304a36be4d8f"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"d6d5864cb3e08f144e9c6f2beb582e0d97b811b5","unresolved":false,"context_lines":[{"line_number":814,"context_line":"                values[\u0027min_disk\u0027] \u003d int(values[\u0027min_disk\u0027] or 0)"},{"line_number":815,"context_line":""},{"line_number":816,"context_line":"            if (\u0027visibility\u0027 in values) and (\u0027is_public\u0027 in values):"},{"line_number":817,"context_line":"                msg \u003d \"Specifying both \u0027visibility\u0027 and \" \\"},{"line_number":818,"context_line":"                    \"\u0027is_public\u0027 is not permitted\""},{"line_number":819,"context_line":"                raise exception.Invalid(msg)"},{"line_number":820,"context_line":"            if \u0027is_public\u0027 in values:"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a95cdbc_8be12b9d","line":817,"updated":"2016-10-05 23:11:31.000000000","message":"Identical message to simple/api.py:205 so this message should probably be somewhere in db/__init__.py or something, and there is can be marked for il8n once","commit_id":"3c90ccc4403f4ac68cd5f14508b4304a36be4d8f"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"72f8c70d34ad27b0e54e3f87cbc594b2c277aa5e","unresolved":false,"context_lines":[{"line_number":814,"context_line":"                values[\u0027min_disk\u0027] \u003d int(values[\u0027min_disk\u0027] or 0)"},{"line_number":815,"context_line":""},{"line_number":816,"context_line":"            if (\u0027visibility\u0027 in values) and (\u0027is_public\u0027 in values):"},{"line_number":817,"context_line":"                msg \u003d \"Specifying both \u0027visibility\u0027 and \" \\"},{"line_number":818,"context_line":"                    \"\u0027is_public\u0027 is not permitted\""},{"line_number":819,"context_line":"                raise exception.Invalid(msg)"},{"line_number":820,"context_line":"            if \u0027is_public\u0027 in values:"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a95cdbc_015f930e","line":817,"in_reply_to":"1a95cdbc_5991b998","updated":"2016-10-06 17:42:59.000000000","message":"Both the functionality and error message has been centralized to db/utils.py","commit_id":"3c90ccc4403f4ac68cd5f14508b4304a36be4d8f"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"aa913d844f312bb969f25fa568f0c007531f9d23","unresolved":false,"context_lines":[{"line_number":814,"context_line":"                values[\u0027min_disk\u0027] \u003d int(values[\u0027min_disk\u0027] or 0)"},{"line_number":815,"context_line":""},{"line_number":816,"context_line":"            if (\u0027visibility\u0027 in values) and (\u0027is_public\u0027 in values):"},{"line_number":817,"context_line":"                msg \u003d \"Specifying both \u0027visibility\u0027 and \" \\"},{"line_number":818,"context_line":"                    \"\u0027is_public\u0027 is not permitted\""},{"line_number":819,"context_line":"                raise exception.Invalid(msg)"},{"line_number":820,"context_line":"            if \u0027is_public\u0027 in values:"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a95cdbc_5991b998","line":817,"in_reply_to":"1a95cdbc_8be12b9d","updated":"2016-10-06 00:48:55.000000000","message":"Investigating this.","commit_id":"3c90ccc4403f4ac68cd5f14508b4304a36be4d8f"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"d6d5864cb3e08f144e9c6f2beb582e0d97b811b5","unresolved":false,"context_lines":[{"line_number":818,"context_line":"                    \"\u0027is_public\u0027 is not permitted\""},{"line_number":819,"context_line":"                raise exception.Invalid(msg)"},{"line_number":820,"context_line":"            if \u0027is_public\u0027 in values:"},{"line_number":821,"context_line":"                values[\u0027visibility\u0027] \\"},{"line_number":822,"context_line":"                    \u003d \u0027public\u0027 if values.pop(\u0027is_public\u0027) else \u0027private\u0027"},{"line_number":823,"context_line":"            else:"},{"line_number":824,"context_line":"                values[\u0027visibility\u0027] \u003d values.get(\u0027visibility\u0027, \u0027private\u0027)"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a95cdbc_4bfe4339","line":821,"updated":"2016-10-05 23:11:31.000000000","message":"OpenStack prefers () to \\","commit_id":"3c90ccc4403f4ac68cd5f14508b4304a36be4d8f"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"aa913d844f312bb969f25fa568f0c007531f9d23","unresolved":false,"context_lines":[{"line_number":818,"context_line":"                    \"\u0027is_public\u0027 is not permitted\""},{"line_number":819,"context_line":"                raise exception.Invalid(msg)"},{"line_number":820,"context_line":"            if \u0027is_public\u0027 in values:"},{"line_number":821,"context_line":"                values[\u0027visibility\u0027] \\"},{"line_number":822,"context_line":"                    \u003d \u0027public\u0027 if values.pop(\u0027is_public\u0027) else \u0027private\u0027"},{"line_number":823,"context_line":"            else:"},{"line_number":824,"context_line":"                values[\u0027visibility\u0027] \u003d values.get(\u0027visibility\u0027, \u0027private\u0027)"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a95cdbc_99e9811d","line":821,"in_reply_to":"1a95cdbc_4bfe4339","updated":"2016-10-06 00:48:55.000000000","message":"Done","commit_id":"3c90ccc4403f4ac68cd5f14508b4304a36be4d8f"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"e5b8fbed8e1e4aa61ffa5accdf931739726fb712","unresolved":false,"context_lines":[{"line_number":301,"context_line":"    if image[\u0027owner\u0027] is None:"},{"line_number":302,"context_line":"        return True"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    # Public visibility \u003d\u003d image visible"},{"line_number":305,"context_line":"    if \u0027public\u0027 \u003d\u003d image[\u0027visibility\u0027]:"},{"line_number":306,"context_line":"        return True"},{"line_number":307,"context_line":"    # Community visibility \u003d\u003d image visible"},{"line_number":308,"context_line":"    if \u0027community\u0027 \u003d\u003d image[\u0027visibility\u0027]:"},{"line_number":309,"context_line":"        return True"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"    # Perform tests based on whether we have an owner"},{"line_number":312,"context_line":"    if context.owner is not None:"}],"source_content_type":"text/x-python","patch_set":37,"id":"fa6399be_5567fbe9","line":309,"range":{"start_line":304,"start_character":0,"end_line":309,"end_character":19},"updated":"2016-10-17 17:55:27.000000000","message":"nit:\nif image[\u0027visibility\u0027] in [\u0027public\u0027, \u0027community\u0027]:\n    return true","commit_id":"11c678fdd246797f061d7bb4048c9dbc8825ed4d"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"09fa45f5acc1176c18af210b83bd257920ffa89d","unresolved":false,"context_lines":[{"line_number":301,"context_line":"    if image[\u0027owner\u0027] is None:"},{"line_number":302,"context_line":"        return True"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    # Public visibility \u003d\u003d image visible"},{"line_number":305,"context_line":"    if \u0027public\u0027 \u003d\u003d image[\u0027visibility\u0027]:"},{"line_number":306,"context_line":"        return True"},{"line_number":307,"context_line":"    # Community visibility \u003d\u003d image visible"},{"line_number":308,"context_line":"    if \u0027community\u0027 \u003d\u003d image[\u0027visibility\u0027]:"},{"line_number":309,"context_line":"        return True"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"    # Perform tests based on whether we have an owner"},{"line_number":312,"context_line":"    if context.owner is not None:"}],"source_content_type":"text/x-python","patch_set":37,"id":"fa6399be_88225500","line":309,"range":{"start_line":304,"start_character":0,"end_line":309,"end_character":19},"in_reply_to":"fa6399be_5567fbe9","updated":"2016-10-17 19:35:24.000000000","message":"Done","commit_id":"11c678fdd246797f061d7bb4048c9dbc8825ed4d"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"c14f56f477b5ed39a9cb4c395acd7e839f56e639","unresolved":false,"context_lines":[{"line_number":582,"context_line":"    # query the image members table. No union is required."},{"line_number":583,"context_line":"    if visibility is not None and visibility \u003d\u003d \u0027shared\u0027:"},{"line_number":584,"context_line":"        return query_member"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"    query_image \u003d session.query(models.Image).filter(img_conditional_clause)"},{"line_number":587,"context_line":"    if regular_user:"},{"line_number":588,"context_line":"        query_image \u003d query_image.filter(models.Image.is_public \u003d\u003d True)"}],"source_content_type":"text/x-python","patch_set":41,"id":"fa6399be_bbb0e18c","side":"PARENT","line":585,"updated":"2016-10-19 20:19:44.000000000","message":"With \u0027shared\u0027 being an explicit value now, it is no longer correct to just exit the function early.\n\nThank you to abashmak for helping uncover this (now fixed) bug.","commit_id":"f200554666fbf19f98786ad597b902a267dbcd39"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"ecf8a4839814f4b469f18f9dc9ecbeed093d722f","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        if image_ref.visibility \u003d\u003d \u0027private\u0027:"},{"line_number":138,"context_line":"            exc_class \u003d exception.Forbidden"},{"line_number":139,"context_line":"        else:"},{"line_number":140,"context_line":"            # \u0027public\u0027, \u0027community\u0027, or \u0027shared\u0027"},{"line_number":141,"context_line":"            exc_class \u003d exception.ForbiddenPublicImage"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        raise exc_class(msg)"}],"source_content_type":"text/x-python","patch_set":49,"id":"ba5da102_1dcbac1f","line":140,"range":{"start_line":140,"start_character":0,"end_line":140,"end_character":48},"updated":"2016-10-28 19:00:55.000000000","message":"I feel like \u0027shared\u0027 belongs in the same category as \u0027private\u0027 and should raise Forbidden instead of ForbiddenPublicImage. Am I missing a reason for the way you\u0027ve done it here?","commit_id":"b436ac6623ac1599239ff5f263bd963017510768"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"864777c2147c692b0c83b7271356fffd6505dccf","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        if image_ref.visibility \u003d\u003d \u0027private\u0027:"},{"line_number":138,"context_line":"            exc_class \u003d exception.Forbidden"},{"line_number":139,"context_line":"        else:"},{"line_number":140,"context_line":"            # \u0027public\u0027, \u0027community\u0027, or \u0027shared\u0027"},{"line_number":141,"context_line":"            exc_class \u003d exception.ForbiddenPublicImage"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        raise exc_class(msg)"}],"source_content_type":"text/x-python","patch_set":49,"id":"9a629dbe_c903730e","line":140,"range":{"start_line":140,"start_character":0,"end_line":140,"end_character":48},"in_reply_to":"ba5da102_1dcbac1f","updated":"2016-11-07 16:45:10.000000000","message":"Done","commit_id":"b436ac6623ac1599239ff5f263bd963017510768"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"16b03425ca8222dc4e0b88a6c5ec5928e83819cb","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        if image_ref.visibility in [\u0027private\u0027, \u0027shared\u0027]:"},{"line_number":138,"context_line":"            exc_class \u003d exception.Forbidden"},{"line_number":139,"context_line":"        else:"},{"line_number":140,"context_line":"            # \u0027public\u0027, or \u0027shared\u0027"},{"line_number":141,"context_line":"            exc_class \u003d exception.ForbiddenPublicImage"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        raise exc_class(msg)"}],"source_content_type":"text/x-python","patch_set":51,"id":"9a629dbe_64f2ce07","line":140,"range":{"start_line":140,"start_character":27,"end_line":140,"end_character":35},"updated":"2016-11-11 06:46:57.000000000","message":"this should be \u0027community\u0027?","commit_id":"8f55ebafbf6dd1e2ec2a839824e3a73c73fbded2"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"6f483489748bbaba940507c5fe93967bf9d26af7","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        if image_ref.visibility in [\u0027private\u0027, \u0027shared\u0027]:"},{"line_number":138,"context_line":"            exc_class \u003d exception.Forbidden"},{"line_number":139,"context_line":"        else:"},{"line_number":140,"context_line":"            # \u0027public\u0027, or \u0027shared\u0027"},{"line_number":141,"context_line":"            exc_class \u003d exception.ForbiddenPublicImage"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        raise exc_class(msg)"}],"source_content_type":"text/x-python","patch_set":51,"id":"9a629dbe_74ad05e8","line":140,"range":{"start_line":140,"start_character":27,"end_line":140,"end_character":35},"in_reply_to":"9a629dbe_64f2ce07","updated":"2016-11-11 17:22:45.000000000","message":"Yes, thank you. Fixed.","commit_id":"8f55ebafbf6dd1e2ec2a839824e3a73c73fbded2"}],"glance/db/sqlalchemy/migrate_repo/versions/045_add_visibility.py":[{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"67dd1cbcbe768172a3dad793a44b30cdf68eafcf","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    images \u003d Table(\u0027images\u0027, meta, autoload\u003dTrue)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    # TODO(tsymanczyk): would be nice if this enum weren\u0027t copypaste"},{"line_number":25,"context_line":"    enum \u003d Enum(\u0027private\u0027, \u0027public\u0027, \u0027shared\u0027, \u0027community\u0027, metadata\u003dmeta,"},{"line_number":26,"context_line":"                name\u003d\u0027image_visibility\u0027)"},{"line_number":27,"context_line":"    enum.create()"}],"source_content_type":"text/x-python","patch_set":30,"id":"1a95cdbc_2dbc74db","line":24,"updated":"2016-10-06 22:06:29.000000000","message":"it\u0027s not clear to me that this is something you will be fixing and I wouldn\u0027t place much importance on fixing it in this case, so maybe remove the TODO?","commit_id":"a3fc336d9f27f7e6d90fd112c5f87ab3022f1c47"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"a2e7f5f788466537a241859afa2e9c58b8e7df60","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    images \u003d Table(\u0027images\u0027, meta, autoload\u003dTrue)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    # TODO(tsymanczyk): would be nice if this enum weren\u0027t copypaste"},{"line_number":25,"context_line":"    enum \u003d Enum(\u0027private\u0027, \u0027public\u0027, \u0027shared\u0027, \u0027community\u0027, metadata\u003dmeta,"},{"line_number":26,"context_line":"                name\u003d\u0027image_visibility\u0027)"},{"line_number":27,"context_line":"    enum.create()"}],"source_content_type":"text/x-python","patch_set":30,"id":"1a95cdbc_ad27a4c8","line":24,"in_reply_to":"1a95cdbc_2dbc74db","updated":"2016-10-06 22:18:15.000000000","message":"Done","commit_id":"a3fc336d9f27f7e6d90fd112c5f87ab3022f1c47"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"ecf8a4839814f4b469f18f9dc9ecbeed093d722f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    images.update(values\u003d{\u0027visibility\u0027: \u0027public\u0027}).where("},{"line_number":34,"context_line":"        images.c.is_public).execute()"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    images.c.is_public.drop()"}],"source_content_type":"text/x-python","patch_set":49,"id":"ba5da102_9d089c2f","line":36,"range":{"start_line":36,"start_character":4,"end_line":36,"end_character":29},"updated":"2016-10-28 19:00:55.000000000","message":"Should drop the \u0027ix_images_is_public\u0027 index here as well.","commit_id":"b436ac6623ac1599239ff5f263bd963017510768"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"864777c2147c692b0c83b7271356fffd6505dccf","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    images.update(values\u003d{\u0027visibility\u0027: \u0027public\u0027}).where("},{"line_number":34,"context_line":"        images.c.is_public).execute()"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    images.c.is_public.drop()"}],"source_content_type":"text/x-python","patch_set":49,"id":"9a629dbe_6cc43592","line":36,"range":{"start_line":36,"start_character":4,"end_line":36,"end_character":29},"in_reply_to":"ba5da102_9d089c2f","updated":"2016-11-07 16:45:10.000000000","message":"Done","commit_id":"b436ac6623ac1599239ff5f263bd963017510768"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"48355cf5510b24b7df73bd957441722abf4b55d8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Symantec, Inc"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":60,"id":"7a3c09a3_53b93314","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":22},"updated":"2017-01-18 00:07:03.000000000","message":"Update year or drop this?","commit_id":"9190a34cf92580ec732b58bff13ce0b7e6ff771b"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"204ebfee69d0ccccf24487d6f0edcac258980644","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Symantec, Inc"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":60,"id":"7a3c09a3_250fcb37","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":22},"in_reply_to":"7a3c09a3_53b93314","updated":"2017-01-18 18:36:17.000000000","message":"Done","commit_id":"9190a34cf92580ec732b58bff13ce0b7e6ff771b"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"48355cf5510b24b7df73bd957441722abf4b55d8","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    # NOTE(dharinic): Identify \u0027shared\u0027 images from the above"},{"line_number":43,"context_line":"    images.update().values(visibility\u003d\u0027shared\u0027).where("},{"line_number":44,"context_line":"        images.c.visibility !\u003d \u0027public\u0027 and images.c.id.in_(select("},{"line_number":45,"context_line":"            [image_members.c.image_id]).where("},{"line_number":46,"context_line":"                not_(image_members.c.deleted)))).execute()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    is_public_index_present \u003d False"}],"source_content_type":"text/x-python","patch_set":60,"id":"7a3c09a3_00102f56","line":45,"range":{"start_line":45,"start_character":12,"end_line":45,"end_character":38},"updated":"2017-01-18 00:07:03.000000000","message":"Can we do distinct here?","commit_id":"9190a34cf92580ec732b58bff13ce0b7e6ff771b"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"204ebfee69d0ccccf24487d6f0edcac258980644","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    # NOTE(dharinic): Identify \u0027shared\u0027 images from the above"},{"line_number":43,"context_line":"    images.update().values(visibility\u003d\u0027shared\u0027).where("},{"line_number":44,"context_line":"        images.c.visibility !\u003d \u0027public\u0027 and images.c.id.in_(select("},{"line_number":45,"context_line":"            [image_members.c.image_id]).where("},{"line_number":46,"context_line":"                not_(image_members.c.deleted)))).execute()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    is_public_index_present \u003d False"}],"source_content_type":"text/x-python","patch_set":60,"id":"7a3c09a3_a51adb7a","line":45,"range":{"start_line":45,"start_character":12,"end_line":45,"end_character":38},"in_reply_to":"7a3c09a3_00102f56","updated":"2017-01-18 18:36:17.000000000","message":"Done","commit_id":"9190a34cf92580ec732b58bff13ce0b7e6ff771b"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"48355cf5510b24b7df73bd957441722abf4b55d8","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            [image_members.c.image_id]).where("},{"line_number":46,"context_line":"                not_(image_members.c.deleted)))).execute()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    is_public_index_present \u003d False"},{"line_number":49,"context_line":"    insp \u003d reflection.Inspector.from_engine(migrate_engine)"},{"line_number":50,"context_line":"    for index in insp.get_indexes(\u0027images\u0027):"},{"line_number":51,"context_line":"        if \u0027ix_images_is_public\u0027 \u003d\u003d index[\u0027name\u0027]:"}],"source_content_type":"text/x-python","patch_set":60,"id":"7a3c09a3_f344df4a","line":48,"range":{"start_line":48,"start_character":4,"end_line":48,"end_character":35},"updated":"2017-01-18 00:07:03.000000000","message":"Don\u0027t need this.","commit_id":"9190a34cf92580ec732b58bff13ce0b7e6ff771b"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"204ebfee69d0ccccf24487d6f0edcac258980644","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            [image_members.c.image_id]).where("},{"line_number":46,"context_line":"                not_(image_members.c.deleted)))).execute()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    is_public_index_present \u003d False"},{"line_number":49,"context_line":"    insp \u003d reflection.Inspector.from_engine(migrate_engine)"},{"line_number":50,"context_line":"    for index in insp.get_indexes(\u0027images\u0027):"},{"line_number":51,"context_line":"        if \u0027ix_images_is_public\u0027 \u003d\u003d index[\u0027name\u0027]:"}],"source_content_type":"text/x-python","patch_set":60,"id":"7a3c09a3_c51d2774","line":48,"range":{"start_line":48,"start_character":4,"end_line":48,"end_character":35},"in_reply_to":"7a3c09a3_f344df4a","updated":"2017-01-18 18:36:17.000000000","message":"Done","commit_id":"9190a34cf92580ec732b58bff13ce0b7e6ff771b"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"48355cf5510b24b7df73bd957441722abf4b55d8","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    insp \u003d reflection.Inspector.from_engine(migrate_engine)"},{"line_number":50,"context_line":"    for index in insp.get_indexes(\u0027images\u0027):"},{"line_number":51,"context_line":"        if \u0027ix_images_is_public\u0027 \u003d\u003d index[\u0027name\u0027]:"},{"line_number":52,"context_line":"            is_public_index_present \u003d True"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    if is_public_index_present:"},{"line_number":55,"context_line":"        Index(\u0027ix_images_is_public\u0027, images.c.is_public).drop()"}],"source_content_type":"text/x-python","patch_set":60,"id":"7a3c09a3_937abb86","line":52,"range":{"start_line":52,"start_character":12,"end_line":52,"end_character":42},"updated":"2017-01-18 00:07:03.000000000","message":"We can drop the index right here and break out of the loop.\nReplace this with the following:\n Index(\u0027ix_images_is_public\u0027, images.c.is_public).drop()\n break","commit_id":"9190a34cf92580ec732b58bff13ce0b7e6ff771b"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"204ebfee69d0ccccf24487d6f0edcac258980644","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    insp \u003d reflection.Inspector.from_engine(migrate_engine)"},{"line_number":50,"context_line":"    for index in insp.get_indexes(\u0027images\u0027):"},{"line_number":51,"context_line":"        if \u0027ix_images_is_public\u0027 \u003d\u003d index[\u0027name\u0027]:"},{"line_number":52,"context_line":"            is_public_index_present \u003d True"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    if is_public_index_present:"},{"line_number":55,"context_line":"        Index(\u0027ix_images_is_public\u0027, images.c.is_public).drop()"}],"source_content_type":"text/x-python","patch_set":60,"id":"7a3c09a3_e510635b","line":52,"range":{"start_line":52,"start_character":12,"end_line":52,"end_character":42},"in_reply_to":"7a3c09a3_937abb86","updated":"2017-01-18 18:36:17.000000000","message":"Done","commit_id":"9190a34cf92580ec732b58bff13ce0b7e6ff771b"}],"glance/db/sqlalchemy/migrate_repo/versions/045_sqlite_upgrade.sql":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"5a942182c52a570aeec816a108b702da1e9ff823","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":52,"id":"7a77a97e_30ce1884","updated":"2016-11-14 20:55:08.000000000","message":"So I know we have a couple other migrations that were written in plain sql a while back, but why is this one not written in Python the way every other recent one has been?","commit_id":"0b3517fd57cdba4a0a7859fe52539da557e7e0e6"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"51c1809eada36b387b68eb90257b3dc025fe5f43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":52,"id":"7a77a97e_abc63914","in_reply_to":"7a77a97e_30ce1884","updated":"2016-11-14 21:59:46.000000000","message":"Back in the original changeset for the community images database migration https://review.openstack.org/#/c/326128/ , I was never able to get the .py migration script to work with sqlite. You can see on patchset #8 Nikhil had commented that he felt I was running into this problem http://lists.openstack.org/pipermail/openstack-dev/2014-August/043615.html where sqlite doesn\u0027t support the requisite DROP CHECK.\n\nThat is why this file exists.","commit_id":"0b3517fd57cdba4a0a7859fe52539da557e7e0e6"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"48355cf5510b24b7df73bd957441722abf4b55d8","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    WHERE is_public\u003d0;"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"UPDATE images SET visibility\u003d\u0027private\u0027 WHERE visibility\u003d\u0027shared\u0027;"},{"line_number":160,"context_line":"UPDATE images SET visibility\u003d\u0027shared\u0027 WHERE visibility \u003c\u003e \u0027public\u0027 AND id IN (SELECT image_id FROM image_members WHERE deleted !\u003d 1);"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"DROP TABLE images_backup;"}],"source_content_type":"text/x-sql","patch_set":60,"id":"7a3c09a3_13aecbe5","line":160,"range":{"start_line":160,"start_character":85,"end_line":160,"end_character":93},"updated":"2017-01-18 00:07:03.000000000","message":"same, can use distinct here.","commit_id":"9190a34cf92580ec732b58bff13ce0b7e6ff771b"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"204ebfee69d0ccccf24487d6f0edcac258980644","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    WHERE is_public\u003d0;"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"UPDATE images SET visibility\u003d\u0027private\u0027 WHERE visibility\u003d\u0027shared\u0027;"},{"line_number":160,"context_line":"UPDATE images SET visibility\u003d\u0027shared\u0027 WHERE visibility \u003c\u003e \u0027public\u0027 AND id IN (SELECT image_id FROM image_members WHERE deleted !\u003d 1);"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"DROP TABLE images_backup;"}],"source_content_type":"text/x-sql","patch_set":60,"id":"7a3c09a3_65055312","line":160,"range":{"start_line":160,"start_character":85,"end_line":160,"end_character":93},"in_reply_to":"7a3c09a3_13aecbe5","updated":"2017-01-18 18:36:17.000000000","message":"Done","commit_id":"9190a34cf92580ec732b58bff13ce0b7e6ff771b"}],"glance/db/sqlalchemy/models.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"120cc3c993b39c498a173165e83b8b97aad8974f","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    status \u003d Column(String(30), nullable\u003dFalse)"},{"line_number":132,"context_line":"    visibility \u003d Column(Enum(\u0027private\u0027, \u0027public\u0027, \u0027shared\u0027, \u0027community\u0027,"},{"line_number":133,"context_line":"                        name\u003d\u0027image_visibility\u0027), nullable\u003dFalse,"},{"line_number":134,"context_line":"                        server_default\u003d\u0027shared\u0027)"},{"line_number":135,"context_line":"    checksum \u003d Column(String(32))"},{"line_number":136,"context_line":"    min_disk \u003d Column(Integer, nullable\u003dFalse, default\u003d0)"},{"line_number":137,"context_line":"    min_ram \u003d Column(Integer, nullable\u003dFalse, default\u003d0)"}],"source_content_type":"text/x-python","patch_set":51,"id":"9a629dbe_34e632e8","line":134,"range":{"start_line":134,"start_character":24,"end_line":134,"end_character":47},"updated":"2016-11-11 15:25:07.000000000","message":"This is backwards incompatible API change.","commit_id":"8f55ebafbf6dd1e2ec2a839824e3a73c73fbded2"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"6f483489748bbaba940507c5fe93967bf9d26af7","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    status \u003d Column(String(30), nullable\u003dFalse)"},{"line_number":132,"context_line":"    visibility \u003d Column(Enum(\u0027private\u0027, \u0027public\u0027, \u0027shared\u0027, \u0027community\u0027,"},{"line_number":133,"context_line":"                        name\u003d\u0027image_visibility\u0027), nullable\u003dFalse,"},{"line_number":134,"context_line":"                        server_default\u003d\u0027shared\u0027)"},{"line_number":135,"context_line":"    checksum \u003d Column(String(32))"},{"line_number":136,"context_line":"    min_disk \u003d Column(Integer, nullable\u003dFalse, default\u003d0)"},{"line_number":137,"context_line":"    min_ram \u003d Column(Integer, nullable\u003dFalse, default\u003d0)"}],"source_content_type":"text/x-python","patch_set":51,"id":"9a629dbe_743fc5b3","line":134,"range":{"start_line":134,"start_character":24,"end_line":134,"end_character":47},"in_reply_to":"9a629dbe_34e632e8","updated":"2016-11-11 17:22:45.000000000","message":"\u0027shared\u0027 visibility is functionality identical to the old is_public\u003dfalse.","commit_id":"8f55ebafbf6dd1e2ec2a839824e3a73c73fbded2"}],"glance/db/utils.py":[{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"bbc7d083f8dd73195802605e98ec84be2a1764e7","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    Replaces a v2-style image dictionary\u0027s \u0027visibility\u0027 member with the"},{"line_number":22,"context_line":"    equivalent v1-style \u0027is_public\u0027 member."},{"line_number":23,"context_line":"    \"\"\""},{"line_number":24,"context_line":"    image[\u0027is_public\u0027] \u003d True if \u0027public\u0027 \u003d\u003d image.pop(\u0027visibility\u0027) else False"},{"line_number":25,"context_line":"    return image"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":48,"id":"da6895a0_310076aa","line":24,"updated":"2016-10-25 23:57:56.000000000","message":"This is bothering me now, but didn\u0027t before. The logic isn\u0027t complex but this implementation seems to be. Maybe improve it a bit by simplifying to some degree.\n\nfor example:\n    visibility \u003d image.pop(\u0027visibility\u0027)\n    is_image_public \u003d \u0027public\u0027 \u003d\u003d visibility\n    image[\u0027is_public\u0027] \u003d is_image_public\n    return image\n\nor:\n    is_image_public \u003d \u0027public\u0027 \u003d\u003d image.pop(\u0027visibility\u0027)\n    image[\u0027is_public\u0027] \u003d is_image_public\n    return image\n\nor:\n    visibility \u003d image.pop(\u0027visibility\u0027)\n    image[\u0027is_public\u0027] \u003d \u0027public\u0027 \u003d\u003d visibility\n    return image\n\nor perhaps:\n    image[\u0027is_public\u0027] \u003d \u0027public\u0027 \u003d\u003d image.pop(\u0027visibility\u0027)\n    return image\n\nI\u0027m not sure which is best but I think I prefer one of the first two. Just finding something that can be easily scanned for meaning would be helpful.","commit_id":"f455a23f8c82dafa27fafce867e5e0b4f2878ed7"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"d383c9892f16b7052bd137d7baf39ef41a8071d8","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    Replaces a v2-style image dictionary\u0027s \u0027visibility\u0027 member with the"},{"line_number":22,"context_line":"    equivalent v1-style \u0027is_public\u0027 member."},{"line_number":23,"context_line":"    \"\"\""},{"line_number":24,"context_line":"    image[\u0027is_public\u0027] \u003d True if \u0027public\u0027 \u003d\u003d image.pop(\u0027visibility\u0027) else False"},{"line_number":25,"context_line":"    return image"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":48,"id":"ba5da102_465e3e77","line":24,"in_reply_to":"da6895a0_310076aa","updated":"2016-10-28 14:02:52.000000000","message":"Done","commit_id":"f455a23f8c82dafa27fafce867e5e0b4f2878ed7"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"120cc3c993b39c498a173165e83b8b97aad8974f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                    \"permiitted.\")"},{"line_number":39,"context_line":"            raise exception.Invalid(msg)"},{"line_number":40,"context_line":"        else:"},{"line_number":41,"context_line":"            image[\u0027visibility\u0027] \u003d (\u0027public\u0027 if image.pop(\u0027is_public\u0027) else"},{"line_number":42,"context_line":"                                   \u0027shared\u0027)"},{"line_number":43,"context_line":"    return image"}],"source_content_type":"text/x-python","patch_set":51,"id":"9a629dbe_f42d9afe","line":42,"range":{"start_line":41,"start_character":69,"end_line":42,"end_character":43},"updated":"2016-11-11 15:25:07.000000000","message":"This is backwards incompatible breaking API change.","commit_id":"8f55ebafbf6dd1e2ec2a839824e3a73c73fbded2"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"6f483489748bbaba940507c5fe93967bf9d26af7","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                    \"permiitted.\")"},{"line_number":39,"context_line":"            raise exception.Invalid(msg)"},{"line_number":40,"context_line":"        else:"},{"line_number":41,"context_line":"            image[\u0027visibility\u0027] \u003d (\u0027public\u0027 if image.pop(\u0027is_public\u0027) else"},{"line_number":42,"context_line":"                                   \u0027shared\u0027)"},{"line_number":43,"context_line":"    return image"}],"source_content_type":"text/x-python","patch_set":51,"id":"9a629dbe_146da9cb","line":42,"range":{"start_line":41,"start_character":69,"end_line":42,"end_character":43},"in_reply_to":"9a629dbe_f42d9afe","updated":"2016-11-11 17:22:45.000000000","message":"\u0027shared\u0027 visibility is functionality identical to the old is_public\u003dfalse.","commit_id":"8f55ebafbf6dd1e2ec2a839824e3a73c73fbded2"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"48355cf5510b24b7df73bd957441722abf4b55d8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Symantec, Inc"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":60,"id":"7a3c09a3_335587c5","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":22},"updated":"2017-01-18 00:07:03.000000000","message":"Update year or drop this?","commit_id":"9190a34cf92580ec732b58bff13ce0b7e6ff771b"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"204ebfee69d0ccccf24487d6f0edcac258980644","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Symantec, Inc"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":60,"id":"7a3c09a3_a801d206","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":22},"in_reply_to":"7a3c09a3_335587c5","updated":"2017-01-18 18:36:17.000000000","message":"Done","commit_id":"9190a34cf92580ec732b58bff13ce0b7e6ff771b"}],"glance/domain/__init__.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"120cc3c993b39c498a173165e83b8b97aad8974f","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                if key in properties:"},{"line_number":69,"context_line":"                    raise exception.ReservedProperty(property\u003dkey)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def new_image(self, image_id\u003dNone, name\u003dNone, visibility\u003d\u0027shared\u0027,"},{"line_number":72,"context_line":"                  min_disk\u003d0, min_ram\u003d0, protected\u003dFalse, owner\u003dNone,"},{"line_number":73,"context_line":"                  disk_format\u003dNone, container_format\u003dNone,"},{"line_number":74,"context_line":"                  extra_properties\u003dNone, tags\u003dNone, **other_args):"}],"source_content_type":"text/x-python","patch_set":51,"id":"9a629dbe_14312e5a","line":71,"range":{"start_line":71,"start_character":50,"end_line":71,"end_character":69},"updated":"2016-11-11 15:25:07.000000000","message":"This is backwards incompatible breaking API change.","commit_id":"8f55ebafbf6dd1e2ec2a839824e3a73c73fbded2"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"6f483489748bbaba940507c5fe93967bf9d26af7","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                if key in properties:"},{"line_number":69,"context_line":"                    raise exception.ReservedProperty(property\u003dkey)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def new_image(self, image_id\u003dNone, name\u003dNone, visibility\u003d\u0027shared\u0027,"},{"line_number":72,"context_line":"                  min_disk\u003d0, min_ram\u003d0, protected\u003dFalse, owner\u003dNone,"},{"line_number":73,"context_line":"                  disk_format\u003dNone, container_format\u003dNone,"},{"line_number":74,"context_line":"                  extra_properties\u003dNone, tags\u003dNone, **other_args):"}],"source_content_type":"text/x-python","patch_set":51,"id":"9a629dbe_7466e5ed","line":71,"range":{"start_line":71,"start_character":50,"end_line":71,"end_character":69},"in_reply_to":"9a629dbe_14312e5a","updated":"2016-11-11 17:22:45.000000000","message":"The new \u0027shared\u0027 visibility is functionality identical to the old \u0027private\u0027 visibility.","commit_id":"8f55ebafbf6dd1e2ec2a839824e3a73c73fbded2"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"120cc3c993b39c498a173165e83b8b97aad8974f","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        self.created_at \u003d created_at"},{"line_number":117,"context_line":"        self.updated_at \u003d updated_at"},{"line_number":118,"context_line":"        self.name \u003d kwargs.pop(\u0027name\u0027, None)"},{"line_number":119,"context_line":"        self.visibility \u003d kwargs.pop(\u0027visibility\u0027, \u0027shared\u0027)"},{"line_number":120,"context_line":"        self.min_disk \u003d kwargs.pop(\u0027min_disk\u0027, 0)"},{"line_number":121,"context_line":"        self.min_ram \u003d kwargs.pop(\u0027min_ram\u0027, 0)"},{"line_number":122,"context_line":"        self.protected \u003d kwargs.pop(\u0027protected\u0027, False)"}],"source_content_type":"text/x-python","patch_set":51,"id":"9a629dbe_74426aaf","line":119,"updated":"2016-11-11 15:25:07.000000000","message":"Ditto","commit_id":"8f55ebafbf6dd1e2ec2a839824e3a73c73fbded2"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"6f483489748bbaba940507c5fe93967bf9d26af7","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        self.created_at \u003d created_at"},{"line_number":117,"context_line":"        self.updated_at \u003d updated_at"},{"line_number":118,"context_line":"        self.name \u003d kwargs.pop(\u0027name\u0027, None)"},{"line_number":119,"context_line":"        self.visibility \u003d kwargs.pop(\u0027visibility\u0027, \u0027shared\u0027)"},{"line_number":120,"context_line":"        self.min_disk \u003d kwargs.pop(\u0027min_disk\u0027, 0)"},{"line_number":121,"context_line":"        self.min_ram \u003d kwargs.pop(\u0027min_ram\u0027, 0)"},{"line_number":122,"context_line":"        self.protected \u003d kwargs.pop(\u0027protected\u0027, False)"}],"source_content_type":"text/x-python","patch_set":51,"id":"9a629dbe_9461b9d5","line":119,"in_reply_to":"9a629dbe_74426aaf","updated":"2016-11-11 17:22:45.000000000","message":"Also ditto.","commit_id":"8f55ebafbf6dd1e2ec2a839824e3a73c73fbded2"}],"glance/locale/de/LC_MESSAGES/glance.po":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"120cc3c993b39c498a173165e83b8b97aad8974f","unresolved":false,"context_lines":[{"line_number":1653,"context_line":"msgstr \"\""},{"line_number":1654,"context_line":"\"Stellt eine benutzerfreundliche Beschreibung des Namensbereichs bereit. \""},{"line_number":1655,"context_line":""},{"line_number":1656,"context_line":"msgid \"Only shared images have members.\""},{"line_number":1657,"context_line":"msgstr \"Öffentliche Abbilder haben keine Mitglieder.\""},{"line_number":1658,"context_line":""},{"line_number":1659,"context_line":"msgid \"Received invalid HTTP redirect.\""}],"source_content_type":"application/octet-stream","patch_set":51,"id":"9a629dbe_540e468c","line":1656,"updated":"2016-11-11 15:25:07.000000000","message":"Oh no we don\u0027t!","commit_id":"8f55ebafbf6dd1e2ec2a839824e3a73c73fbded2"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"5a942182c52a570aeec816a108b702da1e9ff823","unresolved":false,"context_lines":[{"line_number":1653,"context_line":"msgstr \"\""},{"line_number":1654,"context_line":"\"Stellt eine benutzerfreundliche Beschreibung des Namensbereichs bereit. \""},{"line_number":1655,"context_line":""},{"line_number":1656,"context_line":"msgid \"Only shared images have members.\""},{"line_number":1657,"context_line":"msgstr \"Öffentliche Abbilder haben keine Mitglieder.\""},{"line_number":1658,"context_line":""},{"line_number":1659,"context_line":"msgid \"Received invalid HTTP redirect.\""}],"source_content_type":"application/octet-stream","patch_set":52,"id":"7a77a97e_10b91cea","line":1656,"updated":"2016-11-14 20:55:08.000000000","message":"Please do not change the translations files.","commit_id":"0b3517fd57cdba4a0a7859fe52539da557e7e0e6"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"51c1809eada36b387b68eb90257b3dc025fe5f43","unresolved":false,"context_lines":[{"line_number":1653,"context_line":"msgstr \"\""},{"line_number":1654,"context_line":"\"Stellt eine benutzerfreundliche Beschreibung des Namensbereichs bereit. \""},{"line_number":1655,"context_line":""},{"line_number":1656,"context_line":"msgid \"Only shared images have members.\""},{"line_number":1657,"context_line":"msgstr \"Öffentliche Abbilder haben keine Mitglieder.\""},{"line_number":1658,"context_line":""},{"line_number":1659,"context_line":"msgid \"Received invalid HTTP redirect.\""}],"source_content_type":"application/octet-stream","patch_set":52,"id":"7a77a97e_8be25d9e","line":1656,"in_reply_to":"7a77a97e_10b91cea","updated":"2016-11-14 21:59:46.000000000","message":"Thank you for explaining the correct way on IRC.\n\nFixed.","commit_id":"0b3517fd57cdba4a0a7859fe52539da557e7e0e6"}],"glance/locale/es/LC_MESSAGES/glance.po":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"120cc3c993b39c498a173165e83b8b97aad8974f","unresolved":false,"context_lines":[{"line_number":1627,"context_line":"msgid \"Provides a user friendly description of the namespace.\""},{"line_number":1628,"context_line":"msgstr \"Proporciona una descripción sencilla del espacio de nombre.\""},{"line_number":1629,"context_line":""},{"line_number":1630,"context_line":"msgid \"Only shared images have members.\""},{"line_number":1631,"context_line":"msgstr \"Las imágenes públicas no tienen miembros.\""},{"line_number":1632,"context_line":""},{"line_number":1633,"context_line":"msgid \"Received invalid HTTP redirect.\""}],"source_content_type":"application/octet-stream","patch_set":51,"id":"9a629dbe_b41fa2b5","line":1630,"updated":"2016-11-11 15:25:07.000000000","message":"Oh no we don\u0027t!","commit_id":"8f55ebafbf6dd1e2ec2a839824e3a73c73fbded2"}],"glance/locale/fr/LC_MESSAGES/glance.po":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"120cc3c993b39c498a173165e83b8b97aad8974f","unresolved":false,"context_lines":[{"line_number":1653,"context_line":"msgid \"Provides a user friendly description of the namespace.\""},{"line_number":1654,"context_line":"msgstr \"Fournit une description conviviale de l\u0027espace de nom.\""},{"line_number":1655,"context_line":""},{"line_number":1656,"context_line":"msgid \"Only shared images have members.\""},{"line_number":1657,"context_line":"msgstr \"Les images publiques n\u0027ont pas de membre.\""},{"line_number":1658,"context_line":""},{"line_number":1659,"context_line":"msgid \"Received invalid HTTP redirect.\""}],"source_content_type":"application/octet-stream","patch_set":51,"id":"9a629dbe_147f6ee0","line":1656,"updated":"2016-11-11 15:25:07.000000000","message":"Oh no we don\u0027t!","commit_id":"8f55ebafbf6dd1e2ec2a839824e3a73c73fbded2"}],"glance/locale/it/LC_MESSAGES/glance.po":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"120cc3c993b39c498a173165e83b8b97aad8974f","unresolved":false,"context_lines":[{"line_number":1639,"context_line":"msgid \"Provides a user friendly description of the namespace.\""},{"line_number":1640,"context_line":"msgstr \"Fornisce una semplice descrizione utente dello spazio dei nomi.\""},{"line_number":1641,"context_line":""},{"line_number":1642,"context_line":"msgid \"Only shared images have members.\""},{"line_number":1643,"context_line":"msgstr \"Le immagini pubblica non hanno membri.\""},{"line_number":1644,"context_line":""},{"line_number":1645,"context_line":"msgid \"Received invalid HTTP redirect.\""}],"source_content_type":"application/octet-stream","patch_set":51,"id":"9a629dbe_548566cc","line":1642,"updated":"2016-11-11 15:25:07.000000000","message":"Oh no we don\u0027t!","commit_id":"8f55ebafbf6dd1e2ec2a839824e3a73c73fbded2"}],"glance/locale/ja/LC_MESSAGES/glance.po":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"120cc3c993b39c498a173165e83b8b97aad8974f","unresolved":false,"context_lines":[{"line_number":1592,"context_line":"msgid \"Provides a user friendly description of the namespace.\""},{"line_number":1593,"context_line":"msgstr \"分かりやすい名前空間の説明が提供されます。\""},{"line_number":1594,"context_line":""},{"line_number":1595,"context_line":"msgid \"Only shared images have members.\""},{"line_number":1596,"context_line":"msgstr \"パブリックイメージにはメンバーがありません。\""},{"line_number":1597,"context_line":""},{"line_number":1598,"context_line":"msgid \"Received invalid HTTP redirect.\""}],"source_content_type":"application/octet-stream","patch_set":51,"id":"9a629dbe_7470aa0b","line":1595,"updated":"2016-11-11 15:25:07.000000000","message":"Oh no we don\u0027t!","commit_id":"8f55ebafbf6dd1e2ec2a839824e3a73c73fbded2"}],"glance/locale/ko_KR/LC_MESSAGES/glance.po":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"120cc3c993b39c498a173165e83b8b97aad8974f","unresolved":false,"context_lines":[{"line_number":1564,"context_line":"msgid \"Provides a user friendly description of the namespace.\""},{"line_number":1565,"context_line":"msgstr \"사용자에게 익숙한 네임스페이스 설명을 제공합니다.\""},{"line_number":1566,"context_line":""},{"line_number":1567,"context_line":"msgid \"Only shared images have members.\""},{"line_number":1568,"context_line":"msgstr \"공용 이미지에 멤버가 없습니다.\""},{"line_number":1569,"context_line":""},{"line_number":1570,"context_line":"msgid \"Received invalid HTTP redirect.\""}],"source_content_type":"application/octet-stream","patch_set":51,"id":"9a629dbe_d471760d","line":1567,"updated":"2016-11-11 15:25:07.000000000","message":"Oh no we don\u0027t!","commit_id":"8f55ebafbf6dd1e2ec2a839824e3a73c73fbded2"}],"glance/locale/pt_BR/LC_MESSAGES/glance.po":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"120cc3c993b39c498a173165e83b8b97aad8974f","unresolved":false,"context_lines":[{"line_number":1617,"context_line":"msgid \"Provides a user friendly description of the namespace.\""},{"line_number":1618,"context_line":"msgstr \"Fornece uma descrição fácil do namespace.\""},{"line_number":1619,"context_line":""},{"line_number":1620,"context_line":"msgid \"Only shared images have members.\""},{"line_number":1621,"context_line":"msgstr \"As imagens não têm membros.\""},{"line_number":1622,"context_line":""},{"line_number":1623,"context_line":"msgid \"Received invalid HTTP redirect.\""}],"source_content_type":"application/octet-stream","patch_set":51,"id":"9a629dbe_f462fa3c","line":1620,"updated":"2016-11-11 15:25:07.000000000","message":"Oh no we don\u0027t!","commit_id":"8f55ebafbf6dd1e2ec2a839824e3a73c73fbded2"}],"glance/locale/ru/LC_MESSAGES/glance.po":[{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"62bbd41c7e6a9861ba040d252543a3cd311902ab","unresolved":false,"context_lines":[{"line_number":1592,"context_line":"msgid \"Provides a user friendly description of the namespace.\""},{"line_number":1593,"context_line":"msgstr \"Описание пространства имен для пользователя.\""},{"line_number":1594,"context_line":""},{"line_number":1595,"context_line":"msgid \"Only shared images have members.\""},{"line_number":1596,"context_line":"msgstr \"У общедоступных образов нет участников.\""},{"line_number":1597,"context_line":""},{"line_number":1598,"context_line":"msgid \"Received invalid HTTP redirect.\""},{"line_number":1599,"context_line":"msgstr \"Получено недопустимое перенаправление HTTP.\""}],"source_content_type":"application/octet-stream","patch_set":40,"id":"fa6399be_af0c2295","line":1596,"range":{"start_line":1595,"start_character":0,"end_line":1596,"end_character":48},"updated":"2016-10-19 17:21:39.000000000","message":"I\u0027ve probably asked this before and forgot, when/how does ``msgstr`` get updated?","commit_id":"4ff08bb30960abe6803b0f37581fada18c84fd1c"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"f3386bee470d97990572adccef0f1d3d456db69b","unresolved":false,"context_lines":[{"line_number":1592,"context_line":"msgid \"Provides a user friendly description of the namespace.\""},{"line_number":1593,"context_line":"msgstr \"Описание пространства имен для пользователя.\""},{"line_number":1594,"context_line":""},{"line_number":1595,"context_line":"msgid \"Only shared images have members.\""},{"line_number":1596,"context_line":"msgstr \"У общедоступных образов нет участников.\""},{"line_number":1597,"context_line":""},{"line_number":1598,"context_line":"msgid \"Received invalid HTTP redirect.\""},{"line_number":1599,"context_line":"msgstr \"Получено недопустимое перенаправление HTTP.\""}],"source_content_type":"application/octet-stream","patch_set":40,"id":"fa6399be_8c7cc973","line":1596,"range":{"start_line":1595,"start_character":0,"end_line":1596,"end_character":48},"in_reply_to":"fa6399be_af0c2295","updated":"2016-10-19 17:45:12.000000000","message":"My understanding is the cores flag it for international/localization separately from the (this) checkin.","commit_id":"4ff08bb30960abe6803b0f37581fada18c84fd1c"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"120cc3c993b39c498a173165e83b8b97aad8974f","unresolved":false,"context_lines":[{"line_number":1592,"context_line":"msgid \"Provides a user friendly description of the namespace.\""},{"line_number":1593,"context_line":"msgstr \"Описание пространства имен для пользователя.\""},{"line_number":1594,"context_line":""},{"line_number":1595,"context_line":"msgid \"Only shared images have members.\""},{"line_number":1596,"context_line":"msgstr \"У общедоступных образов нет участников.\""},{"line_number":1597,"context_line":""},{"line_number":1598,"context_line":"msgid \"Received invalid HTTP redirect.\""}],"source_content_type":"application/octet-stream","patch_set":51,"id":"9a629dbe_545c867c","line":1595,"updated":"2016-11-11 15:25:07.000000000","message":"Oh no we don\u0027t!","commit_id":"8f55ebafbf6dd1e2ec2a839824e3a73c73fbded2"}],"glance/locale/tr_TR/LC_MESSAGES/glance.po":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"120cc3c993b39c498a173165e83b8b97aad8974f","unresolved":false,"context_lines":[{"line_number":1376,"context_line":"msgid \"Provides a user friendly description of the namespace.\""},{"line_number":1377,"context_line":"msgstr \"Ad alanı için kullanıcı dostu bir açıklama sağlar.\""},{"line_number":1378,"context_line":""},{"line_number":1379,"context_line":"msgid \"Only shared images have members.\""},{"line_number":1380,"context_line":"msgstr \"Ortak imajlar üyelere sahip değil.\""},{"line_number":1381,"context_line":""},{"line_number":1382,"context_line":"msgid \"Received invalid HTTP redirect.\""}],"source_content_type":"application/octet-stream","patch_set":51,"id":"9a629dbe_d44896b5","line":1379,"updated":"2016-11-11 15:25:07.000000000","message":"Oh no we don\u0027t!","commit_id":"8f55ebafbf6dd1e2ec2a839824e3a73c73fbded2"}],"glance/locale/zh_CN/LC_MESSAGES/glance.po":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"120cc3c993b39c498a173165e83b8b97aad8974f","unresolved":false,"context_lines":[{"line_number":1554,"context_line":"msgid \"Provides a user friendly description of the namespace.\""},{"line_number":1555,"context_line":"msgstr \"提供名称空间的用户友好描述。\""},{"line_number":1556,"context_line":""},{"line_number":1557,"context_line":"msgid \"Only shared images have members.\""},{"line_number":1558,"context_line":"msgstr \"公共映像没有成员。\""},{"line_number":1559,"context_line":""},{"line_number":1560,"context_line":"msgid \"Received invalid HTTP redirect.\""}],"source_content_type":"application/octet-stream","patch_set":51,"id":"9a629dbe_34d0f2c8","line":1557,"updated":"2016-11-11 15:25:07.000000000","message":"Oh no we don\u0027t!","commit_id":"8f55ebafbf6dd1e2ec2a839824e3a73c73fbded2"}],"glance/locale/zh_TW/LC_MESSAGES/glance.po":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"120cc3c993b39c498a173165e83b8b97aad8974f","unresolved":false,"context_lines":[{"line_number":1502,"context_line":"msgid \"Provides a user friendly description of the namespace.\""},{"line_number":1503,"context_line":"msgstr \"提供對使用者更為友善的名稱空間說明。\""},{"line_number":1504,"context_line":""},{"line_number":1505,"context_line":"msgid \"Only shared images have members.\""},{"line_number":1506,"context_line":"msgstr \"公用映像檔沒有成員。\""},{"line_number":1507,"context_line":""},{"line_number":1508,"context_line":"msgid \"Received invalid HTTP redirect.\""}],"source_content_type":"application/octet-stream","patch_set":51,"id":"9a629dbe_74deeadd","line":1505,"updated":"2016-11-11 15:25:07.000000000","message":"Oh no we don\u0027t!","commit_id":"8f55ebafbf6dd1e2ec2a839824e3a73c73fbded2"}],"glance/notifier.py":[{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"7d10041d176331ac88d0f307a64b502dbac34b83","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        \u0027container_format\u0027: image.container_format,"},{"line_number":157,"context_line":"        \u0027size\u0027: image.size,"},{"line_number":158,"context_line":"        \u0027virtual_size\u0027: image.virtual_size,"},{"line_number":159,"context_line":"        \u0027is_public\u0027: image.visibility \u003d\u003d \u0027public\u0027,"},{"line_number":160,"context_line":"        \u0027visibility\u0027: image.visibility,"},{"line_number":161,"context_line":"        \u0027properties\u0027: dict(image.extra_properties),"},{"line_number":162,"context_line":"        \u0027tags\u0027: list(image.tags),"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a98d1f4_3b08612d","line":159,"range":{"start_line":159,"start_character":8,"end_line":159,"end_character":50},"updated":"2016-09-29 17:22:17.000000000","message":"should we deprecate this notification?","commit_id":"db2e6a87fd0b5d263867a3e1d3e0608defd4dc13"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"29b035107485aa784bc94a3455e419d62fdbb23b","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        \u0027container_format\u0027: image.container_format,"},{"line_number":157,"context_line":"        \u0027size\u0027: image.size,"},{"line_number":158,"context_line":"        \u0027virtual_size\u0027: image.virtual_size,"},{"line_number":159,"context_line":"        \u0027is_public\u0027: image.visibility \u003d\u003d \u0027public\u0027,"},{"line_number":160,"context_line":"        \u0027visibility\u0027: image.visibility,"},{"line_number":161,"context_line":"        \u0027properties\u0027: dict(image.extra_properties),"},{"line_number":162,"context_line":"        \u0027tags\u0027: list(image.tags),"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a98d1f4_f2ba8c6d","line":159,"range":{"start_line":159,"start_character":8,"end_line":159,"end_character":50},"in_reply_to":"3a98d1f4_3b08612d","updated":"2016-09-29 22:34:46.000000000","message":"I explicitly left this in based on rosmaita\u0027s comment from Mar 25 2016 on line 314 of the spec. https://review.openstack.org/#/c/271019/9\n\nIf I misunderstood and this should be removed I\u0027d be happy to.","commit_id":"db2e6a87fd0b5d263867a3e1d3e0608defd4dc13"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"ecbd006665afdc0a31223edeb533cb555fd2ad34","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        \u0027container_format\u0027: image.container_format,"},{"line_number":157,"context_line":"        \u0027size\u0027: image.size,"},{"line_number":158,"context_line":"        \u0027virtual_size\u0027: image.virtual_size,"},{"line_number":159,"context_line":"        \u0027is_public\u0027: image.visibility \u003d\u003d \u0027public\u0027,"},{"line_number":160,"context_line":"        \u0027visibility\u0027: image.visibility,"},{"line_number":161,"context_line":"        \u0027properties\u0027: dict(image.extra_properties),"},{"line_number":162,"context_line":"        \u0027tags\u0027: list(image.tags),"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a98d1f4_65c91859","line":159,"range":{"start_line":159,"start_character":8,"end_line":159,"end_character":50},"in_reply_to":"3a98d1f4_f2ba8c6d","updated":"2016-09-30 22:37:34.000000000","message":"Got it. Makes sense.","commit_id":"db2e6a87fd0b5d263867a3e1d3e0608defd4dc13"}],"glance/tests/functional/db/base.py":[{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"62bbd41c7e6a9861ba040d252543a3cd311902ab","unresolved":false,"context_lines":[{"line_number":2160,"context_line":"        self.assertEqual(\u0027private\u0027, images[0][\u0027visibility\u0027])"},{"line_number":2161,"context_line":"        self.assertEqual(self.tenant1, images[0][\u0027owner\u0027])"},{"line_number":2162,"context_line":""},{"line_number":2163,"context_line":"    def _setup_is_public_red_herring(self):"},{"line_number":2164,"context_line":"        values \u003d {"},{"line_number":2165,"context_line":"            \u0027name\u0027: \u0027Red Herring\u0027,"},{"line_number":2166,"context_line":"            \u0027owner\u0027: self.tenant1,"}],"source_content_type":"text/x-python","patch_set":40,"id":"fa6399be_0fac2e34","line":2163,"range":{"start_line":2163,"start_character":4,"end_line":2163,"end_character":36},"updated":"2016-10-19 17:21:39.000000000","message":"I\u0027m not exactly sure of the purpose of this, but if it\u0027s legit, then perhaps we need another couple of tests that filter on \u0027visibility\u0027: \u0027silly\u0027 property?","commit_id":"4ff08bb30960abe6803b0f37581fada18c84fd1c"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"f3386bee470d97990572adccef0f1d3d456db69b","unresolved":false,"context_lines":[{"line_number":2160,"context_line":"        self.assertEqual(\u0027private\u0027, images[0][\u0027visibility\u0027])"},{"line_number":2161,"context_line":"        self.assertEqual(self.tenant1, images[0][\u0027owner\u0027])"},{"line_number":2162,"context_line":""},{"line_number":2163,"context_line":"    def _setup_is_public_red_herring(self):"},{"line_number":2164,"context_line":"        values \u003d {"},{"line_number":2165,"context_line":"            \u0027name\u0027: \u0027Red Herring\u0027,"},{"line_number":2166,"context_line":"            \u0027owner\u0027: self.tenant1,"}],"source_content_type":"text/x-python","patch_set":40,"id":"fa6399be_6cbdb5d6","line":2163,"range":{"start_line":2163,"start_character":4,"end_line":2163,"end_character":36},"in_reply_to":"fa6399be_0fac2e34","updated":"2016-10-19 17:45:12.000000000","message":"My understanding is that the purpose of this test is to check that an arbitrarily named \"is_public\" property (separate and unrelated to the old is_public image attribute or new visibility attribute, which this changeset deals with) can take and be filtered by an arbitrary value. For this (questionable) purpose, there are already these two tests as well as another in unit/v2/test_registry_client.py (def test_image_get_is_public_v2).\n\nIf these \"should be\" expanded, I would argue that this changeset is not the appropriate place.","commit_id":"4ff08bb30960abe6803b0f37581fada18c84fd1c"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"62bbd41c7e6a9861ba040d252543a3cd311902ab","unresolved":false,"context_lines":[{"line_number":2266,"context_line":""},{"line_number":2267,"context_line":"    def _create_image(self, name, owner, members\u003dNone):"},{"line_number":2268,"context_line":"        image \u003d build_image_fixture(name\u003dname, owner\u003downer,"},{"line_number":2269,"context_line":"                                    visibility\u003d\u0027private\u0027)"},{"line_number":2270,"context_line":"        self.image_ids[(owner, name)] \u003d image[\u0027id\u0027]"},{"line_number":2271,"context_line":"        self.db_api.image_create(self.admin_ctx, image)"},{"line_number":2272,"context_line":"        for member in members or []:"}],"source_content_type":"text/x-python","patch_set":40,"id":"fa6399be_4f1c66c1","line":2269,"range":{"start_line":2269,"start_character":48,"end_line":2269,"end_character":55},"updated":"2016-10-19 17:21:39.000000000","message":"should this be \u0027shared\u0027 for consistency?","commit_id":"4ff08bb30960abe6803b0f37581fada18c84fd1c"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"f3386bee470d97990572adccef0f1d3d456db69b","unresolved":false,"context_lines":[{"line_number":2266,"context_line":""},{"line_number":2267,"context_line":"    def _create_image(self, name, owner, members\u003dNone):"},{"line_number":2268,"context_line":"        image \u003d build_image_fixture(name\u003dname, owner\u003downer,"},{"line_number":2269,"context_line":"                                    visibility\u003d\u0027private\u0027)"},{"line_number":2270,"context_line":"        self.image_ids[(owner, name)] \u003d image[\u0027id\u0027]"},{"line_number":2271,"context_line":"        self.db_api.image_create(self.admin_ctx, image)"},{"line_number":2272,"context_line":"        for member in members or []:"}],"source_content_type":"text/x-python","patch_set":40,"id":"fa6399be_0cab591e","line":2269,"range":{"start_line":2269,"start_character":48,"end_line":2269,"end_character":55},"in_reply_to":"fa6399be_4f1c66c1","updated":"2016-10-19 17:45:12.000000000","message":"good point, thank you. i\u0027ll address these in a new patch shortly.","commit_id":"4ff08bb30960abe6803b0f37581fada18c84fd1c"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"bbc7d083f8dd73195802605e98ec84be2a1764e7","unresolved":false,"context_lines":[{"line_number":1158,"context_line":"        result \u003d self.db_api.is_image_visible(ctxt2, image)"},{"line_number":1159,"context_line":"        self.assertFalse(result)"},{"line_number":1160,"context_line":""},{"line_number":1161,"context_line":"    def test_is_community_image_visible(self):"},{"line_number":1162,"context_line":"        TENANT1 \u003d str(uuid.uuid4())"},{"line_number":1163,"context_line":"        TENANT2 \u003d str(uuid.uuid4())"},{"line_number":1164,"context_line":"        ctxt1 \u003d context.RequestContext(is_admin\u003dFalse, tenant\u003dTENANT1,"}],"source_content_type":"text/x-python","patch_set":48,"id":"da6895a0_549cf8bf","line":1161,"updated":"2016-10-25 23:57:56.000000000","message":"maybe a nit, but naming the test variables meaningfully would help clarity of the test:\n\nctxt1 is a kind of owners_ctxt\nctxt2 is a kind of viewing_ctxt\n\nThis would make the intent of the test clearer.","commit_id":"f455a23f8c82dafa27fafce867e5e0b4f2878ed7"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"d383c9892f16b7052bd137d7baf39ef41a8071d8","unresolved":false,"context_lines":[{"line_number":1158,"context_line":"        result \u003d self.db_api.is_image_visible(ctxt2, image)"},{"line_number":1159,"context_line":"        self.assertFalse(result)"},{"line_number":1160,"context_line":""},{"line_number":1161,"context_line":"    def test_is_community_image_visible(self):"},{"line_number":1162,"context_line":"        TENANT1 \u003d str(uuid.uuid4())"},{"line_number":1163,"context_line":"        TENANT2 \u003d str(uuid.uuid4())"},{"line_number":1164,"context_line":"        ctxt1 \u003d context.RequestContext(is_admin\u003dFalse, tenant\u003dTENANT1,"}],"source_content_type":"text/x-python","patch_set":48,"id":"ba5da102_a659da5c","line":1161,"in_reply_to":"da6895a0_549cf8bf","updated":"2016-10-28 14:02:52.000000000","message":"Done","commit_id":"f455a23f8c82dafa27fafce867e5e0b4f2878ed7"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"120cc3c993b39c498a173165e83b8b97aad8974f","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        self.assertEqual(0, image[\u0027min_ram\u0027])"},{"line_number":159,"context_line":"        self.assertEqual(0, image[\u0027min_disk\u0027])"},{"line_number":160,"context_line":"        self.assertIsNone(image[\u0027owner\u0027])"},{"line_number":161,"context_line":"        self.assertEqual(\u0027shared\u0027, image[\u0027visibility\u0027])"},{"line_number":162,"context_line":"        self.assertIsNone(image[\u0027size\u0027])"},{"line_number":163,"context_line":"        self.assertIsNone(image[\u0027checksum\u0027])"},{"line_number":164,"context_line":"        self.assertIsNone(image[\u0027disk_format\u0027])"}],"source_content_type":"text/x-python","patch_set":51,"id":"9a629dbe_14c20ee9","line":161,"updated":"2016-11-11 15:25:07.000000000","message":"This is not equal to our API specifications.","commit_id":"8f55ebafbf6dd1e2ec2a839824e3a73c73fbded2"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"6f483489748bbaba940507c5fe93967bf9d26af7","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        self.assertEqual(0, image[\u0027min_ram\u0027])"},{"line_number":159,"context_line":"        self.assertEqual(0, image[\u0027min_disk\u0027])"},{"line_number":160,"context_line":"        self.assertIsNone(image[\u0027owner\u0027])"},{"line_number":161,"context_line":"        self.assertEqual(\u0027shared\u0027, image[\u0027visibility\u0027])"},{"line_number":162,"context_line":"        self.assertIsNone(image[\u0027size\u0027])"},{"line_number":163,"context_line":"        self.assertIsNone(image[\u0027checksum\u0027])"},{"line_number":164,"context_line":"        self.assertIsNone(image[\u0027disk_format\u0027])"}],"source_content_type":"text/x-python","patch_set":51,"id":"9a629dbe_b4c23d51","line":161,"in_reply_to":"9a629dbe_14c20ee9","updated":"2016-11-11 17:22:45.000000000","message":"\u0027shared\u0027 visibility is functionality identical to the old is_public\u003dfalse.","commit_id":"8f55ebafbf6dd1e2ec2a839824e3a73c73fbded2"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"120cc3c993b39c498a173165e83b8b97aad8974f","unresolved":false,"context_lines":[{"line_number":1085,"context_line":"                                       auth_token\u003d\u0027user:%s:user\u0027 % TENANT2,"},{"line_number":1086,"context_line":"                                       owner_is_tenant\u003dFalse)"},{"line_number":1087,"context_line":"        UUIDX \u003d str(uuid.uuid4())"},{"line_number":1088,"context_line":"        # We need a shared image and context.owner should not match image"},{"line_number":1089,"context_line":"        # owner"},{"line_number":1090,"context_line":"        self.db_api.image_create(ctxt1, {\u0027id\u0027: UUIDX,"},{"line_number":1091,"context_line":"                                         \u0027status\u0027: \u0027queued\u0027,"}],"source_content_type":"text/x-python","patch_set":51,"id":"9a629dbe_346c7207","line":1088,"updated":"2016-11-11 15:25:07.000000000","message":"!","commit_id":"8f55ebafbf6dd1e2ec2a839824e3a73c73fbded2"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"6f483489748bbaba940507c5fe93967bf9d26af7","unresolved":false,"context_lines":[{"line_number":1085,"context_line":"                                       auth_token\u003d\u0027user:%s:user\u0027 % TENANT2,"},{"line_number":1086,"context_line":"                                       owner_is_tenant\u003dFalse)"},{"line_number":1087,"context_line":"        UUIDX \u003d str(uuid.uuid4())"},{"line_number":1088,"context_line":"        # We need a shared image and context.owner should not match image"},{"line_number":1089,"context_line":"        # owner"},{"line_number":1090,"context_line":"        self.db_api.image_create(ctxt1, {\u0027id\u0027: UUIDX,"},{"line_number":1091,"context_line":"                                         \u0027status\u0027: \u0027queued\u0027,"}],"source_content_type":"text/x-python","patch_set":51,"id":"9a629dbe_d4a331b0","line":1088,"in_reply_to":"9a629dbe_346c7207","updated":"2016-11-11 17:22:45.000000000","message":"?","commit_id":"8f55ebafbf6dd1e2ec2a839824e3a73c73fbded2"}],"glance/tests/functional/test_bin_glance_cache_manage.py":[{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"5e7cef1f3decce935ea2676fa58915883d9d27e0","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                         data[\u0027image\u0027][\u0027checksum\u0027])"},{"line_number":68,"context_line":"        self.assertEqual(FIVE_KB, data[\u0027image\u0027][\u0027size\u0027])"},{"line_number":69,"context_line":"        self.assertEqual(name, data[\u0027image\u0027][\u0027name\u0027])"},{"line_number":70,"context_line":"        self.assertTrue(\u0027public\u0027, data[\u0027image\u0027][\u0027visibility\u0027])"},{"line_number":71,"context_line":"        return data[\u0027image\u0027][\u0027id\u0027]"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def is_image_cached(self, image_id):"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a8ec9b2_dca1c247","line":70,"updated":"2016-09-16 23:22:11.000000000","message":"^^^ that should be assertEqual not assertTrue.\n\nI knew something had to be weird when this test passed so easily.","commit_id":"ec924fd15045d91500e50d86cf0e6849c04ce217"}],"glance/tests/functional/v2/test_images.py":[{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"62bbd41c7e6a9861ba040d252543a3cd311902ab","unresolved":false,"context_lines":[{"line_number":1288,"context_line":"        data \u003d jsonutils.dumps(doc)"},{"line_number":1289,"context_line":"        response \u003d requests.patch(path, headers\u003dheaders, data\u003ddata)"},{"line_number":1290,"context_line":"        self.assertEqual(200, response.status_code)"},{"line_number":1291,"context_line":""},{"line_number":1292,"context_line":"    def test_owning_tenant_can_communitize_image(self):"},{"line_number":1293,"context_line":"        rules \u003d {"},{"line_number":1294,"context_line":"            \"context_is_admin\": \"role:admin\","}],"source_content_type":"text/x-python","patch_set":40,"id":"fa6399be_8a02ec07","line":1291,"updated":"2016-10-19 17:21:39.000000000","message":"I may have missed it, but is there a function test that non-owners can view community images by explicitly requesting them in the filter?","commit_id":"4ff08bb30960abe6803b0f37581fada18c84fd1c"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"f3386bee470d97990572adccef0f1d3d456db69b","unresolved":false,"context_lines":[{"line_number":1288,"context_line":"        data \u003d jsonutils.dumps(doc)"},{"line_number":1289,"context_line":"        response \u003d requests.patch(path, headers\u003dheaders, data\u003ddata)"},{"line_number":1290,"context_line":"        self.assertEqual(200, response.status_code)"},{"line_number":1291,"context_line":""},{"line_number":1292,"context_line":"    def test_owning_tenant_can_communitize_image(self):"},{"line_number":1293,"context_line":"        rules \u003d {"},{"line_number":1294,"context_line":"            \"context_is_admin\": \"role:admin\","}],"source_content_type":"text/x-python","patch_set":40,"id":"fa6399be_4c60f135","line":1291,"in_reply_to":"fa6399be_8a02ec07","updated":"2016-10-19 17:45:12.000000000","message":"Tests for the new community functionality have not been included yet.","commit_id":"4ff08bb30960abe6803b0f37581fada18c84fd1c"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"120cc3c993b39c498a173165e83b8b97aad8974f","unresolved":false,"context_lines":[{"line_number":187,"context_line":"            \u0027status\u0027: \u0027queued\u0027,"},{"line_number":188,"context_line":"            \u0027name\u0027: \u0027image-1\u0027,"},{"line_number":189,"context_line":"            \u0027tags\u0027: [],"},{"line_number":190,"context_line":"            \u0027visibility\u0027: \u0027shared\u0027,"},{"line_number":191,"context_line":"            \u0027self\u0027: \u0027/v2/images/%s\u0027 % image_id,"},{"line_number":192,"context_line":"            \u0027protected\u0027: False,"},{"line_number":193,"context_line":"            \u0027file\u0027: \u0027/v2/images/%s/file\u0027 % image_id,"}],"source_content_type":"text/x-python","patch_set":51,"id":"9a629dbe_b457a224","line":190,"updated":"2016-11-11 15:25:07.000000000","message":"These test changes are clear indication that we are breaking our API.","commit_id":"8f55ebafbf6dd1e2ec2a839824e3a73c73fbded2"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"6f483489748bbaba940507c5fe93967bf9d26af7","unresolved":false,"context_lines":[{"line_number":187,"context_line":"            \u0027status\u0027: \u0027queued\u0027,"},{"line_number":188,"context_line":"            \u0027name\u0027: \u0027image-1\u0027,"},{"line_number":189,"context_line":"            \u0027tags\u0027: [],"},{"line_number":190,"context_line":"            \u0027visibility\u0027: \u0027shared\u0027,"},{"line_number":191,"context_line":"            \u0027self\u0027: \u0027/v2/images/%s\u0027 % image_id,"},{"line_number":192,"context_line":"            \u0027protected\u0027: False,"},{"line_number":193,"context_line":"            \u0027file\u0027: \u0027/v2/images/%s/file\u0027 % image_id,"}],"source_content_type":"text/x-python","patch_set":51,"id":"9a629dbe_34b2ade5","line":190,"in_reply_to":"9a629dbe_b457a224","updated":"2016-11-11 17:22:45.000000000","message":"The new \u0027shared\u0027 visibility is functionality identical to the old \u0027private\u0027 visibility.","commit_id":"8f55ebafbf6dd1e2ec2a839824e3a73c73fbded2"}],"glance/tests/unit/test_db.py":[{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"bbc7d083f8dd73195802605e98ec84be2a1764e7","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        filters \u003d {\u0027visibility\u0027: \u0027private\u0027}"},{"line_number":252,"context_line":"        images \u003d self.image_repo.list(filters\u003dfilters)"},{"line_number":253,"context_line":"        self.assertEqual(0, len(images))"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def test_list_shared_images(self):"},{"line_number":256,"context_line":"        filters \u003d {\u0027visibility\u0027: \u0027shared\u0027}"},{"line_number":257,"context_line":"        images \u003d self.image_repo.list(filters\u003dfilters)"}],"source_content_type":"text/x-python","patch_set":48,"id":"da6895a0_149520dd","line":254,"updated":"2016-10-25 23:57:56.000000000","message":"add a community image test?","commit_id":"f455a23f8c82dafa27fafce867e5e0b4f2878ed7"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"d383c9892f16b7052bd137d7baf39ef41a8071d8","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        filters \u003d {\u0027visibility\u0027: \u0027private\u0027}"},{"line_number":252,"context_line":"        images \u003d self.image_repo.list(filters\u003dfilters)"},{"line_number":253,"context_line":"        self.assertEqual(0, len(images))"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def test_list_shared_images(self):"},{"line_number":256,"context_line":"        filters \u003d {\u0027visibility\u0027: \u0027shared\u0027}"},{"line_number":257,"context_line":"        images \u003d self.image_repo.list(filters\u003dfilters)"}],"source_content_type":"text/x-python","patch_set":48,"id":"ba5da102_063526f6","line":254,"in_reply_to":"da6895a0_149520dd","updated":"2016-10-28 14:02:52.000000000","message":"Skipping this one, at least for now, since you had said you don\u0027t care that much and at this point I\u0027m very worried about running out of time.","commit_id":"f455a23f8c82dafa27fafce867e5e0b4f2878ed7"}],"glance/tests/unit/test_migrations.py":[{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"8aa93bf6ba836eefd8ec1fc2c9e188585bbc5f7b","unresolved":false,"context_lines":[{"line_number":1491,"context_line":""},{"line_number":1492,"context_line":"    def _pre_upgrade_045(self, engine):"},{"line_number":1493,"context_line":"        images \u003d db_utils.get_table(engine, \u0027images\u0027)"},{"line_number":1494,"context_line":""},{"line_number":1495,"context_line":"        now \u003d datetime.datetime.now()"},{"line_number":1496,"context_line":"        public_temp \u003d dict(deleted\u003dFalse,"},{"line_number":1497,"context_line":"                           created_at\u003dnow,"}],"source_content_type":"text/x-python","patch_set":57,"id":"1a6eadb0_7c30329f","line":1494,"updated":"2016-12-19 22:29:34.000000000","message":"please add a few comment lines to improve readability, the important parts of each effective operation in this method are obscured by the many many many lines, and the use of _temp in the variable names for the data dicts seems unnecessary. something like:\n\n# Insert a public image record\n\nnit: you could eliminate unnecessary lines by specifying now as a func one time instead of as a value for each usage:\n\n * `now \u003d datetime.datetime.now`\n * and below in each case just use `now()`\n\nalternatively you could just use the same created_at value for multiple images, they don\u0027t need to be distinct for this test.","commit_id":"c015b7cb9e623a862a2b730b3e8da85a36f4905d"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"16451e4c955e0a3d7efe934ef3ae781f9d8474fa","unresolved":false,"context_lines":[{"line_number":1491,"context_line":""},{"line_number":1492,"context_line":"    def _pre_upgrade_045(self, engine):"},{"line_number":1493,"context_line":"        images \u003d db_utils.get_table(engine, \u0027images\u0027)"},{"line_number":1494,"context_line":""},{"line_number":1495,"context_line":"        now \u003d datetime.datetime.now()"},{"line_number":1496,"context_line":"        public_temp \u003d dict(deleted\u003dFalse,"},{"line_number":1497,"context_line":"                           created_at\u003dnow,"}],"source_content_type":"text/x-python","patch_set":57,"id":"da4df55a_b3113bb2","line":1494,"in_reply_to":"1a6eadb0_7c30329f","updated":"2016-12-22 01:24:19.000000000","message":"Done","commit_id":"c015b7cb9e623a862a2b730b3e8da85a36f4905d"}],"glance/tests/unit/v1/test_registry_api.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"120cc3c993b39c498a173165e83b8b97aad8974f","unresolved":false,"context_lines":[{"line_number":1225,"context_line":"    def test_create_image(self):"},{"line_number":1226,"context_line":"        \"\"\"Tests that the /images POST registry API creates the image\"\"\""},{"line_number":1227,"context_line":""},{"line_number":1228,"context_line":"        fixture \u003d self.get_minimal_fixture(is_public\u003dTrue)"},{"line_number":1229,"context_line":"        body \u003d jsonutils.dump_as_bytes(dict(image\u003dfixture))"},{"line_number":1230,"context_line":""},{"line_number":1231,"context_line":"        res \u003d self.get_api_response_ext(http.OK, body\u003dbody,"}],"source_content_type":"text/x-python","patch_set":51,"id":"9a629dbe_df17cf42","line":1228,"updated":"2016-11-11 15:25:07.000000000","message":"Why changing this?","commit_id":"8f55ebafbf6dd1e2ec2a839824e3a73c73fbded2"},{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"6f483489748bbaba940507c5fe93967bf9d26af7","unresolved":false,"context_lines":[{"line_number":1225,"context_line":"    def test_create_image(self):"},{"line_number":1226,"context_line":"        \"\"\"Tests that the /images POST registry API creates the image\"\"\""},{"line_number":1227,"context_line":""},{"line_number":1228,"context_line":"        fixture \u003d self.get_minimal_fixture(is_public\u003dTrue)"},{"line_number":1229,"context_line":"        body \u003d jsonutils.dump_as_bytes(dict(image\u003dfixture))"},{"line_number":1230,"context_line":""},{"line_number":1231,"context_line":"        res \u003d self.get_api_response_ext(http.OK, body\u003dbody,"}],"source_content_type":"text/x-python","patch_set":51,"id":"9a629dbe_f41755a0","line":1228,"in_reply_to":"9a629dbe_df17cf42","updated":"2016-11-11 17:22:45.000000000","message":"Because the minimal_fixture\u0027s default behaviour is to assume and a create an internal value for \u0027visibility\u0027 unless told otherwise. \u0027visibility\u0027 is not compatible with v1, so to ensure that \u0027is_public\u0027 is used internally in this case (instead of \u0027visibility\u0027), we specify it here.\n\nFunctionally, this changes nothing from any previous test behaviour.","commit_id":"8f55ebafbf6dd1e2ec2a839824e3a73c73fbded2"}]}
