)]}'
{"glance/common/utils.py":[{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"3b435b95e66dcd2ad5b00f69cf463bb8c3dff655","unresolved":false,"context_lines":[{"line_number":517,"context_line":"    except UnicodeError:"},{"line_number":518,"context_line":"        try:"},{"line_number":519,"context_line":"            error \u003d str(exc)"},{"line_number":520,"context_line":"        except UnicodeError:"},{"line_number":521,"context_line":"            error \u003d (_(\"Caught \u0027%(exception)s\u0027 exception.\") %"},{"line_number":522,"context_line":"                     {\"exception\": exc.__class__.__name__})"},{"line_number":523,"context_line":"    return strutils.safe_encode(error, errors\u003d\u0027ignore\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2Fqbo%3D","line":520,"updated":"2013-07-25 15:09:49.000000000","message":"I don\u0027t see how str() can raise UnicodeError. I see UnicodeEncodeError however:\n\n    \u003e\u003e\u003e str(Exception(u\u0027\\u2022\u0027))\n    Traceback (most recent call last):\n      File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\n    UnicodeEncodeError: \u0027ascii\u0027 codec can\u0027t encode character u\u0027\\u2022\u0027 in position 0: ordinal not in range(128)","commit_id":"dbc013d224273a5aa9132ad699670f64d3d15b2c"},{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"e73b950ee5b2e433abe1fad12eac39050b8d8df3","unresolved":false,"context_lines":[{"line_number":517,"context_line":"    except UnicodeError:"},{"line_number":518,"context_line":"        try:"},{"line_number":519,"context_line":"            error \u003d str(exc)"},{"line_number":520,"context_line":"        except UnicodeError:"},{"line_number":521,"context_line":"            error \u003d (_(\"Caught \u0027%(exception)s\u0027 exception.\") %"},{"line_number":522,"context_line":"                     {\"exception\": exc.__class__.__name__})"},{"line_number":523,"context_line":"    return strutils.safe_encode(error, errors\u003d\u0027ignore\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2FqVo%3D","line":520,"in_reply_to":"AAAAQn%2F%2Fqbo%3D","updated":"2013-07-25 15:34:16.000000000","message":"Duh, UnicodeEncodeError (and UnicodeDecodeError) is a subclass of UnicodeError. Ok, that makes more sense.","commit_id":"dbc013d224273a5aa9132ad699670f64d3d15b2c"}],"glance/store/base.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"8c916ae5441612370a6918e132e440dc1a2b7c3d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            self.configure_add()"},{"line_number":42,"context_line":"        except exception.BadStoreConfiguration as e:"},{"line_number":43,"context_line":"            msg \u003d _(\"Failed to configure store correctly: %s \""},{"line_number":44,"context_line":"                    \"Disabling add method.\") % unicode(e)"},{"line_number":45,"context_line":"            LOG.warn(msg)"},{"line_number":46,"context_line":"            self.add \u003d self.add_disabled"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2Ff%2Bs%3D","line":44,"updated":"2013-07-17 14:13:36.000000000","message":"pls, use the strutils module. (openstack.common). Also, everything going to stdout should be encoded, not decoded, otherwise it could fail during the encode process.","commit_id":"0ee469e37e93e36ad1135489a2d6df8af2beb075"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"1b83f0e933c523f99c89a2795b021a58bd57c193","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            self.configure_add()"},{"line_number":42,"context_line":"        except exception.BadStoreConfiguration as e:"},{"line_number":43,"context_line":"            msg \u003d _(\"Failed to configure store correctly: %s \""},{"line_number":44,"context_line":"                    \"Disabling add method.\") % unicode(e)"},{"line_number":45,"context_line":"            LOG.warn(msg)"},{"line_number":46,"context_line":"            self.add \u003d self.add_disabled"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2F%2Bi0%3D","line":44,"in_reply_to":"AAAAP3%2F%2Ff%2Bs%3D","updated":"2013-07-18 05:17:47.000000000","message":"Done","commit_id":"0ee469e37e93e36ad1135489a2d6df8af2beb075"}],"glance/tests/unit/common/test_utils.py":[{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"3b435b95e66dcd2ad5b00f69cf463bb8c3dff655","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                                  keyf.name, keyf.name)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def test_exception_to_str(self):"},{"line_number":210,"context_line":"        class FakeExcpetion(Exception):"},{"line_number":211,"context_line":"            def __str__(self):"},{"line_number":212,"context_line":"                raise UnicodeError()"},{"line_number":213,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2Fqcc%3D","line":210,"updated":"2013-07-25 15:09:49.000000000","message":"Typo in \"FakeExcpetion\"","commit_id":"dbc013d224273a5aa9132ad699670f64d3d15b2c"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"620a6e6870cdaa2f98523b6affaa89467c23676b","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                                  keyf.name, keyf.name)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def test_exception_to_str(self):"},{"line_number":210,"context_line":"        class FakeExcpetion(Exception):"},{"line_number":211,"context_line":"            def __str__(self):"},{"line_number":212,"context_line":"                raise UnicodeError()"},{"line_number":213,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2FpK4%3D","line":210,"in_reply_to":"AAAAQn%2F%2Fqcc%3D","updated":"2013-07-25 22:14:04.000000000","message":"good catch. I will fix it in next PS.","commit_id":"dbc013d224273a5aa9132ad699670f64d3d15b2c"}]}