)]}'
{"glance/async/flows/base_import.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f491602f2fbbf929ad710987321091adac8fcce6","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            # place that other tasks can consume as well."},{"line_number":158,"context_line":"            stdout, stderr \u003d putils.trycmd(\u0027qemu-img\u0027, \u0027info\u0027,"},{"line_number":159,"context_line":"                                           \u0027--output\u003djson\u0027, path,"},{"line_number":160,"context_line":"                                           prlimit\u003dutils.QEMU_IMG_PROC_LIMITS,"},{"line_number":161,"context_line":"                                           log_errors\u003dputils.LOG_ALL_ERRORS)"},{"line_number":162,"context_line":"        except OSError as exc:"},{"line_number":163,"context_line":"            with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_f9d58f1b","line":160,"updated":"2016-12-06 20:56:14.000000000","message":"Note that prlimit was added to oslo.concurrency in 3.4.0:\n\nhttps://github.com/openstack/oslo.concurrency/commit/b2e78569c5cabc9582c02aacff1ce2a5e186c3ab\n\nThe upper-constraint on oslo.concurrency in liberty is 2.6.1:\n\nhttps://github.com/openstack/requirements/blob/stable/liberty/upper-constraints.txt#L190\n\nI think we backported that change though, otherwise this would fail. I know about this because we had to deal with it in nova too.\n\nYeah this is the liberty backport:\n\nhttps://review.openstack.org/#/c/327630/\n\nThat was released in 2.6.1, so the upper-constraint works.\n\nThe minimum on oslo.concurrency in liberty is 2.3.0 though:\n\nhttps://github.com/openstack/requirements/blob/stable/liberty/global-requirements.txt#L83\n\nSo anyone that shipped with the minimums and upgrades to this code is going to fail.\n\nI guess the difference with nova is in nova I don\u0027t think we used the trycmd method, however, trycmd will return \u0027\u0027 for stdout if it fails and will fail below if you\u0027re using json.loads(\u0027\u0027):\n\n\u003e\u003e\u003e json.loads(\u0027\u0027)\nTraceback (most recent call last):\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\n  File \"C:\\Python27\\lib\\json\\__init__.py\", line 339, in loads\n    return _default_decoder.decode(s)\n  File \"C:\\Python27\\lib\\json\\decoder.py\", line 364, in decode\n    obj, end \u003d self.raw_decode(s, idx\u003d_w(s, 0).end())\n  File \"C:\\Python27\\lib\\json\\decoder.py\", line 382, in raw_decode\n    raise ValueError(\"No JSON object could be decoded\")\nValueError: No JSON object could be decoded\n\u003e\u003e\u003e\n\nThis is the change we went with on the nova side for liberty:\n\nhttps://review.openstack.org/#/c/327624/\n\nAnd the release note points out you need oslo.concurrency\u003e\u003d2.6.1 for the fix. However, nova doesn\u0027t fail if you don\u0027t have the required minimum version, but you get an error when hitting this code:\n\nhttps://review.openstack.org/#/c/327624/14/nova/virt/images.py","commit_id":"58311904a73f931404416649dc6ed3958adc59c8"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"ab6eff66b58e1c9913b3d46ea388cb85777d4adf","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            # place that other tasks can consume as well."},{"line_number":158,"context_line":"            stdout, stderr \u003d putils.trycmd(\u0027qemu-img\u0027, \u0027info\u0027,"},{"line_number":159,"context_line":"                                           \u0027--output\u003djson\u0027, path,"},{"line_number":160,"context_line":"                                           prlimit\u003dutils.QEMU_IMG_PROC_LIMITS,"},{"line_number":161,"context_line":"                                           log_errors\u003dputils.LOG_ALL_ERRORS)"},{"line_number":162,"context_line":"        except OSError as exc:"},{"line_number":163,"context_line":"            with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_6a50985f","line":160,"in_reply_to":"3a71b18c_f9d58f1b","updated":"2016-12-07 16:04:05.000000000","message":"Done in https://review.openstack.org/408196","commit_id":"58311904a73f931404416649dc6ed3958adc59c8"}]}