)]}'
{"glance/store/filesystem.py":[{"author":{"_account_id":7703,"name":"Venkatesh Sampath","email":"venkatesh.sampath@outlook.com","username":"venkateshsampath"},"change_message_id":"0eef71e6aa56ed232d4cf9af7d3e54ede3fd5c30","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            LOG.error(_(\u0027The path for the metadata file %s could not be \u0027"},{"line_number":177,"context_line":"                        \u0027opened: %s  An empty dictionary will be returned \u0027"},{"line_number":178,"context_line":"                        \u0027to the client.\u0027"},{"line_number":179,"context_line":"                        % (CONF.filesystem_store_metadata_file, unicode(ioe))))"},{"line_number":180,"context_line":"            return {}"},{"line_number":181,"context_line":"        except Exception as ex:"},{"line_number":182,"context_line":"            LOG.exception(_(\u0027An error occured processing the storage systems \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FAD8%3D","line":179,"updated":"2013-08-08 16:47:22.000000000","message":"Hi Johannas, \n\nPlease help me to understand this. \nIsn\u0027t _(msg) returns a unicoded string as it internally invokes translation.ugettext(msg)? Would that not suffice?","commit_id":"f8ef68763ce93c86e166911123498fdc4afeb6f6"},{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"51879159095829331723580e18490d560ac0db60","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            LOG.error(_(\u0027The path for the metadata file %s could not be \u0027"},{"line_number":177,"context_line":"                        \u0027opened: %s  An empty dictionary will be returned \u0027"},{"line_number":178,"context_line":"                        \u0027to the client.\u0027"},{"line_number":179,"context_line":"                        % (CONF.filesystem_store_metadata_file, unicode(ioe))))"},{"line_number":180,"context_line":"            return {}"},{"line_number":181,"context_line":"        except Exception as ex:"},{"line_number":182,"context_line":"            LOG.exception(_(\u0027An error occured processing the storage systems \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2B%2F%2FA%3D","line":179,"in_reply_to":"AAAAQn%2F%2FAD8%3D","updated":"2013-08-08 17:03:23.000000000","message":"I\u0027m not sure if you\u0027re talking about removing the .message attribute or the use of unicode().\n\nAs far as the .message attribute is concerned, it\u0027s deprecated in Python 2.6 and removed in Python 3. The replacement is to use the built-in unicode/str conversion (but using str() is a bad idea for i18n reasons).\n\nAs far as the use of unicode(), it\u0027s not strictly necessary to explicitly convert to a unicode type if _() guarantees to always return a unicode type.\n\nThat\u0027s not normally the case with gettext, but it looks like glance does setup gettext to always do that.\n\nHowever, your comment did make me look closer at the use there and I noticed it\u0027s using _() incorrectly. The string interpolation needs to happen after the call to _() and not before. I\u0027ll push up another patch with that fixed.","commit_id":"f8ef68763ce93c86e166911123498fdc4afeb6f6"}]}