)]}'
{"glance/common/config.py":[{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"1dc244889a22d1aee46d3d1d51682671c5875cb3","unresolved":false,"context_lines":[{"line_number":667,"context_line":"The location where Glance API node saves staged image data"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"This option is for Glance internal use only. Glance will save the"},{"line_number":670,"context_line":"image data uploaded by the user to the staging during the image"},{"line_number":671,"context_line":"import process. This is also the location task flows will look that"},{"line_number":672,"context_line":"image data from if the staging option was used."},{"line_number":673,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_ecb56831","line":670,"range":{"start_line":670,"start_character":39,"end_line":670,"end_character":46},"updated":"2016-10-28 22:40:18.000000000","message":"s/staging/staging area/","commit_id":"5bf382608750361455c0c3620da949b1a91ffe06"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"cdb63e577c38ebde899f2c1eb6ca2129c039b8d7","unresolved":false,"context_lines":[{"line_number":667,"context_line":"The location where Glance API node saves staged image data"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"This option is for Glance internal use only. Glance will save the"},{"line_number":670,"context_line":"image data uploaded by the user to the staging during the image"},{"line_number":671,"context_line":"import process. This is also the location task flows will look that"},{"line_number":672,"context_line":"image data from if the staging option was used."},{"line_number":673,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_192b7c95","line":670,"range":{"start_line":670,"start_character":39,"end_line":670,"end_character":46},"in_reply_to":"ba5da102_0376ad05","updated":"2016-11-01 17:21:13.000000000","message":"This is a total nit, but probably be better to specifically say: \"...the staging endpoint...\"","commit_id":"5bf382608750361455c0c3620da949b1a91ffe06"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"63b7bf782338e7fc9e7e2355dabc38509af30df6","unresolved":false,"context_lines":[{"line_number":667,"context_line":"The location where Glance API node saves staged image data"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"This option is for Glance internal use only. Glance will save the"},{"line_number":670,"context_line":"image data uploaded by the user to the staging during the image"},{"line_number":671,"context_line":"import process. This is also the location task flows will look that"},{"line_number":672,"context_line":"image data from if the staging option was used."},{"line_number":673,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_59fb3f7b","line":670,"range":{"start_line":670,"start_character":39,"end_line":670,"end_character":46},"in_reply_to":"ba5da102_192b7c95","updated":"2016-12-09 22:51:25.000000000","message":"\"staging area\" or \"staging endpoint\" reads better and conveys the idea fairly effectively. alternatively maybe \"staging point\" or omit, such as \u0027uploaded by the user during the image import process\u0027.\n\nI would prefer to use neither \"endpoint\" or \"cache\" or the like as those are technical terms which are not entirely accurate usages in this case and could contribute to confusion.\n\n\"the staging\" doesn\u0027t parse well for me.","commit_id":"5bf382608750361455c0c3620da949b1a91ffe06"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"a312b54796c6a43951cf894b424b7d22b775737e","unresolved":false,"context_lines":[{"line_number":667,"context_line":"The location where Glance API node saves staged image data"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"This option is for Glance internal use only. Glance will save the"},{"line_number":670,"context_line":"image data uploaded by the user to the staging during the image"},{"line_number":671,"context_line":"import process. This is also the location task flows will look that"},{"line_number":672,"context_line":"image data from if the staging option was used."},{"line_number":673,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_0376ad05","line":670,"range":{"start_line":670,"start_character":39,"end_line":670,"end_character":46},"in_reply_to":"ba5da102_ecb56831","updated":"2016-11-01 16:21:30.000000000","message":"the endpoint is \"staging\" not \"staging area\"","commit_id":"5bf382608750361455c0c3620da949b1a91ffe06"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"1dc244889a22d1aee46d3d1d51682671c5875cb3","unresolved":false,"context_lines":[{"line_number":668,"context_line":""},{"line_number":669,"context_line":"This option is for Glance internal use only. Glance will save the"},{"line_number":670,"context_line":"image data uploaded by the user to the staging during the image"},{"line_number":671,"context_line":"import process. This is also the location task flows will look that"},{"line_number":672,"context_line":"image data from if the staging option was used."},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"This option does not change the staging API endpoint by any means."},{"line_number":675,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_0c837c57","line":672,"range":{"start_line":671,"start_character":16,"end_line":672,"end_character":46},"updated":"2016-10-28 22:40:18.000000000","message":"This is also the location where task flows will look for image data, if this option is specified.","commit_id":"5bf382608750361455c0c3620da949b1a91ffe06"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"a312b54796c6a43951cf894b424b7d22b775737e","unresolved":false,"context_lines":[{"line_number":668,"context_line":""},{"line_number":669,"context_line":"This option is for Glance internal use only. Glance will save the"},{"line_number":670,"context_line":"image data uploaded by the user to the staging during the image"},{"line_number":671,"context_line":"import process. This is also the location task flows will look that"},{"line_number":672,"context_line":"image data from if the staging option was used."},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"This option does not change the staging API endpoint by any means."},{"line_number":675,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_63f5a955","line":672,"range":{"start_line":671,"start_character":16,"end_line":672,"end_character":46},"in_reply_to":"ba5da102_0c837c57","updated":"2016-11-01 16:21:30.000000000","message":"Nope, the \"staging option\" refers to the import call specifying if the image data is in \"staging\", external http-uri or in swift. As per the spec.","commit_id":"5bf382608750361455c0c3620da949b1a91ffe06"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"2322cb511f800c9c4f6bcc54616e16e79c4f9ebb","unresolved":false,"context_lines":[{"line_number":668,"context_line":""},{"line_number":669,"context_line":"This option is for Glance internal use only. Glance will save the"},{"line_number":670,"context_line":"image data uploaded by the user to the staging during the image"},{"line_number":671,"context_line":"import process. This is also the location task flows will look that"},{"line_number":672,"context_line":"image data from if the staging option was used."},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"This option does not change the staging API endpoint by any means."},{"line_number":675,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_fe06951a","line":672,"range":{"start_line":671,"start_character":16,"end_line":672,"end_character":46},"in_reply_to":"ba5da102_391a007e","updated":"2016-11-02 10:01:31.000000000","message":"Yes sorry, I do agree it does not make sense, just did not agree with your version of it.","commit_id":"5bf382608750361455c0c3620da949b1a91ffe06"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"cdb63e577c38ebde899f2c1eb6ca2129c039b8d7","unresolved":false,"context_lines":[{"line_number":668,"context_line":""},{"line_number":669,"context_line":"This option is for Glance internal use only. Glance will save the"},{"line_number":670,"context_line":"image data uploaded by the user to the staging during the image"},{"line_number":671,"context_line":"import process. This is also the location task flows will look that"},{"line_number":672,"context_line":"image data from if the staging option was used."},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"This option does not change the staging API endpoint by any means."},{"line_number":675,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_391a007e","line":672,"range":{"start_line":671,"start_character":16,"end_line":672,"end_character":46},"in_reply_to":"ba5da102_63f5a955","updated":"2016-11-01 17:21:13.000000000","message":"This sentence makes no grammatical sense as is written, specifically: \"...task flows will look that image data...\" \nI tried to re-phrase it as per my understanding and obviously failed. Please take a careful look and rewrite.","commit_id":"5bf382608750361455c0c3620da949b1a91ffe06"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"63b7bf782338e7fc9e7e2355dabc38509af30df6","unresolved":false,"context_lines":[{"line_number":668,"context_line":""},{"line_number":669,"context_line":"This option is for Glance internal use only. Glance will save the"},{"line_number":670,"context_line":"image data uploaded by the user to the staging during the image"},{"line_number":671,"context_line":"import process. This is also the location task flows will look that"},{"line_number":672,"context_line":"image data from if the staging option was used."},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"This option does not change the staging API endpoint by any means."},{"line_number":675,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_b9ae132c","line":672,"range":{"start_line":671,"start_character":16,"end_line":672,"end_character":46},"in_reply_to":"ba5da102_fe06951a","updated":"2016-12-09 22:51:25.000000000","message":"Could just omit this sentence safely. It stands to reason that this is where the task flows will look but doesn\u0027t necessarily need to be stated.","commit_id":"5bf382608750361455c0c3620da949b1a91ffe06"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"1dc244889a22d1aee46d3d1d51682671c5875cb3","unresolved":false,"context_lines":[{"line_number":676,"context_line":"NOTE: It is discouraged to use same path as [TASKS]/work_dir"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"NOTE: \u0027file:///\u003cpath\u003e\u0027 is the only option api_image_import flow"},{"line_number":679,"context_line":"will support on this first stage of MVP."},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"NOTE: The staging mount point needs to be shared FS between the"},{"line_number":682,"context_line":"Glance API nodes."}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_8c978c8f","line":679,"range":{"start_line":679,"start_character":36,"end_line":679,"end_character":39},"updated":"2016-10-28 22:40:18.000000000","message":"Q: what is MVP? Will this be clear to potential users of this option?","commit_id":"5bf382608750361455c0c3620da949b1a91ffe06"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"2322cb511f800c9c4f6bcc54616e16e79c4f9ebb","unresolved":false,"context_lines":[{"line_number":676,"context_line":"NOTE: It is discouraged to use same path as [TASKS]/work_dir"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"NOTE: \u0027file:///\u003cpath\u003e\u0027 is the only option api_image_import flow"},{"line_number":679,"context_line":"will support on this first stage of MVP."},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"NOTE: The staging mount point needs to be shared FS between the"},{"line_number":682,"context_line":"Glance API nodes."}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_d3370afd","line":679,"range":{"start_line":679,"start_character":36,"end_line":679,"end_character":39},"in_reply_to":"ba5da102_5465b9b2","updated":"2016-11-02 10:01:31.000000000","message":"I had no intention to have this note present when we get to the release. Now thinking it again it might have been bit too optimistic goal.","commit_id":"5bf382608750361455c0c3620da949b1a91ffe06"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"a312b54796c6a43951cf894b424b7d22b775737e","unresolved":false,"context_lines":[{"line_number":676,"context_line":"NOTE: It is discouraged to use same path as [TASKS]/work_dir"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"NOTE: \u0027file:///\u003cpath\u003e\u0027 is the only option api_image_import flow"},{"line_number":679,"context_line":"will support on this first stage of MVP."},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"NOTE: The staging mount point needs to be shared FS between the"},{"line_number":682,"context_line":"Glance API nodes."}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_a370a1dd","line":679,"range":{"start_line":679,"start_character":36,"end_line":679,"end_character":39},"in_reply_to":"ba5da102_8c978c8f","updated":"2016-11-01 16:21:30.000000000","message":"https://etherpad.openstack.org/p/glance-image-import-implementation-tactics \u0026 https://etherpad.openstack.org/p/glance-ocata-image-import-sync","commit_id":"5bf382608750361455c0c3620da949b1a91ffe06"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"cdb63e577c38ebde899f2c1eb6ca2129c039b8d7","unresolved":false,"context_lines":[{"line_number":676,"context_line":"NOTE: It is discouraged to use same path as [TASKS]/work_dir"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"NOTE: \u0027file:///\u003cpath\u003e\u0027 is the only option api_image_import flow"},{"line_number":679,"context_line":"will support on this first stage of MVP."},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"NOTE: The staging mount point needs to be shared FS between the"},{"line_number":682,"context_line":"Glance API nodes."}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_5465b9b2","line":679,"range":{"start_line":679,"start_character":36,"end_line":679,"end_character":39},"in_reply_to":"ba5da102_a370a1dd","updated":"2016-11-01 17:21:13.000000000","message":"I am not sure calling out spec discussion and implementation details in a config option is a good idea. I wonder what others think. Perhaps simply say \"initial implementation\" instead of \"first stage of MVP\"","commit_id":"5bf382608750361455c0c3620da949b1a91ffe06"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"1dc244889a22d1aee46d3d1d51682671c5875cb3","unresolved":false,"context_lines":[{"line_number":678,"context_line":"NOTE: \u0027file:///\u003cpath\u003e\u0027 is the only option api_image_import flow"},{"line_number":679,"context_line":"will support on this first stage of MVP."},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"NOTE: The staging mount point needs to be shared FS between the"},{"line_number":682,"context_line":"Glance API nodes."},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_2c868065","line":681,"range":{"start_line":681,"start_character":30,"end_line":681,"end_character":48},"updated":"2016-10-28 22:40:18.000000000","message":"Perhaps better to say: \"must be on a shared FS\" ?","commit_id":"5bf382608750361455c0c3620da949b1a91ffe06"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"63b7bf782338e7fc9e7e2355dabc38509af30df6","unresolved":false,"context_lines":[{"line_number":678,"context_line":"NOTE: \u0027file:///\u003cpath\u003e\u0027 is the only option api_image_import flow"},{"line_number":679,"context_line":"will support on this first stage of MVP."},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"NOTE: The staging mount point needs to be shared FS between the"},{"line_number":682,"context_line":"Glance API nodes."},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_b9cff354","line":681,"range":{"start_line":681,"start_character":30,"end_line":681,"end_character":48},"in_reply_to":"ba5da102_2c868065","updated":"2016-12-09 22:51:25.000000000","message":"also prefer \"must be\" here, and would prefer to spell out \u0027filesystem\u0027","commit_id":"5bf382608750361455c0c3620da949b1a91ffe06"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"1dc244889a22d1aee46d3d1d51682671c5875cb3","unresolved":false,"context_lines":[{"line_number":684,"context_line":"Possible values:"},{"line_number":685,"context_line":"    * String starting with \u0027file://\u0027 followed by FS path"},{"line_number":686,"context_line":""},{"line_number":687,"context_line":"Relation options:"},{"line_number":688,"context_line":"    * [TASKS]/work_dir"},{"line_number":689,"context_line":""},{"line_number":690,"context_line":"\"\"\")),"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_6c807847","line":687,"range":{"start_line":687,"start_character":0,"end_line":687,"end_character":8},"updated":"2016-10-28 22:40:18.000000000","message":"s/Relation/Related/","commit_id":"5bf382608750361455c0c3620da949b1a91ffe06"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"a312b54796c6a43951cf894b424b7d22b775737e","unresolved":false,"context_lines":[{"line_number":684,"context_line":"Possible values:"},{"line_number":685,"context_line":"    * String starting with \u0027file://\u0027 followed by FS path"},{"line_number":686,"context_line":""},{"line_number":687,"context_line":"Relation options:"},{"line_number":688,"context_line":"    * [TASKS]/work_dir"},{"line_number":689,"context_line":""},{"line_number":690,"context_line":"\"\"\")),"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_633849f0","line":687,"range":{"start_line":687,"start_character":0,"end_line":687,"end_character":8},"in_reply_to":"ba5da102_6c807847","updated":"2016-11-01 16:21:30.000000000","message":"ack; copypaste from above, no wonder it did look weird ;)","commit_id":"5bf382608750361455c0c3620da949b1a91ffe06"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"2b29d9d8a7f88f3f4854bbd6f8386f3ba060d83e","unresolved":false,"context_lines":[{"line_number":662,"context_line":"    * None"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"\"\"\")),"},{"line_number":665,"context_line":"    cfg.StrOpt(\u0027node_staging_uri\u0027,"},{"line_number":666,"context_line":"               default\u003d\u0027file:///tmp/staging/\u0027,"},{"line_number":667,"context_line":"               help\u003d_(\"\"\""},{"line_number":668,"context_line":"The location where Glance API node saves staged image data"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_cc8c8cdc","line":665,"updated":"2017-03-22 21:03:40.000000000","message":"I\u0027d like to see this option grouped under \n\n  [import_staging]\n\nor such a group. When the store options expand beyond filesystem we will need more configuration options for the specific driver and designating all of these options under a common group now makes sense to me.","commit_id":"e1a59dc9e3f1f46b6f012ba8afda8c7c024201c9"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"e14a38ca676d29b8c1a5120a161e9c1c58ba459c","unresolved":false,"context_lines":[{"line_number":665,"context_line":"    cfg.StrOpt(\u0027node_staging_uri\u0027,"},{"line_number":666,"context_line":"               default\u003d\u0027file:///tmp/staging/\u0027,"},{"line_number":667,"context_line":"               help\u003d_(\"\"\""},{"line_number":668,"context_line":"The location where Glance API node saves staged image data"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"This option is for Glance internal use only. Glance will save the"},{"line_number":671,"context_line":"image data uploaded by the user to \u0027staging\u0027 endpoint during the"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_a4263714","line":668,"range":{"start_line":668,"start_character":0,"end_line":668,"end_character":58},"updated":"2017-03-17 18:08:23.000000000","message":"Please use something like \"String representing the staging uri\" ..\nThe word \u0027location\u0027 might confuse an operator.\n\nPlease add a clearer format section.\n \u0027file://\u003cabsolute_dir_path\u003e\u0027","commit_id":"e1a59dc9e3f1f46b6f012ba8afda8c7c024201c9"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"2b29d9d8a7f88f3f4854bbd6f8386f3ba060d83e","unresolved":false,"context_lines":[{"line_number":665,"context_line":"    cfg.StrOpt(\u0027node_staging_uri\u0027,"},{"line_number":666,"context_line":"               default\u003d\u0027file:///tmp/staging/\u0027,"},{"line_number":667,"context_line":"               help\u003d_(\"\"\""},{"line_number":668,"context_line":"The location where Glance API node saves staged image data"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"This option is for Glance internal use only. Glance will save the"},{"line_number":671,"context_line":"image data uploaded by the user to \u0027staging\u0027 endpoint during the"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_4cb97ccb","line":668,"range":{"start_line":668,"start_character":0,"end_line":668,"end_character":58},"in_reply_to":"1a1ced50_a4263714","updated":"2017-03-22 21:03:40.000000000","message":"perhaps\n\n...the staging uri used by Glance API nodes to save staged image data","commit_id":"e1a59dc9e3f1f46b6f012ba8afda8c7c024201c9"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"ab44de80777a50831c3e380b83c820bf366dae1d","unresolved":false,"context_lines":[{"line_number":671,"context_line":"image data uploaded by the user to \u0027staging\u0027 endpoint during the"},{"line_number":672,"context_line":"image import process."},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"This option does not change the \u0027staging\u0027 API endpoint by any means."},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"NOTE: It is discouraged to use same path as [TASKS]/work_dir"},{"line_number":677,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_a665f1b5","line":674,"range":{"start_line":674,"start_character":31,"end_line":674,"end_character":54},"updated":"2017-03-09 22:08:53.000000000","message":"what is the \u0027staging\u0027 API endpoint exactly?","commit_id":"e1a59dc9e3f1f46b6f012ba8afda8c7c024201c9"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"2b29d9d8a7f88f3f4854bbd6f8386f3ba060d83e","unresolved":false,"context_lines":[{"line_number":671,"context_line":"image data uploaded by the user to \u0027staging\u0027 endpoint during the"},{"line_number":672,"context_line":"image import process."},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"This option does not change the \u0027staging\u0027 API endpoint by any means."},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"NOTE: It is discouraged to use same path as [TASKS]/work_dir"},{"line_number":677,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_6cc0f850","line":674,"range":{"start_line":674,"start_character":31,"end_line":674,"end_character":54},"in_reply_to":"9a30ddce_a665f1b5","updated":"2017-03-22 21:03:40.000000000","message":"Alex, the API endpoint is defined in https://review.openstack.org/#/c/443636/","commit_id":"e1a59dc9e3f1f46b6f012ba8afda8c7c024201c9"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"e14a38ca676d29b8c1a5120a161e9c1c58ba459c","unresolved":false,"context_lines":[{"line_number":675,"context_line":""},{"line_number":676,"context_line":"NOTE: It is discouraged to use same path as [TASKS]/work_dir"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"NOTE: \u0027file:///\u003cpath\u003e\u0027 is the only option api_image_import flow"},{"line_number":679,"context_line":"will support on this first stage."},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"NOTE: The staging path must be on shared filesystem between the"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_84885be9","line":678,"range":{"start_line":678,"start_character":6,"end_line":678,"end_character":22},"updated":"2017-03-17 18:08:23.000000000","message":"file://\u003cabsolute_dir_path\u003e","commit_id":"e1a59dc9e3f1f46b6f012ba8afda8c7c024201c9"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"2b29d9d8a7f88f3f4854bbd6f8386f3ba060d83e","unresolved":false,"context_lines":[{"line_number":676,"context_line":"NOTE: It is discouraged to use same path as [TASKS]/work_dir"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"NOTE: \u0027file:///\u003cpath\u003e\u0027 is the only option api_image_import flow"},{"line_number":679,"context_line":"will support on this first stage."},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"NOTE: The staging path must be on shared filesystem between the"},{"line_number":682,"context_line":"Glance API nodes."}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_ace910b9","line":679,"range":{"start_line":679,"start_character":13,"end_line":679,"end_character":32},"updated":"2017-03-22 21:03:40.000000000","message":"at this time\n\n(the use of stage is overloaded)","commit_id":"e1a59dc9e3f1f46b6f012ba8afda8c7c024201c9"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"2b29d9d8a7f88f3f4854bbd6f8386f3ba060d83e","unresolved":false,"context_lines":[{"line_number":678,"context_line":"NOTE: \u0027file:///\u003cpath\u003e\u0027 is the only option api_image_import flow"},{"line_number":679,"context_line":"will support on this first stage."},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"NOTE: The staging path must be on shared filesystem between the"},{"line_number":682,"context_line":"Glance API nodes."},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_8c34544a","line":681,"range":{"start_line":681,"start_character":52,"end_line":681,"end_character":63},"updated":"2017-03-22 21:03:40.000000000","message":"s/between the/available to all/","commit_id":"e1a59dc9e3f1f46b6f012ba8afda8c7c024201c9"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"ab44de80777a50831c3e380b83c820bf366dae1d","unresolved":false,"context_lines":[{"line_number":678,"context_line":"NOTE: \u0027file:///\u003cpath\u003e\u0027 is the only option api_image_import flow"},{"line_number":679,"context_line":"will support on this first stage."},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"NOTE: The staging path must be on shared filesystem between the"},{"line_number":682,"context_line":"Glance API nodes."},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"Possible values:"},{"line_number":685,"context_line":"    * String starting with \u0027file://\u0027 followed by FS path"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_c66bc5ef","line":682,"range":{"start_line":681,"start_character":1,"end_line":682,"end_character":17},"updated":"2017-03-09 22:08:53.000000000","message":"I\u0027m slightly confused here. If the path must be on a shared FS, then does it make sense to have \u0027node\u0027 as part of the name of this option?","commit_id":"e1a59dc9e3f1f46b6f012ba8afda8c7c024201c9"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"2b29d9d8a7f88f3f4854bbd6f8386f3ba060d83e","unresolved":false,"context_lines":[{"line_number":678,"context_line":"NOTE: \u0027file:///\u003cpath\u003e\u0027 is the only option api_image_import flow"},{"line_number":679,"context_line":"will support on this first stage."},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"NOTE: The staging path must be on shared filesystem between the"},{"line_number":682,"context_line":"Glance API nodes."},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"Possible values:"},{"line_number":685,"context_line":"    * String starting with \u0027file://\u0027 followed by FS path"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_ec24e80d","line":682,"range":{"start_line":681,"start_character":1,"end_line":682,"end_character":17},"in_reply_to":"9a30ddce_c66bc5ef","updated":"2017-03-22 21:03:40.000000000","message":"+1, staging_uri does the job just fine.","commit_id":"e1a59dc9e3f1f46b6f012ba8afda8c7c024201c9"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"e14a38ca676d29b8c1a5120a161e9c1c58ba459c","unresolved":false,"context_lines":[{"line_number":682,"context_line":"Glance API nodes."},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"Possible values:"},{"line_number":685,"context_line":"    * String starting with \u0027file://\u0027 followed by FS path"},{"line_number":686,"context_line":""},{"line_number":687,"context_line":"Related options:"},{"line_number":688,"context_line":"    * [TASKS]/work_dir"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_c46a531a","line":685,"range":{"start_line":685,"start_character":49,"end_line":685,"end_character":51},"updated":"2017-03-17 18:08:23.000000000","message":"absolute FS directory path","commit_id":"e1a59dc9e3f1f46b6f012ba8afda8c7c024201c9"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"2b29d9d8a7f88f3f4854bbd6f8386f3ba060d83e","unresolved":false,"context_lines":[{"line_number":682,"context_line":"Glance API nodes."},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"Possible values:"},{"line_number":685,"context_line":"    * String starting with \u0027file://\u0027 followed by FS path"},{"line_number":686,"context_line":""},{"line_number":687,"context_line":"Related options:"},{"line_number":688,"context_line":"    * [TASKS]/work_dir"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_8c8294c6","line":685,"range":{"start_line":685,"start_character":49,"end_line":685,"end_character":51},"in_reply_to":"1a1ced50_c46a531a","updated":"2017-03-22 21:03:40.000000000","message":"I think we should avoid abbreviation of filesystem as FS throughout operator-facing documentation. In-code-only comments I don\u0027t care a lot.","commit_id":"e1a59dc9e3f1f46b6f012ba8afda8c7c024201c9"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"ab44de80777a50831c3e380b83c820bf366dae1d","unresolved":false,"context_lines":[{"line_number":689,"context_line":"    * [DEFAULT]/enable_image_import (*deprecated*)"},{"line_number":690,"context_line":""},{"line_number":691,"context_line":"\"\"\")),"},{"line_number":692,"context_line":"    # TODO(jokke): Change the default to True in Pike"},{"line_number":693,"context_line":"    cfg.BoolOpt(\u0027enable_image_import\u0027,"},{"line_number":694,"context_line":"                default\u003dFalse,"},{"line_number":695,"context_line":"                deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_e6152949","line":692,"range":{"start_line":692,"start_character":4,"end_line":692,"end_character":53},"updated":"2017-03-09 22:08:53.000000000","message":"s/Pike/Queens/ ?","commit_id":"e1a59dc9e3f1f46b6f012ba8afda8c7c024201c9"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"e14a38ca676d29b8c1a5120a161e9c1c58ba459c","unresolved":false,"context_lines":[{"line_number":704,"context_line":"Enables the Image Import workflow introduced in Ocata"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"As \u0027[DEFAULT]/node_staging_uri\u0027 is required for the Image"},{"line_number":707,"context_line":"Import, it\u0027s disabled per default in Pike, enabled per"},{"line_number":708,"context_line":"default in Queens and removed in R. This allows Glance to"},{"line_number":709,"context_line":"operate with previous version configs upon upgrade."},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"Setting this option to True will enable the endpoints related"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_9f77c2d3","line":708,"range":{"start_line":707,"start_character":8,"end_line":708,"end_character":35},"updated":"2017-03-17 18:08:23.000000000","message":"Not sure we need to give this info in the config options help text. Maybe move it to deprecated_reason?","commit_id":"e1a59dc9e3f1f46b6f012ba8afda8c7c024201c9"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"2b29d9d8a7f88f3f4854bbd6f8386f3ba060d83e","unresolved":false,"context_lines":[{"line_number":704,"context_line":"Enables the Image Import workflow introduced in Ocata"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"As \u0027[DEFAULT]/node_staging_uri\u0027 is required for the Image"},{"line_number":707,"context_line":"Import, it\u0027s disabled per default in Pike, enabled per"},{"line_number":708,"context_line":"default in Queens and removed in R. This allows Glance to"},{"line_number":709,"context_line":"operate with previous version configs upon upgrade."},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"Setting this option to True will enable the endpoints related"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_6c50f832","line":708,"range":{"start_line":707,"start_character":8,"end_line":708,"end_character":35},"in_reply_to":"1a1ced50_9f77c2d3","updated":"2017-03-22 21:03:40.000000000","message":"agreed, in deprecated_reason is sufficient","commit_id":"e1a59dc9e3f1f46b6f012ba8afda8c7c024201c9"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"2b29d9d8a7f88f3f4854bbd6f8386f3ba060d83e","unresolved":false,"context_lines":[{"line_number":712,"context_line":"to Image Import Refactoring work."},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"Related options:"},{"line_number":715,"context_line":"    * [DEFUALT]/node_staging_uri\"\"\")),"},{"line_number":716,"context_line":"]"},{"line_number":717,"context_line":""},{"line_number":718,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_ecaea82c","line":715,"range":{"start_line":715,"start_character":7,"end_line":715,"end_character":14},"updated":"2017-03-22 21:03:40.000000000","message":"typo","commit_id":"e1a59dc9e3f1f46b6f012ba8afda8c7c024201c9"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"2f153f1fd1e198f2284aa53882317dc266da9d9d","unresolved":false,"context_lines":[{"line_number":676,"context_line":"NOTE: It is discouraged to use same path as [TASKS]/work_dir"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"NOTE: \u0027file:///\u003cpath\u003e\u0027 is the only option api_image_import flow"},{"line_number":679,"context_line":"will support on this first stage."},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"NOTE: The staging path must be on shared filesystem between the"},{"line_number":682,"context_line":"Glance API nodes."}],"source_content_type":"text/x-python","patch_set":6,"id":"3f044301_5cbc84db","line":679,"range":{"start_line":679,"start_character":13,"end_line":679,"end_character":32},"updated":"2017-05-05 10:03:09.000000000","message":"perhaps: \"with this implementation\" rather than overload \"stage\". Adding, use of \"first\" is presuming a lot, as a lot of things could happen before this config is updated to support other options.","commit_id":"a3fa874a6c62bf6f05846fae949d7eceabbdfb9a"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"8018629fe2e83bb2293e082c791fce362f37e514","unresolved":false,"context_lines":[{"line_number":676,"context_line":"NOTE: It is discouraged to use same path as [TASKS]/work_dir"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"NOTE: \u0027file:///\u003cpath\u003e\u0027 is the only option api_image_import flow"},{"line_number":679,"context_line":"will support on this first stage."},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"NOTE: The staging path must be on shared filesystem between the"},{"line_number":682,"context_line":"Glance API nodes."}],"source_content_type":"text/x-python","patch_set":6,"id":"3f044301_cc6d6d99","line":679,"range":{"start_line":679,"start_character":13,"end_line":679,"end_character":32},"in_reply_to":"3f044301_3e8ac81a","updated":"2017-05-07 03:56:16.000000000","message":"Not being able to attend meetings right now, I\u0027m going to beg your patience. \n\nIf there is agreement that a change is appropriate and record the noted change in a following change set or just acknowledge it here, that\u0027s good enough for me. I just want to ensure it isn\u0027t lost. I\u0027m recording it here and now because this is the opportunity to identify those things.","commit_id":"a3fa874a6c62bf6f05846fae949d7eceabbdfb9a"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"aaa8bc8ecf6bd0b44d32947eb689cc0ceae57d4d","unresolved":false,"context_lines":[{"line_number":676,"context_line":"NOTE: It is discouraged to use same path as [TASKS]/work_dir"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"NOTE: \u0027file:///\u003cpath\u003e\u0027 is the only option api_image_import flow"},{"line_number":679,"context_line":"will support on this first stage."},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"NOTE: The staging path must be on shared filesystem between the"},{"line_number":682,"context_line":"Glance API nodes."}],"source_content_type":"text/x-python","patch_set":6,"id":"3f044301_3e8ac81a","line":679,"range":{"start_line":679,"start_character":13,"end_line":679,"end_character":32},"in_reply_to":"3f044301_5cbc84db","updated":"2017-05-05 14:10:47.000000000","message":"As this is the first commit of the chain, I\u0027d urge the nitpicking to move to the future changes after the MVP merges as agreed on the meeting this was discussed last. http://eavesdrop.openstack.org/meetings/glance/2017/glance.2017-03-30-14.00.log.html\n\nObviously unless you feel this is the most pressing matter and reson to prevent this work to move forward.","commit_id":"a3fa874a6c62bf6f05846fae949d7eceabbdfb9a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"143bfec2fa7dc64979730c73509959ce1d33a3c8","unresolved":false,"context_lines":[{"line_number":676,"context_line":"NOTE: It is discouraged to use same path as [TASKS]/work_dir"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"NOTE: \u0027file:///\u003cpath\u003e\u0027 is the only option api_image_import flow"},{"line_number":679,"context_line":"will support on this first stage."},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"NOTE: The staging path must be on shared filesystem between the"},{"line_number":682,"context_line":"Glance API nodes."}],"source_content_type":"text/x-python","patch_set":6,"id":"3f044301_d7711f78","line":679,"range":{"start_line":679,"start_character":13,"end_line":679,"end_character":32},"in_reply_to":"3f044301_cc6d6d99","updated":"2017-05-11 16:29:45.000000000","message":"Let\u0027s leave this as is for now.  We\u0027ll be reviewing the text once more before release after everything is more stable.","commit_id":"a3fa874a6c62bf6f05846fae949d7eceabbdfb9a"}]}