)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"792f4bbe01c3427a9b2d0a545f6c88414eb57ba7","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Previously cache client used endpoints from service catalog to"},{"line_number":10,"context_line":"request cache items from node. It works perfectly on devstack"},{"line_number":11,"context_line":"but it doesn\u0027t work when OS clous is deployed with HA"},{"line_number":12,"context_line":"(3/5/7 controllers). We need to use -H option instead. This"},{"line_number":13,"context_line":"option by default interacts with localhost endpoint which is"},{"line_number":14,"context_line":"applicable in most cases because cache management client is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba5da102_691e0e0d","line":11,"range":{"start_line":11,"start_character":25,"end_line":11,"end_character":33},"updated":"2016-11-03 16:34:51.000000000","message":"\"an OpenStack cloud\"","commit_id":"11c6c55239691d2dbe04826c2a20f0f59d2eba76"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"792f4bbe01c3427a9b2d0a545f6c88414eb57ba7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Previously cache client used endpoints from service catalog to"},{"line_number":10,"context_line":"request cache items from node. It works perfectly on devstack"},{"line_number":11,"context_line":"but it doesn\u0027t work when OS clous is deployed with HA"},{"line_number":12,"context_line":"(3/5/7 controllers). We need to use -H option instead. This"},{"line_number":13,"context_line":"option by default interacts with localhost endpoint which is"},{"line_number":14,"context_line":"applicable in most cases because cache management client is"},{"line_number":15,"context_line":"dependant on glance code and usually placed on controller."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I355fb36d9af7e06dcac70b8263dc1a2b915ffc8f"},{"line_number":18,"context_line":"Closes-Bug: #1634486"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba5da102_6c753cc9","line":15,"range":{"start_line":12,"start_character":55,"end_line":15,"end_character":58},"updated":"2016-11-03 16:34:51.000000000","message":"This option makes cache management client interact with the local endpoint which is more appropriate as image cache is local to each node/controller.","commit_id":"11c6c55239691d2dbe04826c2a20f0f59d2eba76"}],"glance/tests/unit/test_image_cache_client.py":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"792f4bbe01c3427a9b2d0a545f6c88414eb57ba7","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def test_get_client_not_using_service_catalog(self):"},{"line_number":120,"context_line":"        self.assertFalse(client.get_client(self.host).configure_via_auth)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def test_get_client_client_configuration_error(self):"},{"line_number":123,"context_line":"        self.assertRaises(exception.ClientConfigurationError,"},{"line_number":124,"context_line":"                          client.get_client, self.host, username\u003d\u0027name\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_ec686cf7","line":121,"updated":"2016-11-03 16:34:51.000000000","message":"I\u0027m wondering if it\u0027d be better to mock out required objects here and assert that the following call is not made?\nhttps://github.com/openstack/glance/blob/master/glance/common/client.py#L348-L349","commit_id":"11c6c55239691d2dbe04826c2a20f0f59d2eba76"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"1f3a5de9813b7375e8239a6d64368df1df04b1f2","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    def test_get_client_not_using_service_catalog(self):"},{"line_number":120,"context_line":"        self.assertFalse(client.get_client(self.host).configure_via_auth)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def test_get_client_using_provided_host(self):"},{"line_number":123,"context_line":"        cli \u003d client.get_client(self.host)"},{"line_number":124,"context_line":"        cli._do_request \u003d mock.MagicMock()"},{"line_number":125,"context_line":"        cli.configure_from_url \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_a35578c7","line":122,"updated":"2016-11-07 16:06:30.000000000","message":"Why can\u0027t we merge this and the above test case? They are both testing the same thing.","commit_id":"d67feb26a69626d6bea14dfbf97cdfa1a5168537"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"1f3a5de9813b7375e8239a6d64368df1df04b1f2","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    def test_get_client_not_using_service_catalog(self):"},{"line_number":120,"context_line":"        self.assertFalse(client.get_client(self.host).configure_via_auth)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def test_get_client_using_provided_host(self):"},{"line_number":123,"context_line":"        cli \u003d client.get_client(self.host)"},{"line_number":124,"context_line":"        cli._do_request \u003d mock.MagicMock()"},{"line_number":125,"context_line":"        cli.configure_from_url \u003d mock.MagicMock()"},{"line_number":126,"context_line":"        cli.do_request(\"GET\", \"/queued_images\")"},{"line_number":127,"context_line":"        self.assertFalse(cli.configure_from_url.called)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def test_get_client_client_configuration_error(self):"},{"line_number":130,"context_line":"        self.assertRaises(exception.ClientConfigurationError,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_23ca48a2","line":127,"range":{"start_line":122,"start_character":3,"end_line":127,"end_character":55},"updated":"2016-11-07 16:06:30.000000000","message":"This test won\u0027t work as expected unless we mock the management url as well. Try turning the configure_via_auth to False and run the test again to reproduce. It should fail, but it won\u0027t.\n\nHence, I suggest adding the following.\n\n cli.auth_plugin.management_url \u003d mock.MagicMock()","commit_id":"d67feb26a69626d6bea14dfbf97cdfa1a5168537"}]}